[monitoring-plugins] check_ifstatus: perfdata bug

Jan Wagner git at monitoring-plugins.org
Mon Jul 21 00:20:08 CEST 2014


 Module: monitoring-plugins
 Branch: master
 Commit: 69b719aa2e3bd8dfd643d7cbe60e6e165d5279ea
 Author: Jan Wagner <waja at cyconet.org>
   Date: Mon Sep 30 17:55:22 2013 +0200
    URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=69b719a

check_ifstatus: perfdata bug

The perfdata output violates the current Nagios Plugin Development Guidelines
(http://nagiosplug.sourceforge.net/developer-guidelines.html#AEN202 :
"space separated list of label/value pairs").

Thus the Addon PNP did not read the perdata correctly.

The patch replaces the commas with spaces in the perfdata output.

Many thanks to Patric Wust.
---
Closes #1169 and #721.

---

 THANKS.in                         | 1 +
 plugins-scripts/check_ifstatus.pl | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/THANKS.in b/THANKS.in
index 883387e..43ba182 100644
--- a/THANKS.in
+++ b/THANKS.in
@@ -323,3 +323,4 @@ Eric J. Mislivec
 Jean-Claude Computing
 Andy Brist
 Mikael Falkvidd
+Patric Wust
diff --git a/plugins-scripts/check_ifstatus.pl b/plugins-scripts/check_ifstatus.pl
index fb17d98..709ad17 100755
--- a/plugins-scripts/check_ifstatus.pl
+++ b/plugins-scripts/check_ifstatus.pl
@@ -221,7 +221,7 @@ foreach $key (keys %ifStatus) {
 			$ifexclude,
 			$ifunused);
    }
-my $perfdata = sprintf("up=%d,down=%d,dormant=%d,excluded=%d,unused=%d",$ifup,$ifdown,$ifdormant,$ifexclude,$ifunused);
+my $perfdata = sprintf("up=%d down=%d dormant=%d excluded=%d unused=%d",$ifup,$ifdown,$ifdormant,$ifexclude,$ifunused);
 print ("$state: $answer |$perfdata\n");
 exit $ERRORS{$state};
 



More information about the Commits mailing list