[Nagiosplug-devel] [ nagiosplug-Patches-778644 ] check_http cookies and keep-alive support

[SourceForge.net]

Patches item #778644, was opened at 2003-07-27 12:58
Message generated for change (Comment added) made by trbmaker
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=778644&group_id=29880

Category: Enhancement
Group: None
>Status: Closed
Resolution: None
Priority: 5
Submitted By: Dmitri Smirnov (trbmaker)
Assigned to: Ton Voon (tonvoon)
Summary: check_http cookies and keep-alive support

Initial Comment:
Finally found a problem with my initial patch. Some IIS 
servers are not respond if Keep-Alive header supplied in 
request.
I've made new patch for check_http 1.3.1 with 'Keep-
Alive' disabled by default (option '-k' to enable).

Patch attached below.

-----Original Message-----
From: Voon, Ton [mailto:Ton.Voon at egg.com] 
Sent: Tuesday, July 15, 2003 9:04 AM
To: Dmitri Smirnov; nagiosplug-
devel at lists.sourceforge.net
Subject: RE: [Nagiosplug-devel] check_http cookie and 
app-proxy support

Dmitri,

Thanks very much for your patch. I'm sorry it has taken 
so long to look at it.

I've given it a try and it seems to work okay with sites 
that do set cookies. However, it seems to fail when a 
site does not check for cookies - it just hangs when 
querying the site. I think there's a bug in your patch 
somewhere?

If you do update your patch, please post on sourceforge 
so we can keep track of it: 
http://sourceforge.net/tracker/?
group_id=29880&atid=397599

Thanks,
Ton

> -----Original Message-----
> From: Dmitri Smirnov 
[mailto:Dmitri.Smirnov at fusepoint.com]
> Sent: Monday, July 07, 2003 6:04 PM
> To: nagiosplug-devel at lists.sourceforge.net
> Subject: [Nagiosplug-devel] check_http cookie and 
app-proxy support
> 
> 
> Hi guys,
>  
> I've found a number of sites on our infrastructure that 
require 
> check_http plugin to have cookie support for sessions 
management and 
> 'Connection: Keep-Alive' in HTTP header to work 
correctly.
> Below is a little patch for check_http (latest from 
CVS) I've made.
> Will apriciate, guys, if you will review and incorporate 
such 
> functionality in standard check_http (wrapped by cmd 
arguments 
> probably).
> 
> Dmitri
> 

----------------------------------------------------------------------

>Comment By: Dmitri Smirnov (trbmaker)
Date: 2003-11-04 21:36

Message:
Logged In: YES 
user_id=720709

Sorry, guys, check_http changed too much during last few 
weeks and I just realized how bad was my initial patch. 
I don't have time to put cookies-related changes inside the 
new check_http - hope someone will do it one day. 
Plus I have a feeling that libcurl is the right choice for 
check_http if transaction monitor will be implemented one day.

----------------------------------------------------------------------

Comment By: Ton Voon (tonvoon)
Date: 2003-09-15 04:18

Message:
Logged In: YES 
user_id=664364

Dmitri,

Thanks for this patch, but I'm having trouble adding it into 
check_http.c. Can you provide a unified diff against CVS 
HEAD?

Ton

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=778644&group_id=29880