[Nagiosplug-devel] [ nagiosplug-Patches-774019 ] Major check_oracle reorg - + new getopts style arg handling

[SourceForge.net]

Patches item #774019, was opened at 2003-07-19 03:34
Message generated for change (Settings changed) made by opensides
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=774019&group_id=29880

Category: Enhancement
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: John Marquart (vaix)
>Assigned to: Benoit Mortier (opensides)
Summary: Major check_oracle reorg  - + new getopts style arg handling

Initial Comment:
This is my attempt at re-organizing the check_oracle
plugin to enable easier modifications/updates - as well
as 1 new feature (the reason for my re-organization).

Reorg:

1)  Command line argument handling has been supplemented:
     A) getopts style handling has been implemented
     B)  old style args still work - however require a
leading '--'

2)   All "checks" (i.e. cache, tns, login, etc) have
been turned 
      into functions.  - this enables argument handling
to be 
      independant of actual check code

3)   All "checks" - now use set variables instead of passed
      arguments - this makes the code easier to read &
manage

4)   "Chaining" - w/ changes 1-3, it is now easier to
combine
      options into chains - rather than individual checks.


New:

Extent checking - this new option (-e || --extents) is
the first
real excercise of the above mentioned new functionality.

When invoked as -e (w/ no other getopts style checks) or 
--extents - it checks the entire oracle instance for
tables that cannot be extended - due to insufficient
tablespace.

When invoked as -e w/ the -T argument (-T = tablespace
check) - it checks the tablespace for available space -
and then checks to see if the tablespace in question
can be extended.


----
This is a pretty large change - it nearly doubles the
existing code base (partially in backwards
compatibility support).  I have uploaded the entire new
"oracle.sh" - since the diff is larger.

If required - i can break this into smaller iterative
patches - and submit them sequentially  en mass. 
(unfotunately my zeal prevented me from doing it that
way to begin w/)

I really think that this re-organization - or a not
dissimilar one will encourate / enable easier addition
of funtionality as well as making debugging
/modification of existing functions 
simpler.

Please let me know what you think - I intend to send
this to the developer list as well (as specified in the
guidelines).

-john marquart (aka vaix)   

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=774019&group_id=29880