[Nagiosplug-devel] [ nagiosplug-Patches-925295 ] check_disk_smb: compare_levels_after_kMG_decoding

[SourceForge.net]

Patches item #925295, was opened at 2004-03-29 08:36
Message generated for change (Settings changed) made by sghosh
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=925295&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: neil prockter (orangepeel)
>Assigned to: Subhendu Ghosh (sghosh)
Summary: check_disk_smb: compare_levels_after_kMG_decoding

Initial Comment:
Hi

in order to avoid

Argument "500M" isn't numeric in numeric gt (>) at
./check_disk_smb_experimental line 96.
Argument "1000M" isn't numeric in numeric gt (>) at
./check_disk_smb_experimental line 96.

type warnings from check_disk_smb I propose the
following patch

This moves the comparing of warn and crit to after the
kMG have been
decoded, using the _type variables to decide whether to
compare

Additionally allows mixing of kMG (e.g. -w 1000M -c 500k)

Not sure if warn being percent and crit being actual
should be considered, would need to examin the output
to determine share size first

Neil

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=925295&group_id=29880