[Nagiosplug-devel] check_load arg parsing bugfix and cleanup
seanius at seanius.net
Fri Jun 3 06:47:16 CEST 2005
On Mon, May 30, 2005 at 04:22:30PM +0200, Andreas Ericsson wrote:
> Also for async safety reasons, but the plugins should only call
> exit_code = np_runcmd(command, &chld_out, &chld_err, flags);
> and never worry about anything else (the flags parameter is a new
> addition which makes it possible for plugins decide if they want the
> output->line array populated or not).
cool. i see that as being a generally helpful parameter.
> The output structure is fairly general and can be used for other things
> as well (getting data from a network socket, reading files, etc. etc.)
something that would be nice to see would be to have this extended to
manage not just output, but also input. specifically, what comes to
mind are the various check_tcp derived plugins where there's a specific
order of send-recieve operations. or perhaps there's a need for a
different datastructure to handle this?
anyway, i'm going to hold off on the applying runcmd patches for the
time being, as i won't have time to majorly audit this for the next
3 weeks or so. i'm definitely planning on re-visiting this then, if
someone else hasn't already picked up the ball on this by then.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 189 bytes
Desc: Digital signature
More information about the Devel