[Nagiosplug-devel] [ nagiosplug-Patches-1153148 ] long long support for check_swap on release 1.3

[SourceForge.net]

Patches item #1153148, was opened at 2005-02-28 00:05
Message generated for change (Comment added) made by tonvoon
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1153148&group_id=29880

Category: Bugfix
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Carlo Marcelo Arenas Belon (carenas)
>Assigned to: Ton Voon (tonvoon)
Summary: long long support for check_swap on release 1.3

Initial Comment:
using an unsigned long int and therefore overflowing
for swap bigger than 2^32 bytes.

still is_intnonneg util function could wrongly assume
that the parameter  is not in the right range but my
guess is that it is better to fix the parametrized
parameter to also allow KB, MB and such instead of
forcing the user to fit it as an integer so i left it
untouched.

----------------------------------------------------------------------

>Comment By: Ton Voon (tonvoon)
Date: 2005-03-04 22:26

Message:
Logged In: YES 
user_id=664364

Carlo,

I'm very interested in this patch. Two things:

- could you provide a patch against CVS HEAD? 1.9 is a very old version
- is there a reason to prefer long long against float, other than performance 
reasons? My feeling is to "keep it simple" if preferable

Ton

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1153148&group_id=29880