[Nagiosplug-devel] [ nagiosplug-Patches-1119917 ] Added ipv4/ipv6 options to check_ntp

[SourceForge.net]

Patches item #1119917, was opened at 2005-02-10 09:46
Message generated for change (Comment added) made by tonvoon
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1119917&group_id=29880

Category: Enhancement
Group: None
Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: Seaworthy (mrseaworthy)
Assigned to: Ton Voon (tonvoon)
Summary: Added ipv4/ipv6 options to check_ntp

Initial Comment:
The options -4 and -6 now specify the protocol to use.
This addition was made because the script failed in the 
original version when contacting a server over ipv6.
The enhancement makes use of the -46 options of 
ntpdate and ntpq.
The original version of check_ntp I used was 1.20 and I 
made this version 1.30.
Also i made some minor adjustments, like newlines and 
comments on the new options in the help output.


----------------------------------------------------------------------

>Comment By: Ton Voon (tonvoon)
Date: 2005-03-08 06:21

Message:
Logged In: YES 
user_id=664364

Merijn,

Is this still an issue then? Does the CVS version work correctly?

Ton

----------------------------------------------------------------------

Comment By: Seaworthy (mrseaworthy)
Date: 2005-03-07 10:01

Message:
Logged In: YES 
user_id=1178781

The reason I added the default for ipv4 is that without anuy 
parameters the default for ntpdate and ntpq is ipv6 which 
caused my servers to show errors (because Windows does 
not support IPv6 NTP :|)

----------------------------------------------------------------------

Comment By: Ton Voon (tonvoon)
Date: 2005-03-04 21:51

Message:
Logged In: YES 
user_id=664364

Merijn,

Thanks for the patch. This is useful, so it is now committed to CVS 
HEAD. I've made a change where the default is not to add either -4 nor -6 
for backward compatibility, but I can't test this from my home system. Can 
you confirm this works correctly.

Also, I've removed your copyright. As a rule, we don't put copyright into 
plugins, but we credit you in the CVS comments and in our list of 
contributors.

BTW, a unified diff (-u) or contextual diff (-c) is more helpful than the 
default line by line.

Ton

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1119917&group_id=29880