From noreply at sourceforge.net Sun May 1 12:51:13 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun May 1 12:51:13 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1189822 ] No way to change perl location Message-ID: Bugs item #1189822, was opened at 2005-04-25 17:11 Message generated for change (Settings changed) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1189822&group_id=29880 Category: None Group: snapshot tarball Status: Open Resolution: None Priority: 5 Submitted By: Code Monkey (duckhead) >Assigned to: M. Sean Finney (seanius) Summary: No way to change perl location Initial Comment: It would be wonderful if there were a way to specify a --with-perl option at configure time, to change perl interpreter to /usr/local/bin/perl, for example. This is particularly useful in the case where people have frequently installed their own perl, and left the vendor's perl in /usr/bin . In my particular case, this is done all the time on Solaris boxes. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1189822&group_id=29880 From noreply at sourceforge.net Sun May 1 12:55:02 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun May 1 12:55:02 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1189822 ] No way to change perl location Message-ID: Bugs item #1189822, was opened at 2005-04-25 17:11 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1189822&group_id=29880 Category: None Group: snapshot tarball >Status: Closed Resolution: None Priority: 5 Submitted By: Code Monkey (duckhead) Assigned to: M. Sean Finney (seanius) Summary: No way to change perl location Initial Comment: It would be wonderful if there were a way to specify a --with-perl option at configure time, to change perl interpreter to /usr/local/bin/perl, for example. This is particularly useful in the case where people have frequently installed their own perl, and left the vendor's perl in /usr/bin . In my particular case, this is done all the time on Solaris boxes. ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-05-01 15:53 Message: Logged In: YES user_id=226838 this problem is now fixed in cvs. thank you for your report. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1189822&group_id=29880 From noreply at sourceforge.net Sun May 1 12:57:10 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun May 1 12:57:10 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-903461 ] check_nwstat generates ipv6 calls (error) Message-ID: Bugs item #903461, was opened at 2004-02-24 09:14 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=903461&group_id=29880 Category: None Group: Release (specify) Status: Open Resolution: None Priority: 5 Submitted By: Alex (faucon) Assigned to: Nobody/Anonymous (nobody) Summary: check_nwstat generates ipv6 calls (error) Initial Comment: Short story : check_nwstat is doing 2 X AAAA request and 1 X A request to my DNS server since version 1.3.99 (1.13). Details and tests : Linux server RedHat9. DNS server Netware With check_nwstat v1.3.99 or more recent, my DNS server is showing that my Nagios server is doing 2 X AAAA request (ip6) and 1 X A request (ip4). I tested with version 1.3.1 of the plugins, and there is no problem there. (but features in latest release are needed). I tested with other plugins and with ping, and everything is fine. Here is a peace of the logs. ---------------------- ***** QH_Proc: query received from 10.1.0.137 QH_ns_req: Query for (srv-ndps1.cslaval.qc.ca) of type aaaa Domain Name "srv-ndps1.cslaval.qc.ca" found in authoritative cache zone "cslaval.qc.ca" Send a UDP Reply to 10.1.0.137 ***** QH_Proc: query received from 10.1.0.137 QH_ns_req: Query for (srv-educ1.cslaval.qc.ca) of type aaaa Domain Name "srv-educ1.cslaval.qc.ca" found in authoritative cache zone "cslaval.qc.ca" Send a UDP Reply to 10.1.0.137 ***** QH_Proc: query received from 10.1.0.137 QH_ns_req: Query for (srv-sec1.cslaval.qc.ca) of type aaaa Domain Name "srv-sec1.cslaval.qc.ca" found in authoritative cache zone "cslaval.qc.ca" Send a UDP Reply to 10.1.0.137 ***** QH_Proc: query received from 10.1.0.137 QH_ns_req: Query for (srv-ndps1.cslaval.qc.ca) of type aaaa Domain Name "srv-ndps1.cslaval.qc.ca" found in authoritative cache zone "cslaval.qc.ca" Send a UDP Reply to 10.1.0.137 ***** QH_Proc: query received from 10.1.0.137 QH_ns_req: Query for (srv-educ1.cslaval.qc.ca) of type a Domain Name "srv-educ1.cslaval.qc.ca" found in authoritative cache zone "cslaval.qc.ca" Send a UDP Reply to 10.1.0.137 ***** QH_Proc: query received from 10.1.0.137 QH_ns_req: Query for (srv-sec1.cslaval.qc.ca) of type aaaa Domain Name "srv-sec1.cslaval.qc.ca" found in authoritative cache zone "cslaval.qc.ca" Send a UDP Reply to 10.1.0.137 ***** QH_Proc: query received from 10.1.0.137 QH_ns_req: Query for (srv-ndps1.cslaval.qc.ca) of type a Domain Name "srv-ndps1.cslaval.qc.ca" found in authoritative cache zone "cslaval.qc.ca" Send a UDP Reply to 10.1.0.137 ***** QH_Proc: query received from 10.1.0.137 QH_ns_req: Query for (srv-sec1.cslaval.qc.ca) of type a Domain Name "srv-sec1.cslaval.qc.ca" found in authoritative cache zone "cslaval.qc.ca" Send a UDP Reply to 10.1.0.137 --------------------------------- ---------------------------------------------------------------------- >Comment By: M. Sean Finney (seanius) Date: 2005-05-01 15:56 Message: Logged In: YES user_id=226838 any progress on this one? it's the oldest bug in the tracker and i'm just trying to help keep a clean house :) ---------------------------------------------------------------------- Comment By: Alex (faucon) Date: 2005-01-11 10:39 Message: Logged In: YES user_id=706397 Hi tonvoon, Let me check it out. I'll download the latest cve and test it. ---------------------------------------------------------------------- Comment By: Ton Voon (tonvoon) Date: 2005-01-01 11:35 Message: Logged In: YES user_id=664364 Unassigning from Karl, but not sure of current status of this bug. Is it still an issue with the latest release? ---------------------------------------------------------------------- Comment By: Alex (faucon) Date: 2004-03-01 11:42 Message: Logged In: YES user_id=706397 Hi kdebisschop, I have tryed your check_nwstat of 2004-02-29. I can compile it, I can run it, but there is no output. And, on my dns, there is no dns request been made. And here is the command call that I use. Any other variable could be used. The output is working with 1.3.1 or 1.4.1alpha. ./check_nwstat -H srv-ndps1.cslaval.qc.ca -v ABENDS The answer to this command is usually: "0 abended threads" srv-ndps1 is an internal server. So you can't access it. But I can make any tests you require. Thanks. ---------------------------------------------------------------------- Comment By: Karl DeBisschop (kdebisschop) Date: 2004-02-28 23:18 Message: Logged In: YES user_id=1671 I may have found the cause - we were opening a new connection for each attribute requested. I have rewritten the code to open one connection and send repeatedly on tha one connection. But I do not have any way to test it and I do not know if the NW protocols allow it. Please test and provide feedback. ---------------------------------------------------------------------- Comment By: Karl DeBisschop (kdebisschop) Date: 2004-02-28 22:37 Message: Logged In: YES user_id=1671 Can you provide the service and command definitions that create these multiple requests? I don't have access to a test environment, but I'll be glad to look at the code and see if I can find anything. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=903461&group_id=29880 From noreply at sourceforge.net Sun May 1 13:09:13 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun May 1 13:09:13 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1107524 ] check_ping, segfault, popen problems Message-ID: Bugs item #1107524, was opened at 2005-01-22 17:39 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1107524&group_id=29880 Category: Parsing problem Group: CVS Status: Open Resolution: None Priority: 7 Submitted By: gprosser (gprosser) >Assigned to: M. Sean Finney (seanius) Summary: check_ping, segfault, popen problems Initial Comment: check_ping.c, including the current version in CVS, installs a signal handler for SIGALRM called popen_timeout_alarm_handler on startup, and sets an alarm to interrupt it later so the plugin doesn't run forever. However, the popen handler is set to kill the processes that was opened when an ALRM hits, and in certain circumstances (DNS timeouts) the plugin is still resolving the hostname of the target and has not yet opened a command. This leads to SIGSEGV when popen_timeout_(etc) tries to dereference a null pointer looking for what process to kill. I would suggest a safer benign signal handler to handle DNS timeouts be installed in the first case, and then changed just before the process is actually popened to the current handler. Thanks. -gnp ---------------------------------------------------------------------- >Comment By: M. Sean Finney (seanius) Date: 2005-05-01 16:08 Message: Logged In: YES user_id=226838 i think a fix for this wouldn't be too hard. the culprit seems to be in popen.c:247: kill (childpid[fileno (child_process)], SIGKILL); some simple error checking should do the trick. i'm also going to go ahead and initialize the file pointers in popen.h =NULL, as it shouldn't do any harm and may catch something else bad before it happens. ---------------------------------------------------------------------- Comment By: Daniel Graupner (dael) Date: 2005-03-09 13:33 Message: Logged In: YES user_id=577827 I have a similar problem, maybe it is related to this one. I have a lot of lines like pid xxxxx (check_ping), uid 1002: exited on signal 11 in my /var/log/messages. My notes on that: We have Laserlink between our gateway and the "world", everytime it is raining or snowing the connection is really slow or temporarily crashes. We have some pings that "go" over this line. The time of the crashes seems to be at the same time the laserlink is down. ---------------------------------------------------------------------- Comment By: Ton Voon (tonvoon) Date: 2005-02-03 19:05 Message: Logged In: YES user_id=664364 Raising priority on this one. Cannot reproduce myself. Any test cases available? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1107524&group_id=29880 From noreply at sourceforge.net Sun May 1 13:17:08 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun May 1 13:17:08 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1107524 ] check_ping, segfault, popen problems Message-ID: Bugs item #1107524, was opened at 2005-01-22 17:39 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1107524&group_id=29880 Category: Parsing problem Group: CVS >Status: Pending Resolution: None Priority: 7 Submitted By: gprosser (gprosser) Assigned to: M. Sean Finney (seanius) Summary: check_ping, segfault, popen problems Initial Comment: check_ping.c, including the current version in CVS, installs a signal handler for SIGALRM called popen_timeout_alarm_handler on startup, and sets an alarm to interrupt it later so the plugin doesn't run forever. However, the popen handler is set to kill the processes that was opened when an ALRM hits, and in certain circumstances (DNS timeouts) the plugin is still resolving the hostname of the target and has not yet opened a command. This leads to SIGSEGV when popen_timeout_(etc) tries to dereference a null pointer looking for what process to kill. I would suggest a safer benign signal handler to handle DNS timeouts be installed in the first case, and then changed just before the process is actually popened to the current handler. Thanks. -gnp ---------------------------------------------------------------------- >Comment By: M. Sean Finney (seanius) Date: 2005-05-01 16:16 Message: Logged In: YES user_id=226838 i've committed something i believe will solve this problem. can you test that it no longer segfaults? ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-05-01 16:08 Message: Logged In: YES user_id=226838 i think a fix for this wouldn't be too hard. the culprit seems to be in popen.c:247: kill (childpid[fileno (child_process)], SIGKILL); some simple error checking should do the trick. i'm also going to go ahead and initialize the file pointers in popen.h =NULL, as it shouldn't do any harm and may catch something else bad before it happens. ---------------------------------------------------------------------- Comment By: Daniel Graupner (dael) Date: 2005-03-09 13:33 Message: Logged In: YES user_id=577827 I have a similar problem, maybe it is related to this one. I have a lot of lines like pid xxxxx (check_ping), uid 1002: exited on signal 11 in my /var/log/messages. My notes on that: We have Laserlink between our gateway and the "world", everytime it is raining or snowing the connection is really slow or temporarily crashes. We have some pings that "go" over this line. The time of the crashes seems to be at the same time the laserlink is down. ---------------------------------------------------------------------- Comment By: Ton Voon (tonvoon) Date: 2005-02-03 19:05 Message: Logged In: YES user_id=664364 Raising priority on this one. Cannot reproduce myself. Any test cases available? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1107524&group_id=29880 From noreply at sourceforge.net Sun May 1 13:25:12 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun May 1 13:25:12 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1117643 ] Problems compiling 1.4 on Solaris 8 x86 Message-ID: Bugs item #1117643, was opened at 2005-02-06 21:52 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1117643&group_id=29880 Category: Parsing problem Group: Release (specify) Status: Open Resolution: None Priority: 5 Submitted By: Jeremy Russell (ellipses) >Assigned to: M. Sean Finney (seanius) Summary: Problems compiling 1.4 on Solaris 8 x86 Initial Comment: make errored on compling check_icmp. ---------------------------------------------- gcc -g -O2 -L. -R/usr/local/ssl/lib -L/usr/local/ssl/lib -o check_icmp check_icmp.o ../intl/libintl.a -liconv -lgen - lsocket -I/usr/local/ssl/include Undefined first referenced symbol in file gethostbyname check_icmp.o (symbol belongs to implicit dependency /usr/lib/libnsl.so.1) inet_addr check_icmp.o (symbol belongs to implicit dependency /usr/lib/libnsl.so.1) inet_ntoa check_icmp.o (symbol belongs to implicit dependency /usr/lib/libnsl.so.1) ld: fatal: Symbol referencing errors. No output written to check_icmp collect2: ld returned 1 exit status make[2]: *** [check_icmp] Error 1 make[2]: Leaving directory `/usr/local/support/src/monitor/nagios-plugins- 1.4/plugins' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/usr/local/support/src/monitor/nagios-plugins-1.4' make: *** [all] Error 2 ------------------------------------------ gcc -v Reading specs from /usr/local/lib/gcc-lib/i386-pc- solaris2.8/2.95.3/specs gcc version 2.95.3 20010315 (release) edited plugins/Makefile # diff Makefile Makefile.orig 419c419 < check_icmp_LDADD = -lnsl --- > check_icmp_LDADD = attaching config.log ---------------------------------------------------------------------- >Comment By: M. Sean Finney (seanius) Date: 2005-05-01 16:24 Message: Logged In: YES user_id=226838 hi, there exists code in the configure script which should find cases where -lnsl/-lsocket is needed, so i'm wondering why it's not working for you. could you try compiling from the latest cvs? if you still have the problem, could you post your config.log? ---------------------------------------------------------------------- Comment By: Stanley Hopcroft (stanleyhopcroft) Date: 2005-02-07 18:02 Message: Logged In: YES user_id=395628 Dear Jeremy, I am writing to thank you for opening a tracker about this problem, which appears to be Solaris specific. The developers advice is to add _both_ -lnsl and -lsocket for Solaris compiles. Since all the Makefiles for the plugins are generated by autoconf/automake, there needs to be Solaris specific mods made to configure.in and perhaps plugin/Makefile.am for this to please everyone. In the meantime, others should do as you have and manually add the extra libraries for Solaris. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1117643&group_id=29880 From noreply at sourceforge.net Sun May 1 13:27:09 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun May 1 13:27:09 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1181554 ] 1.4-3: Bug in check_tcp Message-ID: Bugs item #1181554, was opened at 2005-04-12 11:27 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1181554&group_id=29880 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Simon Bellwood (sb-netman) >Assigned to: M. Sean Finney (seanius) Summary: 1.4-3: Bug in check_tcp Initial Comment: I'm using check_imap with perfparse, and it's returning critical for all values. It seems the problem is that when no critical or warning value is passed to it on the command line, it defaults to use 0.000 and 0.000 respectively. Perfparse then sees that the check time (say 0.002 seconds) is above 0 and flags a CRITICAL warning. I've had a look at the code, and the return happens at check_tcp.c:389, where fperfdata is called. fperfdata is provided by utils.h which sets both types to a double, so I suspect it's not as simple as changing check_tcp.c to return nulls if the -w and -c flags aren't given :/ ---------------------------------------------------------------------- >Comment By: M. Sean Finney (seanius) Date: 2005-05-01 16:26 Message: Logged In: YES user_id=226838 hi, i'm still not sure what the solution to this should be. i don't believe arbitrarily setting the warn/critical values is the appropriate response. is there an undef value in perfparse? ---------------------------------------------------------------------- Comment By: Simon Bellwood (sb-netman) Date: 2005-04-19 02:52 Message: Logged In: YES user_id=1156501 But the plugin returns "0" and "0" for its warning and critical values, even though they are undefined - isn't that a bug? ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-04-18 19:50 Message: Logged In: YES user_id=226838 perhaps there's an "undef" value that could be used in such a case? i really don't know much about the whole perfparse thing since i use a seperate system from nagios for monitoring performance data. otherwise, i think the system is doing exactly what it's supposed to be doing, and would need some convincing why the answer isn't to just pass the warning and critical arguments to check_tcp. ---------------------------------------------------------------------- Comment By: Simon Bellwood (sb-netman) Date: 2005-04-18 03:01 Message: Logged In: YES user_id=1156501 I was hoping that one of the developers would either say: i) Oh no wait, there's an easy fix for this ii) Tell perfparse to treat 0.0 as "no value" Although ii) might be wrong in some cases, i.e. when 0 was considered a good value (perhaps for items where a measure from the normal was taken - can' think of any examples atm) ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-04-17 18:14 Message: Logged In: YES user_id=226838 hi, what exactly are you suggesting as a fix? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1181554&group_id=29880 From noreply at sourceforge.net Mon May 2 00:15:07 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon May 2 00:15:07 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1181554 ] 1.4-3: Bug in check_tcp Message-ID: Bugs item #1181554, was opened at 2005-04-12 17:27 Message generated for change (Comment added) made by sb-netman You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1181554&group_id=29880 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Simon Bellwood (sb-netman) Assigned to: M. Sean Finney (seanius) Summary: 1.4-3: Bug in check_tcp Initial Comment: I'm using check_imap with perfparse, and it's returning critical for all values. It seems the problem is that when no critical or warning value is passed to it on the command line, it defaults to use 0.000 and 0.000 respectively. Perfparse then sees that the check time (say 0.002 seconds) is above 0 and flags a CRITICAL warning. I've had a look at the code, and the return happens at check_tcp.c:389, where fperfdata is called. fperfdata is provided by utils.h which sets both types to a double, so I suspect it's not as simple as changing check_tcp.c to return nulls if the -w and -c flags aren't given :/ ---------------------------------------------------------------------- >Comment By: Simon Bellwood (sb-netman) Date: 2005-05-02 09:14 Message: Logged In: YES user_id=1156501 > i don't believe arbitrarily setting the warn/critical > values is the appropriate response. But this is what utils.h does (used by check_tcp.c), not perfparse. There seems to be no way of returning an unknown value, so it uses 0.000 instead. perfparse sees the "unknown" warning and critical values as 0.000, so uses them. ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-05-01 22:26 Message: Logged In: YES user_id=226838 hi, i'm still not sure what the solution to this should be. i don't believe arbitrarily setting the warn/critical values is the appropriate response. is there an undef value in perfparse? ---------------------------------------------------------------------- Comment By: Simon Bellwood (sb-netman) Date: 2005-04-19 08:52 Message: Logged In: YES user_id=1156501 But the plugin returns "0" and "0" for its warning and critical values, even though they are undefined - isn't that a bug? ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-04-19 01:50 Message: Logged In: YES user_id=226838 perhaps there's an "undef" value that could be used in such a case? i really don't know much about the whole perfparse thing since i use a seperate system from nagios for monitoring performance data. otherwise, i think the system is doing exactly what it's supposed to be doing, and would need some convincing why the answer isn't to just pass the warning and critical arguments to check_tcp. ---------------------------------------------------------------------- Comment By: Simon Bellwood (sb-netman) Date: 2005-04-18 09:01 Message: Logged In: YES user_id=1156501 I was hoping that one of the developers would either say: i) Oh no wait, there's an easy fix for this ii) Tell perfparse to treat 0.0 as "no value" Although ii) might be wrong in some cases, i.e. when 0 was considered a good value (perhaps for items where a measure from the normal was taken - can' think of any examples atm) ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-04-18 00:14 Message: Logged In: YES user_id=226838 hi, what exactly are you suggesting as a fix? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1181554&group_id=29880 From noreply at sourceforge.net Mon May 2 10:25:04 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon May 2 10:25:04 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1181554 ] 1.4-3: Bug in check_tcp Message-ID: Bugs item #1181554, was opened at 2005-04-12 11:27 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1181554&group_id=29880 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Simon Bellwood (sb-netman) Assigned to: M. Sean Finney (seanius) Summary: 1.4-3: Bug in check_tcp Initial Comment: I'm using check_imap with perfparse, and it's returning critical for all values. It seems the problem is that when no critical or warning value is passed to it on the command line, it defaults to use 0.000 and 0.000 respectively. Perfparse then sees that the check time (say 0.002 seconds) is above 0 and flags a CRITICAL warning. I've had a look at the code, and the return happens at check_tcp.c:389, where fperfdata is called. fperfdata is provided by utils.h which sets both types to a double, so I suspect it's not as simple as changing check_tcp.c to return nulls if the -w and -c flags aren't given :/ ---------------------------------------------------------------------- >Comment By: M. Sean Finney (seanius) Date: 2005-05-02 09:07 Message: Logged In: YES user_id=226838 sorry, i should be a little more clear on this: is perfparse capable of parsing an "unknown" or "undefined" value? if so, how should it look? otherwise, would it make sense to just not pass the information to perfparse at all? if so how should that look? you're right that there's no way to pass such values in the current code, but it wouldn't be too hard to add this functionality, as long as i knew what i was doing :) ---------------------------------------------------------------------- Comment By: Simon Bellwood (sb-netman) Date: 2005-05-02 03:14 Message: Logged In: YES user_id=1156501 > i don't believe arbitrarily setting the warn/critical > values is the appropriate response. But this is what utils.h does (used by check_tcp.c), not perfparse. There seems to be no way of returning an unknown value, so it uses 0.000 instead. perfparse sees the "unknown" warning and critical values as 0.000, so uses them. ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-05-01 16:26 Message: Logged In: YES user_id=226838 hi, i'm still not sure what the solution to this should be. i don't believe arbitrarily setting the warn/critical values is the appropriate response. is there an undef value in perfparse? ---------------------------------------------------------------------- Comment By: Simon Bellwood (sb-netman) Date: 2005-04-19 02:52 Message: Logged In: YES user_id=1156501 But the plugin returns "0" and "0" for its warning and critical values, even though they are undefined - isn't that a bug? ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-04-18 19:50 Message: Logged In: YES user_id=226838 perhaps there's an "undef" value that could be used in such a case? i really don't know much about the whole perfparse thing since i use a seperate system from nagios for monitoring performance data. otherwise, i think the system is doing exactly what it's supposed to be doing, and would need some convincing why the answer isn't to just pass the warning and critical arguments to check_tcp. ---------------------------------------------------------------------- Comment By: Simon Bellwood (sb-netman) Date: 2005-04-18 03:01 Message: Logged In: YES user_id=1156501 I was hoping that one of the developers would either say: i) Oh no wait, there's an easy fix for this ii) Tell perfparse to treat 0.0 as "no value" Although ii) might be wrong in some cases, i.e. when 0 was considered a good value (perhaps for items where a measure from the normal was taken - can' think of any examples atm) ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-04-17 18:14 Message: Logged In: YES user_id=226838 hi, what exactly are you suggesting as a fix? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1181554&group_id=29880 From noreply at sourceforge.net Mon May 2 10:57:52 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon May 2 10:57:52 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-903461 ] check_nwstat generates ipv6 calls (error) Message-ID: Bugs item #903461, was opened at 2004-02-24 14:14 Message generated for change (Comment added) made by faucon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=903461&group_id=29880 Category: None Group: Release (specify) Status: Open Resolution: None Priority: 5 Submitted By: Alex (faucon) Assigned to: Nobody/Anonymous (nobody) Summary: check_nwstat generates ipv6 calls (error) Initial Comment: Short story : check_nwstat is doing 2 X AAAA request and 1 X A request to my DNS server since version 1.3.99 (1.13). Details and tests : Linux server RedHat9. DNS server Netware With check_nwstat v1.3.99 or more recent, my DNS server is showing that my Nagios server is doing 2 X AAAA request (ip6) and 1 X A request (ip4). I tested with version 1.3.1 of the plugins, and there is no problem there. (but features in latest release are needed). I tested with other plugins and with ping, and everything is fine. Here is a peace of the logs. ---------------------- ***** QH_Proc: query received from 10.1.0.137 QH_ns_req: Query for (srv-ndps1.cslaval.qc.ca) of type aaaa Domain Name "srv-ndps1.cslaval.qc.ca" found in authoritative cache zone "cslaval.qc.ca" Send a UDP Reply to 10.1.0.137 ***** QH_Proc: query received from 10.1.0.137 QH_ns_req: Query for (srv-educ1.cslaval.qc.ca) of type aaaa Domain Name "srv-educ1.cslaval.qc.ca" found in authoritative cache zone "cslaval.qc.ca" Send a UDP Reply to 10.1.0.137 ***** QH_Proc: query received from 10.1.0.137 QH_ns_req: Query for (srv-sec1.cslaval.qc.ca) of type aaaa Domain Name "srv-sec1.cslaval.qc.ca" found in authoritative cache zone "cslaval.qc.ca" Send a UDP Reply to 10.1.0.137 ***** QH_Proc: query received from 10.1.0.137 QH_ns_req: Query for (srv-ndps1.cslaval.qc.ca) of type aaaa Domain Name "srv-ndps1.cslaval.qc.ca" found in authoritative cache zone "cslaval.qc.ca" Send a UDP Reply to 10.1.0.137 ***** QH_Proc: query received from 10.1.0.137 QH_ns_req: Query for (srv-educ1.cslaval.qc.ca) of type a Domain Name "srv-educ1.cslaval.qc.ca" found in authoritative cache zone "cslaval.qc.ca" Send a UDP Reply to 10.1.0.137 ***** QH_Proc: query received from 10.1.0.137 QH_ns_req: Query for (srv-sec1.cslaval.qc.ca) of type aaaa Domain Name "srv-sec1.cslaval.qc.ca" found in authoritative cache zone "cslaval.qc.ca" Send a UDP Reply to 10.1.0.137 ***** QH_Proc: query received from 10.1.0.137 QH_ns_req: Query for (srv-ndps1.cslaval.qc.ca) of type a Domain Name "srv-ndps1.cslaval.qc.ca" found in authoritative cache zone "cslaval.qc.ca" Send a UDP Reply to 10.1.0.137 ***** QH_Proc: query received from 10.1.0.137 QH_ns_req: Query for (srv-sec1.cslaval.qc.ca) of type a Domain Name "srv-sec1.cslaval.qc.ca" found in authoritative cache zone "cslaval.qc.ca" Send a UDP Reply to 10.1.0.137 --------------------------------- ---------------------------------------------------------------------- >Comment By: Alex (faucon) Date: 2005-05-02 14:54 Message: Logged In: YES user_id=706397 Hi seanius. Nop, still does. With the latest 1.4 package of plugins. Just tested 5 minutes ago :) check_ping (nagios-plugins 1.3.99) 1.25 check_nwstat (nagios-plugins 1.3.99) 1.13 At the end of this message, you can see the logs of ethereal. I made 3 pass for each tests. One with check_ping and one with check_nwstat. Since all 3 pass are the same, I just posted one of each. The thing is, with ping, everything is fine, it sends A request to the DNS and then ping. But with nwstat, it sends AAAA requests to the DNS before the A request and then check_nwstat. In practice, this means more stress for the DNS server. So the current workaround for here, is that I use the "secondary" DNS server as the first server, insted of the primary. If not, the primary is overload. -ethereal capture (edited)- (check_ping) 1.260597 10.200.60.160 -> 10.1.0.80 DNS Standard query A server.domain.qc.ca 1.260921 10.1.0.80 -> 10.200.60.160 DNS Standard query response A 10.200.1.20 1.264812 10.200.60.160 -> 10.1.0.80 DNS Standard query A server.domain.qc.ca 1.266082 10.1.0.80 -> 10.200.60.160 DNS Standard query response A 10.200.1.20 1.265547 10.200.60.160 -> 10.200.1.20 ICMP Echo (ping) request 1.265723 10.200.1.20 -> 10.200.60.160 ICMP Echo (ping) reply 2.264552 10.200.60.160 -> 10.200.1.20 ICMP Echo (ping) request 2.264726 10.200.1.20 -> 10.200.60.160 ICMP Echo (ping) reply 3.263560 10.200.60.160 -> 10.200.1.20 ICMP Echo (ping) request 3.263707 10.200.1.20 -> 10.200.60.160 ICMP Echo (ping) reply 4.262556 10.200.60.160 -> 10.200.1.20 ICMP Echo (ping) request 4.262723 10.200.1.20 -> 10.200.60.160 ICMP Echo (ping) reply 5.261575 10.200.60.160 -> 10.200.1.20 ICMP Echo (ping) request 5.261735 10.200.1.20 -> 10.200.60.160 ICMP Echo (ping) reply (check nwstat) 23.476463 10.200.60.160 -> 10.1.0.80 DNS Standard query AAAA server.domain.qc.ca 23.476734 10.1.0.80 -> 10.200.60.160 DNS Standard query response 23.477294 10.200.60.160 -> 10.1.0.80 DNS Standard query AAAA server.domain.qc.ca.domain.qc.ca 23.477576 10.1.0.80 -> 10.200.60.160 DNS Standard query response, No such name 23.477911 10.200.60.160 -> 10.1.0.80 DNS Standard query A srv-adm1.cslaval.qc.ca 23.478212 10.1.0.80 -> 10.200.60.160 DNS Standard query response A 10.200.1.20 23.478799 10.200.60.160 -> 10.200.1.20 TCP 39763 > 9999 [SYN] Seq=0 Ack=0 Win=5840 Len=0 MSS=1460 TSV=219178857 TSER=0 WS=0 23.478971 10.200.1.20 -> 10.200.60.160 TCP 9999 > 39763 [SYN, ACK] Seq=0 Ack=1 Win=6144 Len=0 MSS=1460 WS=0 23.479029 10.200.60.160 -> 10.200.1.20 TCP 39763 > 9999 [ACK] Seq=1 Ack=1 Win=5840 Len=0 23.540094 10.200.60.160 -> 10.200.1.20 TCP 39763 > 9999 [FIN, ACK] Seq=1 Ack=1 Win=5840 Len=0 23.540252 10.200.1.20 -> 10.200.60.160 TCP 9999 > 39763 [ACK] Seq=1 Ack=2 Win=6143 Len=0 23.540270 10.200.1.20 -> 10.200.60.160 TCP 9999 > 39763 [FIN, PSH, ACK] Seq=1 Ack=2 Win=6143 Len=0 23.540360 10.200.60.160 -> 10.200.1.20 TCP 39763 > 9999 [ACK] Seq=2 Ack=2 Win=5840 Len=0 ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-05-01 19:56 Message: Logged In: YES user_id=226838 any progress on this one? it's the oldest bug in the tracker and i'm just trying to help keep a clean house :) ---------------------------------------------------------------------- Comment By: Alex (faucon) Date: 2005-01-11 15:39 Message: Logged In: YES user_id=706397 Hi tonvoon, Let me check it out. I'll download the latest cve and test it. ---------------------------------------------------------------------- Comment By: Ton Voon (tonvoon) Date: 2005-01-01 16:35 Message: Logged In: YES user_id=664364 Unassigning from Karl, but not sure of current status of this bug. Is it still an issue with the latest release? ---------------------------------------------------------------------- Comment By: Alex (faucon) Date: 2004-03-01 16:42 Message: Logged In: YES user_id=706397 Hi kdebisschop, I have tryed your check_nwstat of 2004-02-29. I can compile it, I can run it, but there is no output. And, on my dns, there is no dns request been made. And here is the command call that I use. Any other variable could be used. The output is working with 1.3.1 or 1.4.1alpha. ./check_nwstat -H srv-ndps1.cslaval.qc.ca -v ABENDS The answer to this command is usually: "0 abended threads" srv-ndps1 is an internal server. So you can't access it. But I can make any tests you require. Thanks. ---------------------------------------------------------------------- Comment By: Karl DeBisschop (kdebisschop) Date: 2004-02-29 04:18 Message: Logged In: YES user_id=1671 I may have found the cause - we were opening a new connection for each attribute requested. I have rewritten the code to open one connection and send repeatedly on tha one connection. But I do not have any way to test it and I do not know if the NW protocols allow it. Please test and provide feedback. ---------------------------------------------------------------------- Comment By: Karl DeBisschop (kdebisschop) Date: 2004-02-29 03:37 Message: Logged In: YES user_id=1671 Can you provide the service and command definitions that create these multiple requests? I don't have access to a test environment, but I'll be glad to look at the code and see if I can find anything. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=903461&group_id=29880 From noreply at sourceforge.net Mon May 2 14:24:11 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon May 2 14:24:11 2005 Subject: [Nagiosplug-devel] [ nagiosplug-New Plugins-811360 ] New Plugin: check_webapp Message-ID: New Plugins item #811360, was opened at 2003-09-23 14:02 Message generated for change (Comment added) made by shadowlore You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=811360&group_id=29880 Category: Application monitor Group: None Status: Open Resolution: None Priority: 5 Submitted By: Barry Roberts (manithree) Assigned to: Nobody/Anonymous (nobody) Summary: New Plugin: check_webapp Initial Comment: This plugin does several things that I couldn't figure out how to do with check_http. It is intended for checking web applications and allow logging in, etc. It uses a text file with URL's, and text to match or not match as described in the beginning of the source. It can hit multiple URL's and save/send cookies. It currently spawns grep and curl. I would like to change it to use re and pyCurl. It's only a pass/fail thing now. No warning, and timeouts are not user-specifiable. ---------------------------------------------------------------------- Comment By: Bill Anderson (shadowlore) Date: 2005-05-02 15:22 Message: Logged In: YES user_id=13339 If there is any interest I'd be happy to rewrite this. The code should use the standard library's urllib/urllib2 for retreiving URLs, as opposed to calling an external binary. Newer python also includes cookie support on the client side. I've already written a test suite for mailman testing, so refactoring the code to do somethign less conplex would not be difficult or time intensive. So if anyone wants, I can rewrite this. It can use the same command line options if backward compatibility is desired but I have some options in mind to make it better. ---------------------------------------------------------------------- Comment By: Terry Davis (td3201) Date: 2003-10-30 12:35 Message: Logged In: YES user_id=115042 I have something quite similar written in perl. I utilize wt or HTTP::WebTest to log into sites and run a bunch of tests to determine whether it is up or not. The cookies part of your code is interesting. My plugin too is simply pass/fail. Therefore, it is either OK or CRITICAL. I don't know anything about python but you might be able to cut down some of the code by utilizing the wt system binary versus curl and grep. Let me know how I can help if you need any. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=811360&group_id=29880 From noreply at sourceforge.net Mon May 2 14:36:06 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon May 2 14:36:06 2005 Subject: [Nagiosplug-devel] [ nagiosplug-New Plugins-1119927 ] check_smtp_tls Message-ID: New Plugins item #1119927, was opened at 2005-02-10 03:10 Message generated for change (Comment added) made by shadowlore You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1119927&group_id=29880 Category: Perl plugin Group: None Status: Open Resolution: None Priority: 5 Submitted By: noliono (noliono) Assigned to: Nobody/Anonymous (nobody) Summary: check_smtp_tls Initial Comment: needed : lib net:telnet has to be install. a telnet command is send on the SMTP server, then a "STARTTLS" command and if TLS is present they will have a response code 250 ... and so on a nagios state (warning,critical,ok,unknow) ---------------------------------------------------------------------- Comment By: Bill Anderson (shadowlore) Date: 2005-05-02 15:35 Message: Logged In: YES user_id=13339 postfix will either handle starttls before or after ehlo/helo. IN other words, you can do it in either order for postfix. ---------------------------------------------------------------------- Comment By: jeff_fr (jeff_fr) Date: 2005-04-05 02:47 Message: Logged In: YES user_id=1250267 Modification to do $telnet->print("EHLO $HOSTNAME"); just before $telnet->print("STARTTLS"); :-) ps: the hostname should be the name of the computer that send the helo, but because it is not given in argument, i use hostname to put something ... else some server reject the command EHLO without argument... ---------------------------------------------------------------------- Comment By: noliono (noliono) Date: 2005-04-05 02:26 Message: Logged In: YES user_id=1216152 I will do the correction when i will have time to. But if you do the correction send it to all ! bye ---------------------------------------------------------------------- Comment By: jeff_fr (jeff_fr) Date: 2005-04-05 02:16 Message: Logged In: YES user_id=1250267 I checked the RFC and exchange2003 respects the SMTP/TLS RFC, every SMTP/TLS Server should be waiting for HELO or EHLO before the STARTTLS command, I don't know why postfix doesn't... ---------------------------------------------------------------------- Comment By: jeff_fr (jeff_fr) Date: 2005-03-31 06:32 Message: Logged In: YES user_id=1250267 Exchange is waiting for HELO or EHLO before the STARTTLS, in this case the script will return an ALERT instead of OK ---------------------------------------------------------------------- Comment By: jeff_fr (jeff_fr) Date: 2005-03-31 06:31 Message: Logged In: YES user_id=1250267 Exchange is waiting for HELO or EHLO before the STARTTLS, in this case the script will return an ALERT instead of OK ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1119927&group_id=29880 From noreply at sourceforge.net Mon May 2 18:12:00 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon May 2 18:12:00 2005 Subject: [Nagiosplug-devel] [ nagiosplug-New Plugins-1119927 ] check_smtp_tls Message-ID: New Plugins item #1119927, was opened at 2005-02-10 05:10 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1119927&group_id=29880 Category: Perl plugin Group: None >Status: Closed Resolution: None Priority: 5 Submitted By: noliono (noliono) >Assigned to: M. Sean Finney (seanius) Summary: check_smtp_tls Initial Comment: needed : lib net:telnet has to be install. a telnet command is send on the SMTP server, then a "STARTTLS" command and if TLS is present they will have a response code 250 ... and so on a nagios state (warning,critical,ok,unknow) ---------------------------------------------------------------------- >Comment By: M. Sean Finney (seanius) Date: 2005-05-02 21:11 Message: Logged In: YES user_id=226838 hey, the check_smtp plugin (check_tcp that is) now supports tls, so this plugin isn't really relevant any more, so i'm going to close this plugin report. ---------------------------------------------------------------------- Comment By: Bill Anderson (shadowlore) Date: 2005-05-02 17:35 Message: Logged In: YES user_id=13339 postfix will either handle starttls before or after ehlo/helo. IN other words, you can do it in either order for postfix. ---------------------------------------------------------------------- Comment By: jeff_fr (jeff_fr) Date: 2005-04-05 04:47 Message: Logged In: YES user_id=1250267 Modification to do $telnet->print("EHLO $HOSTNAME"); just before $telnet->print("STARTTLS"); :-) ps: the hostname should be the name of the computer that send the helo, but because it is not given in argument, i use hostname to put something ... else some server reject the command EHLO without argument... ---------------------------------------------------------------------- Comment By: noliono (noliono) Date: 2005-04-05 04:26 Message: Logged In: YES user_id=1216152 I will do the correction when i will have time to. But if you do the correction send it to all ! bye ---------------------------------------------------------------------- Comment By: jeff_fr (jeff_fr) Date: 2005-04-05 04:16 Message: Logged In: YES user_id=1250267 I checked the RFC and exchange2003 respects the SMTP/TLS RFC, every SMTP/TLS Server should be waiting for HELO or EHLO before the STARTTLS command, I don't know why postfix doesn't... ---------------------------------------------------------------------- Comment By: jeff_fr (jeff_fr) Date: 2005-03-31 08:32 Message: Logged In: YES user_id=1250267 Exchange is waiting for HELO or EHLO before the STARTTLS, in this case the script will return an ALERT instead of OK ---------------------------------------------------------------------- Comment By: jeff_fr (jeff_fr) Date: 2005-03-31 08:31 Message: Logged In: YES user_id=1250267 Exchange is waiting for HELO or EHLO before the STARTTLS, in this case the script will return an ALERT instead of OK ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1119927&group_id=29880 From noreply at sourceforge.net Mon May 2 18:54:13 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon May 2 18:54:13 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1186384 ] check_tcp issue Message-ID: Bugs item #1186384, was opened at 2005-04-19 21:43 Message generated for change (Settings changed) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1186384&group_id=29880 Category: Argument proccessing Group: None >Status: Closed Resolution: None Priority: 5 Submitted By: Scott Abbott (abbotsco) >Assigned to: M. Sean Finney (seanius) Summary: check_tcp issue Initial Comment: When an expect (-e) string is specified, check_tcp times out while waiting for a connection to the specified host/port. Without an expect string, check_tcp responds properly. ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-05-02 21:53 Message: Logged In: YES user_id=226838 this problem is now fixed in cvs. thank you for your report. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1186384&group_id=29880 From noreply at sourceforge.net Mon May 2 19:03:12 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon May 2 19:03:12 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1159828 ] CRITICAL check_ping on FC3 Message-ID: Bugs item #1159828, was opened at 2005-03-09 08:57 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1159828&group_id=29880 Category: None Group: None >Status: Closed Resolution: None Priority: 9 Submitted By: PiTsA (pitsa) >Assigned to: M. Sean Finney (seanius) Summary: CRITICAL check_ping on FC3 Initial Comment: The ping verification its not working... [root at infoandre libexec]# ./check_ping -H 192.168.1.4 -w 100.0,0,20% -c 500.0,0,60% /bin/ping -n -U -w 10 -c 5 192.168.1.4 CRITICAL - Could not interpret output from ping command [root at infoandre libexec]# /bin/ping -n -U -w 10 -c 5 192.168.1.4 PING 192.168.1.4 (192.168.1.4) 56(84) bytes of data. 64 bytes from 192.168.1.4: icmp_seq=0 ttl=128 time=0.249 ms 64 bytes from 192.168.1.4: icmp_seq=1 ttl=128 time=0.255 ms 64 bytes from 192.168.1.4: icmp_seq=2 ttl=128 time=0.198 ms 64 bytes from 192.168.1.4: icmp_seq=3 ttl=128 time=0.738 ms 64 bytes from 192.168.1.4: icmp_seq=4 ttl=128 time=0.187 ms --- 192.168.1.4 ping statistics --- 5 packets transmitted, 5 received, 0% packet loss, time 4006ms rtt min/avg/max/mdev = 0.187/0.325/0.738/0.208 ms, pipe 2 [root at infoandre libexec]# ---------------------------------------------------------------------- >Comment By: M. Sean Finney (seanius) Date: 2005-05-02 22:02 Message: Logged In: YES user_id=226838 actually, for check_ping to work the only locale setting you need to change is LC_NUMERIC (which deals with the formatting of numbers). i've just committed this change to cvs and verify that check_ping now works in different locales. ---------------------------------------------------------------------- Comment By: jeff_fr (jeff_fr) Date: 2005-03-31 08:14 Message: Logged In: YES user_id=1250267 you must modifiy chech_ping line 74 and add : setlocale (LC_ALL, "C"); instead of : setlocale (LC_ALL, ""); recompile ... in nagios it will be state ok in console mode you will get something like : PING CRITICAL - PAcket loss= 0%, TA= 1 ms ---------------------------------------------------------------------- Comment By: Bastien (dro0p) Date: 2005-03-11 05:29 Message: Logged In: YES user_id=1237097 Hi, Same problem here on a redhat 7.3. For me this problem is due to the local used. In fact my local (french) used , as float separator instead of . (us or english local). So the scanf function is unable to read float from the command ping (wich sort float using .). I made a small patch (it has a bad quality but it works). I post it here : ----- --- check_ping.c Fri Mar 11 10:13:08 2005 +++ check_ping.c Fri Mar 11 10:09:50 2005 @@ -401,6 +401,7 @@ { char buf[MAX_INPUT_BUFFER]; int result = STATE_UNKNOWN; + int i; if ((child_process = spopen (cmd)) == NULL) die (STATE_UNKNOWN, _("Could not open pipe: %s\n"), cmd); @@ -421,9 +422,19 @@ sscanf(buf,"%*d packets transmitted, %*d received, %d%% packet loss, time", &pl)==1 || sscanf(buf,"%*d packets transmitted, %*d received, +%*d errors, %d%% packet loss", &pl) == 1) continue; - /* get the round trip average */ else + { + if ((buf[0] == 'r') && (buf[1] == 't') && (buf[2] == 't')) + { + //fix for locales who uses , as float delimiter + for (i = 3 ; buf[i] != 0 ; i++) + { + if (buf[i] == '.') + buf[i] = ','; + } + } + if(sscanf(buf,"round-trip min/avg/max = %*f/%f/%*f",&rta)==1 || sscanf(buf,"round-trip min/avg/max/mdev = %*f/%f/%*f/%*f",&rta)==1 || sscanf(buf,"round-trip min/avg/max/sdev = %*f/%f/%*f/%*f",&rta)==1 || @@ -432,7 +443,8 @@ sscanf(buf,"round-trip (ms) min/avg/max = %*f/%f/%*f",&rta)==1 || sscanf(buf,"round-trip (ms) min/avg/max/stddev = %*f/%f/%*f/%*f",&rta)==1 || sscanf(buf,"rtt min/avg/max/mdev = %*f/%f/%*f/%*f ms",&rta)==1) - continue; + continue; + } } /* this is needed because there is no rta if all packets are lost */ ---- ---------------------------------------------------------------------- Comment By: PiTsA (pitsa) Date: 2005-03-09 09:00 Message: Logged In: YES user_id=1235741 nagios-plugins Version 1.4 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1159828&group_id=29880 From admin at jpk236.com Tue May 3 15:53:04 2005 From: admin at jpk236.com (admin at jpk236.com) Date: Tue May 3 15:53:04 2005 Subject: [Nagiosplug-devel] NSCA 2.4 patch Message-ID: <4278008E.9000608@jpk236.com> Here is a patch a buddy of mine put together which allows the nsca.cfg for the nsca daemon to allow hostnames, along with IPs, in the allowed_hosts field. It uses the gethostbyname and the inet_ntoa system functions. The patch was coded to work the FreeBSD ports version of nsca-2.4. However, even though the patch is not portable, the modification itself is. Author :: Brian Gillis Patch :: http://www.thegillis.net/examples/nagios/nsca.gillis.patch Installation :: #> cd /usr/ports/net-mgmt/nsca #> wget http://www.thegillis.net/examples/nagios/nsca.gillis.patch #> make extract #> patch -p1 < nsca.gillis.patch #> make install - Justin Kulikowski [ http://www.jpk236.com ] From mi.cz at web.de Wed May 4 07:58:18 2005 From: mi.cz at web.de (Micha Micha) Date: Wed May 4 07:58:18 2005 Subject: [Nagiosplug-devel] Nagios plugins in C-Shell Message-ID: <20050504115302.E4DB14F4002@desire.netways.de> Hi list is it possible to create plugins in c-shell?? I wrote a plugin but i get the messege NRPE: Unable to read output. Here is my code: if ( ($ERR_LOG_FLAG == 1) && ($ERR_JB_FLAG == 1) ) then set exitstatus = $STATE_CRITICAL echo "A and B" exit $STATE_CRITICAL else if ( $ERR_LOG_FLAG == 1) then set exitstatus = $STATE_WARNING echo "A" exit $STATE_WARNING else if ( $ERR_JB_FLAG == 1 ) then set exitstatus = $STATE_WARNING echo "B" exit $STATE_WARNING else set exitstatus = $STATE_OK echo "OK" exit $STATE_OK endif What is wrong?? - Micha (Navigato) ----------------------- The mailing list archive is found here: http://www.nagiosexchange.org/nagiosplug-devel.31.0.html From seanius at seanius.net Wed May 4 08:23:18 2005 From: seanius at seanius.net (sean finney) Date: Wed May 4 08:23:18 2005 Subject: [Nagiosplug-devel] Nagios plugins in C-Shell In-Reply-To: <20050504115302.E4DB14F4002@desire.netways.de> References: <20050504115302.E4DB14F4002@desire.netways.de> Message-ID: <20050504152230.GA20934@seanius.net> hi micha, On Wed, May 04, 2005 at 01:53:02PM +0200, Micha Micha wrote: > is it possible to create plugins in c-shell?? you can create them in any language, as long as it has the capability to control the exit status. > What is wrong?? unfortunately, i stay far away from csh, so i can't help you too much there :/ sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From seanius at seanius.net Wed May 4 08:24:33 2005 From: seanius at seanius.net (sean finney) Date: Wed May 4 08:24:33 2005 Subject: [Nagiosplug-devel] NSCA 2.4 patch In-Reply-To: <4278008E.9000608@jpk236.com> References: <4278008E.9000608@jpk236.com> Message-ID: <20050504152338.GB20934@seanius.net> hi justin, afaik, ncsa is under the control of the main nagios project, not the nagios-plugins project. might want to try re-sending your patch there. sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From josh at joshs.net Thu May 5 13:01:12 2005 From: josh at joshs.net (Josh) Date: Thu May 5 13:01:12 2005 Subject: [Nagiosplug-devel] comparisons of -w and -c Message-ID: The check_disk and check_swap plugins error if -w is *less* than -c - it should be the other way around. (this still is true in the most recent CVS) "check_disk.c" line 505 "check_disk.c" line 512 "check_swap.c" line 463 "check_swap.c" line 467 Thanks, Josh From ae at op5.se Thu May 5 13:11:19 2005 From: ae at op5.se (Andreas Ericsson) Date: Thu May 5 13:11:19 2005 Subject: [Nagiosplug-devel] comparisons of -w and -c In-Reply-To: References: Message-ID: <427A7D6D.7060700@op5.se> Josh wrote: > The check_disk and check_swap plugins error if -w is *less* than -c - it should > be the other way around. (this still is true in the most recent CVS) > No it should not, since they report (and warn) on how much space (in percent) that is free. It's a common misconception. > "check_disk.c" line 505 > "check_disk.c" line 512 > "check_swap.c" line 463 > "check_swap.c" line 467 > > Thanks, > Josh > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: NEC IT Guy Games. > Get your fingers limbered up and give it your best shot. 4 great events, 4 > opportunities to win big! Highest score wins.NEC IT Guy Games. Play to > win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20 > _______________________________________________________ > Nagios Plugin Development Mailing List Nagiosplug-devel at lists.sourceforge.net > Unsubscribe at https://lists.sourceforge.net/lists/listinfo/nagiosplug-devel > ::: Please include plugins version (-v) and OS when reporting any issue. > ::: Messages without supporting info will risk being sent to /dev/null > -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Lead Developer From seanius at seanius.net Thu May 5 13:25:24 2005 From: seanius at seanius.net (sean finney) Date: Thu May 5 13:25:24 2005 Subject: [Nagiosplug-devel] comparisons of -w and -c In-Reply-To: <427A7D6D.7060700@op5.se> References: <427A7D6D.7060700@op5.se> Message-ID: <20050505202056.GA4610@seanius.net> hi, On Thu, May 05, 2005 at 10:09:17PM +0200, Andreas Ericsson wrote: > Josh wrote: > >The check_disk and check_swap plugins error if -w is *less* than -c - it > >should > >be the other way around. (this still is true in the most recent CVS) > > > > No it should not, since they report (and warn) on how much space (in > percent) that is free. It's a common misconception. and this behaviour has changed *at least* once in the past, if not more. honestly, for the sake of stability and consistancy i'd suggest leaving it as it is. it might be nice to have a flag that let you select what you'd like to check (% left/used and Gb/Mb left/used, like the -T in check_snmp_storage), but otherwise i think it's fine the way it is. sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From ae at op5.se Thu May 5 13:44:58 2005 From: ae at op5.se (Andreas Ericsson) Date: Thu May 5 13:44:58 2005 Subject: [Nagiosplug-devel] comparisons of -w and -c In-Reply-To: <20050505202056.GA4610@seanius.net> References: <427A7D6D.7060700@op5.se> <20050505202056.GA4610@seanius.net> Message-ID: <427A8570.10609@op5.se> sean finney wrote: > hi, > > On Thu, May 05, 2005 at 10:09:17PM +0200, Andreas Ericsson wrote: > >>Josh wrote: >> >>>The check_disk and check_swap plugins error if -w is *less* than -c - it >>>should >>>be the other way around. (this still is true in the most recent CVS) >>> >> >>No it should not, since they report (and warn) on how much space (in >>percent) that is free. It's a common misconception. > > > and this behaviour has changed *at least* once in the past, if not more. > > honestly, for the sake of stability and consistancy i'd suggest leaving > it as it is. it might be nice to have a flag that let you select what > you'd like to check (% left/used and Gb/Mb left/used, like the -T in > check_snmp_storage), but otherwise i think it's fine the way it is. > What's really needed is something like a general functionality to check if one value is greater than the other and evaluate it intelligently, like so; /* eval thresholds in a somewhat clever manner */ inline int nplug_thresh_match(warn, crit, value) { if(crit <= warn) { if(value <= crit) return STATE_CRITICAL; if(value <= warn) return STATE_WARNING; } if(crit >= warn) { if(value >= crit) return STATE_CRITICAL; if(value >= warn) return STATE_WARNING; } return STATE_OK; } This should ofcourse be called once for each threshold type (several disks at once, fe). Also, check_{disk,mem,swap} and friends should be made to accept a prefix to the threshold arguments, such as %, MB et al. They should also follow the path of least surprise for the end user. I've never quite understood why there are a plethora of various functions for exiting while reporting user errors when there are none that actually work around user stupidity. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Lead Developer From josh at joshs.net Thu May 5 19:33:13 2005 From: josh at joshs.net (Josh) Date: Thu May 5 19:33:13 2005 Subject: [Nagiosplug-devel] Re: comparisons of -w and -c References: <427A7D6D.7060700@op5.se> Message-ID: Andreas Ericsson writes: > > Josh wrote: > > The check_disk and check_swap plugins error if -w is *less* than -c - it > > should > > be the other way around. (this still is true in the most recent CVS) > > > > No it should not, since they report (and warn) on how much space (in > percent) that is free. It's a common misconception. > *grumble* - damn i'm stupid. Perhaps the addtion of -u and -f switches would help that (-u = used, -f = free) - I've seen this in some other plugins. From noreply at sourceforge.net Fri May 6 06:00:23 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Fri May 6 06:00:23 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1196550 ] Fixed typo in Lotus Plugin Message-ID: Patches item #1196550, was opened at 2005-05-06 14:58 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1196550&group_id=29880 Category: Bugfix Group: None Status: Open Resolution: None Priority: 5 Submitted By: B. Czech (bczech) Assigned to: Nobody/Anonymous (nobody) Summary: Fixed typo in Lotus Plugin Initial Comment: The Server DN was checked in a case sensetive way. Source: contrib/check_lotus.pl ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1196550&group_id=29880 From noreply at sourceforge.net Fri May 6 06:02:57 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Fri May 6 06:02:57 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1196550 ] Fixed typo in Lotus Plugin Message-ID: Patches item #1196550, was opened at 2005-05-06 14:58 Message generated for change (Settings changed) made by bczech You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1196550&group_id=29880 Category: Bugfix Group: None Status: Open Resolution: None Priority: 5 Submitted By: B. Czech (bczech) >Assigned to: Stanley Hopcroft (stanleyhopcroft) Summary: Fixed typo in Lotus Plugin Initial Comment: The Server DN was checked in a case sensetive way. Source: contrib/check_lotus.pl ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1196550&group_id=29880 From noreply at sourceforge.net Fri May 6 07:27:31 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Fri May 6 07:27:31 2005 Subject: [Nagiosplug-devel] [ nagiosplug-New Plugins-1196604 ] plugin for check ser interface Message-ID: New Plugins item #1196604, was opened at 2005-05-06 14:25 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1196604&group_id=29880 Category: Perl plugin Group: None Status: Open Resolution: None Priority: 5 Submitted By: paly (palyk) Assigned to: Nobody/Anonymous (nobody) Summary: plugin for check ser interface Initial Comment: At the moment work only for local ser servers, U need install sipsak interface. Try and change it! need file utils.pm in /usr/nagios/libexec - or change this path wherever U instal your nagios command in check commands and services and resources # 'check_ser' command definition define command{ command_name check_ser command_line $USER1$/check_ser.pl -U sip:$ARG1$@$HOSTADDRESS$ -w 10 -c 50 -H $USER2$ -P $ARG2$ } define service{ use generic-service ; Name of service template to use host_name merkur service_description SER is_volatile 0 check_period 24x7 max_check_attempts 10 normal_check_interval 1 retry_check_interval 1 contact_groups nt-admins notification_interval 960 notification_period workhours notification_options c,r check_command check_ser!user!password } $USER2$ = 192.168.x.x (your nagios ip address) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1196604&group_id=29880 From noreply at sourceforge.net Fri May 6 07:36:13 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Fri May 6 07:36:13 2005 Subject: [Nagiosplug-devel] [ nagiosplug-New Plugins-1196604 ] check ser interface plugin Message-ID: New Plugins item #1196604, was opened at 2005-05-06 14:25 Message generated for change (Settings changed) made by palyk You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1196604&group_id=29880 Category: Perl plugin Group: None Status: Open Resolution: None Priority: 5 Submitted By: paly (palyk) Assigned to: Nobody/Anonymous (nobody) >Summary: check ser interface plugin Initial Comment: At the moment work only for local ser servers, U need install sipsak interface. Try and change it! need file utils.pm in /usr/nagios/libexec - or change this path wherever U instal your nagios command in check commands and services and resources # 'check_ser' command definition define command{ command_name check_ser command_line $USER1$/check_ser.pl -U sip:$ARG1$@$HOSTADDRESS$ -w 10 -c 50 -H $USER2$ -P $ARG2$ } define service{ use generic-service ; Name of service template to use host_name merkur service_description SER is_volatile 0 check_period 24x7 max_check_attempts 10 normal_check_interval 1 retry_check_interval 1 contact_groups nt-admins notification_interval 960 notification_period workhours notification_options c,r check_command check_ser!user!password } $USER2$ = 192.168.x.x (your nagios ip address) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1196604&group_id=29880 From frank at simplyhired.com Sun May 8 01:42:04 2005 From: frank at simplyhired.com (Frank Reta) Date: Sun May 8 01:42:04 2005 Subject: [Nagiosplug-devel] Custom Plugin issue Message-ID: Hello: Not sure if these are the correct forums through which to ask questions, but I couldn't find where else to post to. Nagios 1.2 on Fedora 3 I'm in the throes of trying to create an in-house script that parses a file for a given number. It then uses this number to determine if the return should be OK, WARNING or CRITICAL. When command line run, the issued PRINT line displays the correct result given the parameters given. When brought into Nagios, the "Status Information" portion of the service item is correct, but the actual "Status" entry never changes from OK, despite the plugin reporting "Critical". The perl script is: #!/usr/bin/perl -w use strict; use warnings; use Getopt::Long; use constant STATS_FILE_PATH => '/home/kapow/crawler/etc/crawl-server.stat'; my @return_codes = qw( OK WARNING CRITICAL UNKNOWN ); my ($warning, $critical) = get_cmd_params(); my $threads = 0; my $status = 0; my $msg = ''; if( open( STAT, STATS_FILE_PATH ) ) { foreach ( ) { next unless /^threads=(\d+)/; $threads = $1; } close( STAT ); $status = ( $threads > $warning ) ? 0 : ( $threads > $critical ) ? 1 : 2; $msg = "crawl-server currently has $threads threads"; } else { $status = 3; $msg = 'unable to open crawl-server stats file'; } print( "threads $return_codes[$status] - $msg ", "|threads=$threads;$warning;$critical;$status\n" ); ###################################################################### sub get_cmd_params { my ($warning, $critical) = (0,0); my $result = GetOptions( 'w=i' => \$warning, 'c=i' => \$critical ); die "Usage: get_crawler_stats -w -c \n" if($warning <= 0 || $critical <= 0); return ($warning, $critical); } When run on command line, the result is: [root at warlords etc]# /usr/local/nagios/libexec/check_nrpe -H crawl1 -c check_threads -a 70 60 threads WARNING - crawl-server currently has 64 threads |threads=64;70;60;0 (to compare, the check_users, which does work correctly all the way through is:) [root at warlords libexec]# ./check_users -w 1 -c 6 USERS WARNING - 5 users currently logged in |users=5;1;6;0 Any help on this would be immensely appreciated. If this is not the correct forum to direct my questions to, could you please point me in the right direction? Thanks much! Frank Reta Information Technology Janitor - Simply Hired , Inc. http://www.SimplyHired.com (650) 254-9000x130 frank at simplyhired.com -------------- next part -------------- An HTML attachment was scrubbed... URL: From sghosh at sghosh.org Sun May 8 01:52:14 2005 From: sghosh at sghosh.org (Subhendu Ghosh) Date: Sun May 8 01:52:14 2005 Subject: [Nagiosplug-devel] Custom Plugin issue In-Reply-To: References: Message-ID: This is the correct forum - but you may want to subscribe before posting as well. Documentation on writing plugins: http://nagiosplug.sourceforge.net/developer-guidelines.html Nagios looks at the exit codes. An "echo $?" after running the plugin on the command line will tell you if you are exiting with the proper code or not. You are missing a "exit ($status)" line at the end. -sg On Thu, 5 May 2005, Frank Reta wrote: > Hello: > > Not sure if these are the correct forums through which to > ask questions, but I couldn't find where else to post to. > > > > Nagios 1.2 on Fedora 3 > > > > I'm in the throes of trying to create an in-house script that parses a > file for a given number. It then uses this number to determine if the > return should be OK, WARNING or CRITICAL. When command line run, the > issued PRINT line displays the correct result given the parameters > given. When brought into Nagios, the "Status Information" portion of > the service item is correct, but the actual "Status" entry never changes > from OK, despite the plugin reporting "Critical". > > > > The perl script is: > > > > #!/usr/bin/perl -w > > > > use strict; > > use warnings; > > use Getopt::Long; > > > > use constant STATS_FILE_PATH => > '/home/kapow/crawler/etc/crawl-server.stat'; > > > > my @return_codes = qw( OK WARNING CRITICAL UNKNOWN ); > > > > > > my ($warning, $critical) = get_cmd_params(); > > my $threads = 0; > > my $status = 0; > > my $msg = ''; > > > > if( open( STAT, STATS_FILE_PATH ) ) { > > > > foreach ( ) { > > next unless /^threads=(\d+)/; > > $threads = $1; > > } > > close( STAT ); > > $status = ( $threads > $warning ) ? 0 : > > ( $threads > $critical ) ? 1 : 2; > > $msg = "crawl-server currently has $threads threads"; > > } else { > > $status = 3; > > $msg = 'unable to open crawl-server stats file'; > > } > > > > > > print( "threads $return_codes[$status] - $msg ", > > "|threads=$threads;$warning;$critical;$status\n" ); > > > > > > > > ###################################################################### > > sub get_cmd_params { > > > > my ($warning, $critical) = (0,0); > > > > my $result = GetOptions( 'w=i' => \$warning, > > 'c=i' => \$critical ); > > > > die "Usage: get_crawler_stats -w -c \n" > > if($warning <= 0 || $critical <= 0); > > > > return ($warning, $critical); > > } > > > > > > > > When run on command line, the result is: > > [root at warlords etc]# /usr/local/nagios/libexec/check_nrpe -H crawl1 -c > check_threads -a 70 60 > > threads WARNING - crawl-server currently has 64 threads > |threads=64;70;60;0 > > > > (to compare, the check_users, which does work correctly all the way > through is:) > > [root at warlords libexec]# ./check_users -w 1 -c 6 > > USERS WARNING - 5 users currently logged in |users=5;1;6;0 > > > > > > Any help on this would be immensely appreciated. If this is not the > correct forum to direct my questions to, could you please point me in > the right direction? > > > > Thanks much! > > > > Frank Reta > > Information Technology Janitor - Simply Hired > , Inc. > > http://www.SimplyHired.com > > (650) 254-9000x130 > > frank at simplyhired.com > > > > -- From ae at op5.se Sun May 8 01:58:29 2005 From: ae at op5.se (Andreas Ericsson) Date: Sun May 8 01:58:29 2005 Subject: [Nagiosplug-devel] Custom Plugin issue In-Reply-To: References: Message-ID: <427DD485.1050809@op5.se> Frank Reta wrote: > Hello: > > Not sure if these are the correct forums through which to > ask questions, but I couldn't find where else to post to. > > > > Nagios 1.2 on Fedora 3 > > > > I'm in the throes of trying to create an in-house script that parses a > file for a given number. It then uses this number to determine if the > return should be OK, WARNING or CRITICAL. When command line run, the > issued PRINT line displays the correct result given the parameters > given. When brought into Nagios, the "Status Information" portion of > the service item is correct, but the actual "Status" entry never changes > from OK, despite the plugin reporting "Critical". > Because it exits with return code 0. Read the plugin developer guidelines or the code of another plugin. The output doesn't matter at all. Only the return-code as given from the program to the shell by the exit(3) library call. Having nagios actually care about the output of plugins would be seriously stupid performance-wise. > > > The perl script is: > > > > #!/usr/bin/perl -w > > > > use strict; > > use warnings; > > use Getopt::Long; > > > > use constant STATS_FILE_PATH => > '/home/kapow/crawler/etc/crawl-server.stat'; > > > > my @return_codes = qw( OK WARNING CRITICAL UNKNOWN ); > > > > > > my ($warning, $critical) = get_cmd_params(); > > my $threads = 0; > > my $status = 0; > > my $msg = ''; > > > > if( open( STAT, STATS_FILE_PATH ) ) { > > > > foreach ( ) { > > next unless /^threads=(\d+)/; > > $threads = $1; > > } > > close( STAT ); > > $status = ( $threads > $warning ) ? 0 : > > ( $threads > $critical ) ? 1 : 2; > > $msg = "crawl-server currently has $threads threads"; > > } else { > > $status = 3; > > $msg = 'unable to open crawl-server stats file'; > > } > > > > > > print( "threads $return_codes[$status] - $msg ", > > "|threads=$threads;$warning;$critical;$status\n" ); > > > > > > > > ###################################################################### > > sub get_cmd_params { > > > > my ($warning, $critical) = (0,0); > > > > my $result = GetOptions( 'w=i' => \$warning, > > 'c=i' => \$critical ); > > > > die "Usage: get_crawler_stats -w -c \n" > > if($warning <= 0 || $critical <= 0); > > > > return ($warning, $critical); > > } > > > > > > > > When run on command line, the result is: > > [root at warlords etc]# /usr/local/nagios/libexec/check_nrpe -H crawl1 -c > check_threads -a 70 60 > > threads WARNING - crawl-server currently has 64 threads > |threads=64;70;60;0 > > > > (to compare, the check_users, which does work correctly all the way > through is:) > > [root at warlords libexec]# ./check_users -w 1 -c 6 > > USERS WARNING - 5 users currently logged in |users=5;1;6;0 > > > > > > Any help on this would be immensely appreciated. If this is not the > correct forum to direct my questions to, could you please point me in > the right direction? > > > > Thanks much! > > > > Frank Reta > > Information Technology Janitor - Simply Hired > , Inc. > > http://www.SimplyHired.com > > (650) 254-9000x130 > > frank at simplyhired.com > > > > -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Lead Developer From jhmartin at toger.us Sun May 8 08:20:43 2005 From: jhmartin at toger.us (Jason Martin) Date: Sun May 8 08:20:43 2005 Subject: [Nagiosplug-devel] Custom Plugin issue In-Reply-To: References: Message-ID: <20050508151753.GA7941@zippy.toger.us> On Thu, May 05, 2005 at 06:54:07PM -0700, Frank Reta wrote: > Hello: > > Not sure if these are the correct forums through which to > ask questions, but I couldn't find where else to post to. The last thing your script must do is exit($status). You can verify this i happening by executing "echo $?" immediately after you run the script from the command line. -Jason Martin -- Hackito ergo sum. This message is PGP/MIME signed. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 211 bytes Desc: not available URL: From seanius at seanius.net Sun May 8 14:01:25 2005 From: seanius at seanius.net (sean finney) Date: Sun May 8 14:01:25 2005 Subject: [Nagiosplug-devel] novel idea for performance optimization Message-ID: <20050508205952.GA9645@seanius.net> hey folks, (cross-posting to nagiosplug mailing list too) i have this idea that's been floating around in my head for a while, and wonder what other folks think. one of the most notable performance hits on a nagios server is the huge overhead from having to fork/exec a seperate binary for every check (and many of these binaries go on to fork/exec or popen yet another system call). to the passing pessimist, this might be considered an unavoidable hit because of how nagios works (with the plugins being a bunch of seperate executable binaries). however, i think i see a rather novel way around the problem. with a little ld linker voodoo, you could build a shared library version of each plugin, where main() was renamed something identifiable to the plugins. then in nagios, when it goes to execute a plugin, it first would check to see if such a shared object existed. if it doesn't, it executes the binary just like it normally would, and if it does, it instead dlopen()'s the library, and calls the function. repeated calls to the check would therefore have very little overhead, as not only would the fork/exec be avoided, but the library would already be loaded and resident in memory. the one problems i see with this are that many of the plugins have less than stellar memory management, and some might need some work to be thread safe (and some of course are not executable binaries at all, but instead perl/shell/whatever scripts). so, what do you think? sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From seanius at seanius.net Sun May 8 21:17:12 2005 From: seanius at seanius.net (sean finney) Date: Sun May 8 21:17:12 2005 Subject: [Nagiosplug-devel] novel idea for performance optimization In-Reply-To: <20050509032841.GA27725@tapir.sajinet.com.pe> References: <20050508205952.GA9645@seanius.net> <20050509032841.GA27725@tapir.sajinet.com.pe> Message-ID: <20050509041548.GA14048@seanius.net> hi carlo, On Sun, May 08, 2005 at 10:28:41PM -0500, Carlo Marcelo Arenas Belon wrote: > my guess is that most of the C plugins are small enough and designed to be > standalone programs, that this migration wouldn't show on them a big > improvement and the risk/cost would be too high. maybe not on a system that isn't feeling the burn of all the fork/exec calls, but i'll bet money that it will make a notable difference on a system where hundreds or thousands of devices are being polled. i may do a proof of concept just to see how true this is. > the perl plugins (big interpreter spawned and code "re-compiled" on every > excecution) and shell plugins (with several different processes spawned > inside) which are the ones which are taking more of the CPU anyway are not > getting any improvement at all. this is true. most notably, the snmp based perl plugins are real hogs. i think the clear answer is to eventually implement them in C :) > as for making a new standard interface based on DSOs (basically an stable > API which you could dynamic link probes to) without making it mandatory so > that new probes could start migrating to it on their own, i am all for it. the nice thing about the 'ld voodoo' i suggest is that no code needs to be re-written[1] in any of the existing plugins. anyway, i'll see about putting some code where my mouth is before wasting anyone else's time :) sean [1] minus fixes for memory leaks and being thread-safe, i suppose. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From seanius at debian.org Sun May 8 23:45:27 2005 From: seanius at debian.org (sean finney) Date: Sun May 8 23:45:27 2005 Subject: [Nagiosplug-devel] novel idea for performance optimization Message-ID: <20050508193639.GA8828@seanius.net> hey folks, (cross-posting to nagiosplug mailing list too) i have this idea that's been floating around in my head for a while, and wonder what other folks think. one of the most notable performance hits on a nagios server is the huge overhead from having to fork/exec a seperate binary for every check (and many of these binaries go on to fork/exec or popen yet another system call). to the passing pessimist, this might be considered an unavoidable hit because of how nagios works (with the plugins being a bunch of seperate executable binaries). however, i think i see a rather novel way around the problem. with a little ld linker voodoo, you could build a shared library version of each plugin, where main() was renamed something identifiable to the plugins. then in nagios, when it goes to execute a plugin, it first would check to see if such a shared object existed. if it doesn't, it executes the binary just like it normally would, and if it does, it instead dlopen()'s the library, and calls the function. repeated calls to the check would therefore have very little overhead, as not only would the fork/exec be avoided, but the library would already be loaded and resident in memory. the one problems i see with this are that many of the plugins have less than stellar memory management, and some might need some work to be thread safe (and some of course are not executable binaries at all, but instead perl/shell/whatever scripts). so, what do you think? sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From noreply at sourceforge.net Mon May 9 18:21:31 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon May 9 18:21:31 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1106849 ] check_procs returns "WARNING" due to bad syntax of ps Message-ID: Bugs item #1106849, was opened at 2005-01-22 04:28 Message generated for change (Comment added) made by opensourceror55 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1106849&group_id=29880 Category: Parsing problem Group: snapshot tarball Status: Open Resolution: None Priority: 7 Submitted By: Paulo Fessel (paulo_fessel) Assigned to: Ton Voon (tonvoon) Summary: check_procs returns "WARNING" due to bad syntax of ps Initial Comment: Everytime I use check_procs (from 1.4-beta1 on), I get warnings even when I haven't specified warning levels: [root at nagios plugins]# ./check_procs System call sent warnings to stderr PROCS WARNING: 392 processes Running with -vv, I see that there's a message from ps command which is interpreted incorrectly by the plugin: [root at nagios plugins]# ./check_procs -vv CMD: /bin/ps -axwo 'stat uid ppid vsz rss pcpu comm args' STDERR: Warning: bad syntax, perhaps a bogus '-'? See http://procps.sf.net/faq.html System call sent warnings to stderr PROCS WARNING: 345 processes >From the FAQ of procps: 'Why does "ps -aux" complain about a bogus '-'? 'According to the POSIX and UNIX standards, the above command asks to display all processes with a TTY (generally the commands users are running) plus all processes owned by a user named "x". If that user doesn't exist, then ps will assume you really meant "ps aux". The warning is given to gently break you of a habit that will cause you trouble if a user named "x" were created.' Thus the syntax of ps must be corrected. We should get rid of the "-" on "/bin/ps -axwo..." In fact, if I change PS_COMMAND manually on config.h the plugin works as expected: [root at nagios plugins]# ./check_procs PROCS OK: 470 processes I'm getting this behaviour in Mandrake 10.0, with procps 3.1.15 running on a dual-P4, 1 GB RAM. ---------------------------------------------------------------------- Comment By: Tim (opensourceror55) Date: 2005-05-10 11:19 Message: Logged In: YES user_id=1275574 Correct me if I'm wrong but the options of the ps command haven't actually changed - its just they've added a warning because so many people were confused about the difference between ps -axwo and ps axwo. By leaving it as ps -axwo aren't you just causing more trouble as its the incorrect options? The fact that they work for most people is just luck. Please change it to use the correct options by default and leave a note in the REQUIREMENTS or wherever so that people can edit configure.h if they need to use the broken way, not the other way round. ---------------------------------------------------------------------- Comment By: Ton Voon (tonvoon) Date: 2005-01-27 07:55 Message: Logged In: YES user_id=664364 Paulo, Thanks for the bug report. This problem will have to stand. The configure script tries to work out the best ps command to use, but doesn't trap the stderr output. However, the plugin does, which is why you are getting this problem. Long term, I think I will change the configure script so that it chooses the ps command based on the OS - this seems the best way to move forward, because ordering of the ps checks always seems to break for some OSes. I am loathe to make any changes to configure.in of this scale for the 1.4 release, so I have updated the REQUIREMENTS file to note the change you recommend to config.h. Will work on this in the next major release. Ton ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1106849&group_id=29880 From noreply at sourceforge.net Wed May 11 10:33:43 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed May 11 10:33:43 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1200030 ] check_ntp perl expression does not match some values Message-ID: Bugs item #1200030, was opened at 2005-05-11 10:31 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1200030&group_id=29880 Category: Parsing problem Group: CVS Status: Open Resolution: None Priority: 5 Submitted By: Kenny Raby (kraby) Assigned to: Nobody/Anonymous (nobody) Summary: check_ntp perl expression does not match some values Initial Comment: check_ntp was returning: Use of uninitialized value in concatenation (.) or string at ./check_ntp line 346. The sys.peer line in the ntpq output was: *127.127.7.1 CHU_AUDIO(1) 3 - 66m 64 377 0.000 0.000 0.020 The perl regex was not matching the _, ( or ) changed line 277 from: if (/^(\*|o)([-0-9.\s]+)\s+([-0-9A-Za-z.]+)\s+([-0-9.]+)\s+([lumb-]+)\s+([-0-9m.]+)\s+([-0-9.]+)\s+([-0-9.]+)\s+ ([-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)/) { To: if (/^(\*|o)([-0-9.\s]+)\s+([-0-9A-Za-z_().]+)\s+([-0-9.]+)\s+([lumb-]+)\s+([-0-9hm.]+)\s+([-0-9.mh]+)\s+([-0-9.]+)\s+( [-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)/) { and line 302 from: $c =~ /^(#)([-0-9.\s]+)\s+([-0-9A-Za-z.]+)\s+([-0-9.]+)\s+([lumb-]+)\s+([-0-9m.]+)\s+([-0-9.]+)\s+([-0-9 .]+)\s+([-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)/; to $c =~ /^(#)([-0-9.\s]+)\s+([-0-9A-Za-z_()..]+)\s+([-0-9.]+)\s+([lumb-]+)\s+([-0-9hm.]+)\s+([-0-9.mh]+)\s+([-0-9. ]+)\s+([-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)/; (basically added _() to the $3 check) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1200030&group_id=29880 From ben at clewett.org.uk Thu May 12 05:17:31 2005 From: ben at clewett.org.uk (Ben Clewett) Date: Thu May 12 05:17:31 2005 Subject: [Nagiosplug-devel] Websensor plugin for http://www.eesensors.com sensors Message-ID: <428348D6.9070704@clewett.org.uk> Dear nagiosplug-devel and Esensors, For the environment sensors advertised on the Nagios web site from http://www.eesensors.com. There is an error in the plugin: it fails if the plugin reports Celcius instead of the default Fahrenheit. The plugin also fails to report performance data. As this plugin is not part of the standard plugin distribution, I have included a patch in this email for the nagiosplugin group, and the hope that Esensors may fix their published plugin. PS, the Esensors 'Webserver Configuration' 'Read/Verify' and polling programs also all fail for the same reason. Hoping of some use... Regards, Ben. Patch: --- check_em01.pl.old Fri Dec 12 20:57:14 2003 +++ check_em01.pl Thu May 12 11:53:39 2005 @@ -64,10 +64,11 @@ $response = $ua->request($request); if ($response->is_success) { $resp = $response->content; - if ($resp =~ /E01.*TF\D*([0123456789.]+)\D*HU\D*([0123456789.]+)\D*IL\D*([0123456789.]+)/g) { - $temperature=$1; - $humidity=$2; - $illumination=$3; + if ($resp =~ /E01.*T([CF])\D*([0123456789.]+)\D*HU\D*([0123456789.]+)\D*IL\D*([0123456789.]+)/g) { + $unit=$1; + $temperature=$2; + $humidity=$3; + $illumination=$4; } } } until (($i >= 3) || (defined($temperature))); @@ -83,7 +84,8 @@ $humidity = sprintf("%.1f", $humidity); # format $illumination = sprintf("%.1f", $illumination); # format $humidity =~ s/[_%]//g; -$check_result = "temp: $temperature F, humidity: $humidity\%, illumination: $illumination"; +$check_result = "temp: $temperature $unit, humidity: $humidity\%, illumination: $illumination"; +$check_result = "$check_result | temp=$temperature$unit humidity=$humidity\% illimination=$illumination"; $have_critical=0; From rick at cope.nl Thu May 12 05:54:10 2005 From: rick at cope.nl (Rick van der Zwet) Date: Thu May 12 05:54:10 2005 Subject: [Nagiosplug-devel] Bug at check_dig.c (fix) Message-ID: <42832A10.9090100@cope.nl> Not possible tot specify -p (latest snapshot) Fix: --- check_dig.c Thu May 12 12:01:27 2005 +++ check_dig.c.new Thu May 12 12:01:11 2005 @@ -213,7 +213,7 @@ return ERROR; while (1) { - c = getopt_long (argc, argv, "hVvt:l:H:w:c:T:a:", longopts, &option); + c = getopt_long (argc, argv, "hVvt:l:H:w:c:T:a:p:", longopts, &option); if (c == -1 || c == EOF) break; Cheerz, Rick van der Zwet From mitya at cavia.pp.ru Thu May 12 05:54:13 2005 From: mitya at cavia.pp.ru (Dmitry Sivachenko) Date: Thu May 12 05:54:13 2005 Subject: [Nagiosplug-devel] Bug in check_jabber Message-ID: <20050512101101.GA61077@sinbin.demos.su> Hello! PLease apply the following patch to check_tcp.c. Without it check_jabber always tries to connect via SSL (this is what --ssl option is for). Thanks! --- check_tcp.c.orig Thu Dec 30 03:41:40 2004 +++ check_tcp.c Thu May 12 14:02:13 2005 @@ -196,7 +196,6 @@ EXPECT = strdup("\n"); PROTOCOL=TCP_PROTOCOL; - use_ssl=TRUE; PORT = 5222; } else if (strstr (argv[0], "check_nntps")) { From bclewett at perfparse.org Thu May 12 05:54:14 2005 From: bclewett at perfparse.org (Ben Clewett) Date: Thu May 12 05:54:14 2005 Subject: [Nagiosplug-devel] Sensors Websensor Message-ID: <42834787.7020604@perfparse.org> Dear nagiosplug-devel and Esensors, For the environment sensors advertised on the Nagios web site from http://www.eesensors.com. There is an error in the plugin: it fails if the plugin reports Celcius instead of the default Fahrenheit. The plugin also fails to report performance data. As this plugin is not part of the standard plugin distribution, I have included a patch in this email for the nagiosplugin group, and the hope that Esensors may fix their published plugin. PS, the Esensors 'Webserver Configuration' 'Read/Verify' and polling programs also all fail for the same reason. Hoping of some use... Regards, Ben. Patch: --- check_em01.pl.old Fri Dec 12 20:57:14 2003 +++ check_em01.pl Thu May 12 11:53:39 2005 @@ -64,10 +64,11 @@ $response = $ua->request($request); if ($response->is_success) { $resp = $response->content; - if ($resp =~ /E01.*TF\D*([0123456789.]+)\D*HU\D*([0123456789.]+)\D*IL\D*([0123456789.]+)/g) { - $temperature=$1; - $humidity=$2; - $illumination=$3; + if ($resp =~ /E01.*T([CF])\D*([0123456789.]+)\D*HU\D*([0123456789.]+)\D*IL\D*([0123456789.]+)/g) { + $unit=$1; + $temperature=$2; + $humidity=$3; + $illumination=$4; } } } until (($i >= 3) || (defined($temperature))); @@ -83,7 +84,8 @@ $humidity = sprintf("%.1f", $humidity); # format $illumination = sprintf("%.1f", $illumination); # format $humidity =~ s/[_%]//g; -$check_result = "temp: $temperature F, humidity: $humidity\%, illumination: $illumination"; +$check_result = "temp: $temperature $unit, humidity: $humidity\%, illumination: $illumination"; +$check_result = "$check_result | temp=$temperature$unit humidity=$humidity\% illimination=$illumination"; $have_critical=0; From noreply at sourceforge.net Thu May 12 20:05:49 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Thu May 12 20:05:49 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1201049 ] added perf data to check_cpu Message-ID: Patches item #1201049, was opened at 2005-05-12 17:54 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1201049&group_id=29880 Category: Perf data Group: None Status: Open Resolution: None Priority: 5 Submitted By: monkeymanorg (monkeymanorg) Assigned to: Nobody/Anonymous (nobody) Summary: added perf data to check_cpu Initial Comment: Added performance data... cause graphs are cool ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1201049&group_id=29880 From noreply at sourceforge.net Thu May 12 20:09:19 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Thu May 12 20:09:19 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1201050 ] check_mem with perf data Message-ID: Patches item #1201050, was opened at 2005-05-12 18:00 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1201050&group_id=29880 Category: Enhancement Group: None Status: Open Resolution: None Priority: 5 Submitted By: monkeymanorg (monkeymanorg) Assigned to: Nobody/Anonymous (nobody) Summary: check_mem with perf data Initial Comment: wrote a quick perl script that calculates the percentage of memory usage based on the outputs on `free`. the script has perf data, as well. depending on OS / kernel, you might need to awk out a different group for your needs.. so give it a sanity check. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1201050&group_id=29880 From noreply at sourceforge.net Thu May 12 20:51:44 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Thu May 12 20:51:44 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Feature Requests-1201126 ] check_iftraffic code 13 out of bounds Message-ID: Feature Requests item #1201126, was opened at 2005-05-13 03:49 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=1201126&group_id=29880 Category: None Group: None Status: Open Priority: 5 Submitted By: jhazin (jhazin) Assigned to: Nobody/Anonymous (nobody) Summary: check_iftraffic code 13 out of bounds Initial Comment: Hi When i use this command for test the plugin check_iftraffic: /usr/lib/nagios/plugins/check_iftraffic -H 200.62.42.65 -C public -i if_descr -b 256 -u k -w 80 -c 90 The exit looks fine: Total RX Bytes: 76.98 MB, Total TX Bytes: 35.94 MB
Average Traffic:5.32 kB/s (16.6%) in, 3.98 kB/s (12.5%) out | inUsage=16.6,80,90 outUsage=12.5,80,90 But when i put this from Nagios services configuration file, appears this message in the nagios.log: Warning: Return code of 13 for check of service 'BandWidth' on host 'CLIENT' was out of bounds. The solution of the nagios faq is: The plugin you're using to perform the host or service check is not returning the proper return code when it exits. My services.cfg file is: define service { host_name CLIENT service_description BandWidth is_volatile 0 check_command check_iftraffic!public!if_decr!256! k!80!98 max_check_attempts 5 normal_check_interval 1 retry_check_interval 2 active_checks_enabled 1 passive_checks_enabled 1 check_period 24x7 parallelize_check 0 obsess_over_service 1 check_freshness 0 event_handler_enabled 0 flap_detection_enabled 0 process_perf_data 1 retain_status_information 1 retain_nonstatus_information 1 contact_groups Administrators notification_interval 10 notification_period 24x7 notification_options c notifications_enabled 0 register 1 } Any Ideas?...Thanks Johny ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=1201126&group_id=29880 From noreply at sourceforge.net Mon May 16 15:16:01 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon May 16 15:16:01 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1202797 ] Uninitialized value warning in check_ifoperstatus Message-ID: Bugs item #1202797, was opened at 2005-05-17 00:03 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1202797&group_id=29880 Category: Embedded Perl failure Group: CVS Status: Open Resolution: None Priority: 5 Submitted By: Reuben Farrelly (reuben) Assigned to: Nobody/Anonymous (nobody) Summary: Uninitialized value warning in check_ifoperstatus Initial Comment: I've been seeing this error for the last few weeks with this plugin. This is the message returned by the plugin when invoked via Nagios: **ePN /usr/lib/nagios/plugins/check_ifoperstatus: "Use of uninitialized value in numeric gt (>) at (eval 3257) line 359". Nagios displays an 'orange' status for this check. line 359 looks like this: unless ($snmpkey > 0 || defined $ifdescr){ When the command is executed manually, it looks like this: [root at tornado plugins]# /usr/lib/nagios/plugins/check_ifoperstatus -H 192.168.0.1 -C snmpaccess -d ATM0 OK: Interface ATM0 (index 1) is up.[root at tornado plugins]# (I wonder if a missing CR at the end is a bad thing..) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1202797&group_id=29880 From noreply at sourceforge.net Mon May 16 15:45:22 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon May 16 15:45:22 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1200030 ] check_ntp perl expression does not match some values Message-ID: Bugs item #1200030, was opened at 2005-05-11 13:31 Message generated for change (Comment added) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1200030&group_id=29880 Category: Parsing problem Group: CVS Status: Open Resolution: None Priority: 5 Submitted By: Kenny Raby (kraby) >Assigned to: Subhendu Ghosh (sghosh) Summary: check_ntp perl expression does not match some values Initial Comment: check_ntp was returning: Use of uninitialized value in concatenation (.) or string at ./check_ntp line 346. The sys.peer line in the ntpq output was: *127.127.7.1 CHU_AUDIO(1) 3 - 66m 64 377 0.000 0.000 0.020 The perl regex was not matching the _, ( or ) changed line 277 from: if (/^(\*|o)([-0-9.\s]+)\s+([-0-9A-Za-z.]+)\s+([-0-9.]+)\s+([lumb-]+)\s+([-0-9m.]+)\s+([-0-9.]+)\s+([-0-9.]+)\s+ ([-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)/) { To: if (/^(\*|o)([-0-9.\s]+)\s+([-0-9A-Za-z_().]+)\s+([-0-9.]+)\s+([lumb-]+)\s+([-0-9hm.]+)\s+([-0-9.mh]+)\s+([-0-9.]+)\s+( [-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)/) { and line 302 from: $c =~ /^(#)([-0-9.\s]+)\s+([-0-9A-Za-z.]+)\s+([-0-9.]+)\s+([lumb-]+)\s+([-0-9m.]+)\s+([-0-9.]+)\s+([-0-9 .]+)\s+([-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)/; to $c =~ /^(#)([-0-9.\s]+)\s+([-0-9A-Za-z_()..]+)\s+([-0-9.]+)\s+([lumb-]+)\s+([-0-9hm.]+)\s+([-0-9.mh]+)\s+([-0-9. ]+)\s+([-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)/; (basically added _() to the $3 check) ---------------------------------------------------------------------- >Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-16 18:22 Message: Logged In: YES user_id=46572 Thanks for the report - Any idea what the peer is? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1200030&group_id=29880 From noreply at sourceforge.net Mon May 16 16:11:24 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon May 16 16:11:24 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1202797 ] Uninitialized value warning in check_ifoperstatus Message-ID: Bugs item #1202797, was opened at 2005-05-16 08:03 Message generated for change (Comment added) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1202797&group_id=29880 Category: Embedded Perl failure Group: CVS Status: Open Resolution: None Priority: 5 Submitted By: Reuben Farrelly (reuben) >Assigned to: Subhendu Ghosh (sghosh) Summary: Uninitialized value warning in check_ifoperstatus Initial Comment: I've been seeing this error for the last few weeks with this plugin. This is the message returned by the plugin when invoked via Nagios: **ePN /usr/lib/nagios/plugins/check_ifoperstatus: "Use of uninitialized value in numeric gt (>) at (eval 3257) line 359". Nagios displays an 'orange' status for this check. line 359 looks like this: unless ($snmpkey > 0 || defined $ifdescr){ When the command is executed manually, it looks like this: [root at tornado plugins]# /usr/lib/nagios/plugins/check_ifoperstatus -H 192.168.0.1 -C snmpaccess -d ATM0 OK: Interface ATM0 (index 1) is up.[root at tornado plugins]# (I wonder if a missing CR at the end is a bad thing..) ---------------------------------------------------------------------- >Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-16 18:21 Message: Logged In: YES user_id=46572 This is strange. snmpkey is initialized to 0 and you are using -d so snmpkey should remain at 0. Which version of nagios and plugin? How long has Nagios with ePN been running? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1202797&group_id=29880 From noreply at sourceforge.net Mon May 16 16:29:05 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon May 16 16:29:05 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1202797 ] Uninitialized value warning in check_ifoperstatus Message-ID: Bugs item #1202797, was opened at 2005-05-17 00:03 Message generated for change (Comment added) made by reuben You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1202797&group_id=29880 Category: Embedded Perl failure Group: CVS Status: Open Resolution: None Priority: 5 Submitted By: Reuben Farrelly (reuben) Assigned to: Subhendu Ghosh (sghosh) Summary: Uninitialized value warning in check_ifoperstatus Initial Comment: I've been seeing this error for the last few weeks with this plugin. This is the message returned by the plugin when invoked via Nagios: **ePN /usr/lib/nagios/plugins/check_ifoperstatus: "Use of uninitialized value in numeric gt (>) at (eval 3257) line 359". Nagios displays an 'orange' status for this check. line 359 looks like this: unless ($snmpkey > 0 || defined $ifdescr){ When the command is executed manually, it looks like this: [root at tornado plugins]# /usr/lib/nagios/plugins/check_ifoperstatus -H 192.168.0.1 -C snmpaccess -d ATM0 OK: Interface ATM0 (index 1) is up.[root at tornado plugins]# (I wonder if a missing CR at the end is a bad thing..) ---------------------------------------------------------------------- >Comment By: Reuben Farrelly (reuben) Date: 2005-05-17 11:25 Message: Logged In: YES user_id=26209 Using both -CVS of Nagios and -CVS of nagiosplug... The config on this has not changed for many months.. Is it worth me disabling the ePN to test? ---------------------------------------------------------------------- Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-17 10:21 Message: Logged In: YES user_id=46572 This is strange. snmpkey is initialized to 0 and you are using -d so snmpkey should remain at 0. Which version of nagios and plugin? How long has Nagios with ePN been running? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1202797&group_id=29880 From noreply at sourceforge.net Mon May 16 16:33:04 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon May 16 16:33:04 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1200030 ] check_ntp perl expression does not match some values Message-ID: Bugs item #1200030, was opened at 2005-05-11 10:31 Message generated for change (Comment added) made by kraby You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1200030&group_id=29880 Category: Parsing problem Group: CVS Status: Open Resolution: None Priority: 5 Submitted By: Kenny Raby (kraby) Assigned to: Subhendu Ghosh (sghosh) Summary: check_ntp perl expression does not match some values Initial Comment: check_ntp was returning: Use of uninitialized value in concatenation (.) or string at ./check_ntp line 346. The sys.peer line in the ntpq output was: *127.127.7.1 CHU_AUDIO(1) 3 - 66m 64 377 0.000 0.000 0.020 The perl regex was not matching the _, ( or ) changed line 277 from: if (/^(\*|o)([-0-9.\s]+)\s+([-0-9A-Za-z.]+)\s+([-0-9.]+)\s+([lumb-]+)\s+([-0-9m.]+)\s+([-0-9.]+)\s+([-0-9.]+)\s+ ([-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)/) { To: if (/^(\*|o)([-0-9.\s]+)\s+([-0-9A-Za-z_().]+)\s+([-0-9.]+)\s+([lumb-]+)\s+([-0-9hm.]+)\s+([-0-9.mh]+)\s+([-0-9.]+)\s+( [-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)/) { and line 302 from: $c =~ /^(#)([-0-9.\s]+)\s+([-0-9A-Za-z.]+)\s+([-0-9.]+)\s+([lumb-]+)\s+([-0-9m.]+)\s+([-0-9.]+)\s+([-0-9 .]+)\s+([-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)/; to $c =~ /^(#)([-0-9.\s]+)\s+([-0-9A-Za-z_()..]+)\s+([-0-9.]+)\s+([lumb-]+)\s+([-0-9hm.]+)\s+([-0-9.mh]+)\s+([-0-9. ]+)\s+([-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)/; (basically added _() to the $3 check) ---------------------------------------------------------------------- >Comment By: Kenny Raby (kraby) Date: 2005-05-16 16:30 Message: Logged In: YES user_id=908646 Not exactly. It was a response from a Cisco Router and the line corresponed to the routers own master clock. The show ntp assoc on the router shows: +~127.127.7.1 127.127.7.1 3 24 64 377 0.0 0.00 0.0 (see http://www.cisco.com/warp/public/620/ntpassoc.html ) The ntpq -p from the linux server running Nagios gives: +CHU_AUDIO(1) CHU_AUDIO(1) 3 - 5 64 377 0.000 0.000 0.020 ntpq -p from a Solaris 8 server gives: +CHU(1) CHU(1) 3 - 5 64 377 0.00 0.000 0.02 (note that the routers is actually synced to another ntp source thus this shows only as a candidate) There is a thread here which would indicate this is for a radio. I think it is just seeing the 127.127.7 and assigning it that way since as I say this is a router acting as it's own master so doesn't really have a radio attached (well I don't think so anyway) A google search also brings up this: http://www.hn.edu.cn/book/NetWork/NetworkingBookshelf_2ndEd/tshoot/ch11_03.htm ---------------------------------------------------------------------- Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-16 15:22 Message: Logged In: YES user_id=46572 Thanks for the report - Any idea what the peer is? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1200030&group_id=29880 From Matthias.Eble at kaufland.de Tue May 17 10:02:05 2005 From: Matthias.Eble at kaufland.de (Matthias.Eble at kaufland.de) Date: Tue May 17 10:02:05 2005 Subject: [Nagiosplug-devel] additional function for check_disk [Virus checked] Message-ID: Hi list, at the moment, check_disk returns a state != STATE_OK if any of the monitored filesystems has less than -w or -c freespace. In our case, this doesn't meet our needs, since our Oracle databases use more than just one filesystem to store their data. So if there are n data-volumes available, it doesn't matter if one or n-1 volumes get filled 100% as long as one volume remains beyond the warning level. I've got three approaches for solve this problem. First: Introduce an option like -g (--group) followed by a comma_seperated_list of partitions/lvols/mountpoints which are to group. Second: Use a own nrpe command for every group of filesystems and introduce a flag like -g (in addition to multiple -p options) to tell check_disk to return warn/error if all filesystems monitored by this command get full Third: Build an ugly shellscript which executes check_disk for every datafilesystem and return != 0 if all of these checks return !=0. A further parameter could be sth like minimum_filesystems_ok to decide if the state is ok if 1,2,3,... filesystems of a group have more than -w/-c free space. What do you think about it? Is the check_disk plugin is the right place to reproduce a functionality like this. Does anybody know applications like Oracle which use more than one filesystems for the same purpose? Thanks a lot Matthias From nagios.user at gmail.com Tue May 17 10:37:11 2005 From: nagios.user at gmail.com (nagios admin) Date: Tue May 17 10:37:11 2005 Subject: [Nagiosplug-devel] Check_snmp for Perfparse Message-ID: <7067681105051710344a684086@mail.gmail.com> Does anyone have or know where I can get a check_snmp script that will pass performance data to perfparse? From ae at op5.se Tue May 17 10:55:09 2005 From: ae at op5.se (Andreas Ericsson) Date: Tue May 17 10:55:09 2005 Subject: [Nagiosplug-devel] additional function for check_disk [Virus checked] In-Reply-To: References: Message-ID: <428A2F49.7010802@op5.se> Matthias.Eble at kaufland.de wrote: > Hi list, > > at the moment, check_disk returns a state != STATE_OK if any of the > monitored filesystems has less than -w or -c freespace. > > In our case, this doesn't meet our needs, since our Oracle databases use > more than just one filesystem to store their data. > So if there are n data-volumes available, it doesn't matter if one or n-1 > volumes get filled 100% as long as one volume remains beyond > the warning level. > > I've got three approaches for solve this problem. > > First: > Introduce an option like -g (--group) followed by a comma_seperated_list > of partitions/lvols/mountpoints which are to group. > Probably the cleanest solution, or possibly to add check_disk_group as its own command. > > Second: > Use a own nrpe command for every group of filesystems and introduce a flag > like -g (in addition to multiple -p options) to tell check_disk to return > warn/error if all > filesystems monitored by this command get full > > Third: > Build an ugly shellscript which executes check_disk for every > datafilesystem and return != 0 if all of these checks return !=0. > Shell is good for prototyping, but the functionality would be equivalent to that of check_cluster (or check_cluster2, I can't remember). > > A further parameter could be sth like minimum_filesystems_ok to decide if > the state is ok if 1,2,3,... filesystems of a group have more than -w/-c > free space. > > > What do you think about it? Hack away. A clean patch is almost certain to be included upstream. > Is the check_disk plugin is the right place to reproduce a functionality > like this. > > Does anybody know applications like Oracle which use more than one > filesystems for the same purpose? > Samba and various ftp servers in different setups. I'm sure there are more scenarios where this can be interesting. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Lead Developer From noreply at sourceforge.net Wed May 18 13:50:49 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed May 18 13:50:49 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1204541 ] check_ntp returns Critical when offset = 0.000000 Message-ID: Bugs item #1204541, was opened at 2005-05-18 13:48 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1204541&group_id=29880 Category: Parsing problem Group: None Status: Open Resolution: None Priority: 5 Submitted By: Kenny Raby (kraby) Assigned to: Nobody/Anonymous (nobody) Summary: check_ntp returns Critical when offset = 0.000000 Initial Comment: Debian sarge system: check_ntp (nagios-plugins 1.4) 1.20 Occasionally when checking the NTP on the server on which Nagios is running I get (IP Address obsured): NTP CRITICAL: server x.x.x.x, stratum 4, offset 0.000000, delay 0.02565 I think these are the lines in the code: 203 # An offset of 0.000000 with an error is probably bogus. Actually, 204 # it's probably always bogus, but let's be paranoid here. 205 if ($offset == 0) { undef $offset;} 206 207 $ntpdate_error = defined ($offset) ? $ERRORS{"OK"} : $ERRORS{"CRITICAL"}; 208 print "ntperr = $ntpdate_error \n" if $verbose; In this case I do not beleive the offset of 0.000000 is bogus. The first part of the output with a -v is: server x.x.x.x, stratum 3, offset 0.000000, delay 0.02563 ntperr = 2 18 May 13:39:23 ntpdate[23726]: adjust time server x.x.x.x offset 0.000000 sec ntperr = 2 Since these "CRITICAL" failures cause false alerts for me I just commented out line 205 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1204541&group_id=29880 From noreply at sourceforge.net Wed May 18 16:37:36 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed May 18 16:37:36 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1204636 ] check_ntp gives error when only one unsync'd candidate Message-ID: Bugs item #1204636, was opened at 2005-05-18 16:35 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1204636&group_id=29880 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Kenny Raby (kraby) Assigned to: Nobody/Anonymous (nobody) Summary: check_ntp gives error when only one unsync'd candidate Initial Comment: check_ntp (nagios-plugins 1.4) 1.20 If there is only one candidate and the server is not syncronized to it you get the following error: Use of uninitialized value in concatenation (.) or string at ./check_ntp line 346. NTP UNKNOWN: Jitter too high check_ntp -v shows (ip addresses masked): server x.x.x.x, stratum 2, offset -0.000264, delay 0.05827 ntperr = 0 18 May 16:23:19 ntpdate[24669]: adjust time server x.x.x.x offset -0.000264 sec ntperr = 0 remote refid st t when poll reach delay offset jitter ============================================================================== #y.y.y.y .GPS. 1 u 1088 1024 236 33.020 0.149 1000.06 Candiate count= 1 Use of uninitialized value in concatenation (.) or string at ./check_ntp line 346. NTP UNKNOWN: Jitter too high After testing it looks like this line might be responsible for problems with just one candidate: 300 if ($#candidates >0) { I changed it to: if ($#candidates >=0) { And now verbose output becomes: server x.x.x.x, stratum 2, offset -0.000354, delay 0.05830 ntperr = 0 18 May 16:33:01 ntpdate[13054]: adjust time server x.x.x.x offset -0.000354 sec ntperr = 0 remote refid st t when poll reach delay offset jitter ============================================================================== #y.y.y.y .GPS. 1 u 1670 1024 236 33.020 0.149 1000.06 Candiate count= 1 candidate match #y.y.y.y .GPS. 1 u 1670 1024 236 33.020 0.149 1000.06 NTP WARNING: Jitter 1000.06 too high Note in particular the "candidate match" line which did not appear before the change. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1204636&group_id=29880 From noreply at sourceforge.net Thu May 19 05:57:12 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Thu May 19 05:57:12 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-822662 ] check_tcp does not return "TCP CRITICAL" Message-ID: Bugs item #822662, was opened at 2003-10-13 12:00 Message generated for change (Comment added) made by funderburg You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=822662&group_id=29880 Category: Parsing problem Group: None Status: Open Resolution: None Priority: 5 Submitted By: Hugo Monteiro (hvm_pt) Assigned to: Jeremy T. Bouse (undrgrid) Summary: check_tcp does not return "TCP CRITICAL" Initial Comment: check_tcp plugin should return a "TCP CRITICAL: Connection refused by host" when the tcp service port checked is down. example: "check_tcp server1 -p 3128" (SQUID Port) If the squid service is down we get a "Connection refused by host" but we should get a "TCP CRITICAL: etc.." since this service is down. Because of this, Nagios puts this service in the critical services group, but we can't get any availability report because services checked by this plugin (using check_tcp xxx -p xxxx) are not returning valid exit codes/echoes: "TCP OK", "TCP WARNING" or "TCP CRITICAL". This service check not even appear has unknown!?!! ---------------------------------------------------------------------- Comment By: Chris Funderburg (funderburg) Date: 2005-05-19 13:54 Message: Logged In: YES user_id=10827 This still appears to not work even in CVS code. Is Nagios not being maintained anymore ? ---------------------------------------------------------------------- Comment By: Jeremy T. Bouse (undrgrid) Date: 2003-10-13 17:23 Message: Logged In: YES user_id=10485 I believe if you check the contents of nagios-10-10-2003-00.log thru nagios-10-10-2003-23.log you would find that all the entries are for the same day but the logs have been truncated because they grew to be too long... What you need to do when doing reports is to tell it that it can go back through more logs by setting the "Backtracked Archives" to higher than the default (which for me is 2)... ---------------------------------------------------------------------- Comment By: Ton Voon (tonvoon) Date: 2003-10-13 16:48 Message: Logged In: YES user_id=664364 I had a problem with extra nagios logs being created (with - 23). It turned out to be an NTP problem on the server I was using. See http://www.nagios.org/faqs/viewfaq.php? faq_id=93 for the resolution. ---------------------------------------------------------------------- Comment By: Hugo Monteiro (hvm_pt) Date: 2003-10-13 16:37 Message: Logged In: YES user_id=12156 Additional notes: The exit code seems to be valid to NAGIOS process, it can process it well. The problem was that something broke the archived LOG, it appeared "nagios-10-10-2003-23.log" (notice the -23) instead of "nagios-10-10-2003-00.log". That was why this services didn't appear in the Availability Report. (I'm still searching what caused this.) Besides this, i've added the following lines to 'netutils.c' starting line 309: -- cut here -- printf ("CONNECTION CRITICAL: "); --- end cut --- So, if we cannot make a connection it will print something like CONNECTION CRITICAL: "+"Error message from the 'switch/case on the line below"' example: "CONNECTION CRITICAL: Connection refused by host." PS: Check all information i sent and see if this really is an check_tcp plugin issue, and something needs to be modified, or if this bug report can be closed. ---------------------------------------------------------------------- Comment By: Jeremy T. Bouse (undrgrid) Date: 2003-10-13 14:28 Message: Logged In: YES user_id=10485 As I've done quite a few changes in the current CVS HEAD version of the check_tcp code I believe I know where this problem lies. It seems to be in the actual connection code and not in the processing of the reply as it never gets the connection socket to open. I'll look into it and see if this is possible to preface with "TCP CRITICAL" however the code to my knowledge DOES return the proper exit code it is just the human readable details that is failing to display. ---------------------------------------------------------------------- Comment By: Hugo Monteiro (hvm_pt) Date: 2003-10-13 12:46 Message: Logged In: YES user_id=12156 The problem seems to be in "netutils.c" file between line 308 and 320. Even if this errors are not known, a plugin should always return a known error (OK, WARNING, CRITICAL or UNKNOWN) if it sends anything besides this, it will break Nagios service information (reports, stats, etc.) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=822662&group_id=29880 From noreply at sourceforge.net Thu May 19 09:04:39 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Thu May 19 09:04:39 2005 Subject: [Nagiosplug-devel] [ nagiosplug-New Plugins-1205091 ] Jabber server checking Message-ID: New Plugins item #1205091, was opened at 2005-05-19 18:03 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1205091&group_id=29880 Category: Perl plugin Group: None Status: Open Resolution: None Priority: 5 Submitted By: C.Doblado (cdoblado) Assigned to: Nobody/Anonymous (nobody) Summary: Jabber server checking Initial Comment: Perl plugin for monitoring the status of a Jabber server running in a remote host. Developed in Perl, it receives as argument the server ip address or hostname and optionally, the port where Jabber should be running (the default is 5222). Help and version options are also available. The output may be OK, CRITICAL or UNKNOWN status. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1205091&group_id=29880 From noreply at sourceforge.net Thu May 19 09:09:00 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Thu May 19 09:09:00 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1190900 ] Jabber Plugin Message-ID: Patches item #1190900, was opened at 2005-04-27 12:22 Message generated for change (Settings changed) made by cdoblado You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1190900&group_id=29880 Category: None Group: None Status: Open >Resolution: Invalid Priority: 5 Submitted By: C.Doblado (cdoblado) Assigned to: Nobody/Anonymous (nobody) Summary: Jabber Plugin Initial Comment: Plugin for monitoring the status of a Jabber server running in a remote host. Developed in Perl, it receives as argument the server ip address or hostname and optionally, the port where Jabber should be running (the default is 5222). Help and version options are also available. The output may be OK, CRITICAL or UNKNOWN status. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1190900&group_id=29880 From noreply at sourceforge.net Thu May 19 14:48:31 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Thu May 19 14:48:31 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1205309 ] check_ntp gives error when only one unsync'd candidate Message-ID: Bugs item #1205309, was opened at 2005-05-19 14:44 Message generated for change (Comment added) made by kraby You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1205309&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Duplicate Priority: 5 Submitted By: Kenny Raby (kraby) Assigned to: Nobody/Anonymous (nobody) Summary: check_ntp gives error when only one unsync'd candidate Initial Comment: check_ntp (nagios-plugins 1.4) 1.20 If there is only one candidate and the server is not syncronized to it you get the following error: Use of uninitialized value in concatenation (.) or string at ./check_ntp line 346. NTP UNKNOWN: Jitter too high check_ntp -v shows (ip addresses masked): server x.x.x.x, stratum 2, offset -0.000264, delay 0.05827 ntperr = 0 18 May 16:23:19 ntpdate[24669]: adjust time server x.x.x.x offset -0.000264 sec ntperr = 0 remote refid st t when poll reach delay offset jitter ============================================================================== #y.y.y.y .GPS. 1 u 1088 1024 236 33.020 0.149 1000.06 Candiate count= 1 Use of uninitialized value in concatenation (.) or string at ./check_ntp line 346. NTP UNKNOWN: Jitter too high After testing it looks like this line might be responsible for problems with just one candidate: 300 if ($#candidates >0) { I changed it to: if ($#candidates >=0) { And now verbose output becomes: server x.x.x.x, stratum 2, offset -0.000354, delay 0.05830 ntperr = 0 18 May 16:33:01 ntpdate[13054]: adjust time server x.x.x.x offset -0.000354 sec ntperr = 0 remote refid st t when poll reach delay offset jitter ============================================================================== #y.y.y.y .GPS. 1 u 1670 1024 236 33.020 0.149 1000.06 Candiate count= 1 candidate match #y.y.y.y .GPS. 1 u 1670 1024 236 33.020 0.149 1000.06 NTP WARNING: Jitter 1000.06 too high Note in particular the "candidate match" line which did not appear before the change. ---------------------------------------------------------------------- >Comment By: Kenny Raby (kraby) Date: 2005-05-19 14:46 Message: Logged In: YES user_id=908646 Ack! Don't do a refresh on the summary page after submitting a bug the previous day... closing as duplicate ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1205309&group_id=29880 From noreply at sourceforge.net Thu May 19 14:49:24 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Thu May 19 14:49:24 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1205309 ] check_ntp gives error when only one unsync'd candidate Message-ID: Bugs item #1205309, was opened at 2005-05-19 14:44 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1205309&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Kenny Raby (kraby) Assigned to: Nobody/Anonymous (nobody) Summary: check_ntp gives error when only one unsync'd candidate Initial Comment: check_ntp (nagios-plugins 1.4) 1.20 If there is only one candidate and the server is not syncronized to it you get the following error: Use of uninitialized value in concatenation (.) or string at ./check_ntp line 346. NTP UNKNOWN: Jitter too high check_ntp -v shows (ip addresses masked): server x.x.x.x, stratum 2, offset -0.000264, delay 0.05827 ntperr = 0 18 May 16:23:19 ntpdate[24669]: adjust time server x.x.x.x offset -0.000264 sec ntperr = 0 remote refid st t when poll reach delay offset jitter ============================================================================== #y.y.y.y .GPS. 1 u 1088 1024 236 33.020 0.149 1000.06 Candiate count= 1 Use of uninitialized value in concatenation (.) or string at ./check_ntp line 346. NTP UNKNOWN: Jitter too high After testing it looks like this line might be responsible for problems with just one candidate: 300 if ($#candidates >0) { I changed it to: if ($#candidates >=0) { And now verbose output becomes: server x.x.x.x, stratum 2, offset -0.000354, delay 0.05830 ntperr = 0 18 May 16:33:01 ntpdate[13054]: adjust time server x.x.x.x offset -0.000354 sec ntperr = 0 remote refid st t when poll reach delay offset jitter ============================================================================== #y.y.y.y .GPS. 1 u 1670 1024 236 33.020 0.149 1000.06 Candiate count= 1 candidate match #y.y.y.y .GPS. 1 u 1670 1024 236 33.020 0.149 1000.06 NTP WARNING: Jitter 1000.06 too high Note in particular the "candidate match" line which did not appear before the change. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1205309&group_id=29880 From nagios.user at gmail.com Thu May 19 15:09:01 2005 From: nagios.user at gmail.com (nagios admin) Date: Thu May 19 15:09:01 2005 Subject: [Nagiosplug-devel] Check_snmp for Perfparse Message-ID: <7067681105051807566f6031f6@mail.gmail.com> Hi everyone! Does anyone have or know where I can get a check_snmp script that will pass performance data to perfparse? From f.a.g.luteijn at knoware.nl Thu May 19 15:09:04 2005 From: f.a.g.luteijn at knoware.nl (Frans Luteijn) Date: Thu May 19 15:09:04 2005 Subject: [Nagiosplug-devel] some patches Message-ID: <428CFBBF.5EB9A471@knoware.nl> Dear Nagiosplugin developers, I would like to propose the following changes in the attached file: in the plugin check_disk_smb I have added the option "-a" for the address of the checked server if it is in another network. Further, it is legal to have spaces in windows-hostnames, so I implemented that too. In check_mailq I have disabled the emptying of the PATH-variable, because I got error-messages when executing the plugin. I hope, you will find the changes an enhancement, your sincerely, -- Frans Luteijn PGP PblKey fprnt=C4 87 CE AF BC B6 98 C1 EF 42 A1 9A E2 C0 42 5B GPG PblKey fprnt=ED20 0F25 C233 DC59 3FFA 170E D0BF 15F5 0BA6 1355 -------------- next part -------------- diff -rcN /usr/lib/nagios/plugins.orig/check_disk_smb /usr/lib/nagios/plugins/check_disk_smb *** /usr/lib/nagios/plugins.orig/check_disk_smb Mon Mar 7 05:33:28 2005 --- /usr/lib/nagios/plugins/check_disk_smb Thu May 19 00:15:44 2005 *************** *** 23,29 **** use POSIX; use strict; use Getopt::Long; ! use vars qw($opt_P $opt_V $opt_h $opt_H $opt_s $opt_W $opt_u $opt_p $opt_w $opt_c $verbose); use vars qw($PROGNAME); use lib "/usr/lib/nagios/plugins" ; use utils qw($TIMEOUT %ERRORS &print_revision &support &usage); --- 23,29 ---- use POSIX; use strict; use Getopt::Long; ! use vars qw($opt_P $opt_V $opt_h $opt_H $opt_s $opt_W $opt_u $opt_p $opt_w $opt_c $opt_a $verbose); use vars qw($PROGNAME); use lib "/usr/lib/nagios/plugins" ; use utils qw($TIMEOUT %ERRORS &print_revision &support &usage); *************** *** 49,55 **** "u=s" => \$opt_u, "username=s" => \$opt_u, "s=s" => \$opt_s, "share=s" => \$opt_s, "W=s" => \$opt_W, "workgroup=s" => \$opt_W, ! "H=s" => \$opt_H, "hostname=s" => \$opt_H); if ($opt_V) { print_revision($PROGNAME,'$Revision: 1.10 $'); #' --- 49,56 ---- "u=s" => \$opt_u, "username=s" => \$opt_u, "s=s" => \$opt_s, "share=s" => \$opt_s, "W=s" => \$opt_W, "workgroup=s" => \$opt_W, ! "H=s" => \$opt_H, "hostname=s" => \$opt_H, ! "a=s" => \$opt_a, "address=s" => \$opt_a); if ($opt_V) { print_revision($PROGNAME,'$Revision: 1.10 $'); #' *************** *** 65,71 **** # Options checking ($opt_H) || ($opt_H = shift) || usage("Host name not specified\n"); ! my $host = $1 if ($opt_H =~ /^([-_.A-Za-z0-9]+\$?)$/); ($host) || usage("Invalid host: $opt_H\n"); ($opt_s) || ($opt_s = shift) || usage("Share volume not specified\n"); --- 66,72 ---- # Options checking ($opt_H) || ($opt_H = shift) || usage("Host name not specified\n"); ! my $host = $1 if ($opt_H =~ /^([-_.A-Za-z0-9 ]+\$?)$/); ($host) || usage("Invalid host: $opt_H\n"); ($opt_s) || ($opt_s = shift) || usage("Share volume not specified\n"); *************** *** 105,110 **** --- 106,113 ---- my $workgroup = $1 if (defined($opt_W) && $opt_W =~ /(.*)/); + my $address = $1 if (defined($opt_a) && $opt_a =~ /(.*)/); + # end of options checking *************** *** 123,132 **** # Execute an "ls" on the share using smbclient program # get the results into $res if (defined($workgroup)) { ! $res = qx/$smbclient \/\/$host\/$share $pass -W $workgroup -U $user $smbclientoptions -c ls/; } else { ! print "$smbclient " . "\/\/$host\/$share" ." $pass -U $user $smbclientoptions -c ls\n" if ($verbose); ! $res = qx/$smbclient \/\/$host\/$share $pass -U $user $smbclientoptions -c ls/; } #Turn off alarm alarm(0); --- 126,146 ---- # Execute an "ls" on the share using smbclient program # get the results into $res if (defined($workgroup)) { ! if (defined($address)) { ! print "$smbclient " . "\/\/$host\/$share" ." $pass -W $workgroup -U $user $smbclientoptions -I $address -c ls\n" if ($verbose); ! $res = qx/$smbclient "\/\/$host\/$share" $pass -W $workgroup -U $user $smbclientoptions -I $address -c ls/; ! } else { ! print "$smbclient " . "\/\/$host\/$share" ." $pass -W $workgroup -U $user $smbclientoptions -c ls\n" if ($verbose); ! $res = qx/$smbclient "\/\/$host\/$share" $pass -W $workgroup -U $user $smbclientoptions -c ls/; ! } } else { ! if (defined($address)) { ! print "$smbclient " . "\/\/$host\/$share" ." $pass -U $user $smbclientoptions -I $address -c ls\n" if ($verbose); ! $res = qx/$smbclient "\/\/$host\/$share" $pass -U $user $smbclientoptions -I $address -c ls/; ! } else { ! print "$smbclient " . "\/\/$host\/$share" ." $pass -U $user $smbclientoptions -c ls\n" if ($verbose); ! $res = qx/$smbclient "\/\/$host\/$share" $pass -U $user $smbclientoptions -c ls/; ! } } #Turn off alarm alarm(0); *************** *** 231,237 **** sub print_usage () { print "Usage: $PROGNAME -H -s -u -p ! -w -c [-W ] [-P ]\n"; } sub print_help () { --- 245,251 ---- sub print_usage () { print "Usage: $PROGNAME -H -s -u -p ! -w -c [-W ] [-P ] [-a ]\n"; } sub print_help () { *************** *** 249,254 **** --- 263,270 ---- Share name to be tested -W, --workgroup=STRING Workgroup or Domain used (Defaults to \"WORKGROUP\") + -a, --address=IP + IP-address of HOST (only necessary if HOST is in another network) -u, --user=STRING Username to log in to server. (Defaults to \"guest\") -p, --password=STRING diff -rcN /usr/lib/nagios/plugins.orig/check_mailq /usr/lib/nagios/plugins/check_mailq *** /usr/lib/nagios/plugins.orig/check_mailq Mon Mar 7 05:33:29 2005 --- /usr/lib/nagios/plugins/check_mailq Wed May 18 23:52:33 2005 *************** *** 40,46 **** sub print_usage (); sub process_arguments (); ! $ENV{'PATH'}=''; $ENV{'BASH_ENV'}=''; $ENV{'ENV'}=''; $PROGNAME = "check_mailq"; --- 40,46 ---- sub print_usage (); sub process_arguments (); ! #$ENV{'PATH'}=''; $ENV{'BASH_ENV'}=''; $ENV{'ENV'}=''; $PROGNAME = "check_mailq"; From seanius at seanius.net Fri May 20 07:38:04 2005 From: seanius at seanius.net (sean finney) Date: Fri May 20 07:38:04 2005 Subject: [Nagiosplug-devel] some patches In-Reply-To: <428CFBBF.5EB9A471@knoware.nl> References: <428CFBBF.5EB9A471@knoware.nl> Message-ID: <20050520143443.GA32340@seanius.net> hi frans, On Thu, May 19, 2005 at 10:49:03PM +0200, Frans Luteijn wrote: > in the plugin check_disk_smb I have added the option "-a" for the > address of the checked server if it is in another network. Further, it > is legal to have spaces in windows-hostnames, so I implemented that too. > > In check_mailq I have disabled the emptying of the PATH-variable, > because I got error-messages when executing the plugin. thanks for these. i'll see about incorporating them the next time i'm sitting down with the plugins. if you'd like to track the status of the patches, you can open up a patch report for each in the sourceforge tracker. sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From noreply at sourceforge.net Sun May 22 04:45:01 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun May 22 04:45:01 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1202797 ] Uninitialized value warning in check_ifoperstatus Message-ID: Bugs item #1202797, was opened at 2005-05-17 00:03 Message generated for change (Comment added) made by reuben You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1202797&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Embedded Perl failure Group: CVS Status: Open Resolution: None Priority: 5 Submitted By: Reuben Farrelly (reuben) Assigned to: Subhendu Ghosh (sghosh) Summary: Uninitialized value warning in check_ifoperstatus Initial Comment: I've been seeing this error for the last few weeks with this plugin. This is the message returned by the plugin when invoked via Nagios: **ePN /usr/lib/nagios/plugins/check_ifoperstatus: "Use of uninitialized value in numeric gt (>) at (eval 3257) line 359". Nagios displays an 'orange' status for this check. line 359 looks like this: unless ($snmpkey > 0 || defined $ifdescr){ When the command is executed manually, it looks like this: [root at tornado plugins]# /usr/lib/nagios/plugins/check_ifoperstatus -H 192.168.0.1 -C snmpaccess -d ATM0 OK: Interface ATM0 (index 1) is up.[root at tornado plugins]# (I wonder if a missing CR at the end is a bad thing..) ---------------------------------------------------------------------- >Comment By: Reuben Farrelly (reuben) Date: 2005-05-22 23:43 Message: Logged In: YES user_id=26209 Disabled --enable-embedded-perl with Nagios and the error has gone and all looks OK. Shall I close this and re-open a bug with Nagios instead or is this possibly just a bad interaction between the plugin and embedded perl? ---------------------------------------------------------------------- Comment By: Reuben Farrelly (reuben) Date: 2005-05-17 11:25 Message: Logged In: YES user_id=26209 Using both -CVS of Nagios and -CVS of nagiosplug... The config on this has not changed for many months.. Is it worth me disabling the ePN to test? ---------------------------------------------------------------------- Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-17 10:21 Message: Logged In: YES user_id=46572 This is strange. snmpkey is initialized to 0 and you are using -d so snmpkey should remain at 0. Which version of nagios and plugin? How long has Nagios with ePN been running? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1202797&group_id=29880 From noreply at sourceforge.net Sun May 22 07:49:43 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun May 22 07:49:43 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1204636 ] check_ntp gives error when only one unsync'd candidate Message-ID: Bugs item #1204636, was opened at 2005-05-18 19:35 Message generated for change (Settings changed) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1204636&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Kenny Raby (kraby) >Assigned to: Subhendu Ghosh (sghosh) Summary: check_ntp gives error when only one unsync'd candidate Initial Comment: check_ntp (nagios-plugins 1.4) 1.20 If there is only one candidate and the server is not syncronized to it you get the following error: Use of uninitialized value in concatenation (.) or string at ./check_ntp line 346. NTP UNKNOWN: Jitter too high check_ntp -v shows (ip addresses masked): server x.x.x.x, stratum 2, offset -0.000264, delay 0.05827 ntperr = 0 18 May 16:23:19 ntpdate[24669]: adjust time server x.x.x.x offset -0.000264 sec ntperr = 0 remote refid st t when poll reach delay offset jitter ============================================================================== #y.y.y.y .GPS. 1 u 1088 1024 236 33.020 0.149 1000.06 Candiate count= 1 Use of uninitialized value in concatenation (.) or string at ./check_ntp line 346. NTP UNKNOWN: Jitter too high After testing it looks like this line might be responsible for problems with just one candidate: 300 if ($#candidates >0) { I changed it to: if ($#candidates >=0) { And now verbose output becomes: server x.x.x.x, stratum 2, offset -0.000354, delay 0.05830 ntperr = 0 18 May 16:33:01 ntpdate[13054]: adjust time server x.x.x.x offset -0.000354 sec ntperr = 0 remote refid st t when poll reach delay offset jitter ============================================================================== #y.y.y.y .GPS. 1 u 1670 1024 236 33.020 0.149 1000.06 Candiate count= 1 candidate match #y.y.y.y .GPS. 1 u 1670 1024 236 33.020 0.149 1000.06 NTP WARNING: Jitter 1000.06 too high Note in particular the "candidate match" line which did not appear before the change. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1204636&group_id=29880 From noreply at sourceforge.net Sun May 22 07:49:47 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun May 22 07:49:47 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1204541 ] check_ntp returns Critical when offset = 0.000000 Message-ID: Bugs item #1204541, was opened at 2005-05-18 16:48 Message generated for change (Settings changed) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1204541&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Parsing problem Group: None Status: Open Resolution: None Priority: 5 Submitted By: Kenny Raby (kraby) >Assigned to: Subhendu Ghosh (sghosh) Summary: check_ntp returns Critical when offset = 0.000000 Initial Comment: Debian sarge system: check_ntp (nagios-plugins 1.4) 1.20 Occasionally when checking the NTP on the server on which Nagios is running I get (IP Address obsured): NTP CRITICAL: server x.x.x.x, stratum 4, offset 0.000000, delay 0.02565 I think these are the lines in the code: 203 # An offset of 0.000000 with an error is probably bogus. Actually, 204 # it's probably always bogus, but let's be paranoid here. 205 if ($offset == 0) { undef $offset;} 206 207 $ntpdate_error = defined ($offset) ? $ERRORS{"OK"} : $ERRORS{"CRITICAL"}; 208 print "ntperr = $ntpdate_error \n" if $verbose; In this case I do not beleive the offset of 0.000000 is bogus. The first part of the output with a -v is: server x.x.x.x, stratum 3, offset 0.000000, delay 0.02563 ntperr = 2 18 May 13:39:23 ntpdate[23726]: adjust time server x.x.x.x offset 0.000000 sec ntperr = 2 Since these "CRITICAL" failures cause false alerts for me I just commented out line 205 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1204541&group_id=29880 From noreply at sourceforge.net Sun May 22 07:50:00 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun May 22 07:50:00 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1202797 ] Uninitialized value warning in check_ifoperstatus Message-ID: Bugs item #1202797, was opened at 2005-05-16 08:03 Message generated for change (Comment added) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1202797&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Embedded Perl failure Group: CVS Status: Open Resolution: None Priority: 5 Submitted By: Reuben Farrelly (reuben) Assigned to: Subhendu Ghosh (sghosh) Summary: Uninitialized value warning in check_ifoperstatus Initial Comment: I've been seeing this error for the last few weeks with this plugin. This is the message returned by the plugin when invoked via Nagios: **ePN /usr/lib/nagios/plugins/check_ifoperstatus: "Use of uninitialized value in numeric gt (>) at (eval 3257) line 359". Nagios displays an 'orange' status for this check. line 359 looks like this: unless ($snmpkey > 0 || defined $ifdescr){ When the command is executed manually, it looks like this: [root at tornado plugins]# /usr/lib/nagios/plugins/check_ifoperstatus -H 192.168.0.1 -C snmpaccess -d ATM0 OK: Interface ATM0 (index 1) is up.[root at tornado plugins]# (I wonder if a missing CR at the end is a bad thing..) ---------------------------------------------------------------------- >Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-22 10:47 Message: Logged In: YES user_id=46572 No - leave this open. Need to check what ePN changes have happened to cause this. ---------------------------------------------------------------------- Comment By: Reuben Farrelly (reuben) Date: 2005-05-22 07:43 Message: Logged In: YES user_id=26209 Disabled --enable-embedded-perl with Nagios and the error has gone and all looks OK. Shall I close this and re-open a bug with Nagios instead or is this possibly just a bad interaction between the plugin and embedded perl? ---------------------------------------------------------------------- Comment By: Reuben Farrelly (reuben) Date: 2005-05-16 19:25 Message: Logged In: YES user_id=26209 Using both -CVS of Nagios and -CVS of nagiosplug... The config on this has not changed for many months.. Is it worth me disabling the ePN to test? ---------------------------------------------------------------------- Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-16 18:21 Message: Logged In: YES user_id=46572 This is strange. snmpkey is initialized to 0 and you are using -d so snmpkey should remain at 0. Which version of nagios and plugin? How long has Nagios with ePN been running? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1202797&group_id=29880 From noreply at sourceforge.net Sun May 22 17:19:32 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun May 22 17:19:32 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1202797 ] Uninitialized value warning in check_ifoperstatus Message-ID: Bugs item #1202797, was opened at 2005-05-16 12:03 Message generated for change (Comment added) made by stanleyhopcroft You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1202797&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Embedded Perl failure Group: CVS Status: Open Resolution: None Priority: 5 Submitted By: Reuben Farrelly (reuben) Assigned to: Subhendu Ghosh (sghosh) Summary: Uninitialized value warning in check_ifoperstatus Initial Comment: I've been seeing this error for the last few weeks with this plugin. This is the message returned by the plugin when invoked via Nagios: **ePN /usr/lib/nagios/plugins/check_ifoperstatus: "Use of uninitialized value in numeric gt (>) at (eval 3257) line 359". Nagios displays an 'orange' status for this check. line 359 looks like this: unless ($snmpkey > 0 || defined $ifdescr){ When the command is executed manually, it looks like this: [root at tornado plugins]# /usr/lib/nagios/plugins/check_ifoperstatus -H 192.168.0.1 -C snmpaccess -d ATM0 OK: Interface ATM0 (index 1) is up.[root at tornado plugins]# (I wonder if a missing CR at the end is a bad thing..) ---------------------------------------------------------------------- >Comment By: Stanley Hopcroft (stanleyhopcroft) Date: 2005-05-23 00:16 Message: Logged In: YES user_id=395628 Dear Folks, The problem is that the plugin does _not_ work with embedded Perl Nagios (ePN). ePN requires that plugins be written with more care than those designed to be run by a shell (why ? some features such as handles do not work; and, in general, variables and their values persist from the last run, so their is more opportunity for things to go wrong. Also, ePN runs all code under the 'strict' pragma, regardless of whether there is a 'use strict' in the plugin. This leads to some plugins failing to run under ePN). As far as ePN changes go, there have been quite a lot of changes in the 2.x code base, none related to how the plugin is compiled or run (the changes have been attempts to deal with memory leaks related to the threading changes in Nag 2.x and threaded Perls) None of my 55 Perl plugins have malfunctioned (except one that uses the Expect module. This is also a problem with ePN. Plugins that tie or re-open stdout are not going to play well with ePN because it ties stdout to a scalar so that the plugin output can be captured) during this time. My conclusion is 1 this is not an ePN problem - so this is the appropriate support venue 2 the problem is with the plugin text not cooperating with the use strict compilation environment in ePN. The plugin should be patched so that it runs under ePN. FWIW, the best way to do this is run it under the ePN simulator (contrib/mini_epn.c if this has been updated to correspond to the CVS .. Call me otherwise) with the /contrib copy of p1.pl edited to log to suitable file (DEBUG_LOG_PATH) and the DEBUG_LEVEL set to PLUGIN_DUMP. This should nail where the problem is. I have up to date versions of the plugin validation tools if anyone wants them (tools to check if plugins play nicely with ePN). 2 ---------------------------------------------------------------------- Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-22 14:47 Message: Logged In: YES user_id=46572 No - leave this open. Need to check what ePN changes have happened to cause this. ---------------------------------------------------------------------- Comment By: Reuben Farrelly (reuben) Date: 2005-05-22 11:43 Message: Logged In: YES user_id=26209 Disabled --enable-embedded-perl with Nagios and the error has gone and all looks OK. Shall I close this and re-open a bug with Nagios instead or is this possibly just a bad interaction between the plugin and embedded perl? ---------------------------------------------------------------------- Comment By: Reuben Farrelly (reuben) Date: 2005-05-16 23:25 Message: Logged In: YES user_id=26209 Using both -CVS of Nagios and -CVS of nagiosplug... The config on this has not changed for many months.. Is it worth me disabling the ePN to test? ---------------------------------------------------------------------- Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-16 22:21 Message: Logged In: YES user_id=46572 This is strange. snmpkey is initialized to 0 and you are using -d so snmpkey should remain at 0. Which version of nagios and plugin? How long has Nagios with ePN been running? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1202797&group_id=29880 From noreply at sourceforge.net Sun May 22 22:00:01 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun May 22 22:00:01 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1117037 ] rpmbuild for 1.4 fails Message-ID: Bugs item #1117037, was opened at 2005-02-05 17:08 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1117037&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: Compilation Group: None Status: Open Resolution: None Priority: 5 Submitted By: Martijn Lievaart (mappie) >Assigned to: M. Sean Finney (seanius) Summary: rpmbuild for 1.4 fails Initial Comment: Trying to build an rpm (rpmbuild -tb nagios-plugins-1.4.tar.gz) I get: RPM build errors: File not found: /var/tmp/nagios-plugins-1.4-1-root-martijn/usr/lib/nagios/plugins/check_fping File not found: /var/tmp/nagios-plugins-1.4-1-root-martijn/usr/lib/nagios/plugins/check_game File not found: /var/tmp/nagios-plugins-1.4-1-root-martijn/usr/lib/nagios/plugins/check_radius Any clues? TIA, M4 ---------------------------------------------------------------------- >Comment By: M. Sean Finney (seanius) Date: 2005-05-23 00:58 Message: Logged In: YES user_id=226838 hi, this problem is probably because the stuff needed to build those plugins do not exist on your system, but the plugins are listed in the files list of the spec file. i'll commit a fix in CVS, though i don't know what we'll do about the version in 1.4. i'll post a comment to the devel mailing list and see what the other folks think. ---------------------------------------------------------------------- Comment By: Martijn Lievaart (mappie) Date: 2005-02-06 08:59 Message: Logged In: YES user_id=984925 BTW, this is on FC1, although I don't think it matters. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1117037&group_id=29880 From noreply at sourceforge.net Mon May 23 09:51:29 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon May 23 09:51:29 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1204541 ] check_ntp returns Critical when offset = 0.000000 Message-ID: Bugs item #1204541, was opened at 2005-05-18 20:48 Message generated for change (Comment added) made by lehrhardt You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1204541&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Parsing problem Group: None Status: Open Resolution: None Priority: 5 Submitted By: Kenny Raby (kraby) Assigned to: Subhendu Ghosh (sghosh) Summary: check_ntp returns Critical when offset = 0.000000 Initial Comment: Debian sarge system: check_ntp (nagios-plugins 1.4) 1.20 Occasionally when checking the NTP on the server on which Nagios is running I get (IP Address obsured): NTP CRITICAL: server x.x.x.x, stratum 4, offset 0.000000, delay 0.02565 I think these are the lines in the code: 203 # An offset of 0.000000 with an error is probably bogus. Actually, 204 # it's probably always bogus, but let's be paranoid here. 205 if ($offset == 0) { undef $offset;} 206 207 $ntpdate_error = defined ($offset) ? $ERRORS{"OK"} : $ERRORS{"CRITICAL"}; 208 print "ntperr = $ntpdate_error \n" if $verbose; In this case I do not beleive the offset of 0.000000 is bogus. The first part of the output with a -v is: server x.x.x.x, stratum 3, offset 0.000000, delay 0.02563 ntperr = 2 18 May 13:39:23 ntpdate[23726]: adjust time server x.x.x.x offset 0.000000 sec ntperr = 2 Since these "CRITICAL" failures cause false alerts for me I just commented out line 205 ---------------------------------------------------------------------- Comment By: Lars Ehrhardt (lehrhardt) Date: 2005-05-23 16:36 Message: Logged In: YES user_id=709554 I can confirm the error, an offset of 0.000000 occurs quite frequently on our hosts and trigger those false ntp nagios alerts. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1204541&group_id=29880 From ae at op5.se Tue May 24 02:23:56 2005 From: ae at op5.se (Andreas Ericsson) Date: Tue May 24 02:23:56 2005 Subject: [Nagiosplug-devel] Code cleanup patch Message-ID: <4292DAF8.9070507@op5.se> Ahoy. Although I know it's most likely useless to post patches to this list, and even more so to the tracker item (I don't blame you, the amount of junk arriving there is astounding), I thought I'd give submitting this small cleanup a try anyways. The rationale is that fewer function calls and less code is a Good Thing, while wrapper functions that doesn't allow the compiler to optimize sibling calls is a Bad Thing. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Lead Developer -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: nagiosplug-wrapper-macros.diff URL: From seanius at seanius.net Tue May 24 07:27:14 2005 From: seanius at seanius.net (sean finney) Date: Tue May 24 07:27:14 2005 Subject: [Nagiosplug-devel] Code cleanup patch In-Reply-To: <4292DAF8.9070507@op5.se> References: <4292DAF8.9070507@op5.se> Message-ID: <20050524141634.GA17088@seanius.net> hey, On Tue, May 24, 2005 at 09:42:48AM +0200, Andreas Ericsson wrote: > Although I know it's most likely useless to post patches to this list, especially with such a pessimistic start :) > and even more so to the tracker item (I don't blame you, the amount of > junk arriving there is astounding), I thought I'd give submitting this > small cleanup a try anyways. i just looked over the patch, and it looks like a much better way to do things, and i don't think it should break anything in the larger codebase. i'll commit it the next time i'm doing cvs stuff if someone else doesn't get to it first. sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From ae at op5.se Tue May 24 08:02:08 2005 From: ae at op5.se (Andreas Ericsson) Date: Tue May 24 08:02:08 2005 Subject: [Nagiosplug-devel] Code cleanup patch In-Reply-To: <20050524141634.GA17088@seanius.net> References: <4292DAF8.9070507@op5.se> <20050524141634.GA17088@seanius.net> Message-ID: <42933F74.3040704@op5.se> sean finney wrote: >>and even more so to the tracker item (I don't blame you, the amount of >>junk arriving there is astounding), I thought I'd give submitting this >>small cleanup a try anyways. > > > i just looked over the patch, and it looks like a much better way to > do things, and i don't think it should break anything in the larger > codebase. i'll commit it the next time i'm doing cvs stuff if > someone else doesn't get to it first. > Whoa! Sorry for my previous pessimistic posting, but this is the first time I've gotten a reply other than "send it to the tracker" (where nothing has ever happened). Thanks a million. Sorry if I take this as an invitation to pelt the list with various code cleanups and bugfixes ;). If you'd rather deal with it off-list (IRC? IM?), that's fine by me. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Lead Developer From seanius at seanius.net Tue May 24 10:30:05 2005 From: seanius at seanius.net (sean finney) Date: Tue May 24 10:30:05 2005 Subject: [Nagiosplug-devel] Code cleanup patch In-Reply-To: <42933F74.3040704@op5.se> References: <4292DAF8.9070507@op5.se> <20050524141634.GA17088@seanius.net> <42933F74.3040704@op5.se> Message-ID: <20050524172031.GA18116@seanius.net> hey, On Tue, May 24, 2005 at 04:51:32PM +0200, Andreas Ericsson wrote: > Whoa! Sorry for my previous pessimistic posting, but this is the first > time I've gotten a reply other than "send it to the tracker" (where > nothing has ever happened). Thanks a million. i think submissions should still go there as a general rule, because it does provide a way for everyone to keep a better grasp on the state of things. being relatively new to the development team, i'm also a bit weary of rocking the boat too much on what basically amounts to a procedural issue. > Sorry if I take this as an invitation to pelt the list with various code > cleanups and bugfixes ;). If you'd rather deal with it off-list (IRC? > IM?), that's fine by me. i'll send you my contact info privately, though i'm still going to suggest that you in parallel post into the tracker anything you send to me. sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From ae at op5.se Tue May 24 11:25:58 2005 From: ae at op5.se (Andreas Ericsson) Date: Tue May 24 11:25:58 2005 Subject: [Nagiosplug-devel] Code cleanup patch In-Reply-To: <20050524172031.GA18116@seanius.net> References: <4292DAF8.9070507@op5.se> <20050524141634.GA17088@seanius.net> <42933F74.3040704@op5.se> <20050524172031.GA18116@seanius.net> Message-ID: <42937140.5090905@op5.se> sean finney wrote: > hey, > > On Tue, May 24, 2005 at 04:51:32PM +0200, Andreas Ericsson wrote: > >>Whoa! Sorry for my previous pessimistic posting, but this is the first >>time I've gotten a reply other than "send it to the tracker" (where >>nothing has ever happened). Thanks a million. > > > i think submissions should still go there as a general rule, because > it does provide a way for everyone to keep a better grasp on the state > of things. Hmm... Last time I did (2005-02-18 07:23, according to the tracker), nothing happened. It hasn't even been assigned yet, even though it cleared up about a dozen of the unassigned bug at that time. Another reason for not using the tracker is the extremely slow response times I get from it. Submitting a single item there takes about 30 seconds (for the upload), so with more than one patch I'll have given up long before I'm done with the cleanup. > being relatively new to the development team, i'm also a bit > weary of rocking the boat too much on what basically amounts to a > procedural issue. > Umm... Not to be mean to the other devs or anything, but how many of them have done any commits lately? There's Stanley Hopcroft in late april (1), Harper Mann in early april (1), Matthew Kent in mid march (1), and then there's you, who has done all but one commits since you entered the team. Ton Voon has two as well, but one doesn't really count (THANKS file) and the other was an external patch to a no-brain bug. In conclusion; I've got patches, and you've got commit access so we should simply do what's easiest for you, as you're active and other devs are not (atm anyways). > >>Sorry if I take this as an invitation to pelt the list with various code >>cleanups and bugfixes ;). If you'd rather deal with it off-list (IRC? >>IM?), that's fine by me. > > > i'll send you my contact info privately, though i'm still going to > suggest that you in parallel post into the tracker anything you send > to me. > Hmm... Hate to see work down the drain, but I'll give it a shot anyways. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Lead Developer From ae at op5.se Tue May 24 12:27:30 2005 From: ae at op5.se (Andreas Ericsson) Date: Tue May 24 12:27:30 2005 Subject: [Nagiosplug-devel] Code cleanup for check_tcp Message-ID: <42937FA6.3060607@op5.se> In the wake of having made the previously static function my_connect in netutils.c exported by the linker, this patch follows naturally. Apply with patch -p1 < nagiosplug-check_tcp-protocol.diff -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Lead Developer -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: nagiosplug-check_tcp-protocol.diff URL: From noreply at sourceforge.net Tue May 24 13:12:58 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Tue May 24 13:12:58 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1208096 ] netutils.c, netutils.h - macros instead of non-sibling calls Message-ID: Patches item #1208096, was opened at 2005-05-24 22:11 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1208096&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None Status: Open Resolution: None Priority: 5 Submitted By: Andreas Ericsson (ageric) Assigned to: Nobody/Anonymous (nobody) Summary: netutils.c, netutils.h - macros instead of non-sibling calls Initial Comment: This patch has also been submitted to nagiosplug-devel@, where sean finney said he'd take care of applying it fairly quickly. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1208096&group_id=29880 From noreply at sourceforge.net Tue May 24 13:14:04 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Tue May 24 13:14:04 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1208098 ] Code cleanup for check_tcp Message-ID: Patches item #1208098, was opened at 2005-05-24 22:12 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1208098&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None Status: Open Resolution: None Priority: 5 Submitted By: Andreas Ericsson (ageric) Assigned to: Nobody/Anonymous (nobody) Summary: Code cleanup for check_tcp Initial Comment: In the wake of having made the previously static function my_connect in netutils.c exported by the linker, this patch follows naturally. Apply with patch -p1 < nagiosplug-check_tcp-protocol.diff ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1208098&group_id=29880 From noreply at sourceforge.net Tue May 24 13:31:03 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Tue May 24 13:31:03 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1208098 ] Code cleanup for check_tcp Message-ID: Patches item #1208098, was opened at 2005-05-24 16:12 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1208098&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: Enhancement Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Andreas Ericsson (ageric) >Assigned to: M. Sean Finney (seanius) Summary: Code cleanup for check_tcp Initial Comment: In the wake of having made the previously static function my_connect in netutils.c exported by the linker, this patch follows naturally. Apply with patch -p1 < nagiosplug-check_tcp-protocol.diff ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-05-24 16:29 Message: Logged In: YES user_id=226838 this patch has been committed to the nagiosplug CVS repository. thank you for your contribution. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1208098&group_id=29880 From noreply at sourceforge.net Tue May 24 13:31:07 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Tue May 24 13:31:07 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1208096 ] netutils.c, netutils.h - macros instead of non-sibling calls Message-ID: Patches item #1208096, was opened at 2005-05-24 16:11 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1208096&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: Enhancement Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Andreas Ericsson (ageric) >Assigned to: M. Sean Finney (seanius) Summary: netutils.c, netutils.h - macros instead of non-sibling calls Initial Comment: This patch has also been submitted to nagiosplug-devel@, where sean finney said he'd take care of applying it fairly quickly. ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-05-24 16:29 Message: Logged In: YES user_id=226838 this patch has been committed to the nagiosplug CVS repository. thank you for your contribution. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1208096&group_id=29880 From noreply at sourceforge.net Tue May 24 14:33:14 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Tue May 24 14:33:14 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1204541 ] check_ntp returns Critical when offset = 0.000000 Message-ID: Bugs item #1204541, was opened at 2005-05-18 16:48 Message generated for change (Settings changed) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1204541&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Parsing problem Group: None >Status: Pending Resolution: None Priority: 5 Submitted By: Kenny Raby (kraby) Assigned to: Subhendu Ghosh (sghosh) Summary: check_ntp returns Critical when offset = 0.000000 Initial Comment: Debian sarge system: check_ntp (nagios-plugins 1.4) 1.20 Occasionally when checking the NTP on the server on which Nagios is running I get (IP Address obsured): NTP CRITICAL: server x.x.x.x, stratum 4, offset 0.000000, delay 0.02565 I think these are the lines in the code: 203 # An offset of 0.000000 with an error is probably bogus. Actually, 204 # it's probably always bogus, but let's be paranoid here. 205 if ($offset == 0) { undef $offset;} 206 207 $ntpdate_error = defined ($offset) ? $ERRORS{"OK"} : $ERRORS{"CRITICAL"}; 208 print "ntperr = $ntpdate_error \n" if $verbose; In this case I do not beleive the offset of 0.000000 is bogus. The first part of the output with a -v is: server x.x.x.x, stratum 3, offset 0.000000, delay 0.02563 ntperr = 2 18 May 13:39:23 ntpdate[23726]: adjust time server x.x.x.x offset 0.000000 sec ntperr = 2 Since these "CRITICAL" failures cause false alerts for me I just commented out line 205 ---------------------------------------------------------------------- >Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-24 17:31 Message: Logged In: YES user_id=46572 Fixed in CVS - bug1150777 ---------------------------------------------------------------------- Comment By: Lars Ehrhardt (lehrhardt) Date: 2005-05-23 12:36 Message: Logged In: YES user_id=709554 I can confirm the error, an offset of 0.000000 occurs quite frequently on our hosts and trigger those false ntp nagios alerts. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1204541&group_id=29880 From noreply at sourceforge.net Tue May 24 15:12:18 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Tue May 24 15:12:18 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1204636 ] check_ntp gives error when only one unsync'd candidate Message-ID: Bugs item #1204636, was opened at 2005-05-18 19:35 Message generated for change (Comment added) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1204636&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Pending Resolution: None Priority: 5 Submitted By: Kenny Raby (kraby) Assigned to: Subhendu Ghosh (sghosh) Summary: check_ntp gives error when only one unsync'd candidate Initial Comment: check_ntp (nagios-plugins 1.4) 1.20 If there is only one candidate and the server is not syncronized to it you get the following error: Use of uninitialized value in concatenation (.) or string at ./check_ntp line 346. NTP UNKNOWN: Jitter too high check_ntp -v shows (ip addresses masked): server x.x.x.x, stratum 2, offset -0.000264, delay 0.05827 ntperr = 0 18 May 16:23:19 ntpdate[24669]: adjust time server x.x.x.x offset -0.000264 sec ntperr = 0 remote refid st t when poll reach delay offset jitter ============================================================================== #y.y.y.y .GPS. 1 u 1088 1024 236 33.020 0.149 1000.06 Candiate count= 1 Use of uninitialized value in concatenation (.) or string at ./check_ntp line 346. NTP UNKNOWN: Jitter too high After testing it looks like this line might be responsible for problems with just one candidate: 300 if ($#candidates >0) { I changed it to: if ($#candidates >=0) { And now verbose output becomes: server x.x.x.x, stratum 2, offset -0.000354, delay 0.05830 ntperr = 0 18 May 16:33:01 ntpdate[13054]: adjust time server x.x.x.x offset -0.000354 sec ntperr = 0 remote refid st t when poll reach delay offset jitter ============================================================================== #y.y.y.y .GPS. 1 u 1670 1024 236 33.020 0.149 1000.06 Candiate count= 1 candidate match #y.y.y.y .GPS. 1 u 1670 1024 236 33.020 0.149 1000.06 NTP WARNING: Jitter 1000.06 too high Note in particular the "candidate match" line which did not appear before the change. ---------------------------------------------------------------------- >Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-24 18:10 Message: Logged In: YES user_id=46572 updates in CVS - thanks ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1204636&group_id=29880 From james.kingston at gmail.com Tue May 24 15:31:08 2005 From: james.kingston at gmail.com (James Kingston) Date: Tue May 24 15:31:08 2005 Subject: [Nagiosplug-devel] check_mysql.c slave checking patch Message-ID: <9d27c6320505241529105a2816@mail.gmail.com> This patch was motivated by differences in the output of 'SHOW SLAVE STATUS' on different versions of mysqld. I just subscribed an hour ago, so I don't know if it's already been done before. On 4.0.16, Slave_IO_Running and Slave_SQL_Running were columns 9 & 10 out of 18, as the plugin expected. On our 4.1.10a servers compiled with SSL, they were 10 & 11 out of 33 total columns. This patch looks for matching column names, rather than assuming the location of the right columns. Thanks. -------------- next part -------------- A non-text attachment was scrubbed... Name: check_mysql.c.diff Type: text/x-patch Size: 1338 bytes Desc: not available URL: From noreply at sourceforge.net Tue May 24 15:36:00 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Tue May 24 15:36:00 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1200030 ] check_ntp perl expression does not match some values Message-ID: Bugs item #1200030, was opened at 2005-05-11 13:31 Message generated for change (Settings changed) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1200030&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Parsing problem Group: CVS >Status: Pending Resolution: None Priority: 5 Submitted By: Kenny Raby (kraby) Assigned to: Subhendu Ghosh (sghosh) Summary: check_ntp perl expression does not match some values Initial Comment: check_ntp was returning: Use of uninitialized value in concatenation (.) or string at ./check_ntp line 346. The sys.peer line in the ntpq output was: *127.127.7.1 CHU_AUDIO(1) 3 - 66m 64 377 0.000 0.000 0.020 The perl regex was not matching the _, ( or ) changed line 277 from: if (/^(\*|o)([-0-9.\s]+)\s+([-0-9A-Za-z.]+)\s+([-0-9.]+)\s+([lumb-]+)\s+([-0-9m.]+)\s+([-0-9.]+)\s+([-0-9.]+)\s+ ([-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)/) { To: if (/^(\*|o)([-0-9.\s]+)\s+([-0-9A-Za-z_().]+)\s+([-0-9.]+)\s+([lumb-]+)\s+([-0-9hm.]+)\s+([-0-9.mh]+)\s+([-0-9.]+)\s+( [-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)/) { and line 302 from: $c =~ /^(#)([-0-9.\s]+)\s+([-0-9A-Za-z.]+)\s+([-0-9.]+)\s+([lumb-]+)\s+([-0-9m.]+)\s+([-0-9.]+)\s+([-0-9 .]+)\s+([-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)/; to $c =~ /^(#)([-0-9.\s]+)\s+([-0-9A-Za-z_()..]+)\s+([-0-9.]+)\s+([lumb-]+)\s+([-0-9hm.]+)\s+([-0-9.mh]+)\s+([-0-9. ]+)\s+([-0-9.]+)\s+([-0-9.]+)\s+([-0-9.]+)/; (basically added _() to the $3 check) ---------------------------------------------------------------------- >Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-24 18:33 Message: Logged In: YES user_id=46572 CVS patched ---------------------------------------------------------------------- Comment By: Kenny Raby (kraby) Date: 2005-05-16 19:30 Message: Logged In: YES user_id=908646 Not exactly. It was a response from a Cisco Router and the line corresponed to the routers own master clock. The show ntp assoc on the router shows: +~127.127.7.1 127.127.7.1 3 24 64 377 0.0 0.00 0.0 (see http://www.cisco.com/warp/public/620/ntpassoc.html ) The ntpq -p from the linux server running Nagios gives: +CHU_AUDIO(1) CHU_AUDIO(1) 3 - 5 64 377 0.000 0.000 0.020 ntpq -p from a Solaris 8 server gives: +CHU(1) CHU(1) 3 - 5 64 377 0.00 0.000 0.02 (note that the routers is actually synced to another ntp source thus this shows only as a candidate) There is a thread here which would indicate this is for a radio. I think it is just seeing the 127.127.7 and assigning it that way since as I say this is a router acting as it's own master so doesn't really have a radio attached (well I don't think so anyway) A google search also brings up this: http://www.hn.edu.cn/book/NetWork/NetworkingBookshelf_2ndEd/tshoot/ch11_03.htm ---------------------------------------------------------------------- Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-16 18:22 Message: Logged In: YES user_id=46572 Thanks for the report - Any idea what the peer is? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1200030&group_id=29880 From seanius at seanius.net Tue May 24 17:36:40 2005 From: seanius at seanius.net (sean finney) Date: Tue May 24 17:36:40 2005 Subject: [Nagiosplug-devel] Code cleanup patch In-Reply-To: <42937140.5090905@op5.se> References: <4292DAF8.9070507@op5.se> <20050524141634.GA17088@seanius.net> <42933F74.3040704@op5.se> <20050524172031.GA18116@seanius.net> <42937140.5090905@op5.se> Message-ID: <20050525003355.GA23035@seanius.net> a followup on this patch, turns out the patch breaks the check_mysql plugin (my_connect is a function used by the libmysqlclient api). so, i've renamed the my_connect function and all references to it to np_net_connect for lack of a better name... sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From noreply at sourceforge.net Tue May 24 17:48:45 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Tue May 24 17:48:45 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1118832 ] check_procs reports incorrect number of processes Message-ID: Bugs item #1118832, was opened at 2005-02-08 14:00 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1118832&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Argument proccessing Group: snapshot tarball >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Chris (clambertus) >Assigned to: M. Sean Finney (seanius) Summary: check_procs reports incorrect number of processes Initial Comment: When check_procs is used with a system like check_nrpe, the nrpe daemon executes popen(), which causes check_procs to be executed as "sh -c /path/to/check_procs argument_list" This causes erroneous returns because check_procs fails the strcmp(procprog,progname) call, since the "procprog" is actually sh. To fix this, I added an additional strstr() call which compares progname against procargs and discards the line if "check_procs" appears in the process argument list. This is not an ideal solution, but should take care of the vast majority of cases where check_procs is used with check_nrpe or similar utilities. ---------------------------------------------------------------------- >Comment By: M. Sean Finney (seanius) Date: 2005-05-24 20:46 Message: Logged In: YES user_id=226838 this issue should be solved now. instead of looking at the process names as strings, i've modified check_procs to also be able to get the pid of all the processes, which it can compare against the output of getpid(). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1118832&group_id=29880 From noreply at sourceforge.net Tue May 24 20:10:12 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Tue May 24 20:10:12 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1155027 ] check_hpjd (v1.4) unknown output Message-ID: Bugs item #1155027, was opened at 2005-03-02 07:16 Message generated for change (Comment added) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1155027&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Argument proccessing Group: Release (specify) >Status: Pending Resolution: None Priority: 5 Submitted By: Werner Flamme (wernerflamme) >Assigned to: Subhendu Ghosh (sghosh) Summary: check_hpjd (v1.4) unknown output Initial Comment: Hi there, I use check_hpjd with -H as only parameter. No problems with the 1.3.1 plugins. Today I installed version 1.4 and found out that ./check_hpjd -H 141.65.129.65 results in Unknown output option passed to -O: Q. : Timeout from host 141.65.129.65 So I renamed check_hpjd and copied the old one back again - this runs fine. What can I do to make check_hpjd 1.4 work again? Regards, \/\/erner ---------------------------------------------------------------------- >Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-24 23:07 Message: Logged In: YES user_id=46572 ucdsnmp project has been superseeded by the net-snmp project. Please upgrade accordingly. ---------------------------------------------------------------------- Comment By: MarkusE (lpperm) Date: 2005-04-21 11:53 Message: Logged In: YES user_id=1263926 Hi, I'm using nagiosPlugins1.4 with ucdsnmp-4.2.5-168. check_hpdj.c uses /usr/bin/snmpget from this package. It seems like this version of snmpget does not support the option -Oqa. Regards, Markus ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1155027&group_id=29880 From noreply at sourceforge.net Tue May 24 20:25:15 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Tue May 24 20:25:15 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1155754 ] added support SNMPv2c Message-ID: Patches item #1155754, was opened at 2005-03-03 06:40 Message generated for change (Settings changed) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1155754&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Pending Resolution: None Priority: 5 Submitted By: KonstantinK (koka_atvc) Assigned to: Subhendu Ghosh (sghosh) Summary: added support SNMPv2c Initial Comment: patch added support SNMPv2c in check_snmp ---------------------------------------------------------------------- >Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-24 23:23 Message: Logged In: YES user_id=46572 cvs updated ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1155754&group_id=29880 From ae at op5.se Wed May 25 00:45:54 2005 From: ae at op5.se (Andreas Ericsson) Date: Wed May 25 00:45:54 2005 Subject: [Nagiosplug-devel] Code cleanup patch In-Reply-To: <20050525003355.GA23035@seanius.net> References: <4292DAF8.9070507@op5.se> <20050524141634.GA17088@seanius.net> <42933F74.3040704@op5.se> <20050524172031.GA18116@seanius.net> <42937140.5090905@op5.se> <20050525003355.GA23035@seanius.net> Message-ID: <42942CEE.5020101@op5.se> sean finney wrote: > a followup on this patch, > > turns out the patch breaks the check_mysql plugin (my_connect is a > function used by the libmysqlclient api). so, i've renamed the > my_connect function and all references to it to np_net_connect for lack > of a better name... > I remember something about this, but I didn't think it would still be a problem. With mysql 4.1.x, it isn't. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Lead Developer From seanius at seanius.net Wed May 25 05:36:10 2005 From: seanius at seanius.net (sean finney) Date: Wed May 25 05:36:10 2005 Subject: [Nagiosplug-devel] check_mysql.c slave checking patch In-Reply-To: <9d27c6320505241529105a2816@mail.gmail.com> References: <9d27c6320505241529105a2816@mail.gmail.com> Message-ID: <20050525123308.GA29157@seanius.net> hi james, the patch looks good, i'll apply it to cvs. for future reference, the current practice here is to post patches into the patch tracker, so if you could do that instead or in parallel to posting here, it would be appreciated. thanks, sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From seanius at seanius.net Wed May 25 05:39:28 2005 From: seanius at seanius.net (sean finney) Date: Wed May 25 05:39:28 2005 Subject: [Nagiosplug-devel] actually In-Reply-To: <9d27c6320505241529105a2816@mail.gmail.com> References: <9d27c6320505241529105a2816@mail.gmail.com> Message-ID: <20050525123626.GB29157@seanius.net> hi james, actually, the patch doesn't apply against the version in cvs. could you throw a patch our way against cvs HEAD? thanks sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From noreply at sourceforge.net Wed May 25 06:51:04 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed May 25 06:51:04 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-836014 ] Bug fix for check_ntp Message-ID: Patches item #836014, was opened at 2003-11-04 15:20 Message generated for change (Comment added) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=836014&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None >Status: Pending Resolution: None Priority: 5 Submitted By: Howard Wilkinson (howardwilkinson) Assigned to: Subhendu Ghosh (sghosh) Summary: Bug fix for check_ntp Initial Comment: This fixes check_ntp to run with the latest ntpq output! ---------------------------------------------------------------------- >Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-25 09:40 Message: Logged In: YES user_id=46572 Closing - since this is patched in CVS ---------------------------------------------------------------------- Comment By: Howard Wilkinson (howardwilkinson) Date: 2004-03-19 08:09 Message: Logged In: YES user_id=655834 I am unsure what you mean by ePN! But the BEGIN block has been necessary on most of my installations and provides the means to support access to the utils.pm drop in. The addition of the m into the pattern is designed to cope with clocks that have drifted dramatically. We currently do not have an example of this we can confirm the situation on. But the latest releases of NTPQ will convert seconds to minutes in these fields. Sorry about the delay in replying but I missed the original message. ---------------------------------------------------------------------- Comment By: Subhendu Ghosh (sghosh) Date: 2003-11-05 23:35 Message: Logged In: YES user_id=46572 Sorry - the BEGIN block will not work with ePN The only other relevant diff seems to be the addition of "m" in the regex to match sys.peer or pps.peer. Can you elaborate on the circumstances that causes this? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=836014&group_id=29880 From noreply at sourceforge.net Wed May 25 06:59:30 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed May 25 06:59:30 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1172539 ] check_ntp perfdata and fixes Message-ID: Patches item #1172539, was opened at 2005-03-29 09:00 Message generated for change (Settings changed) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1172539&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Perf data Group: None >Status: Pending Resolution: None Priority: 5 Submitted By: Yann Dirson (ydirson) >Assigned to: Subhendu Ghosh (sghosh) Summary: check_ntp perfdata and fixes Initial Comment: This patch adds offset and jitter using usual perfdata syntax. As I had to remove \n's put in wrong places, I cleaned up a couple of trailing spaces as well. You'll also find I had to fix the regexp for ntpq, as was reported in several patches. I also added a check for the case the regexp does not match, to make it visible in the plugin output. You may also like the typo fix in one verbose message. ---------------------------------------------------------------------- >Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-25 09:57 Message: Logged In: YES user_id=46572 Added perfdata patch, typo patch regex not applied. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1172539&group_id=29880 From noreply at sourceforge.net Wed May 25 07:00:21 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed May 25 07:00:21 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1159317 ] Patch for check_ntp to work with zero offsets Message-ID: Patches item #1159317, was opened at 2005-03-08 14:55 Message generated for change (Comment added) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1159317&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Pending Resolution: None Priority: 5 Submitted By: W Sanders (wsanders1) >Assigned to: Subhendu Ghosh (sghosh) Summary: Patch for check_ntp to work with zero offsets Initial Comment: In some (mine) LANS with "perfectly" synchronized clocks the offset can be zero even though the ntp daemon is all synced up. "Check_ntp" assumes a zero offset is an unsynchronized ntpd. The way I got it to work was to also check for stratum 16, which is also a sign of zero offset. No need to be paranoid unless you are sure they are out to get you! Diff -c below: $ diff -c ../../libexec/check_ntp.0 ../../libexec/check_ntp *** ../../libexec/check_ntp.0 2005-02-04 13:59:50.000000000 -0800 --- ../../libexec/check_ntp 2005-02-04 14:18:24.000000000 -0800 *************** *** 194,200 **** # An offset of 0.000000 with an error is probably bogus. Actually, # it's probably always bogus, but let's be paranoid here. ! if ($offset == 0) { undef $offset;} $ntpdate_error = defined ($offset) ? $ERRORS{"OK"} : $ERRORS{"CRITICAL"}; print "ntperr = $ntpdate_error \n" if $verbose; --- 194,200 ---- # An offset of 0.000000 with an error is probably bogus. Actually, # it's probably always bogus, but let's be paranoid here. ! if ($offset == 0 and $stratum == 16) { undef $offset;} $ntpdate_error = defined ($offset) ? $ERRORS{"OK"} : $ERRORS{"CRITICAL"}; print "ntperr = $ntpdate_error \n" if $verbose; ---------------------------------------------------------------------- >Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-25 09:58 Message: Logged In: YES user_id=46572 Added option -O for bad zero offset ---------------------------------------------------------------------- Comment By: W Sanders (wsanders1) Date: 2005-03-08 19:06 Message: Logged In: YES user_id=609888 I don't know if iit would be right to remove the check for 0 offset. When offset is 0 and stratum is 16 this will indeed usually be accompanied by the "no server suitable for synchronization" in the ntpdate -q output, which is checked for in line 204. My logic will still allow the script to reset $ERRORS to the right value if the string is found in line 204. I dunno, maybe the case where offset=0 and stratum=16 and the string is not present never happens. Still the fact that Ian was being paranoid about it signifies be probably got burned once or twice by it. I tried to contact Ian via email and could not find a valid address for him. The "offset" is AFAIK the difference between the system time and the local NTPD's idea of what the time is supposed to be based on estimates of delays and stuff in the network. My particular LAN is highly accurate since I have GPS time receivers within one or two hops. So on my LAN the offset is frequently zero since the time sources are very stable and local and the network delays are very short and consistent. "Stratum" is the number of hops (0..15) between the local ntpd and the authoritative time source. (My stratum is 1 since I directly reference the servers with the GPS receivers attached.). The offset rarely stays zero for one than one check - so with "max_check_attempts" set to more than 1 this will not result in bogus alarms, the single isolated alerts show up in the logs and bug PHBs and anal-retentive sysadmins. HTH... ---------------------------------------------------------------------- Comment By: Ton Voon (tonvoon) Date: 2005-03-08 17:27 Message: Logged In: YES user_id=664364 I've applied a patch to check_ntp to remove this 0 test, but have to admit I'm not exactly sure what is happening here. Can you say why an offset of 0.000 is good/bad? ---------------------------------------------------------------------- Comment By: Jason Martin (jhmartin) Date: 2005-03-08 15:44 Message: Logged In: YES user_id=589094 This would probably be better implemented as a command-line flag with the default behavior remaining as '0 = bad'. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1159317&group_id=29880 From noreply at sourceforge.net Wed May 25 07:03:03 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed May 25 07:03:03 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-818987 ] Fixes check_ntp parse of large poll intervals Message-ID: Patches item #818987, was opened at 2003-10-06 21:44 Message generated for change (Settings changed) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=818987&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None >Status: Pending Resolution: None Priority: 5 Submitted By: Shawn Dvorak (sdvorak) Assigned to: Subhendu Ghosh (sghosh) Summary: Fixes check_ntp parse of large poll intervals Initial Comment: The ntpq output parsing in check_ntp does not handle long poll intervals (those that include an "m", indicating minutes). This short patch fixes this by adding "m" to the match string. Also corrects the misspelling of "Candidates" in the verbose output. ---------------------------------------------------------------------- >Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-25 10:01 Message: Logged In: YES user_id=46572 CVS fixed ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=818987&group_id=29880 From noreply at sourceforge.net Wed May 25 07:04:12 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed May 25 07:04:12 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1081520 ] check_snmp doesn't allow version 2 of SNMP protocol Message-ID: Bugs item #1081520, was opened at 2004-12-08 13:21 Message generated for change (Settings changed) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1081520&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Argument proccessing Group: Release (specify) >Status: Pending Resolution: None Priority: 5 Submitted By: Jason (snackmeat) Assigned to: Benoit Mortier (opensides) Summary: check_snmp doesn't allow version 2 of SNMP protocol Initial Comment: The current check_snmp plugin does not allow you to choose SNMP protocol V2. Only V1 or V3. Some of our network devices will ONLY respond to SNMP V2 queries. It seems to me that check_snmp should be modified to allow V2 protocol as well. This can be accomplished with a simple addition to the source. In the part where it validates your arguements, add something like this: else if ((strcmp(proto,"2c") == 0) || (strcmp(proto,"2") == 0)) { /* Added manually, since old check_snmp doesn't allow protocol V2 */ asprintf(&proto, "%s", "2c"); asprintf(&authpriv, "%s%s", "-c ", community); } Any reason this shouldn't be included in check_snmp? ---------------------------------------------------------------------- >Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-25 10:02 Message: Logged In: YES user_id=46572 CVS updated ---------------------------------------------------------------------- Comment By: Benoit Mortier (opensides) Date: 2004-12-08 20:02 Message: Logged In: YES user_id=388184 Hi, will put that in check_snmp.c byz ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1081520&group_id=29880 From noreply at sourceforge.net Wed May 25 07:26:16 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed May 25 07:26:16 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-833685 ] RH9 check_ping.c Fix Message-ID: Patches item #833685, was opened at 2003-10-31 09:51 Message generated for change (Settings changed) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=833685&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None >Status: Pending Resolution: None Priority: 5 Submitted By: Luiz Encarnacao (lfencarnacao) Assigned to: Subhendu Ghosh (sghosh) Summary: RH9 check_ping.c Fix Initial Comment: Hi On some circunstancies, RedHat output for ping (used by check_ping.c) reports a field ERRORS. When this situation occurs, check_ping is unable to complete successfully. This fix solve this isssue. Thanks Encarnacao, Luiz ---------------------------------------------------------------------- >Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-25 10:24 Message: Logged In: YES user_id=46572 cvs includes patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=833685&group_id=29880 From noreply at sourceforge.net Wed May 25 08:42:03 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed May 25 08:42:03 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1106430 ] Patch for check_snmp.c to use snmpgetnext Message-ID: Patches item #1106430, was opened at 2005-01-20 20:41 Message generated for change (Comment added) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1106430&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Pending Resolution: None Priority: 5 Submitted By: W Sanders (wsanders1) >Assigned to: Subhendu Ghosh (sghosh) Summary: Patch for check_snmp.c to use snmpgetnext Initial Comment: An occasion arose to make check_snmp use snmpgetnext instead of snmpget as its command to execute. (More info on this: http://e-docs.bea.com/wls/docs81/snmpman/snmpagent.html#Managed_Resources_and_MBeans see "Object Identifiers") Basically we can get an object in Weblogic (and maybe some other MIBs) by doing an snmpgetnext on a much shorter OID than an snmpget requires. Example - amount off free space on JVM heap is enterprises.140.625.340.1.25 via snmpgetnext or snmpwalk but snmpget requires enterprises.140.625.340.1.25.32.100.102.55.101.56.52.101.53.51.99.55.100.99.55.54.48.49.48.101.97.50.101.97.97.49.56.57.50.100.52.57.53 Don't ask me why - I'm no SNMP expert and I wouldn't admit to being one if I were! Anyway here are the diffs attached. Conveniently, a PATH_TP_SNMPGETNEXT macro is defined and set up in configure and in the resulting .h files. ---------------------------------------------------------------------- >Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-25 11:40 Message: Logged In: YES user_id=46572 CVS updated to support snmp-getnext ---------------------------------------------------------------------- Comment By: Ton Voon (tonvoon) Date: 2005-02-03 19:07 Message: Logged In: YES user_id=664364 Moving to patches because it looks like an enhancement rather than a bug. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1106430&group_id=29880 From noreply at sourceforge.net Wed May 25 08:48:40 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed May 25 08:48:40 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-880904 ] check_mailq: -f option for sendmail config file Message-ID: Patches item #880904, was opened at 2004-01-20 17:01 Message generated for change (Comment added) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=880904&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None Status: Open Resolution: None Priority: 5 Submitted By: Don Badrak (dbadrak) Assigned to: Subhendu Ghosh (sghosh) Summary: check_mailq: -f option for sendmail config file Initial Comment: In my sendmail configuration, I have two instances of sendmail, with non-standard config files and spool directories. This is a patch to both check_mailq.pl and utils.pm.in that allows a -f options. The -f option is for sendmail only. It allows a non-standard configuration file to be used by the mailq command (mailq -C filename). It also looks through the config file for the QueueDirectory, and uses that, rather than assuming 'mqueue' will be in the string. I also included a fix in check_mailq.pl to ignore the case of the command line options (--warning vs --Warning). The patch for utils.pm.in is for a PATH_TO_SENDMAIL_CF. These patches are both against the HEAD revision. Don ---------------------------------------------------------------------- >Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-25 11:46 Message: Logged In: YES user_id=46572 Sorry about holding this up for so long.. Do you haave corresponding patch to Configure.in for checking PATH_TO_SENDMAIL_CF ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=880904&group_id=29880 From noreply at sourceforge.net Wed May 25 10:45:35 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed May 25 10:45:35 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1185713 ] PATCH: check_time for 64bit long systems Message-ID: Patches item #1185713, was opened at 2005-04-19 03:49 Message generated for change (Comment added) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1185713&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None >Status: Pending Resolution: None Priority: 5 Submitted By: Peter Bray (illumino) >Assigned to: Subhendu Ghosh (sghosh) Summary: PATCH: check_time for 64bit long systems Initial Comment: check_time provides an incorrect result on systems using 64bit longs (such as Solaris 9 / SPARCv9 / gcc-sparcv9-3.4.3) as the data returned off the network socket read, is placed in the upper half of the 64bit unsigned long and not the lower half. The function in question ntohl on Solaris takes a uint32_t not a long, changing the type of the variables used fixed the problem. I have not verified that the type "uint32_t" is available of all systems (eg Linux, OSX, *BSD, ...) but the use of unsigned long is incorrect (I believe) is it is variable by platform & compiler. The following is a summary of the attached patch: OLD: unsigned long server_time, raw_server_time; NEW: uint32_t server_time, raw_server_time; Regards, Peter Bray Sydney, Australia ---------------------------------------------------------------------- >Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-25 13:42 Message: Logged In: YES user_id=46572 patch applied ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1185713&group_id=29880 From noreply at sourceforge.net Wed May 25 11:38:44 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed May 25 11:38:44 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1122262 ] checki_fping Message-ID: Bugs item #1122262, was opened at 2005-02-14 05:11 Message generated for change (Comment added) made by sghosh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1122262&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Argument proccessing Group: Release (specify) Status: Open Resolution: None Priority: 5 Submitted By: Chancellor Sy (i_m_chance) Assigned to: Nobody/Anonymous (nobody) Summary: checki_fping Initial Comment: Hi, When i run check_fping The output is it only checks Here is a sample output [root at apserv libexec]# ./check_fping -v -H 133.88.30.173 133.88.6.4 /usr/local/sbin/fping -b 56 -c 1 133.88.30.173 133.88.30.173 : [0], 84 bytes, 0.19 ms (0.19 avg, 0% loss) 133.88.30.173 : xmt/rcv/%loss = 1/1/0%, min/avg/max = 0.19/0.19/0.19 FPING OK - 133.88.30.173 (loss=0%, rta=0.190000 ms)|loss=0%;;;0;100 rta=0.000190s;;;0.000000 Your answer is very much appreciated. Regards Chancellor Sy ---------------------------------------------------------------------- >Comment By: Subhendu Ghosh (sghosh) Date: 2005-05-25 14:36 Message: Logged In: YES user_id=46572 Check_fping only supports one hostname ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1122262&group_id=29880 From noreply at sourceforge.net Fri May 27 08:56:47 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Fri May 27 08:56:47 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1209978 ] check_load arg parsing and cleanup Message-ID: Patches item #1209978, was opened at 2005-05-27 17:54 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1209978&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None Status: Open Resolution: None Priority: 5 Submitted By: Andreas Ericsson (ageric) Assigned to: Nobody/Anonymous (nobody) Summary: check_load arg parsing and cleanup Initial Comment: Here's a patch to check_load.c which removes a lot of duplicate code and some unnecessary complexity. It also fixes the argument parsing bug. LOC count is down by 10% and speed is up by about 15, so I guess that's a good thing. Apply with patch -p1 < nagiosplug-check_load.diff ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1209978&group_id=29880 From ae at op5.se Fri May 27 08:56:57 2005 From: ae at op5.se (Andreas Ericsson) Date: Fri May 27 08:56:57 2005 Subject: [Nagiosplug-devel] check_load arg parsing bugfix and cleanup Message-ID: <429742E4.4050504@op5.se> Ahoy. Here's a patch to check_load.c which removes a lot of duplicate code and some unnecessary complexity. It also fixes the argument parsing bug. LOC count is down by 10% and speed is up by about 15, so I guess that's a good thing. Apply with patch -p1 < nagiosplug-check_load.diff Next I'll rework the api for running commands, since that's the area where most plugins duplicate efforts and does so in a very non-efficient way. If someone else is already working on this, gimme a holler so we can coordinate the efforts. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Lead Developer -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: nagiosplug-check_load.diff URL: From ae at op5.se Fri May 27 09:10:17 2005 From: ae at op5.se (Andreas Ericsson) Date: Fri May 27 09:10:17 2005 Subject: [Nagiosplug-devel] check_load arg parsing bugfix and cleanup In-Reply-To: <429742E4.4050504@op5.se> References: <429742E4.4050504@op5.se> Message-ID: <429745BA.9060705@op5.se> Feeling a bit stupid here, but I just found a bug in my patch. On system with getloadavg(3) it will always return STATE_UNKNOWN if getloadavg succeeds and no threshold value is overstepped. Use the corrected patch attached here instead. The tracker has been updated. Andreas Ericsson wrote: > Ahoy. > > Here's a patch to check_load.c which removes a lot of duplicate code and > some unnecessary complexity. It also fixes the argument parsing bug. > > LOC count is down by 10% and speed is up by about 15, so I guess that's > a good thing. > > Apply with patch -p1 < nagiosplug-check_load.diff > > Next I'll rework the api for running commands, since that's the area > where most plugins duplicate efforts and does so in a very non-efficient > way. If someone else is already working on this, gimme a holler so we > can coordinate the efforts. > > > ------------------------------------------------------------------------ > > diff -urN ../orig.nplg/plugins/check_load.c ./plugins/check_load.c > --- ../orig.nplg/plugins/check_load.c 2005-05-27 15:56:34.000000000 +0200 > +++ ./plugins/check_load.c 2005-05-27 17:45:50.000000000 +0200 > @@ -39,37 +39,64 @@ > #endif /* !defined LOADAVG_1MIN */ > > > -int process_arguments (int argc, char **argv); > -int validate_arguments (void); > +static int process_arguments (int argc, char **argv); > +static int validate_arguments (void); > void print_help (void); > void print_usage (void); > > -float wload1 = -1, wload5 = -1, wload15 = -1; > -float cload1 = -1, cload5 = -1, cload15 = -1; > +/* strictly for pretty-print usage in loops */ > +static const int nums[3] = { 1, 5, 15 }; > + > +/* provide some fairly sane defaults */ > +double wload[3] = { 0.0, 0.0, 0.0 }; > +double cload[3] = { 0.0, 0.0, 0.0 }; > +#define la1 la[0] > +#define la5 la[1] > +#define la15 la[2] > > char *status_line; > > +static void > +get_threshold(char *arg, double *th) > +{ > + size_t i, n; > + char *str = arg, *p; > + > + n = strlen(arg); > + for(i = 0; i < 3; i++) { > + th[i] = strtod(str, &p); > + if(p == str) break; > + > + str = p + 1; > + if(n <= (size_t)(str - arg)) break; > + } > + > + /* empty argument or non-floatish, so warn about it and die */ > + if(!i) usage (_("Warning threshold must be float or float triplet!\n")); > + > + if(i != 2) { > + /* one or more numbers were given, so fill array with last > + * we got (most likely to NOT produce the least expected result) */ > + for(n = i; n < 3; n++) th[n] = th[i]; > + } > +} > > > int > main (int argc, char **argv) > { > - int result = STATE_UNKNOWN; > - > -#if HAVE_GETLOADAVG==1 > + int result = STATE_OK; > + int i; > + > double la[3] = { 0.0, 0.0, 0.0 }; /* NetBSD complains about unitialized arrays */ > -#else > -# if HAVE_PROC_LOADAVG==1 > - FILE *fp; > - char input_buffer[MAX_INPUT_BUFFER]; > - char *tmp_ptr; > -# else > +#ifndef HAVE_GETLOADAVG > char input_buffer[MAX_INPUT_BUFFER]; > +# ifdef HAVE_PROC_LOADAVG > + FILE *fp; > + char *str, *next; > # endif > #endif > > - float la1, la5, la15; > - > setlocale (LC_ALL, ""); > bindtextdomain (PACKAGE, LOCALEDIR); > textdomain (PACKAGE); > @@ -77,30 +104,24 @@ > if (process_arguments (argc, argv) == ERROR) > usage4 (_("Could not parse arguments")); > > -#if HAVE_GETLOADAVG==1 > +#ifdef HAVE_GETLOADAVG > result = getloadavg (la, 3); > if (result == -1) > return STATE_UNKNOWN; > - la1 = la[LOADAVG_1MIN]; > - la5 = la[LOADAVG_5MIN]; > - la15 = la[LOADAVG_15MIN]; > #else > -# if HAVE_PROC_LOADAVG==1 > +# ifdef HAVE_PROC_LOADAVG > fp = fopen (PROC_LOADAVG, "r"); > if (fp == NULL) { > printf (_("Error opening %s\n"), PROC_LOADAVG); > return STATE_UNKNOWN; > } > > - la1 = la5 = la15 = -1; > - > while (fgets (input_buffer, MAX_INPUT_BUFFER - 1, fp)) { > - tmp_ptr = strtok (input_buffer, " "); > - la1 = atof (tmp_ptr); > - tmp_ptr = strtok (NULL, " "); > - la5 = atof (tmp_ptr); > - tmp_ptr = strtok (NULL, " "); > - la15 = atof (tmp_ptr); > + str = (char *)input_buffer; > + for(i = 0; i < 3; i++) { > + la[i] = strtod(str, &next); > + str = next; > + } > } > > fclose (fp); > @@ -126,11 +147,11 @@ > #endif > > > - if ((la1 < 0.0) || (la5 < 0.0) || (la15 < 0.0)) { > -#if HAVE_GETLOADAVG==1 > + if ((la[0] < 0.0) || (la[1] < 0.0) || (la[2] < 0.0)) { > +#ifdef HAVE_GETLOADAVG > printf (_("Error in getloadavg()\n")); > #else > -# if HAVE_PROC_LOADAVG==1 > +# ifdef HAVE_PROC_LOADAVG > printf (_("Error processing %s\n"), PROC_LOADAVG); > # else > printf (_("Error processing %s\n"), PATH_TO_UPTIME); > @@ -141,27 +162,25 @@ > > asprintf(&status_line, _("load average: %.2f, %.2f, %.2f"), la1, la5, la15); > > - if ((la1 >= cload1) || (la5 >= cload5) || (la15 >= cload15)) > - result = STATE_CRITICAL; > - else if ((la1 >= wload1) || (la5 >= wload5) || (la15 >= wload15)) > - result = STATE_WARNING; > - else > - result = STATE_OK; > - > - die (result, > - "%s - %s|%s %s %s\n", > - state_text (result), > - status_line, > - fperfdata ("load1", la1, "", (int)wload1, wload1, (int)cload1, cload1, TRUE, 0, FALSE, 0), > - fperfdata ("load5", la5, "", (int)wload5, wload5, (int)cload5, cload5, TRUE, 0, FALSE, 0), > - fperfdata ("load15", la15, "", (int)wload15, wload15, (int)cload15, cload15, TRUE, 0, FALSE, 0)); > - return STATE_OK; > -} > + for(i = 0; i < 3; i++) { > + if(la[i] > cload[i]) { > + result = STATE_CRITICAL; > + break; > + } > + else if(la[i] > wload[i]) result = STATE_WARNING; > + } > > + printf("%s - %s|", state_text(result), status_line); > + for(i = 0; i < 3; i++) > + printf("load%d=%.3f;%.3f;%.3f;0; ", nums[i], la[i], wload[i], cload[i]); > + > + putchar('\n'); > + return result; > +} > > > /* process command-line arguments */ > -int > +static int > process_arguments (int argc, char **argv) > { > int c = 0; > @@ -185,37 +204,11 @@ > break; > > switch (c) { > - case 'w': /* warning time threshold */ > - if (is_intnonneg (optarg)) { > - wload1 = atof (optarg); > - wload5 = atof (optarg); > - wload15 = atof (optarg); > - break; > - } > - else if (strstr (optarg, ",") && > - sscanf (optarg, "%f,%f,%f", &wload1, &wload5, &wload15) == 3) > - break; > - else if (strstr (optarg, ":") && > - sscanf (optarg, "%f:%f:%f", &wload1, &wload5, &wload15) == 3) > - break; > - else > - usage (_("Warning threshold must be float or float triplet!\n")); > + case 'w': /* warning time threshold */ > + get_threshold(optarg, wload); > break; > - case 'c': /* critical time threshold */ > - if (is_intnonneg (optarg)) { > - cload1 = atof (optarg); > - cload5 = atof (optarg); > - cload15 = atof (optarg); > - break; > - } > - else if (strstr (optarg, ",") && > - sscanf (optarg, "%f,%f,%f", &cload1, &cload5, &cload15) == 3) > - break; > - else if (strstr (optarg, ":") && > - sscanf (optarg, "%f:%f:%f", &cload1, &cload5, &cload15) == 3) > - break; > - else > - usage (_("Critical threshold must be float or float triplet!\n")); > + case 'c': /* critical time threshold */ > + get_threshold(optarg, cload); > break; > case 'V': /* version */ > print_revision (progname, revision); > @@ -231,60 +224,38 @@ > c = optind; > if (c == argc) > return validate_arguments (); > - if (wload1 < 0 && is_nonnegative (argv[c])) > - wload1 = atof (argv[c++]); > - > - if (c == argc) > - return validate_arguments (); > - if (cload1 < 0 && is_nonnegative (argv[c])) > - cload1 = atof (argv[c++]); > - > - if (c == argc) > - return validate_arguments (); > - if (wload5 < 0 && is_nonnegative (argv[c])) > - wload5 = atof (argv[c++]); > - > - if (c == argc) > - return validate_arguments (); > - if (cload5 < 0 && is_nonnegative (argv[c])) > - cload5 = atof (argv[c++]); > > - if (c == argc) > - return validate_arguments (); > - if (wload15 < 0 && is_nonnegative (argv[c])) > - wload15 = atof (argv[c++]); > - > - if (c == argc) > - return validate_arguments (); > - if (cload15 < 0 && is_nonnegative (argv[c])) > - cload15 = atof (argv[c++]); > + /* handle the case if both arguments are missing, > + * but not if only one is given without -c or -w flag */ > + if(c - argc == 2) { > + get_threshold(argv[c++], wload); > + get_threshold(argv[c++], cload); > + } > + else if(c - argc == 1) { > + get_threshold(argv[c++], cload); > + } > > return validate_arguments (); > } > > > > -int > +static int > validate_arguments (void) > { > - if (wload1 < 0) > - usage (_("Warning threshold for 1-minute load average is not specified\n")); > - if (wload5 < 0) > - usage (_("Warning threshold for 5-minute load average is not specified\n")); > - if (wload15 < 0) > - usage (_("Warning threshold for 15-minute load average is not specified\n")); > - if (cload1 < 0) > - usage (_("Critical threshold for 1-minute load average is not specified\n")); > - if (cload5 < 0) > - usage (_("Critical threshold for 5-minute load average is not specified\n")); > - if (cload15 < 0) > - usage (_("Critical threshold for 15-minute load average is not specified\n")); > - if (wload1 > cload1) > - usage (_("Parameter inconsistency: 1-minute \"warning load\" greater than \"critical load\".\n")); > - if (wload5 > cload5) > - usage (_("Parameter inconsistency: 5-minute \"warning load\" greater than \"critical load\".\n")); > - if (wload15 > cload15) > - usage (_("Parameter inconsistency: 15-minute \"warning load\" greater than \"critical load\".\n")); > + int i = 0; > + > + /* match cload first, as it will give the most friendly error message > + * if user hasn't given the -c switch properly */ > + for(i = 0; i < 3; i++) { > + if(cload[i] < 0) > + die (STATE_UNKNOWN, _("Critical threshold for %d-minute load average is not specified\n"), nums[i]); > + if(wload[i] < 0) > + die (STATE_UNKNOWN, _("Warning threshold for %d-minute load average is not specified\n"), nums[i]); > + if(wload[i] > cload[i]) > + die (STATE_UNKNOWN, _("Parameter inconsistency: %d-minute \"warning load\" is greater than \"critical load\"\n"), nums[i]); > + } > + > return OK; > } -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Lead Developer -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: nagiosplug-check_load.diff URL: From noreply at sourceforge.net Fri May 27 09:11:10 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Fri May 27 09:11:10 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1209978 ] check_load arg parsing and cleanup Message-ID: Patches item #1209978, was opened at 2005-05-27 17:54 Message generated for change (Comment added) made by ageric You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1209978&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None Status: Open Resolution: None Priority: 5 Submitted By: Andreas Ericsson (ageric) Assigned to: Nobody/Anonymous (nobody) Summary: check_load arg parsing and cleanup Initial Comment: Here's a patch to check_load.c which removes a lot of duplicate code and some unnecessary complexity. It also fixes the argument parsing bug. LOC count is down by 10% and speed is up by about 15, so I guess that's a good thing. Apply with patch -p1 < nagiosplug-check_load.diff ---------------------------------------------------------------------- >Comment By: Andreas Ericsson (ageric) Date: 2005-05-27 18:08 Message: Logged In: YES user_id=1047860 bugfixed patch. See list for details. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1209978&group_id=29880 From seanius at seanius.net Fri May 27 15:19:29 2005 From: seanius at seanius.net (sean finney) Date: Fri May 27 15:19:29 2005 Subject: [Nagiosplug-devel] check_load arg parsing bugfix and cleanup In-Reply-To: <429742E4.4050504@op5.se> References: <429742E4.4050504@op5.se> Message-ID: <20050527221720.GA26079@seanius.net> hey, On Fri, May 27, 2005 at 05:55:16PM +0200, Andreas Ericsson wrote: > Here's a patch to check_load.c which removes a lot of duplicate code and > some unnecessary complexity. It also fixes the argument parsing bug. i'll take a look at the latest patch as soon as i have a chance. > Next I'll rework the api for running commands, since that's the area > where most plugins duplicate efforts and does so in a very non-efficient > way. If someone else is already working on this, gimme a holler so we > can coordinate the efforts. i'm not working directly on this, but i have been messing around with more general api-related stuff. while i don't have much to show on my end (apart from the beginnings of some plugin-friendly snmp functions), i'd be interested in what you have to propose. sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From noreply at sourceforge.net Fri May 27 18:26:11 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Fri May 27 18:26:11 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1209978 ] check_load arg parsing and cleanup Message-ID: Patches item #1209978, was opened at 2005-05-27 11:54 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1209978&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Andreas Ericsson (ageric) >Assigned to: M. Sean Finney (seanius) Summary: check_load arg parsing and cleanup Initial Comment: Here's a patch to check_load.c which removes a lot of duplicate code and some unnecessary complexity. It also fixes the argument parsing bug. LOC count is down by 10% and speed is up by about 15, so I guess that's a good thing. Apply with patch -p1 < nagiosplug-check_load.diff ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-05-27 21:22 Message: Logged In: YES user_id=226838 this patch has been committed to the nagiosplug CVS repository. thank you for your contribution. ---------------------------------------------------------------------- Comment By: Andreas Ericsson (ageric) Date: 2005-05-27 12:08 Message: Logged In: YES user_id=1047860 bugfixed patch. See list for details. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1209978&group_id=29880 From ae at op5.se Fri May 27 18:54:20 2005 From: ae at op5.se (Andreas Ericsson) Date: Fri May 27 18:54:20 2005 Subject: [Nagiosplug-devel] check_load arg parsing bugfix and cleanup In-Reply-To: <20050527221720.GA26079@seanius.net> References: <429742E4.4050504@op5.se> <20050527221720.GA26079@seanius.net> Message-ID: <4297CED6.700@op5.se> sean finney wrote: > hey, > > On Fri, May 27, 2005 at 05:55:16PM +0200, Andreas Ericsson wrote: > >>Here's a patch to check_load.c which removes a lot of duplicate code and >>some unnecessary complexity. It also fixes the argument parsing bug. > > > i'll take a look at the latest patch as soon as i have a chance. > Thanks, and thanks for applying it. :) > >>Next I'll rework the api for running commands, since that's the area >>where most plugins duplicate efforts and does so in a very non-efficient >>way. If someone else is already working on this, gimme a holler so we >>can coordinate the efforts. > > > i'm not working directly on this, but i have been messing around with > more general api-related stuff. while i don't have much to show on > my end (apart from the beginnings of some plugin-friendly snmp functions), > i'd be interested in what you have to propose. > It's at http://oss.op5.se/nagios/runcmd.tar.gz. It's basically a revamped spopen() with an output-buf-to-stringarray parsing-routine attached. I've made sure that used values aren't wasted so the complexity of parsing multi-line output is no O(n) instead of O(n+m) like it was before. It makes for quite a save on multiple serial executions. I've also made it async-safe so it should be fairly straight-forward to implement it in the nagios core later on, although that will most likely involve the shell or at least a more shell-like argument parsing routine. Compile with make and run like so: ./runcmd '/usr/bin/find /usr/bin' You can run any command really, but paths aren't understood and it's fairly nice to see that dynamic memory allocation works nicely. I'm particularly fond of the array size calculation which wastes a minimum of memory while making calculations simple and does a maximum of 5 realloc()'s for any average input strlen(). Look for --rsf and you'll see what I mean. It should work well with running snmpget/snmpwalk from a plugin until time and energy has been found to make use of the net-snmp library. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Lead Developer From sghosh at sghosh.org Fri May 27 21:44:01 2005 From: sghosh at sghosh.org (Subhendu Ghosh) Date: Fri May 27 21:44:01 2005 Subject: [Nagiosplug-devel] check_load arg parsing bugfix and cleanup In-Reply-To: <4297CED6.700@op5.se> References: <429742E4.4050504@op5.se> <20050527221720.GA26079@seanius.net> <4297CED6.700@op5.se> Message-ID: On Sat, 28 May 2005, Andreas Ericsson wrote: > > You can run any command really, but paths aren't understood and it's fairly > nice to see that dynamic memory allocation works nicely. I'm particularly > fond of the array size calculation which wastes a minimum of memory while > making calculations simple and does a maximum of 5 realloc()'s for any > average input strlen(). Look for --rsf and you'll see what I mean. > > It should work well with running snmpget/snmpwalk from a plugin until time > and energy has been found to make use of the net-snmp library. > > I have started on the framework for the check_net-snmp to mirror check_snmp but use the libs instead of apps. Should have an alpha in CVS over the long weekend (in the US that is) Once that's working, adding additional snmp checks in C should get easier. -- -sg From noreply at sourceforge.net Sun May 29 14:46:36 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun May 29 14:46:36 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1210958 ] Issue with check_nwstat in Release 1.4 Message-ID: Bugs item #1210958, was opened at 2005-05-30 07:42 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1210958&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Argument proccessing Group: Release (specify) Status: Open Resolution: None Priority: 5 Submitted By: mick81 (mick81) Assigned to: Nobody/Anonymous (nobody) Summary: Issue with check_nwstat in Release 1.4 Initial Comment: I have found a issue with check_nwstat incorrectly reporting free disk space. Using the variable VPF returns Available Entries within Directory Entries of the Volume instead of Free Space in Disk Usage. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1210958&group_id=29880 From seanius at seanius.net Sun May 29 15:01:24 2005 From: seanius at seanius.net (sean finney) Date: Sun May 29 15:01:24 2005 Subject: [Nagiosplug-devel] check_load arg parsing bugfix and cleanup In-Reply-To: <4297CED6.700@op5.se> References: <429742E4.4050504@op5.se> <20050527221720.GA26079@seanius.net> <4297CED6.700@op5.se> Message-ID: <20050529215408.GA18638@seanius.net> hi andreas, On Sat, May 28, 2005 at 03:52:22AM +0200, Andreas Ericsson wrote: > It's at http://oss.op5.se/nagios/runcmd.tar.gz. It's basically a > revamped spopen() with an output-buf-to-stringarray parsing-routine > attached. I've made sure that used values aren't wasted so the > complexity of parsing multi-line output is no O(n) instead of O(n+m) > like it was before. It makes for quite a save on multiple serial executions. i've taken a look over this, and have a couple questions/comments, which i'll share for the benefit of those who probably aren't going to read through it otherwise: first off, i notice some pretty major interface changes to spopen. instead of dealing with FILE pointers we're now dealing with int fd's (or piped pairs, actually). secondly, these are now passed as additional params to the function, instead of existing as global variables. this would mean going through all the nagios plugins code and making some fairly heavy modifications. however, i see this being a generally beneficial thing in the long run--mainly because of code reduction but also because it's generally more friendly towards multithreaded environments (not that i think any plugins will be multithreaded, but certainly a good thing if this were eventually headed for nagios core). about the runcmd functions: any reason not to have "output" be a struct that contains datastructures for both stdout and stderr, and only pass one argument to the functions? sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From news_gonzo at yahoo.fr Mon May 30 05:34:40 2005 From: news_gonzo at yahoo.fr (news gonzo news gonzo) Date: Mon May 30 05:34:40 2005 Subject: [Nagiosplug-devel] Nagios don't execute correctly my plugin Message-ID: <20050530123106.25528.qmail@web26602.mail.ukl.yahoo.com> Hello, I 'm trying to devellop a plugin which is execute correctly in local but not with Nagios For exemple in local exe: debut fonction fin fonc tmp:100 value:0 crit:0 warn:0 CRITICAL - CPU usage 0 but in nagios : debut fonction fin fonc tmp: value: crit:2 warn:0 OKOK - CPU usage As you can it can't have correct value there is my plugin : . /usr/local/nagios/libexec/utils.sh get_value(){ echo -n "debut fonction " tmp=`/usr/bin/top -n 1 | /bin/grep total | /bin/awk '{print $8}' | /bin/awk -F , '{print $1}'` value=`expr 100 - $tmp` echo -n "fin fonc " } wval="" cval="" while [ $# -gt 0 ] do case "$1" in -w) shift wval=$1 ;; -c) shift cval=$1 ;; esac shift done echo -n "tmp:$tmp value:$value crit:$cval warn:$wval " if [ $value -ge $cval ] then echo "CRITICAL - CPU usage $value" exit 2 elif [ $value -ge $wval ] then echo "WARNING - CPU usage $value" exit 1 else echo "OK - CPU usage $value" exit 0 fi echo "impossible" exit 3 Can you help me please :) thx for response _____________________________________________________________________________ D?couvrez le nouveau Yahoo! Mail : 1 Go d'espace de stockage pour vos mails, photos et vid?os ! Cr?ez votre Yahoo! Mail sur http://fr.mail.yahoo.com From ae at op5.se Mon May 30 07:24:27 2005 From: ae at op5.se (Andreas Ericsson) Date: Mon May 30 07:24:27 2005 Subject: [Nagiosplug-devel] check_load arg parsing bugfix and cleanup In-Reply-To: <20050529215408.GA18638@seanius.net> References: <429742E4.4050504@op5.se> <20050527221720.GA26079@seanius.net> <4297CED6.700@op5.se> <20050529215408.GA18638@seanius.net> Message-ID: <429B21A6.3050009@op5.se> sean finney wrote: > hi andreas, > > On Sat, May 28, 2005 at 03:52:22AM +0200, Andreas Ericsson wrote: > >>It's at http://oss.op5.se/nagios/runcmd.tar.gz. It's basically a >>revamped spopen() with an output-buf-to-stringarray parsing-routine >>attached. I've made sure that used values aren't wasted so the >>complexity of parsing multi-line output is no O(n) instead of O(n+m) >>like it was before. It makes for quite a save on multiple serial executions. > > > i've taken a look over this, and have a couple questions/comments, which > i'll share for the benefit of those who probably aren't going to read > through it otherwise: > > first off, i notice some pretty major interface changes to spopen. Yes. This was necessary to make it async safe while maintaining simplicity. The function must be renamed however, since its interface doesn't match that of popen any more. > instead of dealing with FILE pointers we're now dealing with int fd's > (or piped pairs, actually). secondly, these are now passed as additional > params to the function, instead of existing as global variables. > Also for async safety reasons, but the plugins should only call exit_code = np_runcmd(command, &chld_out, &chld_err, flags); and never worry about anything else (the flags parameter is a new addition which makes it possible for plugins decide if they want the output->line array populated or not). > this would mean going through all the nagios plugins code and making > some fairly heavy modifications. Not all that heavy actually since it will mostly involve removing a lot of redundant code. I'll take care of that, so there'll be no need to worry about it. > however, i see this being a generally > beneficial thing in the long run--mainly because of code reduction > but also because it's generally more friendly towards multithreaded > environments (not that i think any plugins will be multithreaded, but > certainly a good thing if this were eventually headed for nagios core). > > about the runcmd functions: any reason not to have "output" be a struct > that contains datastructures for both stdout and stderr, and only pass > one argument to the functions? > The output structure is fairly general and can be used for other things as well (getting data from a network socket, reading files, etc. etc.) If all of it is in the same struct that would mean symbol names will differ further from the start so the linker takes longer to resolve the symbols. It should be possible to choose what output one is interested in so the caller should be able to send NULL instead of a struct. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Lead Developer From ae at op5.se Mon May 30 14:53:31 2005 From: ae at op5.se (Andreas Ericsson) Date: Mon May 30 14:53:31 2005 Subject: [Nagiosplug-devel] check_tcp cleanup and optimization Message-ID: <429B8AF4.5070708@op5.se> Ahoy. Attached is a cleanup and optimization patch for check_tcp. It also removes some redundant code and fixes a potential SIGSEGV in the matching of server_expect against returned output and makes sure it doesn't print perfdata that appears to be OK when the server responded weirdly. Note that further cleaning up should be done for this plugin and parts of it should be redesigned, but that's for another rainy day. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Lead Developer -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: nagiosplug-check_tcp.diff URL: From noreply at sourceforge.net Mon May 30 14:53:50 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon May 30 14:53:50 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1211624 ] check_tcp cleanup (take 1) Message-ID: Patches item #1211624, was opened at 2005-05-30 23:52 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1211624&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None Status: Open Resolution: None Priority: 5 Submitted By: Andreas Ericsson (ageric) Assigned to: Nobody/Anonymous (nobody) Summary: check_tcp cleanup (take 1) Initial Comment: Cleanup and optimization patch for check_tcp. It also removes some redundant code and fixes a potential SIGSEGV in the matching of server_expect against returned output. Note that further cleaning up should be done for this plugin and parts of it should simply be redesigned, but that's for another rainy day. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1211624&group_id=29880 From news_gonzo at yahoo.fr Mon May 30 20:59:03 2005 From: news_gonzo at yahoo.fr (news gonzo news gonzo) Date: Mon May 30 20:59:03 2005 Subject: [Nagiosplug-devel] NRPE Unable to read output Message-ID: <20050530091743.67646.qmail@web26602.mail.ukl.yahoo.com> Hello, I m' trying to devellop Nagios plugin but when I want to check it with NRPE i have the error NRPE : Unable to read output But this plugin works : #!/bin/sh if [ $1 -gt 2 ] then echo "CRITICAL - $1 " exit 2 elif [ $1 -gt 1 ] then echo "WARNING - $1 " exit 1 else echo "OK - $1 " exit 0 fi And this one doesn't work: #!/bin/sh wval="" cval="" while [ $# -gt 0 ] do case "$1" in -w) shift wval=$1 ;; -c) shift cval=$1 ;; esac shift done tmp=`top -n 1 | grep total | awk '{print $8}' | awk -F . '{print $1}'` value=$[100-$tmp] if [ $value -ge $cval ] then echo "CRITICAL - $value" exit 2 elif [ $value -ge $wval ] then echo "WARNING - $value" exit 1 else echo "OK - $value" exit 0 fi With a local execution i haven't any problem Thx for your help :) _____________________________________________________________________________ D?couvrez le nouveau Yahoo! Mail : 1 Go d'espace de stockage pour vos mails, photos et vid?os ! Cr?ez votre Yahoo! Mail sur http://fr.mail.yahoo.com From noreply at sourceforge.net Tue May 31 05:45:12 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Tue May 31 05:45:12 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1211973 ] plugins/common.h sanity fixes Message-ID: Patches item #1211973, was opened at 2005-05-31 14:42 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1211973&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None Status: Open Resolution: None Priority: 5 Submitted By: Andreas Ericsson (ageric) Assigned to: Nobody/Anonymous (nobody) Summary: plugins/common.h sanity fixes Initial Comment: Some small sanity-fixes to plugins/common.h (also sent to nagiosplug-devel@), notably; * protection from being included several times. * defining __attribute__ right at the top, so GNU header files can be imported fairly straight to non-GNU archs (this requires other magic as well, but that's beyond the scope of our code), and so that __attributes__ can be declared for prototypes residing in common.h. * Making default values macros instead of included in enum lists. This has the benefit of other plugins being able to test for their state of definedness and some PTE address range benefits on weird architectures. Apply with patch -p1. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1211973&group_id=29880 From ae at op5.se Tue May 31 05:48:18 2005 From: ae at op5.se (Andreas Ericsson) Date: Tue May 31 05:48:18 2005 Subject: [Nagiosplug-devel] common.h sanity fixes Message-ID: <429C5BF8.1070602@op5.se> The attached patch (also submitted to the tracker) provides some small sanity-fixes to plugins/common.h, notably; * protection from being included several times. * defining __attribute__ right at the top, so GNU header files can be imported fairly straight to non-GNU archs (this requires other magic as well, but that's beyond the scope of our code), and so that __attributes__ can be declared for prototypes residing in common.h. * Making default values macros instead of included in enum lists. This has the benefit of other plugins being able to test for their state of definedness and some PTE address range benefits on weird architectures. Apply with patch -p1. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Lead Developer -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: nagiosplug-common_h-sanity.diff URL: From sabol at alderaan.gsfc.nasa.gov Tue May 31 12:35:43 2005 From: sabol at alderaan.gsfc.nasa.gov (Edward J. Sabol) Date: Tue May 31 12:35:43 2005 Subject: [Nagiosplug-devel] Re: check_procs ELAPSED In-Reply-To: (rodrigo_correo@hotmail.com) References: Message-ID: <200505311933.j4VJXTI7024062@alderaan.gsfc.nasa.gov> > I installed Nagios on Solaris and Linux. Note that the ELAPSED metric is only supposed to work on Linux. > I?m trying to use check_procs plugin to check java process etime (ps ?eo > etime), so I want to receive an alert if the java process has an elapsed > time higher than 1000 second > > The command is: > /usr/lib/nagios/plugins/check_procs -C java ?c 1000 --metric=ELAPSED > > -m, --metric=TYPE > Check thresholds against metric. Valid types: > PROCS - number of processes (default) > VSZ - virtual memory size > RSS - resident set memory size > CPU - percentage cpu > ELAPSED - time elapsed in seconds > > but the result isn?t correct. > > Am I using the correct syntax ?. Yes, I think you are. I recently needed to implement a service check using check_proc's ELAPSED metric, and I couldn't get it to work either. After looking the code, I believe there is a problem with the source code. Which version of Linux are you using? On my Red Hat Linux 7.3 system, check_procs executes: /bin/ps -axwo 'stat uid ppid vsz rss pcpu comm args' However, the process etime needed for the ELAPSED metric test is not included in the output of that command! In order to get the etime, the command needs to be the followng instead: /bin/ps axwwo 'stat uid ppid vsz rss pcpu etime comm args' If you change the PS_COMMAND in config.h, however, the parsing of the `ps' output may need to be altered in check_procs. I still need to check on that, and it's not clear to me what the impact is on check_nagios which also uses PS_COMMAND. Later, Ed [ Please forgive the cross-posting, but I felt I strayed far enough into the development side that it warranted posting to the nagiosplug-devel mailing list. ] From seanius at seanius.net Tue May 31 13:53:25 2005 From: seanius at seanius.net (sean finney) Date: Tue May 31 13:53:25 2005 Subject: [Nagiosplug-devel] Re: check_procs ELAPSED In-Reply-To: <200505311933.j4VJXTI7024062@alderaan.gsfc.nasa.gov> References: <200505311933.j4VJXTI7024062@alderaan.gsfc.nasa.gov> Message-ID: <20050531205115.GA10841@seanius.net> hello, On Tue, May 31, 2005 at 03:33:29PM -0400, Edward J. Sabol wrote: > If you change the PS_COMMAND in config.h, however, the parsing of the `ps' > output may need to be altered in check_procs. I still need to check on that, > and it's not clear to me what the impact is on check_nagios which also uses > PS_COMMAND. in addition to changing PS_COMMAND, you'll need to change PS_FORMAT. the whole ps format autodetection is a real mess (i was just looking at it last week), and should be rethought. my thinking is to remove much of it from the configure.in script, and instead provide a way to specify the options/format from the cmdline, but i probably won't be getting to that any time in the near future because my TODO stack is already nearly toppling over :) sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From noreply at sourceforge.net Tue May 31 20:44:27 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Tue May 31 20:44:27 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1212395 ] check_snmp - don't read MIBS if not needed Message-ID: Patches item #1212395, was opened at 2005-05-31 23:41 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1212395&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: John Sellens (jsellens) Assigned to: Nobody/Anonymous (nobody) Summary: check_snmp - don't read MIBS if not needed Initial Comment: One of the slowdowns in check_snmp is when snmpget reads all the MIB files. But it occurred to me today that if you call check_snmp with an OID (instead of an SNMP variable name), then we don't need to read any MIB files at all. Here's a patch. Thanks! John jsellens at syonex.com ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1212395&group_id=29880