[Nagiosplug-devel] [ nagiosplug-Patches-1339134 ] Fixes --mismatch option for check_tcp

[SourceForge.net]

Patches item #1339134, was opened at 2005-10-27 04:30
Message generated for change (Settings changed) made by tonvoon
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1339134&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Bugfix
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Rick Frey (grater)
>Assigned to: Ton Voon (tonvoon)
Summary: Fixes --mismatch option for check_tcp

Initial Comment:
check_tcp correctly parsed options for --mismatch
option and set var expect_mismatch_state, but never
used var when mismatch was detected (string mismatch
always returned STATE_WARNING regardless of mismatch
argument).

Patch to check_tcp 1.66 (supplied with 1.4.2 plugins):

*** check_tcp.c Sun Jun  5 12:43:58 2005
--- check_tcp.c.patch   Wed Oct 26 22:20:30 2005
***************
*** 350,356 ****
  
        /* did we get the response we hoped? */
        if(match == -2 && result != STATE_CRITICAL)
!               result = STATE_WARNING;
  
        /* reset the alarm */
        alarm (0);
--- 350,356 ----
  
        /* did we get the response we hoped? */
        if(match == -2 && result != STATE_CRITICAL)
!               result = expect_mismatch_state;
  
        /* reset the alarm */
        alarm (0);

----------------------------------------------------------------------

>Comment By: Ton Voon (tonvoon)
Date: 2005-11-04 09:39

Message:
Logged In: YES 
user_id=664364

Rick,

Thanks for the report. Fixed in CVS now. Have added a test into t/
check_imap.t so that this argument will always be checked in the 
automated tests.

Ton

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1339134&group_id=29880