From aurimas.m at interdata.lt Mon Oct 3 01:29:45 2005 From: aurimas.m at interdata.lt (Aurimas Mikalauskas) Date: Mon Oct 3 01:29:45 2005 Subject: [Nagiosplug-devel] check_http feature for clustered web server Message-ID: <141233707.20051003111907@interdata.lt> Hello, I'm missing one feature in check_http nagios plugin that would help monitoring different virtual hosts on clustered web servers. The situtation is simple: I have two virtual hosts www.first-host.com and www.second-host.com both round-robin resolving to 10.0.0.1, 10.0.0.2 and 10.0.0.3. I want to check each virtualhost on each cluster. If I do ./check_http -H www.first-host.com then it will likely round-robin each check to a differend cluster and most likely at least one of them will be alive and return correct data. If I do "./check_http -I 10.0.0.1" then I will be able to check only the first virtual host. If you added one more variable that is the virtual host (even if I use -I 10.0.0.1) somewhere near 824 line after the "Host: ", the plugin would be much closer to perfetct. On the other hand, you could simply expand the variable so it could be used as "http://virtualhost/uri". Thank you in advance for your good work! P.S. I'm not on the list. From aurimas.mikalauskas at gmail.com Mon Oct 3 03:22:22 2005 From: aurimas.mikalauskas at gmail.com (Aurimas Mikalauskas) Date: Mon Oct 3 03:22:22 2005 Subject: [Nagiosplug-devel] check_http feature for web cluster Message-ID: <535f038f0510030320k1cd4f9ddn69d35607347e117d@mail.gmail.com> Hello, I'm missing one feature in check_http nagios plugin that would help monitoring different virtual hosts on clustered web servers. The situtation is simple: I have two virtual hosts www.first-host.com and www.second-host.com both round-robin resolving to 10.0.0.1 , 10.0.0.2and 10.0.0.3 . I want to check each virtualhost on each cluster. If I do ./check_http -H www.first-host.com then it will likely round-robin each check to a differend cluster and most likely at least one of them will be alive and return correct data. If I do "./check_http -I 10.0.0.1 " then I will be able to check only the first virtual host. If you added one more variable that is the virtual host (even if I use -I 10.0.0.1 ) somewhere near 824 line after the "Host: ", the plugin would be much closer to perfetct. On the other hand, you could simply expand the variable so it could be used as "http://virtualhost/uri". Thank you in advance for your good work! Respectfully, Aurimas Mikalauskas -------------- next part -------------- An HTML attachment was scrubbed... URL: From gh at 3gupload.com Mon Oct 3 07:04:42 2005 From: gh at 3gupload.com (Garrett Honeycutt) Date: Mon Oct 3 07:04:42 2005 Subject: [Nagiosplug-devel] check_http feature for web cluster In-Reply-To: <535f038f0510030320k1cd4f9ddn69d35607347e117d@mail.gmail.com> References: <535f038f0510030320k1cd4f9ddn69d35607347e117d@mail.gmail.com> Message-ID: <1128348213.30461.3.camel@gspot.internal.3gupload.com> You should probably define your load balancer as a host and check it using check_http -H www.domain.name and have each machine in your cluster setup as a host with a service description that runs check_http. This is what I do for my web cluster. I think that extended the check to check multiple hosts is not really the correct way to go about things. -g On Mon, 2005-10-03 at 13:20 +0300, Aurimas Mikalauskas wrote: > Hello, > > I'm missing one feature in check_http nagios plugin that would help > monitoring different virtual hosts on clustered web servers. The > situtation is simple: > > I have two virtual hosts www.first-host.com and www.second-host.com > both round-robin resolving to 10.0.0.1, 10.0.0.2 and 10.0.0.3. > > I want to check each virtualhost on each cluster. If I do > ./check_http -H www.first-host.com > > then it will likely round-robin each check to a differend cluster and > most likely at least one of them will be alive and return correct > data. > > If I do "./check_http -I 10.0.0.1" then I will be able to check only > the first virtual host. > > If you added one more variable that is the virtual host (even if I use > -I 10.0.0.1) somewhere near 824 line after the "Host: ", the plugin > would be much closer to perfetct. On the other hand, you could simply > expand the variable so it could be used as > "http://virtualhost/uri". > > Thank you in advance for your good work! > > Respectfully, > Aurimas Mikalauskas -- // Garrett Honeycutt // Sr. Systems Administrator // 3GUpload.com, Inc. // 317.472.4969 Office From poncki.lists at axelspringer.com.pl Wed Oct 5 09:00:56 2005 From: poncki.lists at axelspringer.com.pl (Tomasz Pilat) Date: Wed Oct 5 09:00:56 2005 Subject: [Nagiosplug-devel] check_snmp 1.4.2 won't compile under gcc 2.* Message-ID: <839763214.20051005175916@axelspringer.com.pl> Hello. There is little bug in check_snmp.c (line 341) which is preventing compilation on platforms using gcc 2.* (Solaris, FreeBSD 4 for example). 341: char *str[MAX_INPUT_BUFFER]; 342: asprintf(str, "=%s%s;;;; ", show, type ? type : ""); 341: strcat(perfstr, *str); Older gcc does not allow declarations here, this line should be moved to the top of main() (line 144 for example). This is somehow related to <30A4A13F-63D9-4FEB-8766-E436116A62E9 at khan.org> (Problem compiling check_snmp.c on Solaris 8 [with fix?]) Details (for future list archive searches): gcc version 2.95.4 20020320 [FreeBSD] source='check_snmp.c' object='check_snmp.o' libtool=no \ DEPDIR=.deps depmode=gcc /bin/sh ../depcomp \ cc -DLOCALEDIR=\"/usr/local/share/nagios/locale\" -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I../lib -I../intl -I/usr/local/include -O -pipe -c check_snmp.c check_snmp.c: In function `main': check_snmp.c:341: syntax error before `char' check_snmp.c:342: `str' undeclared (first use in this function) check_snmp.c:342: (Each undeclared identifier is reported only once check_snmp.c:342: for each function it appears in.) gmake[2]: *** [check_snmp.o] Error 1 gmake[2]: Leaving directory `/var/local/workdir/usr/ports/net-mgmt/nagios-plugins/work/nagios-plugins-1.4.2/plugins' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/var/local/workdir/usr/ports/net-mgmt/nagios-plugins/work/nagios-plugins-1.4.2' gmake: *** [all] Error 2 *** Error code 2 HTH. Ponc -- Tomasz Pilat http://poncki.freebsd.pl./ AXEL SPRINGER POLSKA Sp. z o.o. PONC-RIPE | PGPKEY-EDEB47FC A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing on e-mail/Usenet? From khan at khan.org Wed Oct 5 12:56:13 2005 From: khan at khan.org (Khan Klatt) Date: Wed Oct 5 12:56:13 2005 Subject: [Nagiosplug-devel] check_snmp 1.4.2 won't compile under gcc 2.* In-Reply-To: <839763214.20051005175916@axelspringer.com.pl> References: <839763214.20051005175916@axelspringer.com.pl> Message-ID: <49742.69.25.135.238.1128541990.squirrel@mail.geckowerx.com> Yes, I submitted a fix for this, but I'm not familiar with how to get patches applied to the codebase. -K > Hello. > > There is little bug in check_snmp.c (line 341) which is preventing > compilation on platforms using gcc 2.* (Solaris, FreeBSD 4 for > example). > > 341: char *str[MAX_INPUT_BUFFER]; > 342: asprintf(str, "=%s%s;;;; ", show, type ? type : ""); > 341: strcat(perfstr, *str); > > Older gcc does not allow declarations here, this line should be moved > to the top of main() (line 144 for example). > > This is somehow related to <30A4A13F-63D9-4FEB-8766-E436116A62E9 at khan.org> > (Problem compiling check_snmp.c on Solaris 8 [with fix?]) > > Details (for future list archive searches): > > gcc version 2.95.4 20020320 [FreeBSD] > > source='check_snmp.c' object='check_snmp.o' libtool=no \ > DEPDIR=.deps depmode=gcc /bin/sh ../depcomp \ > cc -DLOCALEDIR=\"/usr/local/share/nagios/locale\" -DHAVE_CONFIG_H -I. -I. > -I.. -I.. -I../lib -I../intl -I/usr/local/include -O -pipe -c > check_snmp.c > check_snmp.c: In function `main': > check_snmp.c:341: syntax error before `char' > check_snmp.c:342: `str' undeclared (first use in this function) > check_snmp.c:342: (Each undeclared identifier is reported only once > check_snmp.c:342: for each function it appears in.) > gmake[2]: *** [check_snmp.o] Error 1 > gmake[2]: Leaving directory > `/var/local/workdir/usr/ports/net-mgmt/nagios-plugins/work/nagios-plugins-1.4.2/plugins' > gmake[1]: *** [all-recursive] Error 1 > gmake[1]: Leaving directory > `/var/local/workdir/usr/ports/net-mgmt/nagios-plugins/work/nagios-plugins-1.4.2' > gmake: *** [all] Error 2 > *** Error code 2 > > > HTH. > Ponc > -- > Tomasz Pilat http://poncki.freebsd.pl./ > AXEL SPRINGER POLSKA Sp. z o.o. PONC-RIPE | PGPKEY-EDEB47FC > > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing on e-mail/Usenet? > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Power Architecture Resource Center: Free content, downloads, discussions, > and more. http://solutions.newsforge.com/ibmarch.tmpl > _______________________________________________________ > Nagios Plugin Development Mailing List > Nagiosplug-devel at lists.sourceforge.net > Unsubscribe at > https://lists.sourceforge.net/lists/listinfo/nagiosplug-devel > ::: Please include plugins version (-v) and OS when reporting any issue. > ::: Messages without supporting info will risk being sent to /dev/null > From noreply at sourceforge.net Wed Oct 5 22:34:57 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 5 22:34:57 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1314503 ] nagios cant check local sockets Message-ID: Bugs item #1314503, was opened at 2005-10-06 08:33 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1314503&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Submitted By: Alex Samorukov (samm2) Assigned to: Nobody/Anonymous (nobody) Summary: nagios cant check local sockets Initial Comment: Hi. It is not a bug, its a feture request but i sent patch MANY month ago and i still have no any reaction on it :( It is still open. Some users use it (they wrote me mail) but i dont know why it is not included in the sources :( Bug itself is that check_tcp (and it childs) cant check services on local sockets. I am sure that many services which dont need to communicate with external world have only local socket connectors, e.g. clamav antivirus, or local SQL server, etc. The patch (newdiff file) is located on http://sourceforge.net/tracker/index.php?func=detail&aid=1145413&group_id=29880&atid=397599 I used on my servers and it seems to work fine. I hope to see it in later releases or explanation why this cannot be done. With best regards, Alex Samorukov ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1314503&group_id=29880 From noreply at sourceforge.net Thu Oct 6 06:13:51 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 6 06:13:51 2005 Subject: [Nagiosplug-devel] [ nagiosplug-New Plugins-1314918 ] HP Smart Array Hardware status plugin for Nagios Message-ID: New Plugins item #1314918, was opened at 2005-10-06 15:11 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1314918&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: System monitor Group: None Status: Open Resolution: None Priority: 5 Submitted By: Simone Rosa (simonerosa) Assigned to: Nobody/Anonymous (nobody) Summary: HP Smart Array Hardware status plugin for Nagios Initial Comment: HP Smart Array Hardware status plugin for Nagios Written by Simone Rosa (info at simonerosa.it) Last Modified: 06-10-2005 Usage: ./check_cciss -N [-v | --verbose] Description: This plugin checks hardware status for Smart Array Controllers, using the HP Array Configuration Utility CLI. NOTE: HP Array Configuration Utility CLI 7.40.7.0 need administrator rights. Please add this line to /etc/sudoers -------------------------------------------------- nagios ALL=NOPASSWD: /usr/sbin/hpacucli -------------------------------------------------- Today you can find HP Array Configuration Utility CLI for Linux version 7.40-7 (9 Sep 05) here: http://h18000.www1.hp.com/support/files/server/us/downl oad/23022.html ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1314918&group_id=29880 From mdanilov at pkb.ru Fri Oct 7 00:57:37 2005 From: mdanilov at pkb.ru (Mikhail Danilov) Date: Fri Oct 7 00:57:37 2005 Subject: [Nagiosplug-devel] Nagios' remote checks Message-ID: <023101c5cb0d$d3ee9990$2409c881@pcbn> Hello, First of all i want to say you thanks for your great idea to write such usefull plugins. But i faced with some problems when i began to use them. 1. check_disk_remote there was some strange problem with definition of current status by Nagios. On two servers Nagios showed current status UNKNOWN though Status information was OK and echo $? was 0. On other servers all were ok. I removed next strings from plugin check_disk_remote: # declare an error if we also get a non-zero return code from load # unless already set to critical #if ( $? ) { # print "stderr = $? : $! \n" if $verbose; # $state = $state == $ERRORS{"CRITICAL"} ? $ERRORS{"CRITICAL"} : $ERRORS{"UNKNOWN"} ; # print "error: $!\n" if $verbose; #} And all became to work properly 2. check_load_remote. This script works fine except when the load on any server is four figures (f.e. 12.0,13.4,14.0) At that time nagios shows like this: Current Status: OK Status Information:OK: load () is below threshold (12/15) Performance Data:load= Script can't count up the simple average of load values. I suspect that problem somewhere there: my $avg = $2 if /load average: (\S{4}), (\S{4}), (\S{4})/i; And there was the same problem with status which i solved the same way as in previous case. Please could you advise me what should i do in order to change these scripts correctly? Nagios' version is 2.0b4 plugins versions are: bash-3.00$ ./check_load_remote -V check_load_remote (nagios-plugins 1.4.1) 1.0 bash-3.00$ ./check_disk_remote -V check_disk_remote (nagios-plugins 1.4.1) 1.0 OS with Nagios - FC3 bash-3.00$ uname -a Linux fly.pcb 2.6.12-1.1376_FC3 #1 Fri Aug 26 23:27:26 EDT 2005 i686 i686 i386 GNU/Linux OS under test - Solaris 8 and 9 If you need more information i would be glad to grant it Thank you for you attention. With best regards, Mikhail Danilov -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at sourceforge.net Fri Oct 7 01:41:40 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 7 01:41:40 2005 Subject: [Nagiosplug-devel] [ nagiosplug-New Plugins-1314918 ] HP Smart Array Hardware status plugin for Nagios Message-ID: New Plugins item #1314918, was opened at 2005-10-06 15:11 Message generated for change (Comment added) made by simonerosa You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1314918&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: System monitor Group: None Status: Open Resolution: None Priority: 5 Submitted By: Simone Rosa (simonerosa) Assigned to: Nobody/Anonymous (nobody) Summary: HP Smart Array Hardware status plugin for Nagios Initial Comment: HP Smart Array Hardware status plugin for Nagios Written by Simone Rosa (info at simonerosa.it) Last Modified: 06-10-2005 Usage: ./check_cciss -N [-v | --verbose] Description: This plugin checks hardware status for Smart Array Controllers, using the HP Array Configuration Utility CLI. NOTE: HP Array Configuration Utility CLI 7.40.7.0 need administrator rights. Please add this line to /etc/sudoers -------------------------------------------------- nagios ALL=NOPASSWD: /usr/sbin/hpacucli -------------------------------------------------- Today you can find HP Array Configuration Utility CLI for Linux version 7.40-7 (9 Sep 05) here: http://h18000.www1.hp.com/support/files/server/us/downl oad/23022.html ---------------------------------------------------------------------- >Comment By: Simone Rosa (simonerosa) Date: 2005-10-07 10:40 Message: Logged In: YES user_id=1357423 UPDATE to v1.1 (with Debug): HP Smart Array Hardware status plugin for Nagios (1.1) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1314918&group_id=29880 From noreply at sourceforge.net Fri Oct 7 10:53:00 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 7 10:53:00 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1291126 ] Alternate ps for Solaris Message-ID: Bugs item #1291126, was opened at 2005-09-14 12:04 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1291126&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: CVS Status: Open Resolution: None Priority: 5 Submitted By: Bob Ingraham (rwingraham) Assigned to: M. Sean Finney (seanius) Summary: Alternate ps for Solaris Initial Comment: Per Sean, I am uploading the source for an alternate ps utility for Solaris that will work with the existing check_procs plugin. This alternate ps gets around the 80-character limitation inherent in the native ps for Solaris. It has been extensively testing on our corporate Solaris farm. Notes: 1. I've installed this alternate ps (called pst3) in the libexec directory, along with the other plugins. 2. It needs setuid-root permissions to run, but accepts no arguments and reads no input streams and therefore isn't subject to exploitations such as buffer overflow and the like. The only reason is needs the setuid-root permission is so that it can open the running kernel image, in READ-ONLY mode, in order to access the process argument vectors. 3. It requires a patch to the configuration file which substitutes this alternate utility instead of ps for Soalris systems. Bob ---------------------------------------------------------------------- >Comment By: M. Sean Finney (seanius) Date: 2005-10-07 13:50 Message: Logged In: YES user_id=226838 hi bob, any chance you've taken a look to see if check_procs now works for you from cvs? about the other issues, i guess i don't have the interest to look more into it if you don't :) ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-09-25 11:23 Message: Logged In: YES user_id=226838 hi bob, i've now included your code in cvs head, and mangled the configure script appropriately, so pst3 should now be the default for all SunOS systems. could you try the latest copy of what's in cvs and verify that it works for you? as i previously stated, i don't have r00t on a solaris machine, unfortunately :( likewise, to any others who have r00t access on a solaris bug, i'd appreciate hearing back. ---------------------------------------------------------------------- Comment By: Bob Ingraham (rwingraham) Date: 2005-09-22 15:20 Message: Logged In: YES user_id=1086870 Sean, To answer your previous posts (sorry for the delay - I've been slammed at work,): 1. why isn't pPsInfo->pr_pid included in the output? I designed pst3 to exactly duplicate the output columns produced by the output produced by the original Solaris ps command: /usr/bin/ps -Ao 's uid ppid vsz rss pcpu comm args' You'll notice that Parent-PID is requested (ppid) but not the current process PID (pid). According to the source for check_procs, you can search for children of a parent PID (hence the ppid,) or you can search for a username/uid (hence the uid). But apparetnly, the option is not provided to search for just a PID. 2. You need root access on a Solaris server. I have a Solaris box I can test you config changes on. 3. Can I drop privileges after opening the kernel image? I don't know if it will work. That would depend upon whether the subsequent kvm_* calls also check the effective UID of the caller or not. Do you still want me to try this? Bob ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-09-22 07:40 Message: Logged In: YES user_id=226838 slight complication, i'll email the list with details... ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-09-22 05:32 Message: Logged In: YES user_id=226838 btw: why isn't pPsInfo->pr_pid included in the output? ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-09-22 05:16 Message: Logged In: YES user_id=226838 hi bob, ton, i just finished looking over the script, and it looks good. unfortunately i no longer have root access to a solaris server, so i can't install the plugin setuid root. i can still throw together everything else (the configure patch, etc), but the final test will need to be conducted by someone else. ---------------------------------------------------------------------- Comment By: Ton Voon (tonvoon) Date: 2005-09-21 06:14 Message: Logged In: YES user_id=664364 Sean, plugins-root/ is created now. This would be the best place to put pst3. Ton ---------------------------------------------------------------------- Comment By: Ton Voon (tonvoon) Date: 2005-09-20 03:55 Message: Logged In: YES user_id=664364 Sean, I have no problem with setuid scripts since we already have check_icmp and check_dhcp, but they don't install as root at the moment (it is manually done). I am trying to separate setuid scripts out to plugins- root/ so then the installer can be configured to install with the correct permissions, but haven't fully tested my local copy yet. Give me another day to sort this out. Ton ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-09-19 11:27 Message: Logged In: YES user_id=226838 hi bob, thanks for this, i've just taken a look over it. if this program has to run setuid root to open the kmem structure, would it be possible to drop priviliges immediately after having done so? ton: what are your thoughts about dropping this utility in the libexec dir? i could throw together a pretty quick configure patch to decide whether or not the ps utility was needed. not sure how we're handling the other setuid programs, but i could follow suit with whatever we're doing for the others ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1291126&group_id=29880 From noreply at sourceforge.net Mon Oct 10 03:26:46 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 10 03:26:46 2005 Subject: [Nagiosplug-devel] [ nagiosplug-New Plugins-1314918 ] HP Smart Array Hardware status plugin for Nagios Message-ID: New Plugins item #1314918, was opened at 2005-10-06 15:11 Message generated for change (Comment added) made by engelenh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1314918&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: System monitor Group: None Status: Open Resolution: None Priority: 5 Submitted By: Simone Rosa (simonerosa) Assigned to: Nobody/Anonymous (nobody) Summary: HP Smart Array Hardware status plugin for Nagios Initial Comment: HP Smart Array Hardware status plugin for Nagios Written by Simone Rosa (info at simonerosa.it) Last Modified: 06-10-2005 Usage: ./check_cciss -N [-v | --verbose] Description: This plugin checks hardware status for Smart Array Controllers, using the HP Array Configuration Utility CLI. NOTE: HP Array Configuration Utility CLI 7.40.7.0 need administrator rights. Please add this line to /etc/sudoers -------------------------------------------------- nagios ALL=NOPASSWD: /usr/sbin/hpacucli -------------------------------------------------- Today you can find HP Array Configuration Utility CLI for Linux version 7.40-7 (9 Sep 05) here: http://h18000.www1.hp.com/support/files/server/us/downl oad/23022.html ---------------------------------------------------------------------- Comment By: Hans Engelen (engelenh) Date: 2005-10-10 12:25 Message: Logged In: YES user_id=53586 I would like to point out that this check could be expanded to provide similar support easily for older cpqarray drives such as the Compaq Smart Array 3200 controller (found in Compaq 6500 machines for one). The same compaq cli utility supports these drives too. However their status resides in /proc/driver/cpqarray/idax (with x being the number of the controller and not related to the slot in which it is, so first controller is ida0 no matter what slot it is in) instead of /proc/driver/cciss/ccissx as is hardcoded in check_cciss now. ---------------------------------------------------------------------- Comment By: Simone Rosa (simonerosa) Date: 2005-10-07 10:40 Message: Logged In: YES user_id=1357423 UPDATE to v1.1 (with Debug): HP Smart Array Hardware status plugin for Nagios (1.1) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1314918&group_id=29880 From noreply at sourceforge.net Mon Oct 10 08:03:47 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 10 08:03:47 2005 Subject: [Nagiosplug-devel] [ nagiosplug-New Plugins-1314918 ] HP Smart Array Hardware status plugin for Nagios Message-ID: New Plugins item #1314918, was opened at 2005-10-06 15:11 Message generated for change (Comment added) made by simonerosa You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1314918&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: System monitor Group: None Status: Open Resolution: None Priority: 5 Submitted By: Simone Rosa (simonerosa) Assigned to: Nobody/Anonymous (nobody) Summary: HP Smart Array Hardware status plugin for Nagios Initial Comment: HP Smart Array Hardware status plugin for Nagios Written by Simone Rosa (info at simonerosa.it) Last Modified: 06-10-2005 Usage: ./check_cciss -N [-v | --verbose] Description: This plugin checks hardware status for Smart Array Controllers, using the HP Array Configuration Utility CLI. NOTE: HP Array Configuration Utility CLI 7.40.7.0 need administrator rights. Please add this line to /etc/sudoers -------------------------------------------------- nagios ALL=NOPASSWD: /usr/sbin/hpacucli -------------------------------------------------- Today you can find HP Array Configuration Utility CLI for Linux version 7.40-7 (9 Sep 05) here: http://h18000.www1.hp.com/support/files/server/us/downl oad/23022.html ---------------------------------------------------------------------- >Comment By: Simone Rosa (simonerosa) Date: 2005-10-10 17:02 Message: Logged In: YES user_id=1357423 Now it's compatible with "Compaq Smart Array" ( /proc/driver/cpqarray/ ) # HP Smart Array Hardware status plugin for Nagios # ( With HP Array Configuration Utility CLI ) # Last Modified: 10-10-2005 - Revision: 1.2 Usage: check_cciss -N [-c] [-v | -- verbose] [-d | --debug] Usage: check_cciss [-h | --help] Usage: check_cciss [-V | --version] Usage: ./check_cciss -N [-c] [-v | -- verbose] [-d | --debug] default (without -c) = use /proc/driver/cciss/ ( HP Smart Array ) -c = use /proc/driver/cpqarray/ ( Compaq Smart Array ) -v = output status and informations about RAID -d = use for debug ( command line mode ) ---------------------------------------------------------------------- Comment By: Hans Engelen (engelenh) Date: 2005-10-10 12:25 Message: Logged In: YES user_id=53586 I would like to point out that this check could be expanded to provide similar support easily for older cpqarray drives such as the Compaq Smart Array 3200 controller (found in Compaq 6500 machines for one). The same compaq cli utility supports these drives too. However their status resides in /proc/driver/cpqarray/idax (with x being the number of the controller and not related to the slot in which it is, so first controller is ida0 no matter what slot it is in) instead of /proc/driver/cciss/ccissx as is hardcoded in check_cciss now. ---------------------------------------------------------------------- Comment By: Simone Rosa (simonerosa) Date: 2005-10-07 10:40 Message: Logged In: YES user_id=1357423 UPDATE to v1.1 (with Debug): HP Smart Array Hardware status plugin for Nagios (1.1) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1314918&group_id=29880 From noreply at sourceforge.net Mon Oct 10 12:42:36 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 10 12:42:36 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1323230 ] check_http proxy-authorization option Message-ID: Patches item #1323230, was opened at 2005-10-10 21:41 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1323230&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None Status: Open Resolution: None Priority: 5 Submitted By: Marcel Kuiper (ku1111) Assigned to: Nobody/Anonymous (nobody) Summary: check_http proxy-authorization option Initial Comment: I've added an option (-b, --proxy-authorization user:password) for doing basic Proxy-Authorization with check_http. (Plus added --authorization to the long optionlist as the help describes) Patch is against version 1.81 of check_httpd.c in context diff format Hopefully this will be incoporated in some form in a next relelase THNX Marcel Kuiper ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1323230&group_id=29880 From marcel at mknet.nl Mon Oct 10 12:58:44 2005 From: marcel at mknet.nl (Marcel Kuiper) Date: Mon Oct 10 12:58:44 2005 Subject: [Nagiosplug-devel] Patch request id 1323230: check_http.c proxy-authorization option added Message-ID: <434AC819.5090603@mknet.nl> Hi list, As per developer docu I send this mail to inform you of a small patch (request id: 1323230) against check_http.c 1.81. The patch adds an option to enable proxy authorization. Cheers Marcel Kuiper From rouilj at cs.umb.edu Wed Oct 12 11:00:50 2005 From: rouilj at cs.umb.edu (John P. Rouillard) Date: Wed Oct 12 11:00:50 2005 Subject: [Nagiosplug-devel] (no subject) Message-ID: <200510121759.j9CHxw4X016164@mx1.cs.umb.edu> Hello all: I have been trying to use check_by_ssh with an ssh-agent to allow encrypted keys to be kept on the system. While using spopen in the plugin is a great idea, it breaks using the ssh-agent to manage keys since the required environment variable: SSH_AUTH_SOCK isn't present in the child environment. I had patched this once (at another job, code unavailable) by duplicating spopen to spopenenv and adding a second argument that was a list of the environment strings (retrieved with getenv) that should be added to the child environment. So does adding support to check_by_ssh to use an ssh-agent sound reasonable? -- rouilj John Rouillard =========================================================================== My employers don't acknowledge my existence much less my opinions. From tonvoon at mac.com Thu Oct 13 02:48:00 2005 From: tonvoon at mac.com (Ton Voon) Date: Thu Oct 13 02:48:00 2005 Subject: [Nagiosplug-devel] spopenenv (Was: no subject) In-Reply-To: <200510121759.j9CHxw4X016164@mx1.cs.umb.edu> References: <200510121759.j9CHxw4X016164@mx1.cs.umb.edu> Message-ID: <02F3F455-47E6-453A-A6F3-B9DABFE654B2@mac.com> On 12 Oct 2005, at 18:59, John P. Rouillard wrote: > > Hello all: > > I have been trying to use check_by_ssh with an ssh-agent to allow > encrypted keys to be kept on the system. > > While using spopen in the plugin is a great idea, it breaks using the > ssh-agent to manage keys since the required environment variable: > SSH_AUTH_SOCK isn't present in the child environment. > > I had patched this once (at another job, code unavailable) by > duplicating spopen to spopenenv and adding a second argument that was > a list of the environment strings (retrieved with getenv) that should > be added to the child environment. > > So does adding support to check_by_ssh to use an ssh-agent sound > reasonable? I think this sounds like a good idea. Is it possible to have the 2nd argument to spopen be the optional array of variables? That way we're not trying to maintain a spopen and an spopenenv. Ton From ton.voon at altinity.com Thu Oct 13 03:15:11 2005 From: ton.voon at altinity.com (Ton Voon) Date: Thu Oct 13 03:15:11 2005 Subject: [Nagiosplug-devel] check_cluster and check_cluster2 into main distribution Message-ID: Hi! Wanted to hear some opinions on this. I've only recently come across check_cluster and check_cluster2 (written by Ethan) and I think these should be in the main distribution. ( A quick recap: check_cluster works by specifying a list of host/ service pairs and it returns a status based on the status of those - it does this by querying the status log file. check_cluster2 has an argument list of the actual status codes because it uses Nagios 2's clever macros to work out status. ) But check_cluster only makes sense for Nagios 1 installs, so we probably should be configuring things differently. This is not unprecedented since check_nagios tries to read Nagios' status file, so there are dependencies on the version of Nagios here too. I think there is an outstanding bug here which I'll fix as part of this work. Thus I propose making the following changes: - at configure time, have option to compile --with-nagios-version=1 or 2, default 1 (we can change default when Nagios 2.0 is released) - for nagios-1, set NAGIOS_VERSION=1, add check_cluster to list of plugins - for nagios-2, set NAGIOS_VERSION=2 - always compile check_nagios (with ifdefs around Nagios version specific parts) and check_cluster2 Also, maybe a rename of check_cluster2 to, say, check_cluster_states? Does this make sense? Any other ways of doing this? Ton http://www.altinity.com T: +44 (0)870 787 9243 F: +44 (0)845 280 1725 Skype: tonvoon From seanius at seanius.net Thu Oct 13 03:48:40 2005 From: seanius at seanius.net (sean finney) Date: Thu Oct 13 03:48:40 2005 Subject: [Nagiosplug-devel] update for nagios-plugins and debian Message-ID: <20051013104542.GA12152@seanius.net> hey folks, just fyi, i've recently got my hands on the debian nagios-plugins package, and have brought it under the umbrella of the debian nagios packaging team. i've now brought the package up to date with the latest official release (was previously at 1.4). i've also tackled a fair number of bugs that were reported in the debian bts, which i've now merged into CVS HEAD here. most of the changes that have come through the debian bts will have an entry in the cvs commit (and thus the changelog i guess) referencing the bug number in the debian bts. for those who are curious, you can then visit the bug by going to http://bugs.debian.org/$bugnumber. you can also see all bugs against nagios-plugins by visiting http://bugs.debian.org/cgi-bin/pkgreport.cgi?src=nagios-plugins. btw, as i've mentioned, there's a "debian packaging team", which consists of myself and a couple other individuals. the team is coordinated through "alioth"[1], which is essentially the same thing as sourceforge, though we only use the cvs repositories and mailing lists. i'm trying to get as much of the "nagios family" there, and make it a coordinated center for everything nagios in debian. if anyone would be interested in working in this group (you don't have to be a debian developer) please let me know. note that this is not intended to be an alternate development tree to nagios, but more like a tree of the "debian-refined" changes made to the plugins. also, it will include patches for bugfixes etc from cvs HEAD here in between releases, and also serve as another source for bugreports, which will result in fixes coming back this way. sean [1] http://alioth.debian.org/projects/pkg-nagios -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From ae at op5.se Thu Oct 13 04:17:29 2005 From: ae at op5.se (Andreas Ericsson) Date: Thu Oct 13 04:17:29 2005 Subject: [Nagiosplug-devel] spopenenv (Was: no subject) In-Reply-To: <02F3F455-47E6-453A-A6F3-B9DABFE654B2@mac.com> References: <200510121759.j9CHxw4X016164@mx1.cs.umb.edu> <02F3F455-47E6-453A-A6F3-B9DABFE654B2@mac.com> Message-ID: <434E41DC.9090108@op5.se> Ton Voon wrote: > > On 12 Oct 2005, at 18:59, John P. Rouillard wrote: > >> >> Hello all: >> >> I have been trying to use check_by_ssh with an ssh-agent to allow >> encrypted keys to be kept on the system. >> >> While using spopen in the plugin is a great idea, it breaks using the >> ssh-agent to manage keys since the required environment variable: >> SSH_AUTH_SOCK isn't present in the child environment. >> >> I had patched this once (at another job, code unavailable) by >> duplicating spopen to spopenenv and adding a second argument that was >> a list of the environment strings (retrieved with getenv) that should >> be added to the child environment. >> >> So does adding support to check_by_ssh to use an ssh-agent sound >> reasonable? > > > I think this sounds like a good idea. > > Is it possible to have the 2nd argument to spopen be the optional array > of variables? That way we're not trying to maintain a spopen and an > spopenenv. > FILE *spopenenv(const char *cmd, char **envp); #define spopen(cmd) spopenenv(cmd, NULL) No hassle while staying backwards-compatible. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 From ae at op5.se Thu Oct 13 04:22:07 2005 From: ae at op5.se (Andreas Ericsson) Date: Thu Oct 13 04:22:07 2005 Subject: [Nagiosplug-devel] check_cluster and check_cluster2 into main distribution In-Reply-To: References: Message-ID: <434E42C9.2050508@op5.se> Ton Voon wrote: > Hi! > > Wanted to hear some opinions on this. I've only recently come across > check_cluster and check_cluster2 (written by Ethan) and I think these > should be in the main distribution. > > ( A quick recap: check_cluster works by specifying a list of host/ > service pairs and it returns a status based on the status of those - it > does this by querying the status log file. check_cluster2 has an > argument list of the actual status codes because it uses Nagios 2's > clever macros to work out status. ) > > But check_cluster only makes sense for Nagios 1 installs, so we > probably should be configuring things differently. This is not > unprecedented since check_nagios tries to read Nagios' status file, so > there are dependencies on the version of Nagios here too. I think there > is an outstanding bug here which I'll fix as part of this work. > > Thus I propose making the following changes: > > - at configure time, have option to compile --with-nagios-version=1 or > 2, default 1 (we can change default when Nagios 2.0 is released) > - for nagios-1, set NAGIOS_VERSION=1, add check_cluster to list of plugins > - for nagios-2, set NAGIOS_VERSION=2 > - always compile check_nagios (with ifdefs around Nagios version > specific parts) and check_cluster2 > > Also, maybe a rename of check_cluster2 to, say, check_cluster_states? > > Does this make sense? Any other ways of doing this? > The obvious way would be through a NEB-module which wouldn't have to use on-demand macros (which are hard to get right). Keep check_cluster for use with Nagios 1.x. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 From ton.voon at altinity.com Thu Oct 13 04:23:44 2005 From: ton.voon at altinity.com (Ton Voon) Date: Thu Oct 13 04:23:44 2005 Subject: [Nagiosplug-devel] update for nagios-plugins and debian In-Reply-To: <20051013104542.GA12152@seanius.net> References: <20051013104542.GA12152@seanius.net> Message-ID: On 13 Oct 2005, at 11:45, sean finney wrote: > note that this is not intended to be an alternate development tree > to nagios, but more like a tree of the "debian-refined" changes > made to the plugins. also, it will include patches for bugfixes etc > from cvs HEAD here in between releases, and also serve as another > source for bugreports, which will result in fixes coming back this > way. Sean, Cool - good to see lots of work happening on the plugins. Bit concerned about the huge list of bugs (!) My angle is that, obviously, I would like bugfixes to come back upstream. Let me know if there is anything I can do to facilitate this. I'm also interested in how you are marking differences between trees. For Altinity, there are some fixes that we need to apply, but anything that is generally useful I apply to the main SF tree at the same time. I store on our local CVS server the tar.gz distribution and then apply patch files in our custom Makefile. This way I know all the changes from our code to the released file. The idea is I can just replace the released file with a newer version, run a make and during the patch process it should tell me all the things that have already been fixed (or that I may need to amend a patch for). I notice you are using an actual "exploded" CVS tree. Does your method work well when syncing trees? Ton http://www.altinity.com T: +44 (0)870 787 9243 F: +44 (0)845 280 1725 Skype: tonvoon -------------- next part -------------- An HTML attachment was scrubbed... URL: From tonvoon at mac.com Thu Oct 13 04:30:47 2005 From: tonvoon at mac.com (Ton Voon) Date: Thu Oct 13 04:30:47 2005 Subject: [Nagiosplug-devel] spopenenv (Was: no subject) In-Reply-To: <434E41DC.9090108@op5.se> References: <200510121759.j9CHxw4X016164@mx1.cs.umb.edu> <02F3F455-47E6-453A-A6F3-B9DABFE654B2@mac.com> <434E41DC.9090108@op5.se> Message-ID: On 13 Oct 2005, at 12:15, Andreas Ericsson wrote: > > FILE *spopenenv(const char *cmd, char **envp); > #define spopen(cmd) spopenenv(cmd, NULL) > > No hassle while staying backwards-compatible. Neat trick. John, if you can supply a patch for spopen to become spopenenv, I'll look into getting it in. On a somewhat different note, I've been converted into continous unit testing and the above change is one that would have been perfect for the tests, if they existed. Does anyone know of any methods for unit testing C routines similar to perl's Test module? Ton From rouilj at cs.umb.edu Thu Oct 13 05:41:37 2005 From: rouilj at cs.umb.edu (John P. Rouillard) Date: Thu Oct 13 05:41:37 2005 Subject: [Nagiosplug-devel] spopenenv (Was: no subject) In-Reply-To: Your message of "Thu, 13 Oct 2005 10:46:04 BST." <02F3F455-47E6-453A-A6F3-B9DABFE654B2@mac.com> Message-ID: <200510131240.j9DCerjX022105@mx1.cs.umb.edu> In message <02F3F455-47E6-453A-A6F3-B9DABFE654B2 at mac.com>, Ton Voon writes: >On 12 Oct 2005, at 18:59, John P. Rouillard wrote: >> I have been trying to use check_by_ssh with an ssh-agent to allow >> encrypted keys to be kept on the system. >> >> While using spopen in the plugin is a great idea, it breaks using the >> ssh-agent to manage keys since the required environment variable: >> SSH_AUTH_SOCK isn't present in the child environment. >> >> I had patched this once (at another job, code unavailable) by >> duplicating spopen to spopenenv and adding a second argument that was >> a list of the environment strings (retrieved with getenv) that should >> be added to the child environment. >> >> So does adding support to check_by_ssh to use an ssh-agent sound >> reasonable? > >I think this sounds like a good idea. > >Is it possible to have the 2nd argument to spopen be the optional >array of variables? That way we're not trying to maintain a spopen >and an spopenenv. You could use a varargs list I suppose. Another way to do it might be with a macro that maps: spopen(a) -> spopenenv (a, NULL) and then you just have spopenenv. But it's been a long time since I have done C programming (almost 20 years sigh). BTW, Thanks for adding the subject. Mistakenly sent it without one. -- rouilj John Rouillard =========================================================================== My employers don't acknowledge my existence much less my opinions. From ae at op5.se Thu Oct 13 05:54:38 2005 From: ae at op5.se (Andreas Ericsson) Date: Thu Oct 13 05:54:38 2005 Subject: [Nagiosplug-devel] update for nagios-plugins and debian In-Reply-To: References: <20051013104542.GA12152@seanius.net> Message-ID: <434E589C.6070104@op5.se> Ton Voon wrote: > > On 13 Oct 2005, at 11:45, sean finney wrote: > >> note that this is not intended to be an alternate development tree >> to nagios, but more like a tree of the "debian-refined" changes >> made to the plugins. also, it will include patches for bugfixes etc >> from cvs HEAD here in between releases, and also serve as another >> source for bugreports, which will result in fixes coming back this way. > > > Sean, > > Cool - good to see lots of work happening on the plugins. Bit concerned > about the huge list of bugs (!) > > My angle is that, obviously, I would like bugfixes to come back > upstream. Let me know if there is anything I can do to facilitate this. > > I'm also interested in how you are marking differences between trees. > For Altinity, there are some fixes that we need to apply, but anything > that is generally useful I apply to the main SF tree at the same time. > I store on our local CVS server the tar.gz distribution and then apply > patch files in our custom Makefile. This way I know all the changes > from our code to the released file. The idea is I can just replace the > released file with a newer version, run a make and during the patch > process it should tell me all the things that have already been fixed > (or that I may need to amend a patch for). > > I notice you are using an actual "exploded" CVS tree. Does your method > work well when syncing trees? > A move to git/cogito in preference of CVS would easily help resolve such issues, as merging between branches is embarrassingly simple. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 From ae at op5.se Thu Oct 13 05:57:38 2005 From: ae at op5.se (Andreas Ericsson) Date: Thu Oct 13 05:57:38 2005 Subject: [Nagiosplug-devel] spopenenv (Was: no subject) In-Reply-To: <200510131240.j9DCerjX022105@mx1.cs.umb.edu> References: <200510131240.j9DCerjX022105@mx1.cs.umb.edu> Message-ID: <434E596F.3090300@op5.se> John P. Rouillard wrote: > In message <02F3F455-47E6-453A-A6F3-B9DABFE654B2 at mac.com>, > Ton Voon writes: > >>On 12 Oct 2005, at 18:59, John P. Rouillard wrote: >> >>>I have been trying to use check_by_ssh with an ssh-agent to allow >>>encrypted keys to be kept on the system. >>> >>>While using spopen in the plugin is a great idea, it breaks using the >>>ssh-agent to manage keys since the required environment variable: >>>SSH_AUTH_SOCK isn't present in the child environment. >>> >>>I had patched this once (at another job, code unavailable) by >>>duplicating spopen to spopenenv and adding a second argument that was >>>a list of the environment strings (retrieved with getenv) that should >>>be added to the child environment. >>> >>>So does adding support to check_by_ssh to use an ssh-agent sound >>>reasonable? >> >>I think this sounds like a good idea. >> >>Is it possible to have the 2nd argument to spopen be the optional >>array of variables? That way we're not trying to maintain a spopen >>and an spopenenv. > > > You could use a varargs list I suppose. varargs are obsoleted in favor of stdarg, which is ANSI X3.159-1989 (C89) compliant. > Another way to do it might be > with a macro that maps: > > spopen(a) -> spopenenv (a, NULL) > Good idea. ;) > and then you just have spopenenv. But it's been a long time since I have > done C programming (almost 20 years sigh). > 27, if standards ratification dates are anything to go by. :) -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 From tonvoon at mac.com Thu Oct 13 06:43:04 2005 From: tonvoon at mac.com (Ton Voon) Date: Thu Oct 13 06:43:04 2005 Subject: [Nagiosplug-devel] update for nagios-plugins and debian In-Reply-To: <434E589C.6070104@op5.se> References: <20051013104542.GA12152@seanius.net> <434E589C.6070104@op5.se> Message-ID: <70F48E31-D4B2-42E8-813D-90D26A6668E9@mac.com> On 13 Oct 2005, at 13:52, Andreas Ericsson wrote: > A move to git/cogito in preference of CVS would easily help resolve > such issues, as merging between branches is embarrassingly simple. Is that a move at both ends or just at one side? Ton -------------- next part -------------- An HTML attachment was scrubbed... URL: From ae at op5.se Thu Oct 13 07:19:28 2005 From: ae at op5.se (Andreas Ericsson) Date: Thu Oct 13 07:19:28 2005 Subject: [Nagiosplug-devel] update for nagios-plugins and debian In-Reply-To: <70F48E31-D4B2-42E8-813D-90D26A6668E9@mac.com> References: <20051013104542.GA12152@seanius.net> <434E589C.6070104@op5.se> <70F48E31-D4B2-42E8-813D-90D26A6668E9@mac.com> Message-ID: <434E6CA3.2000100@op5.se> Ton Voon wrote: > > On 13 Oct 2005, at 13:52, Andreas Ericsson wrote: > >> A move to git/cogito in preference of CVS would easily help resolve >> such issues, as merging between branches is embarrassingly simple. > > > Is that a move at both ends or just at one side? > That's the whole point. git has excellent support for distributed repositories, branches and merges between branches so there would only be one repository where each individual organisation can add their own branch (or branches) and merge changes between them. Always assuming changesets doesn't conflict, ofcourse, but that shouldn't often be the case. The individual organisation branches will live on the organisation side only, whereas the 'master' head lives on sourceforge (as a web-repository or whatever). There can be several official branches as well. It might present problems for the various organisations if they have identical names, but that's their headache. Try it out; http://www.kernel.org/pub/scm/git It comes in RPM's now as well. I seriously recommend having a look at the gitk tool as well. It's the best I've seen so far, and git is only 6 months old. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 From seanius at seanius.net Thu Oct 13 09:48:43 2005 From: seanius at seanius.net (sean finney) Date: Thu Oct 13 09:48:43 2005 Subject: [Nagiosplug-devel] update for nagios-plugins and debian In-Reply-To: References: <20051013104542.GA12152@seanius.net> Message-ID: <20051013164644.GA15549@seanius.net> hi, On Thu, Oct 13, 2005 at 12:22:29PM +0100, Ton Voon wrote: > My angle is that, obviously, I would like bugfixes to come back > upstream. Let me know if there is anything I can do to facilitate this. seeing as i'm now in charge of the nagios-plugins in debian, and am also on the team here, i think it will be pretty easy. i probably won't always do them at the same time, but it should be fairly easy to track what bugfixes i haven't yet merged (as you'll see below) in debian. > I'm also interested in how you are marking differences between trees. debian has a development tool called dpatch, which is what i use here and pretty much everywhere else. you basically keep the "upstream" source pristine, and have a directory of ordered patches which are applied before building the package. thus, when 1.4.3 comes out with the fixes flown in from debian, all i have to do is remove the patches from the directory (and if i forget to the patches will fail to apply and i'll pretty quickly figure out why). in fact, for most projects, i don't keep the upstream source in an scm at all, and only keep the ./debian directory in subversion. svn-buildpackage (a debian tool) knows how to unpack original upstream tarballs, add ./debian, and then the dpatch+the standard build process takes care of everything else. this guarantees that some combination of configure/make/make clean/editing doesn't corrupt my "original" source, and also keeps the footprint of stuff being tracked to a bare minimum. unfortunately cvs-buildpackage (another debian tool) isn't that smart, and alioth doesn't yet support svn, so i'm stuck keeping all of nagios-plugins in cvs on alioth. the only time i will modify things outside of ./debian is when i'm introducing the next upstream version of the plugins. works pretty well as long as i don't mess up the cvs tags and/or accidentally commit something in the source outside fo ./debian. > I notice you are using an actual "exploded" CVS tree. Does your > method work well when syncing trees? yeah. the only ./debian in svn really works the best but... but if that's not a choice, this works okay too. basically when a new upstream version comes out, i merge the trees (there's a tool for that too), do a bit of manual inspection to add new files and remove deleted files, and then tag it as the next upstream version. cvs-buildpackage takes care of the rest for me. sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From noreply at sourceforge.net Thu Oct 13 10:55:36 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 13 10:55:36 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1326050 ] check_disk incorrect output when checking non-existant disk. Message-ID: Bugs item #1326050, was opened at 2005-10-13 13:54 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1326050&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: Release (specify) Status: Open Resolution: None Priority: 5 Submitted By: John Rouillard (rouilj) Assigned to: Nobody/Anonymous (nobody) Summary: check_disk incorrect output when checking non-existant disk. Initial Comment: Fedora core 3 system - plugin release 1.4.2. When running check_disk on a non-existent disk the output is not helpful: /usr/lib/nagios/plugins/check_disk -c 20 -w 30 -p /boot -p /dev/shm -p /home -p /foo where /foo doesn't exist produces (split for readability): DISK CRITICAL - free space: /boot 168 MB (88%); /dev/shm 1014 MB (100%); /home 6590 MB (67%); | /boot=22MB;159;169;0;189 /dev/shm=0MB;983;993;0;1013 /home=3268MB;9828;9838;0;9858 [/foo not found] The [/foo not found] error occurs in the performance output part of the plugin and not the user output. BTW this command produces an ok status if run without the /foo. This should be changed so that the error is put (first) in the regular output. -- rouilj ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1326050&group_id=29880 From benoit.mortier at opensides.be Thu Oct 13 11:42:06 2005 From: benoit.mortier at opensides.be (Benoit Mortier) Date: Thu Oct 13 11:42:06 2005 Subject: [Nagiosplug-devel] update for nagios-plugins and debian In-Reply-To: References: <20051013104542.GA12152@seanius.net> Message-ID: <200510132038.16536.benoit.mortier@opensides.be> Le Jeudi 13 Octobre 2005 13:22, Ton Voon a ?crit?: > On 13 Oct 2005, at 11:45, sean finney wrote: > > note that this is not intended to be an alternate development tree > > to nagios, but more like a tree of the "debian-refined" changes > > made to the plugins. also, it will include patches for bugfixes etc > > from cvs HEAD here in between releases, and also serve as another > > source for bugreports, which will result in fixes coming back this > > way. > > Sean, > > Cool - good to see lots of work happening on the plugins. Bit > concerned about the huge list of bugs (!) > > My angle is that, obviously, I would like bugfixes to come back > upstream. Let me know if there is anything I can do to facilitate this. Hi, i am i also an the debian nagios team ;-) i could help backport the bugfixes and changes to the nagios core cvs. I still have the idea to integrate the change from andrea to the nagios officials plugins, just missing some time ;-( Cheers -- Benoit Mortier CEO www.opensides.be From noreply at sourceforge.net Thu Oct 13 12:25:48 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 13 12:25:48 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Feature Requests-1326060 ] check_disk default setting to scan unspecified partition Message-ID: Feature Requests item #1326060, was opened at 2005-10-13 14:04 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=1326060&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Interface Improvements (example) Group: Next Release (example) Status: Open Priority: 5 Submitted By: John Rouillard (rouilj) Assigned to: Nobody/Anonymous (nobody) Summary: check_disk default setting to scan unspecified partition Initial Comment: currently check disk can apply thresholds on multiple disks. If no disks are specified, all of the disks are checked automatically. Multiple disks can be specified with different thresholds, but then unspecified disks aren't checked. What I would like is for the fag "-p" to take an argument of '*' (or some other character @, % etc) that means apply the current thresholds to all disks that have not yet been specified. Disks excluded using -x or -X ould not be included in the '*' scan. This would of course go at the end of the command string. Thi feature could also be used to warn the user if any disks are not being monitored for those sites that specify all their disks. By manually speciying al the disks using -p or -x and setting "-c 100%" -c 100000000000 -p *' will result in any unspecified disk causing a critical alert if it isn't 100% free and have how ever many oodles of bytes I have specified above free. -- rouilj ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=1326060&group_id=29880 From noreply at sourceforge.net Sat Oct 15 22:38:17 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 15 22:38:17 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1327793 ] Added snmpwalk support to check_snmp Message-ID: Patches item #1327793, was opened at 2005-10-16 00:37 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1327793&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None Status: Open Resolution: None Priority: 5 Submitted By: Dave Frailey (dfrailey) Assigned to: Nobody/Anonymous (nobody) Summary: Added snmpwalk support to check_snmp Initial Comment: * Using snmpwalk (instead of snmpget or snmpgetnext) allows a dynamic number of like OID's to be checked from a single parent OID (and thus a single nagios check_command). For example, a stackable Cisco 3750 switch will expose a sub OID containing the power supply status of each swtich in the stack under the 1.3.6.1.4.1.9.9.13.1.5.1.4 OID: Without snmpwalk you'd have to build a separate check_command (using check_snmp) to query each OID individually for every switch in the stack. With the snmpwalk patch you simply query the parent OID with the new --walk switch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1327793&group_id=29880 From seanius at seanius.net Mon Oct 17 01:37:36 2005 From: seanius at seanius.net (sean finney) Date: Mon Oct 17 01:37:36 2005 Subject: [Nagiosplug-devel] looking more into this bug Message-ID: <20051017083603.GA31642@seanius.net> hi tatsuki, i've recently taken over maintaining the nagios-plugins package in debian, and would like to work with you to resolve the bug you reported about check_http not working with some remote ssl implementations. in your previous mail, you mention that rmeoving the line SSL_set_cipher_list(ssl, "ALL"); seems to fix your problem. while i'm not an expert, i believe "ALL" is a valid cipher name in openssl that translates to all available ciphers on the client, and i'm a little nervous to yank out any code i don't fully understand. so, i guess what we need to know is why things are failing when contacting the remote host, and what this function does to play a part in it. perhaps this is some openssl "extension" that other implementations don't understand? i will cc this email to the nagios-plugins development group in the hopes that perhaps someone there can shed some light on the manner. sean -- -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From gvs at yandex-team.ru Mon Oct 17 04:49:58 2005 From: gvs at yandex-team.ru (Seva Gluschenko) Date: Mon Oct 17 04:49:58 2005 Subject: [Nagiosplug-devel] a couple of nagios plugins patches and check_rrd plugin Message-ID: <435371A5.8060903@yandex-team.ru> Here is collection of patches to Nagios plugins we're using in production environment (they're enough self-documented, I hope) and new check_rrd plugin (Perl script) which behaves close to check_mrtg but looks for information in RRD databases. Hope it helps. Patches were made against 1.4.2 -- SY, Seva Gluschenko, just stranger on The Road. Yandex LLC Maintenance Team | GVS-RIPE -------------- next part -------------- A non-text attachment was scrubbed... Name: plugins-patches.tar.gz Type: application/x-gzip Size: 5338 bytes Desc: not available URL: -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: check_rrd URL: From seanius at seanius.net Mon Oct 17 12:35:39 2005 From: seanius at seanius.net (sean finney) Date: Mon Oct 17 12:35:39 2005 Subject: [Nagiosplug-devel] nagiosplug licensing is self-conflicting Message-ID: <20051017193258.GA6004@seanius.net> hi folks, something that recently came to my attention is that there are potential licensing conflicts within the nagios-plugins project. as nagios-plugins are a GPL'd project, that means they can not be compiled against 3rd party API's that do not meet the criteria of the GPL. the most noticable issue is regarding openssl, though there are perhaps others into which i would have to look more closely. i'll start with the former, because i have some experience dealing with it in other projects. === part 1 - openssl === wrt openssl, it is unfortunately not compatible with the "stock" gpl on many distributions (including debian), because it is not considered "part of the operating system" and thus is a "derived work". The solution in this case is fairly straightforward. any of the following would be sufficient: - change the license to something that doesn't conflict (lgpl, bsd-style, etc) - modify the code to be able to use other ssl implementations (like gnutls), and leave it to the distributions that have the problem to choose the non-conflicting option. - put an addendum to the current copyright such that it is "GPL, but exception is made for linking against OpenSSL". this is what the folks at mysql have done, btw. peronally, i prefer the second option, but it's also the most work. for more information on this particular issue, here's some helpful information: a crash-course into the problem: http://www.gnome.org/~markmc/openssl-and-the-gpl.html openssl project's recommendations: http://www.openssl.org/support/faq.html#LEGAL2 === part 2 - other potential issues === in addition to the openssl issue described above, i foresee potential problems with other plugins which make use of api's or command-line programs which are also not GPL-compatible. the only other two that immediately come to mind are lmstat and qmail (neither of which are GPL compatible but are used), but i haven't looked closely into ./contrib, where other problems are likely to exist. what to do about these is probably a touchier subject, and i'd appreciate any ideas that you folks might have. sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From ae at op5.se Mon Oct 17 14:36:43 2005 From: ae at op5.se (Andreas Ericsson) Date: Mon Oct 17 14:36:43 2005 Subject: [Nagiosplug-devel] nagiosplug licensing is self-conflicting In-Reply-To: <20051017193258.GA6004@seanius.net> References: <20051017193258.GA6004@seanius.net> Message-ID: <43541861.6040802@op5.se> sean finney wrote: > hi folks, > > something that recently came to my attention is that there are potential > licensing conflicts within the nagios-plugins project. > > as nagios-plugins are a GPL'd project, that means they can not be compiled > against 3rd party API's that do not meet the criteria of the GPL. the > most noticable issue is regarding openssl, though there are perhaps others > into which i would have to look more closely. i'll start with the > former, because i have some experience dealing with it in other > projects. > > === part 1 - openssl === > > wrt openssl, it is unfortunately not compatible with the "stock" gpl > on many distributions (including debian), because it is not considered > "part of the operating system" and thus is a "derived work". The solution > in this case is fairly straightforward. any of the following would > be sufficient: > > - change the license to something that doesn't conflict (lgpl, bsd-style, etc) > - modify the code to be able to use other ssl implementations (like > gnutls), and leave it to the distributions that have the problem to > choose the non-conflicting option. > - put an addendum to the current copyright such that it is "GPL, > but exception is made for linking against OpenSSL". this is what > the folks at mysql have done, btw. > The last option is what the openssl team recommends. It also says: "Some GPL software copyright holders claim that you infringe on their rights if you use OpenSSL with their software on operating systems that don't normally include OpenSSL." The problem is thus not with openssl, but with the copyright holders of other programs that may or may not link to openssl. If all the developers and contributors are OK with using OpenSSL there is no problem. IMO, this is really splitting hairs. OpenSSL is as available as any GPL'd software. The reason for it not being GPL'd is that it isn't hard to write a TSL library so if corporations were unable to use openssl they would simply roll their own and withhold their clever solutions from the open community (which is exactly why glibc is LGPL rather than GPL, btw). > peronally, i prefer the second option, but it's also the most work. for > more information on this particular issue, here's some helpful > information: > How incompatible are the two interfaces? Does everything have to be changed? Perhaps we could use an abstraction layer on top the plugins to move the problems to somewhere where users won't tinker with it? > a crash-course into the problem: > > http://www.gnome.org/~markmc/openssl-and-the-gpl.html > > openssl project's recommendations: > > http://www.openssl.org/support/faq.html#LEGAL2 > > > === part 2 - other potential issues === > > in addition to the openssl issue described above, i foresee potential > problems with other plugins which make use of api's or command-line > programs which are also not GPL-compatible. Using command line tools that aren't GPL'd doesn't violate the GPL, just as gcc, bison, yacc and flex can be used to compile and create proprietary code and proprietary applications can be written in PHP/Perl/Python/whatever. > the only other two that > immediately come to mind are lmstat and qmail (neither of which are GPL > compatible but are used), but i haven't looked closely into ./contrib, > where other problems are likely to exist. > > what to do about these is probably a touchier subject, and i'd > appreciate any ideas that you folks might have. > Put a doc in the distribution highlighting the problems and make it available to everyone who are likely to contribute code (a HACKING file or some such). Make it plain that when they *do* contribute code it will be under the GPL with this and that exception (for openssl, for instance). lmstat and qmail coders aren't going to complain. If plugin developers are having issues with this then they will simply stop submitting code, most likely after having had a heated discussion on this list. It won't be done quietly anyways. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 From ton.voon at altinity.com Tue Oct 18 02:20:29 2005 From: ton.voon at altinity.com (Ton Voon) Date: Tue Oct 18 02:20:29 2005 Subject: [Nagiosplug-devel] nagiosplug licensing is self-conflicting In-Reply-To: <43541861.6040802@op5.se> References: <20051017193258.GA6004@seanius.net> <43541861.6040802@op5.se> Message-ID: On 17 Oct 2005, at 22:32, Andreas Ericsson wrote: > sean finney wrote: > >> hi folks, >> something that recently came to my attention is that there are >> potential >> licensing conflicts within the nagios-plugins project. as nagios- >> plugins are a GPL'd project, that means they can not be compiled >> against 3rd party API's that do not meet the criteria of the GPL. >> the >> most noticable issue is regarding openssl, though there are >> perhaps others >> into which i would have to look more closely. i'll start with the >> former, because i have some experience dealing with it in other >> projects. >> === part 1 - openssl === >> wrt openssl, it is unfortunately not compatible with the "stock" gpl >> on many distributions (including debian), because it is not >> considered >> "part of the operating system" and thus is a "derived work". The >> solution >> in this case is fairly straightforward. any of the following would >> be sufficient: - change the license to something that doesn't >> conflict (lgpl, bsd-style, etc) >> - modify the code to be able to use other ssl implementations (like >> gnutls), and leave it to the distributions that have the problem to >> choose the non-conflicting option. >> - put an addendum to the current copyright such that it is "GPL, >> but exception is made for linking against OpenSSL". this is what >> the folks at mysql have done, btw. >> > > The last option is what the openssl team recommends. It also says: > "Some GPL software copyright holders claim that you infringe on > their rights if you use OpenSSL with their software on operating > systems that don't normally include OpenSSL." I would say the last option too because the OpenSSL team say it is okay. I think that means we need to add an exception notice in check_http and check_ldaps (amongst others) within the help text. We should add something at a top level file as well - I will update the README with references to our licence and update some contact information. There's a reference to GPL in the nagios-plugins.spec file, which looks like an RPM file. Can the line: License: GPL be changed to: License: GPL, with exception for OpenSSL (see README) without breaking anything? > IMO, this is really splitting hairs. OpenSSL is as available as any > GPL'd software. The reason for it not being GPL'd is that it isn't > hard to write a TSL library so if corporations were unable to use > openssl they would simply roll their own and withhold their clever > solutions from the open community (which is exactly why glibc is > LGPL rather than GPL, btw). > IMO, it is about respecting the various teams that we are taking advantage of. >> peronally, i prefer the second option, but it's also the most >> work. for >> more information on this particular issue, here's some helpful >> information: >> > > How incompatible are the two interfaces? Does everything have to be > changed? Perhaps we could use an abstraction layer on top the > plugins to move the problems to somewhere where users won't tinker > with it? I'm okay with the idea of using a different SSL library. An abstraction layer is a good idea, if there are major differences. >> a crash-course into the problem: >> http://www.gnome.org/~markmc/openssl-and-the-gpl.html >> openssl project's recommendations: >> http://www.openssl.org/support/faq.html#LEGAL2 >> === part 2 - other potential issues === >> in addition to the openssl issue described above, i foresee potential >> problems with other plugins which make use of api's or command-line >> programs which are also not GPL-compatible. >> > > > Using command line tools that aren't GPL'd doesn't violate the GPL, > just as gcc, bison, yacc and flex can be used to compile and create > proprietary code and proprietary applications can be written in PHP/ > Perl/Python/whatever. I don't think the GPL covers command line communication. There's this section in the GPL FAQ (http://www.gnu.org/licenses/gpl-faq.html): "By contrast, pipes, sockets and command-line arguments are communication mechanisms normally used between two separate programs. So when they are used for communication, the modules normally are separate programs. But if the semantics of the communication are intimate enough, exchanging complex internal data structures, that too could be a basis to consider the two parts as combined into a larger program." So I think command line invocation of external non-GPL programs are fine. >> the only other two that >> immediately come to mind are lmstat and qmail (neither of which >> are GPL >> compatible but are used), but i haven't looked closely into ./ >> contrib, >> where other problems are likely to exist. >> what to do about these is probably a touchier subject, and i'd >> appreciate any ideas that you folks might have. >> > > Put a doc in the distribution highlighting the problems and make it > available to everyone who are likely to contribute code (a HACKING > file or some such). Make it plain that when they *do* contribute > code it will be under the GPL with this and that exception (for > openssl, for instance). I'll add a text to the patches section of SF to say that all contributions are accepted only if they are GPL. Something I've been meaning to do for a long time. Ton http://www.altinity.com T: +44 (0)870 787 9243 F: +44 (0)845 280 1725 Skype: tonvoon From seanius at seanius.net Tue Oct 18 02:27:51 2005 From: seanius at seanius.net (sean finney) Date: Tue Oct 18 02:27:51 2005 Subject: [Nagiosplug-devel] nagiosplug licensing is self-conflicting In-Reply-To: <43541861.6040802@op5.se> <200510171953.j9HJr5dR004402@mx1.cs.umb.edu> References: <20051017193258.GA6004@seanius.net> <43541861.6040802@op5.se> <20051017193258.GA6004@seanius.net> <200510171953.j9HJr5dR004402@mx1.cs.umb.edu> Message-ID: <20051018092534.GA13489@seanius.net> hi, On Mon, Oct 17, 2005 at 03:53:03PM -0400, John P. Rouillard wrote: > As I understand it, the programs can not be compiled and then > distributed. So the binary RPM's/other distributions are a problem, > but not the source RPM's. Do you agree? i'll have to double check my notes, but i think you're right. there could potentially be a problem because it won't compile against any api other than openssl's, but i'm not sure about this. > The GPL programs are perl scripts calling the non-free components via > fork/exec in this case correct? If so then it's not a problem > AFAIK. See: > > http://www.gnu.org/licenses/gpl-faq.html#TOCGPLPluginsInNF > > http://www.gnu.org/licenses/gpl-faq.html#TOCMereAggregation okay, then "mere aggregation" addresses that. thanks for pointing that out. previously, everything i had seen dealt with the converse; that is non-GPL programs calling GPL'd ones. On Mon, Oct 17, 2005 at 11:32:17PM +0200, Andreas Ericsson wrote: > >- put an addendum to the current copyright such that it is "GPL, > > but exception is made for linking against OpenSSL". this is what > > the folks at mysql have done, btw. > > The last option is what the openssl team recommends. It also says: > "Some GPL software copyright holders claim that you infringe on their > rights if you use OpenSSL with their software on operating systems that > don't normally include OpenSSL." > > The problem is thus not with openssl, but with the copyright holders of > other programs that may or may not link to openssl. If all the > developers and contributors are OK with using OpenSSL there is no problem. yes. it might be more straightforward in this case, but i think the answer would then be to clarify the position as such. however, it can get really, really tricky when you start dealing with shared libraries and api's. for example, say nagiosplug decided to release a shared library (GPL'd of course), which was then used by other 3rd party software projects. if any of these other 3rd party software projects were also GPL'd, then they too would be inadvertently made in violation of their own license because they would then be linking against openssl indirectly through us. it may sound farfetched for our particular situation, but this happens a lot. this was a major pita with mysql, because you have pam/nss modules that link against mysql, which means effectively the entire OS could link against it :( > IMO, this is really splitting hairs. OpenSSL is as available as any > GPL'd software. The reason for it not being GPL'd is that it isn't hard i think it's a bit more than splitting hairs. it's not a major issue because there are trivial ways to remedy it, but it's still a potential license violation. > How incompatible are the two interfaces? Does everything have to be > changed? Perhaps we could use an abstraction layer on top the plugins to > move the problems to somewhere where users won't tinker with it? i believe the API's are similar, but not compatible (or at least not completely so), though i haven't verified this for myself. since i've heard this come up a few times within debian-devel, i can probably call upon some volunteers from there to send me an initial patch, or at least some notes about differences. but in any case, yes i think it should be abstracted away, and not just because of this. having recently dealt with some ssl-related bugs in one plugin and still having a small number more, i'm beginning to think this would be a good idea. sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From ae at op5.se Tue Oct 18 02:50:38 2005 From: ae at op5.se (Andreas Ericsson) Date: Tue Oct 18 02:50:38 2005 Subject: [Nagiosplug-devel] nagiosplug licensing is self-conflicting In-Reply-To: References: <20051017193258.GA6004@seanius.net> <43541861.6040802@op5.se> Message-ID: <4354C51D.4080706@op5.se> Ton Voon wrote: > > On 17 Oct 2005, at 22:32, Andreas Ericsson wrote: > >> sean finney wrote: >> >>> hi folks, >>> something that recently came to my attention is that there are >>> potential >>> licensing conflicts within the nagios-plugins project. as nagios- >>> plugins are a GPL'd project, that means they can not be compiled >>> against 3rd party API's that do not meet the criteria of the GPL. the >>> most noticable issue is regarding openssl, though there are perhaps >>> others >>> into which i would have to look more closely. i'll start with the >>> former, because i have some experience dealing with it in other >>> projects. >>> === part 1 - openssl === >>> wrt openssl, it is unfortunately not compatible with the "stock" gpl >>> on many distributions (including debian), because it is not considered >>> "part of the operating system" and thus is a "derived work". The >>> solution >>> in this case is fairly straightforward. any of the following would >>> be sufficient: - change the license to something that doesn't >>> conflict (lgpl, bsd-style, etc) >>> - modify the code to be able to use other ssl implementations (like >>> gnutls), and leave it to the distributions that have the problem to >>> choose the non-conflicting option. >>> - put an addendum to the current copyright such that it is "GPL, >>> but exception is made for linking against OpenSSL". this is what >>> the folks at mysql have done, btw. >>> >> >> The last option is what the openssl team recommends. It also says: >> "Some GPL software copyright holders claim that you infringe on their >> rights if you use OpenSSL with their software on operating systems >> that don't normally include OpenSSL." > > > I would say the last option too because the OpenSSL team say it is okay. > > I think that means we need to add an exception notice in check_http and > check_ldaps (amongst others) within the help text. We should add > something at a top level file as well - I will update the README with > references to our licence and update some contact information. > > There's a reference to GPL in the nagios-plugins.spec file, which looks > like an RPM file. Can the line: > > License: GPL > > be changed to: > > License: GPL, with exception for OpenSSL (see README) > > without breaking anything? > Just write "License: See COPYING" or some such. That way you won't have to fiddle all the plugins if it ever changes in the future. >> IMO, this is really splitting hairs. OpenSSL is as available as any >> GPL'd software. The reason for it not being GPL'd is that it isn't >> hard to write a TSL library so if corporations were unable to use >> openssl they would simply roll their own and withhold their clever >> solutions from the open community (which is exactly why glibc is LGPL >> rather than GPL, btw). >> > > IMO, it is about respecting the various teams that we are taking > advantage of. > But the limitation works the other way around. OpenSSL haven't got claims on the plugin developers. The plugin developers have potential claims on the plugin users that they must include the SSL copyright exception and notices whenever re-distributing the code. Since the plugin developers can simply refrain from pressing charges it's not much of an issue (although if it can easily be fixed it should be). > >>> peronally, i prefer the second option, but it's also the most work. >>> for >>> more information on this particular issue, here's some helpful >>> information: >>> >> >> How incompatible are the two interfaces? Does everything have to be >> changed? Perhaps we could use an abstraction layer on top the plugins >> to move the problems to somewhere where users won't tinker with it? > > > I'm okay with the idea of using a different SSL library. An abstraction > layer is a good idea, if there are major differences. > >>> a crash-course into the problem: >>> http://www.gnome.org/~markmc/openssl-and-the-gpl.html >>> openssl project's recommendations: >>> http://www.openssl.org/support/faq.html#LEGAL2 >>> === part 2 - other potential issues === >>> in addition to the openssl issue described above, i foresee potential >>> problems with other plugins which make use of api's or command-line >>> programs which are also not GPL-compatible. >>> >> >> >> Using command line tools that aren't GPL'd doesn't violate the GPL, >> just as gcc, bison, yacc and flex can be used to compile and create >> proprietary code and proprietary applications can be written in PHP/ >> Perl/Python/whatever. > > > I don't think the GPL covers command line communication. There's this > section in the GPL FAQ (http://www.gnu.org/licenses/gpl-faq.html): > > "By contrast, pipes, sockets and command-line arguments are > communication mechanisms normally used between two separate programs. > So when they are used for communication, the modules normally are > separate programs. But if the semantics of the communication are > intimate enough, exchanging complex internal data structures, that too > could be a basis to consider the two parts as combined into a larger > program." > > So I think command line invocation of external non-GPL programs are fine. > >>> the only other two that >>> immediately come to mind are lmstat and qmail (neither of which are GPL >>> compatible but are used), but i haven't looked closely into ./ contrib, >>> where other problems are likely to exist. >>> what to do about these is probably a touchier subject, and i'd >>> appreciate any ideas that you folks might have. >>> >> >> Put a doc in the distribution highlighting the problems and make it >> available to everyone who are likely to contribute code (a HACKING >> file or some such). Make it plain that when they *do* contribute code >> it will be under the GPL with this and that exception (for openssl, >> for instance). > > > I'll add a text to the patches section of SF to say that all > contributions are accepted only if they are GPL. Something I've been > meaning to do for a long time. > > Ton > > http://www.altinity.com > T: +44 (0)870 787 9243 > F: +44 (0)845 280 1725 > Skype: tonvoon > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Power Architecture Resource Center: Free content, downloads, discussions, > and more. http://solutions.newsforge.com/ibmarch.tmpl > _______________________________________________________ > Nagios Plugin Development Mailing List > Nagiosplug-devel at lists.sourceforge.net > Unsubscribe at > https://lists.sourceforge.net/lists/listinfo/nagiosplug-devel > ::: Please include plugins version (-v) and OS when reporting any issue. > ::: Messages without supporting info will risk being sent to /dev/null > -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 From seanius at seanius.net Tue Oct 18 15:49:10 2005 From: seanius at seanius.net (sean finney) Date: Tue Oct 18 15:49:10 2005 Subject: [Nagiosplug-devel] trying out gnutls Message-ID: <20051018224734.GA21315@seanius.net> so apparently, the gnutls folks while using their own api are kind enough to *also* provide a compatibility api with openssl, which for the most part seems to work: http://www.gnu.org/software/gnutls/manual/html_node/Compatibility-with-the-OpenSSL-library.html however, i have encountered a couple problems. - the configure.in code for openssl detection/support is a total mess - the above compatability api doesn't cover x509 cert checking i've managed to work around the first issue with a bit of persistance, and the second issue i've temporarily sidelined with judicious use of #ifdef's (so cert checking is disabled for the time being in gnutls-compiled versions). in the interest of sanity for all, i haven't changed any default settings. if you want gnutls support, you need to pass to ./configure "--without-openssl --with-gnutls" (and have gnutls development libraries installed, of course). unless of course you don't have openssl installed, in which case it will fall through to using gnutls if it's there. currently, the only plugin i've hacked on is check_tcp, but there was very little work to do there, most of the hard work was wrestling with ./configure.in. anyway, in the next day or two i'll try and make support more complete, as well as clean up the code in configure.in if that's okay. sean ps - my last commit to check_disk seems to have broken something... i'll see about fixing that too :) -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From seanius at seanius.net Wed Oct 19 06:11:45 2005 From: seanius at seanius.net (sean finney) Date: Wed Oct 19 06:11:45 2005 Subject: [Nagiosplug-devel] trying out gnutls In-Reply-To: <20051018224734.GA21315@seanius.net> References: <20051018224734.GA21315@seanius.net> Message-ID: <20051019130933.GA29087@seanius.net> and anoter checkin today. the other two plugins (smtp/http) also now compile against gnutls too. i've also moved the bulk of the ssl-related code from check_tcp into netutils.{c,h}. the other two plugins have basically the same functions cut and pasted into them, so we'll be able to get rid of some duplicate code, and make things generally cleaner too. i've tested compilation using the following configure option combinations: --with-openssl --without-openssl --with-gnutls --without-openssl --without-gnutls and things seem to compile/run fine. sean > ps - my last commit to check_disk seems to have broken something... > i'll see about fixing that too :) turns out it was just fine, ijust had a version of automake that the ./tools/setup script doesn't like. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From noreply at sourceforge.net Wed Oct 19 07:41:53 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 19 07:41:53 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1331909 ] pop3(s) email-matching plugin Message-ID: Patches item #1331909, was opened at 2005-10-19 09:38 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1331909&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: kkvenkit (kkvenkit) Assigned to: Nobody/Anonymous (nobody) Summary: pop3(s) email-matching plugin Initial Comment: A Perl plugin to match email in a pop3(s) account. This was developed to monitor more than a dozen remote cron jobs that email results to a common pop3s account. Rather than manually verify an OK response for each check, this plugin is used to check the pop3s account once a day for an email that matches a specific subject. The contents of the email are then searched for specified ok-, warning-, and critical-resulting content. The subject, ok-, warning-, and critical-resulting patterns are Perl regular expressions. The host, username, password, pop3 or pop3s values are arguments to the plugin allowing the plugin to be re-used as many times as required. In addition to the standard ok/warning/critical result message, the line in the email address following the match is displayed. This allows contextual detail to be reported within the nagios interface. All the standard arguments are supported. Suggestions to extend this plugin are encouraged. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1331909&group_id=29880 From noreply at sourceforge.net Wed Oct 19 08:01:01 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 19 08:01:01 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1331909 ] pop3(s) email-matching plugin Message-ID: Patches item #1331909, was opened at 2005-10-19 09:38 Message generated for change (Comment added) made by kkvenkit You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1331909&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: kkvenkit (kkvenkit) Assigned to: Nobody/Anonymous (nobody) Summary: pop3(s) email-matching plugin Initial Comment: A Perl plugin to match email in a pop3(s) account. This was developed to monitor more than a dozen remote cron jobs that email results to a common pop3s account. Rather than manually verify an OK response for each check, this plugin is used to check the pop3s account once a day for an email that matches a specific subject. The contents of the email are then searched for specified ok-, warning-, and critical-resulting content. The subject, ok-, warning-, and critical-resulting patterns are Perl regular expressions. The host, username, password, pop3 or pop3s values are arguments to the plugin allowing the plugin to be re-used as many times as required. In addition to the standard ok/warning/critical result message, the line in the email address following the match is displayed. This allows contextual detail to be reported within the nagios interface. All the standard arguments are supported. Suggestions to extend this plugin are encouraged. ---------------------------------------------------------------------- >Comment By: kkvenkit (kkvenkit) Date: 2005-10-19 09:59 Message: Logged In: YES user_id=1034657 Just realized I submitted this to the wrong tracker. Please ignore. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1331909&group_id=29880 From kkvenkit at gmail.com Wed Oct 19 08:07:08 2005 From: kkvenkit at gmail.com (Kevin Venkiteswaran) Date: Wed Oct 19 08:07:08 2005 Subject: [Nagiosplug-devel] new plugin: check_pop3_message.pl Message-ID: <1129734363.9465.32.camel@localhost.localdomain> I've added a new plugin to the new-plugin tracker on sourceforge. A brief description of the plugin: A Perl plugin to match email in a pop3(s) account. This was developed to monitor more than a dozen remote cron jobs that email results to a common pop3s account. Rather than manually verify an OK response for each job, this plugin is used to check the pop3s account once a day for an email that matches a specific subject. The contents of the email are then searched for specified ok-, warning-, and critical-resulting content. This setup removes the manual checking of results; nagios now notifies me if it does not find positive results for all cron jobs. The subject, ok-, warning-, and critical-resulting patterns are Perl regular expressions. The host, username, password, pop3 or pop3s values are arguments to the plugin allowing the plugin to be re-used as many times as required. In addition to the standard ok/warning/critical result message, the line in the email address following the match is displayed. This allows contextual detail to be reported within the nagios interface. All the standard arguments are supported. Suggestions to extend this plugin are encouraged. From noreply at sourceforge.net Wed Oct 19 08:07:11 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 19 08:07:11 2005 Subject: [Nagiosplug-devel] [ nagiosplug-New Plugins-1331956 ] pop3(s) email-matching plugin Message-ID: New Plugins item #1331956, was opened at 2005-10-19 10:04 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1331956&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Perl plugin Group: None Status: Open Resolution: None Priority: 5 Submitted By: kkvenkit (kkvenkit) Assigned to: Nobody/Anonymous (nobody) Summary: pop3(s) email-matching plugin Initial Comment: A Perl plugin to match email in a pop3(s) account. This was developed to monitor more than a dozen remote cron jobs that email results to a common pop3s account. Rather than manually verify an OK response for each job, this plugin is used to check the pop3s account once a day for an email that matches a specific subject. The contents of the email are then searched for specified ok-, warning-, and critical-resulting content. This setup removes the manual checking of results; nagios now notifies me if it does not find positive results for all cron jobs. The subject, ok-, warning-, and critical-resulting patterns are Perl regular expressions. The host, username, password, pop3 or pop3s values are arguments to the plugin allowing the plugin to be re-used as many times as required. In addition to the standard ok/warning/critical result message, the line in the email address following the match is displayed. This allows contextual detail to be reported within the nagios interface. All the standard arguments are supported. Suggestions to extend this plugin are encouraged. A subsest of the plugin's help follows: Usage: check_pop3_message.pl -H -U -P -s -o [ -S ] [ -p ] [ -w ] [ -c ] [ -n ] -H, --hostname=HOST Name or IP address of pop3(s) host -U --username=USERNAME Username for pop3(s) account -P --password=PASSWORD Password for pop3(s) account -S --ssl Use SSL (aka pop3s) -p --port=PORT Port of pop3(s) server (default: 110 for pop3, 995 for pop3s) -s --subject=PATTERN Pattern to match in email's subject -o --ok=PATTERN Pattern to match in email's body indicating OK status -w --warning=PATTERN Pattern to match in email's body indicating WARNING status -c --critical==PATERN Pattern to match in email's body indicating CRITICAL status -n --nodelete Do not delete matched email (if it exists). -v --verbose Output verbose output ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1331956&group_id=29880 From noreply at sourceforge.net Thu Oct 20 10:30:03 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 20 10:30:03 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1283131 ] check_load gives incorrect data on AIX Message-ID: Bugs item #1283131, was opened at 2005-09-06 11:58 Message generated for change (Comment added) made by martinrichard You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1283131&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Submitted By: Andrew Elwell (elwell2000) Assigned to: Nobody/Anonymous (nobody) Summary: check_load gives incorrect data on AIX Initial Comment: compare output from check_load to that of "uptime" - they do not match and I'm seeing stupidly high (eg 30000) loads from the nagios plugin intermittently /usr/local/nagios/libexec/check_load -w 15,10,5 -c 30,25,20 ; uptime OK - load average: 0.01, 0.01, 0.24|load1=0.013;15.000;30.000;0; load5=0.012;10.000;25.000;0; load15=0.235;5.000;20.000;0; 04:48PM up 1 day, 5:55, 31 users, load average: 1.09, 1.07, 1.61 ---------------------------------------------------------------------- Comment By: Martin Richard (martinrichard) Date: 2005-10-20 13:00 Message: Logged In: YES user_id=1226367 Same symptoms on 2 different AIX 5 here.. # ./check_load -w 3,2,1 -c 6,5,4; uptime OK - load average: 0.13, 0.01, 0.01|load1=0.135;3.000;6.000;0; load5=0.007;2.000;5.000;0; load15=0.012;1.000;4.000;0; 12:59PM up 21 days, 15:44, 2 users, load average: 1.51, 0.98, 1.06 # Would it matter in any way that the machine has 2 CPUs ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1283131&group_id=29880 From noreply at sourceforge.net Thu Oct 20 11:11:40 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 20 11:11:40 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1283131 ] check_load gives incorrect data on AIX Message-ID: Bugs item #1283131, was opened at 2005-09-06 11:58 Message generated for change (Comment added) made by martinrichard You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1283131&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Submitted By: Andrew Elwell (elwell2000) Assigned to: Nobody/Anonymous (nobody) Summary: check_load gives incorrect data on AIX Initial Comment: compare output from check_load to that of "uptime" - they do not match and I'm seeing stupidly high (eg 30000) loads from the nagios plugin intermittently /usr/local/nagios/libexec/check_load -w 15,10,5 -c 30,25,20 ; uptime OK - load average: 0.01, 0.01, 0.24|load1=0.013;15.000;30.000;0; load5=0.012;10.000;25.000;0; load15=0.235;5.000;20.000;0; 04:48PM up 1 day, 5:55, 31 users, load average: 1.09, 1.07, 1.61 ---------------------------------------------------------------------- Comment By: Martin Richard (martinrichard) Date: 2005-10-20 13:13 Message: Logged In: YES user_id=1226367 Just tested - this has been fixed in check_load 1.30 on the cvs. It changes %f to %lf in the sscanf to parse the result from uptime.. works great now: # ./check_load -w 3,2,1 -c 6,5,4; uptime OK - load average: 0.09, 0.17, 0.09|load1=0.090;3.000;6.000;0; load5=0.170;2.000;5.000;0; load15=0.090;1.000;4.000;0; 01:06PM up 122 days, 22:33, 1 user, load average: 0.09, 0.17, 0.09 ---------------------------------------------------------------------- Comment By: Martin Richard (martinrichard) Date: 2005-10-20 13:00 Message: Logged In: YES user_id=1226367 Same symptoms on 2 different AIX 5 here.. # ./check_load -w 3,2,1 -c 6,5,4; uptime OK - load average: 0.13, 0.01, 0.01|load1=0.135;3.000;6.000;0; load5=0.007;2.000;5.000;0; load15=0.012;1.000;4.000;0; 12:59PM up 21 days, 15:44, 2 users, load average: 1.51, 0.98, 1.06 # Would it matter in any way that the machine has 2 CPUs ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1283131&group_id=29880 From noreply at sourceforge.net Fri Oct 21 02:47:37 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 21 02:47:37 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1333956 ] check_log errors on non-Linux platforms Message-ID: Bugs item #1333956, was opened at 2005-10-21 10:46 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1333956&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: Release (specify) Status: Open Resolution: None Priority: 5 Submitted By: Ade Rixon (aderixon) Assigned to: Nobody/Anonymous (nobody) Summary: check_log errors on non-Linux platforms Initial Comment: I am running check_log from the 1.4 release (unchanged in 1.4.2) on Solaris 8. It gives shell errors and falis to work correctly because: a) chmod command is unrecognised (no path) in the case where mktemp is not available; b) tail command uses GNU-specific long option instead of generic alternative. The attached patch fixes these issues and also adds: - variable definitions for CHMOD and TOUCH to match command usage in rest of script; - use of extended grep (egrep) in place of grep to support full regex matching; assume this works on all supported platforms. Ade ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1333956&group_id=29880 From noreply at sourceforge.net Fri Oct 21 03:14:33 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 21 03:14:33 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1251096 ] check_ntp perl warnings Message-ID: Bugs item #1251096, was opened at 2005-08-03 15:49 Message generated for change (Comment added) made by aderixon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1251096&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Parsing problem Group: Release (specify) Status: Open Resolution: None Priority: 5 Submitted By: Peter Pramberger (peterpramb) Assigned to: Nobody/Anonymous (nobody) Summary: check_ntp perl warnings Initial Comment: Using check_ntp.pl from plugins 1.4.1 produces some warnings if the checked host is not reachable or responding before timeout. These warnings produce an UNKNOWN state in Nagios. See the attached patch for clarification. ---------------------------------------------------------------------- Comment By: Ade Rixon (aderixon) Date: 2005-10-21 11:12 Message: Logged In: YES user_id=145082 This is still a problem in 1.4.2, can someone review before next release, please? The warning is: Argument "(not parsed)" isn't numeric in abs at ./check_ntp line 401. ...Caused by assigning a string value ('(not parsed)') to $jitter. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1251096&group_id=29880 From seanius at seanius.net Fri Oct 21 04:58:00 2005 From: seanius at seanius.net (sean finney) Date: Fri Oct 21 04:58:00 2005 Subject: [Nagiosplug-devel] trying out gnutls In-Reply-To: References: Message-ID: <20051021115618.GA21907@seanius.net> hi Bj?rnar, On Fri, Oct 21, 2005 at 01:41:03PM +0200, Bj?rnar Bj?rgum Larsen wrote: > Thank you very much for including gnutls support for nagios > plugins. > > Small suggestion: Given that openssl and gnutls are mutually > exclusive, if i say --with-gnutls, couldn't the --without-openssl > be implied? The point being that neither alternative would seem > to be the default. yes, that should be done, thanks for pointing it out. i'll make sure that goes in this weekend, when i hope to cleanup the configure.in code a bit too. sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From ae at op5.se Fri Oct 21 06:18:39 2005 From: ae at op5.se (Andreas Ericsson) Date: Fri Oct 21 06:18:39 2005 Subject: [Nagiosplug-devel] trying out gnutls In-Reply-To: <20051021115618.GA21907@seanius.net> References: <20051021115618.GA21907@seanius.net> Message-ID: <4358EA2F.7010009@op5.se> sean finney wrote: > hi Bj?rnar, > > On Fri, Oct 21, 2005 at 01:41:03PM +0200, Bj?rnar Bj?rgum Larsen wrote: > >>Thank you very much for including gnutls support for nagios >>plugins. >> >>Small suggestion: Given that openssl and gnutls are mutually >>exclusive, if i say --with-gnutls, couldn't the --without-openssl >>be implied? The point being that neither alternative would seem >>to be the default. > > > yes, that should be done, thanks for pointing it out. i'll make > sure that goes in this weekend, when i hope to cleanup the configure.in > code a bit too. > While you're at it, how about tucking it in a separate file (sslutils.c)? Otherwise all networking non-ssl plugins will have to be linked to the ssl libraries anyways, or the linker will complain. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 From seanius at seanius.net Sun Oct 23 04:54:21 2005 From: seanius at seanius.net (sean finney) Date: Sun Oct 23 04:54:21 2005 Subject: [Nagiosplug-devel] trying out gnutls In-Reply-To: <4358EA2F.7010009@op5.se> References: <20051021115618.GA21907@seanius.net> <4358EA2F.7010009@op5.se> Message-ID: <20051023115214.GA17359@seanius.net> On Fri, Oct 21, 2005 at 03:16:31PM +0200, Andreas Ericsson wrote: > While you're at it, how about tucking it in a separate file > (sslutils.c)? Otherwise all networking non-ssl plugins will have to be > linked to the ssl libraries anyways, or the linker will complain. even though they don't reference any ssl symbols? i didn't see this on my system, though i guess i could see it happening on other (non-gcc?) systems. anyway, it's reasonable enough that it ought to be done anyways. i'll be including this along with another commit in a few minutes. btw, does anyone know if we actually need the "uname -p" call in configure? on my linux systems there is no "-p" flag. i know on solaris it's the "architecture instruction set" or something like that, but are we even using it? sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From ae at op5.se Sun Oct 23 05:29:27 2005 From: ae at op5.se (Andreas Ericsson) Date: Sun Oct 23 05:29:27 2005 Subject: [Nagiosplug-devel] trying out gnutls In-Reply-To: <20051023115214.GA17359@seanius.net> References: <20051021115618.GA21907@seanius.net> <4358EA2F.7010009@op5.se> <20051023115214.GA17359@seanius.net> Message-ID: <435B8192.6070604@op5.se> sean finney wrote: > On Fri, Oct 21, 2005 at 03:16:31PM +0200, Andreas Ericsson wrote: > >>While you're at it, how about tucking it in a separate file >>(sslutils.c)? Otherwise all networking non-ssl plugins will have to be >>linked to the ssl libraries anyways, or the linker will complain. > > > even though they don't reference any ssl symbols? i didn't see this on > my system, though i guess i could see it happening on other (non-gcc?) > systems. anyway, it's reasonable enough that it ought to be done > anyways. i'll be including this along with another commit in a few > minutes. > > btw, does anyone know if we actually need the "uname -p" call > in configure? on my linux systems there is no "-p" flag. i know > on solaris it's the "architecture instruction set" or something like > that, but are we even using it? > Not likely. I know heavily optimized code (mplayer, vlcplayer, glibc) sometimes take shortcuts through specific assembly instructions, but I see no real reason for such extreme optimization in the plugins. That information is also (usually) available through preprocessor macros. http://predef.sourceforge.net for more info on preprocessor macros. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 From seanius at seanius.net Mon Oct 24 04:19:26 2005 From: seanius at seanius.net (sean finney) Date: Mon Oct 24 04:19:26 2005 Subject: [Nagiosplug-devel] starting import of runcmd code Message-ID: <20051024111726.GA31588@seanius.net> hi all, i've just done a first commit for this. below are some notes from the process. general: - updated runcmd code to latest version from ae - new host_or_die function - new usage_va function for printf-like (fmt,...) params. - i didn't include any of the other "cleanup" or other superficial changes/optimizations from ae's patches in this run. the following seem to be okay: - check_dns - check_nagios the following seem to be okay, but i'd like more testing: - check_by_ssh: - check_dig: - didn't work for nonexistant domains (bug in introduced runcmd logic), later fixed by me. - check_game: - having a quake server to test against would be good the following haven't been done yet: - check_dhcp: - i remember there being some problem with that so i'll take a look later - check_hpjd - patch contained swapped MIB defs, need to verify - check_icmp because i haven't yet - check_load because of later changes in official branch - check_procs - seems some detection logic is broken in the new runcmd based code. or maybe it was already? seems so... - check_snmp - don't want to play around with sg's code just now - check_swap - seems there have been parallel changes - check_users - contains a bunch of runcmd debug code -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From ml at os2.kiev.ua Mon Oct 24 04:50:48 2005 From: ml at os2.kiev.ua (Alex Samorukov) Date: Mon Oct 24 04:50:48 2005 Subject: [Nagiosplug-devel] nagios and local sockets patch Message-ID: <435CCA8F.10200@os2.kiev.ua> Hi. I want to ask to check and commit patch for nagios plugins which allow to check services on local sockets. The patch is located on http://sourceforge.net/tracker/index.php?func=detail&aid=1145413&group_id=29880&atid=397599 . I use it on my freebsd box, and it work just fine. Some users wrote me mail that they used this patch too. I hope to see it commited. With best regards, Alex Samorukov From seanius at seanius.net Mon Oct 24 09:10:40 2005 From: seanius at seanius.net (sean finney) Date: Mon Oct 24 09:10:40 2005 Subject: [Nagiosplug-devel] nagios and local sockets patch In-Reply-To: <435CCA8F.10200@os2.kiev.ua> References: <435CCA8F.10200@os2.kiev.ua> Message-ID: <20051024160842.GA1537@seanius.net> hi alex, On Mon, Oct 24, 2005 at 02:50:39PM +0300, Alex Samorukov wrote: > I want to ask to check and commit patch for nagios plugins which allow > to check services on local sockets. > The patch is located on > http://sourceforge.net/tracker/index.php?func=detail&aid=1145413&group_id=29880&atid=397599 > . > I use it on my freebsd box, and it work just fine. Some users wrote me > mail that they used this patch too. I hope to see it commited. short synopsis: if the hostname starts with a '/', the net code defaults to opening a local socket instead of an inet socket. anyone else want to chimein on whether they feel that's reasonable? my thought is there should be a cmdline flag to imply that a "host" should be interpreted as a local socket instead, but don't feel too strongly about it. sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From ml at os2.kiev.ua Mon Oct 24 11:54:34 2005 From: ml at os2.kiev.ua (Alex Samorukov) Date: Mon Oct 24 11:54:34 2005 Subject: [Nagiosplug-devel] nagios and local sockets patch In-Reply-To: <20051024160842.GA1537@seanius.net> References: <435CCA8F.10200@os2.kiev.ua> <20051024160842.GA1537@seanius.net> Message-ID: <435D2DAF.1060306@os2.kiev.ua> sean finney wrote: >hi alex, > >On Mon, Oct 24, 2005 at 02:50:39PM +0300, Alex Samorukov wrote: > > >>I want to ask to check and commit patch for nagios plugins which allow >>to check services on local sockets. >>The patch is located on >>http://sourceforge.net/tracker/index.php?func=detail&aid=1145413&group_id=29880&atid=397599 >>. >>I use it on my freebsd box, and it work just fine. Some users wrote me >>mail that they used this patch too. I hope to see it commited. >> >> > >short synopsis: if the hostname starts with a '/', the net code >defaults to opening a local socket instead of an inet socket. > >anyone else want to chimein on whether they feel that's reasonable? my >thought is there should be a cmdline flag to imply that a "host" should >be interpreted as a local socket instead, but don't feel too strongly >about it. > > I take this logic from the bsd telnet sources. Here is short text from the telnet man: === host Indicates the official name, an alias, or the Internet address of a remote host. If host starts with a `/', telnet establishes a connection to the corresponding named socket. === I think that hostname cannot start with "/" characters and local socket always can be referenced as absolute pathname. So i dont think that we need different key for this. Anyway, if someone not agree with this i can create a new patch. From ton.voon at altinity.com Tue Oct 25 01:29:27 2005 From: ton.voon at altinity.com (Ton Voon) Date: Tue Oct 25 01:29:27 2005 Subject: [Nagiosplug-devel] nagios and local sockets patch In-Reply-To: <435D2DAF.1060306@os2.kiev.ua> References: <435CCA8F.10200@os2.kiev.ua> <20051024160842.GA1537@seanius.net> <435D2DAF.1060306@os2.kiev.ua> Message-ID: On 24 Oct 2005, at 19:53, Alex Samorukov wrote: > I take this logic from the bsd telnet sources. Here is short text > from the telnet man: > === > host > Indicates the official name, an alias, or the Internet address of a > remote host. If host starts with a `/', telnet establishes a > connection to the corresponding named socket. > === > I think that hostname cannot start with "/" characters and local > socket always can be referenced as absolute pathname. So i dont > think that we need different key for this. Anyway, if someone not > agree with this i can create a new patch. I wasn't keen on this convention, but if BSD use it, then I'm happy. Ton http://www.altinity.com T: +44 (0)870 787 9243 F: +44 (0)845 280 1725 Skype: tonvoon -------------- next part -------------- An HTML attachment was scrubbed... URL: From seanius at seanius.net Tue Oct 25 01:50:44 2005 From: seanius at seanius.net (sean finney) Date: Tue Oct 25 01:50:44 2005 Subject: [Nagiosplug-devel] nagios and local sockets patch In-Reply-To: References: <435CCA8F.10200@os2.kiev.ua> <20051024160842.GA1537@seanius.net> <435D2DAF.1060306@os2.kiev.ua> Message-ID: <20051025084850.GA10653@seanius.net> On Tue, Oct 25, 2005 at 09:26:20AM +0100, Ton Voon wrote: > >I think that hostname cannot start with "/" characters and local > >socket always can be referenced as absolute pathname. So i dont > >think that we need different key for this. Anyway, if someone not > >agree with this i can create a new patch. > > I wasn't keen on this convention, but if BSD use it, then I'm happy. > okay, well then i'll work on merging in the supplied patch, and if anyone has a complaint about it they better bring it up before the next release. sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From noreply at sourceforge.net Wed Oct 26 03:11:44 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 26 03:11:44 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1338298 ] check_linux_raid plugin does not recognize recovery Message-ID: Patches item #1338298, was opened at 2005-10-26 12:09 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1338298&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bastiaan Bakker (bastiaan) Assigned to: Nobody/Anonymous (nobody) Summary: check_linux_raid plugin does not recognize recovery Initial Comment: The check_linux_raid plugin does not properly parse /proc/mdstat, causing it to report CRITICAL status for RAID devices that are already recovering. For example it reports CRITICAL for the following /proc/mdstat (taken from a CentOS 3.5 box): Personalities : [raid1] read_ahead 1024 sectors Event: 8 md0 : active raid1 sdb1[2] sda1[1] 2097024 blocks [2/1] [_U] [>....................] recovery = 0.4% (10168/2097024) finish=23.8min speed=1452K/sec unused devices: The attached patch fixes two bugs which cause this problem: 1) do not stop parsing after [_U] but until the next mdX entry begins, so we won't miss the 'recovery line' 2) allow two or more spaces after 'recovery =' in order to recognize single digit percentages Other modifications: 1) Addition of 'speed=' to the output: WARNING md0 status=[_U], recovery=0.4%, finish=23.8min, speed=1452K/sec 2) Addition of optionally specification of mdstat file as second command line parameter. Primarily useful for debugging. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1338298&group_id=29880 From noreply at sourceforge.net Wed Oct 26 20:31:48 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 26 20:31:48 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1339134 ] Fixes --mismatch option for check_tcp Message-ID: Patches item #1339134, was opened at 2005-10-26 22:30 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1339134&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None Status: Open Resolution: None Priority: 5 Submitted By: Rick Frey (grater) Assigned to: Nobody/Anonymous (nobody) Summary: Fixes --mismatch option for check_tcp Initial Comment: check_tcp correctly parsed options for --mismatch option and set var expect_mismatch_state, but never used var when mismatch was detected (string mismatch always returned STATE_WARNING regardless of mismatch argument). Patch to check_tcp 1.66 (supplied with 1.4.2 plugins): *** check_tcp.c Sun Jun 5 12:43:58 2005 --- check_tcp.c.patch Wed Oct 26 22:20:30 2005 *************** *** 350,356 **** /* did we get the response we hoped? */ if(match == -2 && result != STATE_CRITICAL) ! result = STATE_WARNING; /* reset the alarm */ alarm (0); --- 350,356 ---- /* did we get the response we hoped? */ if(match == -2 && result != STATE_CRITICAL) ! result = expect_mismatch_state; /* reset the alarm */ alarm (0); ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1339134&group_id=29880 From noreply at sourceforge.net Wed Oct 26 20:51:24 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Wed Oct 26 20:51:24 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1339140 ] Enables check_ldap to monitor root DSE Message-ID: Patches item #1339140, was opened at 2005-10-26 22:49 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1339140&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None Status: Open Resolution: None Priority: 5 Submitted By: Rick Frey (grater) Assigned to: Nobody/Anonymous (nobody) Summary: Enables check_ldap to monitor root DSE Initial Comment: Had need to monitor root DSE using check_ldap but unable since LDAP search requires a base DN of "" (empty string). check_ldap version 1.30 (supplied with 1.4.2 plugins) does not allow zero length string for base DN. Modified to remove test for zero length base dn to allow passing argument of "" for base dn. Patch to version 1.30: *** check_ldap.c Sat Dec 25 17:17:44 2004 --- check_ldap.c.patch Wed Oct 26 22:46:29 2005 *************** *** 333,339 **** if (ld_host==NULL || strlen(ld_host)==0) usage4 (_("Please specify the host name\n")); ! if (ld_base==NULL || strlen(ld_base)==0) usage4 (_("Please specify the LDAP base\n")); return OK; --- 333,339 ---- if (ld_host==NULL || strlen(ld_host)==0) usage4 (_("Please specify the host name\n")); ! if (ld_base==NULL) usage4 (_("Please specify the LDAP base\n")); return OK; ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1339140&group_id=29880 From noreply at sourceforge.net Thu Oct 27 01:32:37 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Thu Oct 27 01:32:37 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1251096 ] check_ntp perl warnings Message-ID: Bugs item #1251096, was opened at 2005-08-03 16:49 Message generated for change (Comment added) made by cbueche You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1251096&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Parsing problem Group: Release (specify) Status: Open Resolution: None Priority: 5 Submitted By: Peter Pramberger (peterpramb) Assigned to: Nobody/Anonymous (nobody) Summary: check_ntp perl warnings Initial Comment: Using check_ntp.pl from plugins 1.4.1 produces some warnings if the checked host is not reachable or responding before timeout. These warnings produce an UNKNOWN state in Nagios. See the attached patch for clarification. ---------------------------------------------------------------------- Comment By: Charles Bueche (cbueche) Date: 2005-10-27 10:30 Message: Logged In: YES user_id=299377 duplicate with 1267741 ---------------------------------------------------------------------- Comment By: Ade Rixon (aderixon) Date: 2005-10-21 12:12 Message: Logged In: YES user_id=145082 This is still a problem in 1.4.2, can someone review before next release, please? The warning is: Argument "(not parsed)" isn't numeric in abs at ./check_ntp line 401. ...Caused by assigning a string value ('(not parsed)') to $jitter. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1251096&group_id=29880 From jtmoore at autosportcatalog.com Thu Oct 27 15:08:12 2005 From: jtmoore at autosportcatalog.com (J.T. Moore) Date: Thu Oct 27 15:08:12 2005 Subject: [Nagiosplug-devel] check_http plugin suggestion Message-ID: <670DD7A2C61C1849BF9372C2C6992E1F6BC0@borg2.domain.international-auto.com> Hello, It appears that the check_http plugin ignores the --string option when the http status code is 4xx Normally if the string is not found, the plugin sets the service state to critical, but if a 4xx status code is returned, the service state is set to warning even if the string is not present. I suppose there may be times where this logic may be preferred, for example a http 200 status code with different content would indicate a likely defacement and is a critical problem where as a http 400 status code would indicate a less serious service disruption or configuration error If people are actually using the above logic, it shouldn't be changed, but in my case it would be nice to add a option to always compare the string value and always treat the string not being found as a critical error. What I am doing is using Nagios and a few other tools to set up a "director" for a fault tolerant web farm. To me a warning is, the page look longer to load than is desirable (as specified with the -w argument). A critical error is not returning a page with the specified string (specified with the -s argument) before the critical time (specified with the -c argument). Ideally, I would like to write an event handler that wouldn't do anything about warnings in a soft state, but that would stop sending traffic to a server if it was in a hard warning state or any type of critical state. Thanks for the cool tools, J.T. Moore International Auto Parts -------------- next part -------------- An HTML attachment was scrubbed... URL: From seanius at seanius.net Thu Oct 27 22:57:49 2005 From: seanius at seanius.net (sean finney) Date: Thu Oct 27 22:57:49 2005 Subject: [Nagiosplug-devel] looking for http/smtp server needing client certificates Message-ID: <20051028055635.GA18277@seanius.net> hey folks, i'd like to finish up the ssl-related work by adding support for handling client-certificate requests from the tcp/http/smtp plugins. however, i don't have a server that requires this in the first place. does anyone around here have a server that they wouldn't mind me testing plugins against while i hack out the code? also, the cmdline options required to generate the proper cert via openssl would be helpful too (or sending me a copy of a cert that would "just work" would be fine too, i guess). sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From seanius at seanius.net Thu Oct 27 23:01:39 2005 From: seanius at seanius.net (sean finney) Date: Thu Oct 27 23:01:39 2005 Subject: [Nagiosplug-devel] check_http plugin suggestion In-Reply-To: <670DD7A2C61C1849BF9372C2C6992E1F6BC0@borg2.domain.international-auto.com> References: <670DD7A2C61C1849BF9372C2C6992E1F6BC0@borg2.domain.international-auto.com> Message-ID: <20051028055943.GB18277@seanius.net> hi jt, On Thu, Oct 27, 2005 at 01:06:47PM -0400, J.T. Moore wrote: > It appears that the check_http plugin ignores the --string option > when the http status code is 4xx > > Normally if the string is not found, the plugin sets the service state > to critical, but if a 4xx status code is returned, the service state is > set to warning even if the string is not present. this sounds like an oversight. the next time i'm looking at the code in question i'll see about fixing it if no one beats me to it. sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From ae at op5.se Fri Oct 28 01:52:09 2005 From: ae at op5.se (Andreas Ericsson) Date: Fri Oct 28 01:52:09 2005 Subject: [Nagiosplug-devel] looking for http/smtp server needing client certificates In-Reply-To: <20051028055635.GA18277@seanius.net> References: <20051028055635.GA18277@seanius.net> Message-ID: <4361E65C.1@op5.se> sean finney wrote: > hey folks, > > i'd like to finish up the ssl-related work by adding support for > handling client-certificate requests from the tcp/http/smtp plugins. > however, i don't have a server that requires this in the first place. > dovecot supports this. http://www.dovecot.org. > does anyone around here have a server that they wouldn't mind me > testing plugins against while i hack out the code? also, the > cmdline options required to generate the proper cert via openssl > would be helpful too (or sending me a copy of a cert that would "just > work" would be fine too, i guess). > Attached is a script to generate certificates for webservers. You'll most likely have to tweak some of it a bit to make it sane for smtp usage, but it should give you a fairly good idea of how to do it. -- Andreas Ericsson andreas.ericsson at op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 -------------- next part -------------- A non-text attachment was scrubbed... Name: mksslcert.sh Type: application/x-shellscript Size: 18456 bytes Desc: not available URL: From seanius at seanius.net Fri Oct 28 05:19:39 2005 From: seanius at seanius.net (sean finney) Date: Fri Oct 28 05:19:39 2005 Subject: [Nagiosplug-devel] looking for http/smtp server needing client certificates In-Reply-To: <4361E65C.1@op5.se> References: <20051028055635.GA18277@seanius.net> <4361E65C.1@op5.se> Message-ID: <20051028121708.GA21822@seanius.net> hey andreas, On Fri, Oct 28, 2005 at 10:50:36AM +0200, Andreas Ericsson wrote: > >i'd like to finish up the ssl-related work by adding support for > >handling client-certificate requests from the tcp/http/smtp plugins. > >however, i don't have a server that requires this in the first place. > > dovecot supports this. http://www.dovecot.org. in fact i've a fair amount of experience with dovecot and other imap/smtp/http servers which could be configured to require an ssl certificate. however, my point was i've never done such, and i'd probably save myself an hour or two if osmeone had a pre-existing service against which i could test. then again, i guess having to learn something new isn't such a big deal either :) > Attached is a script to generate certificates for webservers. You'll > most likely have to tweak some of it a bit to make it sane for smtp > usage, but it should give you a fairly good idea of how to do it. i had some notes buried in a wiki at a former place of work with these commands documented, i was hoping i wouldn't have to resort to looking for them. this makes it a bit easier, thanks. sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From noreply at sourceforge.net Fri Oct 28 10:52:49 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Fri Oct 28 10:52:49 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1340923 ] check_ldaps is not installed Message-ID: Patches item #1340923, was opened at 2005-10-28 19:51 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1340923&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None Status: Open Resolution: None Priority: 5 Submitted By: nsturm (nsturm) Assigned to: Nobody/Anonymous (nobody) Summary: check_ldaps is not installed Initial Comment: In plugins/Makefile.am install-exec-hook target checks for the existence of the wrong file. See attached diff. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1340923&group_id=29880 From noreply at sourceforge.net Sat Oct 29 05:18:53 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 29 05:18:53 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Feature Requests-1341528 ] configure options to skip program autodetection Message-ID: Feature Requests item #1341528, was opened at 2005-10-29 15:17 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=1341528&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Priority: 5 Submitted By: glen scary (ahmake) Assigned to: Nobody/Anonymous (nobody) Summary: configure options to skip program autodetection Initial Comment: hi this patch adds commandline arguments to specify location of programs to be used, so the programs are not needed to exist at compile time in system, but plugins are usable. http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/nagios-plugins-configure.patch please be so kind and apply in your cvs. note: the ps program related patch chunk creates .rej with current snapshot (200510290447), but if you apply the rest, i'm happy to make that portion compatible with current cvs code. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=1341528&group_id=29880 From noreply at sourceforge.net Sat Oct 29 05:20:48 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 29 05:20:48 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Feature Requests-1341531 ] subst problem Message-ID: Feature Requests item #1341531, was opened at 2005-10-29 15:19 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=1341531&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Priority: 5 Submitted By: glen scary (ahmake) Assigned to: Nobody/Anonymous (nobody) Summary: subst problem Initial Comment: do the utils.pm substitution AFTER path based substitution otherwise if 'nagios' is in $PATH somewhy, then wrong perl library path is substituted to perl programs. http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/nagios-plugins-subst.patch?rev=1.2 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=1341531&group_id=29880 From noreply at sourceforge.net Sat Oct 29 05:43:45 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 29 05:43:45 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Feature Requests-1341528 ] configure options to skip program autodetection Message-ID: Feature Requests item #1341528, was opened at 2005-10-29 08:17 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=1341528&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Priority: 5 Submitted By: Elan Ruusam?e (ahmake) >Assigned to: M. Sean Finney (seanius) Summary: configure options to skip program autodetection Initial Comment: hi this patch adds commandline arguments to specify location of programs to be used, so the programs are not needed to exist at compile time in system, but plugins are usable. http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/nagios-plugins-configure.patch please be so kind and apply in your cvs. note: the ps program related patch chunk creates .rej with current snapshot (200510290447), but if you apply the rest, i'm happy to make that portion compatible with current cvs code. ---------------------------------------------------------------------- >Comment By: M. Sean Finney (seanius) Date: 2005-10-29 08:42 Message: Logged In: YES user_id=226838 hi elan, this would be a wonderful feature to have. as i'm also maintaining the debian distribution's package, i'm very much in the same situation as you. the previous maintainer issued build-dependencies on these packages, which was not only an ugly hack but also problematic, as some of the dependencies tried to install daemons on the debian build-hosts :) my current approach was to patch common.h to include a "debian.h" that had everything hardcoded, which isn't the most "graceful" way anyway, if you could supply a version that works against the current configure.in in cvs HEAD, i'd be more than willing to include it. also, could you comment on the first two hunks in the patch? not sure what the first one does and the second looks like it would have problems on non-linux hosts. thanks, sean ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=1341528&group_id=29880 From noreply at sourceforge.net Sat Oct 29 05:49:48 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 29 05:49:48 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1340923 ] check_ldaps is not installed Message-ID: Patches item #1340923, was opened at 2005-10-28 13:51 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1340923&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None >Status: Closed Resolution: None Priority: 5 Submitted By: nsturm (nsturm) >Assigned to: M. Sean Finney (seanius) Summary: check_ldaps is not installed Initial Comment: In plugins/Makefile.am install-exec-hook target checks for the existence of the wrong file. See attached diff. ---------------------------------------------------------------------- >Comment By: M. Sean Finney (seanius) Date: 2005-10-29 08:48 Message: Logged In: YES user_id=226838 hi, yes, i had noticed this too but hadn't had the time to look into what/why check_ldaps wasn't being created. anyway, i've applied the patch to cvs now, and the fix will be included in the next version. thanks, sean ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1340923&group_id=29880 From noreply at sourceforge.net Sat Oct 29 07:14:10 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 29 07:14:10 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Feature Requests-1341528 ] configure options to skip program autodetection Message-ID: Feature Requests item #1341528, was opened at 2005-10-29 15:17 Message generated for change (Comment added) made by ahmake You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=1341528&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Priority: 5 Submitted By: Elan Ruusam?e (ahmake) Assigned to: M. Sean Finney (seanius) Summary: configure options to skip program autodetection Initial Comment: hi this patch adds commandline arguments to specify location of programs to be used, so the programs are not needed to exist at compile time in system, but plugins are usable. http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/nagios-plugins-configure.patch please be so kind and apply in your cvs. note: the ps program related patch chunk creates .rej with current snapshot (200510290447), but if you apply the rest, i'm happy to make that portion compatible with current cvs code. ---------------------------------------------------------------------- >Comment By: Elan Ruusam?e (ahmake) Date: 2005-10-29 17:12 Message: Logged In: YES user_id=289546 ok. i've updated the /proc/loadavg to be also with commandline arg. ac_cv_ping_has_timeout needs more look, i guess it was added because there was no way to do it with commandline. i'll look on this later, perhaps on monday. ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-10-29 15:42 Message: Logged In: YES user_id=226838 hi elan, this would be a wonderful feature to have. as i'm also maintaining the debian distribution's package, i'm very much in the same situation as you. the previous maintainer issued build-dependencies on these packages, which was not only an ugly hack but also problematic, as some of the dependencies tried to install daemons on the debian build-hosts :) my current approach was to patch common.h to include a "debian.h" that had everything hardcoded, which isn't the most "graceful" way anyway, if you could supply a version that works against the current configure.in in cvs HEAD, i'd be more than willing to include it. also, could you comment on the first two hunks in the patch? not sure what the first one does and the second looks like it would have problems on non-linux hosts. thanks, sean ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=1341528&group_id=29880 From noreply at sourceforge.net Sat Oct 29 08:41:58 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 29 08:41:58 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1333956 ] check_log errors on non-Linux platforms Message-ID: Bugs item #1333956, was opened at 2005-10-21 05:46 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1333956&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: Release (specify) >Status: Pending Resolution: None Priority: 5 Submitted By: Ade Rixon (aderixon) >Assigned to: M. Sean Finney (seanius) Summary: check_log errors on non-Linux platforms Initial Comment: I am running check_log from the 1.4 release (unchanged in 1.4.2) on Solaris 8. It gives shell errors and falis to work correctly because: a) chmod command is unrecognised (no path) in the case where mktemp is not available; b) tail command uses GNU-specific long option instead of generic alternative. The attached patch fixes these issues and also adds: - variable definitions for CHMOD and TOUCH to match command usage in rest of script; - use of extended grep (egrep) in place of grep to support full regex matching; assume this works on all supported platforms. Ade ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-10-29 11:39 Message: Logged In: YES user_id=226838 this problem is now fixed in cvs. thank you for your report. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1333956&group_id=29880 From noreply at sourceforge.net Sat Oct 29 08:44:58 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 29 08:44:58 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1314503 ] nagios cant check local sockets Message-ID: Bugs item #1314503, was opened at 2005-10-06 01:33 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1314503&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None >Status: Pending Resolution: None Priority: 5 Submitted By: Alex Samorukov (samm2) >Assigned to: M. Sean Finney (seanius) Summary: nagios cant check local sockets Initial Comment: Hi. It is not a bug, its a feture request but i sent patch MANY month ago and i still have no any reaction on it :( It is still open. Some users use it (they wrote me mail) but i dont know why it is not included in the sources :( Bug itself is that check_tcp (and it childs) cant check services on local sockets. I am sure that many services which dont need to communicate with external world have only local socket connectors, e.g. clamav antivirus, or local SQL server, etc. The patch (newdiff file) is located on http://sourceforge.net/tracker/index.php?func=detail&aid=1145413&group_id=29880&atid=397599 I used on my servers and it seems to work fine. I hope to see it in later releases or explanation why this cannot be done. With best regards, Alex Samorukov ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-10-29 11:43 Message: Logged In: YES user_id=226838 this problem is now fixed in cvs. thank you for your report. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1314503&group_id=29880 From ml at os2.kiev.ua Sat Oct 29 11:25:09 2005 From: ml at os2.kiev.ua (Alex Samorukov) Date: Sat Oct 29 11:25:09 2005 Subject: [Nagiosplug-devel] check_tcp and local sockets Message-ID: <4363BE44.2030505@os2.kiev.ua> Hi all. Big thanks to Seanius for looking into my patch. I tried latest CVS and found some errors on it. This small error make check_tcp completely unusable (core on startup). Here is a correction: samm>~/src/nagios-plugins/nagiosplug/plugins: cvs diff -u cvs diff: Diffing . Index: check_tcp.c =================================================================== RCS file: /cvsroot/nagiosplug/nagiosplug/plugins/check_tcp.c,v retrieving revision 1.70 diff -u -r1.70 check_tcp.c --- check_tcp.c 25 Oct 2005 10:38:02 -0000 1.70 +++ check_tcp.c 29 Oct 2005 18:15:10 -0000 @@ -177,7 +177,7 @@ QUIT = "QUIT\r\n"; PORT = 119; } - else if (strncmp(SERVICE, "CLAMD", 5)) { + else if (!strncmp(SERVICE, "CLAMD", 5)) { SEND = "PING"; EXPECT = "PONG"; QUIT = NULL; @@ -550,7 +550,7 @@ if (server_address == NULL) usage4 (_("You must provide a server address")); - else if (is_host (optarg) == FALSE && optarg[0] != '/') + else if (is_host (server_address) == FALSE && server_address[0] != '/') usage2 (_("Invalid hostname, address, or socket"), optarg); return TRUE; From noreply at sourceforge.net Sat Oct 29 11:25:18 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 29 11:25:18 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1145413 ] This patche allow to use unix sockets in nagios plugins. Message-ID: Patches item #1145413, was opened at 2005-02-21 15:20 Message generated for change (Comment added) made by samm2 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1145413&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None Status: Open Resolution: None Priority: 5 Submitted By: Alex Samorukov (samm2) Assigned to: Nobody/Anonymous (nobody) Summary: This patche allow to use unix sockets in nagios plugins. Initial Comment: With this patch user can specify unix socket as -H argument. This allow to check tcp services which are bind to unix sockets only. I use this for checking clamav-clamd. Alsi, i added check_clamd prototype to check status of the CLAMAV daemon (clamav.net). ---------------------------------------------------------------------- >Comment By: Alex Samorukov (samm2) Date: 2005-10-29 21:23 Message: Logged In: YES user_id=891004 I tried latest CVS and found some errors on it. This small error make check_tcp completely unusable (core on startup). Here is a correction: samm>~/src/nagios-plugins/nagiosplug/plugins: cvs diff -u cvs diff: Diffing . Index: check_tcp.c =================================================================== RCS file: /cvsroot/nagiosplug/nagiosplug/plugins/check_tcp.c,v retrieving revision 1.70 diff -u -r1.70 check_tcp.c --- check_tcp.c 25 Oct 2005 10:38:02 -0000 1.70 +++ check_tcp.c 29 Oct 2005 18:15:10 -0000 @@ -177,7 +177,7 @@ QUIT = "QUIT\r\n"; PORT = 119; } - else if (strncmp(SERVICE, "CLAMD", 5)) { + else if (!strncmp(SERVICE, "CLAMD", 5)) { SEND = "PING"; EXPECT = "PONG"; QUIT = NULL; @@ -550,7 +550,7 @@ if (server_address == NULL) usage4 (_("You must provide a server address")); - else if (is_host (optarg) == FALSE && optarg[0] != '/') + else if (is_host (server_address) == FALSE && server_address[0] != '/') usage2 (_("Invalid hostname, address, or socket"), optarg); return TRUE; ---------------------------------------------------------------------- Comment By: Subhendu Ghosh (sghosh) Date: 2005-06-01 17:29 Message: Logged In: YES user_id=46572 Can you take a shot at reworking the patch based on the current CVS - a bunch of changes went in a couple of weeks ago that breaks this patch. ---------------------------------------------------------------------- Comment By: Alex Samorukov (samm2) Date: 2005-03-11 12:04 Message: Logged In: YES user_id=891004 Hi. Will nagios-plugins use this code? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1145413&group_id=29880 From samm at os2.kiev.ua Sat Oct 29 13:13:57 2005 From: samm at os2.kiev.ua (Alex Samorukov) Date: Sat Oct 29 13:13:57 2005 Subject: [Nagiosplug-devel] check_tcp and local sockets Message-ID: <4363BD1A.7050002@os2.kiev.ua> Hi all. Big thanks to Seanius for looking into my patch. I tried latest CVS and found some errors on it. This small error make check_tcp completely unusable (core on startup). Here is a correction: samm>~/src/nagios-plugins/nagiosplug/plugins: cvs diff -u cvs diff: Diffing . Index: check_tcp.c =================================================================== RCS file: /cvsroot/nagiosplug/nagiosplug/plugins/check_tcp.c,v retrieving revision 1.70 diff -u -r1.70 check_tcp.c --- check_tcp.c 25 Oct 2005 10:38:02 -0000 1.70 +++ check_tcp.c 29 Oct 2005 18:15:10 -0000 @@ -177,7 +177,7 @@ QUIT = "QUIT\r\n"; PORT = 119; } - else if (strncmp(SERVICE, "CLAMD", 5)) { + else if (!strncmp(SERVICE, "CLAMD", 5)) { SEND = "PING"; EXPECT = "PONG"; QUIT = NULL; @@ -550,7 +550,7 @@ if (server_address == NULL) usage4 (_("You must provide a server address")); - else if (is_host (optarg) == FALSE && optarg[0] != '/') + else if (is_host (server_address) == FALSE && server_address[0] != '/') usage2 (_("Invalid hostname, address, or socket"), optarg); return TRUE; From noreply at sourceforge.net Sat Oct 29 18:28:44 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 29 18:28:44 2005 Subject: [Nagiosplug-devel] [ nagiosplug-New Plugins-1187892 ] check_mail.pl Message-ID: New Plugins item #1187892, was opened at 2005-04-22 07:56 Message generated for change (Comment added) made by jbuhacoff You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1187892&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Perl plugin Group: None Status: Open Resolution: None Priority: 5 Submitted By: bledi51 (bledi51) Assigned to: Nobody/Anonymous (nobody) Summary: check_mail.pl Initial Comment: Send mails to specified server, check them, and delete them check_mail.pl -H host -f addsender -t addrecpt -u user -p poppass -n nbrmail -w warningvalue [-v] check_mail.pl --version check_mail.pl --help Required Arguments: -H, --host=HOST The name or address of the mail server. -f, --from The sender address -t, --to The recipient address -u, --user The user -p, --pass The pop password -w, --warning The warning value < number of mail send -n; --mailnbr The number of mail send to the server -v; --verbose Verbose, more informations -T; --timeout Number of seconds to wait for a response ---------------------------------------------------------------------- Comment By: Jonathan Buhacoff (jbuhacoff) Date: 2005-10-30 01:27 Message: Logged In: YES user_id=1370225 I wish I had seen this before!!! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1187892&group_id=29880 From noreply at sourceforge.net Sat Oct 29 18:29:08 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sat Oct 29 18:29:08 2005 Subject: [Nagiosplug-devel] [ nagiosplug-New Plugins-1187892 ] check_mail.pl Message-ID: New Plugins item #1187892, was opened at 2005-04-22 07:56 Message generated for change (Comment added) made by jbuhacoff You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1187892&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Perl plugin Group: None Status: Open Resolution: None Priority: 5 Submitted By: bledi51 (bledi51) Assigned to: Nobody/Anonymous (nobody) Summary: check_mail.pl Initial Comment: Send mails to specified server, check them, and delete them check_mail.pl -H host -f addsender -t addrecpt -u user -p poppass -n nbrmail -w warningvalue [-v] check_mail.pl --version check_mail.pl --help Required Arguments: -H, --host=HOST The name or address of the mail server. -f, --from The sender address -t, --to The recipient address -u, --user The user -p, --pass The pop password -w, --warning The warning value < number of mail send -n; --mailnbr The number of mail send to the server -v; --verbose Verbose, more informations -T; --timeout Number of seconds to wait for a response ---------------------------------------------------------------------- Comment By: Jonathan Buhacoff (jbuhacoff) Date: 2005-10-30 01:28 Message: Logged In: YES user_id=1370225 I wish I had seen this before!!! ---------------------------------------------------------------------- Comment By: Jonathan Buhacoff (jbuhacoff) Date: 2005-10-30 01:27 Message: Logged In: YES user_id=1370225 I wish I had seen this before!!! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1187892&group_id=29880 From seanius at seanius.net Sun Oct 30 02:28:00 2005 From: seanius at seanius.net (sean finney) Date: Sun Oct 30 02:28:00 2005 Subject: [Nagiosplug-devel] check_tcp and local sockets In-Reply-To: <4363BE44.2030505@os2.kiev.ua> References: <4363BE44.2030505@os2.kiev.ua> Message-ID: <20051030102715.GA14098@seanius.net> hey alex, On Sat, Oct 29, 2005 at 09:24:04PM +0300, Alex Samorukov wrote: > Big thanks to Seanius for looking into my patch. I tried latest CVS and > found some errors on it. > This small error make check_tcp completely unusable (core on startup). > Here is a correction: > - else if (strncmp(SERVICE, "CLAMD", 5)) { > + else if (!strncmp(SERVICE, "CLAMD", 5)) { d'oh. that's what i get for manually merging in the patch :) > - else if (is_host (optarg) == FALSE && optarg[0] != '/') > + else if (is_host (server_address) == FALSE && server_address[0] > != '/') yeah. and that's what i get for making a code optimization without double checking myself. anyway, both of these are fixed in cvs now. on a related note, i believe that providing this feature also provides a much better/thorough way to test the tcp-based plugins. i don't know much about how the test suite works, but it wouldn't be too hard to write a test program that creates a unix domain socket and spoke the proper things to the plugins... sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From noreply at sourceforge.net Sun Oct 30 02:30:05 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 30 02:30:05 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1145413 ] This patche allow to use unix sockets in nagios plugins. Message-ID: Patches item #1145413, was opened at 2005-02-21 08:20 Message generated for change (Comment added) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1145413&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None >Status: Pending Resolution: None Priority: 5 Submitted By: Alex Samorukov (samm2) Assigned to: Nobody/Anonymous (nobody) Summary: This patche allow to use unix sockets in nagios plugins. Initial Comment: With this patch user can specify unix socket as -H argument. This allow to check tcp services which are bind to unix sockets only. I use this for checking clamav-clamd. Alsi, i added check_clamd prototype to check status of the CLAMAV daemon (clamav.net). ---------------------------------------------------------------------- >Comment By: M. Sean Finney (seanius) Date: 2005-10-30 05:29 Message: Logged In: YES user_id=226838 fixed in cvs, thanks ---------------------------------------------------------------------- Comment By: Alex Samorukov (samm2) Date: 2005-10-29 14:23 Message: Logged In: YES user_id=891004 I tried latest CVS and found some errors on it. This small error make check_tcp completely unusable (core on startup). Here is a correction: samm>~/src/nagios-plugins/nagiosplug/plugins: cvs diff -u cvs diff: Diffing . Index: check_tcp.c =================================================================== RCS file: /cvsroot/nagiosplug/nagiosplug/plugins/check_tcp.c,v retrieving revision 1.70 diff -u -r1.70 check_tcp.c --- check_tcp.c 25 Oct 2005 10:38:02 -0000 1.70 +++ check_tcp.c 29 Oct 2005 18:15:10 -0000 @@ -177,7 +177,7 @@ QUIT = "QUIT\r\n"; PORT = 119; } - else if (strncmp(SERVICE, "CLAMD", 5)) { + else if (!strncmp(SERVICE, "CLAMD", 5)) { SEND = "PING"; EXPECT = "PONG"; QUIT = NULL; @@ -550,7 +550,7 @@ if (server_address == NULL) usage4 (_("You must provide a server address")); - else if (is_host (optarg) == FALSE && optarg[0] != '/') + else if (is_host (server_address) == FALSE && server_address[0] != '/') usage2 (_("Invalid hostname, address, or socket"), optarg); return TRUE; ---------------------------------------------------------------------- Comment By: Subhendu Ghosh (sghosh) Date: 2005-06-01 10:29 Message: Logged In: YES user_id=46572 Can you take a shot at reworking the patch based on the current CVS - a bunch of changes went in a couple of weeks ago that breaks this patch. ---------------------------------------------------------------------- Comment By: Alex Samorukov (samm2) Date: 2005-03-11 05:04 Message: Logged In: YES user_id=891004 Hi. Will nagios-plugins use this code? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1145413&group_id=29880 From noreply at sourceforge.net Sun Oct 30 02:30:58 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 30 02:30:58 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1145413 ] This patche allow to use unix sockets in nagios plugins. Message-ID: Patches item #1145413, was opened at 2005-02-21 08:20 Message generated for change (Settings changed) made by seanius You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1145413&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None Status: Pending Resolution: None Priority: 5 Submitted By: Alex Samorukov (samm2) >Assigned to: M. Sean Finney (seanius) Summary: This patche allow to use unix sockets in nagios plugins. Initial Comment: With this patch user can specify unix socket as -H argument. This allow to check tcp services which are bind to unix sockets only. I use this for checking clamav-clamd. Alsi, i added check_clamd prototype to check status of the CLAMAV daemon (clamav.net). ---------------------------------------------------------------------- Comment By: M. Sean Finney (seanius) Date: 2005-10-30 05:29 Message: Logged In: YES user_id=226838 fixed in cvs, thanks ---------------------------------------------------------------------- Comment By: Alex Samorukov (samm2) Date: 2005-10-29 14:23 Message: Logged In: YES user_id=891004 I tried latest CVS and found some errors on it. This small error make check_tcp completely unusable (core on startup). Here is a correction: samm>~/src/nagios-plugins/nagiosplug/plugins: cvs diff -u cvs diff: Diffing . Index: check_tcp.c =================================================================== RCS file: /cvsroot/nagiosplug/nagiosplug/plugins/check_tcp.c,v retrieving revision 1.70 diff -u -r1.70 check_tcp.c --- check_tcp.c 25 Oct 2005 10:38:02 -0000 1.70 +++ check_tcp.c 29 Oct 2005 18:15:10 -0000 @@ -177,7 +177,7 @@ QUIT = "QUIT\r\n"; PORT = 119; } - else if (strncmp(SERVICE, "CLAMD", 5)) { + else if (!strncmp(SERVICE, "CLAMD", 5)) { SEND = "PING"; EXPECT = "PONG"; QUIT = NULL; @@ -550,7 +550,7 @@ if (server_address == NULL) usage4 (_("You must provide a server address")); - else if (is_host (optarg) == FALSE && optarg[0] != '/') + else if (is_host (server_address) == FALSE && server_address[0] != '/') usage2 (_("Invalid hostname, address, or socket"), optarg); return TRUE; ---------------------------------------------------------------------- Comment By: Subhendu Ghosh (sghosh) Date: 2005-06-01 10:29 Message: Logged In: YES user_id=46572 Can you take a shot at reworking the patch based on the current CVS - a bunch of changes went in a couple of weeks ago that breaks this patch. ---------------------------------------------------------------------- Comment By: Alex Samorukov (samm2) Date: 2005-03-11 05:04 Message: Logged In: YES user_id=891004 Hi. Will nagios-plugins use this code? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1145413&group_id=29880 From ml at os2.kiev.ua Sun Oct 30 05:03:37 2005 From: ml at os2.kiev.ua (Alex Samorukov) Date: Sun Oct 30 05:03:37 2005 Subject: [Nagiosplug-devel] check_tcp and local sockets In-Reply-To: <20051030102715.GA14098@seanius.net> References: <4363BE44.2030505@os2.kiev.ua> <20051030102715.GA14098@seanius.net> Message-ID: <4364C456.7050707@os2.kiev.ua> sean finney wrote: >hey alex, > >On Sat, Oct 29, 2005 at 09:24:04PM +0300, Alex Samorukov wrote: > > >yeah. and that's what i get for making a code optimization without >double checking myself. anyway, both of these are fixed in cvs now. > > I updated my src tree to latest cvs. Now it seems that all work fine (i tested check_clamd and check_tcp). I found one minor problem. When using with local sockets i found that there is a timeout (~2sec) from starting of the command and before any output. I found that this happens because of request with socket name to DNS server. This patch will fix this: diff -u -r1.71 check_tcp.c --- check_tcp.c 30 Oct 2005 10:25:26 -0000 1.71 +++ check_tcp.c 30 Oct 2005 13:01:18 -0000 @@ -550,7 +550,7 @@ if (server_address == NULL) usage4 (_("You must provide a server address")); - else if (is_host (server_address) == FALSE && server_address[0] != '/') + else if (server_address[0] != '/' && is_host (server_address) == FALSE) usage2 (_("Invalid hostname, address, or socket"), server_address); return TRUE; >on a related note, i believe that providing this feature also provides >a much better/thorough way to test the tcp-based plugins. i don't know >much about how the test suite works, but it wouldn't be too hard to >write a test program that creates a unix domain socket and spoke >the proper things to the plugins... > > Sure. May be i`ll try to find some time and create daemon which will response on check_tcp commands. From noreply at sourceforge.net Sun Oct 30 12:04:54 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 30 12:04:54 2005 Subject: [Nagiosplug-devel] [ nagiosplug-New Plugins-1342716 ] email delivery plugin (smtp send and imap receive) Message-ID: New Plugins item #1342716, was opened at 2005-10-30 20:04 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1342716&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Perl plugin Group: None Status: Open Resolution: None Priority: 5 Submitted By: Jonathan Buhacoff (jbuhacoff) Assigned to: Nobody/Anonymous (nobody) Summary: email delivery plugin (smtp send and imap receive) Initial Comment: The email delivery plugin I wrote uses two other plugins (smtp send and imap receive), also included, to send a message to an email account and then check that account for the message and delete it. The plugin times how long it takes for the message to be delivered and the warning and critical thresholds are for this elapsed time. A few notes: 1. I tried to use the check_smtp plugin for sending mail. I can do it on the command line but I can't get the newlines to happen from the config file (\n doesn't seem to work so smtp server waits for the '.' but doesn't get it like it does when i use single quote and newlines from the command line). So if you know how to get the check_smtp plugin to send a message from the nagios config, that one could be used instead of the check_smtp_send plugin included here (and also please let me know, jonathan at pnc.net) 2. The check_smtp_send plugin I included lets you specify custom headers and body, and this is used by email delivery plugin. 3. The check_imap_receive plugin I included lets you search for a specific message in any mailbox via options, and this is used by email delivery plugin. The email delivery plugin could also be modified to use a POP account with a suitable plugin for checking pop (see "pop3(s) email matching plugin" by kkvenkit). If this is possible to do using the existing check_imap plugin please let me know how, I couldn't find any examples: jonathan at pnc.net 4. I looked at check_mail.pl by bledi51 and its pretty good, and also conforms better to nagios perl plugin guidelnes than mine does. So I'm going to be revising my plugins to conform more. 5. I think I made a mistake in the concept of using the email delivery plugin's options. Right now it takes very specific mail from / mail to options and connection options for the smtp and imap plugins. Maybe it would be better to accept just two options that are long strings which actually specify a complete plugin command-line to run (with the $USER1$ macro of course) and then use them a little more blindly. This might make it more difficult to generate unique id's for emails on the fly as is done now, but on the other hand I noticed after using the plugin for a while that using unique id's just means the email accumulates on the recipient account when a problem does occur. So this might change and I'll provide both options. 6. The plugin fails with UNKNOWN status code when required perl modules are missing, and it prints a list of missing modules, but when I view this on my nagios website it says "no output!", and i've tried printing the missing modules list on stdout and stderr, without success. So if anyone knows how to get status messages to show up when using UNKNOWN status code, please let me know: jonathan at pnc.net Finally, usage example from my own nagios config: define command{ command_name check_email_delivery command_line $USER1$/check_email_delivery -H $HOSTADDRESS$ --mailfrom $ARG3$ --mailto $ARG4$ -- username $ARG5$ --password $ARG6$ --libexec $USER1$ -w $ARG1$ -c $ARG2$ } define service{ use generic-service host_name mail.your.net service_description EMAIL DELIVERY check_command check_email_delivery!5!120! sender at your.net!recipient at your.net!recipient at your.net!password } References to similar plugins: pop3(s) email matching plugin by kkvenkit check_mail.pl by bledi51 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1342716&group_id=29880 From noreply at sourceforge.net Sun Oct 30 20:32:59 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 30 20:32:59 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1343135 ] patch for check_nmap to report incorrect tmp dir & more Message-ID: Bugs item #1343135, was opened at 2005-10-30 23:31 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1343135&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Submitted By: John Rouillard (rouilj) Assigned to: Nobody/Anonymous (nobody) Summary: patch for check_nmap to report incorrect tmp dir & more Initial Comment: Changes by rouilj-np at renesys.com. Patch generated against version 1.21 of check_nmap.py included in nagios-plugins version 1.4.2 If the temporary directory specified in the program is not present, check_nmap.py exits with a wierd error. My patch checks to make sure the temp directory exists and is writable. It generates a useful error message if not accessible. Temp directory changed to /var/spool/nagios/tmp. The UNKNOWN status exit code is set to 3 rather than -1. Updated script for python 2.x using random rather than whrandom. Added more debugging statements. One feature added: The -N option passes arguments directly to nmap. Useful for tuning nmap operation to allow the plugin to finish in less time than the default operating mode. -- rouilj ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1343135&group_id=29880 From noreply at sourceforge.net Sun Oct 30 20:42:55 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 30 20:42:55 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1343151 ] check_ssh needs to support multiple acceptable ssh versions Message-ID: Patches item #1343151, was opened at 2005-10-30 23:42 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1343151&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None Status: Open Resolution: None Priority: 5 Submitted By: John Rouillard (rouilj) Assigned to: Nobody/Anonymous (nobody) Summary: check_ssh needs to support multiple acceptable ssh versions Initial Comment: From: rouilj-np at renesys.com Patch against check_ssh version 1.27 in nagios-plugins version 1.4.2. The -r flag to check_ssh is used to specify a version string to be matched in the ssh banner. If the string doesn't match a warning is returned. It is useful to specify multiple valid banners so that non-buggy but older versions of ssh can be recognized and accepted. This patch allows the -r flag to be specified multiple times and all version strings will be cmpared to the one returned by the ssh daemon. If none of the strings match WARNING is returned. If one of the strings matches, no warning is generated from the version check section of the code. -- rouilj ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1343151&group_id=29880 From noreply at sourceforge.net Sun Oct 30 20:50:54 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 30 20:50:54 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1343159 ] check_dns doesn't support warning and critical response time Message-ID: Patches item #1343159, was opened at 2005-10-30 23:49 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1343159&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None Status: Open Resolution: None Priority: 5 Submitted By: John Rouillard (rouilj) Assigned to: Nobody/Anonymous (nobody) Summary: check_dns doesn't support warning and critical response time Initial Comment: From: rouilj-np at renesys.com Patch against check_dns version 1.47 included with nagios-plugins 1.4.2. check_dns doesn't support warning and critical levels on response time for query. This patch adds -w and -c to set floating point warning and critical response times. -- rouilj ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1343159&group_id=29880 From noreply at sourceforge.net Sun Oct 30 20:58:33 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 30 20:58:33 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1343166 ] check_test program control exit status with external file Message-ID: Patches item #1343166, was opened at 2005-10-30 23:58 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1343166&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None Status: Open Resolution: None Priority: 5 Submitted By: John Rouillard (rouilj) Assigned to: Nobody/Anonymous (nobody) Summary: check_test program control exit status with external file Initial Comment: rouilj-np at renesys.com A quick and dirty test program similar to check_dummy, but the exit status is controllable from an external file. This makes it much easier to use for testing service interactions when deploying or testing new nagios installation. It has been used for testing nagios service dependency and host dependency notification and suppression under various senarios. Entries in the external file are composed of a label and an exit code, or code list seperated by an = sign. The exit code list is any 1, 2 or 3 digit number which will exit with that status (0, 1, 2 and 3 are valid for nagios). The code 'S' or 's' will cause the process to sleep for 1 hour in the expectation that it will recieve a kill signal from nagios. Directions for use are at the top of the file. -- rouilj ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1343166&group_id=29880 From noreply at sourceforge.net Sun Oct 30 21:04:07 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Sun Oct 30 21:04:07 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1343171 ] script for controlling commands under check_by_ssh Message-ID: Patches item #1343171, was opened at 2005-10-31 00:03 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1343171&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: John Rouillard (rouilj) Assigned to: Nobody/Anonymous (nobody) Summary: script for controlling commands under check_by_ssh Initial Comment: rouilj-np at renesys.com This perl script is intended to be run as a forced command under ssh. It is used to limit the command that can be run under the account to those command listed in the file and in the nagios plugin directory. -- rouilj ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1343171&group_id=29880 From noreply at sourceforge.net Mon Oct 31 00:24:39 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 31 00:24:39 2005 Subject: [Nagiosplug-devel] [ nagiosplug-New Plugins-1187892 ] Send mails to specified server, check them, and delete them Message-ID: New Plugins item #1187892, was opened at 2005-04-22 07:56 Message generated for change (Settings changed) made by bledi51 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1187892&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Perl plugin Group: None Status: Open Resolution: None Priority: 5 Submitted By: bledi51 (bledi51) Assigned to: Nobody/Anonymous (nobody) >Summary: Send mails to specified server, check them, and delete them Initial Comment: Send mails to specified server, check them, and delete them check_mail.pl -H host -f addsender -t addrecpt -u user -p poppass -n nbrmail -w warningvalue [-v] check_mail.pl --version check_mail.pl --help Required Arguments: -H, --host=HOST The name or address of the mail server. -f, --from The sender address -t, --to The recipient address -u, --user The user -p, --pass The pop password -w, --warning The warning value < number of mail send -n; --mailnbr The number of mail send to the server -v; --verbose Verbose, more informations -T; --timeout Number of seconds to wait for a response ---------------------------------------------------------------------- Comment By: Jonathan Buhacoff (jbuhacoff) Date: 2005-10-30 01:28 Message: Logged In: YES user_id=1370225 I wish I had seen this before!!! ---------------------------------------------------------------------- Comment By: Jonathan Buhacoff (jbuhacoff) Date: 2005-10-30 01:27 Message: Logged In: YES user_id=1370225 I wish I had seen this before!!! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1187892&group_id=29880 From noreply at sourceforge.net Mon Oct 31 00:26:34 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 31 00:26:34 2005 Subject: [Nagiosplug-devel] [ nagiosplug-New Plugins-1187892 ] check_mail.pl \ check mails server Message-ID: New Plugins item #1187892, was opened at 2005-04-22 07:56 Message generated for change (Settings changed) made by bledi51 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1187892&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Perl plugin Group: None Status: Open Resolution: None Priority: 5 Submitted By: bledi51 (bledi51) Assigned to: Nobody/Anonymous (nobody) >Summary: check_mail.pl \ check mails server Initial Comment: Send mails to specified server, check them, and delete them check_mail.pl -H host -f addsender -t addrecpt -u user -p poppass -n nbrmail -w warningvalue [-v] check_mail.pl --version check_mail.pl --help Required Arguments: -H, --host=HOST The name or address of the mail server. -f, --from The sender address -t, --to The recipient address -u, --user The user -p, --pass The pop password -w, --warning The warning value < number of mail send -n; --mailnbr The number of mail send to the server -v; --verbose Verbose, more informations -T; --timeout Number of seconds to wait for a response ---------------------------------------------------------------------- Comment By: Jonathan Buhacoff (jbuhacoff) Date: 2005-10-30 01:28 Message: Logged In: YES user_id=1370225 I wish I had seen this before!!! ---------------------------------------------------------------------- Comment By: Jonathan Buhacoff (jbuhacoff) Date: 2005-10-30 01:27 Message: Logged In: YES user_id=1370225 I wish I had seen this before!!! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1187892&group_id=29880 From tonvoon at mac.com Mon Oct 31 02:23:56 2005 From: tonvoon at mac.com (Ton Voon) Date: Mon Oct 31 02:23:56 2005 Subject: [Nagiosplug-devel] check_tcp and local sockets In-Reply-To: <20051030102715.GA14098@seanius.net> References: <4363BE44.2030505@os2.kiev.ua> <20051030102715.GA14098@seanius.net> Message-ID: <0BE6C05D-9D46-468F-85AD-0569139AE59C@mac.com> On 30 Oct 2005, at 10:27, sean finney wrote: > on a related note, i believe that providing this feature also provides > a much better/thorough way to test the tcp-based plugins. i don't > know > much about how the test suite works, but it wouldn't be too hard to > write a test program that creates a unix domain socket and spoke > the proper things to the plugins... > Interesting idea. The local daemon would accept requests as if it was over the network and respond accordingly. However, it will probably mean that the local daemon will end up looking like the actual service, in which case we should just use an actual service on the internet to run against. I've been thinking that we need to enhance the testcases and get more continuous builds. Have spoken to Peter Bray about this, but there's not much movement, so I'm interested in getting a Tinderbox setup for this. Will work on this over the next few weeks. Ton -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at sourceforge.net Mon Oct 31 05:55:16 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 31 05:55:16 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1338298 ] check_linux_raid plugin does not recognize recovery Message-ID: Patches item #1338298, was opened at 2005-10-26 12:09 Message generated for change (Comment added) made by bastiaan You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1338298&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None Status: Open Resolution: None Priority: 5 Submitted By: Bastiaan Bakker (bastiaan) Assigned to: Nobody/Anonymous (nobody) Summary: check_linux_raid plugin does not recognize recovery Initial Comment: The check_linux_raid plugin does not properly parse /proc/mdstat, causing it to report CRITICAL status for RAID devices that are already recovering. For example it reports CRITICAL for the following /proc/mdstat (taken from a CentOS 3.5 box): Personalities : [raid1] read_ahead 1024 sectors Event: 8 md0 : active raid1 sdb1[2] sda1[1] 2097024 blocks [2/1] [_U] [>....................] recovery = 0.4% (10168/2097024) finish=23.8min speed=1452K/sec unused devices: The attached patch fixes two bugs which cause this problem: 1) do not stop parsing after [_U] but until the next mdX entry begins, so we won't miss the 'recovery line' 2) allow two or more spaces after 'recovery =' in order to recognize single digit percentages Other modifications: 1) Addition of 'speed=' to the output: WARNING md0 status=[_U], recovery=0.4%, finish=23.8min, speed=1452K/sec 2) Addition of optionally specification of mdstat file as second command line parameter. Primarily useful for debugging. ---------------------------------------------------------------------- >Comment By: Bastiaan Bakker (bastiaan) Date: 2005-10-31 14:54 Message: Logged In: YES user_id=8050 replaced diff with new version: * fixes output so that nrpe understands it. * implements --help and --version command line params. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1338298&group_id=29880 From noreply at sourceforge.net Mon Oct 31 06:17:06 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 31 06:17:06 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1343151 ] check_ssh needs to support multiple acceptable ssh versions Message-ID: Patches item #1343151, was opened at 2005-10-30 23:42 Message generated for change (Comment added) made by rouilj You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1343151&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None Status: Open Resolution: None Priority: 5 Submitted By: John Rouillard (rouilj) Assigned to: Nobody/Anonymous (nobody) Summary: check_ssh needs to support multiple acceptable ssh versions Initial Comment: From: rouilj-np at renesys.com Patch against check_ssh version 1.27 in nagios-plugins version 1.4.2. The -r flag to check_ssh is used to specify a version string to be matched in the ssh banner. If the string doesn't match a warning is returned. It is useful to specify multiple valid banners so that non-buggy but older versions of ssh can be recognized and accepted. This patch allows the -r flag to be specified multiple times and all version strings will be cmpared to the one returned by the ssh daemon. If none of the strings match WARNING is returned. If one of the strings matches, no warning is generated from the version check section of the code. -- rouilj ---------------------------------------------------------------------- >Comment By: John Rouillard (rouilj) Date: 2005-10-31 09:16 Message: Logged In: YES user_id=707416 This time I will attach the patch that actually works and not the earlier version. 8-) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1343151&group_id=29880 From bohara at gmail.com Mon Oct 31 07:06:43 2005 From: bohara at gmail.com (Ben O'Hara) Date: Mon Oct 31 07:06:43 2005 Subject: [Nagiosplug-devel] Fwd: check_disk with inode usage? In-Reply-To: <2b36e660510310628k70d777cdg4c6ba6885301cdfe@mail.gmail.com> References: <2b36e660510310622p6f7fb360s127ed7c2773b159d@mail.gmail.com> <2b36e660510310628k70d777cdg4c6ba6885301cdfe@mail.gmail.com> Message-ID: <2b36e660510310705m58592259o3498028a80bc3233@mail.gmail.com> So, I found the original patch and have attached a patch against the latest HEAD release of check_disk.c This appears to work with no problems from limited testing on solaris 7,8,9 boxes. Could this be applied to CVS? Regards Ben ---------- Forwarded message ---------- From: Ben O'Hara Date: Oct 31, 2005 2:28 PM Subject: Re: check_disk with inode usage? To: nagiosplug-help at lists.sourceforge.net And to followup on my own post, the tracker item is at https://sourceforge.net/tracker/?func=detail&atid=397599&aid=995761&group_id=29880 Doesnt look like it ever got actioned...any reason? Can it be mergted into CVS? Ben On 10/31/05, Ben O'Hara wrote: > Hey Guys, > > Ive installed nagiosgraph, and their "map" file mentions a check_disk > patch which also checks inode usage. > > Im currently using seperate checks for both disk/inode usage and would > like to merge them into one check. > > Anyone know anything about this patch? Looks to have been submitted > back in 2004 but ive checked out the latest cvs head and it doesnt > seem to be included. > > ./plugins/check_disk.c contains > > /* If nonzero, show inode information. */ > /* static int inode_format; */ > > Although these are obviously commented out i cant find any other > mention of inode or inode_format in the code. > > Did this ever get patched into CVS? > > Cheers > > Ben > -- > "There are 10 types of IT people. Those who understand binary and > those who don't." > -- "There are 10 types of IT people. Those who understand binary and those who don't." -- "There are 10 types of IT people. Those who understand binary and those who don't." -------------- next part -------------- 26a27,31 > /* > * Additional inode code by Jorgen Lundman > */ > > 42c47 < /* static int inode_format; */ --- > static int inode_format; 71a77,78 > double w_idfp; > double c_idfp; 117,118c124,125 < int validate_arguments (uintmax_t, uintmax_t, double, double, char *); < int check_disk (double usp, double free_disk); --- > int validate_arguments (uintmax_t, uintmax_t, double, double, double, double, char *); > int check_disk (double usp, uintmax_t free_disk, double uisp); 126a134,135 > double w_idfp = -1.0; > double c_idfp = -1.0; 143c152 < double usp = -1.0; --- > double usp = -1.0, uisp = -1.0; 151c160 < float free_space, free_space_pct, total_space; --- > float free_space, free_space_pct, total_space, inode_space_pct; 223c232,235 < disk_result = check_disk (usp, (double)(fsp.fsu_bavail * fsp.fsu_blocksize / mult)); --- > uisp = (double)(fsp.fsu_files - fsp.fsu_ffree) * 100 / fsp.fsu_files; > disk_result = check_disk (usp, fsp.fsu_bavail, uisp); > > 225a238,244 > > > /* Moved this computation up here so we can add it > * to perf */ > inode_space_pct = (float)fsp.fsu_ffree*100/fsp.fsu_files; > > 231c250,251 < TRUE, 0, --- > TRUE, inode_space_pct, > 240c260 < asprintf (&output, ("%s %s %.0f %s (%.0f%%);"), --- > asprintf (&output, ("%s %s %.0f %s (%.0f%% inode=%.0f%%);"), 245c265,267 < free_space_pct); --- > free_space_pct, > inode_space_pct); > 247,248c269,270 < %.0f of %.0f %s (%.0f%%) free on %s (type %s mounted on %s) warn:%lu crit:%lu warn%%:%.0f%% crit%%:%.0f%%"), < details, free_space, total_space, units, free_space_pct, --- > %.0f of %.0f %s (%.0f%% inode=%.0f%%) free on %s (type %s mounted on %s) warn:%lu crit:%lu warn%%:%.0f%% crit%%:%.0f%%"), > details, free_space, total_space, units, free_space_pct, inode_space_pct, 250a273 > 294a318,320 > {"iwarning", required_argument, 0, 'W'}, > /* Dang, -C is taken. We might want to reshuffle this. */ > {"icritical", required_argument, 0, 'K'}, 329c355 < c = getopt_long (argc, argv, "+?VqhveCt:c:w:u:p:x:X:mklM", longopts, &option); --- > c = getopt_long (argc, argv, "+?VqhveCt:c:w:K:W:u:p:x:X:mklM", longopts, &option); 376a403,418 > > > case 'W': /* warning inode threshold */ > if (strstr (optarg, "%") && sscanf (optarg, "%lf%%", &w_idfp) == 1) { > break; > } > else { > usage (_("Warning inode threshold must be percentage!\n")); > } > case 'K': /* kritical inode threshold */ > if (strstr (optarg, "%") && sscanf (optarg, "%lf%%", &c_idfp) == 1) { > break; > } > else { > usage (_("Critical inode threshold must be percentage!\n")); > } 433,436c475,483 < se->w_df = 0; < se->c_df = 0; < se->w_dfp = -1.0; < se->c_dfp = -1.0; --- > > /* If you don't clear the w_fd etc values here, they > * get processed when you walk the list and assigned > * to the global w_df! > */ > se->w_df = 0; > se->c_df = 0; > se->w_dfp = 0; > se->c_dfp = 0; 446,449c493,500 < se->w_df = 0; < se->c_df = 0; < se->w_dfp = -1.0; < se->c_dfp = -1.0; --- > /* If you don't clear the w_fd etc values here, they > * get processed when you walk the list and assigned > * to the global w_df! > */ > se->w_df = 0; > se->c_df = 0; > se->w_dfp = 0; > se->c_dfp = 0; 511a563,564 > temp_list->w_idfp, > temp_list->c_idfp, 518c571 < return validate_arguments (w_df, c_df, w_dfp, c_dfp, NULL); --- > return validate_arguments (w_df, c_df, w_dfp, c_dfp, w_idfp, c_idfp, NULL); 538c591 < validate_arguments (uintmax_t w, uintmax_t c, double wp, double cp, char *mypath) --- > validate_arguments (uintmax_t w, uintmax_t c, double wp, double cp, double iwp, double icp, char *mypath) 552a606,613 > else if ((iwp >= 0.0 || icp >= 0.0) && > (iwp < 0.0 || icp < 0.0 || iwp > 100.0 || icp > 100.0 || icp > iwp)) { > printf (_("\ > INPUT ERROR: C_IDFP (%f) should be less than W_IDFP (%.1f) and both should be between zero and 100 percent, inclusive"), > icp, iwp); > print_path (mypath); > return ERROR; > } 571c632,633 < check_disk (double usp, double free_disk) --- > > check_disk (double usp, uintmax_t free_disk, double uisp) 573,583c635,649 < int result = STATE_UNKNOWN; < /* check the percent used space against thresholds */ < if (usp >= 0.0 && c_dfp >=0.0 && usp >= (100.0 - c_dfp)) < result = STATE_CRITICAL; < else if (c_df > 0 && free_disk <= c_df) < result = STATE_CRITICAL; < else if (usp >= 0.0 && w_dfp >=0.0 && usp >= (100.0 - w_dfp)) < result = STATE_WARNING; < else if (w_df > 0 && free_disk <= w_df) < result = STATE_WARNING; < else if (usp >= 0.0) --- > int result = STATE_UNKNOWN; > /* check the percent used space against thresholds */ > if (usp >= 0.0 && c_dfp >=0.0 && usp >= (100.0 - c_dfp)) > result = STATE_CRITICAL; > else if (uisp >= 0.0 && c_idfp >=0.0 && uisp >= (100.0 - c_idfp)) > result = STATE_CRITICAL; > else if (c_df > 0 && free_disk <= c_df) > result = STATE_CRITICAL; > else if (usp >= 0.0 && w_dfp >=0.0 && usp >= (100.0 - w_dfp)) > result = STATE_WARNING; > else if (uisp >= 0.0 && w_idfp >=0.0 && uisp >= (100.0 - w_idfp)) > result = STATE_WARNING; > else if (w_df > 0 && free_disk <= w_df) > result = STATE_WARNING; > else if (usp >= 0.0) 637a704,707 > -W, --iwarning=PERCENT%%\n\ > Exit with WARNING status if less than PERCENT of inode space is free\n\ > -K, --icritical=PERCENT%%\n\ > Exit with CRITICAL status if less than PERCENT of inode space is free\n\ 686c756 < Usage: %s -w limit -c limit [-p path | -x device] [-t timeout] [-m] [-e]\n\ --- > Usage: %s -w limit -c limit [-p path | -x device] [-t timeout] [-m] [-e] [-W limit] [-K limit]\n\ From seanius at seanius.net Mon Oct 31 09:25:42 2005 From: seanius at seanius.net (sean finney) Date: Mon Oct 31 09:25:42 2005 Subject: [Nagiosplug-devel] Fwd: check_disk with inode usage? In-Reply-To: <2b36e660510310705m58592259o3498028a80bc3233@mail.gmail.com> References: <2b36e660510310622p6f7fb360s127ed7c2773b159d@mail.gmail.com> <2b36e660510310628k70d777cdg4c6ba6885301cdfe@mail.gmail.com> <2b36e660510310705m58592259o3498028a80bc3233@mail.gmail.com> Message-ID: <20051031172422.GA31050@seanius.net> hi ben, On Mon, Oct 31, 2005 at 03:05:44PM +0000, Ben O'Hara wrote: > https://sourceforge.net/tracker/?func=detail&atid=397599&aid=995761&group_id=29880 i'll take a look at it when i have some time in the next week or two. in the meantime, do you think you could throw me the patch in diff -u format? thanks, sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: From bohara at gmail.com Mon Oct 31 10:24:53 2005 From: bohara at gmail.com (Ben O'Hara) Date: Mon Oct 31 10:24:53 2005 Subject: [Nagiosplug-devel] Fwd: check_disk with inode usage? In-Reply-To: <20051031172422.GA31050@seanius.net> References: <2b36e660510310622p6f7fb360s127ed7c2773b159d@mail.gmail.com> <2b36e660510310628k70d777cdg4c6ba6885301cdfe@mail.gmail.com> <2b36e660510310705m58592259o3498028a80bc3233@mail.gmail.com> <20051031172422.GA31050@seanius.net> Message-ID: <2b36e660510311024m390838c1n4bda10788d8a4b71@mail.gmail.com> On 10/31/05, sean finney wrote: > hi ben, > > On Mon, Oct 31, 2005 at 03:05:44PM +0000, Ben O'Hara wrote: > > https://sourceforge.net/tracker/?func=detail&atid=397599&aid=995761&group_id=29880 > > i'll take a look at it when i have some time in the next week or two. > in the meantime, do you think you could throw me the patch in diff -u > format? > > thanks, > sean > Cheers Sean, Ive attached a copy of the patch, its against the latest snapshot of HEAD. Ive got it running on Sol7,8,9 and FreeBSD4,5 machines and it appears to be reporting back the correct info as far as inode usage is concerned, and it doesnt appear to have broken the disk reporting. Give me a shout if you have any questions and thanks for the great work! Ben > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.2.4 (GNU/Linux) > > iD8DBQFDZlNGynjLPm522B0RAjwZAJ9if9J7kQGedbePKhxtVpUeaWxNjgCgh7aZ > imtsLfo+pxQxiJ77RKHKB6U= > =DBtK > -----END PGP SIGNATURE----- > > > -- "There are 10 types of IT people. Those who understand binary and those who don't." -------------- next part -------------- A non-text attachment was scrubbed... Name: check_disk.c.patch Type: application/octet-stream Size: 11036 bytes Desc: not available URL: From noreply at sourceforge.net Mon Oct 31 10:43:09 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 31 10:43:09 2005 Subject: [Nagiosplug-devel] [ nagiosplug-New Plugins-1187892 ] check_mail.pl \ check mails server Message-ID: New Plugins item #1187892, was opened at 2005-04-22 03:56 Message generated for change (Comment added) made by rouilj You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1187892&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Perl plugin Group: None Status: Open Resolution: None Priority: 5 Submitted By: bledi51 (bledi51) Assigned to: Nobody/Anonymous (nobody) Summary: check_mail.pl \ check mails server Initial Comment: Send mails to specified server, check them, and delete them check_mail.pl -H host -f addsender -t addrecpt -u user -p poppass -n nbrmail -w warningvalue [-v] check_mail.pl --version check_mail.pl --help Required Arguments: -H, --host=HOST The name or address of the mail server. -f, --from The sender address -t, --to The recipient address -u, --user The user -p, --pass The pop password -w, --warning The warning value < number of mail send -n; --mailnbr The number of mail send to the server -v; --verbose Verbose, more informations -T; --timeout Number of seconds to wait for a response ---------------------------------------------------------------------- Comment By: John Rouillard (rouilj) Date: 2005-10-31 13:41 Message: Logged In: YES user_id=707416 Just out of curiosity how does this differ from contrib/check_email_loop.pl? Help for check_email_loop is: This script sends a mail with a specific id in the subject via an given smtp-server to a given email-adress. When the script is run again, it checks for this Email (with its unique id) on a given pop3 account and sends another mail. The following options are available: -from=text email adress of send (for mail returnr on errors) -to=text email adress to which the mails should send to -pophost=text IP or name of the POP3-host to be checked -popuser=text Username of the POP3-account -passwd=text Password for the POP3-user -poptimeout=num Timeout in seconds for the POP3-server -smtphost=text IP oder name of the SMTP host -smtptimeout=num Timeout in seconds for the SMTP-server -statfile=text File to save ids of messages (check_email_loop.stat) -interval=num Time (in minutes) that must pass by before sending another Ping-mail (gibe a new try); -lostwarn=num WARNING-state if more than num lost emails -lostcrit=num CRITICAL -pendwarn=num WARNING-state if more than num pending emails -pendcrit=num CRITICAL -maxmsg=num WARNING if more than num emails on POP3 (default 50) -keeporphaned Set this to NOT delete orphaned E-Mail Ping msg from POP3 -debug send SMTP tranaction info to stderr Options may abbreviated! LOST mails are mails, being sent before the last mail arrived back. PENDING mails are those, which are not. (supposed to be on the way) Example: BUILD/nagios-plugins-1.4.2/contrib/check_email_loop.pl -poph=host -pa=pw -popu=popts -smtph=host -from=root at me.com -to=remailer at testxy.com -lostc=0 -pendc=2 ---------------------------------------------------------------------- Comment By: Jonathan Buhacoff (jbuhacoff) Date: 2005-10-29 21:28 Message: Logged In: YES user_id=1370225 I wish I had seen this before!!! ---------------------------------------------------------------------- Comment By: Jonathan Buhacoff (jbuhacoff) Date: 2005-10-29 21:27 Message: Logged In: YES user_id=1370225 I wish I had seen this before!!! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=541465&aid=1187892&group_id=29880 From rajo at platon.sk Mon Oct 31 13:23:00 2005 From: rajo at platon.sk (Lubomir Host) Date: Mon Oct 31 13:23:00 2005 Subject: [Nagiosplug-devel] PATCH: SMTP auth support in nagios plugin check_smtp.c Message-ID: <20051031212222.GD32185@platon.sk> Hi developers! Here is a patch that adds the ability to confirm that your SMTP AUTH mechanism is working on your smtp server. First version of this kind of patch was sent to mailinglist 2003-07-31. Check following links: http://sourceforge.net/mailarchive/forum.php?thread_id=2876441&forum_id=8499 http://sourceforge.net/mailarchive/forum.php?thread_id=2876984&forum_id=8499 Why this patch was never included? My new version is rewritten. SMTP AUTH now works with SSL/TLS and also withouth TLS. Patch is againts fresh CVS version. Please, apply ASAP. Thanks rajo -- Lubomir Host 'rajo' ICQ #: 257322664 ,''`. Platon Software Development Group http://platon.sk/ : :' : Homepage: http://rajo.platon.sk/en/references `. `' http://www.gnu.org/philosophy/no-word-attachments.html `- -------------- next part -------------- Index: check_smtp.c =================================================================== RCS file: /cvsroot/nagiosplug/nagiosplug/plugins/check_smtp.c,v retrieving revision 1.49 diff -u -r1.49 check_smtp.c --- check_smtp.c 19 Oct 2005 20:22:00 -0000 1.49 +++ check_smtp.c 31 Oct 2005 20:58:30 -0000 @@ -45,6 +45,7 @@ #define SMTP_EHLO "EHLO " #define SMTP_QUIT "QUIT\r\n" #define SMTP_STARTTLS "STARTTLS\r\n" +#define SMTP_AUTH_LOGIN "AUTH LOGIN\r\n" #ifndef HOST_MAX_BYTES #define HOST_MAX_BYTES 255 @@ -82,6 +83,9 @@ int response_size=0; char **commands = NULL; char **responses = NULL; +char *authtype = NULL; +char *authuser = NULL; +char *authpass = NULL; int warning_time = 0; int check_warning_time = FALSE; int critical_time = 0; @@ -99,6 +103,47 @@ MAXBUF = 1024 }; +/* written by lauri alanko */ +static char * +base64 (const char *bin, size_t len) +{ + + char *buf = (char *) malloc ((len + 2) / 3 * 4 + 1); + size_t i = 0, j = 0; + + char BASE64_END = '='; + char base64_table[64]; + strncpy (base64_table, "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/", 64); + + while (j < len - 2) { + buf[i++] = base64_table[bin[j] >> 2]; + buf[i++] = base64_table[((bin[j] & 3) << 4) | (bin[j + 1] >> 4)]; + buf[i++] = base64_table[((bin[j + 1] & 15) << 2) | (bin[j + 2] >> 6)]; + buf[i++] = base64_table[bin[j + 2] & 63]; + j += 3; + } + + switch (len - j) { + case 1: + buf[i++] = base64_table[bin[j] >> 2]; + buf[i++] = base64_table[(bin[j] & 3) << 4]; + buf[i++] = BASE64_END; + buf[i++] = BASE64_END; + break; + case 2: + buf[i++] = base64_table[bin[j] >> 2]; + buf[i++] = base64_table[((bin[j] & 3) << 4) | (bin[j + 1] >> 4)]; + buf[i++] = base64_table[(bin[j + 1] & 15) << 2]; + buf[i++] = BASE64_END; + break; + case 0: + break; + } + + buf[i] = '\0'; + return buf; +} + int main (int argc, char **argv) { @@ -109,6 +154,7 @@ int result = STATE_UNKNOWN; char *cmd_str = NULL; char *helocmd = NULL; + char *error_msg = NULL; struct timeval tv; struct hostent *hp; @@ -293,6 +339,92 @@ n++; } + if (authtype != NULL) { + if (strcmp (authtype, "LOGIN") == 0) { + char *abuf; + int ret; + do { + if (authuser == NULL) { + result = STATE_CRITICAL; + error_msg = _("no authuser specified, "); + break; + } + if (authpass == NULL) { + result = STATE_CRITICAL; + error_msg = _("no authpass specified, "); + break; + } + + /* send AUTH LOGIN */ + my_send(SMTP_AUTH_LOGIN, strlen(SMTP_AUTH_LOGIN)); + if (verbose) + printf (_("sent %s\n"), "AUTH LOGIN"); + + if((ret = my_recv(buffer, MAXBUF - 1)) < 0){ + error_msg = _("recv() failed after AUTH LOGIN, \n"); + result = STATE_WARNING; + break; + } + buffer[ret] = 0; + if (verbose) + printf (_("received %s\n"), buffer); + + if (strncmp (buffer, "334", 3) != 0) { + result = STATE_CRITICAL; + error_msg = _("invalid response received after AUTH LOGIN, "); + break; + } + + /* encode authuser with base64 */ + abuf = base64 (authuser, strlen(authuser)); + strcat (abuf, "\r\n"); + my_send(abuf, strlen(abuf)); + if (verbose) + printf (_("sent %s\n"), abuf); + + if ((ret = my_recv(buffer, MAX_INPUT_BUFFER-1)) == -1) { + result = STATE_CRITICAL; + error_msg = _("recv() failed after sending authuser, "); + break; + } + buffer[ret] = 0; + if (verbose) { + printf (_("received %s\n"), buffer); + } + if (strncmp (buffer, "334", 3) != 0) { + result = STATE_CRITICAL; + error_msg = _("invalid response received after authuser, "); + break; + } + /* encode authpass with base64 */ + abuf = base64 (authpass, strlen(authpass)); + strcat (abuf, "\r\n"); + my_send(abuf, strlen(abuf)); + if (verbose) { + printf (_("sent %s\n"), abuf); + } + if ((ret = my_recv(buffer, MAX_INPUT_BUFFER-1)) == -1) { + result = STATE_CRITICAL; + error_msg = _("recv() failed after sending authpass, "); + break; + } + buffer[ret] = 0; + if (verbose) { + printf (_("received %s\n"), buffer); + } + if (strncmp (buffer, "235", 3) != 0) { + result = STATE_CRITICAL; + error_msg = _("invalid response received after authpass, "); + break; + } + break; + } while (0); + } else { + result = STATE_CRITICAL; + error_msg = _("only authtype LOGIN is supported, "); + } + } + /* tell the server we're done */ my_send (SMTP_QUIT, strlen (SMTP_QUIT)); @@ -313,13 +445,15 @@ result = STATE_WARNING; } - printf (_("SMTP %s - %.3f sec. response time%s%s|%s\n"), - state_text (result), elapsed_time, - verbose?", ":"", verbose?buffer:"", - fperfdata ("time", elapsed_time, "s", - (int)check_warning_time, warning_time, - (int)check_critical_time, critical_time, - TRUE, 0, FALSE, 0)); + printf (_("SMTP %s - %s%.3f sec. response time%s%s|%s\n"), + state_text (result), + (error_msg == NULL ? "" : error_msg), + elapsed_time, + verbose?", ":"", verbose?buffer:"", + fperfdata ("time", elapsed_time, "s", + (int)check_warning_time, warning_time, + (int)check_critical_time, critical_time, + TRUE, 0, FALSE, 0)); return result; } @@ -342,6 +476,9 @@ {"port", required_argument, 0, 'p'}, {"from", required_argument, 0, 'f'}, {"fqdn", required_argument, 0, 'F'}, + {"authtype", required_argument, 0, 'A'}, + {"authuser", required_argument, 0, 'U'}, + {"authpass", required_argument, 0, 'P'}, {"command", required_argument, 0, 'C'}, {"response", required_argument, 0, 'R'}, {"nocommand", required_argument, 0, 'n'}, @@ -368,7 +505,7 @@ } while (1) { - c = getopt_long (argc, argv, "+hVv46t:p:f:e:c:w:H:C:R:SD:F:", + c = getopt_long (argc, argv, "+hVv46t:p:f:e:c:w:H:C:R:SD:F:A:U:P:", longopts, &option); if (c == -1 || c == EOF) @@ -397,6 +534,15 @@ from_arg = optarg; smtp_use_dummycmd = 1; break; + case 'A': + authtype = optarg; + break; + case 'U': + authuser = optarg; + break; + case 'P': + authpass = optarg; + break; case 'e': /* server expect string on 220 */ server_expect = optarg; break; @@ -562,6 +708,15 @@ Use STARTTLS for the connection.\n")); #endif + printf("\ + -A, --authtype=STRING\n\ + SMTP AUTH type to check (default none, only LOGIN supported)\n\ + -U, --authuser=STRING\n\ + SMTP AUTH username\n\ + -P, --authpass=STRING\n\ + SMTP AUTH password\n\ + "); + printf (_(UT_WARN_CRIT)); printf (_(UT_TIMEOUT), DEFAULT_SOCKET_TIMEOUT); @@ -584,6 +739,7 @@ { printf ("\ Usage: %s -H host [-p port] [-e expect] [-C command] [-f from addr]\n\ + [-A authtype -U authuser -P authpass]\n\ [-w warn] [-c crit] [-t timeout] [-S] [-D days] [-n] [-v] [-4|-6]\n", progname); } From noreply at sourceforge.net Mon Oct 31 22:44:58 2005 From: noreply at sourceforge.net (SourceForge.net) Date: Mon Oct 31 22:44:58 2005 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1344584 ] check_snmp Counter64 values not handled correctly Message-ID: Bugs item #1344584, was opened at 2005-10-31 22:44 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1344584&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: snapshot tarball Status: Open Resolution: None Priority: 5 Submitted By: prjctgeek (prjctgeek) Assigned to: Nobody/Anonymous (nobody) Summary: check_snmp Counter64 values not handled correctly Initial Comment: After adding this snippet at line 253 else if (strstr (response, "Counter64: ")) { show = strstr (response, "Counter64: ") + 11; } and at 285-to show long longs asprintf (&show, "%llu", response_value[i]); the comparison of Counter64 values to the warning and critical ranges still do not function correctly. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1344584&group_id=29880 From seanius at seanius.net Mon Oct 31 23:19:07 2005 From: seanius at seanius.net (sean finney) Date: Mon Oct 31 23:19:07 2005 Subject: [Nagiosplug-devel] PATCH: SMTP auth support in nagios plugin check_smtp.c In-Reply-To: <20051031212222.GD32185@platon.sk> References: <20051031212222.GD32185@platon.sk> Message-ID: <20051101071827.GA6168@seanius.net> hi, On Mon, Oct 31, 2005 at 10:22:22PM +0100, Lubomir Host wrote: > > http://sourceforge.net/mailarchive/forum.php?thread_id=2876441&forum_id=8499 > http://sourceforge.net/mailarchive/forum.php?thread_id=2876984&forum_id=8499 > > Why this patch was never included? probably dropped off the radar and no one made any noise about it. i'll take a look at it the next time i'm sitting down with a cvs copy. sean -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: