[Nagiosplug-devel] Nagios::Plugin thresholds

[Vonnahme, Nathan]

> -----Original Message-----
> From: nagiosplug-devel-bounces at lists.sourceforge.net 
> [mailto:nagiosplug-devel-bounces at lists.sourceforge.net] On 
> Behalf Of Gavin Carr
> Sent: Thursday, September 07, 2006 3:20 PM

> More on check_threshold, I think we should make 'warning' and 
> 'critical'
> default to $plugin->opt('warning') and 
> $plugin->opt('critical') if those
> are defined, as that's likely to be far and away the common use case.
> That would mean your example above just becomes:
> 
>     my $return_status = $plugin->check_threshold( check => $value );
>     $plugin->nagios_exit( $return_status, $message );
> 
> Maybe we should allow:
> 
>     my $return_status = $plugin->check_threshold( $value );
> 
> for that case as well?
> 
> So does this mean you're putting your hand up to implement 
> this Nathan? ;-)
>   

I'd be happy to take a crack at it after November 1, but I won't be able
to until then.




> > On a side note, Gavin, is there any problem with 
> standardizing on one
> > spelling of license/licence in Getopt.pm ?
> 
> Er, well I speak the Queen's English, in which licence is the 
> noun, and 
> license is the verb. I like helping American's understand 
> that there's is
> not the only brand on the planet, but I'm not _too_ much of a 
> linguistic
> Nazi. ;-)
> 
> So no, if you want to Americanise it I don't really care.



Ah.  I had never noticed that verb/noun distinction!  I thought it was
just half American spelling and half Queen's and was going to
s/licen[cs]/licens/gi to minimize future confusion.

But this paragraph is still inconsistent, I think:


=item license

License text, included in the longer --help output (see below for an 
example). By default, this is set to the standard nagios plugins
GPL licence text:

  This nagios plugin is free software, and comes with ABSOLUTELY NO
WARRANTY. 
  It may be used, redistributed and/or modified under the terms of the
GNU 
  General Public Licence (see
http://www.fsf.org/licensing/licenses/gpl.txt).

and there's this line which looked like a mistake to me (though I think
it works correctly on closer inspection):

    license => { default => $DEFAULT{licence} },


I think the noun is meant in all those cases, so we could just
s/licen[cs]/licenc/gi except for the GPL URLs, right?