[Nagiosplug-devel] [ nagiosplug-Bugs-1681516 ] output too verbose for various checks

[SourceForge.net]

Bugs item #1681516, was opened at 2007-03-15 16:45
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1681516&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General plugin execution
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Christof Hanke (hanki_pank)
Assigned to: Nobody/Anonymous (nobody)
Summary: output too verbose for various checks

Initial Comment:
Hi,

Release 1.4.6.
I wanted to deploy check_http of a https-server which requires a valid client-certificate. Due to hardcoded printf's in sslutils.c:np_net_ssl_init()
I get 

CRITICAL - Cannot make SSL connection
25575:error:14094410:SSL routines:SSL3_READ_BYTES:sslv3 alert handshake failure:s3_pkt.c:1052:SSL alert number 40
OK - Certificate will expire on 02/18/2008 07:50.

What happens is that the check_http cannot do the handshake, because it has no valid client cerificate, which is correct.
But it _can_ verify the certificate presented by the server, which it succesfully does. 
However, the correct output "OK -..." is overwritten by the "CRITICAL - Cannot make SSL connection".

I have a fix, but maybe you guys want to introduce a kind of message passing from the lower-level functions in netutils.c and sslutils.c to the actual test, so that they can give a nice output, if necessary. E.g. if you do check_http -H NOTEXISTENT.NODOMAIN the output is also 2 lines and not very appealling IMHO.

Christof


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1681516&group_id=29880