[Nagiosplug-devel] [Nagiosplug-help] check_ntp

[Thomas Guyot-Sionnest]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/11/07 06:01 AM, Andreas Ericsson wrote:
> Thomas Guyot-Sionnest wrote:
>> check_ntp gets the offset between the local clock the the peer, which is
>> good to check if the local server is sync with the remote server, but
>> not to check if the remote server is sync with its peers.
>>
>> This can easily be changed; the question is do we actually want that?
>> (I'm personally all for it...)
>>
> 
> I think not. You can accomplish a peer-check by using NRPE or some such
> with the current behaviour.
> 
> OTOH, adding a --check-peers flag to check_ntp might be worthwhile.

No, that would become a mess because getting offset between ourself and
the server and getting the peers offset it a totally different operation
in NTP. Also it doesn't make much sense to get the former along with
jitter or stratum.

I started rewriting check_ntp to use the offset from the peers, and also
removed the useless loop for getting 4 times the control packets (since
they all contain the same info). I believe the best option is to also
rewrite check_ntp the other way round to get only offset using normal
NTP packets and name it something like check_time_ntp (that will be very
easy).

I'll create a branch later today add commit my changes there. So far my
rewrite is fairly complete except for a simple string-parsing function
that I haven't managed to make work properly yet...

Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHNcj46dZ+Kt5BchYRAvq2AJ9TV8I961gqhV81vs0kLVJ0So2FOwCdGDaf
Ojv6tu1CzmSLBX5kANKwe8Y=
=W0k+
-----END PGP SIGNATURE-----