[Nagiosplug-devel] [patch] failing check compromises SNMP community

Holger Weiss holger at CIS.FU-Berlin.DE
Wed Oct 24 17:12:56 CEST 2007

* Bernhard Fischer <rep.dot.nop at gmail.com> [2007-10-24 13:14]:
> If a check fails then the whole command-line, including the v1 or v2c
> community string is printed in check_snmp.c
> The attached proposed patch prints the dummy string "authpriv" instead
> of the real community, so a failing check does not make the community
> string visible to the users. Like before the full command_line is
> printed in verbose mode.

Good point, thank you.  Committed to SVN.

> PS: I'm attaching nagios-plugins-1.4.10-fix-indentation.diff, which
> indents check_snmp.c with the options listed on top of the patch.

I didn't commit this as indentation changes make SVN diffs crossing that
revision unreadable.  Maybe we should nevertheless fix our indentation
and make it consistent across all plugins in one big commit, but IMO
this should be discussed, first.


More information about the Devel mailing list