[Nagiosplug-devel] [ nagiosplug-Bugs-1939578 ] check_jabber: Always returns WARNING with Openfire server.

[SourceForge.net]

Bugs item #1939578, was opened at 2008-04-10 13:20
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1939578&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Adam Buchbinder (gdrago23)
Assigned to: Nobody/Anonymous (nobody)
Summary: check_jabber: Always returns WARNING with Openfire server.

Initial Comment:
check_jabber always returns WARNING when run against an Openfire Jabber server. It may do so against other servers, but I have no way of checking that.

Running check_jabber -v with no -e, -A or -a arguments shows that it expects the string "<?xml version='1.0'?><stream:stream xmlns='jabber:client' xmlns:stream='http://etherx.jabber.org/streams'". However, Openfire rearranges the namespace definitions; it returns a string beginning with "<?xml version='1.0' encoding='UTF-8'?><stream:stream xmlns:stream="http://etherx.jabber.org/streams" xmlns="jabber:client"". This is exactly as valid, but the hardcoded string doesn't match it, so it always returns "JABBER WARNING - Unexpected response from host/socket on port 5222".

A fix is to look for the three components separately in any order. The attached patch changes check_tcp so that running check_jabber is now equivalent to running:

check_jabber -A -e "<?xml version='1.0' encoding='UTF-8'?><stream:stream" -e "xmlns=\"jabber:client\"" -e "xmlns:stream=\"http://etherx.jabber.org/streams\""

Because the match has been made more general, this shouldn't cause any regressions with regards to other servers being detected.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1939578&group_id=29880