From ton.voon at altinity.com Fri Feb 1 10:45:10 2008 From: ton.voon at altinity.com (Ton Voon) Date: Fri, 1 Feb 2008 09:45:10 +0000 Subject: [Nagiosplug-devel] Nagios::Plugin with scientific notation Message-ID: Hi! I've been looking at some of the test failures that CPAN is reporting about the Nagios::Plugin module and I think I've fixed most of them now. However, this one still occurs: http://www.nntp.perl.org/group/perl.cpan.testers/2007/12/msg887150.html It looks like on some systems, perl returns the scientific notation for the value part of the performance data. You can see this on any system by running: perl -e '$a = 0.000053; print $a,$/' I get 5.3e-05 on my MacOSX 10.5 and Debian 4.0. For some reason, the test on darwin is giving this scientific notation when other systems are not. So the question is: Is scientific notation a problem? If not, I'll amend the test so that it doesn't fail. But if it is, should we specifically state a sprintf output so that you get a consistent output of the value? Ton http://www.altinity.com UK: +44 (0)870 787 9243 US: +1 866 879 9184 Fax: +44 (0)845 280 1725 Skype: tonvoon From chiel at gmx.net Tue Feb 5 02:59:47 2008 From: chiel at gmx.net (chiel) Date: Mon, 4 Feb 2008 21:59:47 -0400 Subject: [Nagiosplug-devel] Plugin to monitor abnormal traffic behavior Message-ID: <066b01c8679a$cae3a440$7c00a8c0@michiel> Hello, The bandwidth of some of our routers is pretty the same every day at a specific time. Max in is about 1.2 Gb and min 40 Mb. I want to monitor any strange behavior in this traffic. But with normal interface plugins that monitor traffic you can only set one max (and sometimes min). With those scripts we can't monitor if bandwidth is higher for example 90Mb where it's normally 40Mb at a particular time. I don't know if there is a plugin already availible for this (I have searched nagiosexchange)? And I'm not such a great coder myself, so maybe someone can help me? I think this can be done with using a table where it stores the traffic output of the last 24 hours. It can then check the current traffic with the one it monitored 24 hours ago. Maybe you can set warning and critical in % for example "-w 5 -c 10" to use 5% and 10% difference in traffic. What do you think of this? chiel -------------- next part -------------- An HTML attachment was scrubbed... URL: From william at leibzon.org Tue Feb 5 06:07:08 2008 From: william at leibzon.org (William Leibzon) Date: Mon, 4 Feb 2008 21:07:08 -0800 Subject: [Nagiosplug-devel] Plugin to monitor abnormal traffic behavior In-Reply-To: <066b01c8679a$cae3a440$7c00a8c0@michiel> References: <066b01c8679a$cae3a440$7c00a8c0@michiel> Message-ID: I dont think its worth the effort (but cost-effectivness is really up to the client, if someone paid me to do it, I would but I'd not on my own add such feature to check_snmp_netint which I maintain). Your idea on how to do it is wrong - you can not just look at traffic level 1 day ago because maybe exactly at the moment one day ago it was higher or lower then normal. So what it requires is calculating 1 day (and most likely really 2 day since maybe it began bursting today) traffic average in additional to immediate traffic. This requires large historic data file - with 5 minute checks this gets to be at least 300 entries for each interface for one day and most likely 600 if you want either average of traffic from yesterday as base or average for last 2 days. You may think this can be done quickly and easily by just looking up octet data count 1 or 2 days ago, but no so fast - you may have had router reboots or counter overflow, possibly more then one. So you end up having to go through all those likely 600 entires to calculate the average while also accounting for such events. Now the above probably sounds a lot like fixed-size average values db which if you know is exactly what RRD is all about. So instead of in actual network check plugin if you really really need such a feature I'd recommend you put data from network check into RRD (as you would to plot performance data) and then have separate check that specifically looks up one day ago average in RRD and compares it to most recent data put in the same RRD file. This can be done with either existing plugins or with just minimum extra programming and is mostly a matter of configuration to make it all work together. On 2/4/08, chiel wrote: > > Hello, > > The bandwidth of some of our routers is pretty the same every day at a > specific time. Max in is about 1.2 Gb and min 40 Mb. > I want to monitor any strange behavior in this traffic. But with normal > interface plugins that monitor traffic you can only set one max (and > sometimes min). With those scripts we can't monitor if bandwidth is higher > for example 90Mb where it's normally 40Mb at a particular time. > I don't know if there is a plugin already availible for this (I have > searched nagiosexchange)? And I'm not such a great coder myself, so maybe > someone can help me? > I think this can be done with using a table where it stores the traffic > output of the last 24 hours. It can then check the current traffic with the > one it monitored 24 hours ago. > > Maybe you can set warning and critical in % for example "-w 5 -c 10" to > use 5% and 10% difference in traffic. > > What do you think of this? > > chiel > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________________ > Nagios Plugin Development Mailing List > Nagiosplug-devel at lists.sourceforge.net > Unsubscribe at > https://lists.sourceforge.net/lists/listinfo/nagiosplug-devel > ::: Please include plugins version (-v) and OS when reporting any issue. > ::: Messages without supporting info will risk being sent to /dev/null > -------------- next part -------------- An HTML attachment was scrubbed... URL: From rouilj at cs.umb.edu Tue Feb 5 18:23:16 2008 From: rouilj at cs.umb.edu (John P. Rouillard) Date: Tue, 05 Feb 2008 12:23:16 -0500 Subject: [Nagiosplug-devel] Plugin to monitor abnormal traffic behavior In-Reply-To: Your message of "Mon, 04 Feb 2008 21:07:08 PST." Message-ID: <200802051723.m15HNGac003875@mx1.cs.umb.edu> In message , "William Leibzon" writes: >Your idea on how to do it is >wrong - you can not just look at traffic level 1 day ago because maybe >exactly at the moment one day ago it was higher or lower then normal. So >what it requires is calculating 1 day (and most likely really 2 day since >maybe it began bursting today) traffic average in additional to immediate >traffic. This requires large historic data file - with 5 minute checks this >gets to be at least 300 entries for each interface for one day and most >likely 600 if you want either average of traffic from yesterday as base or >average for last 2 days. You may think this can be done quickly and easily >by just looking up octet data count 1 or 2 days ago, but no so fast - you >may have had router reboots or counter overflow, possibly more then one. So >you end up having to go through all those likely 600 entires to calculate >the average while also accounting for such events. > >Now the above probably sounds a lot like fixed-size average values db which >if you know is exactly what RRD is all about. So instead of in actual >network check plugin if you really really need such a feature I'd recommend >you put data from network check into RRD (as you would to plot performance >data) and then have separate check that specifically looks up one day ago >average in RRD and compares it to most recent data put in the same RRD file. >This can be done with either existing plugins or with just minimum extra >programming and is mostly a matter of configuration to make it all work >together. I agree. What I did a while ago was dump the data into an rrd database with Holt-Winters forcasting turned on. Then I had a check that reported when the FAILURES RRA indicated that the current value was not within the expected estimation range. This works well for the range where rrdtool's H-W algorithm is tuned to match the periodicity of your data. Note I never used it in production, only spent a couple of months testing it with data from my monitoring installation and synthesized data. -- -- rouilj John Rouillard =========================================================================== My employers don't acknowledge my existence much less my opinions. From noreply at sourceforge.net Tue Feb 5 22:56:00 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Tue, 05 Feb 2008 13:56:00 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1878971 ] several typos Message-ID: Bugs item #1878971, was opened at 2008-01-24 16:44 Message generated for change (Comment added) made by cyco_dd You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1878971&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jan Wagner (cyco_dd) Assigned to: Nobody/Anonymous (nobody) Summary: several typos Initial Comment: the attached patch fixes several typos and was commited to Debian Nagios Maintainer Group. ---------------------------------------------------------------------- >Comment By: Jan Wagner (cyco_dd) Date: 2008-02-05 22:56 Message: Logged In: YES user_id=1345239 Originator: YES see also http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=435525 and http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=453012 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1878971&group_id=29880 From noreply at sourceforge.net Tue Feb 5 22:57:09 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Tue, 05 Feb 2008 13:57:09 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1878972 ] fixes compilation of check_pgsql with postgresql 8.3 Message-ID: Bugs item #1878972, was opened at 2008-01-24 16:47 Message generated for change (Comment added) made by cyco_dd You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1878972&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Compilation Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jan Wagner (cyco_dd) Assigned to: Nobody/Anonymous (nobody) Summary: fixes compilation of check_pgsql with postgresql 8.3 Initial Comment: the attached patch fixes compilation of check_psql with postgresql 8.3. Changelog of postgresql 8.3: - Move NAMEDATALEN definition from postgres_ext.h to pg_config_manual.h. It used to be part of libpq's exported interface many releases ago, but now it's no longer necessary to make it accessible to clients. The patch is against 1.4.11. With kind regards, Jan. ---------------------------------------------------------------------- >Comment By: Jan Wagner (cyco_dd) Date: 2008-02-05 22:57 Message: Logged In: YES user_id=1345239 Originator: YES see also http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=462509 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1878972&group_id=29880 From noreply at sourceforge.net Tue Feb 5 23:07:45 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Tue, 05 Feb 2008 14:07:45 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1887297 ] check_disk --local fails due missing arg no one is needed Message-ID: Bugs item #1887297, was opened at 2008-02-05 23:07 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1887297&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Argument proccessing Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jan Wagner (cyco_dd) Assigned to: Nobody/Anonymous (nobody) Summary: check_disk --local fails due missing arg no one is needed Initial Comment: check_disk --local requires argument while check_disk -l doesn't see also http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=405537 a patch is attached. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1887297&group_id=29880 From noreply at sourceforge.net Fri Feb 8 09:30:28 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 08 Feb 2008 00:30:28 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1889453 ] check_dig should support TCP Message-ID: Bugs item #1889453, was opened at 2008-02-08 10:30 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1889453&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Giannis Stoilis (stoilis) Assigned to: Nobody/Anonymous (nobody) Summary: check_dig should support TCP Initial Comment: I want to check DNS services for both UDP and TCP connectivity. dig has the +tcp parameter that enables TCP querying insted of UDP but it is not accessible because check_dig doesn't support it. While enabling this through check_dig would be a nice thing, maybe a better idea would be to pass parameters starting with "+" to dig directly, thus making it a little more transparent, giving it the ability to support future needed features. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1889453&group_id=29880 From federico.donati at hermess.it Fri Feb 8 12:40:45 2008 From: federico.donati at hermess.it (Federico Donati) Date: Fri, 08 Feb 2008 12:40:45 +0100 Subject: [Nagiosplug-devel] check_tcp source port? Message-ID: <47AC3FBD.4080500@hermess.it> Hi, source port option will be integraded in check_tcp plugin? It would be very useful! Now i have to use perl for check services that need a precise source port :( Thanks for your great work. Nagios is wonderful! From noreply at sourceforge.net Sat Feb 9 02:27:41 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 08 Feb 2008 17:27:41 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1889955 ] check_dig: patch to make dig honor -t option Message-ID: Patches item #1889955, was opened at 2008-02-09 14:27 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1889955&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jethro Carr (dodocaptain) Assigned to: Nobody/Anonymous (nobody) Summary: check_dig: patch to make dig honor -t option Initial Comment: When a timeout value is specified with the -t option, dig will sometimes timeout before the timer is actually reached. The problem occurs because the check_dig plugin does not pass the specified timeout value to dig, leaving dig to timeout with it's default value which seems to be around 10-15seconds. To reproduce: time ./check_dig -H 127.0.0.2 -l www.google.com -t 30 It will not run for 30secs, which is the expected behaviour. The following will work, because the timeout is less than the default dig timeout, so the plugin cancels the dig command: time ./check_dig -H 127.0.0.2 -l www.google.com -t 2 I have made a fix, and attached a patch for it against 1.4.11. This fix passes the timeout value to dig, and sets the number of retries which tends to vary from system to system by default. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1889955&group_id=29880 From noreply at sourceforge.net Sat Feb 9 20:24:58 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Sat, 09 Feb 2008 11:24:58 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1890260 ] 1.4.11 release does not build using SunC Message-ID: Bugs item #1890260, was opened at 2008-02-09 13:24 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1890260&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Compilation Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Rob Windsor (wrwindsor) Assigned to: Nobody/Anonymous (nobody) Summary: 1.4.11 release does not build using SunC Initial Comment: SunStudio predefined macro missed in plugins-root/check_dhcp.c, patch is attached. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1890260&group_id=29880 From noreply at sourceforge.net Sat Feb 9 20:25:37 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Sat, 09 Feb 2008 11:25:37 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1890260 ] 1.4.11 release does not build using SunC (patch incl) Message-ID: Bugs item #1890260, was opened at 2008-02-09 13:24 Message generated for change (Settings changed) made by wrwindsor You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1890260&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Compilation Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Rob Windsor (wrwindsor) Assigned to: Nobody/Anonymous (nobody) >Summary: 1.4.11 release does not build using SunC (patch incl) Initial Comment: SunStudio predefined macro missed in plugins-root/check_dhcp.c, patch is attached. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1890260&group_id=29880 From federico.donati at hermess.it Mon Feb 11 09:18:55 2008 From: federico.donati at hermess.it (Federico Donati) Date: Mon, 11 Feb 2008 09:18:55 +0100 Subject: [Nagiosplug-devel] check_tcp source port? Message-ID: <47B004EF.6040407@hermess.it> Hi, is there a way to insert a source port option in the check_tcp plugin? It would be very useful! Now i have to script perl for check services that need a precise source port :( Any suggestion? From noreply at sourceforge.net Mon Feb 11 14:43:22 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 11 Feb 2008 05:43:22 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1891143 ] popen test runs "forever" Message-ID: Bugs item #1891143, was opened at 2008-02-11 14:43 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891143&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Compilation Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Henry78 (henry78) Assigned to: Nobody/Anonymous (nobody) Summary: popen test runs "forever" Initial Comment: Using nagios-plugins-1.4.11 I run a plain ./configure, which is stuck at "checking for redhat spopen problem". The part getting stuck is the child_test, which takes 10 seconds to fail. As you see from the Makefile in the dir config_test the caller script (run_test) invokes the child_test 10 000 times. I attached an starce output of a manual child_test run. If anyone guides my (I'm no big C programmer), I'd be welcome to debug/track down this problem further. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891143&group_id=29880 From noreply at sourceforge.net Mon Feb 11 15:04:41 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 11 Feb 2008 06:04:41 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1891143 ] popen test runs "forever" (workaraound) Message-ID: Bugs item #1891143, was opened at 2008-02-11 14:43 Message generated for change (Comment added) made by henry78 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891143&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Compilation Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Henry78 (henry78) Assigned to: Nobody/Anonymous (nobody) >Summary: popen test runs "forever" (workaraound) Initial Comment: Using nagios-plugins-1.4.11 I run a plain ./configure, which is stuck at "checking for redhat spopen problem". The part getting stuck is the child_test, which takes 10 seconds to fail. As you see from the Makefile in the dir config_test the caller script (run_test) invokes the child_test 10 000 times. I attached an starce output of a manual child_test run. If anyone guides my (I'm no big C programmer), I'd be welcome to debug/track down this problem further. ---------------------------------------------------------------------- >Comment By: Henry78 (henry78) Date: 2008-02-11 15:04 Message: Logged In: YES user_id=885432 Originator: YES Finally had a look into the code of child_test, and of course it take forever, it's running nslookup from there, and nagios isn't attached to the internet. So i changed (removed/added comments) the executed command to 'date' (hope the test still does what it should do), now the test runs in a reasonable time. However, imho the test should be fixed to run something internet-independent. So leave the bug open. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891143&group_id=29880 From noreply at sourceforge.net Mon Feb 11 15:56:13 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 11 Feb 2008 06:56:13 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1891183 ] 1.4.11 doesn't compile (2x) Message-ID: Bugs item #1891183, was opened at 2008-02-11 15:56 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Henry78 (henry78) Assigned to: Nobody/Anonymous (nobody) Summary: 1.4.11 doesn't compile (2x) Initial Comment: I got this complie error, during 'makeing' nagios-plugins-1.4.11 on RHEL4: ----------8<---------- basename.c: In function `char* base_name(const char*)': basename.c:95: error: invalid conversion from `void*' to `char*' make[3]: *** [basename.o] Error 1 ---------->8---------- 'cause i didn't need it, i removed the part for rewriting windows(?) paths from basename.c. distclean, configure, make and a similar error occured: ----------8<---------- dirname.c: In function `char* dir_name(const char*)': dirname.c:79: error: invalid conversion from `void*' to `char*' make[3]: *** [dirname.o] Error 1 ---------->8---------- It's a rewrite of a filename/path there too, but I'm not sure why it throws an Error. The corresponding line 79 from dirname.c: ----------8<---------- char *dir = xmalloc (length + append_dot + 1); ---------->8---------- ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 From noreply at sourceforge.net Mon Feb 11 16:07:01 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 11 Feb 2008 07:07:01 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1891183 ] 1.4.11 doesn't compile (2x) Message-ID: Bugs item #1891183, was opened at 2008-02-11 15:56 Message generated for change (Comment added) made by hweiss You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Henry78 (henry78) Assigned to: Nobody/Anonymous (nobody) Summary: 1.4.11 doesn't compile (2x) Initial Comment: I got this complie error, during 'makeing' nagios-plugins-1.4.11 on RHEL4: ----------8<---------- basename.c: In function `char* base_name(const char*)': basename.c:95: error: invalid conversion from `void*' to `char*' make[3]: *** [basename.o] Error 1 ---------->8---------- 'cause i didn't need it, i removed the part for rewriting windows(?) paths from basename.c. distclean, configure, make and a similar error occured: ----------8<---------- dirname.c: In function `char* dir_name(const char*)': dirname.c:79: error: invalid conversion from `void*' to `char*' make[3]: *** [dirname.o] Error 1 ---------->8---------- It's a rewrite of a filename/path there too, but I'm not sure why it throws an Error. The corresponding line 79 from dirname.c: ----------8<---------- char *dir = xmalloc (length + append_dot + 1); ---------->8---------- ---------------------------------------------------------------------- >Comment By: Holger Weiss (hweiss) Date: 2008-02-11 16:07 Message: Logged In: YES user_id=759506 Originator: NO You didn't post the compiler command line which threw the error, but it seems as if you're using g++ instead of gcc for some reason. Is the environment variable CC set to "g++" or something like that? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 From noreply at sourceforge.net Mon Feb 11 16:12:34 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 11 Feb 2008 07:12:34 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1891183 ] 1.4.11 doesn't compile (2x) Message-ID: Bugs item #1891183, was opened at 2008-02-11 15:56 Message generated for change (Comment added) made by henry78 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Henry78 (henry78) Assigned to: Nobody/Anonymous (nobody) Summary: 1.4.11 doesn't compile (2x) Initial Comment: I got this complie error, during 'makeing' nagios-plugins-1.4.11 on RHEL4: ----------8<---------- basename.c: In function `char* base_name(const char*)': basename.c:95: error: invalid conversion from `void*' to `char*' make[3]: *** [basename.o] Error 1 ---------->8---------- 'cause i didn't need it, i removed the part for rewriting windows(?) paths from basename.c. distclean, configure, make and a similar error occured: ----------8<---------- dirname.c: In function `char* dir_name(const char*)': dirname.c:79: error: invalid conversion from `void*' to `char*' make[3]: *** [dirname.o] Error 1 ---------->8---------- It's a rewrite of a filename/path there too, but I'm not sure why it throws an Error. The corresponding line 79 from dirname.c: ----------8<---------- char *dir = xmalloc (length + append_dot + 1); ---------->8---------- ---------------------------------------------------------------------- >Comment By: Henry78 (henry78) Date: 2008-02-11 16:12 Message: Logged In: YES user_id=885432 Originator: YES ----------8<---------- if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../intl -g -O2 -MT dirname.o -MD -MP -MF ".deps/dirname.Tpo" -c -o dirname.o dirname.c; \ then mv -f ".deps/dirname.Tpo" ".deps/dirname.Po"; else rm -f ".deps/dirname.Tpo"; exit 1; fi ---------->8---------- That's the corresponding compiler command line. I'm pretty sure it uses gcc... ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 16:07 Message: Logged In: YES user_id=759506 Originator: NO You didn't post the compiler command line which threw the error, but it seems as if you're using g++ instead of gcc for some reason. Is the environment variable CC set to "g++" or something like that? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 From noreply at sourceforge.net Mon Feb 11 15:29:41 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 11 Feb 2008 06:29:41 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1891143 ] popen test runs "forever" (workaraound) Message-ID: Bugs item #1891143, was opened at 2008-02-11 14:43 Message generated for change (Comment added) made by srunschke You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891143&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Compilation Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Henry78 (henry78) Assigned to: Nobody/Anonymous (nobody) Summary: popen test runs "forever" (workaraound) Initial Comment: Using nagios-plugins-1.4.11 I run a plain ./configure, which is stuck at "checking for redhat spopen problem". The part getting stuck is the child_test, which takes 10 seconds to fail. As you see from the Makefile in the dir config_test the caller script (run_test) invokes the child_test 10 000 times. I attached an starce output of a manual child_test run. If anyone guides my (I'm no big C programmer), I'd be welcome to debug/track down this problem further. ---------------------------------------------------------------------- Comment By: Sascha Runschke (srunschke) Date: 2008-02-11 15:29 Message: Logged In: YES user_id=2006232 Originator: NO The type of check cannot be changed, since the Redhat spopen bug evolves around a futex race condition in combination with the ISC DNS libraries. Those are linked with bind, nslookup, dig and the like. If you change the actual check binary, then the check itself is foobar. It'll be better to implement a "pre-check" if DNS resolving is possible at all and bail out if not. S ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 15:04 Message: Logged In: YES user_id=885432 Originator: YES Finally had a look into the code of child_test, and of course it take forever, it's running nslookup from there, and nagios isn't attached to the internet. So i changed (removed/added comments) the executed command to 'date' (hope the test still does what it should do), now the test runs in a reasonable time. However, imho the test should be fixed to run something internet-independent. So leave the bug open. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891143&group_id=29880 From Matthias.Broenner at systemagmbh.de Mon Feb 11 15:28:14 2008 From: Matthias.Broenner at systemagmbh.de (Matthias.Broenner at systemagmbh.de) Date: Mon, 11 Feb 2008 15:28:14 +0100 Subject: [Nagiosplug-devel] Nagiosplugins 1.4.11 on HP UX Message-ID: Hello, i`m trying to set up tinderbox on 2 HPUX machines for the nagios plugins. I get the following Error on HP UX B 11.11 and also on HP UX B.11.23. Ton Voon asked me to test the actual release and post the errors to this list. here it is :) (See attached file: config.log) Kybelle:/root/nagios-plugins-1.4.11 # make No suffix list. make all-recursive No suffix list. Making all in gl make all-am No suffix list. Making all in lib Making all in tests No suffix list. source='utils_base.c' object='utils_base.o' libtool=no \ DEPDIR=.deps depmode=hp /bin/sh ../build-aux/depcomp \ cc -DHAVE_CONFIG_H -I. -I. -I.. -I. -I../gl -I../intl -I../plugins -I/opt/openssl/include -g -c utils_base.c cpp: "../plugins/common.h", line 224: warning 2002: Redefinition of param names for macro __attribute__. cc: "utils_base.c", line 108: error 1649: Illegal integer-pointer combination for >. cc: "utils_base.c", line 108: error 1563: Expression in if must be scalar. *** Error exit code 1 Stop. *** Error exit code 1 Stop. *** Error exit code 1 Stop. *** Error exit code 1 Stop. Kybelle:/root/nagios-plugins-1.4.11 # Viele Gr??e / Best Regards Matthias Br?nner ---------------------------------------------------------------------- --- [ Mitarbeiter / employee ] --- Matthias Br?nner Tel.: +49 941 / 78392 - 11 Fax: +49 941 / 78392 - 72 Mailto: matthias.broenner at SYSTEMAGmbH.de --- [ Standort / location ] --- Schikanederstr. 2 B - Posthof, 93053 Regensburg, GERMANY --- [ Firma / company ] --- SYSTEMA Systementwicklung Dipl.-Inf. Manfred Austen GmbH Manfred-von-Ardenne-Ring 6, 01099 Dresden, GERMANY Handelsregister: HRB 5422 Amtsgericht Dresden USt.-ID-Nr.: DE 159 607 786 Gesch?ftsf?hrer: Herr Manfred Austen http://www.SYSTEMAGmbH.de ---------------------------------------------------------------------- -------------- next part -------------- A non-text attachment was scrubbed... Name: config.log Type: application/octet-stream Size: 479321 bytes Desc: not available URL: From noreply at sourceforge.net Mon Feb 11 16:43:46 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 11 Feb 2008 07:43:46 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1891143 ] popen test runs "forever" (workaraound) Message-ID: Bugs item #1891143, was opened at 2008-02-11 13:43 Message generated for change (Comment added) made by tonvoon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891143&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Compilation Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Henry78 (henry78) Assigned to: Nobody/Anonymous (nobody) Summary: popen test runs "forever" (workaraound) Initial Comment: Using nagios-plugins-1.4.11 I run a plain ./configure, which is stuck at "checking for redhat spopen problem". The part getting stuck is the child_test, which takes 10 seconds to fail. As you see from the Makefile in the dir config_test the caller script (run_test) invokes the child_test 10 000 times. I attached an starce output of a manual child_test run. If anyone guides my (I'm no big C programmer), I'd be welcome to debug/track down this problem further. ---------------------------------------------------------------------- >Comment By: Ton Voon (tonvoon) Date: 2008-02-11 15:43 Message: Logged In: YES user_id=664364 Originator: NO Henry, Does this answer your questions? http://nagiosplugins.org/node/7 Ton ---------------------------------------------------------------------- Comment By: Sascha Runschke (srunschke) Date: 2008-02-11 14:29 Message: Logged In: YES user_id=2006232 Originator: NO The type of check cannot be changed, since the Redhat spopen bug evolves around a futex race condition in combination with the ISC DNS libraries. Those are linked with bind, nslookup, dig and the like. If you change the actual check binary, then the check itself is foobar. It'll be better to implement a "pre-check" if DNS resolving is possible at all and bail out if not. S ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 14:04 Message: Logged In: YES user_id=885432 Originator: YES Finally had a look into the code of child_test, and of course it take forever, it's running nslookup from there, and nagios isn't attached to the internet. So i changed (removed/added comments) the executed command to 'date' (hope the test still does what it should do), now the test runs in a reasonable time. However, imho the test should be fixed to run something internet-independent. So leave the bug open. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891143&group_id=29880 From holger at CIS.FU-Berlin.DE Mon Feb 11 16:47:39 2008 From: holger at CIS.FU-Berlin.DE (Holger Weiss) Date: Mon, 11 Feb 2008 16:47:39 +0100 Subject: [Nagiosplug-devel] Nagiosplugins 1.4.11 on HP UX In-Reply-To: References: Message-ID: <20080211154739.GC40233203@CIS.FU-Berlin.DE> * Matthias.Broenner at systemagmbh.de [2008-02-11 15:28]: > cc: "utils_base.c", line 108: error 1649: Illegal integer-pointer combination for >. > cc: "utils_base.c", line 108: error 1563: Expression in if must be scalar. Ugh, that's indeed broken. A quick and dirty workaround for you would be to delete the lines 108-111 in utils_base.c: if (*my_thresholds > 0) { /* Not sure why, but sometimes could be -1 */ /* printf("Freeing here: %d\n", *my_thresholds); */ free(*my_thresholds); } Removing these lines creates a minor memory leak, but that won't be a problem in practice. A proper fix will require a little more work. Holger From noreply at sourceforge.net Mon Feb 11 16:57:03 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 11 Feb 2008 07:57:03 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1891183 ] 1.4.11 doesn't compile (2x) Message-ID: Bugs item #1891183, was opened at 2008-02-11 15:56 Message generated for change (Comment added) made by hweiss You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Henry78 (henry78) Assigned to: Nobody/Anonymous (nobody) Summary: 1.4.11 doesn't compile (2x) Initial Comment: I got this complie error, during 'makeing' nagios-plugins-1.4.11 on RHEL4: ----------8<---------- basename.c: In function `char* base_name(const char*)': basename.c:95: error: invalid conversion from `void*' to `char*' make[3]: *** [basename.o] Error 1 ---------->8---------- 'cause i didn't need it, i removed the part for rewriting windows(?) paths from basename.c. distclean, configure, make and a similar error occured: ----------8<---------- dirname.c: In function `char* dir_name(const char*)': dirname.c:79: error: invalid conversion from `void*' to `char*' make[3]: *** [dirname.o] Error 1 ---------->8---------- It's a rewrite of a filename/path there too, but I'm not sure why it throws an Error. The corresponding line 79 from dirname.c: ----------8<---------- char *dir = xmalloc (length + append_dot + 1); ---------->8---------- ---------------------------------------------------------------------- >Comment By: Holger Weiss (hweiss) Date: 2008-02-11 16:57 Message: Logged In: YES user_id=759506 Originator: NO Odd. Does compiling the following code using "gcc -o test test.c" work? /* test.c */ int main(void) { void *v; char *c = v; return 0; } ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 16:12 Message: Logged In: YES user_id=885432 Originator: YES ----------8<---------- if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../intl -g -O2 -MT dirname.o -MD -MP -MF ".deps/dirname.Tpo" -c -o dirname.o dirname.c; \ then mv -f ".deps/dirname.Tpo" ".deps/dirname.Po"; else rm -f ".deps/dirname.Tpo"; exit 1; fi ---------->8---------- That's the corresponding compiler command line. I'm pretty sure it uses gcc... ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 16:07 Message: Logged In: YES user_id=759506 Originator: NO You didn't post the compiler command line which threw the error, but it seems as if you're using g++ instead of gcc for some reason. Is the environment variable CC set to "g++" or something like that? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 From noreply at sourceforge.net Mon Feb 11 17:05:41 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 11 Feb 2008 08:05:41 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1891183 ] 1.4.11 doesn't compile (2x) Message-ID: Bugs item #1891183, was opened at 2008-02-11 15:56 Message generated for change (Comment added) made by henry78 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Henry78 (henry78) Assigned to: Nobody/Anonymous (nobody) Summary: 1.4.11 doesn't compile (2x) Initial Comment: I got this complie error, during 'makeing' nagios-plugins-1.4.11 on RHEL4: ----------8<---------- basename.c: In function `char* base_name(const char*)': basename.c:95: error: invalid conversion from `void*' to `char*' make[3]: *** [basename.o] Error 1 ---------->8---------- 'cause i didn't need it, i removed the part for rewriting windows(?) paths from basename.c. distclean, configure, make and a similar error occured: ----------8<---------- dirname.c: In function `char* dir_name(const char*)': dirname.c:79: error: invalid conversion from `void*' to `char*' make[3]: *** [dirname.o] Error 1 ---------->8---------- It's a rewrite of a filename/path there too, but I'm not sure why it throws an Error. The corresponding line 79 from dirname.c: ----------8<---------- char *dir = xmalloc (length + append_dot + 1); ---------->8---------- ---------------------------------------------------------------------- >Comment By: Henry78 (henry78) Date: 2008-02-11 17:05 Message: Logged In: YES user_id=885432 Originator: YES No, the test.c doesn't complile. It throws an error: -----8<----- test.c:2: error: invalid conversion from `void*' to `char*' ----->8----- It works if I (double)quote the 'v'. gcc -v gcc version 3.4.5 20051201 (Red Hat 3.4.5-2) ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 16:57 Message: Logged In: YES user_id=759506 Originator: NO Odd. Does compiling the following code using "gcc -o test test.c" work? /* test.c */ int main(void) { void *v; char *c = v; return 0; } ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 16:12 Message: Logged In: YES user_id=885432 Originator: YES ----------8<---------- if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../intl -g -O2 -MT dirname.o -MD -MP -MF ".deps/dirname.Tpo" -c -o dirname.o dirname.c; \ then mv -f ".deps/dirname.Tpo" ".deps/dirname.Po"; else rm -f ".deps/dirname.Tpo"; exit 1; fi ---------->8---------- That's the corresponding compiler command line. I'm pretty sure it uses gcc... ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 16:07 Message: Logged In: YES user_id=759506 Originator: NO You didn't post the compiler command line which threw the error, but it seems as if you're using g++ instead of gcc for some reason. Is the environment variable CC set to "g++" or something like that? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 From noreply at sourceforge.net Mon Feb 11 17:09:39 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 11 Feb 2008 08:09:39 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1891143 ] popen test runs "forever" (workaraound) Message-ID: Bugs item #1891143, was opened at 2008-02-11 08:43 Message generated for change (Comment added) made by dermoth You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891143&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Compilation Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Henry78 (henry78) Assigned to: Nobody/Anonymous (nobody) Summary: popen test runs "forever" (workaraound) Initial Comment: Using nagios-plugins-1.4.11 I run a plain ./configure, which is stuck at "checking for redhat spopen problem". The part getting stuck is the child_test, which takes 10 seconds to fail. As you see from the Makefile in the dir config_test the caller script (run_test) invokes the child_test 10 000 times. I attached an starce output of a manual child_test run. If anyone guides my (I'm no big C programmer), I'd be welcome to debug/track down this problem further. ---------------------------------------------------------------------- >Comment By: Thomas Guyot (dermoth) Date: 2008-02-11 11:09 Message: Logged In: YES user_id=375623 Originator: NO Why not printing out this link with a sort note just before running the test? ---------------------------------------------------------------------- Comment By: Ton Voon (tonvoon) Date: 2008-02-11 10:43 Message: Logged In: YES user_id=664364 Originator: NO Henry, Does this answer your questions? http://nagiosplugins.org/node/7 Ton ---------------------------------------------------------------------- Comment By: Sascha Runschke (srunschke) Date: 2008-02-11 09:29 Message: Logged In: YES user_id=2006232 Originator: NO The type of check cannot be changed, since the Redhat spopen bug evolves around a futex race condition in combination with the ISC DNS libraries. Those are linked with bind, nslookup, dig and the like. If you change the actual check binary, then the check itself is foobar. It'll be better to implement a "pre-check" if DNS resolving is possible at all and bail out if not. S ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 09:04 Message: Logged In: YES user_id=885432 Originator: YES Finally had a look into the code of child_test, and of course it take forever, it's running nslookup from there, and nagios isn't attached to the internet. So i changed (removed/added comments) the executed command to 'date' (hope the test still does what it should do), now the test runs in a reasonable time. However, imho the test should be fixed to run something internet-independent. So leave the bug open. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891143&group_id=29880 From noreply at sourceforge.net Mon Feb 11 17:14:19 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 11 Feb 2008 08:14:19 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1891183 ] 1.4.11 doesn't compile (2x) Message-ID: Bugs item #1891183, was opened at 2008-02-11 15:56 Message generated for change (Comment added) made by hweiss You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Henry78 (henry78) Assigned to: Nobody/Anonymous (nobody) Summary: 1.4.11 doesn't compile (2x) Initial Comment: I got this complie error, during 'makeing' nagios-plugins-1.4.11 on RHEL4: ----------8<---------- basename.c: In function `char* base_name(const char*)': basename.c:95: error: invalid conversion from `void*' to `char*' make[3]: *** [basename.o] Error 1 ---------->8---------- 'cause i didn't need it, i removed the part for rewriting windows(?) paths from basename.c. distclean, configure, make and a similar error occured: ----------8<---------- dirname.c: In function `char* dir_name(const char*)': dirname.c:79: error: invalid conversion from `void*' to `char*' make[3]: *** [dirname.o] Error 1 ---------->8---------- It's a rewrite of a filename/path there too, but I'm not sure why it throws an Error. The corresponding line 79 from dirname.c: ----------8<---------- char *dir = xmalloc (length + append_dot + 1); ---------->8---------- ---------------------------------------------------------------------- >Comment By: Holger Weiss (hweiss) Date: 2008-02-11 17:14 Message: Logged In: YES user_id=759506 Originator: NO Then there's something seriously broken with your gcc installation, my example is perfectly valid C code. Maybe try to re-install your GCC package(s)? Other than that, I have no idea, sorry. ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 17:05 Message: Logged In: YES user_id=885432 Originator: YES No, the test.c doesn't complile. It throws an error: -----8<----- test.c:2: error: invalid conversion from `void*' to `char*' ----->8----- It works if I (double)quote the 'v'. gcc -v gcc version 3.4.5 20051201 (Red Hat 3.4.5-2) ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 16:57 Message: Logged In: YES user_id=759506 Originator: NO Odd. Does compiling the following code using "gcc -o test test.c" work? /* test.c */ int main(void) { void *v; char *c = v; return 0; } ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 16:12 Message: Logged In: YES user_id=885432 Originator: YES ----------8<---------- if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../intl -g -O2 -MT dirname.o -MD -MP -MF ".deps/dirname.Tpo" -c -o dirname.o dirname.c; \ then mv -f ".deps/dirname.Tpo" ".deps/dirname.Po"; else rm -f ".deps/dirname.Tpo"; exit 1; fi ---------->8---------- That's the corresponding compiler command line. I'm pretty sure it uses gcc... ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 16:07 Message: Logged In: YES user_id=759506 Originator: NO You didn't post the compiler command line which threw the error, but it seems as if you're using g++ instead of gcc for some reason. Is the environment variable CC set to "g++" or something like that? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 From noreply at sourceforge.net Mon Feb 11 17:15:39 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 11 Feb 2008 08:15:39 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1891183 ] 1.4.11 doesn't compile (2x) Message-ID: Bugs item #1891183, was opened at 2008-02-11 15:56 Message generated for change (Settings changed) made by hweiss You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Pending >Resolution: Invalid Priority: 5 Private: No Submitted By: Henry78 (henry78) Assigned to: Nobody/Anonymous (nobody) Summary: 1.4.11 doesn't compile (2x) Initial Comment: I got this complie error, during 'makeing' nagios-plugins-1.4.11 on RHEL4: ----------8<---------- basename.c: In function `char* base_name(const char*)': basename.c:95: error: invalid conversion from `void*' to `char*' make[3]: *** [basename.o] Error 1 ---------->8---------- 'cause i didn't need it, i removed the part for rewriting windows(?) paths from basename.c. distclean, configure, make and a similar error occured: ----------8<---------- dirname.c: In function `char* dir_name(const char*)': dirname.c:79: error: invalid conversion from `void*' to `char*' make[3]: *** [dirname.o] Error 1 ---------->8---------- It's a rewrite of a filename/path there too, but I'm not sure why it throws an Error. The corresponding line 79 from dirname.c: ----------8<---------- char *dir = xmalloc (length + append_dot + 1); ---------->8---------- ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 17:14 Message: Logged In: YES user_id=759506 Originator: NO Then there's something seriously broken with your gcc installation, my example is perfectly valid C code. Maybe try to re-install your GCC package(s)? Other than that, I have no idea, sorry. ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 17:05 Message: Logged In: YES user_id=885432 Originator: YES No, the test.c doesn't complile. It throws an error: -----8<----- test.c:2: error: invalid conversion from `void*' to `char*' ----->8----- It works if I (double)quote the 'v'. gcc -v gcc version 3.4.5 20051201 (Red Hat 3.4.5-2) ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 16:57 Message: Logged In: YES user_id=759506 Originator: NO Odd. Does compiling the following code using "gcc -o test test.c" work? /* test.c */ int main(void) { void *v; char *c = v; return 0; } ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 16:12 Message: Logged In: YES user_id=885432 Originator: YES ----------8<---------- if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../intl -g -O2 -MT dirname.o -MD -MP -MF ".deps/dirname.Tpo" -c -o dirname.o dirname.c; \ then mv -f ".deps/dirname.Tpo" ".deps/dirname.Po"; else rm -f ".deps/dirname.Tpo"; exit 1; fi ---------->8---------- That's the corresponding compiler command line. I'm pretty sure it uses gcc... ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 16:07 Message: Logged In: YES user_id=759506 Originator: NO You didn't post the compiler command line which threw the error, but it seems as if you're using g++ instead of gcc for some reason. Is the environment variable CC set to "g++" or something like that? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 From Matthias.Broenner at systemagmbh.de Mon Feb 11 17:36:37 2008 From: Matthias.Broenner at systemagmbh.de (Matthias.Broenner at systemagmbh.de) Date: Mon, 11 Feb 2008 17:36:37 +0100 Subject: [Nagiosplug-devel] Nagiosplug-devel Digest, Vol 21, Issue 7 In-Reply-To: Message-ID: Hello Holger, i removed the line from 108-111 in utils_base.c. Now "make" goes on :) ... until next error.... cc -g -o check_nagios check_nagios.o utils.o runcmd.o -L/root/nagios-plugins-1.4.11/plugins -L/opt/openssl/lib ../lib/libnagiosplug.a ../gl/libgnu.a source='check_dns.c' object='check_dns.o' libtool=no \ DEPDIR=.deps depmode=hp /bin/sh ../build-aux/depcomp \ cc -DLOCALEDIR=\"/usr/local/nagios/share/locale\" -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I../lib -I../gl -I../intl -I/opt/openssl/include -I/opt/openssl/include -g -c check_dns.c cpp: "common.h", line 224: warning 2002: Redefinition of param names for macro __attribute__. /bin/sh ../libtool --tag=CC --mode=link cc -g -L. -L/opt/openssl/lib -o check_dns check_dns.o netutils.o utils.o ../lib/libnagiosplug.a ../gl/libgnu.a -ldce -lnsl runcmd.o cc -g -o check_dns check_dns.o netutils.o utils.o runcmd.o -L/root/nagios-plugins-1.4.11/plugins -L/opt/openssl/lib ../lib/libnagiosplug.a ../gl/libgnu.a -ldce -lnsl source='check_by_ssh.c' object='check_by_ssh.o' libtool=no \ DEPDIR=.deps depmode=hp /bin/sh ../build-aux/depcomp \ cc -DLOCALEDIR=\"/usr/local/nagios/share/locale\" -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I../lib -I../gl -I../intl -I/opt/openssl/include -I/opt/openssl/include -g -c check_by_ssh.c cpp: "common.h", line 224: warning 2002: Redefinition of param names for macro __attribute__. /bin/sh ../libtool --tag=CC --mode=link cc -g -L. -L/opt/openssl/lib -o check_by_ssh check_by_ssh.o netutils.o utils.o ../lib/libnagiosplug.a ../gl/libgnu.a -ldce -lnsl runcmd.o cc -g -o check_by_ssh check_by_ssh.o netutils.o utils.o runcmd.o -L/root/nagios-plugins-1.4.11/plugins -L/opt/openssl/lib ../lib/libnagiosplug.a ../gl/libgnu.a -ldce -lnsl source='check_swap.c' object='check_swap.o' libtool=no \ DEPDIR=.deps depmode=hp /bin/sh ../build-aux/depcomp \ cc -DLOCALEDIR=\"/usr/local/nagios/share/locale\" -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I../lib -I../gl -I../intl -I/opt/openssl/include -I/opt/openssl/include -g -c check_swap.c cpp: "common.h", line 224: warning 2002: Redefinition of param names for macro __attribute__. /bin/sh ../libtool --tag=CC --mode=link cc -g -L. -L/opt/openssl/lib -o check_swap check_swap.o -lm utils.o ../lib/libnagiosplug.a ../gl/libgnu.a popen.o cc -g -o check_swap check_swap.o utils.o popen.o -L/root/nagios-plugins-1.4.11/plugins -L/opt/openssl/lib -lm ../lib/libnagiosplug.a ../gl/libgnu.a /usr/ccs/bin/ld: Unsatisfied symbols: floorf (first referenced in check_swap.o) (code) *** Error exit code 1 Stop. *** Error exit code 1 Stop. *** Error exit code 1 Stop. Kybelle:/root/nagios-plugins-1.4.11 # >Message: 2 >Date: Mon, 11 Feb 2008 16:47:39 +0100 >From: Holger Weiss >Subject: Re: [Nagiosplug-devel] Nagiosplugins 1.4.11 on HP UX >To: Nagios Plugins Development > >Message-ID: <20080211154739.GC40233203 at CIS.FU-Berlin.DE> >Content-Type: text/plain; charset=us-ascii >* Matthias.Broenner at systemagmbh.de [2008-02-11 15:28]: >> cc: "utils_base.c", line 108: error 1649: Illegal integer-pointer combination for >. >> cc: "utils_base.c", line 108: error 1563: Expression in if must be scalar. > >Ugh, that's indeed broken. A quick and dirty workaround for you would be to >delete the lines 108-111 in utils_base.c: > > if (*my_thresholds > 0) { /* Not sure why, but sometimes could be -1 */ > /* printf("Freeing here: %d\n", *my_thresholds); */ > free(*my_thresholds); > } > >Removing these lines creates a minor memory leak, but that won't be a >problem in practice. A proper fix will require a little more work. > >Holger > Viele Gr??e / Best Regards Matthias Br?nner ---------------------------------------------------------------------- --- [ Mitarbeiter / employee ] --- Matthias Br?nner Tel.: +49 941 / 78392 - 11 Fax: +49 941 / 78392 - 72 Mailto: matthias.broenner at SYSTEMAGmbH.de --- [ Standort / location ] --- Schikanederstr. 2 B - Posthof, 93053 Regensburg, GERMANY --- [ Firma / company ] --- SYSTEMA Systementwicklung Dipl.-Inf. Manfred Austen GmbH Manfred-von-Ardenne-Ring 6, 01099 Dresden, GERMANY Handelsregister: HRB 5422 Amtsgericht Dresden USt.-ID-Nr.: DE 159 607 786 Gesch?ftsf?hrer: Herr Manfred Austen http://www.SYSTEMAGmbH.de ---------------------------------------------------------------------- From andurin at process-zero.de Mon Feb 11 17:53:19 2008 From: andurin at process-zero.de (=?ISO-8859-15?Q?Hendrik_B=E4cker?=) Date: Mon, 11 Feb 2008 17:53:19 +0100 Subject: [Nagiosplug-devel] Missing SSL hint in REQUIREMENT Message-ID: <47B07D7F.8010108@process-zero.de> Hi List, hi plugin developers, it would be fine to place a generic hint into the REQUIREMENTS file to let the user know that they need the openssl libraries to get check_ldaps check_http --ssl and so on... Maybe a summary after the configure script which plugins were not be existant cause of missing dependencies would be nice to. IMHO the configure output is to long to see the single "WARNING" lines in it... and to tell the truth - show me a new user who looks for warnings ;). Kind regards Hendrik From noreply at sourceforge.net Mon Feb 11 18:43:30 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 11 Feb 2008 09:43:30 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1891183 ] 1.4.11 doesn't compile (2x) Message-ID: Bugs item #1891183, was opened at 2008-02-11 15:56 Message generated for change (Comment added) made by henry78 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Open Resolution: Invalid Priority: 5 Private: No Submitted By: Henry78 (henry78) Assigned to: Nobody/Anonymous (nobody) Summary: 1.4.11 doesn't compile (2x) Initial Comment: I got this complie error, during 'makeing' nagios-plugins-1.4.11 on RHEL4: ----------8<---------- basename.c: In function `char* base_name(const char*)': basename.c:95: error: invalid conversion from `void*' to `char*' make[3]: *** [basename.o] Error 1 ---------->8---------- 'cause i didn't need it, i removed the part for rewriting windows(?) paths from basename.c. distclean, configure, make and a similar error occured: ----------8<---------- dirname.c: In function `char* dir_name(const char*)': dirname.c:79: error: invalid conversion from `void*' to `char*' make[3]: *** [dirname.o] Error 1 ---------->8---------- It's a rewrite of a filename/path there too, but I'm not sure why it throws an Error. The corresponding line 79 from dirname.c: ----------8<---------- char *dir = xmalloc (length + append_dot + 1); ---------->8---------- ---------------------------------------------------------------------- >Comment By: Henry78 (henry78) Date: 2008-02-11 18:43 Message: Logged In: YES user_id=885432 Originator: YES I got a 'C-Guru' to my desk for some minutes. He explained that your test.c code is valid K&R C, but I need to set the gcc-switch "-x c" to compile it. And ist complied fine. Even a hello-world-like line was printed after adding that to test.c The pity is: C-Guru is gone, and the compilation fails with other errors: -----8<----- gcc -x c -o check_apt check_apt.o utils.o runcmd.o -L/root/nagios/nagios-plugins-1.4.11/plugins ../lib/libnagiosplug.a ../gl /libgnu.a check_apt.o:1: error: stray '\127' in program ----->8----- I'll update to the latest available gcc for RHEL4 (that's 3.4.6), and report back. ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 17:14 Message: Logged In: YES user_id=759506 Originator: NO Then there's something seriously broken with your gcc installation, my example is perfectly valid C code. Maybe try to re-install your GCC package(s)? Other than that, I have no idea, sorry. ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 17:05 Message: Logged In: YES user_id=885432 Originator: YES No, the test.c doesn't complile. It throws an error: -----8<----- test.c:2: error: invalid conversion from `void*' to `char*' ----->8----- It works if I (double)quote the 'v'. gcc -v gcc version 3.4.5 20051201 (Red Hat 3.4.5-2) ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 16:57 Message: Logged In: YES user_id=759506 Originator: NO Odd. Does compiling the following code using "gcc -o test test.c" work? /* test.c */ int main(void) { void *v; char *c = v; return 0; } ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 16:12 Message: Logged In: YES user_id=885432 Originator: YES ----------8<---------- if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../intl -g -O2 -MT dirname.o -MD -MP -MF ".deps/dirname.Tpo" -c -o dirname.o dirname.c; \ then mv -f ".deps/dirname.Tpo" ".deps/dirname.Po"; else rm -f ".deps/dirname.Tpo"; exit 1; fi ---------->8---------- That's the corresponding compiler command line. I'm pretty sure it uses gcc... ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 16:07 Message: Logged In: YES user_id=759506 Originator: NO You didn't post the compiler command line which threw the error, but it seems as if you're using g++ instead of gcc for some reason. Is the environment variable CC set to "g++" or something like that? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 From nagios at babar.us Mon Feb 11 22:18:17 2008 From: nagios at babar.us (Olivier 'Babar' Raginel) Date: Mon, 11 Feb 2008 22:18:17 +0100 Subject: [Nagiosplug-devel] Nagiosplug-devel Digest, Vol 21, Issue 7 In-Reply-To: References: Message-ID: <20080211211817.GA7087@mail.babar.us> On Mon, Feb 11, 2008 at 05:36:37PM +0100, Matthias.Broenner at systemagmbh.de wrote: > i removed the line from 108-111 in utils_base.c. Now "make" goes on :) ... > until next error.... > cc -g -o check_swap check_swap.o utils.o popen.o > -L/root/nagios-plugins-1.4.11/plugins -L/opt/openssl/lib -lm > ../lib/libnagiosplug.a ../gl/libgnu.a > /usr/ccs/bin/ld: Unsatisfied symbols: > floorf (first referenced in check_swap.o) (code) > *** Error exit code 1 That's weird, normally floorf is part of libm, and there is -lm. But, according to: http://www.gnu.org/software/gnulib/manual/html_node/floorf.html it's missing on HP-UX 11. In theory, you should be able to change all floorf into floor and it should work, but you might have some overflow issues. A patch for this shall require some m4 configure tweaking and a few defines. Another hack might be to use these: #ifndef floorf #define floorf (float)floor #endif Find one .h which gets included in at least this .c :) But honestly, I'm not happy with any solution (which are the same in fact, just 2 different ways to write it). I let main coders decide what's the best way to do so, but this should help you go on with the compilation. Kind regards, -- Babar. From noreply at sourceforge.net Mon Feb 11 22:21:37 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 11 Feb 2008 13:21:37 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1891183 ] 1.4.11 doesn't compile (2x) Message-ID: Bugs item #1891183, was opened at 2008-02-11 15:56 Message generated for change (Comment added) made by hweiss You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: Invalid Priority: 5 Private: No Submitted By: Henry78 (henry78) Assigned to: Nobody/Anonymous (nobody) Summary: 1.4.11 doesn't compile (2x) Initial Comment: I got this complie error, during 'makeing' nagios-plugins-1.4.11 on RHEL4: ----------8<---------- basename.c: In function `char* base_name(const char*)': basename.c:95: error: invalid conversion from `void*' to `char*' make[3]: *** [basename.o] Error 1 ---------->8---------- 'cause i didn't need it, i removed the part for rewriting windows(?) paths from basename.c. distclean, configure, make and a similar error occured: ----------8<---------- dirname.c: In function `char* dir_name(const char*)': dirname.c:79: error: invalid conversion from `void*' to `char*' make[3]: *** [dirname.o] Error 1 ---------->8---------- It's a rewrite of a filename/path there too, but I'm not sure why it throws an Error. The corresponding line 79 from dirname.c: ----------8<---------- char *dir = xmalloc (length + append_dot + 1); ---------->8---------- ---------------------------------------------------------------------- >Comment By: Holger Weiss (hweiss) Date: 2008-02-11 22:21 Message: Logged In: YES user_id=759506 Originator: NO The new error again looks like your GCC installation is somehow borked. GCC 3.4.5 should be just fine, but an upgrade is probably a good idea, just in order to replace the old stuff. I'd be interested in whether that fixes it. By the way, my example doesn't use K&R style, it's plain ANSI C. The thing your compiler refused to do (in the plugins code and in my example) was an implicit conversion of a pointer to void to a pointer to char, which is just fine in C (both C89 and C99), but is not allowed in C++ (where an explicit cast would be required to convert a pointer to void). "-x c" forces gcc and g++ to expect C input. Without "-x", gcc chooses the language based on the file name suffix (see "man gcc"), while g++ expects C++ unless you use "-x" (which is how your gcc behaves for some reason). ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 18:43 Message: Logged In: YES user_id=885432 Originator: YES I got a 'C-Guru' to my desk for some minutes. He explained that your test.c code is valid K&R C, but I need to set the gcc-switch "-x c" to compile it. And ist complied fine. Even a hello-world-like line was printed after adding that to test.c The pity is: C-Guru is gone, and the compilation fails with other errors: -----8<----- gcc -x c -o check_apt check_apt.o utils.o runcmd.o -L/root/nagios/nagios-plugins-1.4.11/plugins ../lib/libnagiosplug.a ../gl /libgnu.a check_apt.o:1: error: stray '\127' in program ----->8----- I'll update to the latest available gcc for RHEL4 (that's 3.4.6), and report back. ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 17:14 Message: Logged In: YES user_id=759506 Originator: NO Then there's something seriously broken with your gcc installation, my example is perfectly valid C code. Maybe try to re-install your GCC package(s)? Other than that, I have no idea, sorry. ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 17:05 Message: Logged In: YES user_id=885432 Originator: YES No, the test.c doesn't complile. It throws an error: -----8<----- test.c:2: error: invalid conversion from `void*' to `char*' ----->8----- It works if I (double)quote the 'v'. gcc -v gcc version 3.4.5 20051201 (Red Hat 3.4.5-2) ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 16:57 Message: Logged In: YES user_id=759506 Originator: NO Odd. Does compiling the following code using "gcc -o test test.c" work? /* test.c */ int main(void) { void *v; char *c = v; return 0; } ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 16:12 Message: Logged In: YES user_id=885432 Originator: YES ----------8<---------- if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../intl -g -O2 -MT dirname.o -MD -MP -MF ".deps/dirname.Tpo" -c -o dirname.o dirname.c; \ then mv -f ".deps/dirname.Tpo" ".deps/dirname.Po"; else rm -f ".deps/dirname.Tpo"; exit 1; fi ---------->8---------- That's the corresponding compiler command line. I'm pretty sure it uses gcc... ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 16:07 Message: Logged In: YES user_id=759506 Originator: NO You didn't post the compiler command line which threw the error, but it seems as if you're using g++ instead of gcc for some reason. Is the environment variable CC set to "g++" or something like that? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 From noreply at sourceforge.net Mon Feb 11 22:24:17 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 11 Feb 2008 13:24:17 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1891143 ] popen test runs "forever" (workaraound) Message-ID: Bugs item #1891143, was opened at 2008-02-11 13:43 Message generated for change (Comment added) made by tonvoon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891143&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Compilation Group: Release (specify) >Status: Pending Resolution: None Priority: 5 Private: No Submitted By: Henry78 (henry78) Assigned to: Nobody/Anonymous (nobody) Summary: popen test runs "forever" (workaraound) Initial Comment: Using nagios-plugins-1.4.11 I run a plain ./configure, which is stuck at "checking for redhat spopen problem". The part getting stuck is the child_test, which takes 10 seconds to fail. As you see from the Makefile in the dir config_test the caller script (run_test) invokes the child_test 10 000 times. I attached an starce output of a manual child_test run. If anyone guides my (I'm no big C programmer), I'd be welcome to debug/track down this problem further. ---------------------------------------------------------------------- >Comment By: Ton Voon (tonvoon) Date: 2008-02-11 21:24 Message: Logged In: YES user_id=664364 Originator: NO Thomas, Good idea. Done in svn. Link is now: http://nagiosplugins.org/faq/compile/configure_appears_to_hang I'm going to mark this as pending, so this call will auto close after 7 days. Ton ---------------------------------------------------------------------- Comment By: Thomas Guyot (dermoth) Date: 2008-02-11 16:09 Message: Logged In: YES user_id=375623 Originator: NO Why not printing out this link with a sort note just before running the test? ---------------------------------------------------------------------- Comment By: Ton Voon (tonvoon) Date: 2008-02-11 15:43 Message: Logged In: YES user_id=664364 Originator: NO Henry, Does this answer your questions? http://nagiosplugins.org/node/7 Ton ---------------------------------------------------------------------- Comment By: Sascha Runschke (srunschke) Date: 2008-02-11 14:29 Message: Logged In: YES user_id=2006232 Originator: NO The type of check cannot be changed, since the Redhat spopen bug evolves around a futex race condition in combination with the ISC DNS libraries. Those are linked with bind, nslookup, dig and the like. If you change the actual check binary, then the check itself is foobar. It'll be better to implement a "pre-check" if DNS resolving is possible at all and bail out if not. S ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 14:04 Message: Logged In: YES user_id=885432 Originator: YES Finally had a look into the code of child_test, and of course it take forever, it's running nslookup from there, and nagios isn't attached to the internet. So i changed (removed/added comments) the executed command to 'date' (hope the test still does what it should do), now the test runs in a reasonable time. However, imho the test should be fixed to run something internet-independent. So leave the bug open. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891143&group_id=29880 From ton.voon at altinity.com Mon Feb 11 22:28:44 2008 From: ton.voon at altinity.com (Ton Voon) Date: Mon, 11 Feb 2008 21:28:44 +0000 Subject: [Nagiosplug-devel] Nagiosplugins 1.4.11 on HP UX In-Reply-To: <20080211154739.GC40233203@CIS.FU-Berlin.DE> References: <20080211154739.GC40233203@CIS.FU-Berlin.DE> Message-ID: On 11 Feb 2008, at 15:47, Holger Weiss wrote: > * Matthias.Broenner at systemagmbh.de [2008-02-11 15:28]: >> cc: "utils_base.c", line 108: error 1649: Illegal integer-pointer >> combination for >. >> cc: "utils_base.c", line 108: error 1563: Expression in if must be >> scalar. > > Ugh, that's indeed broken. A quick and dirty workaround for you > would be to > delete the lines 108-111 in utils_base.c: > > if (*my_thresholds > 0) { /* Not sure why, but sometimes could be > -1 */ > /* printf("Freeing here: %d\n", *my_thresholds); */ > free(*my_thresholds); > } > > Removing these lines creates a minor memory leak, but that won't be a > problem in practice. A proper fix will require a little more work. Ah! That's my ugly code there :( What's a proper fix? My pointer knowledge is pretty poor... Ton http://www.altinity.com UK: +44 (0)870 787 9243 US: +1 866 879 9184 Fax: +44 (0)845 280 1725 Skype: tonvoon From ton.voon at altinity.com Mon Feb 11 22:39:38 2008 From: ton.voon at altinity.com (Ton Voon) Date: Mon, 11 Feb 2008 21:39:38 +0000 Subject: [Nagiosplug-devel] Missing SSL hint in REQUIREMENT In-Reply-To: <47B07D7F.8010108@process-zero.de> References: <47B07D7F.8010108@process-zero.de> Message-ID: On 11 Feb 2008, at 16:53, Hendrik B?cker wrote: > it would be fine to place a generic hint into the REQUIREMENTS file to > let the user know that they need the openssl libraries to get > > check_ldaps > check_http --ssl > and so on... > > Maybe a summary after the configure script which plugins were not be > existant cause of missing dependencies would be nice to. Good idea. I've updated the REQUIREMENTS file and added a FAQ at http://nagiosplugins.org/node/84 I'm not too sure about printing out the plugins that would **not** be compiled. Where do you draw the line? I can see a horrendous dependency list that would have to be maintained. In fact, the Makefile and the resultant executables is your list of "plugins that can be compiled". > IMHO the configure output is to long to see the single "WARNING" lines > in it... and to tell the truth - show me a new user who looks for > warnings ;). I can empathise. I don't tend to read REQUIREMENTS files either.... Ton http://www.altinity.com UK: +44 (0)870 787 9243 US: +1 866 879 9184 Fax: +44 (0)845 280 1725 Skype: tonvoon From andurin at process-zero.de Mon Feb 11 22:47:41 2008 From: andurin at process-zero.de (=?ISO-8859-1?Q?Hendrik_B=E4cker?=) Date: Mon, 11 Feb 2008 22:47:41 +0100 Subject: [Nagiosplug-devel] Missing SSL hint in REQUIREMENT In-Reply-To: References: <47B07D7F.8010108@process-zero.de> Message-ID: <47B0C27D.6090500@process-zero.de> Hi Ton, thanks for your fast reply. Ton Voon schrieb: > On 11 Feb 2008, at 16:53, Hendrik B?cker wrote: > >> it would be fine to place a generic hint into the REQUIREMENTS file to >> let the user know that they need the openssl libraries to get >> >> check_ldaps >> check_http --ssl >> and so on... >> >> Maybe a summary after the configure script which plugins were not be >> existant cause of missing dependencies would be nice to. > > Good idea. I've updated the REQUIREMENTS file and added a FAQ at http://nagiosplugins.org/node/84 > Great > I'm not too sure about printing out the plugins that would **not** be > compiled. Where do you draw the line? I can see a horrendous > dependency list that would have to be maintained. In fact, the > Makefile and the resultant executables is your list of "plugins that > can be compiled". > What do you think of cat all the WARNING outputs together within the configure and output them all behind the system information gathering stuff? >> IMHO the configure output is to long to see the single "WARNING" lines >> in it... and to tell the truth - show me a new user who looks for >> warnings ;). > > I can empathise. I don't tend to read REQUIREMENTS files either.... > Yeah - but if it's documentated you are able to point the noobs on it ;) smiled regards Hendrik From thomas at zango.com Mon Feb 11 22:50:08 2008 From: thomas at zango.com (Thomas Guyot-Sionnest) Date: Mon, 11 Feb 2008 16:50:08 -0500 Subject: [Nagiosplug-devel] Nagiosplugins 1.4.11 on HP UX In-Reply-To: References: <20080211154739.GC40233203@CIS.FU-Berlin.DE> Message-ID: <47B0C310.9030305@zango.com> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Ton Voon wrote: > On 11 Feb 2008, at 15:47, Holger Weiss wrote: > >> * Matthias.Broenner at systemagmbh.de [2008-02-11 15:28]: >>> cc: "utils_base.c", line 108: error 1649: Illegal integer-pointer >>> combination for >. >>> cc: "utils_base.c", line 108: error 1563: Expression in if must be >>> scalar. >> Ugh, that's indeed broken. A quick and dirty workaround for you >> would be to >> delete the lines 108-111 in utils_base.c: >> >> if (*my_thresholds > 0) { /* Not sure why, but sometimes could be >> -1 */ >> /* printf("Freeing here: %d\n", *my_thresholds); */ >> free(*my_thresholds); >> } >> >> Removing these lines creates a minor memory leak, but that won't be a >> problem in practice. A proper fix will require a little more work. > > Ah! That's my ugly code there :( > > What's a proper fix? My pointer knowledge is pretty poor... I came across this not so long ago... since *my_thresholds is a pointer it seemed wrong. I tried with: if (*my_thresholds != NULL) { and I couldn't see any breakage trough automated tests... If you could specify in which case it could be -1 that would help although we could also explicitly ask the calling app to free (or not, it doesn't really matter for a one-time plugin) its threshold pointer if it needs to redefine it with set_thresholds. In most case this is called once anyways. Typical ex. from check_cluster: thresholds *thresholds = NULL; [...] if(process_arguments(argc,argv)==ERROR) usage(_("Could not parse arguments")); set_thresholds(&thresholds, warn_threshold, crit_threshold); In this case (which is I believe is like every plugins that use them) there should be no need to free it. It can be particularly dangerous is the writer forget to initialize the pointer to NULL, as it could try freeing random memory. - -- Thomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHsMMQ6dZ+Kt5BchYRApjqAJwI8+9zfyi8Q7BSHXpYs31opE4t8gCeMnY3 xjfFmroka2QCm/S6KOUqVwI= =ADtX -----END PGP SIGNATURE----- From ajeshb at gmail.com Mon Feb 11 22:58:05 2008 From: ajeshb at gmail.com (ajeshb at gmail.com) Date: Mon, 11 Feb 2008 21:58:05 +0000 Subject: [Nagiosplug-devel] Nagiosplugins 1.4.11 on HP UX In-Reply-To: <47B0C310.9030305@zango.com> References: <20080211154739.GC40233203@CIS.FU-Berlin.DE><47B0C310.9030305@zango.com> Message-ID: <1037419040-1202767194-cardhu_decombobulator_blackberry.rim.net-1836838843-@bxe011.bisx.prod.on.blackberry> _ -----Original Message----- From: Thomas Guyot-Sionnest Date: Mon, 11 Feb 2008 16:50:08 To:Nagios Plugin Development Mailing List Subject: Re: [Nagiosplug-devel] Nagiosplugins 1.4.11 on HP UX -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Ton Voon wrote: > On 11 Feb 2008, at 15:47, Holger Weiss wrote: > >> * Matthias.Broenner at systemagmbh.de [2008-02-11 15:28]: >>> cc: "utils_base.c", line 108: error 1649: Illegal integer-pointer >>> combination for >. >>> cc: "utils_base.c", line 108: error 1563: Expression in if must be >>> scalar. >> Ugh, that's indeed broken. A quick and dirty workaround for you >> would be to >> delete the lines 108-111 in utils_base.c: >> >> if (*my_thresholds > 0) { /* Not sure why, but sometimes could be >> -1 */ >> /* printf("Freeing here: %d\n", *my_thresholds); */ >> free(*my_thresholds); >> } >> >> Removing these lines creates a minor memory leak, but that won't be a >> problem in practice. A proper fix will require a little more work. > > Ah! That's my ugly code there :( > > What's a proper fix? My pointer knowledge is pretty poor... I came across this not so long ago... since *my_thresholds is a pointer it seemed wrong. I tried with: if (*my_thresholds != NULL) { and I couldn't see any breakage trough automated tests... If you could specify in which case it could be -1 that would help although we could also explicitly ask the calling app to free (or not, it doesn't really matter for a one-time plugin) its threshold pointer if it needs to redefine it with set_thresholds. In most case this is called once anyways. Typical ex. from check_cluster: thresholds *thresholds = NULL; [...] if(process_arguments(argc,argv)==ERROR) usage(_("Could not parse arguments")); set_thresholds(&thresholds, warn_threshold, crit_threshold); In this case (which is I believe is like every plugins that use them) there should be no need to free it. It can be particularly dangerous is the writer forget to initialize the pointer to NULL, as it could try freeing random memory. - -- Thomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHsMMQ6dZ+Kt5BchYRApjqAJwI8+9zfyi8Q7BSHXpYs31opE4t8gCeMnY3 xjfFmroka2QCm/S6KOUqVwI= =ADtX -----END PGP SIGNATURE----- ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________________ Nagios Plugin Development Mailing List Nagiosplug-devel at lists.sourceforge.net Unsubscribe at https://lists.sourceforge.net/lists/listinfo/nagiosplug-devel ::: Please include plugins version (-v) and OS when reporting any issue. ::: Messages without supporting info will risk being sent to /dev/null From thomas at zango.com Mon Feb 11 23:01:23 2008 From: thomas at zango.com (Thomas Guyot-Sionnest) Date: Mon, 11 Feb 2008 17:01:23 -0500 Subject: [Nagiosplug-devel] Missing SSL hint in REQUIREMENT In-Reply-To: References: <47B07D7F.8010108@process-zero.de> Message-ID: <47B0C5B3.80600@zango.com> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Ton Voon wrote: > On 11 Feb 2008, at 16:53, Hendrik B?cker wrote: > > >> IMHO the configure output is to long to see the single "WARNING" lines >> in it... and to tell the truth - show me a new user who looks for >> warnings ;). > > I can empathise. I don't tend to read REQUIREMENTS files either.... Configure has some useful but little-known options, like asking for quiet output: $ ./configure -q appending configuration tag "CXX" to libtool appending configuration tag "F77" to libtool configure: WARNING: Skipping PostgreSQL plugin (check_pgsql) configure: WARNING: LIBS="-lcrypt " CPPFLAGS="" configure: WARNING: install PostgreSQL libs to compile this plugin (see REQUIREMENTS). configure: WARNING: Skipping radius plugin configure: WARNING: install radius libs to compile this plugin (see REQUIREMENTS). configure: WARNING: Get lmstat from Globetrotter Software to monitor flexlm licenses configure: WARNING: Get qstat from http://www.activesw.com/people/steve/qstat.html in order to make check_game plugin configure: WARNING: Could not find qmail-qstat or eqivalent chmod: changing permissions of `./config.status': Operation not permitted config.status: creating po/POTFILES config.status: creating po/Makefile --with-apt-get-command: /usr/bin/apt-get --with-ping6-command: /bin/ping6 -n -U -w %d -c %d %s --with-ping-command: /bin/ping -n -U -w %d -c %d %s --with-ipv6: yes --with-mysql: /usr/bin/mysql_config --with-openssl: yes --with-gnutls: no --with-perl: /usr/bin/perl --enable-perl-modules: no --with-cgiurl: /nagios/cgi-bin --with-trusted-path: /bin:/sbin:/usr/bin:/usr/sbin Although I'd not sure sure how to do it I think it would also be really nice to so see which plugins are and aren't compiled at the end of configure (in addition of the --with options as shown above) - -- Thomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHsMWz6dZ+Kt5BchYRAsKUAJ9qDvQvJJE2mfySHuDEyFu455q7GwCdF6QK jjADJE/PWFqP5bqE0Ol9FTQ= =1nH9 -----END PGP SIGNATURE----- From holger at CIS.FU-Berlin.DE Mon Feb 11 23:46:11 2008 From: holger at CIS.FU-Berlin.DE (Holger Weiss) Date: Mon, 11 Feb 2008 23:46:11 +0100 Subject: [Nagiosplug-devel] Nagiosplugins 1.4.11 on HP UX In-Reply-To: References: <20080211154739.GC40233203@CIS.FU-Berlin.DE> Message-ID: <20080211224611.GD40233203@CIS.FU-Berlin.DE> * Ton Voon [2008-02-11 21:28]: > On 11 Feb 2008, at 15:47, Holger Weiss wrote: > > if (*my_thresholds > 0) { /* Not sure why, but sometimes could be -1 */ > > /* printf("Freeing here: %d\n", *my_thresholds); */ > > free(*my_thresholds); > > } > > > > Removing these lines creates a minor memory leak, but that won't be a > > problem in practice. A proper fix will require a little more work. > > Ah! That's my ugly code there :( > > What's a proper fix? *my_thresholds is a pointer and from the comment that *my_thresholds sometimes was -1 I assumed that it may be uninitialized in some cases (so that it neither points to allocated memory nor to NULL). This is the only possible reason I see that it could ever equal -1 (apart from memory being corrupted). However, I now looked through our code and couldn't find any instance where *my_thresholds isn't initialized to NULL. So, I have no idea how it could ever equal -1. Do you happen to remember any details? Any idea how we could try to reproduce that? Holger From ton.voon at altinity.com Tue Feb 12 00:34:13 2008 From: ton.voon at altinity.com (Ton Voon) Date: Mon, 11 Feb 2008 23:34:13 +0000 Subject: [Nagiosplug-devel] Nagiosplugins 1.4.11 on HP UX In-Reply-To: <20080211224611.GD40233203@CIS.FU-Berlin.DE> References: <20080211154739.GC40233203@CIS.FU-Berlin.DE> <20080211224611.GD40233203@CIS.FU-Berlin.DE> Message-ID: <7672946D-BF81-48EF-86F3-FA23CC32C511@altinity.com> On 11 Feb 2008, at 22:46, Holger Weiss wrote: > However, I now looked through our code and couldn't find any instance > where *my_thresholds isn't initialized to NULL. So, I have no idea > how > it could ever equal -1. Do you happen to remember any details? Any > idea how we could try to reproduce that? I can't recall. I tried looking in the svn log, but it was probably before the move from cvs. I think I initially used *my_thresholds != NULL, but some OSes had *my_thresholds = -1, causing an error at the free. Ton http://www.altinity.com UK: +44 (0)870 787 9243 US: +1 866 879 9184 Fax: +44 (0)845 280 1725 Skype: tonvoon From dermoth at aei.ca Tue Feb 12 04:22:08 2008 From: dermoth at aei.ca (Thomas Guyot-Sionnest) Date: Mon, 11 Feb 2008 22:22:08 -0500 Subject: [Nagiosplug-devel] Nagiosplugins 1.4.11 on HP UX In-Reply-To: <7672946D-BF81-48EF-86F3-FA23CC32C511@altinity.com> References: <20080211154739.GC40233203@CIS.FU-Berlin.DE> <20080211224611.GD40233203@CIS.FU-Berlin.DE> <7672946D-BF81-48EF-86F3-FA23CC32C511@altinity.com> Message-ID: <47B110E0.9060303@aei.ca> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11/02/08 06:34 PM, Ton Voon wrote: > On 11 Feb 2008, at 22:46, Holger Weiss wrote: > >> However, I now looked through our code and couldn't find any instance >> where *my_thresholds isn't initialized to NULL. So, I have no idea >> how >> it could ever equal -1. Do you happen to remember any details? Any >> idea how we could try to reproduce that? > > > I can't recall. I tried looking in the svn log, but it was probably > before the move from cvs. > > I think I initially used *my_thresholds != NULL, but some OSes had > *my_thresholds = -1, causing an error at the free. Normally the thresholds variable should be initialized to NULL, so any non-null should be free()able. Anyways my vote would be to leave the job of freeing that variable prior to re-assignation to the calling program. Considering that most programs calls that function only once it makes sense... On top of my head that could possibly break check_disk that uses threshold functions extensively and supports multiple objects and their respective thresholds. Any objection that I drop these lines and move the free to the plugins that re-assign thresholds? Thomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHsRDg6dZ+Kt5BchYRAh6DAJ40kMEA0XL7JLTqdsZn2BbbR5JpOwCfRLDW A0hi6+sUJjAOg0K0C5RlN4U= =iIsH -----END PGP SIGNATURE----- From noreply at sourceforge.net Tue Feb 12 09:26:38 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Tue, 12 Feb 2008 00:26:38 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1891183 ] 1.4.11 doesn't compile (2x) Message-ID: Bugs item #1891183, was opened at 2008-02-11 15:56 Message generated for change (Comment added) made by henry78 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: Invalid Priority: 5 Private: No Submitted By: Henry78 (henry78) Assigned to: Nobody/Anonymous (nobody) Summary: 1.4.11 doesn't compile (2x) Initial Comment: I got this complie error, during 'makeing' nagios-plugins-1.4.11 on RHEL4: ----------8<---------- basename.c: In function `char* base_name(const char*)': basename.c:95: error: invalid conversion from `void*' to `char*' make[3]: *** [basename.o] Error 1 ---------->8---------- 'cause i didn't need it, i removed the part for rewriting windows(?) paths from basename.c. distclean, configure, make and a similar error occured: ----------8<---------- dirname.c: In function `char* dir_name(const char*)': dirname.c:79: error: invalid conversion from `void*' to `char*' make[3]: *** [dirname.o] Error 1 ---------->8---------- It's a rewrite of a filename/path there too, but I'm not sure why it throws an Error. The corresponding line 79 from dirname.c: ----------8<---------- char *dir = xmalloc (length + append_dot + 1); ---------->8---------- ---------------------------------------------------------------------- >Comment By: Henry78 (henry78) Date: 2008-02-12 09:26 Message: Logged In: YES user_id=885432 Originator: YES Works perfektly now. What ever was borked has been fixed by the upgrade. Thanks for your help, bug may be closed. ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 22:21 Message: Logged In: YES user_id=759506 Originator: NO The new error again looks like your GCC installation is somehow borked. GCC 3.4.5 should be just fine, but an upgrade is probably a good idea, just in order to replace the old stuff. I'd be interested in whether that fixes it. By the way, my example doesn't use K&R style, it's plain ANSI C. The thing your compiler refused to do (in the plugins code and in my example) was an implicit conversion of a pointer to void to a pointer to char, which is just fine in C (both C89 and C99), but is not allowed in C++ (where an explicit cast would be required to convert a pointer to void). "-x c" forces gcc and g++ to expect C input. Without "-x", gcc chooses the language based on the file name suffix (see "man gcc"), while g++ expects C++ unless you use "-x" (which is how your gcc behaves for some reason). ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 18:43 Message: Logged In: YES user_id=885432 Originator: YES I got a 'C-Guru' to my desk for some minutes. He explained that your test.c code is valid K&R C, but I need to set the gcc-switch "-x c" to compile it. And ist complied fine. Even a hello-world-like line was printed after adding that to test.c The pity is: C-Guru is gone, and the compilation fails with other errors: -----8<----- gcc -x c -o check_apt check_apt.o utils.o runcmd.o -L/root/nagios/nagios-plugins-1.4.11/plugins ../lib/libnagiosplug.a ../gl /libgnu.a check_apt.o:1: error: stray '\127' in program ----->8----- I'll update to the latest available gcc for RHEL4 (that's 3.4.6), and report back. ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 17:14 Message: Logged In: YES user_id=759506 Originator: NO Then there's something seriously broken with your gcc installation, my example is perfectly valid C code. Maybe try to re-install your GCC package(s)? Other than that, I have no idea, sorry. ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 17:05 Message: Logged In: YES user_id=885432 Originator: YES No, the test.c doesn't complile. It throws an error: -----8<----- test.c:2: error: invalid conversion from `void*' to `char*' ----->8----- It works if I (double)quote the 'v'. gcc -v gcc version 3.4.5 20051201 (Red Hat 3.4.5-2) ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 16:57 Message: Logged In: YES user_id=759506 Originator: NO Odd. Does compiling the following code using "gcc -o test test.c" work? /* test.c */ int main(void) { void *v; char *c = v; return 0; } ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 16:12 Message: Logged In: YES user_id=885432 Originator: YES ----------8<---------- if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../intl -g -O2 -MT dirname.o -MD -MP -MF ".deps/dirname.Tpo" -c -o dirname.o dirname.c; \ then mv -f ".deps/dirname.Tpo" ".deps/dirname.Po"; else rm -f ".deps/dirname.Tpo"; exit 1; fi ---------->8---------- That's the corresponding compiler command line. I'm pretty sure it uses gcc... ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 16:07 Message: Logged In: YES user_id=759506 Originator: NO You didn't post the compiler command line which threw the error, but it seems as if you're using g++ instead of gcc for some reason. Is the environment variable CC set to "g++" or something like that? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 From ton.voon at altinity.com Tue Feb 12 10:06:41 2008 From: ton.voon at altinity.com (Ton Voon) Date: Tue, 12 Feb 2008 09:06:41 +0000 Subject: [Nagiosplug-devel] Nagiosplugins 1.4.11 on HP UX In-Reply-To: <47B110E0.9060303@aei.ca> References: <20080211154739.GC40233203@CIS.FU-Berlin.DE> <20080211224611.GD40233203@CIS.FU-Berlin.DE> <7672946D-BF81-48EF-86F3-FA23CC32C511@altinity.com> <47B110E0.9060303@aei.ca> Message-ID: On 12 Feb 2008, at 03:22, Thomas Guyot-Sionnest wrote: > Normally the thresholds variable should be initialized to NULL, so any > non-null should be free()able. Anyways my vote would be to leave the > job > of freeing that variable prior to re-assignation to the calling > program. > Considering that most programs calls that function only once it makes > sense... > > On top of my head that could possibly break check_disk that uses > threshold functions extensively and supports multiple objects and > their > respective thresholds. > > Any objection that I drop these lines and move the free to the plugins > that re-assign thresholds? Yeah, I think that makes sense. Ton http://www.altinity.com UK: +44 (0)870 787 9243 US: +1 866 879 9184 Fax: +44 (0)845 280 1725 Skype: tonvoon From Matthias.Broenner at systemagmbh.de Tue Feb 12 10:46:51 2008 From: Matthias.Broenner at systemagmbh.de (Matthias.Broenner at systemagmbh.de) Date: Tue, 12 Feb 2008 10:46:51 +0100 Subject: [Nagiosplug-devel] Nagiosplug-devel Digest, Vol 21, Issue 7 (Olivier 'Babar' Raginel) In-Reply-To: Message-ID: Hello i fixed the error according to this article. I compiled the plugins on HPUX sucessfully :) @Ton what should i do now ? Should i wait until the 2 HP UX errors are fixed in the source ? Should i fix them by hand build and subbmit daily to tinderbox ? https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1864550&group_id=29880 diff -Naur nagios-plugins-1.4.11/plugins/check_swap.c nagios-plugins-1.4.11-hpux-floor/plugins/check_swap.c --- nagios-plugins-1.4.11/plugins/check_swap.c 2007-12-10 08:52:00.000000000 +0100 +++ nagios-plugins-1.4.11-hpux-floor/plugins/check_swap.c 2008-01-05 17:11:46.696863797 +0100 @@ -427,7 +427,7 @@ else if (strstr (optarg, ",") && strstr (optarg, "%") && sscanf (optarg, "%f,%d%%", &warn_size_bytes, &warn_percent) == 2) { - warn_size_bytes = floorf(warn_size_bytes); + warn_size_bytes = (float) floor(warn_size_bytes); break; } else if (strstr (optarg, "%") && @@ -445,7 +445,7 @@ else if (strstr (optarg, ",") && strstr (optarg, "%") && sscanf (optarg, "%f,%d%%", &crit_size_bytes, &crit_percent) == 2) { - crit_size_bytes = floorf(crit_size_bytes); + crit_size_bytes = (float) floor(crit_size_bytes); break; } else if (strstr (optarg, "%") && Message: 1 Date: Mon, 11 Feb 2008 22:18:17 +0100 From: Olivier 'Babar' Raginel Subject: Re: [Nagiosplug-devel] Nagiosplug-devel Digest, Vol 21, Issue 7 To: Nagios Plugin Development Mailing List Message-ID: <20080211211817.GA7087 at mail.babar.us> Content-Type: text/plain; charset=us-ascii On Mon, Feb 11, 2008 at 05:36:37PM +0100, Matthias.Broenner at systemagmbh.de wrote: > i removed the line from 108-111 in utils_base.c. Now "make" goes on :) ... > until next error.... > cc -g -o check_swap check_swap.o utils.o popen.o > -L/root/nagios-plugins-1.4.11/plugins -L/opt/openssl/lib -lm > ../lib/libnagiosplug.a ../gl/libgnu.a > /usr/ccs/bin/ld: Unsatisfied symbols: > floorf (first referenced in check_swap.o) (code) > *** Error exit code 1 That's weird, normally floorf is part of libm, and there is -lm. But, according to: http://www.gnu.org/software/gnulib/manual/html_node/floorf.html it's missing on HP-UX 11. In theory, you should be able to change all floorf into floor and it should work, but you might have some overflow issues. A patch for this shall require some m4 configure tweaking and a few defines. Another hack might be to use these: #ifndef floorf #define floorf (float)floor #endif Find one .h which gets included in at least this .c :) But honestly, I'm not happy with any solution (which are the same in fact, just 2 different ways to write it). I let main coders decide what's the best way to do so, but this should help you go on with the compilation. Kind regards, -- Babar. Viele Gr??e / Best Regards Matthias Br?nner ---------------------------------------------------------------------- --- [ Mitarbeiter / employee ] --- Matthias Br?nner Tel.: +49 941 / 78392 - 11 Fax: +49 941 / 78392 - 72 Mailto: matthias.broenner at SYSTEMAGmbH.de --- [ Standort / location ] --- Schikanederstr. 2 B - Posthof, 93053 Regensburg, GERMANY --- [ Firma / company ] --- SYSTEMA Systementwicklung Dipl.-Inf. Manfred Austen GmbH Manfred-von-Ardenne-Ring 6, 01099 Dresden, GERMANY Handelsregister: HRB 5422 Amtsgericht Dresden USt.-ID-Nr.: DE 159 607 786 Gesch?ftsf?hrer: Herr Manfred Austen http://www.SYSTEMAGmbH.de ---------------------------------------------------------------------- From noreply at sourceforge.net Tue Feb 12 12:29:15 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Tue, 12 Feb 2008 03:29:15 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1891183 ] 1.4.11 doesn't compile (2x) Message-ID: Bugs item #1891183, was opened at 2008-02-11 15:56 Message generated for change (Comment added) made by hweiss You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed Resolution: Invalid Priority: 5 Private: No Submitted By: Henry78 (henry78) Assigned to: Nobody/Anonymous (nobody) Summary: 1.4.11 doesn't compile (2x) Initial Comment: I got this complie error, during 'makeing' nagios-plugins-1.4.11 on RHEL4: ----------8<---------- basename.c: In function `char* base_name(const char*)': basename.c:95: error: invalid conversion from `void*' to `char*' make[3]: *** [basename.o] Error 1 ---------->8---------- 'cause i didn't need it, i removed the part for rewriting windows(?) paths from basename.c. distclean, configure, make and a similar error occured: ----------8<---------- dirname.c: In function `char* dir_name(const char*)': dirname.c:79: error: invalid conversion from `void*' to `char*' make[3]: *** [dirname.o] Error 1 ---------->8---------- It's a rewrite of a filename/path there too, but I'm not sure why it throws an Error. The corresponding line 79 from dirname.c: ----------8<---------- char *dir = xmalloc (length + append_dot + 1); ---------->8---------- ---------------------------------------------------------------------- >Comment By: Holger Weiss (hweiss) Date: 2008-02-12 12:29 Message: Logged In: YES user_id=759506 Originator: NO Okay, thanks for your feedback. ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-12 09:26 Message: Logged In: YES user_id=885432 Originator: YES Works perfektly now. What ever was borked has been fixed by the upgrade. Thanks for your help, bug may be closed. ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 22:21 Message: Logged In: YES user_id=759506 Originator: NO The new error again looks like your GCC installation is somehow borked. GCC 3.4.5 should be just fine, but an upgrade is probably a good idea, just in order to replace the old stuff. I'd be interested in whether that fixes it. By the way, my example doesn't use K&R style, it's plain ANSI C. The thing your compiler refused to do (in the plugins code and in my example) was an implicit conversion of a pointer to void to a pointer to char, which is just fine in C (both C89 and C99), but is not allowed in C++ (where an explicit cast would be required to convert a pointer to void). "-x c" forces gcc and g++ to expect C input. Without "-x", gcc chooses the language based on the file name suffix (see "man gcc"), while g++ expects C++ unless you use "-x" (which is how your gcc behaves for some reason). ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 18:43 Message: Logged In: YES user_id=885432 Originator: YES I got a 'C-Guru' to my desk for some minutes. He explained that your test.c code is valid K&R C, but I need to set the gcc-switch "-x c" to compile it. And ist complied fine. Even a hello-world-like line was printed after adding that to test.c The pity is: C-Guru is gone, and the compilation fails with other errors: -----8<----- gcc -x c -o check_apt check_apt.o utils.o runcmd.o -L/root/nagios/nagios-plugins-1.4.11/plugins ../lib/libnagiosplug.a ../gl /libgnu.a check_apt.o:1: error: stray '\127' in program ----->8----- I'll update to the latest available gcc for RHEL4 (that's 3.4.6), and report back. ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 17:14 Message: Logged In: YES user_id=759506 Originator: NO Then there's something seriously broken with your gcc installation, my example is perfectly valid C code. Maybe try to re-install your GCC package(s)? Other than that, I have no idea, sorry. ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 17:05 Message: Logged In: YES user_id=885432 Originator: YES No, the test.c doesn't complile. It throws an error: -----8<----- test.c:2: error: invalid conversion from `void*' to `char*' ----->8----- It works if I (double)quote the 'v'. gcc -v gcc version 3.4.5 20051201 (Red Hat 3.4.5-2) ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 16:57 Message: Logged In: YES user_id=759506 Originator: NO Odd. Does compiling the following code using "gcc -o test test.c" work? /* test.c */ int main(void) { void *v; char *c = v; return 0; } ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 16:12 Message: Logged In: YES user_id=885432 Originator: YES ----------8<---------- if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../intl -g -O2 -MT dirname.o -MD -MP -MF ".deps/dirname.Tpo" -c -o dirname.o dirname.c; \ then mv -f ".deps/dirname.Tpo" ".deps/dirname.Po"; else rm -f ".deps/dirname.Tpo"; exit 1; fi ---------->8---------- That's the corresponding compiler command line. I'm pretty sure it uses gcc... ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2008-02-11 16:07 Message: Logged In: YES user_id=759506 Originator: NO You didn't post the compiler command line which threw the error, but it seems as if you're using g++ instead of gcc for some reason. Is the environment variable CC set to "g++" or something like that? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891183&group_id=29880 From dermoth at aei.ca Tue Feb 12 13:13:20 2008 From: dermoth at aei.ca (Thomas Guyot-Sionnest) Date: Tue, 12 Feb 2008 07:13:20 -0500 Subject: [Nagiosplug-devel] Regarding base64 Message-ID: <47B18D60.8090604@aei.ca> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 While changing check_smtp to use the new base64 function, I realized that it strcat "\r\n" to a string allocated by base64... From my understanding this is broken as the strcat will likely go beyond the char array. Am I missing something? Just look for 'FIXME' in check_smtp.c... Thomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHsY1g6dZ+Kt5BchYRAsi0AKDiuOIPEwePfW8m8RfdZCOJi8OhrwCgrhZQ C4GEAZmw6NHNqUVVZVL9tzs= =cg7j -----END PGP SIGNATURE----- From dermoth at aei.ca Wed Feb 13 12:47:05 2008 From: dermoth at aei.ca (Thomas Guyot-Sionnest) Date: Wed, 13 Feb 2008 06:47:05 -0500 Subject: [Nagiosplug-devel] _FILE_OFFSET_BITS in plugins/common.h Message-ID: <47B2D8B9.4080900@aei.ca> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 In plugins/common.h there's the following lines: /* This needs to be removed for Solaris servers, where 64 bit files, but 32 bit architecture This needs to be done early on because subsequent system includes use _FILE_OFFSET_BITS Cannot remove from config.h because is included by regex.c from lib/ */ #if __sun__ && !defined(_LP64) && _FILE_OFFSET_BITS == 64 #undef _FILE_OFFSET_BITS #endif Since I added AC_SYS_LARGEFILE to configure.in it should detect the filesystem interfaces available and set _FILE_OFFSET_BITS accordingly in config.h. I'm wondering is these lines can be removed... Any ideas? Thomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHsti56dZ+Kt5BchYRAsxpAJ9WFiFcewUS2OrwsvKs2rn4ma6BtwCg+OEB kf/K7Lc/GgU7uPsWByCyTu0= =EhIY -----END PGP SIGNATURE----- From nbveste at gmail.com Wed Feb 13 07:57:47 2008 From: nbveste at gmail.com (stv) Date: Wed, 13 Feb 2008 07:57:47 +0100 Subject: [Nagiosplug-devel] bug in /usr/lib/nagios/plugins/check_ica_metaframe_pub_apps.pl Message-ID: hi, there is an error in the check_ica_metaframe_pub_apps.pl plugin! in line 21 it should be: use lib qw(/usr/lib/nagios/plugins) ; regards, stefan From ton.voon at altinity.com Wed Feb 13 14:23:48 2008 From: ton.voon at altinity.com (Ton Voon) Date: Wed, 13 Feb 2008 13:23:48 +0000 Subject: [Nagiosplug-devel] _FILE_OFFSET_BITS in plugins/common.h In-Reply-To: <47B2D8B9.4080900@aei.ca> References: <47B2D8B9.4080900@aei.ca> Message-ID: On 13 Feb 2008, at 11:47, Thomas Guyot-Sionnest wrote: > In plugins/common.h there's the following lines: > > /* This needs to be removed for Solaris servers, where 64 bit files, > but > 32 bit architecture > This needs to be done early on because subsequent system includes > use > _FILE_OFFSET_BITS > Cannot remove from config.h because is included by regex.c from > lib/ */ > #if __sun__ && !defined(_LP64) && _FILE_OFFSET_BITS == 64 > #undef _FILE_OFFSET_BITS > #endif > > Since I added AC_SYS_LARGEFILE to configure.in it should detect the > filesystem interfaces available and set _FILE_OFFSET_BITS > accordingly in > config.h. I'm wondering is these lines can be removed... Any ideas? Not sure. I seem to recall putting it in: http://nagiosplug.svn.sourceforge.net/viewvc/nagiosplug/nagiosplug/trunk/plugins/common.h?r1=1462&r2=1546 It was related to the swapctl functions in check_swap for Solaris. The tracker item listed in the changelog is here: http://sourceforge.net/tracker/index.php?func=detail&aid=1588031&group_id=29880&atid=397599 I think I found there was something about the order of the include files, where _FILE_OFFSET_BITS was changed later on. Don't know if the AC_SYS_LARGEFILE marks it early enough. Ton http://www.altinity.com UK: +44 (0)870 787 9243 US: +1 866 879 9184 Fax: +44 (0)845 280 1725 Skype: tonvoon From noreply at sourceforge.net Wed Feb 13 19:11:52 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Wed, 13 Feb 2008 10:11:52 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1892974 ] check_ping: Option to ignore duplicate replies Message-ID: Patches item #1892974, was opened at 2008-02-13 13:11 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1892974&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jeffrey Goldschrafe (jgoldschrafe) Assigned to: Nobody/Anonymous (nobody) Summary: check_ping: Option to ignore duplicate replies Initial Comment: Patch against check_ping v1917 (nagios-plugins 1.4.11) Tested on operating system: Debian Unstable Tested on architecture: i386 Tested with compiler: gcc 4.1.3 This patch adds a flag to check_ping that allows it to ignore duplicate responses and not return warning status when one is received. This is required when monitoring some very stupid software load balancers like one included in an operating system from Redmond, Washington. I've also replaced double spaces with tabs in spots to bring them in line with the rest of the code. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1892974&group_id=29880 From noreply at sourceforge.net Wed Feb 13 20:18:12 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Wed, 13 Feb 2008 11:18:12 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1887297 ] check_disk --local fails due missing arg no one is needed Message-ID: Bugs item #1887297, was opened at 2008-02-05 23:07 Message generated for change (Comment added) made by psychotrahe You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1887297&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Argument proccessing Group: Release (specify) >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Jan Wagner (cyco_dd) >Assigned to: Matthias Eble (psychotrahe) Summary: check_disk --local fails due missing arg no one is needed Initial Comment: check_disk --local requires argument while check_disk -l doesn't see also http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=405537 a patch is attached. ---------------------------------------------------------------------- >Comment By: Matthias Eble (psychotrahe) Date: 2008-02-13 20:18 Message: Logged In: YES user_id=1694341 Originator: NO Hi Jan, this is fixed in svn, now. Thanks for your report Matthias ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1887297&group_id=29880 From noreply at sourceforge.net Wed Feb 13 21:36:23 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Wed, 13 Feb 2008 12:36:23 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1878972 ] fixes compilation of check_pgsql with postgresql 8.3 Message-ID: Bugs item #1878972, was opened at 2008-01-24 16:47 Message generated for change (Settings changed) made by psychotrahe You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1878972&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Compilation Group: Release (specify) >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Jan Wagner (cyco_dd) Assigned to: Nobody/Anonymous (nobody) Summary: fixes compilation of check_pgsql with postgresql 8.3 Initial Comment: the attached patch fixes compilation of check_psql with postgresql 8.3. Changelog of postgresql 8.3: - Move NAMEDATALEN definition from postgres_ext.h to pg_config_manual.h. It used to be part of libpq's exported interface many releases ago, but now it's no longer necessary to make it accessible to clients. The patch is against 1.4.11. With kind regards, Jan. ---------------------------------------------------------------------- Comment By: Matthias Eble (psychotrahe) Date: 2008-02-13 21:36 Message: Logged In: YES user_id=1694341 Originator: NO this problem is now fixed in cvs. thank you for your report. ---------------------------------------------------------------------- Comment By: Jan Wagner (cyco_dd) Date: 2008-02-05 22:57 Message: Logged In: YES user_id=1345239 Originator: YES see also http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=462509 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1878972&group_id=29880 From noreply at sourceforge.net Thu Feb 14 21:47:25 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 14 Feb 2008 12:47:25 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1894021 ] check_ssh clean shutdown of connections Message-ID: Patches item #1894021, was opened at 2008-02-14 12:47 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1894021&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Don Johnson (drj33) Assigned to: Nobody/Anonymous (nobody) Summary: check_ssh clean shutdown of connections Initial Comment: Patch against Plugin Version check_ssh v1813 (nagios-plugins 1.4.11) Plugin Name: check_ssh Example Plugin Commandline: ./check_ssh -H mail Tested on operating system: CentOS 5.1 (linux 2.6.18) Tested on architecture: intel Tested with compiler: gcc 4.1.2 I was noticing quite a few errors in my /var/log/secure on monitored servers like: Feb 14 12:18:33 mail sshd[3250]: fatal: Read from socket failed: Connection reset by peer ...and when I looked at the code, the connection was just being close()d, and that was it, closing the connection with a simple RST, which the other end doesn't enjoy (although nagios is content) So, I tried adding a 'shutdown(sd, SHUT_RDWR);' right before the 'close(sd);' and the error isn't showing up anymore in the logs. Note: I don't know C, just perl. I looked up shutdown() and tried it, and it worked, that's all! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1894021&group_id=29880 From noreply at sourceforge.net Fri Feb 15 15:27:17 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 15 Feb 2008 06:27:17 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1831132 ] add HEAD support to check_http Message-ID: Patches item #1831132, was opened at 2007-11-13 15:27 Message generated for change (Comment added) made by svennierlein You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1831132&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: sni (svennierlein) Assigned to: Nobody/Anonymous (nobody) Summary: add HEAD support to check_http Initial Comment: Patch for: check_http v1759 (nagios-plugins 1.4.10) This patch adds an additional --head option to make check_http a HEAD request instead of the default GET. Plugin Name: check_http Example Plugin Commandline: ./check_http --head -H yourhost Tested on operating system: Linux Tested on architecture: SLES 9 (i586) Tested with compiler: gcc version 3.3.3 (SuSE Linux) I carefully tested the patch, but these are still my first steps with c code. ---------------------------------------------------------------------- >Comment By: sni (svennierlein) Date: 2008-02-15 14:27 Message: Logged In: YES user_id=1936413 Originator: YES New patch for revision (1.4.11 release): Id: check_http.c 1861 2007-12-11 05:57:35Z dermoth File Added: check_http.head.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1831132&group_id=29880 From noreply at sourceforge.net Fri Feb 15 16:06:07 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 15 Feb 2008 07:06:07 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1894496 ] check_http: more than one status code Message-ID: Patches item #1894496, was opened at 2008-02-15 15:06 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1894496&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: sni (svennierlein) Assigned to: Nobody/Anonymous (nobody) Summary: check_http: more than one status code Initial Comment: This patch enhances the check_http plugin to accecpt more than one status code. Example.: check_http -e 200,300,301,302,304,401,403,404 If the webserver returns any of these codes, the check is ok, otherwise critical. This patch further changes the output if a not expected status code occurs, ex.: Invalid HTTP response received from host on port 9452 "HTTP/1.1 500 Internal Server Error" Patch has been tested on Linux. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1894496&group_id=29880 From noreply at sourceforge.net Sat Feb 16 10:57:58 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Sat, 16 Feb 2008 01:57:58 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1894850 ] check_ping: incorrectly parses ping6 output Message-ID: Bugs item #1894850, was opened at 2008-02-16 10:57 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1894850&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Parsing problem Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Matej Vela (vela) Assigned to: Nobody/Anonymous (nobody) Summary: check_ping: incorrectly parses ping6 output Initial Comment: Plugin Version: 1.4.11, HEAD Plugin Name: check_ping Plugin Commandline showing issues: check_ping -H [invalid-ipv6-address] -w 5000,100% -c 5000,100% -p 1 Operating System: Debian GNU/Linux 4.0 (etch) Debian's ping6 may produce output in the following format: 3 packets transmitted, 0 received, +3 errors, 100% packet loss, time 2009ms There's a corresponding pattern in check_ping.c:450: "%*d packets transmitted, %*d received, +%*d errors, %d%% packet loss" but the pattern in check_ping.c:448 matches first: "%*d packets transmitted, %*d received, %d%% loss, time" because sscanf interprets "+3" as a match for "%d". Although the rest of the pattern doesn't match, the number of successful assignments (and thus the return value of sscanf) is still 1. A simple way to make sure the whole pattern matches is to add a "%n" specifier at the end, which will assign the number of characters matched by that point. (The same trick is used in check_http.c.) There seems to be some confusion whether "%n" affects the return value of sscanf, so it's safer to check the assigned number of characters. Patch attached. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1894850&group_id=29880 From noreply at sourceforge.net Fri Feb 22 23:00:13 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 22 Feb 2008 14:00:13 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Feature Requests-1899981 ] check_ssh protocol check Message-ID: Feature Requests item #1899981, was opened at 2008-02-22 22:00 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=1899981&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Priority: 5 Private: No Submitted By: Wart (wart) Assigned to: Nobody/Anonymous (nobody) Summary: check_ssh protocol check Initial Comment: It would be useful to be able to detect the protocols supported by the remote ssh server to locate any using the insecure ssh v1 protocol. This patch attempts to match against the protocol string in the ssh response. Example: check_ssh -H my.host.com -P 2.0 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=1899981&group_id=29880 From micmc79 at hotmail.com Wed Feb 20 08:56:55 2008 From: micmc79 at hotmail.com (MicMC MC) Date: Wed, 20 Feb 2008 08:56:55 +0100 Subject: [Nagiosplug-devel] Pluggin check_http.c avec Internet site with certificate Message-ID: Hello, We have some Internet site (https://www.ixbus.net) that we want check with nagios.This ssl web site has a client certificate authentificationWhen I try to check this Internet site with nagios and check_http we have this error (OS= Fedora 8 x86) : /usr/lib/nagios/plugins/check_http -H www.ixbus.net -p 443 -S -u /controlelegalite/messagerie.asmx --verboseGET /controlelegalite/messagerie.asmx HTTP/1.0 User-Agent: check_http/1.101 (nagios-plugins 1.4.8) Host: www.ixbus.net Error on receive Do you know how can I modify source to check internet Site with Certificate ?In Contrib directory, we have the source check_http-with-client-certificate.c. But when I try to compile it we lot of error. Best regards, David Micallef _________________________________________________________________ Nouveau ! Cr?ez votre profil Messenger ! http://home.services.spaces.live.com/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From irfan_area47 at brawijaya.ac.id Mon Feb 25 04:40:14 2008 From: irfan_area47 at brawijaya.ac.id (irfan_area47) Date: Mon, 25 Feb 2008 10:40:14 +0700 Subject: [Nagiosplug-devel] check_syslog Message-ID: <20080225034014.25533.qmail@brawijaya.ac.id> can you give me some example to use check_syslog?for example how to check log mysql thanks b4.... From noreply at sourceforge.net Mon Feb 25 11:41:48 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 25 Feb 2008 02:41:48 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1901262 ] check_mysql: Support for custom my.cnf Message-ID: Patches item #1901262, was opened at 2008-02-25 11:41 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1901262&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Thorsten T?llmann (thorstent) Assigned to: Nobody/Anonymous (nobody) Summary: check_mysql: Support for custom my.cnf Initial Comment: check_mysql can read a passwort either from the command line or from the system's my.cnf. my.cnf is world-readable and command line arguments show up in the process list. A more secure solution is to put the password in a file, only the user running the plugin can access. The patch does exactly this. By calling 'check_mysql -f /etc/mysql/nagios.cnf' the plugin reads its configuration options from the given file. I am no C guru, the code works for me and probably lacks some error handling. bye, Thorsten Patch against Plugin Version (-V output): SVN revision 1916 Plugin Name: check_mysql Example Plugin Commandline: check_mysql -f /etc/mysql/my.cnf Tested on operating system: Debian Etch Tested on architecture: i386 Tested with compiler: gcc 3.3.5 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1901262&group_id=29880 From shkodich at mail.rv.ua Mon Feb 25 17:03:38 2008 From: shkodich at mail.rv.ua (Oleksandr Shkodych) Date: Mon, 25 Feb 2008 18:03:38 +0200 Subject: [Nagiosplug-devel] check_dhcp not working Message-ID: <47C2E6DA.7010901@mail.rv.ua> Hello, help me please when i run ./check_dhcp -v -i fxp0 i see next messages ./check_dhcp -v -i fxp0 DHCP socket: 3 Hardware address: 00:08:c7:25:98:5b DHCPDISCOVER to 255.255.255.255 port 67 DHCPDISCOVER XID: 1804289383 (0x6B8B4567) DHCDISCOVER ciaddr: 0.0.0.0 DHCDISCOVER yiaddr: 0.0.0.0 DHCDISCOVER siaddr: 0.0.0.0 DHCDISCOVER giaddr: 0.0.0.0 send_dhcp_packet result: 548 No (more) data received (nfound: 0) Result=ERROR Total responses seen on the wire: 0 Valid responses for this machine: 0 CRITICAL: No DHCPOFFERs were received. and simultaneously trafshow on interface fxp0 and i see NOTHING!!! but when i use /etc/netstart with option in /etc/rc.conf ifconfig_fxp0="DHCP" in trafshow i see broadcast and common negotiations DHCP-client - DHCP-server whats wrong???? From noreply at sourceforge.net Tue Feb 26 04:20:11 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 25 Feb 2008 19:20:11 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1891143 ] popen test runs "forever" (workaraound) Message-ID: Bugs item #1891143, was opened at 2008-02-11 05:43 Message generated for change (Comment added) made by sf-robot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891143&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Compilation Group: Release (specify) >Status: Closed Resolution: None Priority: 5 Private: No Submitted By: Henry78 (henry78) Assigned to: Nobody/Anonymous (nobody) Summary: popen test runs "forever" (workaraound) Initial Comment: Using nagios-plugins-1.4.11 I run a plain ./configure, which is stuck at "checking for redhat spopen problem". The part getting stuck is the child_test, which takes 10 seconds to fail. As you see from the Makefile in the dir config_test the caller script (run_test) invokes the child_test 10 000 times. I attached an starce output of a manual child_test run. If anyone guides my (I'm no big C programmer), I'd be welcome to debug/track down this problem further. ---------------------------------------------------------------------- >Comment By: SourceForge Robot (sf-robot) Date: 2008-02-25 19:20 Message: Logged In: YES user_id=1312539 Originator: NO This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker). ---------------------------------------------------------------------- Comment By: Ton Voon (tonvoon) Date: 2008-02-11 13:24 Message: Logged In: YES user_id=664364 Originator: NO Thomas, Good idea. Done in svn. Link is now: http://nagiosplugins.org/faq/compile/configure_appears_to_hang I'm going to mark this as pending, so this call will auto close after 7 days. Ton ---------------------------------------------------------------------- Comment By: Thomas Guyot (dermoth) Date: 2008-02-11 08:09 Message: Logged In: YES user_id=375623 Originator: NO Why not printing out this link with a sort note just before running the test? ---------------------------------------------------------------------- Comment By: Ton Voon (tonvoon) Date: 2008-02-11 07:43 Message: Logged In: YES user_id=664364 Originator: NO Henry, Does this answer your questions? http://nagiosplugins.org/node/7 Ton ---------------------------------------------------------------------- Comment By: Sascha Runschke (srunschke) Date: 2008-02-11 06:29 Message: Logged In: YES user_id=2006232 Originator: NO The type of check cannot be changed, since the Redhat spopen bug evolves around a futex race condition in combination with the ISC DNS libraries. Those are linked with bind, nslookup, dig and the like. If you change the actual check binary, then the check itself is foobar. It'll be better to implement a "pre-check" if DNS resolving is possible at all and bail out if not. S ---------------------------------------------------------------------- Comment By: Henry78 (henry78) Date: 2008-02-11 06:04 Message: Logged In: YES user_id=885432 Originator: YES Finally had a look into the code of child_test, and of course it take forever, it's running nslookup from there, and nagios isn't attached to the internet. So i changed (removed/added comments) the executed command to 'date' (hope the test still does what it should do), now the test runs in a reasonable time. However, imho the test should be fixed to run something internet-independent. So leave the bug open. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1891143&group_id=29880 From hpsekhon at googlemail.com Tue Feb 26 12:22:46 2008 From: hpsekhon at googlemail.com (Hari Sekhon) Date: Tue, 26 Feb 2008 11:22:46 +0000 Subject: [Nagiosplug-devel] check_syslog In-Reply-To: <20080225034014.25533.qmail@brawijaya.ac.id> References: <20080225034014.25533.qmail@brawijaya.ac.id> Message-ID: <47C3F686.7000401@googlemail.com> irfan_area47 wrote: > can you give me some example to use check_syslog?for example how to check > log mysql > thanks b4.... > Try this plugin: http://www.nagiosexchange.org/Check_Plugins.21.0.html?&tx_netnagext_pi1[p_view]=1101 I wrote it to work with any syslog-to-mysql implementation. It sends a unique log to the logserver and then checks the database for that log in order to test the logserver stack top to bottom. It's quite flexible, both tcp and udp, as well as allowing for pretty much any mysql database structure. It works well for me but you need to be aware of how your logserver works and make sure it's set up accordingly so you can mysql access as well for the second part of the test. There is documentation on that page. If you run in to problems, email me. If you think the documentation is missing something, I'll add it. Thanks -h -- Hari Sekhon From dries at ampersant.be Tue Feb 26 10:29:27 2008 From: dries at ampersant.be (Dries Elliott) Date: Tue, 26 Feb 2008 10:29:27 +0100 Subject: [Nagiosplug-devel] Contributing a patch Message-ID: <1204018167.6688.4.camel@ampersant-desktop> Hi, I've patched the check_ping plugin, so it displays performance data. How can I contribute this plugin? Dries From thomas at zango.com Tue Feb 26 19:08:54 2008 From: thomas at zango.com (Thomas Guyot-Sionnest) Date: Tue, 26 Feb 2008 13:08:54 -0500 Subject: [Nagiosplug-devel] Contributing a patch In-Reply-To: <1204018167.6688.4.camel@ampersant-desktop> References: <1204018167.6688.4.camel@ampersant-desktop> Message-ID: <47C455B6.4060605@zango.com> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dries Elliott wrote: > Hi, > > I've patched the check_ping plugin, so it displays performance data. How > can I contribute this plugin? Send a patch that works against SVN HEAD/latest daily snapshot or at the very least latest release. Send it as an attachement/file upload in unified diff format (not inline as text). Your patch should use the same coding style as the plugin. You can either attach it to an email here or use the Patches tracker on SourceForge. Daily snapshots: http://nagiosplug.sourceforge.net/snapshot Patches tracker: http://sourceforge.net/tracker/?group_id=29880&atid=397599 Thanks, - -- Thomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHxFW26dZ+Kt5BchYRAnh9AKCBoxyHTRF1So5dlKC8Ickq+AMZnQCg/+IH H40+pAMKUUB3tbhB+i11/KI= =bDG+ -----END PGP SIGNATURE----- From noreply at sourceforge.net Wed Feb 27 10:52:39 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Wed, 27 Feb 2008 01:52:39 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1902877 ] check_ping patch (performance data) Message-ID: Patches item #1902877, was opened at 2008-02-27 10:52 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1902877&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Perf data Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Dries Elliott (dries123) Assigned to: Nobody/Anonymous (nobody) Summary: check_ping patch (performance data) Initial Comment: I've patched the check_ping plugin, so it now also outputs performance data. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1902877&group_id=29880 From ton.voon at altinity.com Thu Feb 28 17:36:26 2008 From: ton.voon at altinity.com (Ton Voon) Date: Thu, 28 Feb 2008 16:36:26 +0000 Subject: [Nagiosplug-devel] check_procs changes for regexp argu matching and pst3 for solaris Message-ID: <6E2AD2E0-3BC3-49B2-9FA6-A6C740FB35AA@altinity.com> Hi! I've just committed a patch to check_procs which has a nice --ereg- argument-array option to search the argument array based on a regexp. Thanks to Matthias for adding this functionality into check_disk, where I copied the technique from. Also, for Solaris, I've reinstated the pst3 command as the default ps parser. It was switched to /usr/ucb/ps, but that has other issues (large. I thought there would be other options available but according to this page (http://rt.cpan.org/Public/Bug/Display.html?id=23792), there isn't another technique to get the full argument list without root access. The big problem with using pst3 before was the compiling on 64 bit systems, but I think I've got that fixed in configure.in now. I've tested on a 32bit and a 64bit Sol10. A consequence of this is that the check_procs test on solaris will now skip because it requires pst3 to be installed before check_procs will run correctly. Any thoughts on this from Solaris experts? I'm also wondering if it would be a good idea to include a -f as an input to check_procs. There's two reasons for this: * there could be a separate daemon which writes the ps output into this file on a regular basis, which means less load on a system for invoking of the ps command, especially if there are lots of check_procs invocations * for testing, by creating specific test output for check_procs to parse Ton http://www.altinity.com UK: +44 (0)870 787 9243 US: +1 866 879 9184 Fax: +44 (0)845 280 1725 Skype: tonvoon From lavalamp at spiritual-machines.org Thu Feb 28 20:46:00 2008 From: lavalamp at spiritual-machines.org (Brian A. Seklecki) Date: Thu, 28 Feb 2008 14:46:00 -0500 Subject: [Nagiosplug-devel] [Mediawiki-l] Checking MediaWiki Health with Nagios? In-Reply-To: <8f551a650801122117g7f720421maf02c496f5b7defd@mail.gmail.com> References: <1200198461.6804.16.camel@new-host> <8f551a650801122117g7f720421maf02c496f5b7defd@mail.gmail.com> Message-ID: <1204227960.4167.63.camel@soundwave.ws.pitbpa0.priv.collaborativefusion.com> On Sat, 2008-01-12 at 23:17 -0600, Gabriel Millerd wrote: > On Jan 12, 2008 10:27 PM, Brian A. Seklecki (Mobile) > > > > Does anyone have a MW addon or Nagios Check (maybe utilizes the SOAP XML Gabriel et al.: > > API) that queries the application-level health of MediaWiki. I've finally found time to write a small nagios plugin. Here's an example screen shot. It just consumes api.php using SimpleXML's PHP5 bindings. http://people.collaborativefusion.com/~seklecki/images/cf_mediaWiki_NagHC_ex0.png I'll clean it up and post it to nagiosexchange.org just as soon as I have a moment to clean up the code. I may need some advice on getting SimpleXML's simplexml_load_file() in combination with PHP's URI black magic to work with Mediawiki api.php authentication cookies. The underlying library may or may not support cookies (curl/wget/openssl). ~BAS > I would hit Special:Statistics, perhaps grabbing the "The job queue > length is (\d+)." for giggles or similar. > -- Brian A. Seklecki Collaborative Fusion, Inc. From bseklecki at collaborativefusion.com Thu Feb 28 20:45:33 2008 From: bseklecki at collaborativefusion.com (Brian A. Seklecki) Date: Thu, 28 Feb 2008 14:45:33 -0500 Subject: [Nagiosplug-devel] [Mediawiki-l] Checking MediaWiki Health with Nagios? In-Reply-To: <8f551a650801122117g7f720421maf02c496f5b7defd@mail.gmail.com> References: <1200198461.6804.16.camel@new-host> <8f551a650801122117g7f720421maf02c496f5b7defd@mail.gmail.com> Message-ID: <1204227933.4167.62.camel@soundwave.ws.pitbpa0.priv.collaborativefusion.com> On Sat, 2008-01-12 at 23:17 -0600, Gabriel Millerd wrote: > On Jan 12, 2008 10:27 PM, Brian A. Seklecki (Mobile) > > > > Does anyone have a MW addon or Nagios Check (maybe utilizes the SOAP XML Gabriel et al.: > > API) that queries the application-level health of MediaWiki. I've finally found time to write a small nagios plugin. Here's an example screen shot. It just consumes api.php using SimpleXML's PHP5 bindings. http://people.collaborativefusion.com/~seklecki/images/cf_mediaWiki_NagHC_ex0.png I'll clean it up and post it to nagiosexchange.org just as soon as I have a moment to clean up the code. I may need some advice on getting SimpleXML's simplexml_load_file() in combination with PHP's URI black magic to work with Mediawiki api.php authentication cookies. The underlying library may or may not support cookies (curl/wget/openssl). ~BAS > I would hit Special:Statistics, perhaps grabbing the "The job queue > length is (\d+)." for giggles or similar. > -- Brian A. Seklecki Collaborative Fusion, Inc. IMPORTANT: This message contains confidential information and is intended only for the individual named. If the reader of this message is not an intended recipient (or the individual responsible for the delivery of this message to an intended recipient), please be advised that any re-use, dissemination, distribution or copying of this message is prohibited. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. From noreply at sourceforge.net Thu Feb 28 22:55:12 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 28 Feb 2008 13:55:12 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1904304 ] check_nwstat doesn't properly report NRM status Message-ID: Patches item #1904304, was opened at 2008-02-28 16:55 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1904304&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: MikeS (mstatman) Assigned to: Nobody/Anonymous (nobody) Summary: check_nwstat doesn't properly report NRM status Initial Comment: check_nwstat (nagios-plugins 1.4.8) 1.35 check_nwstat v1590 (nagios-plugins 1.4.11) commandline: check_nwstat -H servername -v NRMH check_nwstat always returns OK for NRMH (NRM Health) check. Additionally, the --help option leads to a printf with a %S that ought to be a %s. Linux server 2.6.16.53-0.16-default #1 Tue Oct 2 16:57:49 UTC 2007 i686 i686 i386 GNU/Linux gcc version 4.1.2 20070115 (prerelease) (SUSE Linux) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1904304&group_id=29880 From matthias.eble at mailing.kaufland-informationssysteme.com Fri Feb 29 10:18:06 2008 From: matthias.eble at mailing.kaufland-informationssysteme.com (Matthias Eble) Date: Fri, 29 Feb 2008 10:18:06 +0100 Subject: [Nagiosplug-devel] check_procs changes for regexp argu matching and pst3 for solaris In-Reply-To: <6E2AD2E0-3BC3-49B2-9FA6-A6C740FB35AA@altinity.com> References: <6E2AD2E0-3BC3-49B2-9FA6-A6C740FB35AA@altinity.com> Message-ID: <47C7CDCE.7090007@mailing.kaufland-informationssysteme.com> Ton Voon schrieb: > Hi! > > I've just committed a patch to check_procs which has a nice --ereg- > argument-array option to search the argument array based on a regexp. hehe i did sth similar on my local copy, but then I thought searching for alternatives to parsing ps output would be a better idea but I can't see a good way at the moment. > I'm also wondering if it would be a good idea to include a -f file> as an input to check_procs. There's two reasons for this: > * there could be a separate daemon which writes the ps output into > this file on a regular basis, which means less load on a system for > invoking of the ps command, especially if there are lots of > check_procs invocations > * for testing, by creating specific test output for check_procs to > parse yes++. great for testing, although I somehow dislike starting a daemon for ps output. But that's up to the users. matthias From noreply at sourceforge.net Fri Feb 29 11:40:12 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 29 Feb 2008 02:40:12 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1864225 ] check_procs under SunOS 5.10 broken Message-ID: Bugs item #1864225, was opened at 2008-01-04 21:37 Message generated for change (Comment added) made by tonvoon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1864225&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Compilation Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: gerhard lausser (lausser) >Assigned to: Ton Voon (tonvoon) Summary: check_procs under SunOS 5.10 broken Initial Comment: Hi, i just compiled the 4.11 plugins on a $ uname -a SunOS spnb51 5.10 Generic_118833-24 sun4v sparc SUNW,Sun-Fire-T200 and found that check_procs does not work correctly. $ ps -ef | grep cron root 15100 1 0 Nov 08 ? 1:06 /usr/sbin/cron $ /usr/ucb/ps -alxwwn | grep cron 0 0 15100 1 0 59 20 2784 1048 60015774482 S ? 1:06 /usr/sbin/cron Cron is running, but.... check_procs -w :10 -c 1: -C cron PROCS CRITICAL: 0 processes with command name '/usr/sbin/cron' Running check-procs with -vvv shows, that it uses /usr/ucb/ps -alxwwn and actually parses the right line proc#=0 uid=0 vsz=2784 rss=1048 pid=15100 ppid=1 pcpu=0.00 stat=S etime= prog= args=/usr/sbin/cron but as you see, prog is empty and what should be prog is recognized as argument. Please change the configure.in (the buggy lines in configure are 24967 ff) so that it reads: ac_cv_ps_varlist="&procuid,&procpid,&procppid,&procpcpu,&procvsz,&procrs s,procstat,procprog,&pos" ac_cv_ps_command="/usr/ucb/ps -alxwwn" ac_cv_ps_format="%*s %d %d %d %d %*d %*d %d %d%*[ 0123456789abcdef]%[OSR ZT]%*s %*s %s %n" ac_cv_ps_cols=9 (add procprog to the varlist, add a %s at the end of format and increase cols) Then it looks good: $ check_procs -w :10 -c 1: -C cron PROCS OK: 1 process with command name 'cron' Greetings from Munich, Gerhard ---------------------------------------------------------------------- >Comment By: Ton Voon (tonvoon) Date: 2008-02-29 10:40 Message: Logged In: YES user_id=664364 Originator: NO Gerhard and valloo99, Can you try the snapshot? I've made a change so that we revert back to the pst3 command, which means we can have a tailored output for check_procs to parse. The reason for pst3 is that the /usr/bin/ps command only shows you the first 80 chars of the args field, and /usr/ucb/ps only shows you the full args for your own processes (plus other un-parseable problems). See http://rt.cpan.org/Public/Bug/Display.html?id=23792 for some more details. Ton ---------------------------------------------------------------------- Comment By: Vincent Alloo (valloo99) Date: 2008-01-10 08:42 Message: Logged In: YES user_id=1977333 Originator: NO Fro info, this config is working for both Solaris8 and Soalris 10: ./configure --with-ps-command="/usr/bin/ps -eo 's uid pid ppid vsz rss pcpu etime comm args'" \ --with-ps-format='%s %d %d %d %d %d %f %s %s %n' \ --with-ps-cols=10 \ --with-ps-varlist='procstat,&procuid,&procpid,&procppid,&procvsz,&procrss,&procpcpu,procetime,procprog,&pos' Hope it helps. ---------------------------------------------------------------------- Comment By: Vincent Alloo (valloo99) Date: 2008-01-09 16:57 Message: Logged In: YES user_id=1977333 Originator: NO Fro info, this config is working for both Solaris8 and Soalris 10: ./configure --with-ps-command="/usr/bin/ps -eo 's uid pid ppid vsz rss pcpu etime comm args'" \ --with-ps-format='%s %d %d %d %d %d %f %s %s %n' \ --with-ps-cols=10 \ --with-ps-varlist='procstat,&procuid,&procpid,&procppid,&procvsz,&procrss,&procpcpu,procetime,procprog,&pos' Hope it helps. ---------------------------------------------------------------------- Comment By: gerhard lausser (lausser) Date: 2008-01-09 15:47 Message: Logged In: YES user_id=613416 Originator: YES You are right, when SZ and/or RSS grow too large, ther is no space left between NI and SZ or between SZ and RS: Not parseable: 0 0 16901 1 0 59 205028812184 30004e2e1a6 S ? 278:36 /opt/VRTSsmf/bin/vxsmf.bin -p RootSMF -B I replaced ac_cv_ps_format="%*s %d %d %d %d %*d %*d %d %d%*[...... with ac_cv_ps_format="%*s %d %d %d %d %*d %*2d %5d %d%*[.... and it successfully scanned these lines. (nice can have a maximum of 2 digits, and size can have a maximum of 5 digits. at least when the values still fit into the columns. maybe there are situations, where even the columns don't fit any more, then i think we have no chance) But then i found another one: Not parseable: 0 0 16101 351 0 54 20 3104 2664 ? S ? 0:00 /usr/openv/netbackup/bin/bpcd Here we have a WCHAN value of "?". Adding a ? to the conversion shoud should solve this. So i propose to change line 521 of configure.in to: ac_cv_ps_format="%*s %d %d %d %d %*d %*2d %5d %d%*[ 0123456789abcdef?]%[OSRZT]%*s %*s %s %n" Gerhard ---------------------------------------------------------------------- Comment By: Vincent Alloo (valloo99) Date: 2008-01-09 14:22 Message: Logged In: YES user_id=1977333 Originator: NO Becarefull, the "/usr/ucb/ps -alxwwn" can be non-parseable on some system: 0 18046 20095 20093 0 59 20 3056 1996 fffffe8d3efb8776 S pts/9 0:00 -tcsh 0 0 911 3293 0 59 20837008 1188 ffffffff85c0af42 S ? 0:00 /usr/local/bin/rsync -aWz -v --stats --progress --rsync-path=/apps/free/rsync/2 I still don't have a working check_procs for sol10/x86. ---------------------------------------------------------------------- Comment By: gerhard lausser (lausser) Date: 2008-01-05 01:01 Message: Logged In: YES user_id=613416 Originator: YES Hi Matthias, the last release i compiled on this machine was 1.4.2 and at that time configure decided to use /usr/bin/ps. I can try a 1.4.10 tomorrow but i am sure, it is also broken. I currently look at configure.in line 519. Particularly noticeable is the missing procprog variable in the ac_cv_ps_format. As one can see in the egrep line above, there _is_ a COMMAND field in the output, but the sscanf will not catch it. Gerhard p.s. this ps_format is not used for SunOS in general, only for SunOS whose /usr/ucb/ps -alxwwn shows the expected output format. ---------------------------------------------------------------------- Comment By: Matthias Eble (psychotrahe) Date: 2008-01-05 00:13 Message: Logged In: YES user_id=1694341 Originator: NO Hi Gerhard, Are you sure this is valid for all operating systems where uname -s returns SunOS? I guess this (mis-)behaviour is not new in 1.4.11, right? Matthias ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1864225&group_id=29880 From ton.voon at altinity.com Fri Feb 29 11:49:00 2008 From: ton.voon at altinity.com (Ton Voon) Date: Fri, 29 Feb 2008 10:49:00 +0000 Subject: [Nagiosplug-devel] check_procs changes for regexp argu matching and pst3 for solaris In-Reply-To: <47C7CDCE.7090007@mailing.kaufland-informationssysteme.com> References: <6E2AD2E0-3BC3-49B2-9FA6-A6C740FB35AA@altinity.com> <47C7CDCE.7090007@mailing.kaufland-informationssysteme.com> Message-ID: <96C37CDA-DB45-4B22-8E1A-ECE61B32B3B9@altinity.com> On 29 Feb 2008, at 09:18, Matthias Eble wrote: >> I'm also wondering if it would be a good idea to include a -f > type >> file> as an input to check_procs. There's two reasons for this: >> * there could be a separate daemon which writes the ps output into >> this file on a regular basis, which means less load on a system for >> invoking of the ps command, especially if there are lots of >> check_procs invocations >> * for testing, by creating specific test output for check_procs to >> parse > > yes++. great for testing, although I somehow dislike starting a daemon > for ps output. But that's up to the users. OK, I'll have a go at that later today. Looking through existing patches for check_procs, I've come across this: http://sourceforge.net/tracker/index.php?func=detail&aid=576371&group_id=29880&atid=397599 Tom uses a regex flag, so that the the -a and -C fields are then considered as regexp expressions rather than straight comparisons. So that means instead of: check_procs --ereg-argument-array="java.*http" Tom's patch would make it: check_procs -a "java.*http" --ereg Tom's is more like check_snmp and check_http, but the current one is more like check_disk. I guess check_disk is a special case because it may want regular expressions for some things and not for others. So I'm currently siding with Tom's proposal. Any opinions? Ton http://www.altinity.com UK: +44 (0)870 787 9243 US: +1 866 879 9184 Fax: +44 (0)845 280 1725 Skype: tonvoon From noreply at sourceforge.net Fri Feb 29 11:50:45 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 29 Feb 2008 02:50:45 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-576371 ] Regular expression patch to check_procs Message-ID: Patches item #576371, was opened at 2002-07-02 14:38 Message generated for change (Comment added) made by tonvoon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=576371&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Tom Bertelson (tbertels) Assigned to: Ton Voon (tonvoon) Summary: Regular expression patch to check_procs Initial Comment: This patch adds -r and -R flags to check_procs (similar to check_snmp). This makes comparisons with the -a and -C options match as regular expressions. Tested with Solaris ---------------------------------------------------------------------- >Comment By: Ton Voon (tonvoon) Date: 2008-02-29 10:50 Message: Logged In: YES user_id=664364 Originator: NO A regexp patch has been applied to check_procs, but currently evaluating whether Tom's proposal (like check_snmp and check_http) is a better way of handling the command arguments than the one I just applied (like check_disk). Ton ---------------------------------------------------------------------- Comment By: Ton Voon (tonvoon) Date: 2006-07-07 09:26 Message: Logged In: YES user_id=664364 Taking over Karl's tracker items. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=576371&group_id=29880 From noreply at sourceforge.net Fri Feb 29 11:52:53 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 29 Feb 2008 02:52:53 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1595450 ] check_procs bus error, segmentation fault or ... Message-ID: Patches item #1595450, was opened at 2006-11-13 08:24 Message generated for change (Comment added) made by tonvoon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1595450&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex Peeters (zxr750) >Assigned to: Ton Voon (tonvoon) Summary: check_procs bus error, segmentation fault or ... Initial Comment: check_procs bus error, segmentation fault or wrong output on Solaris 8, 9 & 10 Do first the next configure! ---------------------------- ./configure --with-ps_command="/usr/bin/ps -eo 's uid pid ppid vsz rss pcpu etime comm args'" --with-ps_format='%s %d %d %d %d %d %f %s %s %n' --with-ps_cols=10 --with-ps_varlist='procstat,&procuid,&procpid,&procppid,&procvsz,&procrss,&procpcpu,procetime,procprog,&pos' --with-trusted-path=/usr/local/bin:/usr/local/sbin:/bin:/sbin:/usr/bin:/usr/sbin To solve the bus error and /or segmentation fault on Solaris 8: -------------------------------------------------- replace into check_procs.c if ( cols >= expected_cols ) { resultsum = 0; - asprintf (&procargs, "%s", input_line + pos); strip (procargs); with if ( cols >= expected_cols ) { resultsum = 0; + asprintf (&procargs, "%s", input_line); strip (procargs); To solve the wrong output on Solaris 8, 9 & 10: ----------------------------------------------- change into common.h MAX_INPUT_BUFFER 1024 to MAX_INPUT_BUFFER 4096 ---------------------------------------------------------------------- >Comment By: Ton Voon (tonvoon) Date: 2008-02-29 10:52 Message: Logged In: YES user_id=664364 Originator: NO Alex, Can you see if this is still a problem with the snapshot? Ton ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1595450&group_id=29880 From noreply at sourceforge.net Fri Feb 29 12:18:26 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 29 Feb 2008 03:18:26 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1904609 ] check_mysql (Performance data added) Message-ID: Patches item #1904609, was opened at 2008-02-29 12:18 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1904609&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Perf data Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Dries Elliott (dries123) Assigned to: Nobody/Anonymous (nobody) Summary: check_mysql (Performance data added) Initial Comment: I've parsed the string returned from the mysql_stats function. It now gives performance data about following items: - Threads - Questions - Slow queries - Opens - Flush tables - Open tables - Queries per second avg ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1904609&group_id=29880 From matthias.eble at mailing.kaufland-informationssysteme.com Fri Feb 29 12:46:58 2008 From: matthias.eble at mailing.kaufland-informationssysteme.com (Matthias Eble) Date: Fri, 29 Feb 2008 12:46:58 +0100 Subject: [Nagiosplug-devel] check_procs changes for regexp argu matching and pst3 for solaris In-Reply-To: <96C37CDA-DB45-4B22-8E1A-ECE61B32B3B9@altinity.com> References: <6E2AD2E0-3BC3-49B2-9FA6-A6C740FB35AA@altinity.com> <47C7CDCE.7090007@mailing.kaufland-informationssysteme.com> <96C37CDA-DB45-4B22-8E1A-ECE61B32B3B9@altinity.com> Message-ID: <47C7F0B2.3010604@mailing.kaufland-informationssysteme.com> Ton Voon wrote: > Looking through existing patches for check_procs, I've come across > this: http://sourceforge.net/tracker/index.php?func=detail&aid=576371&group_id=29880&atid=397599 > > Tom uses a regex flag, so that the the -a and -C fields are then > considered as regexp expressions rather than straight comparisons. > > So that means instead of: > > check_procs --ereg-argument-array="java.*http" > > Tom's patch would make it: > > check_procs -a "java.*http" --ereg > > Tom's is more like check_snmp and check_http, but the current one is > more like check_disk. I guess check_disk is a special case because it > may want regular expressions for some things and not for others. > > So I'm currently siding with Tom's proposal. > > Any opinions? hmm I cannot to see/understand this at the moment. Is there a plugin using a flag to define regex usage? check_http actually uses optarg of -r/-R. {"regex", required_argument, 0, 'r'}, {"ereg", required_argument, 0, 'r'}, {"eregi", required_argument, 0, 'R'}, ... strncpy (regexp, optarg, MAX_RE_SIZE - 1); regexp[MAX_RE_SIZE - 1] = 0; errcode = regcomp (&preg, regexp, cflags); same for check_snmp. I'd say implementing a flag like the above would bring us back some implification magic. Which of the possible options are affected by --ereg? --ereg-argument-array is a clear description what is actually done. So I'd prefer the old behavior for now. matthias From ton.voon at altinity.com Fri Feb 29 13:13:56 2008 From: ton.voon at altinity.com (Ton Voon) Date: Fri, 29 Feb 2008 12:13:56 +0000 Subject: [Nagiosplug-devel] check_procs changes for regexp argu matching and pst3 for solaris In-Reply-To: <47C7F0B2.3010604@mailing.kaufland-informationssysteme.com> References: <6E2AD2E0-3BC3-49B2-9FA6-A6C740FB35AA@altinity.com> <47C7CDCE.7090007@mailing.kaufland-informationssysteme.com> <96C37CDA-DB45-4B22-8E1A-ECE61B32B3B9@altinity.com> <47C7F0B2.3010604@mailing.kaufland-informationssysteme.com> Message-ID: <135444C4-E1E0-4C16-8EDD-759627E9ADC4@altinity.com> On 29 Feb 2008, at 11:46, Matthias Eble wrote: > hmm I cannot to see/understand this at the moment. > Is there a plugin using a flag to define regex usage? > > check_http actually uses optarg of -r/-R. > {"regex", required_argument, 0, 'r'}, > {"ereg", required_argument, 0, 'r'}, > {"eregi", required_argument, 0, 'R'}, > ... > strncpy (regexp, optarg, MAX_RE_SIZE - 1); > regexp[MAX_RE_SIZE - 1] = 0; > errcode = regcomp (&preg, regexp, cflags); > > same for check_snmp. I'd say implementing a flag like the above would > bring us back some implification magic. Which of the possible options > are affected by --ereg? --ereg-argument-array is a clear description > what is actually done. So I'd prefer the old behavior for now. Sorry, you are right. check_snmp and check_http use the option to specify the string, whereas Tom's proposal is to provide a flag. My mistake for not looking more closely at that. In which case, I agree with you that the current behaviour is better. I'll close the tracket. Ton http://www.altinity.com UK: +44 (0)870 787 9243 US: +1 866 879 9184 Fax: +44 (0)845 280 1725 Skype: tonvoon From noreply at sourceforge.net Fri Feb 29 14:07:53 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 29 Feb 2008 05:07:53 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1904673 ] Unknown Status Message-ID: Bugs item #1904673, was opened at 2008-02-29 15:07 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1904673&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Parsing problem Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Eugene Dubovski (eugene_dubovski) Assigned to: Nobody/Anonymous (nobody) Summary: Unknown Status Initial Comment: nagios-plugins-1.4.11 check_apache nagios plugin version 0.01 Issue: Unknown Status Gentoo arch: amd64 gcc version 4.1.2 Patch attached. Eugene dea1983 at inbox.ru ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1904673&group_id=29880 From noreply at sourceforge.net Fri Feb 29 22:10:02 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 29 Feb 2008 13:10:02 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1904965 ] check_apt: SECURITY_RE is not correct Message-ID: Bugs item #1904965, was opened at 2008-02-29 22:10 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1904965&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Sebastien Delafond (sdelafond) Assigned to: Nobody/Anonymous (nobody) Summary: check_apt: SECURITY_RE is not correct Initial Comment: Because of the "[^ ]", it fails to recognize lines of this format, that *are* indeed security updates: *Inst linux-image-2.6-amd64 [2.6.18+6etch2] 2.6.18+6etch3 Debian:4.0r3/stable, Debian-Security:4.0/stable) This can unfortunately not be worked around by passing the correct regex with --critical, because of another bug in add_to_regex, that adds a trailing space after the user-supplied regex no matter: this prevents theuser-supplied regex from matching lines like the one above. See attached patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1904965&group_id=29880 From noreply at sourceforge.net Fri Feb 29 22:31:32 2008 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 29 Feb 2008 13:31:32 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1904965 ] check_apt: SECURITY_RE is not correct (patch included) Message-ID: Bugs item #1904965, was opened at 2008-02-29 22:10 Message generated for change (Settings changed) made by sdelafond You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1904965&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Sebastien Delafond (sdelafond) Assigned to: Nobody/Anonymous (nobody) >Summary: check_apt: SECURITY_RE is not correct (patch included) Initial Comment: Because of the "[^ ]", it fails to recognize lines of this format, that *are* indeed security updates: *Inst linux-image-2.6-amd64 [2.6.18+6etch2] 2.6.18+6etch3 Debian:4.0r3/stable, Debian-Security:4.0/stable) This can unfortunately not be worked around by passing the correct regex with --critical, because of another bug in add_to_regex, that adds a trailing space after the user-supplied regex no matter: this prevents theuser-supplied regex from matching lines like the one above. See attached patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1904965&group_id=29880