From noreply at sourceforge.net Sun Feb 1 17:36:10 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Sun, 01 Feb 2009 16:36:10 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2555775 ] nagios check_smtp expects integer instead of double Message-ID: Bugs item #2555775, was opened at 2009-02-01 17:36 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2555775&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Argument proccessing Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jan Wagner (cyco_dd) Assigned to: Nobody/Anonymous (nobody) Summary: nagios check_smtp expects integer instead of double Initial Comment: The following Bugreport we got against the ubuntu package: Command execution returns error with double value: # /usr/lib/nagios/plugins/check_smtp -H localhost -w 0.2 check_smtp: Warning time must be a positive integer Usage:check_smtp -H host [-p port] [-e expect] [-C command] [-f from addr][-A authtype -U authuser -P authpass] [-w warn] [-c crit] [-t timeout] [-S] [-D days] [-n] [-v] [-4|-6] But docu ( /usr/lib/nagios/plugins/check_smtp -h) says: -w, --warning=DOUBLE Response time to result in warning status (seconds) -c, --critical=DOUBLE Response time to result in critical status (seconds) I think, that the integer check is done on error, since all other commands with -w / -c option take double arguments and sub second response time checks are really useful. ----------------------------------------- Current package: Status: install ok installed Priority: extra Section: net Installed-Size: 1252 Maintainer: Ubuntu Core Developers Architecture: i386 Source: nagios-plugins Version: 1.4.11-1ubuntu5 ---------------------------------------- Patch vs nagios-plugins-1.4.12 source (untested): --- check_smtp.orig 2009-01-19 10:57:05.000000000 +0100 +++ check_smtp.c 2009-01-19 11:34:04.000000000 +0100 @@ -103,9 +103,9 @@ char *authtype = NULL; char *authuser = NULL; char *authpass = NULL; -int warning_time = 0; +double warning_time = 0; int check_warning_time = FALSE; -int critical_time = 0; +double critical_time = 0; int check_critical_time = FALSE; int verbose = 0; int use_ssl = FALSE; @@ -432,9 +432,9 @@ elapsed_time = (double)microsec / 1.0e6; if (result == STATE_OK) { - if (check_critical_time && elapsed_time > (double) critical_time) + if (check_critical_time && elapsed_time > critical_time) result = STATE_CRITICAL; - else if (check_warning_time && elapsed_time > (double) warning_time) + else if (check_warning_time && elapsed_time > warning_time) result = STATE_WARNING; } @@ -565,21 +565,19 @@ nresponses++; break; case 'c': /* critical time threshold */ - if (is_intnonneg (optarg)) { - critical_time = atoi (optarg); - check_critical_time = TRUE; - } + if (!is_nonnegative (optarg)) + usage4 (_("Critical time must be a positive")); else { - usage4 (_("Critical time must be a positive integer")); + critical_time = strtod (optarg, NULL); + check_critical_time = TRUE; } break; case 'w': /* warning time threshold */ - if (is_intnonneg (optarg)) { - warning_time = atoi (optarg); - check_warning_time = TRUE; - } + if (!is_nonnegative (optarg)) + usage4 (_("Warning time must be a positive")); else { - usage4 (_("Warning time must be a positive integer")); + warning_time = strtod (optarg, NULL); + check_warning_time = TRUE; } break; case 'v': /* verbose */ Cross comparison with other files (e.g. check_http.c) showed that there might be more of these issues, e.g. wrong message outputs/conversions case 'w': /* warning time threshold */ if (!is_nonnegative (optarg)) usage2 (_("Warning threshold must be integer"), optarg); else { warning_time = strtod (optarg, NULL); check_warning_time = TRUE; } break; You can track the whole bugreport at https://bugs.launchpad.net/ubuntu/+source/nagios-plugins/+bug/318703 Thank, Jan. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2555775&group_id=29880 From noreply at sourceforge.net Sun Feb 1 17:48:27 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Sun, 01 Feb 2009 16:48:27 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2555782 ] check_imap fails with SSL3 Message-ID: Bugs item #2555782, was opened at 2009-02-01 17:48 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2555782&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jan Wagner (cyco_dd) Assigned to: Nobody/Anonymous (nobody) Summary: check_imap fails with SSL3 Initial Comment: The following Bugreport we got against the ubuntu package: imaps service on an Gutsy Server fails with CRITICAL - Cannot make SSL connection Checking imaps on a Debian Sarge still works. Both running courier-imap-ssl with SSL3 Verbose Output Using service IMAP Port: 143 flags: 0x7 CRITICAL - Cannot make SSL connection 26820:error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol:s23_clnt.c:567: and later ... The imap-server expect a ssl-connect SSLv3 (TLS_PROTOCOL=SSL3) and the check_imap try to connect with SSLv2. After changing the imap-server to SSLv2, everything works fine with nagios, but the most clients cannot connect due to recommended security-settings (no SSLv2-use) anymore. Best way would be a new parameter to select the protocol-version (SSLv2, SSLv3, TLSv1). You can track the bug at https://bugs.launchpad.net/ubuntu/+source/nagios-plugins/+bug/155699 Thanks, Jan. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2555782&group_id=29880 From noreply at sourceforge.net Sun Feb 1 17:51:11 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Sun, 01 Feb 2009 16:51:11 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2555775 ] nagios check_smtp expects integer instead of double Message-ID: Bugs item #2555775, was opened at 2009-02-01 17:36 Message generated for change (Comment added) made by cyco_dd You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2555775&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Argument proccessing Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jan Wagner (cyco_dd) Assigned to: Nobody/Anonymous (nobody) Summary: nagios check_smtp expects integer instead of double Initial Comment: The following Bugreport we got against the ubuntu package: Command execution returns error with double value: # /usr/lib/nagios/plugins/check_smtp -H localhost -w 0.2 check_smtp: Warning time must be a positive integer Usage:check_smtp -H host [-p port] [-e expect] [-C command] [-f from addr][-A authtype -U authuser -P authpass] [-w warn] [-c crit] [-t timeout] [-S] [-D days] [-n] [-v] [-4|-6] But docu ( /usr/lib/nagios/plugins/check_smtp -h) says: -w, --warning=DOUBLE Response time to result in warning status (seconds) -c, --critical=DOUBLE Response time to result in critical status (seconds) I think, that the integer check is done on error, since all other commands with -w / -c option take double arguments and sub second response time checks are really useful. ----------------------------------------- Current package: Status: install ok installed Priority: extra Section: net Installed-Size: 1252 Maintainer: Ubuntu Core Developers Architecture: i386 Source: nagios-plugins Version: 1.4.11-1ubuntu5 ---------------------------------------- Patch vs nagios-plugins-1.4.12 source (untested): --- check_smtp.orig 2009-01-19 10:57:05.000000000 +0100 +++ check_smtp.c 2009-01-19 11:34:04.000000000 +0100 @@ -103,9 +103,9 @@ char *authtype = NULL; char *authuser = NULL; char *authpass = NULL; -int warning_time = 0; +double warning_time = 0; int check_warning_time = FALSE; -int critical_time = 0; +double critical_time = 0; int check_critical_time = FALSE; int verbose = 0; int use_ssl = FALSE; @@ -432,9 +432,9 @@ elapsed_time = (double)microsec / 1.0e6; if (result == STATE_OK) { - if (check_critical_time && elapsed_time > (double) critical_time) + if (check_critical_time && elapsed_time > critical_time) result = STATE_CRITICAL; - else if (check_warning_time && elapsed_time > (double) warning_time) + else if (check_warning_time && elapsed_time > warning_time) result = STATE_WARNING; } @@ -565,21 +565,19 @@ nresponses++; break; case 'c': /* critical time threshold */ - if (is_intnonneg (optarg)) { - critical_time = atoi (optarg); - check_critical_time = TRUE; - } + if (!is_nonnegative (optarg)) + usage4 (_("Critical time must be a positive")); else { - usage4 (_("Critical time must be a positive integer")); + critical_time = strtod (optarg, NULL); + check_critical_time = TRUE; } break; case 'w': /* warning time threshold */ - if (is_intnonneg (optarg)) { - warning_time = atoi (optarg); - check_warning_time = TRUE; - } + if (!is_nonnegative (optarg)) + usage4 (_("Warning time must be a positive")); else { - usage4 (_("Warning time must be a positive integer")); + warning_time = strtod (optarg, NULL); + check_warning_time = TRUE; } break; case 'v': /* verbose */ Cross comparison with other files (e.g. check_http.c) showed that there might be more of these issues, e.g. wrong message outputs/conversions case 'w': /* warning time threshold */ if (!is_nonnegative (optarg)) usage2 (_("Warning threshold must be integer"), optarg); else { warning_time = strtod (optarg, NULL); check_warning_time = TRUE; } break; You can track the whole bugreport at https://bugs.launchpad.net/ubuntu/+source/nagios-plugins/+bug/318703 Thank, Jan. ---------------------------------------------------------------------- >Comment By: Jan Wagner (cyco_dd) Date: 2009-02-01 17:51 Message: File Added: patch-nagios-plugins-1.4.12 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2555775&group_id=29880 From risinamit at gmail.com Mon Feb 2 11:05:51 2009 From: risinamit at gmail.com (Amit Kumar) Date: Mon, 2 Feb 2009 15:35:51 +0530 Subject: [Nagiosplug-devel] Fwd: Customised Plugiins deployment In-Reply-To: References: Message-ID: Hi everyone ,I am new to nagios what I want to know is their any specific documentation available if any one wants to deploy a cutomized perl script for a specific check. And how one can activate the email notifications to a specific maild id Please provide the link to that document where I can getthis info. Thanks in advance, Amit -------------- next part -------------- An HTML attachment was scrubbed... URL: From addw at phcomp.co.uk Tue Feb 3 11:36:01 2009 From: addw at phcomp.co.uk (Alain Williams) Date: Tue, 3 Feb 2009 10:36:01 +0000 Subject: [Nagiosplug-devel] Problem with check_ide_smart Message-ID: <20090203103601.GC21983@mint.phcomp.co.uk> Hi, I was monitoring a disk with check_ide_smart and did not receive any warnings. The disk then went bad (fortunately Linux raid so I did not loose anything). I noted from my logs that the error first became apparent several weeks before, but did not pick it up due to email issues (the machine was being commissioned). Is this a known issue ? please find below the output of the command: smartctl -a -d ata /dev/sda The line that is causing concern is the one that starts: 198 Offline_Uncorrectable The disk in error is a Seagate Barracuda. I tried to rewrite the entire disk, but the error showed up soon after. I ran a badblocks check (also below) and it showed up many errors. Regards **************** Output of smartctl below smartctl version 5.36 [x86_64-redhat-linux-gnu] Copyright (C) 2002-6 Bruce Allen Home page is http://smartmontools.sourceforge.net/ === START OF INFORMATION SECTION === Device Model: ST31000340AS Serial Number: 9QJ1Z6NL Firmware Version: SD15 User Capacity: 1,000,204,886,016 bytes Device is: Not in smartctl database [for details use: -P showall] ATA Version is: 8 ATA Standard is: Not recognized. Minor revision code: 0x29 Local Time is: Mon Jan 5 13:57:56 2009 GMT SMART support is: Available - device has SMART capability. SMART support is: Enabled === START OF READ SMART DATA SECTION === SMART overall-health self-assessment test result: PASSED General SMART Values: Offline data collection status: (0x82) Offline data collection activity was completed without error. Auto Offline Data Collection: Enabled. Self-test execution status: ( 0) The previous self-test routine completed without error or no self-test has ever been run. Total time to complete Offline data collection: ( 634) seconds. Offline data collection capabilities: (0x7b) SMART execute Offline immediate. Auto Offline data collection on/off support. Suspend Offline collection upon new command. Offline surface scan supported. Self-test supported. Conveyance Self-test supported. Selective Self-test supported. SMART capabilities: (0x0003) Saves SMART data before entering power-saving mode. Supports SMART auto save timer. Error logging capability: (0x01) Error logging supported. General Purpose Logging supported. Short self-test routine recommended polling time: ( 1) minutes. Extended self-test routine recommended polling time: ( 226) minutes. Conveyance self-test routine recommended polling time: ( 2) minutes. SMART Attributes Data Structure revision number: 10 Vendor Specific SMART Attributes with Thresholds: ID# ATTRIBUTE_NAME FLAG VALUE WORST THRESH TYPE UPDATED WHEN_FAILED RAW_VALUE 1 Raw_Read_Error_Rate 0x000f 098 096 006 Pre-fail Always - 83694887 3 Spin_Up_Time 0x0003 091 091 000 Pre-fail Always - 0 4 Start_Stop_Count 0x0032 100 100 020 Old_age Always - 63 5 Reallocated_Sector_Ct 0x0033 100 100 036 Pre-fail Always - 0 7 Seek_Error_Rate 0x000f 075 060 030 Pre-fail Always - 29792870 9 Power_On_Hours 0x0032 099 099 000 Old_age Always - 1410 10 Spin_Retry_Count 0x0013 100 100 097 Pre-fail Always - 0 12 Power_Cycle_Count 0x0032 100 100 020 Old_age Always - 63 184 Unknown_Attribute 0x0032 100 100 099 Old_age Always - 0 187 Unknown_Attribute 0x0032 016 016 000 Old_age Always - 84 188 Unknown_Attribute 0x0032 100 098 000 Old_age Always - 4295032856 189 Unknown_Attribute 0x003a 100 100 000 Old_age Always - 0 190 Unknown_Attribute 0x0022 071 047 045 Old_age Always - 538640413 194 Temperature_Celsius 0x0022 029 053 000 Old_age Always - 29 (Lifetime Min/Max 0/10) 195 Hardware_ECC_Recovered 0x001a 042 024 000 Old_age Always - 83694887 197 Current_Pending_Sector 0x0012 100 100 000 Old_age Always - 1 198 Offline_Uncorrectable 0x0010 100 100 000 Old_age Offline - 1 199 UDMA_CRC_Error_Count 0x003e 200 200 000 Old_age Always - 0 SMART Error Log Version: 1 ATA Error Count: 84 (device log contains only the most recent five errors) CR = Command Register [HEX] FR = Features Register [HEX] SC = Sector Count Register [HEX] SN = Sector Number Register [HEX] CL = Cylinder Low Register [HEX] CH = Cylinder High Register [HEX] DH = Device/Head Register [HEX] DC = Device Command Register [HEX] ER = Error register [HEX] ST = Status register [HEX] Powered_Up_Time is measured from power on, and printed as DDd+hh:mm:SS.sss where DD=days, hh=hours, mm=minutes, SS=sec, and sss=millisec. It "wraps" after 49.710 days. Error 84 occurred at disk power-on lifetime: 1409 hours (58 days + 17 hours) When the command that caused the error occurred, the device was active or idle. After command completion occurred, registers were: ER ST SC SN CL CH DH -- -- -- -- -- -- -- 40 51 00 30 39 b3 00 Error: UNC at LBA = 0x00b33930 = 11745584 Commands leading to the command that caused the error were: CR FR SC SN CL CH DH DC Powered_Up_Time Command/Feature_Name -- -- -- -- -- -- -- -- ---------------- -------------------- c8 00 08 30 39 b3 e0 00 27d+17:43:19.816 READ DMA 27 00 00 00 00 00 e0 00 27d+17:43:19.815 READ NATIVE MAX ADDRESS EXT ec 00 00 00 00 00 a0 02 27d+17:43:19.812 IDENTIFY DEVICE ef 03 46 00 00 00 a0 02 27d+17:43:19.793 SET FEATURES [Set transfer mode] 27 00 00 00 00 00 e0 00 27d+17:43:19.792 READ NATIVE MAX ADDRESS EXT Error 83 occurred at disk power-on lifetime: 1409 hours (58 days + 17 hours) When the command that caused the error occurred, the device was active or idle. After command completion occurred, registers were: ER ST SC SN CL CH DH -- -- -- -- -- -- -- 40 51 00 30 39 b3 00 Error: UNC at LBA = 0x00b33930 = 11745584 Commands leading to the command that caused the error were: CR FR SC SN CL CH DH DC Powered_Up_Time Command/Feature_Name -- -- -- -- -- -- -- -- ---------------- -------------------- c8 00 08 30 39 b3 e0 00 27d+17:43:16.833 READ DMA 27 00 00 00 00 00 e0 00 27d+17:43:16.833 READ NATIVE MAX ADDRESS EXT ec 00 00 00 00 00 a0 02 27d+17:43:16.830 IDENTIFY DEVICE ef 03 46 00 00 00 a0 02 27d+17:43:16.811 SET FEATURES [Set transfer mode] 27 00 00 00 00 00 e0 00 27d+17:43:16.811 READ NATIVE MAX ADDRESS EXT Error 82 occurred at disk power-on lifetime: 1409 hours (58 days + 17 hours) When the command that caused the error occurred, the device was active or idle. After command completion occurred, registers were: ER ST SC SN CL CH DH -- -- -- -- -- -- -- 40 51 00 30 39 b3 00 Error: UNC at LBA = 0x00b33930 = 11745584 Commands leading to the command that caused the error were: CR FR SC SN CL CH DH DC Powered_Up_Time Command/Feature_Name -- -- -- -- -- -- -- -- ---------------- -------------------- c8 00 08 30 39 b3 e0 00 27d+17:43:13.861 READ DMA 27 00 00 00 00 00 e0 00 27d+17:43:13.860 READ NATIVE MAX ADDRESS EXT ec 00 00 00 00 00 a0 02 27d+17:43:13.857 IDENTIFY DEVICE ef 03 46 00 00 00 a0 02 27d+17:43:13.838 SET FEATURES [Set transfer mode] 27 00 00 00 00 00 e0 00 27d+17:43:13.837 READ NATIVE MAX ADDRESS EXT Error 81 occurred at disk power-on lifetime: 1409 hours (58 days + 17 hours) When the command that caused the error occurred, the device was active or idle. After command completion occurred, registers were: ER ST SC SN CL CH DH -- -- -- -- -- -- -- 40 51 00 30 39 b3 00 Error: UNC at LBA = 0x00b33930 = 11745584 Commands leading to the command that caused the error were: CR FR SC SN CL CH DH DC Powered_Up_Time Command/Feature_Name -- -- -- -- -- -- -- -- ---------------- -------------------- c8 00 08 30 39 b3 e0 00 27d+17:43:10.878 READ DMA 27 00 00 00 00 00 e0 00 27d+17:43:10.878 READ NATIVE MAX ADDRESS EXT ec 00 00 00 00 00 a0 02 27d+17:43:10.875 IDENTIFY DEVICE ef 03 46 00 00 00 a0 02 27d+17:43:10.855 SET FEATURES [Set transfer mode] 27 00 00 00 00 00 e0 00 27d+17:43:10.855 READ NATIVE MAX ADDRESS EXT Error 80 occurred at disk power-on lifetime: 1409 hours (58 days + 17 hours) When the command that caused the error occurred, the device was active or idle. After command completion occurred, registers were: ER ST SC SN CL CH DH -- -- -- -- -- -- -- 40 51 00 30 39 b3 00 Error: UNC at LBA = 0x00b33930 = 11745584 Commands leading to the command that caused the error were: CR FR SC SN CL CH DH DC Powered_Up_Time Command/Feature_Name -- -- -- -- -- -- -- -- ---------------- -------------------- c8 00 08 30 39 b3 e0 00 27d+17:43:07.903 READ DMA 27 00 00 00 00 00 e0 00 27d+17:43:07.903 READ NATIVE MAX ADDRESS EXT ec 00 00 00 00 00 a0 02 27d+17:43:07.900 IDENTIFY DEVICE ef 03 46 00 00 00 a0 02 27d+17:43:07.897 SET FEATURES [Set transfer mode] 27 00 00 00 00 00 e0 00 27d+17:43:07.885 READ NATIVE MAX ADDRESS EXT SMART Self-test log structure revision number 1 Num Test_Description Status Remaining LifeTime(hours) LBA_of_first_error # 1 Short offline Completed without error 00% 1398 - SMART Selective self-test log data structure revision number 1 SPAN MIN_LBA MAX_LBA CURRENT_TEST_STATUS 1 0 0 Not_testing 2 0 0 Not_testing 3 0 0 Not_testing 4 0 0 Not_testing 5 0 0 Not_testing Selective self-test flags (0x0): After scanning selected spans, do NOT read-scan remainder of disk. If Selective self-test is pending on power-up, resume after 0 minute delay. **************** Badblocks output: [root at bfpsev log]# badblocks -s -v /dev/sda Checking blocks 0 to 976762584 Checking for bad blocks (read-only test): 5872768 5872768/ 976762584 5872792 5872792/ 976762584 5872793 5872793/ 976762584 5872794 5872794/ 976762584 5872795 5872795/ 976762584 5872796 5872797 5872798 5872799 5872800 5872801 5872802 5872803 5872804 5872805 5872806 5872807 5872808 5872809 5872810 5872811 5872812 5872813 5872814 5872815 5872816 5872817 5872818 5872819 5872820 5872821 5872822 5872823 5872824 5872825 5872826 5872827 5872828 5872829 5872830 5872831 5872832 5872833 5872834 5872835 5872836 5872837 5872838 5872839 5872840 5872841 5872842 5872843 5872844 5872845 5872846 5872847 5872848 5872849 5872850 5872851 5872852 5872853 5872854 5872855 5872856 5872857 5872858 5872859 5872860 5872861 5872862 5872863 5872864 5872865 5872866 5872867 5872868 5872869 5872870 5872871 5872872 5872873 5872874 5872875 5872876 5872877 5872878 5872879 5872880 5872881 5872882 5872883 5872884 5872885 5872886 5872887 5872888 5872889 5872890 5872891 5872892 5872893 5872894 5872895 5872896 5872897 5872898 5872899 -- Alain Williams Linux/GNU Consultant - Mail systems, Web sites, Networking, Programmer, IT Lecturer. +44 (0) 787 668 0256 http://www.phcomp.co.uk/ Parliament Hill Computers Ltd. Registration Information: http://www.phcomp.co.uk/contact.php Past chairman of UKUUG: http://www.ukuug.org/ #include From noreply at sourceforge.net Tue Feb 3 12:24:37 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Tue, 03 Feb 2009 11:24:37 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1460312 ] check_http doesn't check response time on 300's Message-ID: Bugs item #1460312, was opened at 2006-03-28 17:40 Message generated for change (Settings changed) made by dermoth You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1460312&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Thomas Guyot-Sionnest (dermoth) Assigned to: Thomas Guyot-Sionnest (dermoth) Summary: check_http doesn't check response time on 300's Initial Comment: 300's return codes are accepted as OK by default, but some checks, notably warning/critical time, aren't done on 300 return codes. I didn't had time to rewrite this correctly and test it troughfully, but this simple patch will go on with other tests when 300's are accepted as OK. Ideally, response time should be checked when 300!=CRITICAL, and I also on when expecting a string. ---------------------------------------------------------------------- >Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2009-02-03 06:24 Message: Implemented the max_state logic all the way so that all checks are performed and appended to the status line. see commit: 0d781712d7c8405460ab9f2bd9e262d49fe42a3f ---------------------------------------------------------------------- Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2008-01-08 14:42 Message: Logged In: YES user_id=375623 Originator: YES For the heads up, I just applied it against 1.4.11 and I checked it; it does not prevent redirects. It only change the behavior if oneredirect == STATE_OK and redirs only happens if oneredirect == STATE_DEPENDENT. However if oneredirect == STATE_WARNING it will not detect critical times either, so it fix oneredirect == OK (-f ok, default) but not oneredirect == STATE_WARNING (-f warning). For that reason it should rather be fixed the proper way. The proper fix is likely doing something like following redirect if oneredirect == STATE_DEPENDENT, otherwise using max_state there and in the time check section, and properly handling output as well. It will definitely need careful work and testing, but meanwhile this patch is *safe* but incomplete. ---------------------------------------------------------------------- Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2007-06-12 19:55 Message: Logged In: YES user_id=375623 Originator: YES Indeed this patch looks strange... It was not necessarily intended for inclusion (just a hack), I don't use it anymore and it's been so long I don't even remember why it wasn't "right"... I wasn't a NP developer when I submitted it... I'll assign it to myself and will look over it when I have time (Certainly not until august unfortunately). Thomas ---------------------------------------------------------------------- Comment By: Matthias Eble (psychotrahe) Date: 2007-06-12 14:09 Message: Logged In: YES user_id=1694341 Originator: NO Hi Thomas, I looked over the patch and i guess, this would prevent the actual redirect. We should also take care of changes to the time measuring behaviour and mention changes in NEWS or similar so that people don't wonder why their performance got worse :) Could you bring up some time look at this? Matthias ---------------------------------------------------------------------- Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2006-03-28 17:41 Message: Logged In: YES user_id=375623 Forgot the check_box ;) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1460312&group_id=29880 From noreply at sourceforge.net Thu Feb 5 05:31:39 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 05 Feb 2009 04:31:39 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2550208 ] Patch to check_http redirect behaviour Message-ID: Bugs item #2550208, was opened at 2009-01-30 15:36 Message generated for change (Comment added) made by dermoth You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2550208&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: Release (specify) Status: Open >Resolution: Accepted Priority: 5 Private: No Submitted By: Jan Wagner (cyco_dd) >Assigned to: Thomas Guyot-Sionnest (dermoth) Summary: Patch to check_http redirect behaviour Initial Comment: The following Bugreport we got against our debian package: If told to follow redirects, check_http follows exactly disregarding any supplied IP address. Of course this might be what you want. The included patch adds another option to the -f|--on-redirect switch which will follow but still connect to the same host. It might be considered a bug that even if an IP address is NOT given, the same host will be connected to. --- check_http.c~ 2008-05-07 11:02:42.000000000 +0100 +++ check_http.c 2008-10-17 09:45:38.000000000 +0100 @@ -110,6 +110,7 @@ char **http_opt_headers; int http_opt_headers_count = 0; int onredirect = STATE_OK; +int follow_same_ip = FALSE; int use_ssl = FALSE; int verbose = FALSE; int sd; @@ -302,6 +303,11 @@ server_port = HTTPS_PORT; break; case 'f': /* onredirect */ + if (!strcmp (optarg, "follow-same-ip")) + { + onredirect = STATE_DEPENDENT; + follow_same_ip = TRUE; + } if (!strcmp (optarg, "follow")) onredirect = STATE_DEPENDENT; if (!strcmp (optarg, "unknown")) @@ -1151,8 +1158,11 @@ free (host_name); host_name = strdup (addr); - free (server_address); - server_address = strdup (addr); + if (!follow_same_ip) + { + free (server_address); + server_address = strdup (addr); + } free (server_url); if ((url[0] == '/')) @@ -1169,8 +1179,12 @@ display_html ? "" : ""); if (verbose) - printf (_("Redirection to %s://%s:%d%s\n"), server_type, - host_name ? host_name : server_address, server_port, server_url); + { + printf (_("Redirection to %s://%s:%d%s\n"), server_type, + host_name ? host_name : server_address, server_port, server_url); + if (!host_name) + printf (_("Connecting to %s.\n"), server_address); + } check_http (); } @@ -1292,7 +1306,7 @@ printf (" %s\n", _(" Any other tags to be sent in http header. Use multiple times for additional headers")); printf (" %s\n", "-L, --link"); printf (" %s\n", _("Wrap output in HTML link (obsoleted by urlize)")); - printf (" %s\n", "-f, --onredirect="); + printf (" %s\n", "-f, --onredirect="); printf (" %s\n", _("How to handle redirected pages")); printf (" %s\n", "-m, --pagesize=INTEGER<:INTEGER>"); printf (" %s\n", _("Minimum page size required (bytes) : Maximum page size required (bytes)")); @@ -1346,7 +1360,7 @@ printf (_("Usage:")); printf (" %s -H | -I [-u ] [-p ]\n",progname); printf (" [-w ] [-c ] [-t ] [-L]\n"); - printf (" [-a auth] [-f ] [-e ]\n"); + printf (" [-a auth] [-f ] [-e ]\n"); printf (" [-s string] [-l] [-r | -R ] [-P string]\n"); printf (" [-m :] [-4|-6] [-N] [-M ] [-A string]\n"); printf (" [-k string] [-S] [-C ] [-T ]\n"); You can track the bugreport via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=502529 ---------------------------------------------------------------------- >Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2009-02-04 23:31 Message: Thanks for your report. I just realized my onredirects indeed end up on the wrong ip :) You should always attach the patch, otherwise formating is lost and it can't be applied. It looks like your patch is not totally complete neither. Don't worry though, I'll rather implement it trough --onredirect=sticky ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2550208&group_id=29880 From noreply at sourceforge.net Thu Feb 5 05:37:57 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 05 Feb 2009 04:37:57 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2555775 ] nagios check_smtp expects integer instead of double Message-ID: Bugs item #2555775, was opened at 2009-02-01 11:36 Message generated for change (Comment added) made by dermoth You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2555775&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Argument proccessing Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jan Wagner (cyco_dd) Assigned to: Nobody/Anonymous (nobody) Summary: nagios check_smtp expects integer instead of double Initial Comment: The following Bugreport we got against the ubuntu package: Command execution returns error with double value: # /usr/lib/nagios/plugins/check_smtp -H localhost -w 0.2 check_smtp: Warning time must be a positive integer Usage:check_smtp -H host [-p port] [-e expect] [-C command] [-f from addr][-A authtype -U authuser -P authpass] [-w warn] [-c crit] [-t timeout] [-S] [-D days] [-n] [-v] [-4|-6] But docu ( /usr/lib/nagios/plugins/check_smtp -h) says: -w, --warning=DOUBLE Response time to result in warning status (seconds) -c, --critical=DOUBLE Response time to result in critical status (seconds) I think, that the integer check is done on error, since all other commands with -w / -c option take double arguments and sub second response time checks are really useful. ----------------------------------------- Current package: Status: install ok installed Priority: extra Section: net Installed-Size: 1252 Maintainer: Ubuntu Core Developers Architecture: i386 Source: nagios-plugins Version: 1.4.11-1ubuntu5 ---------------------------------------- Patch vs nagios-plugins-1.4.12 source (untested): --- check_smtp.orig 2009-01-19 10:57:05.000000000 +0100 +++ check_smtp.c 2009-01-19 11:34:04.000000000 +0100 @@ -103,9 +103,9 @@ char *authtype = NULL; char *authuser = NULL; char *authpass = NULL; -int warning_time = 0; +double warning_time = 0; int check_warning_time = FALSE; -int critical_time = 0; +double critical_time = 0; int check_critical_time = FALSE; int verbose = 0; int use_ssl = FALSE; @@ -432,9 +432,9 @@ elapsed_time = (double)microsec / 1.0e6; if (result == STATE_OK) { - if (check_critical_time && elapsed_time > (double) critical_time) + if (check_critical_time && elapsed_time > critical_time) result = STATE_CRITICAL; - else if (check_warning_time && elapsed_time > (double) warning_time) + else if (check_warning_time && elapsed_time > warning_time) result = STATE_WARNING; } @@ -565,21 +565,19 @@ nresponses++; break; case 'c': /* critical time threshold */ - if (is_intnonneg (optarg)) { - critical_time = atoi (optarg); - check_critical_time = TRUE; - } + if (!is_nonnegative (optarg)) + usage4 (_("Critical time must be a positive")); else { - usage4 (_("Critical time must be a positive integer")); + critical_time = strtod (optarg, NULL); + check_critical_time = TRUE; } break; case 'w': /* warning time threshold */ - if (is_intnonneg (optarg)) { - warning_time = atoi (optarg); - check_warning_time = TRUE; - } + if (!is_nonnegative (optarg)) + usage4 (_("Warning time must be a positive")); else { - usage4 (_("Warning time must be a positive integer")); + warning_time = strtod (optarg, NULL); + check_warning_time = TRUE; } break; case 'v': /* verbose */ Cross comparison with other files (e.g. check_http.c) showed that there might be more of these issues, e.g. wrong message outputs/conversions case 'w': /* warning time threshold */ if (!is_nonnegative (optarg)) usage2 (_("Warning threshold must be integer"), optarg); else { warning_time = strtod (optarg, NULL); check_warning_time = TRUE; } break; You can track the whole bugreport at https://bugs.launchpad.net/ubuntu/+source/nagios-plugins/+bug/318703 Thank, Jan. ---------------------------------------------------------------------- >Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2009-02-04 23:37 Message: Thanks for your report. The proper fix would rather be using the nagios thresholds functions. OTOH it's more likely that we put time toward implementing the new thresholds format than fixing plugins that were never converted to the old one. Feel free to attach a working patch if you wish - we'll consider it anyway. Otherwise a quick fix would rather be fixing the documentation. ---------------------------------------------------------------------- Comment By: Jan Wagner (cyco_dd) Date: 2009-02-01 11:51 Message: File Added: patch-nagios-plugins-1.4.12 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2555775&group_id=29880 From dermoth at aei.ca Thu Feb 5 05:49:50 2009 From: dermoth at aei.ca (Thomas Guyot-Sionnest) Date: Wed, 04 Feb 2009 23:49:50 -0500 Subject: [Nagiosplug-devel] For a moment... Message-ID: <498A6FEE.7040408@aei.ca> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 For a moment I thought someone pressed the big red button... Why does Sourceforge says latest release is 1.4.14 (see screenshot)? Be reassured, only .13 is available in the downloads :) BTW it wouldn't be a bad idea to release soon - lots of fixes and enhancements - I'm about to add one more to check_http: - --onredirect=follow that stick on the same IP (although instead of adding a switch, I'll call --onredirect=sticky - anyone has better suggestions?), see Bug #2550208 - -- Thomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFJim/u6dZ+Kt5BchYRArVVAJ4lwX3SfYmQK1of6N5D683ZUv2l7QCg/zoi 72p32Gag8hF6FYadXobtvNY= =92hG -----END PGP SIGNATURE----- -------------- next part -------------- A non-text attachment was scrubbed... Name: Screenshot-SourceForge.net: Nagios Plugin Development - Mozilla Firefox.png Type: image/png Size: 8666 bytes Desc: not available URL: From noreply at sourceforge.net Thu Feb 5 09:16:14 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 05 Feb 2009 08:16:14 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2550208 ] Patch to check_http redirect behaviour Message-ID: Bugs item #2550208, was opened at 2009-01-30 21:36 Message generated for change (Comment added) made by cyco_dd You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2550208&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: Release (specify) Status: Open Resolution: Accepted Priority: 5 Private: No Submitted By: Jan Wagner (cyco_dd) Assigned to: Thomas Guyot-Sionnest (dermoth) Summary: Patch to check_http redirect behaviour Initial Comment: The following Bugreport we got against our debian package: If told to follow redirects, check_http follows exactly disregarding any supplied IP address. Of course this might be what you want. The included patch adds another option to the -f|--on-redirect switch which will follow but still connect to the same host. It might be considered a bug that even if an IP address is NOT given, the same host will be connected to. --- check_http.c~ 2008-05-07 11:02:42.000000000 +0100 +++ check_http.c 2008-10-17 09:45:38.000000000 +0100 @@ -110,6 +110,7 @@ char **http_opt_headers; int http_opt_headers_count = 0; int onredirect = STATE_OK; +int follow_same_ip = FALSE; int use_ssl = FALSE; int verbose = FALSE; int sd; @@ -302,6 +303,11 @@ server_port = HTTPS_PORT; break; case 'f': /* onredirect */ + if (!strcmp (optarg, "follow-same-ip")) + { + onredirect = STATE_DEPENDENT; + follow_same_ip = TRUE; + } if (!strcmp (optarg, "follow")) onredirect = STATE_DEPENDENT; if (!strcmp (optarg, "unknown")) @@ -1151,8 +1158,11 @@ free (host_name); host_name = strdup (addr); - free (server_address); - server_address = strdup (addr); + if (!follow_same_ip) + { + free (server_address); + server_address = strdup (addr); + } free (server_url); if ((url[0] == '/')) @@ -1169,8 +1179,12 @@ display_html ? "" : ""); if (verbose) - printf (_("Redirection to %s://%s:%d%s\n"), server_type, - host_name ? host_name : server_address, server_port, server_url); + { + printf (_("Redirection to %s://%s:%d%s\n"), server_type, + host_name ? host_name : server_address, server_port, server_url); + if (!host_name) + printf (_("Connecting to %s.\n"), server_address); + } check_http (); } @@ -1292,7 +1306,7 @@ printf (" %s\n", _(" Any other tags to be sent in http header. Use multiple times for additional headers")); printf (" %s\n", "-L, --link"); printf (" %s\n", _("Wrap output in HTML link (obsoleted by urlize)")); - printf (" %s\n", "-f, --onredirect="); + printf (" %s\n", "-f, --onredirect="); printf (" %s\n", _("How to handle redirected pages")); printf (" %s\n", "-m, --pagesize=INTEGER<:INTEGER>"); printf (" %s\n", _("Minimum page size required (bytes) : Maximum page size required (bytes)")); @@ -1346,7 +1360,7 @@ printf (_("Usage:")); printf (" %s -H | -I [-u ] [-p ]\n",progname); printf (" [-w ] [-c ] [-t ] [-L]\n"); - printf (" [-a auth] [-f ] [-e ]\n"); + printf (" [-a auth] [-f ] [-e ]\n"); printf (" [-s string] [-l] [-r | -R ] [-P string]\n"); printf (" [-m :] [-4|-6] [-N] [-M ] [-A string]\n"); printf (" [-k string] [-S] [-C ] [-T ]\n"); You can track the bugreport via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=502529 ---------------------------------------------------------------------- >Comment By: Jan Wagner (cyco_dd) Date: 2009-02-05 09:16 Message: Hi Thomas, if you looked in the debian bug report, you can see it's also just a copy&paste patch there. I know that copy&waste usualy breaks the patch ... so ... if I have patch(-files), I'll attach them. :) Cheers, Jan. ---------------------------------------------------------------------- Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2009-02-05 05:31 Message: Thanks for your report. I just realized my onredirects indeed end up on the wrong ip :) You should always attach the patch, otherwise formating is lost and it can't be applied. It looks like your patch is not totally complete neither. Don't worry though, I'll rather implement it trough --onredirect=sticky ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2550208&group_id=29880 From ton.voon at opsera.com Thu Feb 5 09:53:56 2009 From: ton.voon at opsera.com (Ton Voon) Date: Thu, 5 Feb 2009 08:53:56 +0000 Subject: [Nagiosplug-devel] For a moment... In-Reply-To: <498A6FEE.7040408@aei.ca> References: <498A6FEE.7040408@aei.ca> Message-ID: <4B16CCFC-FFCC-48EC-99D3-B8C8374C2789@opsera.com> On 5 Feb 2009, at 04:49, Thomas Guyot-Sionnest wrote: > For a moment I thought someone pressed the big red button... > > Why does Sourceforge says latest release is 1.4.14 (see screenshot)? I've fixed it now. I think I may have done that by mistake when I was running through the release process. > BTW it wouldn't be a bad idea to release soon - lots of fixes and > enhancements - I'm about to add one more to check_http: > - --onredirect=follow that stick on the same IP (although instead of > adding a switch, I'll call --onredirect=sticky - anyone has better > suggestions?), see Bug #2550208 Agreed. I'll send out a warning. Will need to get our site restored before - I'll spend some time on this before the weekend. Re: that check_http patch- is it possible to do a patch to the perl test in plugins/tests/check_http.t? This sounds like just the type of thing we can test. Ton From ton.voon at opsera.com Thu Feb 5 09:55:18 2009 From: ton.voon at opsera.com (Ton Voon) Date: Thu, 5 Feb 2009 08:55:18 +0000 Subject: [Nagiosplug-devel] Notification of plugins 1.4.14 release Message-ID: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> A one week countdown for the next release, since Thomas has done lots of bug fixes. Let us know if there's anything that must go in before the release. Ton From noreply at sourceforge.net Thu Feb 5 12:52:15 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 05 Feb 2009 11:52:15 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2550208 ] Patch to check_http redirect behaviour Message-ID: Bugs item #2550208, was opened at 2009-01-30 15:36 Message generated for change (Comment added) made by dermoth You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2550208&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: Release (specify) >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Jan Wagner (cyco_dd) Assigned to: Thomas Guyot-Sionnest (dermoth) Summary: Patch to check_http redirect behaviour Initial Comment: The following Bugreport we got against our debian package: If told to follow redirects, check_http follows exactly disregarding any supplied IP address. Of course this might be what you want. The included patch adds another option to the -f|--on-redirect switch which will follow but still connect to the same host. It might be considered a bug that even if an IP address is NOT given, the same host will be connected to. --- check_http.c~ 2008-05-07 11:02:42.000000000 +0100 +++ check_http.c 2008-10-17 09:45:38.000000000 +0100 @@ -110,6 +110,7 @@ char **http_opt_headers; int http_opt_headers_count = 0; int onredirect = STATE_OK; +int follow_same_ip = FALSE; int use_ssl = FALSE; int verbose = FALSE; int sd; @@ -302,6 +303,11 @@ server_port = HTTPS_PORT; break; case 'f': /* onredirect */ + if (!strcmp (optarg, "follow-same-ip")) + { + onredirect = STATE_DEPENDENT; + follow_same_ip = TRUE; + } if (!strcmp (optarg, "follow")) onredirect = STATE_DEPENDENT; if (!strcmp (optarg, "unknown")) @@ -1151,8 +1158,11 @@ free (host_name); host_name = strdup (addr); - free (server_address); - server_address = strdup (addr); + if (!follow_same_ip) + { + free (server_address); + server_address = strdup (addr); + } free (server_url); if ((url[0] == '/')) @@ -1169,8 +1179,12 @@ display_html ? "" : ""); if (verbose) - printf (_("Redirection to %s://%s:%d%s\n"), server_type, - host_name ? host_name : server_address, server_port, server_url); + { + printf (_("Redirection to %s://%s:%d%s\n"), server_type, + host_name ? host_name : server_address, server_port, server_url); + if (!host_name) + printf (_("Connecting to %s.\n"), server_address); + } check_http (); } @@ -1292,7 +1306,7 @@ printf (" %s\n", _(" Any other tags to be sent in http header. Use multiple times for additional headers")); printf (" %s\n", "-L, --link"); printf (" %s\n", _("Wrap output in HTML link (obsoleted by urlize)")); - printf (" %s\n", "-f, --onredirect="); + printf (" %s\n", "-f, --onredirect="); printf (" %s\n", _("How to handle redirected pages")); printf (" %s\n", "-m, --pagesize=INTEGER<:INTEGER>"); printf (" %s\n", _("Minimum page size required (bytes) : Maximum page size required (bytes)")); @@ -1346,7 +1360,7 @@ printf (_("Usage:")); printf (" %s -H | -I [-u ] [-p ]\n",progname); printf (" [-w ] [-c ] [-t ] [-L]\n"); - printf (" [-a auth] [-f ] [-e ]\n"); + printf (" [-a auth] [-f ] [-e ]\n"); printf (" [-s string] [-l] [-r | -R ] [-P string]\n"); printf (" [-m :] [-4|-6] [-N] [-M ] [-A string]\n"); printf (" [-k string] [-S] [-C ] [-T ]\n"); You can track the bugreport via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=502529 ---------------------------------------------------------------------- >Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2009-02-05 06:52 Message: Oh, sorry for not updating the patch. It's fixed already. You can try the latest snapshots. The syntax is "--onredirect=sticky" ---------------------------------------------------------------------- Comment By: Jan Wagner (cyco_dd) Date: 2009-02-05 03:16 Message: Hi Thomas, if you looked in the debian bug report, you can see it's also just a copy&paste patch there. I know that copy&waste usualy breaks the patch ... so ... if I have patch(-files), I'll attach them. :) Cheers, Jan. ---------------------------------------------------------------------- Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2009-02-04 23:31 Message: Thanks for your report. I just realized my onredirects indeed end up on the wrong ip :) You should always attach the patch, otherwise formating is lost and it can't be applied. It looks like your patch is not totally complete neither. Don't worry though, I'll rather implement it trough --onredirect=sticky ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2550208&group_id=29880 From sfnetmail at nurfuerspam.de Thu Feb 5 13:49:34 2009 From: sfnetmail at nurfuerspam.de (Olli Hauer) Date: Thu, 05 Feb 2009 13:49:34 +0100 Subject: [Nagiosplug-devel] Notification of plugins 1.4.14 release In-Reply-To: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> References: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> Message-ID: <20090205124934.67600@gmx.net> > A one week countdown for the next release, since Thomas has done lots > of bug fixes. > > Let us know if there's anything that must go in before the release. > > Ton > Please can you look at the bugreport 2179754 http://sourceforge.net/tracker/index.php?func=detail&aid=2179754&group_id=29880&atid=397599 http://sourceforge.net/tracker/index.php?func=detail&aid=2212260&group_id=29880&atid=397597 It is a trivial patch which prevents check_nt to coredump. olli -- Psssst! Schon vom neuen GMX MultiMessenger geh?rt? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger01 From sfnetmail at nurfuerspam.de Thu Feb 5 13:49:34 2009 From: sfnetmail at nurfuerspam.de (Olli Hauer) Date: Thu, 05 Feb 2009 13:49:34 +0100 Subject: [Nagiosplug-devel] Notification of plugins 1.4.14 release In-Reply-To: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> References: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> Message-ID: <20090205124934.67600@gmx.net> > A one week countdown for the next release, since Thomas has done lots > of bug fixes. > > Let us know if there's anything that must go in before the release. > > Ton > Please can you look at the bugreport 2179754 http://sourceforge.net/tracker/index.php?func=detail&aid=2179754&group_id=29880&atid=397599 http://sourceforge.net/tracker/index.php?func=detail&aid=2212260&group_id=29880&atid=397597 It is a trivial patch which prevents check_nt to coredump. olli -- Psssst! Schon vom neuen GMX MultiMessenger geh?rt? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger01 From dermoth at aei.ca Thu Feb 5 15:19:10 2009 From: dermoth at aei.ca (Thomas Guyot-Sionnest) Date: Thu, 05 Feb 2009 09:19:10 -0500 Subject: [Nagiosplug-devel] Notification of plugins 1.4.14 release In-Reply-To: <20090205124934.67600@gmx.net> References: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> <20090205124934.67600@gmx.net> Message-ID: <498AF55E.6020608@aei.ca> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05/02/09 07:49 AM, Olli Hauer wrote: >> A one week countdown for the next release, since Thomas has done lots >> of bug fixes. >> >> Let us know if there's anything that must go in before the release. >> >> Ton >> > > Please can you look at the bugreport 2179754 > http://sourceforge.net/tracker/index.php?func=detail&aid=2179754&group_id=29880&atid=397599 > http://sourceforge.net/tracker/index.php?func=detail&aid=2212260&group_id=29880&atid=397597 > > It is a trivial patch which prevents check_nt to coredump. Will do... Since we're on the subject, recently I started developing a snmp_counter option where you pass back the performancedata string to get an average since last check. I think it's avaluable adition - I'd also like that to become the normal way of retaining data between runs as it's much cleaner than using a file and works well across multiple nagios instances. Waybe I could get it done before the cut date, but I won't have much time for testing then. My current work-in-progreds is here: http://solaris.beaubien.net/cgi-bin/gitweb.cgi?p=nagiosplug-dermoth.git;a=shortlog;h=refs/heads/snmp_counters I need to to the function test (and fix them if needed), the actual implementation in check_snmp and possibly check_snmp tests as well. I have a working perl plugin using this technique - monitors Windows performance monitor logs in CVS format: http://solaris.beaubien.net/cgi-bin/gitweb.cgi?p=code.git;a=blob;f=nagios/plugins/check_perfmon;hb=HEAD - -- Thomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFJivVe6dZ+Kt5BchYRAkWnAJ4v9zMCYo8RqCosAj5qlg2v0b5QCwCfSCl2 ibc980C1sJCt7s111KP4SuA= =Wdwu -----END PGP SIGNATURE----- From Guillaume.Rousse at inria.fr Thu Feb 5 14:57:33 2009 From: Guillaume.Rousse at inria.fr (Guillaume Rousse) Date: Thu, 05 Feb 2009 14:57:33 +0100 Subject: [Nagiosplug-devel] Notification of plugins 1.4.14 release In-Reply-To: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> References: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> Message-ID: <498AF04D.1040702@inria.fr> Ton Voon a ?crit : > A one week countdown for the next release, since Thomas has done lots > of bug fixes. > > Let us know if there's anything that must go in before the release. I'd like just a minimal feedback about my enhancement for ldap plugin: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=2430999&group_id=29880 -- BOFH excuse #275: Bit rot From waja at cyconet.org Thu Feb 5 16:25:48 2009 From: waja at cyconet.org (Jan Wagner) Date: Thu, 5 Feb 2009 16:25:48 +0100 Subject: [Nagiosplug-devel] Notification of plugins 1.4.14 release In-Reply-To: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> References: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> Message-ID: <200902051625.54170.waja@cyconet.org> Hi Ton, On Thursday 05 February 2009, Ton Voon wrote: > A one week countdown for the next release, since Thomas has done lots > of bug fixes. > > Let us know if there's anything that must go in before the release. while maintaining the Debian Package I've submitted a bunch of bug-(fixes), which I would love to see closed after longer time. The first one is fixing Typos, which I'm adjusting for every release, it would be nice to have it included upstream: http://sourceforge.net/tracker/index.php?func=detail&aid=1878971&group_id=29880&atid=397597 The following bugs are either with a patch or trivial to fix: http://sourceforge.net/tracker/index.php?func=detail&aid=1985230&group_id=29880&atid=397597 http://sourceforge.net/tracker/index.php?func=detail&aid=1985317&group_id=29880&atid=397597 http://sourceforge.net/tracker/index.php?func=detail&aid=1985338&group_id=29880&atid=397597 http://sourceforge.net/tracker/index.php?func=detail&aid=1985489&group_id=29880&atid=397597 http://sourceforge.net/tracker/index.php?func=detail&aid=1986260&group_id=29880&atid=397597 Is there a chance to get rid of the deprecated LDAP API: http://sourceforge.net/tracker/index.php?func=detail&aid=1922579&group_id=29880&atid=397597 It would be nice if you could have a look if the stuff could be considered for the next upstream release. Thanks and with kind regards, Jan. -- Never write mail to , you have been warned! -----BEGIN GEEK CODE BLOCK----- Version: 3.1 GIT d-- s+: a- C+++ UL++++ P+ L+++ E- W+++ N+++ o++ K++ w--- O M V- PS PE Y++ PGP++ t-- 5 X R tv- b+ DI- D++ G++ e++ h-- r+++ y+++ ------END GEEK CODE BLOCK------ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part. URL: From noreply at sourceforge.net Mon Feb 9 11:27:01 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 09 Feb 2009 10:27:01 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1894850 ] check_ping: incorrectly parses ping6 output Message-ID: Bugs item #1894850, was opened at 2008-02-16 10:57 Message generated for change (Comment added) made by mnalis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1894850&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Parsing problem Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Matej Vela (vela) Assigned to: Nobody/Anonymous (nobody) Summary: check_ping: incorrectly parses ping6 output Initial Comment: Plugin Version: 1.4.11, HEAD Plugin Name: check_ping Plugin Commandline showing issues: check_ping -H [invalid-ipv6-address] -w 5000,100% -c 5000,100% -p 1 Operating System: Debian GNU/Linux 4.0 (etch) Debian's ping6 may produce output in the following format: 3 packets transmitted, 0 received, +3 errors, 100% packet loss, time 2009ms There's a corresponding pattern in check_ping.c:450: "%*d packets transmitted, %*d received, +%*d errors, %d%% packet loss" but the pattern in check_ping.c:448 matches first: "%*d packets transmitted, %*d received, %d%% loss, time" because sscanf interprets "+3" as a match for "%d". Although the rest of the pattern doesn't match, the number of successful assignments (and thus the return value of sscanf) is still 1. A simple way to make sure the whole pattern matches is to add a "%n" specifier at the end, which will assign the number of characters matched by that point. (The same trick is used in check_http.c.) There seems to be some confusion whether "%n" affects the return value of sscanf, so it's safer to check the assigned number of characters. Patch attached. ---------------------------------------------------------------------- Comment By: Matija Nalis (mnalis) Date: 2009-02-09 11:27 Message: has there been any luck with integrating this patch to nagios-plugins ? It does not seem to be getting any activity. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1894850&group_id=29880 From craig.braithwaite at gmail.com Tue Feb 10 00:35:40 2009 From: craig.braithwaite at gmail.com (Craig Braithwaite) Date: Tue, 10 Feb 2009 10:35:40 +1100 Subject: [Nagiosplug-devel] check_mrtg and check_mrtgtraf return incorrectly using versions from nagios 1.4.13 Message-ID: <4e0204170902091535k5bdbf194jd9941163ee7a83a6@mail.gmail.com> (I hope gmail really does send plain text when I ask it to.) So.. Dear mailing_list I've been struggling with these for a fortnight or so, and have tried to learn enough about c to sort it out myself, however I am so far failing. check_mrtg apparently fails to return an OK status at any stage and is initialised at UNKNOWN so therefore continues to show unknown unless the values cause a flip to warning or critical. check_mrtgtraf also passes (or fails to?) something incorrectly to nagios, as the command line usage can be made to return a string of OK, however nagios reports warning for the same values so is either getting an incorrect return code, or none. ..At least, this is what I think. I've lived in the click-n-close windows world too long and have never written much more than 'hello world'. From what I can gather these two plugins will comprise a hefty proportion of my monitoring options and the versions I have are (I think) the most recent. (both report 1.4.13 but also1991) I am new to everything related to this project, . .linux (centos5.2 on a VM), nagios (3.0.6), mrtg (last months version) so if I'm totally in the wrong place can someone point me in the right direction. Am I right, do these need updating? If so, is it likely that someone reading this mailing list can do so and inform us? Cheers ../craigb ("aussiepics" on this list.) ########################################################################################## # from /usr/local/nagios/objects/commands.cfg # 'check_local_mrtgtraf' command definition define command{ command_name check_local_mrtgtraf command_line $USER1$/check_mrtgtraf -F $ARG1$ -a $ARG2$ -w $ARG3$ -c $ARG4$ -e $ARG5$ } # 'check_local_mrtg' command defiition (wasn't here, I made it myself ./cb) # define command{ command_name check_local_mrtg command_line $USER1$/check_mrtg -F $ARG1$ -a $ARG2$ -v $ARG3$ -w $ARG4$ -c $ARG5$ } ############################################################################################# #from /usr/local/nagios/objects/switch.cfg # Monitor bandwidth via MRTG logs # define service{ use generic-service ; Use values from a template host_name FPV0626 service_description Trunk 6 from FPR Bandwidth Usage check_command check_local_mrtgtraf!/var/www/mrtg/203.103.224.233_trk6.log!AVG!2200000000, 2200000000! 2500000000, 2500000000!10 } ############################################################################################# ===================== cpu temp ==================== [root at Pengy102 libexec]# head /var/www/mrtg/fpvser019-temp1.log 1234162202 23 23 1234162202 23 23 23 23 1234161903 23 23 23 23 1234161900 23 23 23 23 1234161600 23 23 23 23 1234161300 23 23 23 23 1234161000 23 23 23 23 1234160700 23 23 23 23 1234160400 23 23 23 23 1234160100 23 23 23 23 You have new mail in /var/spool/mail/root [root at Pengy102 libexec]# head /var/www/mrtg/ip.ad.dr.ss_trk6.log 1234162502 2314146519 456159057 1234162502 0 238811639 0 238811639 1234162202 0 238811639 0 238811639 1234162200 0 238811639 0 238811639 1234161900 0 238811639 0 238811639 1234161600 0 238811639 0 238811639 1234161300 0 238811639 0 238811639 1234161000 0 238811639 0 238811639 1234160700 0 238811639 0 238811639 1234160400 0 238811639 0 238811639 ############################################################################### # ######### from /usr/local/nagios/etc/objects/windows.cfg ################## # Monitor cpu-temp via MRTG logs # UNTESTED == MAY OR MAY NOT WORK ##### define service{ use generic-service ; Use values from a template host_name fpvser019 service_description CPU Temp ##### # This one works, but check_mrtg has a bug and doesn't # return OK when it's ok so it perpetually says UNKNOWN # until you have a real problem ##### check_command check_local_mrtg!/var/www/mrtg/fpvser019-temp1.log!MAX!1!25!35! ##### # So I'll try using check_mrtgtraf instead even # though it's the wrong tool # BELOW SENDS THE -v COMMAND (WHICH IS WRONG?) BUT WORKS IN NAGIOS # EXCEPT IT ALWAYS SITS AT 'WARNING'. (I guess the plug-in # actually strips out the -v arg, but like check_mrtg, the return codes # are incorrect.) # check_command check_local_mrtgtraf!/var/www/mrtg/fpvser019-temp1.log!MAX!1!30,30!35,35! # ommitting the '1' for the -v arg, causes nagios to show part of the outputted error string. #### } #### ################################################################################## ############## command line checking of the plugin ############################### [root at Pengy102 libexec]# ./check_mrtgtraf -F /var/www/mrtg/fpvser019-temp1.log -a MAX -v 1 -w 30,30 -c 40,40 -e 10 ./check_mrtgtraf: invalid option -- v ######### note 'invalid option' -- v above ############# ######### note usage prompt generated (below) ########### Usage check_mrtgtraf -F -a -v -w -c [-e expire_minutes] [-t timeout] [-v] ####################################################### [root at Pengy102 libexec]# ./check_mrtgtraf -F /var/www/mrtg/fpvser019-temp1.log -a MAX -w 30,30 -c 40,40 -e 10 Traffic OK - Max. In = 23.0 B/s, Max. Out = 23.0 B/s|in=23.000000B/s;30.000000;40.000000;0.000000 in=23.000000B/s;30.000000;40.000000;0.000000 From ton.voon at opsera.com Tue Feb 10 14:38:28 2009 From: ton.voon at opsera.com (Ton Voon) Date: Tue, 10 Feb 2009 13:38:28 +0000 Subject: [Nagiosplug-devel] RFC: gethostbyname instead of getaddrinfo Message-ID: <80F52E4F-C2D2-4B3E-A1A1-50267E22DF68@opsera.com> Hi! Found an issue at a customer site which I think requires a change in the plugins which might impact on a lot of things. Customer setup is this: - host checks use check_icmp, host address is the DNS name - service checks use a mixture of plugins, including check_tcp Customer had a primary DNS failure. A lot of service alerts raised. Analysis showed that the host checks were all considered OK and the service checks were "(Service Check timed out)". However, check_nrpe service checks worked correctly. I think this is due to the plugins using getaddrinfo (which is a DNS call), rather than using gethostbyname (which is an OS call). In this DNS setup, the OS must be caching the DNS results, hence check_icmp and check_nrpe working correctly. As check_tcp is using a different method, its results are inconsistent with the host results. I propose changing all instances of getaddrinfo to gethostbyname in the plugins. This will have an added benefit of reducing the load on DNS servers. I guess some plugins may specifically want to use getaddrinfo (say a DNS round robin web server), but I think those are the exceptions to the rule. Since gethostbyname is already used by check_nrpe and check_icmp, I've confident of the availability of this function. Comments? Ton From Sascha.Runschke at gfkl.com Tue Feb 10 16:25:11 2009 From: Sascha.Runschke at gfkl.com (Sascha.Runschke at gfkl.com) Date: Tue, 10 Feb 2009 16:25:11 +0100 Subject: [Nagiosplug-devel] Antwort: RFC: gethostbyname instead of getaddrinfo In-Reply-To: <80F52E4F-C2D2-4B3E-A1A1-50267E22DF68@opsera.com> References: <80F52E4F-C2D2-4B3E-A1A1-50267E22DF68@opsera.com> Message-ID: Ton Voon schrieb am 10.02.2009 14:38:28: > I propose changing all instances of getaddrinfo to gethostbyname in > the plugins. This will have an added benefit of reducing the load on > DNS servers. > > I guess some plugins may specifically want to use getaddrinfo (say a > DNS round robin web server), but I think those are the exceptions to > the rule. > > Since gethostbyname is already used by check_nrpe and check_icmp, I've > confident of the availability of this function. > > Comments? To make it short - I fully agree with you. getaddrinfo() should only be used in situations where it's really needed. Regards Sascha -- Sascha Runschke IT-Infrastruktur fon : +49 (201) / 102-1879 fax : +49 (201) / 102-1102105 mobil : +49 (173) / 5419665 GFKL Financial Services AG Vorstand: Dr. Peter J?nsch (Vors.), J?rgen Baltes, Dr. Tom Haverkamp Vorsitzender des Aufsichtsrats: Dr. Georg F. Thoma Sitz: Limbecker Platz 1, 45127 Essen, Amtsgericht Essen, HRB 13522 From holger at CIS.FU-Berlin.DE Tue Feb 10 17:40:40 2009 From: holger at CIS.FU-Berlin.DE (Holger Weiss) Date: Tue, 10 Feb 2009 17:40:40 +0100 Subject: [Nagiosplug-devel] Antwort: RFC: gethostbyname instead of getaddrinfo In-Reply-To: References: <80F52E4F-C2D2-4B3E-A1A1-50267E22DF68@opsera.com> Message-ID: <20090210164040.GC21704767@CIS.FU-Berlin.DE> * Sascha.Runschke at gfkl.com [2009-02-10 16:25]: > getaddrinfo() should only be used in situations where it's really needed. I disagree. getaddrinfo allows for opening sockets in a protocol independent manner and therefore makes implementing IPv6 support much cleaner and simpler. gethostbyname has been deprecated by the introduction of getaddrinfo, see the APPLICATION USAGE and FUTURE DIRECTIONS sections of the gethostbyname specification in POSIX.1-2001.? POSIX.1-2008 actually removed getaddrinfo.? So, I'd rather suggest the opposite; that is, we should replace any gethostbyname calls with calls to getaddrinfo. Holger ? http://www.opengroup.org/onlinepubs/009695399/functions/gethostbyname.html ? http://www.opengroup.org/onlinepubs/9699919799/xrat/V4_xsh_chap01.html#tag_22_01_01_05 From holger at CIS.FU-Berlin.DE Tue Feb 10 17:57:28 2009 From: holger at CIS.FU-Berlin.DE (Holger Weiss) Date: Tue, 10 Feb 2009 17:57:28 +0100 Subject: [Nagiosplug-devel] RFC: gethostbyname instead of getaddrinfo In-Reply-To: <80F52E4F-C2D2-4B3E-A1A1-50267E22DF68@opsera.com> References: <80F52E4F-C2D2-4B3E-A1A1-50267E22DF68@opsera.com> Message-ID: <20090210165728.GD21704767@CIS.FU-Berlin.DE> * Ton Voon [2009-02-10 13:38]: > Found an issue at a customer site which I think requires a change in > the plugins which might impact on a lot of things. > > Customer setup is this: > - host checks use check_icmp, host address is the DNS name > - service checks use a mixture of plugins, including check_tcp > > Customer had a primary DNS failure. A lot of service alerts raised. > > Analysis showed that the host checks were all considered OK and the > service checks were "(Service Check timed out)". However, check_nrpe > service checks worked correctly. > > I think this is due to the plugins using getaddrinfo (which is a DNS > call), rather than using gethostbyname (which is an OS call). In this > DNS setup, the OS must be caching the DNS results, hence check_icmp > and check_nrpe working correctly. As check_tcp is using a different > method, its results are inconsistent with the host results. > > I propose changing all instances of getaddrinfo to gethostbyname in > the plugins. This will have an added benefit of reducing the load on > DNS servers. You might be right that the difference is somehow related to getaddrinfo vs. gethostbyname (dunno), but at least on Linux systems which use the getaddrinfo implementation from glibc, getaddrinfo usually queries nscd (if it's running) just as gethostbyname does, so it shouldn't really make a difference with regard to caching. Holger From holger at CIS.FU-Berlin.DE Tue Feb 10 18:01:10 2009 From: holger at CIS.FU-Berlin.DE (Holger Weiss) Date: Tue, 10 Feb 2009 18:01:10 +0100 Subject: [Nagiosplug-devel] Antwort: RFC: gethostbyname instead of getaddrinfo In-Reply-To: <20090210164040.GC21704767@CIS.FU-Berlin.DE> References: <80F52E4F-C2D2-4B3E-A1A1-50267E22DF68@opsera.com> <20090210164040.GC21704767@CIS.FU-Berlin.DE> Message-ID: <20090210170110.GE21704767@CIS.FU-Berlin.DE> * Holger Weiss [2009-02-10 17:40]: > POSIX.1-2008 actually removed getaddrinfo.? It removed gethostbyname, of course :-) > ? http://www.opengroup.org/onlinepubs/9699919799/xrat/V4_xsh_chap01.html#tag_22_01_01_05 Holger From ton.voon at opsera.com Wed Feb 11 00:00:50 2009 From: ton.voon at opsera.com (Ton Voon) Date: Tue, 10 Feb 2009 23:00:50 +0000 Subject: [Nagiosplug-devel] RFC: gethostbyname instead of getaddrinfo In-Reply-To: <20090210165728.GD21704767@CIS.FU-Berlin.DE> References: <80F52E4F-C2D2-4B3E-A1A1-50267E22DF68@opsera.com> <20090210165728.GD21704767@CIS.FU-Berlin.DE> Message-ID: <6357AA1B-BBFD-4F2B-888A-8F02239F6116@opsera.com> On 10 Feb 2009, at 16:57, Holger Weiss wrote: > You might be right that the difference is somehow related to > getaddrinfo > vs. gethostbyname (dunno), but at least on Linux systems which use the > getaddrinfo implementation from glibc, getaddrinfo usually queries > nscd > (if it's running) just as gethostbyname does, so it shouldn't really > make a difference with regard to caching. Here's some debugging: On a Debian Etch system. Running tcpdump -p -i eth4 host 192.168.24.2 and port domain. nscd not running. /etc/resolv.conf has: search localdomain nameserver 192.168.24.2 $ ./check_tcp -H unknown.opsera.com -p 80 TCP CRITICAL - Invalid hostname, address or socket: unknown.opsera.com 06:02:06.731707 IP 192.168.24.134.4903 > 192.168.24.2.domain: 47794+ AAAA? unknown.opsera.com. (36) 06:02:06.770626 IP 192.168.24.2.domain > 192.168.24.134.4903: 47794 NXDomain* 0/1/0 (81) 06:02:06.771237 IP 192.168.24.134.4903 > 192.168.24.2.domain: 9183+ AAAA? unknown.opsera.com.localdomain. (48) 06:02:06.885944 IP 192.168.24.2.domain > 192.168.24.134.4903: 9183 NXDomain 0/1/0 (123) 06:02:06.887095 IP 192.168.24.134.4903 > 192.168.24.2.domain: 46148+ A? unknown.opsera.com. (36) 06:02:06.945637 IP 192.168.24.2.domain > 192.168.24.134.4903: 46148 NXDomain* 0/1/0 (81) 06:02:06.945884 IP 192.168.24.134.4903 > 192.168.24.2.domain: 20546+ A? unknown.opsera.com.localdomain. (48) 06:02:06.982439 IP 192.168.24.2.domain > 192.168.24.134.4903: 20546 NXDomain 0/1/0 (123) (4 lookups) $ ./check_tcp -H unknown.opsera.com. -p 80 TCP CRITICAL - Invalid hostname, address or socket: unknown.opsera.com. 06:03:40.511098 IP 192.168.24.134.4903 > 192.168.24.2.domain: 23215+ AAAA? unknown.opsera.com. (36) 06:03:40.540078 IP 192.168.24.2.domain > 192.168.24.134.4903: 23215 NXDomain* 0/1/0 (81) 06:03:40.540623 IP 192.168.24.134.4903 > 192.168.24.2.domain: 31011+ A? unknown.opsera.com. (36) 06:03:40.642049 IP 192.168.24.2.domain > 192.168.24.134.4903: 31011 NXDomain* 0/1/0 (81) (2 lookups - use period to stop domain searching) ./check_tcp -4 -H unknown.opsera.com. -p 80 TCP CRITICAL - Invalid hostname, address or socket: unknown.opsera.com. 06:19:50.239827 IP 192.168.24.134.4903 > 192.168.24.2.domain: 15398+ A? unknown.opsera.com. (36) 06:19:50.268181 IP 192.168.24.2.domain > 192.168.24.134.4903: 15398 NXDomain* 0/1/0 (81) 06:19:50.268571 IP 192.168.24.134.4903 > 192.168.24.2.domain: 58971+ A? unknown.opsera.com. (36) 06:19:50.322355 IP 192.168.24.2.domain > 192.168.24.134.4903: 58971 NXDomain* 0/1/0 (81) (2 lookups - would have expected only 1) $ ./check_tcp -H www.opsera.com -p 80 TCP OK - 0.120 second response time on port 80|time=0.119810s;;; 0.000000;10.000000 06:02:59.952896 IP 192.168.24.134.4903 > 192.168.24.2.domain: 6846+ AAAA? www.opsera.com. (32) 06:02:59.992078 IP 192.168.24.2.domain > 192.168.24.134.4903: 6846* 1/1/0 CNAME[|domain] 06:02:59.992695 IP 192.168.24.134.4903 > 192.168.24.2.domain: 2265+ A? www.opsera.com. (32) 06:03:00.084890 IP 192.168.24.2.domain > 192.168.24.134.4903: 2265* 2/1/0 CNAME[|domain] 06:03:00.087557 IP 192.168.24.134.4903 > 192.168.24.2.domain: 61796+ AAAA? www.opsera.com. (32) 06:03:00.135503 IP 192.168.24.2.domain > 192.168.24.134.4903: 61796* 1/1/0 CNAME[|domain] 06:03:00.135780 IP 192.168.24.134.4903 > 192.168.24.2.domain: 55503+ A? www.opsera.com. (32) 06:03:00.168262 IP 192.168.24.2.domain > 192.168.24.134.4903: 55503* 2/1/0 CNAME[|domain] (4 lookups - should only have 2) $ ./check_tcp -4 -H www.opsera.com. -p 80 TCP OK - 0.175 second response time on port 80|time=0.175172s;;; 0.000000;10.000000 06:27:10.974406 IP 192.168.24.134.4903 > 192.168.24.2.domain: 3335+ A? www.opsera.com. (32) 06:27:11.051922 IP 192.168.24.2.domain > 192.168.24.134.4903: 3335* 2/1/0 CNAME[|domain] 06:27:11.053219 IP 192.168.24.134.4903 > 192.168.24.2.domain: 6049+ A? www.opsera.com. (32) 06:27:11.187309 IP 192.168.24.2.domain > 192.168.24.134.4903: 6049* 2/1/0 CNAME[|domain] (2 lookups - should only need 1) $ ./check_icmp -H unknown.opsera.com check_icmp: Failed to resolve unknown.opsera.com 06:05:44.357165 IP 192.168.24.134.4903 > 192.168.24.2.domain: 51656+ A? unknown.opsera.com. (36) 06:05:44.520553 IP 192.168.24.2.domain > 192.168.24.134.4903: 51656 NXDomain* 0/1/0 (81) 06:05:44.521194 IP 192.168.24.134.4903 > 192.168.24.2.domain: 60828+ A? unknown.opsera.com.localdomain. (48) 06:05:44.560297 IP 192.168.24.2.domain > 192.168.24.134.4903: 60828 NXDomain 0/1/0 (123) (2 lookups) $ ./check_icmp -H unknown.opsera.com. check_icmp: Failed to resolve unknown.opsera.com. 06:06:07.744863 IP 192.168.24.134.4903 > 192.168.24.2.domain: 52311+ A? unknown.opsera.com. (36) 06:06:07.788173 IP 192.168.24.2.domain > 192.168.24.134.4903: 52311 NXDomain* 0/1/0 (81) (1 lookup - optimal) $ ./check_icmp -H www.opsera.com OK - www.opsera.com: rta 48.374ms, lost 0%|rta=48.374ms; 200.000;500.000;0; pl=0%;40;80;; 06:06:40.584761 IP 192.168.24.134.4903 > 192.168.24.2.domain: 32395+ A? www.opsera.com. (32) 06:06:40.622979 IP 192.168.24.2.domain > 192.168.24.134.4903: 32395* 2/1/0 CNAME[|domain] (1 lookup - optimal) $ dig +short -t AAAA -6 ipv6.whatismyv6.com 2001:4810::110 06:56:23.653750 IP 192.168.24.134.4911 > 192.168.24.2.domain: 51567+ AAAA? ipv6.whatismyv6.com. (37) 06:56:23.712492 IP 192.168.24.2.domain > 192.168.24.134.4911: 51567 1/13/12 AAAA[|domain] (1 lookup) With nscd running: $ ./check_tcp -H unknown6.opsera.com -p 80 TCP CRITICAL - Invalid hostname, address or socket: unknown6.opsera.com 06:10:20.738078 IP 192.168.24.134.4903 > 192.168.24.2.domain: 41386+ AAAA? unknown6.opsera.com. (37) 06:10:20.809164 IP 192.168.24.2.domain > 192.168.24.134.4903: 41386 NXDomain* 0/1/0 (82) 06:10:20.811389 IP 192.168.24.134.4903 > 192.168.24.2.domain: 40461+ AAAA? unknown6.opsera.com.localdomain. (49) 06:10:20.904468 IP 192.168.24.2.domain > 192.168.24.134.4903: 40461 NXDomain 0/1/0 (124) 06:10:20.904986 IP 192.168.24.134.4903 > 192.168.24.2.domain: 32605+ A? unknown6.opsera.com. (37) 06:10:20.941123 IP 192.168.24.2.domain > 192.168.24.134.4903: 32605 NXDomain* 0/1/0 (82) 06:10:20.941607 IP 192.168.24.134.4903 > 192.168.24.2.domain: 27988+ A? unknown6.opsera.com.localdomain. (49) 06:10:21.006650 IP 192.168.24.2.domain > 192.168.24.134.4903: 27988 NXDomain 0/1/0 (124) 06:10:21.009329 IP 192.168.24.134.4903 > 192.168.24.2.domain: 34372+ AAAA? unknown6.opsera.com. (37) 06:10:21.048122 IP 192.168.24.2.domain > 192.168.24.134.4903: 34372 NXDomain* 0/1/0 (82) 06:10:21.048527 IP 192.168.24.134.4903 > 192.168.24.2.domain: 48561+ AAAA? unknown6.opsera.com.localdomain. (49) 06:10:21.149498 IP 192.168.24.2.domain > 192.168.24.134.4903: 48561 NXDomain 0/1/0 (124) 06:10:21.149745 IP 192.168.24.134.4903 > 192.168.24.2.domain: 28714+ A? unknown6.opsera.com. (37) 06:10:21.216563 IP 192.168.24.2.domain > 192.168.24.134.4903: 28714 NXDomain* 0/1/0 (82) 06:10:21.216858 IP 192.168.24.134.4903 > 192.168.24.2.domain: 963+ A? unknown6.opsera.com.localdomain. (49) 06:10:21.303793 IP 192.168.24.2.domain > 192.168.24.134.4903: 963 NXDomain 0/1/0 (124) (8 lookups. Sometimes 4. Should only have 2) $ ./check_tcp -H unknown7.opsera.com. -p 80 TCP CRITICAL - Invalid hostname, address or socket: unknown7.opsera.com. 06:11:38.385293 IP 192.168.24.134.4903 > 192.168.24.2.domain: 20985+ AAAA? unknown7.opsera.com. (37) 06:11:38.447443 IP 192.168.24.2.domain > 192.168.24.134.4903: 20985 NXDomain* 0/1/0 (82) 06:11:38.447637 IP 192.168.24.134.4903 > 192.168.24.2.domain: 2305+ A? unknown7.opsera.com. (37) 06:11:38.517352 IP 192.168.24.2.domain > 192.168.24.134.4903: 2305 NXDomain* 0/1/0 (82) 06:11:38.522049 IP 192.168.24.134.4903 > 192.168.24.2.domain: 32239+ AAAA? unknown7.opsera.com. (37) 06:11:38.582623 IP 192.168.24.2.domain > 192.168.24.134.4903: 32239 NXDomain* 0/1/0 (82) 06:11:38.582904 IP 192.168.24.134.4903 > 192.168.24.2.domain: 45557+ A? unknown7.opsera.com. (37) 06:11:38.629169 IP 192.168.24.2.domain > 192.168.24.134.4903: 45557 NXDomain* 0/1/0 (82) (4 lookups - should only have 2) $ ./check_tcp -H www.opsera.com. -p 80 TCP OK - 0.032 second response time on port 80|time=0.032437s;;; 0.000000;10.000000 06:13:03.543908 IP 192.168.24.134.4903 > 192.168.24.2.domain: 53455+ AAAA? www.opsera.com. (32) 06:13:03.581654 IP 192.168.24.2.domain > 192.168.24.134.4903: 53455* 1/1/0 CNAME[|domain] 06:13:03.582241 IP 192.168.24.134.4903 > 192.168.24.2.domain: 19718+ A? www.opsera.com. (32) 06:13:03.617672 IP 192.168.24.2.domain > 192.168.24.134.4903: 19718* 2/1/0 CNAME[|domain] (2 lookups) $ ./check_tcp -H www.opsera.com. -p 80 TCP OK - 0.036 second response time on port 80|time=0.036289s;;; 0.000000;10.000000 No entries - used cache $ ./check_icmp -H unknown11.opsera.com check_icmp: Failed to resolve unknown11.opsera.com 06:13:50.621161 IP 192.168.24.134.4903 > 192.168.24.2.domain: 51168+ A? unknown11.opsera.com. (38) 06:13:50.952406 IP 192.168.24.2.domain > 192.168.24.134.4903: 51168 NXDomain* 0/1/0 (83) 06:13:50.952942 IP 192.168.24.134.4903 > 192.168.24.2.domain: 63433+ A? unknown11.opsera.com.localdomain. (50) 06:13:51.025156 IP 192.168.24.2.domain > 192.168.24.134.4903: 63433 NXDomain 0/1/0 (125) (2 lookups - optimal) $ ./check_icmp -H www.opsera.com OK - www.opsera.com: rta 49.531ms, lost 0%|rta=49.531ms; 200.000;500.000;0; pl=0%;40;80;; 06:15:25.003246 IP 192.168.24.134.4903 > 192.168.24.2.domain: 30329+ A? www.opsera.com. (32) 06:15:25.040782 IP 192.168.24.2.domain > 192.168.24.134.4903: 30329* 2/1/0 CNAME[|domain] (1 lookup - optimal. I guess it didn't use the earlier www.opsera.com lookup because this is using gethostbyname() and thus different parameters) $ ./check_icmp -H www.opsera.com OK - www.opsera.com: rta 39.112ms, lost 0%|rta=39.112ms; 200.000;500.000;0; pl=0%;40;80;; No entries - used cache. Conclusions: - nscd caches both gethostbyname() and getaddinfo() - use -4 if you want to avoid AAAA lookups (or compile without ipv6 support) - reduce the number of lookups by using fully qualified domain names with a period at the end - use dig +short -t AAAA ipv6.whatismyv6.com to check IPv6 lookups against a nameserver - check_tcp does an additional lookup above check_icmp. I think this is part of the is_host function Given that IPv6 support is desireable, you've convinced me that getaddrinfo() is the right call to use (NRPE and check_icmp do not support IPv6). So I think the only thing that needs to be done in the plugins code is to reduce the use of is_host. Ton From craig.braithwaite at gmail.com Wed Feb 11 00:24:08 2009 From: craig.braithwaite at gmail.com (Craig Braithwaite) Date: Wed, 11 Feb 2009 10:24:08 +1100 Subject: [Nagiosplug-devel] check_mrtg and check_mrtgtraf return incorrectly (?) using versions from nagios 1.4.13 Message-ID: <4e0204170902101524h64e55bd0j7830694236bc5496@mail.gmail.com> Second attempt.. frompostmaster at smtp.novabase.pt to craig.braithwaite at gmail.com date10 February 2009 13:33 subjectDelivery Status Notification (Failure) mailed-bynovabase.pt Final-Recipient: rfc822;nagiosplug-devel at lists.sourceforge.net Action: failed Status: 5.7.1 Diagnostic-Code: smtp;550 5.7.1 Unable to relay .. but that's a side-issue. ---------- Forwarded message ---------- From: "Craig Braithwaite" To: Date: Tue, 10 Feb 2009 10:35:40 +1100 Subject: [Nagiosplug-devel] check_mrtg and check_mrtgtraf return incorrectlyusing versions from nagios 1.4.13 (I hope gmail really does send plain text when I ask it to.) So.. Dear mailing_list I've been struggling with these for a fortnight or so, and have tried to learn enough about c to sort it out myself, however I am so far failing. check_mrtg apparently fails to return an OK status at any stage and is initialised at UNKNOWN so therefore continues to show unknown unless the values cause a flip to warning or critical. check_mrtgtraf also passes (or fails to?) something incorrectly to nagios, as the command line usage can be made to return a string of OK, however nagios reports warning for the same values so is either getting an incorrect return code, or none. .At least, this is what I think. I've lived in the click-n-close windows world too long and have never written much more than 'hello world'. From what I can gather these two plugins will comprise a hefty proportion of my monitoring options and the versions I have are (I think) the most recent. (both report 1.4.13 but also1991) I am new to everything related to this project, .linux (centos5.2 on a VM), nagios (3.0.6), mrtg (last months version) so if I'm totally in the wrong place can someone point me in the right direction. Am I right, do these need updating? If so, is it likely that someone reading this mailing list can do so and inform us? Cheers ../craigb ("aussiepics" on this list.) ########################################################################################## # from /usr/local/nagios/objects/commands.cfg # 'check_local_mrtgtraf' command definition define command{ command_name check_local_mrtgtraf command_line $USER1$/check_mrtgtraf -F $ARG1$ -a $ARG2$ -w $ARG3$ -c $ARG4$ -e $ARG5$ } # 'check_local_mrtg' command defiition (wasn't here, I made it myself ./cb) # define command{ command_name check_local_mrtg command_line $USER1$/check_mrtg -F $ARG1$ -a $ARG2$ -v $ARG3$ -w $ARG4$ -c $ARG5$ } ############################################################################################# #from /usr/local/nagios/objects/switch.cfg # Monitor bandwidth via MRTG logs # define service{ use generic-service ; Use values from a template host_name FPV0626 service_description Trunk 6 from FPR Bandwidth Usage check_command check_local_mrtgtraf!/var/www/mrtg/203.103.224.233_trk6.log!AVG!2200000000, 2200000000! 2500000000, 2500000000!10 } ############################################################################################# ===================== cpu temp ==================== [root at Pengy102 libexec]# head /var/www/mrtg/fpvser019-temp1.log 1234162202 23 23 1234162202 23 23 23 23 1234161903 23 23 23 23 1234161900 23 23 23 23 1234161600 23 23 23 23 1234161300 23 23 23 23 1234161000 23 23 23 23 1234160700 23 23 23 23 1234160400 23 23 23 23 1234160100 23 23 23 23 You have new mail in /var/spool/mail/root [root at Pengy102 libexec]# head /var/www/mrtg/ip.ad.dr.ss_trk6.log 1234162502 2314146519 456159057 1234162502 0 238811639 0 238811639 1234162202 0 238811639 0 238811639 1234162200 0 238811639 0 238811639 1234161900 0 238811639 0 238811639 1234161600 0 238811639 0 238811639 1234161300 0 238811639 0 238811639 1234161000 0 238811639 0 238811639 1234160700 0 238811639 0 238811639 1234160400 0 238811639 0 238811639 ############################################################################### # ######### from /usr/local/nagios/etc/objects/windows.cfg ################## # Monitor cpu-temp via MRTG logs # UNTESTED == MAY OR MAY NOT WORK ##### define service{ use generic-service ; Use values from a template host_name fpvser019 service_description CPU Temp ##### # This one works, but check_mrtg has a bug and doesn't # return OK when it's ok so it perpetually says UNKNOWN # until you have a real problem ##### check_command check_local_mrtg!/var/www/mrtg/fpvser019-temp1.log!MAX!1!25!35! ##### # So I'll try using check_mrtgtraf instead even # though it's the wrong tool # BELOW SENDS THE -v COMMAND (WHICH IS WRONG?) BUT WORKS IN NAGIOS # EXCEPT IT ALWAYS SITS AT 'WARNING'. (I guess the plug-in # actually strips out the -v arg, but like check_mrtg, the return codes # are incorrect.) # check_command check_local_mrtgtraf!/var/www/mrtg/fpvser019-temp1.log!MAX!1!30,30!35,35! # ommitting the '1' for the -v arg, causes nagios to show part of the outputted error string. #### } #### ################################################################################## ############## command line checking of the plugin ############################### [root at Pengy102 libexec]# ./check_mrtgtraf -F /var/www/mrtg/fpvser019-temp1.log -a MAX -v 1 -w 30,30 -c 40,40 -e 10 /check_mrtgtraf: invalid option -- v ######### note 'invalid option' -- v above ############# ######### note usage prompt generated (below) ########### Usage check_mrtgtraf -F -a -v -w -c [-e expire_minutes] [-t timeout] [-v] ####################################################### [root at Pengy102 libexec]# ./check_mrtgtraf -F /var/www/mrtg/fpvser019-temp1.log -a MAX -w 30,30 -c 40,40 -e 10 Traffic OK - Max. In = 23.0 B/s, Max. Out = 23.0 B/s|in=23.000000B/s;30.000000;40.000000;0.000000 in=23.000000B/s;30.000000;40.000000;0.000000 From rich at richhorner.com Wed Feb 11 05:56:00 2009 From: rich at richhorner.com (Richard Edward Horner) Date: Tue, 10 Feb 2009 23:56:00 -0500 Subject: [Nagiosplug-devel] Fwd: Customised Plugiins deployment In-Reply-To: References: Message-ID: <7a65a83a0902102056y7e2f6ce9he1ea6bc28712f6f9@mail.gmail.com> Not sure if this is what you're looking for but the developer guidelines are here: http://nagiosplug.sourceforge.net/developer-guidelines.html Rich(ard) On Mon, Feb 2, 2009 at 5:05 AM, Amit Kumar wrote: > > > Hi everyone ,I am new to nagios what I want to know > is their any specific documentation available if any > one wants to deploy a cutomized perl script for a specific check. > And how one can activate the email notifications to a specific maild > id > Please provide the link to that document where I can getthis info. > > Thanks in advance, > Amit > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by: > SourcForge Community > SourceForge wants to tell your story. > http://p.sf.net/sfu/sf-spreadtheword > _______________________________________________________ > Nagios Plugin Development Mailing List > Nagiosplug-devel at lists.sourceforge.net > Unsubscribe at https://lists.sourceforge.net/lists/listinfo/nagiosplug-devel > ::: Please include plugins version (-v) and OS when reporting any issue. > ::: Messages without supporting info will risk being sent to /dev/null > -- Richard Edward Horner Engineer / Composer / Electric Guitar Virtuoso http://richhorner.com From nagios at babar.us Wed Feb 11 08:06:15 2009 From: nagios at babar.us (Olivier 'Babar' Raginel) Date: Wed, 11 Feb 2009 08:06:15 +0100 Subject: [Nagiosplug-devel] RFC: gethostbyname instead of getaddrinfo In-Reply-To: <6357AA1B-BBFD-4F2B-888A-8F02239F6116@opsera.com> References: <80F52E4F-C2D2-4B3E-A1A1-50267E22DF68@opsera.com> <20090210165728.GD21704767@CIS.FU-Berlin.DE> <6357AA1B-BBFD-4F2B-888A-8F02239F6116@opsera.com> Message-ID: <20090211070615.GA17887@mail.babar.us> On Tue, Feb 10, 2009 at 11:00:50PM +0000, Ton Voon wrote: > On a Debian Etch system. Running tcpdump -p -i eth4 host 192.168.24.2 > and port domain. nscd not running. > > /etc/resolv.conf has: > > search localdomain > nameserver 192.168.24.2 Something I think worth mentionning is that Debian Lenny ships with mdns4 confgiuration, which adds one layer (2 even) per requests, as shown in nsswitch.conf: # grep ^hosts /etc/nsswitch.conf Debian Etch: hosts: files dns Debian Lenny: hosts: files mdns4_minimal [NOTFOUND=return] dns mdns4 I couldn't really mesure the impact of these changes for your current issue, but I think it's worth mentionning that not all OSes in the world have nsswitch.conf set to only "files dns". > So I think the only thing that needs to be done in the plugins code is > to reduce the use of is_host. Agreed. -- Babar. From noreply at sourceforge.net Wed Feb 11 14:22:04 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Wed, 11 Feb 2009 13:22:04 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2531905 ] check_mysql does not properly handle passwords in from file. Message-ID: Bugs item #2531905, was opened at 2009-01-23 18:13 Message generated for change (Comment added) made by btimby You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2531905&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Argument proccessing Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Ben Timby (btimby) Assigned to: Nobody/Anonymous (nobody) Summary: check_mysql does not properly handle passwords in from file. Initial Comment: ----------------- PROBLEM ----------------- The mysql client can use a password from a configuration file. This feature is nice as it keeps the password off of the command line. The check_mysql function does not allow for this. Even though the program informs you via a warning that passing the password on the command line is insecure. It does not allow for the best alternative. According to mysql, the mysql_connect() and mysql_real_connect() both allow a value of NULL to be given for the password. http://dev.mysql.com/doc/refman/5.1/en/mysql-real-connect.html In this case, if a password was read from the option file, it will be used for authentication. The constant "" is used in the case of NO password. Right now, check_mysql, in the validate_arguments() function sets the value of db_pass to "" if it was not provided on the command line. This prevents the password configured in the option file from being used. ----------------- TEST CASE ----------------- # vi $HOME/.my.cnf [client] password=foo # ./check_mysql Access denied for user 'root'@'localhost' (using password: NO) ----------------- PATCH ----------------- The attached patch remedies this. It uses the same method as the mysql client to determine if NULL or "" should be used. If -p is provided, without a value, then "" is used. If -p is omitted, then NULL is used. If -p is provided WITH a password, that password is used. ---------------------------------------------------------------------- >Comment By: Ben Timby (btimby) Date: 2009-02-11 08:22 Message: dermoth, I think you read the patch wrong. The last hunk REMOVES the setting of db_pass to null when it is ''. That was basically the whole problem :-). -- @@ -361,9 +365,6 @@ if (db_host == NULL) db_host = strdup(""); - if (db_pass == NULL) - db_pass = strdup(""); - if (db == NULL) db = strdup(""); -- The difference between '', NULL and is explained at the link I sent in my original bug report: http://dev.mysql.com/doc/refman/5.1/en/mysql-real-connect.html I reproduce the relevant part below... -- For some parameters, it is possible to have the value taken from an option file rather than from an explicit value in the mysql_real_connect() call. To do this, call mysql_options() with the MYSQL_READ_DEFAULT_FILE or MYSQL_READ_DEFAULT_GROUP option before calling mysql_real_connect(). Then, in the mysql_real_connect() call, specify the ?no-value? value for each parameter to be read from an option file: * For passwd, specify a value of NULL. (For the password, a value of the empty string in the mysql_real_connect() call cannot be overridden in an option file, because the empty string indicates explicitly that the MySQL account must have an empty password.) -- ---------------------------------------------------------------------- Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2009-01-23 19:03 Message: Thanks for your patch. There's one thing though that I don't understand, since it already sets db_pass to "" when null (last hunk of your patch does it), why do you need to do this using -p? Can you explain the difference between db_pass=NULL, ="" and =, or point me to the right place in the libmysql documentation? You should also be aware that you can also use the extra-opts feature to use a file for the password argument (you need to enable it with configure; I know some packages enable it by default), although I highly suggest to use the latest snapshot until the 1.4.14 release as there have been some important fixes since 1.4.13. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2531905&group_id=29880 From noreply at sourceforge.net Wed Feb 11 14:28:50 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Wed, 11 Feb 2009 13:28:50 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2531905 ] check_mysql does not properly handle passwords in from file. Message-ID: Bugs item #2531905, was opened at 2009-01-23 18:13 Message generated for change (Comment added) made by btimby You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2531905&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Argument proccessing Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Ben Timby (btimby) Assigned to: Nobody/Anonymous (nobody) Summary: check_mysql does not properly handle passwords in from file. Initial Comment: ----------------- PROBLEM ----------------- The mysql client can use a password from a configuration file. This feature is nice as it keeps the password off of the command line. The check_mysql function does not allow for this. Even though the program informs you via a warning that passing the password on the command line is insecure. It does not allow for the best alternative. According to mysql, the mysql_connect() and mysql_real_connect() both allow a value of NULL to be given for the password. http://dev.mysql.com/doc/refman/5.1/en/mysql-real-connect.html In this case, if a password was read from the option file, it will be used for authentication. The constant "" is used in the case of NO password. Right now, check_mysql, in the validate_arguments() function sets the value of db_pass to "" if it was not provided on the command line. This prevents the password configured in the option file from being used. ----------------- TEST CASE ----------------- # vi $HOME/.my.cnf [client] password=foo # ./check_mysql Access denied for user 'root'@'localhost' (using password: NO) ----------------- PATCH ----------------- The attached patch remedies this. It uses the same method as the mysql client to determine if NULL or "" should be used. If -p is provided, without a value, then "" is used. If -p is omitted, then NULL is used. If -p is provided WITH a password, that password is used. ---------------------------------------------------------------------- >Comment By: Ben Timby (btimby) Date: 2009-02-11 08:28 Message: Hopefully that last post clears up your questions, if not here is a short explaination. While the check_mysql plugin always called mysql_options(), it also always set db_pass to "". This caused the password from the file to be ignored as the password was explicitly set to "". To counteract this, I modified the source so that if the -p parameter is omitted, then db_pass is left as NULL. If the -p parameter is provided, but no password is provided, then db_pass is set to "" (like before). If a password is provided as an argument to -p, then that value is copied to db_pass. ---------------------------------------------------------------------- Comment By: Ben Timby (btimby) Date: 2009-02-11 08:22 Message: dermoth, I think you read the patch wrong. The last hunk REMOVES the setting of db_pass to null when it is ''. That was basically the whole problem :-). -- @@ -361,9 +365,6 @@ if (db_host == NULL) db_host = strdup(""); - if (db_pass == NULL) - db_pass = strdup(""); - if (db == NULL) db = strdup(""); -- The difference between '', NULL and is explained at the link I sent in my original bug report: http://dev.mysql.com/doc/refman/5.1/en/mysql-real-connect.html I reproduce the relevant part below... -- For some parameters, it is possible to have the value taken from an option file rather than from an explicit value in the mysql_real_connect() call. To do this, call mysql_options() with the MYSQL_READ_DEFAULT_FILE or MYSQL_READ_DEFAULT_GROUP option before calling mysql_real_connect(). Then, in the mysql_real_connect() call, specify the ?no-value? value for each parameter to be read from an option file: * For passwd, specify a value of NULL. (For the password, a value of the empty string in the mysql_real_connect() call cannot be overridden in an option file, because the empty string indicates explicitly that the MySQL account must have an empty password.) -- ---------------------------------------------------------------------- Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2009-01-23 19:03 Message: Thanks for your patch. There's one thing though that I don't understand, since it already sets db_pass to "" when null (last hunk of your patch does it), why do you need to do this using -p? Can you explain the difference between db_pass=NULL, ="" and =, or point me to the right place in the libmysql documentation? You should also be aware that you can also use the extra-opts feature to use a file for the password argument (you need to enable it with configure; I know some packages enable it by default), although I highly suggest to use the latest snapshot until the 1.4.14 release as there have been some important fixes since 1.4.13. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2531905&group_id=29880 From mattias.ryrlen at op5.com Wed Feb 11 16:13:12 2009 From: mattias.ryrlen at op5.com (Mattias =?ISO-8859-1?Q?Ryrl=E9n?=) Date: Wed, 11 Feb 2009 16:13:12 +0100 Subject: [Nagiosplug-devel] Featurerequest: check_snmp: when specifying -l for lable the lable should also replace oid on performace output Message-ID: <1234365192.8229.45.camel@mr-laptop> check_snmp: when specifying -l for lable the lable should also replace oid on performace output this to make pnp4nagios graphs look better since the oid gets to long for the image for example. -- V?nliga h?lsningar / Best Regards Mattias Ryrl?n __________________________ op5 AB F?rsta L?nggatan 19 SE-413 27 G?teborg Mobil: +46 735-17 70 99 Support: +46 31-774 09 24 www.op5.com From dermoth at aei.ca Thu Feb 12 04:53:55 2009 From: dermoth at aei.ca (Thomas Guyot-Sionnest) Date: Wed, 11 Feb 2009 22:53:55 -0500 Subject: [Nagiosplug-devel] Featurerequest: check_snmp: when specifying -l for lable the lable should also replace oid on performace output In-Reply-To: <1234365192.8229.45.camel@mr-laptop> References: <1234365192.8229.45.camel@mr-laptop> Message-ID: <49939D53.7000904@aei.ca> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11/02/09 10:13 AM, Mattias Ryrl?n wrote: > check_snmp: when specifying -l for lable the lable should also replace > oid on performace output > > this to make pnp4nagios graphs look better since the oid gets to long > for the image for example. > That would break backwards-compatibility. Short answer: no. Longer answer: I doubt it makes sense to start adding command switches for every single use case - especially when the "feature" is only aesthetic. I don't mind bringing up this idea as part of new thresholds formats though as they will include flags for controlling output format and such - by extension this could be considered. OTOH, you can: 1. Load the required MIBs so that the OID gets translated (Don't just load them all as it may be significantly slower - dependencies gets automatically loaded anyway) 2. "Fix" the graphing application - for instance I use Cacti and I don't have this limitation. Regards, - -- Thomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFJk51T6dZ+Kt5BchYRAuqMAKCqOOZ02ZtDVWMHkI1PytP3+mOhIgCg8HeK cabiL42WVaOmiMjELcZNQXI= =Z++Z -----END PGP SIGNATURE----- From noreply at sourceforge.net Tue Feb 17 07:20:02 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Tue, 17 Feb 2009 06:20:02 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2608223 ] check_snmp long help missing retries entry Message-ID: Bugs item #2608223, was opened at 2009-02-17 01:20 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2608223&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: snapshot tarball Status: Open Resolution: None Priority: 5 Private: No Submitted By: Richard Edward Horner (mechanyx) Assigned to: Nobody/Anonymous (nobody) Summary: check_snmp long help missing retries entry Initial Comment: running check_snmp --help gives output that includes short help for -e retries but there's no -e, --retries in the long help. --retries is implemented in the code. Here's a patch to add the two lines to the long help. It was made against the latest dev snapshot: http://nagiosplug.sourceforge.net/snapshot/nagios-plugins-trunk-200902170100.tar.gz ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2608223&group_id=29880 From waja at cyconet.org Tue Feb 17 16:17:46 2009 From: waja at cyconet.org (Jan Wagner) Date: Tue, 17 Feb 2009 16:17:46 +0100 Subject: [Nagiosplug-devel] Notification of plugins 1.4.14 release In-Reply-To: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> References: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> Message-ID: <200902171617.50147.waja@cyconet.org> Hi Ton, On Thursday 05 February 2009, Ton Voon wrote: > A one week countdown for the next release, since Thomas has done lots > of bug fixes. is there any ETA for the release? I'm just asking, cause I want to create a new Debian package and I don't know if it's worse to package 1.4.13. Thanks and with kind regards, Jan. -- Never write mail to , you have been warned! -----BEGIN GEEK CODE BLOCK----- Version: 3.1 GIT d-- s+: a- C+++ UL++++ P+ L+++ E- W+++ N+++ o++ K++ w--- O M V- PS PE Y++ PGP++ t-- 5 X R tv- b+ DI- D++ G++ e++ h-- r+++ y+++ ------END GEEK CODE BLOCK------ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part. URL: From ton.voon at opsera.com Tue Feb 17 17:16:35 2009 From: ton.voon at opsera.com (Ton Voon) Date: Tue, 17 Feb 2009 16:16:35 +0000 Subject: [Nagiosplug-devel] Notification of plugins 1.4.14 release In-Reply-To: <200902171617.50147.waja@cyconet.org> References: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> <200902171617.50147.waja@cyconet.org> Message-ID: Hi Jan, On 17 Feb 2009, at 15:17, Jan Wagner wrote: > On Thursday 05 February 2009, Ton Voon wrote: >> A one week countdown for the next release, since Thomas has done lots >> of bug fixes. > > is there any ETA for the release? I'm just asking, cause I want to > create a > new Debian package and I don't know if it's worse to package 1.4.13. Sorry, ben meaning to respond. I think it is worth looking at some of these issues that have been escalated. I'll get some time later this week, so the release will be held off for another week. Ton From waja at cyconet.org Tue Feb 17 20:00:28 2009 From: waja at cyconet.org (Jan Wagner) Date: Tue, 17 Feb 2009 20:00:28 +0100 Subject: [Nagiosplug-devel] Notification of plugins 1.4.14 release In-Reply-To: References: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> <200902171617.50147.waja@cyconet.org> Message-ID: <200902172000.31996.waja@cyconet.org> Hi Ton, On Tuesday 17 February 2009, Ton Voon wrote: > On 17 Feb 2009, at 15:17, Jan Wagner wrote: > > On Thursday 05 February 2009, Ton Voon wrote: > >> A one week countdown for the next release, since Thomas has done lots > >> of bug fixes. > > > > is there any ETA for the release? I'm just asking, cause I want to > > create a > > new Debian package and I don't know if it's worse to package 1.4.13. > > Sorry, ben meaning to respond. > > I think it is worth looking at some of these issues that have been > escalated. I'll get some time later this week, so the release will be > held off for another week. don't feel in hurry ... I think I'll just package 1.4.13, thats no problem. Thanks and with kind regards, Jan. -- Never write mail to , you have been warned! -----BEGIN GEEK CODE BLOCK----- Version: 3.1 GIT d-- s+: a- C+++ UL++++ P+ L+++ E- W+++ N+++ o++ K++ w--- O M V- PS PE Y++ PGP++ t-- 5 X R tv- b+ DI- D++ G++ e++ h-- r+++ y+++ ------END GEEK CODE BLOCK------ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part. URL: From dermoth at aei.ca Wed Feb 18 13:35:20 2009 From: dermoth at aei.ca (Thomas Guyot-Sionnest) Date: Wed, 18 Feb 2009 07:35:20 -0500 Subject: [Nagiosplug-devel] Notification of plugins 1.4.14 release In-Reply-To: <200902172000.31996.waja@cyconet.org> References: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> <200902171617.50147.waja@cyconet.org> <200902172000.31996.waja@cyconet.org> Message-ID: <499C0088.1060009@aei.ca> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 17/02/09 02:00 PM, Jan Wagner wrote: > Hi Ton, > > On Tuesday 17 February 2009, Ton Voon wrote: >> On 17 Feb 2009, at 15:17, Jan Wagner wrote: >>> On Thursday 05 February 2009, Ton Voon wrote: >>>> A one week countdown for the next release, since Thomas has done lots >>>> of bug fixes. >>> is there any ETA for the release? I'm just asking, cause I want to >>> create a >>> new Debian package and I don't know if it's worse to package 1.4.13. >> Sorry, ben meaning to respond. >> >> I think it is worth looking at some of these issues that have been >> escalated. I'll get some time later this week, so the release will be >> held off for another week. > > don't feel in hurry ... I think I'll just package 1.4.13, thats no problem. > > Thanks and with kind regards, Jan. I'm planning to do just the same as Ton... review some of the escalated issues as soon as I can. There are important fixes since 1.4.13, especially with extra-opts enabled. If you don't want to use the latest repository code I can send you some commits to apply. - -- Thomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFJnACI6dZ+Kt5BchYRAlG5AKD6YOo/zLoS2TWWqtFPJ/iY6eZ63QCfZMnF EJCBsdd+wzJRwrhb63cXMgM= =v5ek -----END PGP SIGNATURE----- From waja at cyconet.org Thu Feb 19 13:50:17 2009 From: waja at cyconet.org (Jan Wagner) Date: Thu, 19 Feb 2009 13:50:17 +0100 Subject: [Nagiosplug-devel] Notification of plugins 1.4.14 release In-Reply-To: <499C0088.1060009@aei.ca> References: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> <200902172000.31996.waja@cyconet.org> <499C0088.1060009@aei.ca> Message-ID: <200902191350.21180.waja@cyconet.org> On Wednesday 18 February 2009, Thomas Guyot-Sionnest wrote: > I'm planning to do just the same as Ton... review some of the escalated > issues as soon as I can. There are important fixes since 1.4.13, > especially with extra-opts enabled. If you don't want to use the latest > repository code I can send you some commits to apply. I think I will upload 1.4.13 to experimental, I you think it's too worse for unstable/testing, just to update patches and adjust packaging to latest standards. Anyhow ... if you could implement the typo fixes, I would love you much, which is really anoying to update to every release. With kind regards, Jan. -- Never write mail to , you have been warned! -----BEGIN GEEK CODE BLOCK----- Version: 3.1 GIT d-- s+: a- C+++ UL++++ P+ L+++ E- W+++ N+++ o++ K++ w--- O M V- PS PE Y++ PGP++ t-- 5 X R tv- b+ DI- D++ G++ e++ h-- r+++ y+++ ------END GEEK CODE BLOCK------ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part. URL: From noreply at sourceforge.net Thu Feb 19 15:14:04 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 19 Feb 2009 14:14:04 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2616403 ] check_disk - option "--ignore-inaccessible" would be neat Message-ID: Bugs item #2616403, was opened at 2009-02-19 15:14 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2616403&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jan Wagner (cyco_dd) Assigned to: Nobody/Anonymous (nobody) Summary: check_disk - option "--ignore-inaccessible" would be neat Initial Comment: The following Bugreport we got against our debian package: [...] | weasel at malo:~$ /usr/lib/nagios/plugins/check_disk 90 95 | DISK CRITICAL - /home/buildd/chroots/etch/proc is not accessible: Permission denied I think this commit is to blame: | 2007-07-10 20:18 psychotrahe | | * [r1754] NEWS, plugins/check_disk.c, plugins/t/check_disk.t: | Check_disk now calls stat() for all filesystems to check. | Check_disk prints an strerror() message if the call of stat() | fails. [...] weasel at simona:~$ sudo chmod o-rx /mnt/test weasel at simona:~$ stat /mnt/test/mountpoint stat: cannot stat `/mnt/test/mountpoint': Permission denied [...] so as discussed on IRC, adding an option "--ignore-inaccessible" would be neat. You can track the bugreport via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=516097 I would say, an option, which skips mount points with missing permissions would be a good idea. With kind regards, Jan. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2616403&group_id=29880 From noreply at sourceforge.net Fri Feb 20 00:46:18 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 19 Feb 2009 23:46:18 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-2179754 ] [patch] Exception in check_nt.c Message-ID: Patches item #2179754, was opened at 2008-10-19 14:42 Message generated for change (Comment added) made by tonvoon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=2179754&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: mumpitz (ohauer) Assigned to: Nobody/Anonymous (nobody) Summary: [patch] Exception in check_nt.c Initial Comment: routine CHECK_USEDDISKSPACE in check_nt.c do not handle correct unknown/missing drives. # /usr/local/libexec/nagios/check_nt -H HOSTNAME -p 12489 -v USEDDISKSPACE -l d Segmentation fault: 11 (core dumped) # /usr/local/libexec/nagios/check_nt -H HOSTNAME -p 12489 -v USEDDISKSPACE -l e Segmentation fault: 11 (core dumped) # echo "None&4&d" | nc HOSTNAME 12489 UNKNOWN: Drive is not a fixed drive: d: (it is a cdrom drive) # echo "None&4&e" | nc HOSTNAME 12489 UNKNOWN: Could not get free space for: e: e: reason: 3: The system cannot find the path specified. ################################# snipped from the code: ################################# case CHECK_USEDDISKSPACE: fetch_data (server_address, server_port, send_buffer); /* --> no exception handling */ free_disk_space=atof(strtok(recv_buffer,"&")); total_disk_space=atof(strtok(NULL,"&")); The patch is maybe not optimal, but prevents segfault ---------------------------------------------------------------------- >Comment By: Ton Voon (tonvoon) Date: 2009-02-19 23:46 Message: Olli, Thanks for the patch. Applied to git and will be in the next release. Ton ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=2179754&group_id=29880 From noreply at sourceforge.net Fri Feb 20 00:46:54 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 19 Feb 2009 23:46:54 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2212260 ] [patch] ID: 2179754 Message-ID: Bugs item #2212260, was opened at 2008-10-31 17:40 Message generated for change (Comment added) made by tonvoon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2212260&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Argument proccessing Group: None >Status: Closed >Resolution: Duplicate Priority: 5 Private: No Submitted By: mumpitz (ohauer) >Assigned to: Ton Voon (tonvoon) Summary: [patch] ID: 2179754 Initial Comment: In check_nt.c exist a error (case CHECK_USEDDISKSPACE:), which segfaults the plugin if used for example with nrpe++ and a query to an non existent drive. The error is as follows. The first call in the sequence searches the string pointed to by s1 for the first byte that is not contained in the current separator string pointed to by s2. If no such byte is found, then there are no tokens in the string pointed to by s1 and strtok() returns a null pointer. If such a byte is found, it is the start of the first token. (http://www.opengroup.org/onlinepubs/007908775/xsh/strtok.html) If for example the nrpe++ plugin return the following for a drive query: UNKNOWN: Drive is not a fixed drive: d: (it is a cdrom drive) Now the following happens: - the seperator '&' is not provided in the return string - strtok(recv_buffer,"&") returns the full unexpected string to atof. - atof return NULL or random data - strtok(NULL, "&") returns NULL - atof(NULL) -> *segfault* So it is saver but not perfect (usage of atof) with the patch ID: 2179754 I attached the patch from ID 217954 again to this bug ---------------------------------------------------------------------- >Comment By: Ton Voon (tonvoon) Date: 2009-02-19 23:46 Message: Duplicate of 2179754. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2212260&group_id=29880 From noreply at sourceforge.net Fri Feb 20 00:47:46 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 19 Feb 2009 23:47:46 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-2179754 ] [patch] Exception in check_nt.c Message-ID: Patches item #2179754, was opened at 2008-10-19 14:42 Message generated for change (Settings changed) made by tonvoon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=2179754&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: mumpitz (ohauer) >Assigned to: Ton Voon (tonvoon) Summary: [patch] Exception in check_nt.c Initial Comment: routine CHECK_USEDDISKSPACE in check_nt.c do not handle correct unknown/missing drives. # /usr/local/libexec/nagios/check_nt -H HOSTNAME -p 12489 -v USEDDISKSPACE -l d Segmentation fault: 11 (core dumped) # /usr/local/libexec/nagios/check_nt -H HOSTNAME -p 12489 -v USEDDISKSPACE -l e Segmentation fault: 11 (core dumped) # echo "None&4&d" | nc HOSTNAME 12489 UNKNOWN: Drive is not a fixed drive: d: (it is a cdrom drive) # echo "None&4&e" | nc HOSTNAME 12489 UNKNOWN: Could not get free space for: e: e: reason: 3: The system cannot find the path specified. ################################# snipped from the code: ################################# case CHECK_USEDDISKSPACE: fetch_data (server_address, server_port, send_buffer); /* --> no exception handling */ free_disk_space=atof(strtok(recv_buffer,"&")); total_disk_space=atof(strtok(NULL,"&")); The patch is maybe not optimal, but prevents segfault ---------------------------------------------------------------------- Comment By: Ton Voon (tonvoon) Date: 2009-02-19 23:46 Message: Olli, Thanks for the patch. Applied to git and will be in the next release. Ton ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=2179754&group_id=29880 From ton.voon at opsera.com Fri Feb 20 00:52:38 2009 From: ton.voon at opsera.com (Ton Voon) Date: Thu, 19 Feb 2009 23:52:38 +0000 Subject: [Nagiosplug-devel] Notification of plugins 1.4.14 release In-Reply-To: <498AF04D.1040702@inria.fr> References: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> <498AF04D.1040702@inria.fr> Message-ID: <32B769F8-2E39-4C0B-9D1D-1BDA02FABDFA@opsera.com> On 5 Feb 2009, at 13:57, Guillaume Rousse wrote: > Ton Voon a ?crit : >> A one week countdown for the next release, since Thomas has done lots >> of bug fixes. >> >> Let us know if there's anything that must go in before the release. > I'd like just a minimal feedback about my enhancement for ldap plugin: > https://sourceforge.net/tracker/?func=detail&atid=397599&aid=2430999&group_id=29880 I had a quick look at this, but I'm not too hot on SSL certificates. Can anyone else validate this? Is there any way we can generate a testcase for this? Ton -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at sourceforge.net Fri Feb 20 01:08:28 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 20 Feb 2009 00:08:28 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1878971 ] several typos Message-ID: Bugs item #1878971, was opened at 2008-01-24 15:44 Message generated for change (Comment added) made by tonvoon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1878971&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: Release (specify) >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Jan Wagner (cyco_dd) >Assigned to: Ton Voon (tonvoon) Summary: several typos Initial Comment: the attached patch fixes several typos and was commited to Debian Nagios Maintainer Group. ---------------------------------------------------------------------- >Comment By: Ton Voon (tonvoon) Date: 2009-02-20 00:08 Message: I'm quite happy to apply this. It may affect the translations, but the text is incorrect, so it should be fixed. I think gettext will keep texts that are case different, so I've amended the translations for fr.po which are different. I don't really know if this is okay though.... ---------------------------------------------------------------------- Comment By: Matthias Eble (psychotrahe) Date: 2008-06-09 20:57 Message: Logged In: YES user_id=1694341 Originator: NO I haven't committed this since I think it'll break many translation strings. Personally, I like the patch. But maybe the team has to reconsider how to handle translations. This has been neglected for some time, now. ---------------------------------------------------------------------- Comment By: Jan Wagner (cyco_dd) Date: 2008-06-03 13:01 Message: Logged In: YES user_id=1345239 Originator: YES Is there anything blocking the commit ot the patch? Is there anythin what i can do to make it more easy? ---------------------------------------------------------------------- Comment By: Jan Wagner (cyco_dd) Date: 2008-06-03 12:58 Message: Logged In: YES user_id=1345239 Originator: YES File Added: 50_misc_typos.dpatch ---------------------------------------------------------------------- Comment By: Jan Wagner (cyco_dd) Date: 2008-02-05 21:56 Message: Logged In: YES user_id=1345239 Originator: YES see also http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=435525 and http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=453012 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1878971&group_id=29880 From noreply at sourceforge.net Fri Feb 20 01:11:26 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 20 Feb 2009 00:11:26 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1985230 ] check_snmp does not allow " chars in cmdline Message-ID: Bugs item #1985230, was opened at 2008-06-05 09:46 Message generated for change (Comment added) made by tonvoon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1985230&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Argument proccessing Group: CVS Status: Open Resolution: None Priority: 7 Private: No Submitted By: Jan Wagner (cyco_dd) Assigned to: Nobody/Anonymous (nobody) Summary: check_snmp does not allow " chars in cmdline Initial Comment: The following Bugreport we got against our debian package: snmpd can be queried for customized "extend"s. A configured extend like extend avail_mem /usr/local/bin/check_avail_mem.pl can be queried as snmpget -c public -v1 ds9 'nsExtendOutput1Line."avail_mem"' NET-SNMP-EXTEND-MIB::nsExtendOutput1Line."avail_mem" = STRING: 749764 If you try to query this with check_snmp like check_snmp -H $HOSTADDRESS$ -C public -o 'nsExtendOutput1Line."syslog-idletime"' this results into Could not open pipe: /usr/bin/snmpget -t 1 -r 5 -m ALL -v 1 -c public ds9:161 nsExtendOutput1Line."syslog-idletime" Unfortuantely, check_snmp contains code in popen.c that does not allow any " chars in the command line and bails out with above error. I fixed this by commenting out the follwing block: --- popen.c.old 2008-01-12 14:16:39.000000000 +0100 +++ popen.c 2008-01-12 14:16:54.000000000 +0100 @@ -133,8 +133,10 @@ strcpy (cmd, cmdstring); /* This is not a shell, so we don't handle "???" */ +/* if (strstr (cmdstring, "\"")) return NULL; +*/ /* allow single quotes, but only if non-whitesapce doesn't occur on both sides */ if (strstr (cmdstring, " ' ") || strstr (cmdstring, "'''")) You can track the bugreport via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=460405 Thanks and kind regards, Jan. ---------------------------------------------------------------------- >Comment By: Ton Voon (tonvoon) Date: 2009-02-20 00:11 Message: I don't think this is a valid fix. Preferably check_snmp should be switched to use the runcmd library instead, which has a function to pass a varg list for the command to run, thereby avoiding shell quotation. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1985230&group_id=29880 From noreply at sourceforge.net Fri Feb 20 01:26:40 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 20 Feb 2009 00:26:40 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-854538 ] check_nt - add check USEDDISKSPACE against remaining Mb Message-ID: Patches item #854538, was opened at 2003-12-05 05:44 Message generated for change (Comment added) made by tonvoon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=854538&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None >Status: Pending >Resolution: Wont Fix Priority: 5 Private: No Submitted By: Greg Vickers (daehenoc) >Assigned to: Ton Voon (tonvoon) Summary: check_nt - add check USEDDISKSPACE against remaining Mb Initial Comment: Please find attached my patch for version 1.7.2.3 of check_nt.c. This patch adds the ability to check disk space based on the amount of Mb left on a partition. I wrote this because 1% of a 100Gb partition is still a lot of space! :D The command line option is -m or --mb. The logic behind the checks is reversed against the percentage checks: the percentage method checks against the amount of disk space used; the Mb method checks against the amount of free space left. Technical stuff: I used Mb values rather than Gb values because of the use of the unsigned long type for the percentage values, which are used extensively through out check_nt.c. So rather than rewrite a lot of check_nt.c so you could specify, say, -w 1.2 (Gb), I decided to use Mb value on the command line. (Debugging revealed that when a float value is converted into an unsigned long, you would get a negative value in that unsigned long - not good when checking remaining disk space!) Thanks, Greg Vickers ---------------------------------------------------------------------- >Comment By: Ton Voon (tonvoon) Date: 2009-02-20 00:26 Message: Since there is no patch and this tracker item is so old, I'm going to mark this into a pending state so it will be closed automatically in 7 days if there are no updates. Ton ---------------------------------------------------------------------- Comment By: Benoit Mortier (opensides) Date: 2004-12-28 22:47 Message: Logged In: YES user_id=388184 Hi, there is no patch attached... Can you repost it thank you ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=854538&group_id=29880 From tonvoon at mac.com Fri Feb 20 01:42:23 2009 From: tonvoon at mac.com (Ton Voon) Date: Fri, 20 Feb 2009 00:42:23 +0000 Subject: [Nagiosplug-devel] check_http output differences Message-ID: Hi! If you run cd plugins && perl tests/check_http.t, this is failing most of the output tests at the moment. I think this is due to the change that Thomas made where check_http was not going through all its checks correctly (size and age and time). Is this valid? If so, I'll go through the outputs to work out if the changes all make sense. Ton From noreply at sourceforge.net Fri Feb 20 01:44:34 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 20 Feb 2009 00:44:34 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-1867736 ] check_http: allow simultaneous use size and content checks Message-ID: Patches item #1867736, was opened at 2008-01-09 15:22 Message generated for change (Settings changed) made by tonvoon You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1867736&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Bugfix Group: None >Status: Pending Resolution: None Priority: 5 Private: No Submitted By: svenx (svenx) >Assigned to: Ton Voon (tonvoon) Summary: check_http: allow simultaneous use size and content checks Initial Comment: Patch against Plugin Version: check_http v1892 (nagios-plugins 1.4.11) Plugin Name: check_http Example Plugin Commandline: ./check_http -H www.example.net -p 80 -f follow -m 700:750 -s 'reserved' Tested on operating system: Ubuntu 7.10 Tested on architecture: i686 Tested with compiler: gcc 4.1.3 This patch enables the user to perform both page size checking together with string or regex content checking. Previously, the string/regex test ignored the page size check. Sven Ulland ---------------------------------------------------------------------- >Comment By: Ton Voon (tonvoon) Date: 2009-02-20 00:44 Message: Sven, Can you please try the latest snapshot? http://nagiosplug.sourceforge.net/snapshot/. I believe this has been fixed already. I'm marking this call in pending - if it still doesn't work, please update this call. Ton ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=1867736&group_id=29880 From noreply at sourceforge.net Fri Feb 20 02:16:12 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 20 Feb 2009 01:16:12 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-854538 ] check_nt - add check USEDDISKSPACE against remaining Mb Message-ID: Patches item #854538, was opened at 2003-12-05 15:44 Message generated for change (Comment added) made by daehenoc You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=854538&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Enhancement Group: None >Status: Open Resolution: Wont Fix Priority: 5 Private: No Submitted By: Greg Vickers (daehenoc) Assigned to: Ton Voon (tonvoon) Summary: check_nt - add check USEDDISKSPACE against remaining Mb Initial Comment: Please find attached my patch for version 1.7.2.3 of check_nt.c. This patch adds the ability to check disk space based on the amount of Mb left on a partition. I wrote this because 1% of a 100Gb partition is still a lot of space! :D The command line option is -m or --mb. The logic behind the checks is reversed against the percentage checks: the percentage method checks against the amount of disk space used; the Mb method checks against the amount of free space left. Technical stuff: I used Mb values rather than Gb values because of the use of the unsigned long type for the percentage values, which are used extensively through out check_nt.c. So rather than rewrite a lot of check_nt.c so you could specify, say, -w 1.2 (Gb), I decided to use Mb value on the command line. (Debugging revealed that when a float value is converted into an unsigned long, you would get a negative value in that unsigned long - not good when checking remaining disk space!) Thanks, Greg Vickers ---------------------------------------------------------------------- >Comment By: Greg Vickers (daehenoc) Date: 2009-02-20 11:16 Message: Huh, apologies! I no longer have access to the server this patch was developed on, I have contacted the administrator and will try to get a copy of the patch with in the next seven days. Greg ---------------------------------------------------------------------- Comment By: Ton Voon (tonvoon) Date: 2009-02-20 10:26 Message: Since there is no patch and this tracker item is so old, I'm going to mark this into a pending state so it will be closed automatically in 7 days if there are no updates. Ton ---------------------------------------------------------------------- Comment By: Benoit Mortier (opensides) Date: 2004-12-29 08:47 Message: Logged In: YES user_id=388184 Hi, there is no patch attached... Can you repost it thank you ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=854538&group_id=29880 From waja at cyconet.org Fri Feb 20 16:58:23 2009 From: waja at cyconet.org (Jan Wagner) Date: Fri, 20 Feb 2009 16:58:23 +0100 Subject: [Nagiosplug-devel] Notification of plugins 1.4.14 release In-Reply-To: <200902051625.54170.waja@cyconet.org> References: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> <200902051625.54170.waja@cyconet.org> Message-ID: <200902201658.26925.waja@cyconet.org> On Thursday 05 February 2009, Jan Wagner wrote: > while maintaining the Debian Package I've submitted a bunch of bug-(fixes), > which I would love to see closed after longer time. > > The first one is fixing Typos, which I'm adjusting for every release, it > would be nice to have it included upstream: > > http://sourceforge.net/tracker/index.php?func=detail&aid=1878971&group_id=2 >9880&atid=397597 > > The following bugs are either with a patch or trivial to fix: > > http://sourceforge.net/tracker/index.php?func=detail&aid=1985230&group_id=2 >9880&atid=397597 > http://sourceforge.net/tracker/index.php?func=detail&aid=1985317&group_id=2 >9880&atid=397597 > http://sourceforge.net/tracker/index.php?func=detail&aid=1985338&group_id=2 >9880&atid=397597 > http://sourceforge.net/tracker/index.php?func=detail&aid=1985489&group_id=2 >9880&atid=397597 > http://sourceforge.net/tracker/index.php?func=detail&aid=1986260&group_id=2 >9880&atid=397597 > > Is there a chance to get rid of the deprecated LDAP API: > > http://sourceforge.net/tracker/index.php?func=detail&aid=1922579&group_id=2 >9880&atid=397597 Could you please also have a look on ping6 parsing issue for check_ping: https://sourceforge.net/tracker/index.php?func=detail&aid=1894850&group_id=29880&atid=397597 There is a patch attached, dunno if it fit your needs. :) Thanks, Jan. -- Never write mail to , you have been warned! -----BEGIN GEEK CODE BLOCK----- Version: 3.1 GIT d-- s+: a- C+++ UL++++ P+ L+++ E- W+++ N+++ o++ K++ w--- O M V- PS PE Y++ PGP++ t-- 5 X R tv- b+ DI- D++ G++ e++ h-- r+++ y+++ ------END GEEK CODE BLOCK------ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part. URL: From ridha2501 at gmail.com Mon Feb 23 15:03:05 2009 From: ridha2501 at gmail.com (bouhlel ridha) Date: Mon, 23 Feb 2009 15:03:05 +0100 Subject: [Nagiosplug-devel] Nagios freeBSD problem with plugins Message-ID: <903304bb0902230603j6e322002hf080472096f89e71@mail.gmail.com> Dear Sir, I found a problem with the plagin check_disk of nagios with -p option, there is a segmentation fault : (gdb) r -w 1% -c %1 -vvv -p /usr Starting program: /usr/generation_package/Test_compil_Ridha/packaging/GSUP/dist/exec/applis/superv/CE_nagios-plugins/current/bin/check_disk -w 1% -c %1 -vvv -p /usr calling stat on /usr calling stat on /usr For /usr, total=3102260, available=1095634, available_to_root=1343814, used=1758446, fsp.fsu_files=824318, fsp.fsu_ffree=569400 For /usr, used_pct=62 free_pct=38 used_units=3434 free_units=2139 total_units=6059 used_inodes_pct=31 free_inodes_pct=69 fsp.fsu_blocksize=2048 mult=1048576 Freespace_units result=0 Freespace% result=0 Usedspace_units result=0 Usedspace_percent result=0 Usedinodes_percent result=0 Program received signal SIGSEGV, Segmentation fault. check_range (value=69, my_range=0x424d) at utils_base.c:168 168 if (my_range->alert_on == INSIDE) { (gdb) bt #0 check_range (value=69, my_range=0x424d) at utils_base.c:168 #1 0x0804cf83 in get_status (value=69, my_thresholds=0x2820a09c) at utils_base.c:201 #2 0x0804b425 in main (argc=Error accessing memory address 0x0: Bad address. ) at check_disk.c:359 (gdb) Could yuo please help me resolving this problem! Thank you Ridha Bouhlel -------------- next part -------------- An HTML attachment was scrubbed... URL: From ridha2501 at gmail.com Mon Feb 23 15:23:34 2009 From: ridha2501 at gmail.com (bouhlel ridha) Date: Mon, 23 Feb 2009 15:23:34 +0100 Subject: [Nagiosplug-devel] Nagios freeBSD problem Message-ID: <903304bb0902230623t14816bf1xd2f95fd213576255@mail.gmail.com> Dear Sir, I found a problem with the plagin check_disk of nagios with -p option, there is a segmentation fault : (gdb) r -w 1% -c %1 -vvv -p /usr Starting program: /usr/generation_package/Test_compil_Ridha/packaging/GSUP/dist/exec/applis/superv/CE_nagios-plugins/current/bin/check_disk -w 1% -c %1 -vvv -p /usr calling stat on /usr calling stat on /usr For /usr, total=3102260, available=1095634, available_to_root=1343814, used=1758446, fsp.fsu_files=824318, fsp.fsu_ffree=569400 For /usr, used_pct=62 free_pct=38 used_units=3434 free_units=2139 total_units=6059 used_inodes_pct=31 free_inodes_pct=69 fsp.fsu_blocksize=2048 mult=1048576 Freespace_units result=0 Freespace% result=0 Usedspace_units result=0 Usedspace_percent result=0 Usedinodes_percent result=0 Program received signal SIGSEGV, Segmentation fault. check_range (value=69, my_range=0x424d) at utils_base.c: 168 168 if (my_range->alert_on == INSIDE) { (gdb) bt #0 check_range (value=69, my_range=0x424d) at utils_base.c:168 #1 0x0804cf83 in get_status (value=69, my_thresholds=0x2820a09c) at utils_base.c:201 #2 0x0804b425 in main (argc=Error accessing memory address 0x0: Bad address. ) at check_disk.c:359 (gdb) Could yuo please help me resolving this problem ! Thank you Ridha Bouhlel -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at sourceforge.net Mon Feb 23 16:12:28 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 23 Feb 2009 15:12:28 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Feature Requests-2630414 ] TCP/UDP-option(s) for check_dns Message-ID: Feature Requests item #2630414, was opened at 2009-02-23 16:12 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=2630414&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Priority: 5 Private: No Submitted By: Werner (forsbring) Assigned to: Nobody/Anonymous (nobody) Summary: TCP/UDP-option(s) for check_dns Initial Comment: Hi, could you please add options to choose TCP or UDP for DNS query with check_dns? - Werner Plugin Version (-V output): check_dns v1992 (nagios-plugins 1.4.13) Plugin Name: check_dns Operating System: RHEL5.3 Architecture: x86_64 Compiler: gcc ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=2630414&group_id=29880 From noreply at sourceforge.net Tue Feb 24 00:23:41 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 23 Feb 2009 23:23:41 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Feature Requests-2630414 ] TCP/UDP-option(s) for check_dns Message-ID: Feature Requests item #2630414, was opened at 2009-02-23 10:12 Message generated for change (Comment added) made by dermoth You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=2630414&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Priority: 5 Private: No Submitted By: Werner (forsbring) Assigned to: Nobody/Anonymous (nobody) Summary: TCP/UDP-option(s) for check_dns Initial Comment: Hi, could you please add options to choose TCP or UDP for DNS query with check_dns? - Werner Plugin Version (-V output): check_dns v1992 (nagios-plugins 1.4.13) Plugin Name: check_dns Operating System: RHEL5.3 Architecture: x86_64 Compiler: gcc ---------------------------------------------------------------------- >Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2009-02-23 18:23 Message: TCP is not needed in DNS - it's only used for transferring large amount of data like zone transfers. check_dns and check_nslookup use dig and nslookup respectively for making queries, and I'm not sure if either of them can allow that (I'll check later - I doubt for nslookup as it would unlikely be portable) You can still force them to use TCP by requesting large chunk of data; for example you can set the query type to AXFR on a large zone. You will need to be allowed for zone transfers though. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=2630414&group_id=29880 From noreply at sourceforge.net Tue Feb 24 10:04:20 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Tue, 24 Feb 2009 09:04:20 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Feature Requests-2630414 ] TCP/UDP-option(s) for check_dns Message-ID: Feature Requests item #2630414, was opened at 2009-02-23 10:12 Message generated for change (Comment added) made by dermoth You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=2630414&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed Priority: 5 Private: No Submitted By: Werner (forsbring) >Assigned to: Thomas Guyot-Sionnest (dermoth) Summary: TCP/UDP-option(s) for check_dns Initial Comment: Hi, could you please add options to choose TCP or UDP for DNS query with check_dns? - Werner Plugin Version (-V output): check_dns v1992 (nagios-plugins 1.4.13) Plugin Name: check_dns Operating System: RHEL5.3 Architecture: x86_64 Compiler: gcc ---------------------------------------------------------------------- >Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2009-02-24 04:04 Message: Oh, correction: check_dig and check_dns use dig and nslookup respectively check_dig has the option you need (-A "+tcp"). Nslookup does not seem to support any such option so I'll close this bug. ---------------------------------------------------------------------- Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2009-02-23 18:23 Message: TCP is not needed in DNS - it's only used for transferring large amount of data like zone transfers. check_dns and check_nslookup use dig and nslookup respectively for making queries, and I'm not sure if either of them can allow that (I'll check later - I doubt for nslookup as it would unlikely be portable) You can still force them to use TCP by requesting large chunk of data; for example you can set the query type to AXFR on a large zone. You will need to be allowed for zone transfers though. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=2630414&group_id=29880 From noreply at sourceforge.net Tue Feb 24 10:08:43 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Tue, 24 Feb 2009 09:08:43 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2632995 ] check_procs fails on Solaris Message-ID: Bugs item #2632995, was opened at 2009-02-24 10:08 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2632995&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Werner (forsbring) Assigned to: Nobody/Anonymous (nobody) Summary: check_procs fails on Solaris Initial Comment: Hi, check_procs v2019 (nagios-plugins 1.4.13) exits with "Unable to read output" on most of our Solaris8 and Solaris 10 servers (I do not have access to any Solaris9 servers). 1.4.11 works just fine. I've attached the truss output. - Werner ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2632995&group_id=29880 From noreply at sourceforge.net Tue Feb 24 10:19:27 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Tue, 24 Feb 2009 09:19:27 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1478287 ] check_dns fails with CNAMEs Message-ID: Bugs item #1478287, was opened at 2006-04-28 05:43 Message generated for change (Comment added) made by dermoth You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1478287&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Pending >Resolution: Works For Me Priority: 5 Private: No Submitted By: James (jfidell) >Assigned to: Thomas Guyot-Sionnest (dermoth) Summary: check_dns fails with CNAMEs Initial Comment: check_dns gives an error if the hostname being checked is a CNAME instead of an A record: DNS CRITICAL - '/usr/bin/nslookup -sil' msg parsing exited with no address This patch may be sub-optimal, but corrects the problem for me: --- check_dns.c~ Fri Apr 28 10:35:45 2006 +++ check_dns.c Fri Apr 28 10:35:52 2006 @@ -136,6 +136,13 @@ non_authoritative = TRUE; } + else if ( strstr ( chld_out.line[i], query_address ) && !address ) { + if (( temp_buffer = strstr ( chld_out.line[i] + strlen ( query_address ), + _("canonical name = ")))) { + address = strdup ( temp_buffer ); + } + } + result = error_scan (chld_out.line[i]); if (result != STATE_OK) { msg = strchr (chld_out.line[i], ':'); James ---------------------------------------------------------------------- >Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2009-02-24 04:19 Message: Works for me, even if the server does not return an address (CNAME only) If you still have issues, please post the full verbose output (-vvv) of check_dns from the latest release (or even better latest source tarball). I'll mark this as pending for now - this bug will close itself in a week. ---------------------------------------------------------------------- Comment By: James (jfidell) Date: 2007-06-11 05:05 Message: Logged In: YES user_id=1510516 Originator: YES OS is FreeBSD 6.0. Not sure about the nslookup version as it seems to defy my attempts to find out. IIRC correctly (as this was some time ago), the problem is not specifically that the format of output of nslookup is different, but that in same circumstances check_dns mis-handles the output. I *think* the problem is that for some configurations (could be where the CNAME is in a different domain, or where it is served by a different nameserver, or perhaps just depending on the nameserver implementation), nslookup may not return a "Name:" or "Address:" line at all, even though the nameserver being queried can and does answer properly that the queried hostname is a canonical name. ---------------------------------------------------------------------- Comment By: Matthias Eble (psychotrahe) Date: 2007-06-11 04:17 Message: Logged In: YES user_id=1694341 Originator: NO Announced pending state by sending emails to the participants. ---------------------------------------------------------------------- Comment By: Matthias Eble (psychotrahe) Date: 2007-06-04 12:00 Message: Logged In: YES user_id=1694341 Originator: NO Which OS version/nslookup version are you running? On Ubuntu Linux (6.06) everything is fine with cnames, too. nslookup output looks like this: ... foo.de.tld canonical name = bar.tld. Name: bar.tld Address: x.x.x.x Could you post your output, too? Thanks Matthias ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1478287&group_id=29880 From noreply at sourceforge.net Tue Feb 24 10:29:50 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Tue, 24 Feb 2009 09:29:50 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2632995 ] check_procs fails on Solaris Message-ID: Bugs item #2632995, was opened at 2009-02-24 04:08 Message generated for change (Comment added) made by dermoth You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2632995&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Werner (forsbring) >Assigned to: Thomas Guyot-Sionnest (dermoth) Summary: check_procs fails on Solaris Initial Comment: Hi, check_procs v2019 (nagios-plugins 1.4.13) exits with "Unable to read output" on most of our Solaris8 and Solaris 10 servers (I do not have access to any Solaris9 servers). 1.4.11 works just fine. I've attached the truss output. - Werner ---------------------------------------------------------------------- >Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2009-02-24 04:29 Message: Thanks for the debug output. Nagios-plugins now use pst3 to get the process list and this program needs to be installed and setuid root (I think old versions of nagios-plugins used it too, so you may have it already on some servers). It looks like you're trying to run from the source repository. Be sure to install the plugins, or at least hand-install pst3 (in plugins-root/ directory, don't forget to setuit root). If you still have issues I'll be able to help you is you can send the truss output again with the option to follow forks (-f). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2632995&group_id=29880 From dermoth at aei.ca Tue Feb 24 11:16:24 2009 From: dermoth at aei.ca (Thomas Guyot-Sionnest) Date: Tue, 24 Feb 2009 05:16:24 -0500 Subject: [Nagiosplug-devel] check_http output differences In-Reply-To: References: Message-ID: <49A3C8F8.70603@aei.ca> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 19/02/09 07:42 PM, Ton Voon wrote: > Hi! > > If you run cd plugins && perl tests/check_http.t, this is failing most > of the output tests at the moment. I think this is due to the change > that Thomas made where check_http was not going through all its checks > correctly (size and age and time). > > Is this valid? If so, I'll go through the outputs to work out if the > changes all make sense. Huh? Am I missing something? I did not notice any http failure on my workstation and solaris box. Am I running all checks? - -- Thomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFJo8j46dZ+Kt5BchYRAiBeAJ9nFNRD/N15c1W9pN3P6hmSZyrHYgCdGdTX i2h9huJPCkkpvHZNaWTWZkU= =m4NU -----END PGP SIGNATURE----- From dermoth at aei.ca Tue Feb 24 11:21:48 2009 From: dermoth at aei.ca (Thomas Guyot-Sionnest) Date: Tue, 24 Feb 2009 05:21:48 -0500 Subject: [Nagiosplug-devel] Nagios freeBSD problem with plugins In-Reply-To: <903304bb0902230603j6e322002hf080472096f89e71@mail.gmail.com> References: <903304bb0902230603j6e322002hf080472096f89e71@mail.gmail.com> Message-ID: <49A3CA3C.5090105@aei.ca> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 23/02/09 09:03 AM, bouhlel ridha wrote: > Dear Sir, > > I found a problem with the plagin check_disk of nagios with -p option, > there is a segmentation fault : > > > (gdb) r -w 1% -c %1 -vvv -p /usr > Starting program: /usr/generation_package/Test_ > compil_Ridha/packaging/GSUP/dist/exec/applis/superv/CE_nagios-plugins/current/bin/check_disk > -w 1% -c %1 -vvv -p /usr > calling stat on /usr > calling stat on /usr > For /usr, total=3102260, available=1095634, available_to_root=1343814, > used=1758446, fsp.fsu_files=824318, fsp.fsu_ffree=569400 > For /usr, used_pct=62 free_pct=38 used_units=3434 free_units=2139 > total_units=6059 used_inodes_pct=31 free_inodes_pct=69 > fsp.fsu_blocksize=2048 mult=1048576 > Freespace_units result=0 > Freespace% result=0 > Usedspace_units result=0 > Usedspace_percent result=0 > Usedinodes_percent result=0 > > Program received signal SIGSEGV, Segmentation fault. > check_range (value=69, my_range=0x424d) at utils_base.c:168 > 168 if (my_range->alert_on == INSIDE) { > (gdb) bt > #0 check_range (value=69, my_range=0x424d) at utils_base.c:168 > #1 0x0804cf83 in get_status (value=69, my_thresholds=0x2820a09c) at > utils_base.c:201 > #2 0x0804b425 in main (argc=Error accessing memory address 0x0: Bad > address. > ) at check_disk.c:359 > (gdb) > > > Could yuo please help me resolving this problem! Sure. First I will need to know which version of the plugins you are using. If possible, grab the latest snapshot and try with it (no need to install them; just run check_http off the plugins/ directory after compiling them) http://nagiosplug.sourceforge.net/snapshot/ Thanks - -- Thomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFJo8o86dZ+Kt5BchYRAty/AJ9NeCeb73oMf32MZA28dbOZPuGfyACdHLwJ nkU6RbcZnLR5NeycJmkBtEg= =j4hS -----END PGP SIGNATURE----- From noreply at sourceforge.net Tue Feb 24 11:44:17 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Tue, 24 Feb 2009 10:44:17 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2608223 ] check_snmp long help missing retries entry Message-ID: Bugs item #2608223, was opened at 2009-02-17 01:20 Message generated for change (Comment added) made by dermoth You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2608223&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: snapshot tarball >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Richard Edward Horner (mechanyx) >Assigned to: Thomas Guyot-Sionnest (dermoth) Summary: check_snmp long help missing retries entry Initial Comment: running check_snmp --help gives output that includes short help for -e retries but there's no -e, --retries in the long help. --retries is implemented in the code. Here's a patch to add the two lines to the long help. It was made against the latest dev snapshot: http://nagiosplug.sourceforge.net/snapshot/nagios-plugins-trunk-200902170100.tar.gz ---------------------------------------------------------------------- Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2009-02-24 05:44 Message: This problem is now fixed in Git. Thank you for your report. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2608223&group_id=29880 From noreply at sourceforge.net Tue Feb 24 11:44:29 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Tue, 24 Feb 2009 10:44:29 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2608223 ] check_snmp long help missing retries entry Message-ID: Bugs item #2608223, was opened at 2009-02-17 01:20 Message generated for change (Settings changed) made by dermoth You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2608223&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: snapshot tarball Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Richard Edward Horner (mechanyx) Assigned to: Thomas Guyot-Sionnest (dermoth) Summary: check_snmp long help missing retries entry Initial Comment: running check_snmp --help gives output that includes short help for -e retries but there's no -e, --retries in the long help. --retries is implemented in the code. Here's a patch to add the two lines to the long help. It was made against the latest dev snapshot: http://nagiosplug.sourceforge.net/snapshot/nagios-plugins-trunk-200902170100.tar.gz ---------------------------------------------------------------------- Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2009-02-24 05:44 Message: This problem is now fixed in Git. Thank you for your report. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2608223&group_id=29880 From ridha2501 at gmail.com Tue Feb 24 14:45:47 2009 From: ridha2501 at gmail.com (bouhlel ridha) Date: Tue, 24 Feb 2009 14:45:47 +0100 Subject: [Nagiosplug-devel] Nagios freeBSD problem with plugins In-Reply-To: <903304bb0902230603j6e322002hf080472096f89e71@mail.gmail.com> References: <903304bb0902230603j6e322002hf080472096f89e71@mail.gmail.com> Message-ID: <903304bb0902240545t82983l7744feab3038be4b@mail.gmail.com> I use nagios-plugins-1.4.13.tar.gz under FreeBSD 7.1 Thanks On Mon, Feb 23, 2009 at 3:03 PM, bouhlel ridha wrote: > Dear Sir, > > I found a problem with the plagin check_disk of nagios with -p option, > there is a segmentation fault : > > > (gdb) r -w 1% -c %1 -vvv -p /usr > Starting program: /usr/generation_package/Test_compil_Ridha/packaging/GSUP/dist/exec/applis/superv/CE_nagios-plugins/current/bin/check_disk > -w 1% -c %1 -vvv -p /usr > calling stat on /usr > calling stat on /usr > For /usr, total=3102260, available=1095634, available_to_root=1343814, > used=1758446, fsp.fsu_files=824318, fsp.fsu_ffree=569400 > For /usr, used_pct=62 free_pct=38 used_units=3434 free_units=2139 > total_units=6059 used_inodes_pct=31 free_inodes_pct=69 > fsp.fsu_blocksize=2048 mult=1048576 > Freespace_units result=0 > Freespace% result=0 > Usedspace_units result=0 > Usedspace_percent result=0 > Usedinodes_percent result=0 > > Program received signal SIGSEGV, Segmentation fault. > check_range (value=69, my_range=0x424d) at utils_base.c:168 > 168 if (my_range->alert_on == INSIDE) { > (gdb) bt > #0 check_range (value=69, my_range=0x424d) at utils_base.c:168 > #1 0x0804cf83 in get_status (value=69, my_thresholds=0x2820a09c) at > utils_base.c:201 > #2 0x0804b425 in main (argc=Error accessing memory address 0x0: Bad > address. > ) at check_disk.c:359 > (gdb) > > > Could yuo please help me resolving this problem! > > Thank you > Ridha Bouhlel > -------------- next part -------------- An HTML attachment was scrubbed... URL: From dermoth at aei.ca Tue Feb 24 18:04:24 2009 From: dermoth at aei.ca (Thomas Guyot-Sionnest) Date: Tue, 24 Feb 2009 12:04:24 -0500 Subject: [Nagiosplug-devel] Nagios freeBSD problem with plugins In-Reply-To: <903304bb0902240545t82983l7744feab3038be4b@mail.gmail.com> References: <903304bb0902230603j6e322002hf080472096f89e71@mail.gmail.com> <903304bb0902240545t82983l7744feab3038be4b@mail.gmail.com> Message-ID: <49A42898.3080600@aei.ca> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 bouhlel ridha wrote: > I use nagios-plugins-1.4.13.tar.gz under FreeBSD 7.1 Thank you - there aren't many differences with the current HEAD so that should be ok for testing. I'll try to have a look tonight or tomorrow morning - it may be helpful to have the fs list/usage, command arguments and full verbose output. You can send me that privately to my other email (@aei.ca) if you wish. Full output of the following commands: mount df check_disk -vvv + your arguments No need for another backtrace - the one you sent already is good enough. Thanks - -- Thomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFJpCiY6dZ+Kt5BchYRAliGAJsEy0nI8JtwojBFrF+m8DFM2TrAngCgtsx4 EXz9Iuuaz+JGuIYJwLlZJv0= =pCya -----END PGP SIGNATURE----- From noreply at sourceforge.net Wed Feb 25 10:56:24 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Wed, 25 Feb 2009 09:56:24 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Feature Requests-2636404 ] check_dns should be able to check both TCP and UDP Message-ID: Feature Requests item #2636404, was opened at 2009-02-25 10:56 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=2636404&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Priority: 5 Private: No Submitted By: Werner (forsbring) Assigned to: Nobody/Anonymous (nobody) Summary: check_dns should be able to check both TCP and UDP Initial Comment: Hi! It would be great check_dns had an argument for specifying weather it should use UDP or TCP for the DNS query. - Werner ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=2636404&group_id=29880 From noreply at sourceforge.net Wed Feb 25 11:12:16 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Wed, 25 Feb 2009 10:12:16 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Feature Requests-2636404 ] check_dns should be able to check both TCP and UDP Message-ID: Feature Requests item #2636404, was opened at 2009-02-25 04:56 Message generated for change (Comment added) made by dermoth You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=2636404&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed Priority: 5 Private: No Submitted By: Werner (forsbring) Assigned to: Nobody/Anonymous (nobody) Summary: check_dns should be able to check both TCP and UDP Initial Comment: Hi! It would be great check_dns had an argument for specifying weather it should use UDP or TCP for the DNS query. - Werner ---------------------------------------------------------------------- >Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2009-02-25 05:12 Message: See the previous feature request... https://sourceforge.net/tracker2/?func=detail&aid=2630414&group_id=29880&atid=397600 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=2636404&group_id=29880 From ridha2501 at gmail.com Wed Feb 25 12:26:26 2009 From: ridha2501 at gmail.com (bouhlel ridha) Date: Wed, 25 Feb 2009 12:26:26 +0100 Subject: [Nagiosplug-devel] Nagios freeBSD problem with plugins In-Reply-To: <49A42898.3080600@aei.ca> References: <903304bb0902230603j6e322002hf080472096f89e71@mail.gmail.com> <903304bb0902240545t82983l7744feab3038be4b@mail.gmail.com> <49A42898.3080600@aei.ca> Message-ID: <903304bb0902250326o2049ab8fn37b227db7c8e5302@mail.gmail.com> Hi Here what you want to see : mount : [root at tgv0000_sup /exec/applis/superv/CE_nagios-plugins/current/bin]# mount /dev/ad0s1a on / (ufs, local, read-only) devfs on /dev (devfs, local) procfs on /proc (procfs, local) /dev/ad0s3d on /exec (ufs, local, soft-updates) /dev/ad2s2d on /var (ufs, local, soft-updates) /dev/ad2s2e on /tmp (ufs, local, soft-updates) /dev/ad2s2g.journal on /data (ufs, NFS exported, local, gjournal) df : [root at tgv0000_sup /exec/applis/superv/CE_nagios-plugins/current/bin]# df Filesystem 1K-blocks Used Avail Capacity Mounted on /dev/ad0s1a 1012686 325908 605764 35% / devfs 1 1 0 100% /dev procfs 4 4 0 100% /proc /dev/ad0s3d 964334 31870 855318 4% /exec /dev/ad2s2d 5077038 623416 4047460 13% /var /dev/ad2s2e 5077038 617586 4053290 13% /tmp /dev/ad2s2g.journal 120903666 4220 111227154 0% /data check_disk -vvv -w 60% -p /exec [root at tgv0000_sup /exec/applis/superv/CE_nagios-plugins/current/bin]# ./check_disk -vvv -w 60% -p /exec For /exec, used_pct=4 free_pct=96 used_units=31 free_units=835 total_units=941 used_inodes_pct=1 free_inodes_pct=99 Freespace_units result=0 Freespace% result=0 Usedspace_units result=0 Usedspace_percent result=0 Usedinodes_percent result=0 Segmentation fault: 11 (core dumped) Thank you ! Rida On Tue, Feb 24, 2009 at 6:04 PM, Thomas Guyot-Sionnest wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > bouhlel ridha wrote: > > I use nagios-plugins-1.4.13.tar.gz under FreeBSD 7.1 > > Thank you - there aren't many differences with the current HEAD so that > should be ok for testing. > > I'll try to have a look tonight or tomorrow morning - it may be helpful > to have the fs list/usage, command arguments and full verbose output. > You can send me that privately to my other email (@aei.ca) if you wish. > > Full output of the following commands: > > mount > df > check_disk -vvv + your arguments > > No need for another backtrace - the one you sent already is good enough. > > Thanks > > - -- > Thomas > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.7 (MingW32) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org > > iD8DBQFJpCiY6dZ+Kt5BchYRAliGAJsEy0nI8JtwojBFrF+m8DFM2TrAngCgtsx4 > EXz9Iuuaz+JGuIYJwLlZJv0= > =pCya > -----END PGP SIGNATURE----- > > > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, > CA > -OSBC tackles the biggest issue in open source: Open Sourcing the > Enterprise > -Strategies to boost innovation and cut costs with open source > participation > -Receive a $600 discount off the registration fee with the source code: > SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________________ > Nagios Plugin Development Mailing List > Nagiosplug-devel at lists.sourceforge.net > Unsubscribe at > https://lists.sourceforge.net/lists/listinfo/nagiosplug-devel > ::: Please include plugins version (-v) and OS when reporting any issue. > ::: Messages without supporting info will risk being sent to /dev/null > -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at sourceforge.net Wed Feb 25 23:24:53 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Wed, 25 Feb 2009 22:24:53 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2638765 ] check_http has wrong HTTP version when using "Host:" Message-ID: Bugs item #2638765, was opened at 2009-02-26 09:24 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2638765&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Thiago Figueiro (thiagocsf) Assigned to: Nobody/Anonymous (nobody) Summary: check_http has wrong HTTP version when using "Host:" Initial Comment: The "Host" header does not exist in HTTP 1.0, but in HTTP 1.1 (see RFC for HTTP 1.0 http://www.faqs.org/rfcs/rfc2616.html and HTTP 1.1 http://www.faqs.org/rfcs/rfc1945.html) The 1.4.13 (latest release) version of check_http issues requests like: GET /myurl HTTP/1.0 User-Agent: check_http/v2053 (nagios-plugins 1.4.13) Connection: close Host: mydomain.com This will cause web servers and load balancers to ignore the "Host: mydomain.com" header because the request was specified as HTTP/1.0. The correct request is (notice "GET" line): GET /myurl HTTP/1.1 User-Agent: check_http/v2053 (nagios-plugins 1.4.13) Connection: close Host: mydomain.com A quick-and-dirty patch to fix this issue is below. --- plugins-orig/check_http.c 2009-02-26 09:11:55.000000000 +1100 +++ plugins/check_http.c 2009-02-26 09:07:46.000000000 +1100 @@ -783,7 +783,11 @@ } #endif /* HAVE_SSL */ + if (host_name) { + asprintf (&buf, "%s %s HTTP/1.1\r\n%s\r\n", http_method, server_url, user_agent); + } else { asprintf (&buf, "%s %s HTTP/1.0\r\n%s\r\n", http_method, server_url, user_agent); + } /* tell HTTP/1.1 servers not to keep the connection alive */ asprintf (&buf, "%sConnection: close\r\n", buf); Best regards, Thiago. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2638765&group_id=29880 From noreply at sourceforge.net Thu Feb 26 12:37:30 2009 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 26 Feb 2009 11:37:30 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2638765 ] check_http has wrong HTTP version when using "Host:" Message-ID: Bugs item #2638765, was opened at 2009-02-25 17:24 Message generated for change (Settings changed) made by dermoth You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2638765&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution >Group: v1.4.14 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Thiago Figueiro (thiagocsf) >Assigned to: Thomas Guyot-Sionnest (dermoth) Summary: check_http has wrong HTTP version when using "Host:" Initial Comment: The "Host" header does not exist in HTTP 1.0, but in HTTP 1.1 (see RFC for HTTP 1.0 http://www.faqs.org/rfcs/rfc2616.html and HTTP 1.1 http://www.faqs.org/rfcs/rfc1945.html) The 1.4.13 (latest release) version of check_http issues requests like: GET /myurl HTTP/1.0 User-Agent: check_http/v2053 (nagios-plugins 1.4.13) Connection: close Host: mydomain.com This will cause web servers and load balancers to ignore the "Host: mydomain.com" header because the request was specified as HTTP/1.0. The correct request is (notice "GET" line): GET /myurl HTTP/1.1 User-Agent: check_http/v2053 (nagios-plugins 1.4.13) Connection: close Host: mydomain.com A quick-and-dirty patch to fix this issue is below. --- plugins-orig/check_http.c 2009-02-26 09:11:55.000000000 +1100 +++ plugins/check_http.c 2009-02-26 09:07:46.000000000 +1100 @@ -783,7 +783,11 @@ } #endif /* HAVE_SSL */ + if (host_name) { + asprintf (&buf, "%s %s HTTP/1.1\r\n%s\r\n", http_method, server_url, user_agent); + } else { asprintf (&buf, "%s %s HTTP/1.0\r\n%s\r\n", http_method, server_url, user_agent); + } /* tell HTTP/1.1 servers not to keep the connection alive */ asprintf (&buf, "%sConnection: close\r\n", buf); Best regards, Thiago. ---------------------------------------------------------------------- >Comment By: Thomas Guyot-Sionnest (dermoth) Date: 2009-02-26 06:37 Message: Thanks for your patch. This is actually something that was fixed long time ago, but I reverted it because it was removing the :port part of the host header. I proposed a new patch but the follow-up was never done. There have been many changes since then so I doubt it will apply; I'll look very soon and re-apply it. See this thread for more details: http://archive.netbsd.se/?ml=nagiosplug-devel&a=2008-08&m=8377448 Related commits: 31efea1b490a12a64ce0359c2d847a381d2efb7b (2050) 0378f34d85e4fa2d83bae745c44649ccfb9744bb (2030) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2638765&group_id=29880 From Ovidiu.Marcu at tdn.de Thu Feb 26 18:33:55 2009 From: Ovidiu.Marcu at tdn.de (Ovidiu Marcu) Date: Thu, 26 Feb 2009 18:33:55 +0100 Subject: [Nagiosplug-devel] check_http problem In-Reply-To: References: Message-ID: Hello, I just wanted to say that I have installed the latest nagios-plugins 1.4.13 and check_http does not work as it should: "-S" for ssl websites doesn't exist at all :( Viele Gr??e, ServiceDesk_TDN Ovidiu Marcu -------------- next part -------------- An HTML attachment was scrubbed... URL: From marc at ena.com Thu Feb 26 18:45:40 2009 From: marc at ena.com (Marc Powell) Date: Thu, 26 Feb 2009 11:45:40 -0600 Subject: [Nagiosplug-devel] check_http problem In-Reply-To: References: Message-ID: <113E44A0-840B-4ADC-9611-07286D7BA42A@ena.com> On Feb 26, 2009, at 11:33 AM, Ovidiu Marcu wrote: > > Hello, > > I just wanted to say that I have installed the latest nagios-plugins > 1.4.13 and check_http does not work as it should: > ?-S? for ssl websites doesn?t exist at all L Sounds like ./configure didn't find the openssl libraries. Check config.log and verify that you have the openssl development packages installed. You may need to use the '--with-openssl=DIR' flag to ./ configure if it's installed in a non-standard place. HTH, Marc From mlitwin at stubhub.com Thu Feb 26 19:44:43 2009 From: mlitwin at stubhub.com (Matthew Litwin) Date: Thu, 26 Feb 2009 10:44:43 -0800 Subject: [Nagiosplug-devel] check_procs 1.4.11 on Solaris 10 returns "Not parsable" Message-ID: I have seen this question asked but have not been able to find it answered anywhere. The problem is that check_procs ?C some_process doesn?t match any processes. check_proc ?v reveals that each process entry is preceded by ?Not parsable?. I saw the suggestion that /usr/ucb/ was in $PATH at compile time, which is was not, so I presume it is something else that is preventing this plug-in from reading the process table. -------------- next part -------------- An HTML attachment was scrubbed... URL: From dimmumeister at gmail.com Sat Feb 28 09:12:31 2009 From: dimmumeister at gmail.com (hamouda) Date: Sat, 28 Feb 2009 09:12:31 +0100 Subject: [Nagiosplug-devel] Iptables,snort,acid,clamav,nessus,osiris Message-ID: <8b1d85200902280012h69f75e4cv1fd52a9a0d83b27a@mail.gmail.com> Hi everyone, I am a newbie in the nagios world and I'm trying to develop plugins for nagios to administrate iptables,snort,acid,clamav,nessus and osiris. Have anyone already tried doing this or have anyone any idea if what I'm trying to do is doable?? Any tutorials for plugin developping ?? Thx for answering :) -- being selfish won't help you progressing, learn & share that's the point. Give a hand in the forums to help the others & urself; http://www.fedora-tunisia.org/ http://forums.fedora-fr.org/ http://fedora.kiewel-online.de/repoview/linux/releases/7/ From dermoth at aei.ca Sat Feb 28 14:08:12 2009 From: dermoth at aei.ca (Thomas Guyot-Sionnest) Date: Sat, 28 Feb 2009 08:08:12 -0500 Subject: [Nagiosplug-devel] Iptables,snort,acid,clamav,nessus,osiris In-Reply-To: <8b1d85200902280012h69f75e4cv1fd52a9a0d83b27a@mail.gmail.com> References: <8b1d85200902280012h69f75e4cv1fd52a9a0d83b27a@mail.gmail.com> Message-ID: <49A9373C.4070102@aei.ca> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 28/02/09 03:12 AM, hamouda wrote: > Hi everyone, I am a newbie in the nagios world and I'm trying to > develop plugins for nagios to administrate > iptables,snort,acid,clamav,nessus and osiris. > Have anyone already tried doing this or have anyone any idea if what > I'm trying to do is doable?? > Any tutorials for plugin developping ?? See the Nagios plugins developer guidelines: http://nagiosplug.sourceforge.net/developer-guidelines.html You can also look for existing plugins on http://www.nagiosexchange.org and by doing Google searches. - -- Thomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFJqTc86dZ+Kt5BchYRAt5BAKDtgDTBhQ92mHbdEWTzSluM/yAqyACgwEWQ KNdrW1CvT98zD1XD8deZDWY= =tpkz -----END PGP SIGNATURE----- From Guillaume.Rousse at inria.fr Sat Feb 28 14:58:16 2009 From: Guillaume.Rousse at inria.fr (Guillaume Rousse) Date: Sat, 28 Feb 2009 14:58:16 +0100 Subject: [Nagiosplug-devel] Notification of plugins 1.4.14 release In-Reply-To: <32B769F8-2E39-4C0B-9D1D-1BDA02FABDFA@opsera.com> References: <688CCBBE-4346-49A8-8644-96FA98D212FE@opsera.com> <498AF04D.1040702@inria.fr> <32B769F8-2E39-4C0B-9D1D-1BDA02FABDFA@opsera.com> Message-ID: <49A942F8.5000500@inria.fr> Ton Voon a ?crit : > > On 5 Feb 2009, at 13:57, Guillaume Rousse wrote: > >> Ton Voon a ?crit : >>> A one week countdown for the next release, since Thomas has done lots >>> of bug fixes. >>> >>> Let us know if there's anything that must go in before the release. >> I'd like just a minimal feedback about my enhancement for ldap plugin: >> https://sourceforge.net/tracker/?func=detail&atid=397599&aid=2430999&group_id=29880 >> > > I had a quick look at this, but I'm not too hot on SSL certificates. Can > anyone else validate this? Is there any way we can generate a testcase > for this? You mean an automated testcase, right ? If you have anything already existing for https and for normal ldap operation, I could try to adapt them. Otherwise, just try the plugin on any tls-enabled LDAP server to test it. -- BOFH excuse #269: Melting hard drives