[Nagiosplug-devel] check_dns.c patch review request

[Thomas Guyot-Sionnest]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/07/09 05:25 PM, David Horn wrote:
> This is just a request to please review and/or commit the changes to
> check_dns to support IPv6 AAAA record types (and others).
> 
> Let me know if there are any test cases you want me to write, or any
> additional information or changes needed to accept this patch.
> 
> Patch is attached to this tracker entry:
> https://sourceforge.net/tracker/?func=detail&aid=2741269&group_id=29880&atid=397599

It looks good. I just have one question - on what basis did you increase
the ADDRESS_LENGTH macro? It would be helpful to know on what it's based
or how it was calculated.

Also, for inclusion we'll need to add tests too (plugins/t/check_dns.t).
If you can write them that would be awesome, otherwise it would really
help if you could at least give us a list of commands and what to expect
from them (return code and/or text match).

Thanks

- --
Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFKVrB06dZ+Kt5BchYRAjUkAKDRw7nHLrL/JDRkcxZAZmVm5+C8vgCeJqW4
/um/wrIiMznzBqBhv6R6B6A=
=Ovbo
-----END PGP SIGNATURE-----