[Nagiosplug-devel] Perfdata pattern in Nagios::Plugin::Performance.pm

Gerhard Lausser Gerhard.Lausser at consol.de
Mon Jul 13 10:30:25 CEST 2009


according to the development guidelines, the = character is allowed in a

2.label can contain any characters
3.the single quotes for the label are optional. Required if spaces, = or '
are in the label

Now i see in the function Nagios::Plugin::Performance::_parse the following
$string =~ /^'?([^'=]+)'?=($value_re)([.....

Shouldn't it be /^'?([^']+)'?=($value_re)([..... instead? I see no reason
why the = is excluded. The pattern will try to match as much characters as
possible so the = in '?=($value_re... will always be the = separating label
from value.

Do you agree or am i wrong because there is a reason why the = is excluded?


More information about the Devel mailing list