[Nagiosplug-devel] [ nagiosplug-Bugs-2796624 ] check_icmp wrong output in help

[SourceForge.net]

Bugs item #2796624, was opened at 2009-05-26 01:13
Message generated for change (Comment added) made by psychotrahe
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2796624&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Jan Wagner (cyco_dd)
>Assigned to: Matthias Eble (psychotrahe)
Summary: check_icmp wrong output in help

Initial Comment:
The following Bugreport we got against our debian package (1.4.12):

At no point are warn.rta and crit.rta handled differently.  The default behavior has a .5s timeout, not a 500s timeout.  The range for pl seems to be 0..100, and not some orders of magnitude otherwise.  All evidence indicates that the factor of 1000 was misplaced during some code change.

--- ./check_icmp.c
+++ /tmp/tmp.BWCqbw/check_icmp.c	2009-05-25 10:32:23.000000000 -0700
@@ -1271,10 +1271,10 @@
   printf ("    %s\n", _("specify a target"));
   printf (" %s\n", "-w");
   printf ("    %s", _("warning threshold (currently "));
-  printf ("%0.3fms,%u%%)\n", (float)warn.rta / 1000 , warn.pl / 1000);
+  printf ("%0.3fms,%u%%)\n", (float)warn.rta / 1000 , warn.pl);
   printf (" %s\n", "-c");
   printf ("    %s", _("critical threshold (currently "));
-  printf ("%0.3fms,%u%%)\n", (float)crit.rta, crit.pl);
+  printf ("%0.3fms,%u%%)\n", (float)crit.rta / 1000, crit.pl);
   printf (" %s\n", "-s");
   printf ("    %s\n", _("specify a source IP address or device name"));
   printf (" %s\n", "-n");

I know, its not an unified diff, but thats what we got so far, sorry. :)

You can track the bugreport via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=530553

Thanks and kind regards, Jan.

----------------------------------------------------------------------

>Comment By: Matthias Eble (psychotrahe)
Date: 2009-06-01 22:49

Message:
Hi again!

----------------------------------------------------------------------

Comment By: Matthias Eble (psychotrahe)
Date: 2009-06-01 22:49

Message:
This problem is now fixed in Git. Thank you for your report.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2796624&group_id=29880