From noreply at sourceforge.net Sun Aug 1 05:40:35 2010 From: noreply at sourceforge.net (SourceForge.net) Date: Sun, 01 Aug 2010 03:40:35 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2786808 ] check_http asks for HTTP/1.1, but doesn't understand chunked Message-ID: Bugs item #2786808, was opened at 2009-05-04 12:19 Message generated for change (Comment added) made by lamontgranquist You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2786808&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Parsing problem Group: CVS Status: Open Resolution: None Priority: 5 Private: No Submitted By: Ferenc W?gner (wferi) Assigned to: Holger Weiss (hweiss) Summary: check_http asks for HTTP/1.1, but doesn't understand chunked Initial Comment: Fixing 2638765 uncovered this bug (actually, most HTTP servers respect Host: headers in HTTP/1.0 requests, even though it isn't part of the spec). Anyway: if a client sends a HTTP/1.1 request, it must be able to handle the incoming HTTP/1.1 reply. Which includes coping with a chunked one. This exact same command worked with check_http version 1.4.5 (and still does so with -H replaced by -I, but that isn't the point). $ /usr/lib/nagios/plugins/check_http -v -H idp.niif.hu -u /idp/profile/Status --ssl -r "^ok$" GET /idp/profile/Status HTTP/1.1 Host: idp.niif.hu:443 User-Agent: check_http/v1991 (nagios-plugins 1.4.12) Connection: close https://idp.niif.hu:443/idp/profile/Status is 141 characters STATUS: HTTP/1.1 200 OK **** HEADER **** Date: Mon, 04 May 2009 19:12:13 GMT Connection: close Transfer-Encoding: chunked Content-Type: text/plain **** CONTENT **** 2 ok 0 HTTP CRITICAL - pattern not found|time=0.067933s;;;0.000000 size=141B;;;0 ---------------------------------------------------------------------- Comment By: Lamont Granquist (lamontgranquist) Date: 2010-07-31 20:40 Message: +1, I just ran into this bug. I started blaming our software devs for not marshalling their data correctly into XML and garbling it on the wire before I realized that the problem was that check_http didn't understand chunked encoding... ---------------------------------------------------------------------- Comment By: Holger Weiss (hweiss) Date: 2009-05-19 12:04 Message: I'll look into teaching check_http how to cope with chunked replies. Thanks for the bug report. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2786808&group_id=29880 From noreply at sourceforge.net Wed Aug 4 14:37:20 2010 From: noreply at sourceforge.net (SourceForge.net) Date: Wed, 04 Aug 2010 12:37:20 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-3039391 ] Patch to output used space Message-ID: Bugs item #3039391, was opened at 2010-08-04 14:37 Message generated for change (Tracker Item Submitted) made by juergenvigna You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3039391&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jrgen Vigna (juergenvigna) Assigned to: Nobody/Anonymous (nobody) Summary: Patch to output used space Initial Comment: Patch to ouput used space instead of only free space in check_disk plugin adding a -U option. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3039391&group_id=29880 From noreply at sourceforge.net Wed Aug 4 14:40:15 2010 From: noreply at sourceforge.net (SourceForge.net) Date: Wed, 04 Aug 2010 12:40:15 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-3039394 ] Patch to add perfdata to check_disk_smb Message-ID: Bugs item #3039394, was opened at 2010-08-04 14:40 Message generated for change (Tracker Item Submitted) made by juergenvigna You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3039394&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jrgen Vigna (juergenvigna) Assigned to: Nobody/Anonymous (nobody) Summary: Patch to add perfdata to check_disk_smb Initial Comment: This patch addes performance data to the output of check_disk_smb and also changes the output of the Share Name from \\ to // as this is more supported by the nagios webinterface. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3039394&group_id=29880 From mark.frost1 at pepsico.com Wed Aug 4 18:12:41 2010 From: mark.frost1 at pepsico.com (Frost, Mark {PBC}) Date: Wed, 4 Aug 2010 12:12:41 -0400 Subject: [Nagiosplug-devel] patch ID: 2975393 -- check_http HTTP CONNECT through proxy patch Message-ID: I think I must be doing something wrong here... Back in March, I submitted a patch on sourceforge for check_http to allow it to use HTTP CONNECT and check through a proxy. I guess I'd expected that it would automatically be tested and picked up for the next release. I'm looking at it now and it looks like it's not been touched. Of course, I'm not sure how this is supposed to work either. This was a simple patch against the official check_http.c 1.4.14 code. I don't have CVS here so I was hoping that the patch output would be sufficient. Is there something I'm supposed to do to give this patch some visibility and get it into the official tree? Thanks Mark -------------- next part -------------- An HTML attachment was scrubbed... URL: From gbatalov at crystals.ru Tue Aug 10 18:16:00 2010 From: gbatalov at crystals.ru (=?KOI8-R?B?4sHUwczP1yDn0snHz9LJyg==?=) Date: Tue, 10 Aug 2010 20:16:00 +0400 Subject: [Nagiosplug-devel] Segmentation fault (int pos) in check_procs Message-ID: Hello! I've found the clause in nagios-plugins-1.4.15/plugins/check_procs.c: int pos; /* number of spaces before 'args' in `ps` output */ ... if ( cols >= expected_cols ) { resultsum = 0; asprintf (&procargs, "%s", input_line + pos); strip (procargs); ... So I wonder how this variable (pos) is supposed to be initialized. On my system (tinycore linux 3.0) it gives different huge numbers like 166949407, 166949462, etc. and corresponding asprintf segfaults. Should I explicitly initialize it with "int pos=0;" or something? -- Grigory Batalov -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at sourceforge.net Thu Aug 12 16:17:21 2010 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 12 Aug 2010 14:17:21 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-1894850 ] check_ping: incorrectly parses ping6 output Message-ID: Bugs item #1894850, was opened at 2008-02-16 10:57 Message generated for change (Comment added) made by mnalis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1894850&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Parsing problem Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Matej Vela (vela) Assigned to: Nobody/Anonymous (nobody) Summary: check_ping: incorrectly parses ping6 output Initial Comment: Plugin Version: 1.4.11, HEAD Plugin Name: check_ping Plugin Commandline showing issues: check_ping -H [invalid-ipv6-address] -w 5000,100% -c 5000,100% -p 1 Operating System: Debian GNU/Linux 4.0 (etch) Debian's ping6 may produce output in the following format: 3 packets transmitted, 0 received, +3 errors, 100% packet loss, time 2009ms There's a corresponding pattern in check_ping.c:450: "%*d packets transmitted, %*d received, +%*d errors, %d%% packet loss" but the pattern in check_ping.c:448 matches first: "%*d packets transmitted, %*d received, %d%% loss, time" because sscanf interprets "+3" as a match for "%d". Although the rest of the pattern doesn't match, the number of successful assignments (and thus the return value of sscanf) is still 1. A simple way to make sure the whole pattern matches is to add a "%n" specifier at the end, which will assign the number of characters matched by that point. (The same trick is used in check_http.c.) There seems to be some confusion whether "%n" affects the return value of sscanf, so it's safer to check the assigned number of characters. Patch attached. ---------------------------------------------------------------------- Comment By: Matija Nalis (mnalis) Date: 2010-08-12 16:17 Message: Any chance of this fix being implemented? It's been sitting here for years now :-( BTW, it has also been reported at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=514588 if more info is needed ---------------------------------------------------------------------- Comment By: Matija Nalis (mnalis) Date: 2009-02-09 11:27 Message: has there been any luck with integrating this patch to nagios-plugins ? It does not seem to be getting any activity. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1894850&group_id=29880 From noreply at sourceforge.net Mon Aug 16 01:38:36 2010 From: noreply at sourceforge.net (SourceForge.net) Date: Sun, 15 Aug 2010 23:38:36 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2973603 ] disk_check, -g group, failing calculations Message-ID: Bugs item #2973603, was opened at 2010-03-20 02:52 Message generated for change (Settings changed) made by psychotrahe You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2973603&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Bekar (bekar) >Assigned to: Matthias Eble (psychotrahe) Summary: disk_check, -g group, failing calculations Initial Comment: >From a tinderbox build: # Failed test 'grouping: exit warning if the sum of free megs on mp1+mp2 is between -w and -c ' # at ./t/check_disk.t line 312. # got: 0 # expected: 1 # Looks like you failed 1 test of 78. .. Testing: ./check_disk -w 350 -c 348 -g group -p / -p /boot not ok 68 - grouping: exit warning if the sum of free megs on mp1+mp2 is between -w and -c Manually running the test and the check_disk command used to get the amount of disk space in the test shows: [root at dev00 plugins]# ./check_disk -w 350 -c 348 -p / -p /boot DISK CRITICAL - free space: / 275 MB (15% inode=91%); /boot 74 MB (80% inode=99%);| /=1518MB;1540;1542;0;1890 /boot=18MB;-252;-250;0;98 [root at dev00 plugins]# ./check_disk -w 350 -c 348 -g group -p / -p /boot DISK OK - free space: group 500 MB (26% inode=91%);| group=1386MB;1639;1641;0;1989 The test is doing the calculation properly (349), adding one and taking one for warning / critical. The check_disk it's self is coming up with the wrong number for free space in the group. ---------------------------------------------------------------------- >Comment By: Matthias Eble (psychotrahe) Date: 2010-08-16 01:38 Message: Hi Bekar, thanks for your report and running the test cases. Could you please send the failing grouping call with -vvvv added? This should ease finding the problem. Matthias ---------------------------------------------------------------------- Comment By: Bekar (bekar) Date: 2010-03-20 02:59 Message: Bloody hell, bad reporting there, sorry. Plugin Version (-V output): check_disk v1.4.14-65-ge11b (nagios-plugins 1.4.14) Operating System: Linux (Centos 5) Architecture: x86_64 Compiler: gcc version 4.1.2 20080704 (Red Hat 4.1.2-46) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2973603&group_id=29880 From noreply at sourceforge.net Mon Aug 16 12:34:57 2010 From: noreply at sourceforge.net (SourceForge.net) Date: Mon, 16 Aug 2010 10:34:57 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2973603 ] disk_check, -g group, failing calculations Message-ID: Bugs item #2973603, was opened at 2010-03-20 12:52 Message generated for change (Comment added) made by bekar You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2973603&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Bekar (bekar) Assigned to: Matthias Eble (psychotrahe) Summary: disk_check, -g group, failing calculations Initial Comment: >From a tinderbox build: # Failed test 'grouping: exit warning if the sum of free megs on mp1+mp2 is between -w and -c ' # at ./t/check_disk.t line 312. # got: 0 # expected: 1 # Looks like you failed 1 test of 78. .. Testing: ./check_disk -w 350 -c 348 -g group -p / -p /boot not ok 68 - grouping: exit warning if the sum of free megs on mp1+mp2 is between -w and -c Manually running the test and the check_disk command used to get the amount of disk space in the test shows: [root at dev00 plugins]# ./check_disk -w 350 -c 348 -p / -p /boot DISK CRITICAL - free space: / 275 MB (15% inode=91%); /boot 74 MB (80% inode=99%);| /=1518MB;1540;1542;0;1890 /boot=18MB;-252;-250;0;98 [root at dev00 plugins]# ./check_disk -w 350 -c 348 -g group -p / -p /boot DISK OK - free space: group 500 MB (26% inode=91%);| group=1386MB;1639;1641;0;1989 The test is doing the calculation properly (349), adding one and taking one for warning / critical. The check_disk it's self is coming up with the wrong number for free space in the group. ---------------------------------------------------------------------- >Comment By: Bekar (bekar) Date: 2010-08-16 20:34 Message: For point-in-time reference, what the check_disk.t uses to get the available space, coupled with a 'df' just to make sure I'm not going loony: ]# ./check_disk -w 1 -c 1 -p / -p /boot DISK OK - free space: / 143 MB (8% inode=90%); /boot 74 MB (79% inode=99%);| /=1649MB;1889;1889;0;1890 /boot=19MB;97;97;0;98 ]# df -vh Filesystem ???????????Size ?Used Avail Use% Mounted on /dev/mapper/VolGroup01-LogVol00 ?????????????????????1.9G ?1.7G ?144M ?92% / /dev/hda1 ?????????????99M ??20M ??75M ?21% /boot tmpfs ????????????????250M ????0 ?250M ??0% /dev/shm Then the strange output: ]# ./check_disk -vvvv -w 218 -c 216 -g group -p / -p /boot calling stat on / calling stat on /boot Group of /: group calling stat on / Group group: add 36758 blocks (/) calling stat on / Group group: add 75817 blocks (/boot) For group, total=585138, available=112575, available_to_root=142779, used=442359, fsp.fsu_files=525816, fsp.fsu_ffree=479159 For group, used_pct=80 free_pct=20 used_units=1503 free_units=382 total_units=1989 used_inodes_pct=9 free_inodes_pct=91 fsp.fsu_blocksize=3565 mult=1048576 Freespace_units result=0 Freespace% result=0 Usedspace_units result=0 Usedspace_percent result=0 Usedinodes_percent result=0 Freeinodes_percent result=0 Group of /boot: group DISK OK - free space: group 382 MB (20% inode=91%);| group=1503MB;1771;1773;0;198 ---------------------------------------------------------------------- Comment By: Matthias Eble (psychotrahe) Date: 2010-08-16 09:38 Message: Hi Bekar, thanks for your report and running the test cases. Could you please send the failing grouping call with -vvvv added? This should ease finding the problem. Matthias ---------------------------------------------------------------------- Comment By: Bekar (bekar) Date: 2010-03-20 12:59 Message: Bloody hell, bad reporting there, sorry. Plugin Version (-V output): check_disk v1.4.14-65-ge11b (nagios-plugins 1.4.14) Operating System: Linux (Centos 5) Architecture: x86_64 Compiler: gcc version 4.1.2 20080704 (Red Hat 4.1.2-46) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2973603&group_id=29880 From noreply at sourceforge.net Wed Aug 18 01:39:47 2010 From: noreply at sourceforge.net (SourceForge.net) Date: Tue, 17 Aug 2010 23:39:47 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2973603 ] disk_check, -g group, failing calculations Message-ID: Bugs item #2973603, was opened at 2010-03-20 02:52 Message generated for change (Comment added) made by psychotrahe You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2973603&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Bekar (bekar) Assigned to: Matthias Eble (psychotrahe) Summary: disk_check, -g group, failing calculations Initial Comment: >From a tinderbox build: # Failed test 'grouping: exit warning if the sum of free megs on mp1+mp2 is between -w and -c ' # at ./t/check_disk.t line 312. # got: 0 # expected: 1 # Looks like you failed 1 test of 78. .. Testing: ./check_disk -w 350 -c 348 -g group -p / -p /boot not ok 68 - grouping: exit warning if the sum of free megs on mp1+mp2 is between -w and -c Manually running the test and the check_disk command used to get the amount of disk space in the test shows: [root at dev00 plugins]# ./check_disk -w 350 -c 348 -p / -p /boot DISK CRITICAL - free space: / 275 MB (15% inode=91%); /boot 74 MB (80% inode=99%);| /=1518MB;1540;1542;0;1890 /boot=18MB;-252;-250;0;98 [root at dev00 plugins]# ./check_disk -w 350 -c 348 -g group -p / -p /boot DISK OK - free space: group 500 MB (26% inode=91%);| group=1386MB;1639;1641;0;1989 The test is doing the calculation properly (349), adding one and taking one for warning / critical. The check_disk it's self is coming up with the wrong number for free space in the group. ---------------------------------------------------------------------- >Comment By: Matthias Eble (psychotrahe) Date: 2010-08-18 01:39 Message: hi again, I found a bug in the calculation logic, but the problem only shows up if the FS blocksizes differ. Could you please check if this is the case at your site? This will of course be fixed either way, but you can simply check this by changing printf("Group %s: add %llu blocks (%s) \n", path->group, tmpfsp.fsu_bavail, temp_list->name); to printf("Group %s: add %llu blocks (%s) sized %d\n", path->group, tmpfsp.fsu_bavail, temp_list->name, tmpfsp.fsu_blocksize); and run the -vvvv check again. I'd bet the sizes differ. Matthias ---------------------------------------------------------------------- Comment By: Bekar (bekar) Date: 2010-08-16 12:34 Message: For point-in-time reference, what the check_disk.t uses to get the available space, coupled with a 'df' just to make sure I'm not going loony: ]# ./check_disk -w 1 -c 1 -p / -p /boot DISK OK - free space: / 143 MB (8% inode=90%); /boot 74 MB (79% inode=99%);| /=1649MB;1889;1889;0;1890 /boot=19MB;97;97;0;98 ]# df -vh Filesystem ???????????Size ?Used Avail Use% Mounted on /dev/mapper/VolGroup01-LogVol00 ?????????????????????1.9G ?1.7G ?144M ?92% / /dev/hda1 ?????????????99M ??20M ??75M ?21% /boot tmpfs ????????????????250M ????0 ?250M ??0% /dev/shm Then the strange output: ]# ./check_disk -vvvv -w 218 -c 216 -g group -p / -p /boot calling stat on / calling stat on /boot Group of /: group calling stat on / Group group: add 36758 blocks (/) calling stat on / Group group: add 75817 blocks (/boot) For group, total=585138, available=112575, available_to_root=142779, used=442359, fsp.fsu_files=525816, fsp.fsu_ffree=479159 For group, used_pct=80 free_pct=20 used_units=1503 free_units=382 total_units=1989 used_inodes_pct=9 free_inodes_pct=91 fsp.fsu_blocksize=3565 mult=1048576 Freespace_units result=0 Freespace% result=0 Usedspace_units result=0 Usedspace_percent result=0 Usedinodes_percent result=0 Freeinodes_percent result=0 Group of /boot: group DISK OK - free space: group 382 MB (20% inode=91%);| group=1503MB;1771;1773;0;198 ---------------------------------------------------------------------- Comment By: Matthias Eble (psychotrahe) Date: 2010-08-16 01:38 Message: Hi Bekar, thanks for your report and running the test cases. Could you please send the failing grouping call with -vvvv added? This should ease finding the problem. Matthias ---------------------------------------------------------------------- Comment By: Bekar (bekar) Date: 2010-03-20 02:59 Message: Bloody hell, bad reporting there, sorry. Plugin Version (-V output): check_disk v1.4.14-65-ge11b (nagios-plugins 1.4.14) Operating System: Linux (Centos 5) Architecture: x86_64 Compiler: gcc version 4.1.2 20080704 (Red Hat 4.1.2-46) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2973603&group_id=29880 From noreply at sourceforge.net Sat Aug 21 03:18:06 2010 From: noreply at sourceforge.net (SourceForge.net) Date: Sat, 21 Aug 2010 01:18:06 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2973603 ] disk_check, -g group, failing calculations Message-ID: Bugs item #2973603, was opened at 2010-03-20 12:52 Message generated for change (Comment added) made by bekar You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2973603&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Bekar (bekar) Assigned to: Matthias Eble (psychotrahe) Summary: disk_check, -g group, failing calculations Initial Comment: >From a tinderbox build: # Failed test 'grouping: exit warning if the sum of free megs on mp1+mp2 is between -w and -c ' # at ./t/check_disk.t line 312. # got: 0 # expected: 1 # Looks like you failed 1 test of 78. .. Testing: ./check_disk -w 350 -c 348 -g group -p / -p /boot not ok 68 - grouping: exit warning if the sum of free megs on mp1+mp2 is between -w and -c Manually running the test and the check_disk command used to get the amount of disk space in the test shows: [root at dev00 plugins]# ./check_disk -w 350 -c 348 -p / -p /boot DISK CRITICAL - free space: / 275 MB (15% inode=91%); /boot 74 MB (80% inode=99%);| /=1518MB;1540;1542;0;1890 /boot=18MB;-252;-250;0;98 [root at dev00 plugins]# ./check_disk -w 350 -c 348 -g group -p / -p /boot DISK OK - free space: group 500 MB (26% inode=91%);| group=1386MB;1639;1641;0;1989 The test is doing the calculation properly (349), adding one and taking one for warning / critical. The check_disk it's self is coming up with the wrong number for free space in the group. ---------------------------------------------------------------------- >Comment By: Bekar (bekar) Date: 2010-08-21 11:18 Message: [buildmonkey at dev00 plugins]$ ./check_disk -vvv -w 448 -c 446 -g group -p / -p /boot calling stat on / calling stat on /boot Group of /: group calling stat on / Group group: add 43753 blocks (/) sized 4096 calling stat on / Group group: add 75429 blocks (/boot) sized 1024 For group, total=585138, available=119182, available_to_root=149386, used=435752, fsp.fsu_files=525816, fsp.fsu_ffree=477983 For group, used_pct=79 free_pct=21 used_units=1481 free_units=405 total_units=1989 used_inodes_pct=10 free_inodes_pct=90 fsp.fsu_blocksize=3565 mult=1048576 Freespace_units result=2 Freespace% result=0 Usedspace_units result=0 Usedspace_percent result=0 Usedinodes_percent result=0 Freeinodes_percent result=0 Group of /boot: group DISK CRITICAL - free space: group 405 MB (21% inode=90%);| group=1481MB;1541;1543;0;1989 [buildmonkey at dev00 plugins]$ ./check_disk -vvvv -w 448 -c 446 -g group -p / -p /boot calling stat on / calling stat on /boot Group of /: group calling stat on / Group group: add 43753 blocks (/) sized 4096 calling stat on / Group group: add 75429 blocks (/boot) sized 1024 For group, total=585138, available=119182, available_to_root=149386, used=435752, fsp.fsu_files=525816, fsp.fsu_ffree=477983 For group, used_pct=79 free_pct=21 used_units=1481 free_units=405 total_units=1989 used_inodes_pct=10 free_inodes_pct=90 fsp.fsu_blocksize=3565 mult=1048576 Freespace_units result=2 Freespace% result=0 Usedspace_units result=0 Usedspace_percent result=0 Usedinodes_percent result=0 Freeinodes_percent result=0 Group of /boot: group DISK CRITICAL - free space: group 405 MB (21% inode=90%);| group=1481MB;1541;1543;0;1989 One FS is 1024, the other is 4096. ---------------------------------------------------------------------- Comment By: Matthias Eble (psychotrahe) Date: 2010-08-18 09:39 Message: hi again, I found a bug in the calculation logic, but the problem only shows up if the FS blocksizes differ. Could you please check if this is the case at your site? This will of course be fixed either way, but you can simply check this by changing printf("Group %s: add %llu blocks (%s) \n", path->group, tmpfsp.fsu_bavail, temp_list->name); to printf("Group %s: add %llu blocks (%s) sized %d\n", path->group, tmpfsp.fsu_bavail, temp_list->name, tmpfsp.fsu_blocksize); and run the -vvvv check again. I'd bet the sizes differ. Matthias ---------------------------------------------------------------------- Comment By: Bekar (bekar) Date: 2010-08-16 20:34 Message: For point-in-time reference, what the check_disk.t uses to get the available space, coupled with a 'df' just to make sure I'm not going loony: ]# ./check_disk -w 1 -c 1 -p / -p /boot DISK OK - free space: / 143 MB (8% inode=90%); /boot 74 MB (79% inode=99%);| /=1649MB;1889;1889;0;1890 /boot=19MB;97;97;0;98 ]# df -vh Filesystem ???????????Size ?Used Avail Use% Mounted on /dev/mapper/VolGroup01-LogVol00 ?????????????????????1.9G ?1.7G ?144M ?92% / /dev/hda1 ?????????????99M ??20M ??75M ?21% /boot tmpfs ????????????????250M ????0 ?250M ??0% /dev/shm Then the strange output: ]# ./check_disk -vvvv -w 218 -c 216 -g group -p / -p /boot calling stat on / calling stat on /boot Group of /: group calling stat on / Group group: add 36758 blocks (/) calling stat on / Group group: add 75817 blocks (/boot) For group, total=585138, available=112575, available_to_root=142779, used=442359, fsp.fsu_files=525816, fsp.fsu_ffree=479159 For group, used_pct=80 free_pct=20 used_units=1503 free_units=382 total_units=1989 used_inodes_pct=9 free_inodes_pct=91 fsp.fsu_blocksize=3565 mult=1048576 Freespace_units result=0 Freespace% result=0 Usedspace_units result=0 Usedspace_percent result=0 Usedinodes_percent result=0 Freeinodes_percent result=0 Group of /boot: group DISK OK - free space: group 382 MB (20% inode=91%);| group=1503MB;1771;1773;0;198 ---------------------------------------------------------------------- Comment By: Matthias Eble (psychotrahe) Date: 2010-08-16 09:38 Message: Hi Bekar, thanks for your report and running the test cases. Could you please send the failing grouping call with -vvvv added? This should ease finding the problem. Matthias ---------------------------------------------------------------------- Comment By: Bekar (bekar) Date: 2010-03-20 12:59 Message: Bloody hell, bad reporting there, sorry. Plugin Version (-V output): check_disk v1.4.14-65-ge11b (nagios-plugins 1.4.14) Operating System: Linux (Centos 5) Architecture: x86_64 Compiler: gcc version 4.1.2 20080704 (Red Hat 4.1.2-46) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2973603&group_id=29880 From noreply at sourceforge.net Sat Aug 21 07:11:31 2010 From: noreply at sourceforge.net (SourceForge.net) Date: Sat, 21 Aug 2010 05:11:31 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-3049988 ] check_linux_raid fails on RAID0 and linear volumes Message-ID: Bugs item #3049988, was opened at 2010-08-20 22:11 Message generated for change (Tracker Item Submitted) made by You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3049988&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: Release (specify) Status: Open Resolution: None Priority: 5 Private: No Submitted By: clint-fewbar () Assigned to: Nobody/Anonymous (nobody) Summary: check_linux_raid fails on RAID0 and linear volumes Initial Comment: Forwarding this bug from an Ubuntu bug report, seen here: https://bugs.launchpad.net/ubuntu/+source/nagios-plugins/+bug/621380 When the plugin is run with no arguments and there are RAID0 or linear volumes, it displays errors like this: ch at vmserver1:~$ cat /proc/mdstat Personalities : [linear] [multipath] [raid0] [raid1] [raid6] [raid5] [raid4] [raid10] md2 : active raid0 sdf1[1] sde1[0] 1952443392 blocks 64k chunks md0 : active raid1 sda1[0] sdd1[3] sdc1[2] sdb1[1] 995904 blocks [4/4] [UUUU] md1 : active raid5 sdc2[2] sdd2[3] sda2[0] sdb2[1] 1460549184 blocks level 5, 64k chunk, algorithm 2 [4/4] [UUUU] ch at vmserver1:~$ sudo /usr/lib/nagios/plugins/check_linux_raid Use of uninitialized value within %status in pattern match (m//) at /usr/lib/nagios/plugins/check_linux_raid line 82, line 11. Use of uninitialized value within %status in pattern match (m//) at /usr/lib/nagios/plugins/check_linux_raid line 91, line 11. OK md0 status=[UUUU]. md1 status=[UUUU]. md2 active with no status information. The patch located here solves the issue: https://bugs.launchpad.net/ubuntu/+source/nagios-plugins/+bug/621380/+attachment/1505517/+files/patch I have not evaluated whether it has any adverse effects, though it seems like it shouldn't. Note that this was also reported in Debian, here: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=579049 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3049988&group_id=29880 From dermoth at aei.ca Mon Aug 23 13:46:01 2010 From: dermoth at aei.ca (Thomas Guyot-Sionnest) Date: Mon, 23 Aug 2010 07:46:01 -0400 Subject: [Nagiosplug-devel] Segmentation fault (int pos) in check_procs In-Reply-To: References: Message-ID: <4C725F79.6020709@aei.ca> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10-08-10 12:16 PM, ??????? ???????? wrote: > Hello! > I've found the clause in nagios-plugins-1.4.15/plugins/check_procs.c: > > int pos; /* number of spaces before 'args' in `ps` output */ > ... > if ( cols >= expected_cols ) { > resultsum = 0; > asprintf (&procargs, "%s", input_line + pos); > strip (procargs); > ... > > So I wonder how this variable (pos) is supposed to be initialized. > On my system (tinycore linux 3.0) it gives different huge numbers > like 166949407, 166949462, etc. and corresponding asprintf segfaults. > Should I explicitly initialize it with "int pos=0;" or something? This variable should be initialized by a scanf call using the macros PS_FORMAT and PS_VARLIST - this is system-specific. From my config.h (In the root of the source code, this file is generated by configure) I have the following definitions: /* Format string for scanning ps output in check_procs */ #define PS_FORMAT "%s %d %d %d %d %d %f %s %n" /* Whether the ps utility uses the "procetime" field */ /* #undef PS_USES_PROCETIME */ /* Variable list for sscanf of 'ps' output */ #define PS_VARLIST procstat,&procuid,&procpid,&procppid,&procvsz,&procrss,&procpcpu,procprog,&pos And then in check_procs.c the variables are populated with: cols = sscanf (input_line, PS_FORMAT, PS_VARLIST); I have very little experience with sscanf, but I guess either the PS_FORMAT was wrong based on your ps command (detected by configure), or you manually specified a broken --with-ps-varlist option to configure. Could you please send the PS_* macros in config.h, and run the check_procs command in full debug mode (with -vvv) and send us the output (as an attachment, to avoid line-wraps in email)? Thank you, - -- Thomas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkxyX3AACgkQ6dZ+Kt5BchZ8uACeMSAl5qQHJQPPB9zKOsM27E/V 0N4AmwSxMF9WAx7gUUB7WCmQ9DfrwQRK =A8HR -----END PGP SIGNATURE----- From gbatalov at crystals.ru Tue Aug 24 08:14:48 2010 From: gbatalov at crystals.ru (=?KOI8-R?B?4sHUwczP1yDn0snHz9LJyg==?=) Date: Tue, 24 Aug 2010 10:14:48 +0400 Subject: [Nagiosplug-devel] Segmentation fault (int pos) in check_procs In-Reply-To: <4C725F79.6020709@aei.ca> References: <4C725F79.6020709@aei.ca> Message-ID: Thomas Guyot-Sionnest wrote: > I've found the clause in nagios-plugins-1.4.15/plugins/check_procs.c: > > > > int pos; /* number of spaces before 'args' in `ps` output */ > > ... > > if ( cols >= expected_cols ) { > > resultsum = 0; > > asprintf (&procargs, "%s", input_line + pos); > > strip (procargs); > > ... > > > > So I wonder how this variable (pos) is supposed to be initialized. > > On my system (tinycore linux 3.0) it gives different huge numbers > > like 166949407, 166949462, etc. and corresponding asprintf segfaults. > > Should I explicitly initialize it with "int pos=0;" or something? > > This variable should be initialized by a scanf call using the macros > PS_FORMAT and PS_VARLIST - this is system-specific. Ah, that's it! I used to redefine ps command because configure can't detect it correctly (TinyCore Linux includes busybox' version). $ configure --with-ps-varlist="&procpid,&procppid,&procvsz,&procrss,procprog" --with-ps-cols=5 --with-ps-format="%d %d %d %d %s" --with-ps-command="/bin/ps -o pid,ppid,vsz,rss,comm,args" According to your config I should replace it with $ configure --with-ps-varlist="&procpid,&procppid,&procvsz,&procrss,procprog,&pos" --with-ps-cols=6 --with-ps-format="%d %d %d %d %s %n" --with-ps-command="/bin/ps -o pid,ppid,vsz,rss,comm,args" Now it works as expected, thank you! -- Grigory Batalov -------------- next part -------------- An HTML attachment was scrubbed... URL: From noreply at sourceforge.net Tue Aug 24 20:18:21 2010 From: noreply at sourceforge.net (SourceForge.net) Date: Tue, 24 Aug 2010 18:18:21 +0000 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-3052433 ] Fix implicit pointer conversion due to missing ldap_init Message-ID: Bugs item #3052433, was opened at 2010-08-24 21:18 Message generated for change (Tracker Item Submitted) made by hwoarang_gr You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3052433&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Compilation Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Hwoarang (hwoarang_gr) Assigned to: Nobody/Anonymous (nobody) Summary: Fix implicit pointer conversion due to missing ldap_init Initial Comment: Hi I apply this patch to gentoo linux package http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-analyzer/nagios-plugins/files/nagios-plugins-1.4.14-implicit-pointer-conversion.patch?revision=1.1&view=markup This is because the function is defined on ldap.h header but it is not known during compilation time because LDAP_DEPRECATED macro is not defined to the function gets actualy exported Thanks ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3052433&group_id=29880 From MDahmke at 4w.com Tue Aug 31 23:23:40 2010 From: MDahmke at 4w.com (Mark Dahmke) Date: Tue, 31 Aug 2010 16:23:40 -0500 Subject: [Nagiosplug-devel] FW: check_mrtgtraf problem Message-ID: <062BD30A4FE3D645B73BF1407C70E7D0DB7F63@ia32.internal.4w.com> Hello - I'm trying to figure out what I'm doing wrong... why are the averages shown by MRTG and check_mrtgtraf so different? Thank you This is from the MRTG report for daily, 5 minute average: Max Average Current In 423.4 kb/s (0.4%) 76.0 kb/s (0.1%) 76.0 kb/s (0.1%) Out 3766.9 kb/s (3.8%) 1297.0 kb/s (1.3%) 1663.7 kb/s (1.7%) This is what I'm seeing when I run check_mrtgtraf on the same log file: Traffic OK - Avg. In = 9.1 KB/s, Avg. Out = 181.8 KB/s in=9.106445KB/s;1000000.000000;5000000.000000;0.000000 out=181.834961KB/s;2000000.000000;5000000.000000;0.000000 Here's the log file: 1283287833 120412663 3392272079 1283287833 9325 186199 9325 186199 1283287532 10953 390273 10953 390273 1283287500 10576 382936 10953 390273 1283287200 7330 295385 7632 325535 1283286900 5123 57192 7099 105322 1283286600 8287 151067 17903 521191 1283286300 16308 470864 17903 521191 . . . -------------- next part -------------- An HTML attachment was scrubbed... URL: