[Nagiosplug-devel] [nagios-plugins] fixed small bug in previous applied certificate expiration patch (#12)

William Leibzon reply+i-5867954-c348a0f4201a44527ec98b959e12ffabca4fcf82-1651316 at reply.github.com
Fri Jul 27 03:01:35 CEST 2012


my previous certificate expiration check patch had a bug and would not have properly checked if warning threshold had numeric values, the actual threshold checking code had no problems

You can merge this Pull Request by running:

  git pull https://github.com/willixix/nagios-plugins master

Or you can view, comment on it, or merge it online at:

  https://github.com/nagios-plugins/nagios-plugins/pull/12

-- Commit Summary --

* applied patch that adds both critical and warning thresholds to certificate expiration checks of check_tcp, check_http, check_smtp
* manually merged latest update that added SSL version parameter into my code that adds warn and crit thresholds for SSL
* added test case for certificate checs with both warning and critical values
* fixing bug in certificate experiation patch checking for bad warning threshold data
* merging my bug fixes with master branch
* fixing usage function corrupted when merged

-- File Changes --

M plugins/check_http.c (6)
M plugins/check_smtp.c (2)
M plugins/check_tcp.c (2)

-- Patch Links --

  https://github.com/nagios-plugins/nagios-plugins/pull/12.patch
  https://github.com/nagios-plugins/nagios-plugins/pull/12.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/nagios-plugins/nagios-plugins/pull/12




More information about the Devel mailing list