From notifications at github.com Wed Dec 4 09:00:47 2013 From: notifications at github.com (cailiuqing) Date: Wed, 04 Dec 2013 00:00:47 -0800 Subject: [nagios-plugins] rpmbuild for 1.5 fails (#1217) Message-ID: When I trying to build an rpm (rpmbuild -ba nagios-plugins.spec ?from nagios-plugins-1.5.tar.gz and nagios-plugins-1.5-6-g4ab4.tar.gz) I get: + build-aux/install-sh -c -d /root/rpmbuild/BUILDROOT/nagios-plugins-1.5-1.x86_64/etc/nagios + build-aux/install-sh -c -m 664 command.cfg /root/rpmbuild/BUILDROOT/nagios-plugins-1.5-1.x86_64/etc/nagios build-aux/install-sh: command.cfg does not exist. error: Bad exit status from /var/tmp/rpm-tmp.DCK0Sp (%install) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.DCK0Sp (%install) >From the errors, i know command.cfg is not be found. But, why the cfg is not exist? Where i did wrong? PS:i build nagios-4.0.2's rpm first,and rpmbuild seems ok. Thanks for each help. --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/issues/1217 -------------- next part -------------- An HTML attachment was scrubbed... URL: From robert.ennis at bbc.co.uk Wed Dec 4 13:45:07 2013 From: robert.ennis at bbc.co.uk (Robert Ennis) Date: Wed, 4 Dec 2013 12:45:07 +0000 Subject: Check_snmp fails to return OID translations when thresholds are added. Message-ID: Hi, I am using check_snmp (nagios-plugins 1.4.16) to return SNMP dta from Cisco switches. I?m using Centos 6.4, have all my MIB files included and netsnmp is happy so I can do something like: ./check-snmp ?H 1.2.3.4 -c communitystring -o RFC1213-MIB::ifOperStatus.5001 And get: SNMP OK ? up(1) | Where up is the translation of 1 from the associated MIB. Great! The problem is that as soon as I add thresholds to check_snmp this breaks. E.g. ./check-snmp ?H 1.2.3.4 -c communitystring -o RFC1213-MIB::ifOperStatus.5001 ?c 1:1 This gives me: SNMP OK ? 1 | RFC1213-MIB::ifOperStatus.5001=1 So I get the extra info as expected but loose the translation of what 1 means. Bummer! I can recreate this in Centos 6 running 1.4.13 and Ubuntu running 1.4.13 or .15. Is this change in behaviour a bug or a feature? It would be fantastic if I could return the translated values back to Nagios and I?m sure I cannot be the only person who would really appreciate this functionality. Regards, Rob Ennis ---------------------------- http://www.bbc.co.uk This e-mail (and any attachments) is confidential and may contain personal views which are not the views of the BBC unless specifically stated. If you have received it in error, please delete it from your system. Do not use, copy or disclose the information in any way nor act in reliance on it and notify the sender immediately. Please note that the BBC monitors e-mails sent or received. Further communication will signify your consent to this. --------------------- -------------- next part -------------- An HTML attachment was scrubbed... URL: From holger at zedat.fu-berlin.de Thu Dec 5 11:31:39 2013 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Thu, 5 Dec 2013 11:31:39 +0100 Subject: 64-bit issue In-Reply-To: References: Message-ID: <20131205103139.GN975920@zedat.fu-berlin.de> * L. V. Lammert [2013-11-26 15:41]: > Trying to use 64-bit Cygwin and 64-bit plugins has raised an issue,0 > however, .. the one we have found with check_load: > > $ ./check_load.exe -w "30,15,10" -c "35,30,20" > CRITICAL - You need more args!!! > Error opening > > It looks like that error is in popen.c, line 152, getting command > arguments. Does not appear to be a parsing error, as I have tried many > different combinations on argument fornatting. > > Is this related to any known problem? Nothing known to me, at least. Please feel free to submit a new issue on GitHub so that this doesn't get lost: https://github.com/nagios-plugins/nagios-plugins/issues/new Thanks, Holger From holger at zedat.fu-berlin.de Thu Dec 5 19:47:01 2013 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Thu, 5 Dec 2013 19:47:01 +0100 Subject: Check_snmp fails to return OID translations when thresholds are added. In-Reply-To: References: Message-ID: <20131205184701.GO975920@zedat.fu-berlin.de> * Robert Ennis [2013-12-04 12:45]: > I'm using Centos 6.4, have all my MIB files included and netsnmp is happy so I can do something like: > ./check-snmp -H 1.2.3.4 -c communitystring -o RFC1213-MIB::ifOperStatus.5001 > And get: > SNMP OK - up(1) | > > Where up is the translation of 1 from the associated MIB. Great! > > The problem is that as soon as I add thresholds to check_snmp this breaks. E.g. > ./check-snmp -H 1.2.3.4 -c communitystring -o RFC1213-MIB::ifOperStatus.5001 -c 1:1 > This gives me: > SNMP OK - 1 | RFC1213-MIB::ifOperStatus.5001=1 > > So I get the extra info as expected but loose the translation of what 1 means. Bummer! If you specify a string to match (instead of a 1:1 range), the output should be left alone: check-snmp [...] --string='up(1)' Maybe this will do the trick for you? Holger From KDHughes at dow.com Thu Dec 5 19:57:03 2013 From: KDHughes at dow.com (Hughes, Kerry (KD)) Date: Thu, 5 Dec 2013 18:57:03 +0000 Subject: check_http 1.5 issue with -N (no body) flag In-Reply-To: <7520F5AEE843684E9EDE5103DBE0582D7D309B@046-CH1MPN1-051.046d.mgd.msft.net> References: <7520F5AEE843684E9EDE5103DBE0582D7D2E76@046-CH1MPN1-051.046d.mgd.msft.net> <7520F5AEE843684E9EDE5103DBE0582D7D309B@046-CH1MPN1-051.046d.mgd.msft.net> Message-ID: <7520F5AEE843684E9EDE5103DBE0582D7D3123@046-CH1MPN1-051.046d.mgd.msft.net> I recently upgraded my plugins to 1.5. I had some check_http commands with the ?N flag that broke. I found switching the flag from ?N to ?no-body fixed my issue. The documentation seems to imply these are supposed to be equivalent. https://www.nagios-plugins.org/doc/man/check_http.html Is this an appropriate manner to file a bug or is there a more appropriate spot I should turn to? Old commands & results: $ check_http -V check_http v1.5 (nagios-plugins 1.5) $ check_http -H header.example.com -u /mypath -e 302 -N check_http: option requires an argument -- 'N' Usage: check_http -H | -I [-u ] [-p ] [-J ] [-K ] [-w ] [-c ] [-t ] [-L] [-E] [-a auth] [-b proxy_auth] [-f ] [-e ] [-d string] [-s string] [-l] [-r | -R ] [-P string] [-m :] [-4|-6] [-N] [-M ] [-A string] [-k string] [-S ] [--sni] [-C [,]] [-T ] [-j method] $ check_http -H this.is.my.url -u /Pages/default.aspx -N -e 401 Invalid argument HTTP CRITICAL - Unable to open TCP socket New commands and results: $ check_http -H header.example.com -u /mypath -e 302 --no-body HTTP OK: Status line output matched "302" - 653 bytes in 0.140 second response time |time=0.139759s;;;0.000000 size=653B;;;0 $ check_http -H my.url.example.com -u /Pages/default.aspx --no-body -e 401 HTTP OK: Status line output matched "401" - 353 bytes in 0.092 second response time |time=0.091702s;;;0.000000 size=353B;;;0 -------------- next part -------------- An HTML attachment was scrubbed... URL: From holger at zedat.fu-berlin.de Thu Dec 5 20:47:11 2013 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Thu, 5 Dec 2013 20:47:11 +0100 Subject: check_http 1.5 issue with -N (no body) flag In-Reply-To: <7520F5AEE843684E9EDE5103DBE0582D7D3123@046-CH1MPN1-051.046d.mgd.msft.net> References: <7520F5AEE843684E9EDE5103DBE0582D7D2E76@046-CH1MPN1-051.046d.mgd.msft.net> <7520F5AEE843684E9EDE5103DBE0582D7D309B@046-CH1MPN1-051.046d.mgd.msft.net> <7520F5AEE843684E9EDE5103DBE0582D7D3123@046-CH1MPN1-051.046d.mgd.msft.net> Message-ID: <20131205194711.GP975920@zedat.fu-berlin.de> * Hughes, Kerry (KD) [2013-12-05 18:57]: > I recently upgraded my plugins to 1.5. I had some check_http commands > with the -N flag that broke. I found switching the flag from -N to > -no-body fixed my issue. The documentation seems to imply these are > supposed to be equivalent. D'oh, indeed. This is now fixed in Git? and in the current "maint" snapshot?. Thanks for reporting the bug. > Is this an appropriate manner to file a bug or is there a more > appropriate spot I should turn to? Using the mailing list is fine, but if you report a bug in the future and get no response within a few days, you should submit an issue? on GitHub so that it doesn't get lost. Holger ? https://github.com/nagios-plugins/nagios-plugins/commit/c91ff7539 ? https://www.nagios-plugins.org/download/snapshot/nagios-plugins-maint.tar.gz ? https://github.com/nagios-plugins/nagios-plugins/issues/new From notifications at github.com Wed Dec 11 20:46:02 2013 From: notifications at github.com (Philip H) Date: Wed, 11 Dec 2013 11:46:02 -0800 Subject: [nagios-plugins] rpmbuild for 1.5 fails (#1217) In-Reply-To: References: Message-ID: Having same issue here. Looks like a bug so far. --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/issues/1217#issuecomment-30355992 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Dec 11 20:57:49 2013 From: notifications at github.com (Philip H) Date: Wed, 11 Dec 2013 11:57:49 -0800 Subject: [nagios-plugins] rpmbuild for 1.5 fails (#1217) In-Reply-To: References: Message-ID: Looks like command.cfg is not part of the distro anymore, however wasn't removed from the build. After commenting it out from the spec, i received further errors when trying to rpmbuild. RPM build errors: File not found: /home/user/rpm/BUILDROOT/nagios-plugins-1.5-1.x86_64/usr/lib/nagios/plugins/libnpcommon.a File not found: /home/user/rpm/BUILDROOT/nagios-plugins-1.5-1.x86_64/usr/lib/nagios/plugins/check_dhcp File not found: /home/user/rpm/BUILDROOT/nagios-plugins-1.5-1.x86_64/usr/lib/nagios/plugins/check_icmp --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/issues/1217#issuecomment-30357580 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Dec 11 21:26:27 2013 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Wed, 11 Dec 2013 12:26:27 -0800 Subject: [nagios-plugins] rpmbuild for 1.5 fails (#1217) In-Reply-To: References: Message-ID: Yes, the SPEC file isn't up-to-date. While I could have a go at fixing it once, I'm not too keen on maintaining the file in the future: I don't work with RPM-based systems myself (not sure whether the other developers do), and I'm not convinced it makes sense to have upstream projects maintain distribution-specific stuff anyway. So personally I'd prefer removing the file over fixing it. Any opinions? --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/issues/1217#issuecomment-30360010 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Dec 12 13:19:46 2013 From: notifications at github.com (waja) Date: Thu, 12 Dec 2013 04:19:46 -0800 Subject: [nagios-plugins] rpmbuild for 1.5 fails (#1217) In-Reply-To: References: Message-ID: I would remove it, as every distribution is throwing them away anyways (or at least modifiying). --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/issues/1217#issuecomment-30415582 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Dec 12 21:26:13 2013 From: notifications at github.com (Philip H) Date: Thu, 12 Dec 2013 12:26:13 -0800 Subject: [nagios-plugins] rpmbuild for 1.5 fails (#1217) In-Reply-To: References: Message-ID: I was able to disable the plugins-root and plugins-scripts to bypass the aforementioned errors. However, now it can't find ibnpcommon.a It appears this was added to the makefile recently so the latest commit seems to have broken the rpmbuild process. RPM build errors: File not found: /home/user/rpm/BUILDROOT/nagios-plugins-1.5-1.x86_64/usr/lib/nagios/plugins/libnpcommon.a --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/issues/1217#issuecomment-30458458 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Dec 16 13:44:36 2013 From: notifications at github.com (Alexander Wittig) Date: Mon, 16 Dec 2013 04:44:36 -0800 Subject: [nagios-plugins] Add support for drill tool to check_dig (#1218) Message-ID: FreeBSD starting with version 10 is shipped with ldns instead of bind as resolver. Consequently the dig tool in base is replaced by drill. While dig can still be installed as a third party application, it would be nice to make do with the tools available in the system already. This patch rearranges the command line used to invoke dig slightly so that it can be used with both dig and drill (tested with dig 9.8.3-P1 and 9.9.4 as well as drill 1.6.16). It would be really neat if the configure script could be changed to automatically pick up drill when dig is not available (or the other way around), but my autotools-foo is not good enough for that. This part of the patch is an extended version of the locally maintained patch currently deployed in the FreeBSD ports tree by Dmitry Sivachenko. Unrelated, to this, the default DNS server, if not specified, now takes into account the -4 and -6 switches (i.e. if -6 is given ::1 is used instead of 127.0.0.1). You can merge this Pull Request by running: git pull https://github.com/abgandar/nagios-plugins master Or you can view, comment on it, or merge it online at: https://github.com/nagios-plugins/nagios-plugins/pull/1218 -- Commit Summary -- * Update check_dig.c * Update check_dig.c -- File Changes -- M plugins/check_dig.c (9) -- Patch Links -- https://github.com/nagios-plugins/nagios-plugins/pull/1218.patch https://github.com/nagios-plugins/nagios-plugins/pull/1218.diff -------------- next part -------------- An HTML attachment was scrubbed... URL: From eponymousalias at yahoo.com Mon Dec 16 17:07:10 2013 From: eponymousalias at yahoo.com (eponymous alias) Date: Mon, 16 Dec 2013 08:07:10 -0800 (PST) Subject: check_disk perfdata as percentages Message-ID: <1387210030.87666.YahooMailBasic@web121105.mail.ne1.yahoo.com> The check_disk plugin has a lot of flexibility in how it presents its results, but in one particular way it is rigid. And that is, it always prints the perfdata in absolute space units. It's true that this provides all the data needed, but in some situations it would be more convenient if the perfdata space measurements were presented as percentages. I would like to modify the check_disk plugin to provide this capability. My first thought was to provide a "-u %" option. But that would also disturb the readable message output: % ./check_disk -w 20% -c 10% -p / DISK WARNING - free space: / 1425 MB (13% inode=75%);| /=9299MB;8666;9749;0;10833 There we see that the space is listed in the message as an absolute value in MB (reasonable in that context), and imposing a "-u %" option would necessarily default the "MB" measurement for that absolute value, by disallowing other -u settings. So I propose instead to support a -P (--percentage-perfdata) option, with no arguments, to convert the perfdata (only) to all percentage values: % ./check_disk -w 20% -c 10% -p / -P DISK WARNING - free space: / 1425 MB (13% inode=75%);| /=86%;80;90;0;100 Does this seem to folks here like a reasonable design? If so, I'll make the code changes, test, and contribute them back here. From notifications at github.com Tue Dec 17 03:20:30 2013 From: notifications at github.com (Damian Myerscough) Date: Mon, 16 Dec 2013 18:20:30 -0800 Subject: [nagios-plugins] Fix #1217 spec file fails to build due to duplicate files and unused files (#1219) Message-ID: Allow a successful build of the rpm SPEC file. The patch removes duplicate entries, unused file use during compilation and adds check_ldaps You can merge this Pull Request by running: git pull https://github.com/dmyerscough/nagios-plugins maint Or you can view, comment on it, or merge it online at: https://github.com/nagios-plugins/nagios-plugins/pull/1219 -- Commit Summary -- * Fix #1217 spec file fails to build due to duplicate files and unused files -- File Changes -- M nagios-plugins.spec.in (6) -- Patch Links -- https://github.com/nagios-plugins/nagios-plugins/pull/1219.patch https://github.com/nagios-plugins/nagios-plugins/pull/1219.diff -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Dec 17 03:21:19 2013 From: notifications at github.com (Damian Myerscough) Date: Mon, 16 Dec 2013 18:21:19 -0800 Subject: [nagios-plugins] rpmbuild for 1.5 fails (#1217) In-Reply-To: References: Message-ID: I have submitted a request to fix this isse: https://github.com/nagios-plugins/nagios-plugins/pull/1219 --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/issues/1217#issuecomment-30721077 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Dec 17 03:24:51 2013 From: notifications at github.com (Damian Myerscough) Date: Mon, 16 Dec 2013 18:24:51 -0800 Subject: [nagios-plugins] Fix #1217 spec file fails to build due to duplicate files and unused files (#1219) In-Reply-To: References: Message-ID: @weiss please could you merge this request? --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/pull/1219#issuecomment-30721242 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Dec 17 03:44:02 2013 From: notifications at github.com (Stephane Lapie) Date: Mon, 16 Dec 2013 18:44:02 -0800 Subject: [nagios-plugins] Handle negative values properly with check_snmp (#1215) In-Reply-To: References: Message-ID: Sorry, I was just wondering if anyone else had the problem and whether this could be fixed. We are currently dealing with this problem internally with custom packages, but this is not sustainable for long term. --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/pull/1215#issuecomment-30722021 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Dec 17 14:59:02 2013 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Tue, 17 Dec 2013 05:59:02 -0800 Subject: [nagios-plugins] Fix #1217 spec file fails to build due to duplicate files and unused files (#1219) In-Reply-To: References: Message-ID: As [we](https://github.com/nagios-plugins/nagios-plugins/issues/1217#issuecomment-30415582) [mentioned](https://github.com/nagios-plugins/nagios-plugins/issues/1217#issuecomment-30360010) in #1217, we'd rather remove the SPEC file altogether. Could you explain why it's useful to you? Won't the one maintained by your distribution (e.g. the one from [Fedora](http://pkgs.fedoraproject.org/cgit/nagios-plugins.git/tree/nagios-plugins.spec)) do the trick? Or the one from [RepoForge](https://github.com/repoforge/rpms/blob/master/specs/nagios-plugins/nagios-plugins.spec)? --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/pull/1219#issuecomment-30752467 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Dec 17 16:57:40 2013 From: notifications at github.com (Damian Myerscough) Date: Tue, 17 Dec 2013 07:57:40 -0800 Subject: [nagios-plugins] Fix #1217 spec file fails to build due to duplicate files and unused files (#1219) In-Reply-To: References: Message-ID: Fedora and RepoForge don't have the latest version and quite a few people like to build the RPM files themselves. I like how the SPEC file is available in the source, it's convenient. --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/pull/1219#issuecomment-30762851 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Dec 17 18:37:00 2013 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Tue, 17 Dec 2013 09:37:00 -0800 Subject: [nagios-plugins] Fix #1217 spec file fails to build due to duplicate files and unused files (#1219) In-Reply-To: References: Message-ID: [The one from Fedora](http://pkgs.fedoraproject.org/cgit/nagios-plugins.git/tree/nagios-plugins.spec) is for building version 1.5 of the Plugins. And the RepoForge guys would probably be happier to accept a patch that updates their SPEC file than we are. I just think the repositories of upstream projects are not the best place for maintaining distribution-specific things. I for one cannot maintain the SPEC file properly, as I'm not an RPM user. The same is true for the [Solaris package build script](https://github.com/nagios-plugins/nagios-plugins/tree/maint/pkg/solaris). And I'm not keen on explaining users of arbitrary foo distributions why I don't want to also add their packaging stuff ... --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/pull/1219#issuecomment-30772324 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Dec 17 21:33:51 2013 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Tue, 17 Dec 2013 12:33:51 -0800 Subject: [nagios-plugins] rpmbuild for 1.5 fails (#1217) In-Reply-To: References: Message-ID: Closed #1217 via aaee2c06329a9afac9f5e9d626957fe258615fa8. --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/issues/1217 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Dec 17 21:36:05 2013 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Tue, 17 Dec 2013 12:36:05 -0800 Subject: [nagios-plugins] Fix #1217 spec file fails to build due to duplicate files and unused files (#1219) In-Reply-To: References: Message-ID: I've applied your commit for the moment, but will probably suggest removing the SPEC file on the mailing list. Thanks. --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/pull/1219#issuecomment-30788308 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Dec 17 21:36:05 2013 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Tue, 17 Dec 2013 12:36:05 -0800 Subject: [nagios-plugins] Fix #1217 spec file fails to build due to duplicate files and unused files (#1219) In-Reply-To: References: Message-ID: Closed #1219. --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/pull/1219 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Dec 17 21:56:09 2013 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Tue, 17 Dec 2013 12:56:09 -0800 Subject: [nagios-plugins] Fix misleading timeout help (#1209) In-Reply-To: References: Message-ID: The problem is that different plugins use the timeout value in different ways. `check_http` resets the timeout for each connection on HTTP redirects, `check_snmp` uses it as the timeout between retries, and so on. An easy way out might be to replace the `--help` text with something generic, such as "Timeout in seconds". --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/pull/1209#issuecomment-30790031 -------------- next part -------------- An HTML attachment was scrubbed... URL: From holger at zedat.fu-berlin.de Tue Dec 17 22:24:51 2013 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Tue, 17 Dec 2013 22:24:51 +0100 Subject: check_disk perfdata as percentages In-Reply-To: <1387210030.87666.YahooMailBasic@web121105.mail.ne1.yahoo.com> References: <1387210030.87666.YahooMailBasic@web121105.mail.ne1.yahoo.com> Message-ID: <20131217212451.GA510561@zedat.fu-berlin.de> * eponymous alias [2013-12-16 08:07]: > % ./check_disk -w 20% -c 10% -p / > DISK WARNING - free space: / 1425 MB (13% inode=75%);| /=9299MB;8666;9749;0;10833 > > There we see that the space is listed in the message as an absolute > value in MB (reasonable in that context), and imposing a "-u %" > option would necessarily default the "MB" measurement for that > absolute value, by disallowing other -u settings. > > So I propose instead to support a -P (--percentage-perfdata) > option, with no arguments, to convert the perfdata (only) to all > percentage values: > > % ./check_disk -w 20% -c 10% -p / -P > DISK WARNING - free space: / 1425 MB (13% inode=75%);| /=86%;80;90;0;100 > > Does this seem to folks here like a reasonable design? Sounds good to me. > If so, I'll make the code changes, test, and contribute them back here. Thanks! (A pull request on GitHub would be preferred.) Holger From notifications at github.com Tue Dec 17 23:48:55 2013 From: notifications at github.com (awiddersheim) Date: Tue, 17 Dec 2013 14:48:55 -0800 Subject: [nagios-plugins] Fix misleading timeout help (#1209) In-Reply-To: References: Message-ID: I was trying to make the wording generic but I didn't realize it's varying use in the many plugins. I had thought every plugin used the timeouts in the same way where SIGALRM would come to stop it from what it was doing. Obviously, I was wrong. I'm fine with your suggestion since it was what I was going for in the first place. --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/pull/1209#issuecomment-30799687 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Dec 20 16:16:39 2013 From: notifications at github.com (Joe Gooch) Date: Fri, 20 Dec 2013 07:16:39 -0800 Subject: [nagios-plugins] Fix for SSL Versioning when multiple options are used. (#1220) Message-ID: If you specify -S1 -C 30... The -C option will reset the ssl_version to 0. This is not a good thing. Instead we set the default to 0 and retain the version when later args are passed. You can merge this Pull Request by running: git pull https://github.com/goochjj/nagios-plugins master Or you can view, comment on it, or merge it online at: https://github.com/nagios-plugins/nagios-plugins/pull/1220 -- Commit Summary -- * Fix for SSL Versioning when multiple options are used. -- File Changes -- M plugins/check_http.c (8) -- Patch Links -- https://github.com/nagios-plugins/nagios-plugins/pull/1220.patch https://github.com/nagios-plugins/nagios-plugins/pull/1220.diff -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Dec 20 16:25:04 2013 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Fri, 20 Dec 2013 07:25:04 -0800 Subject: [nagios-plugins] Fix for SSL Versioning when multiple options are used. (#1220) In-Reply-To: References: Message-ID: The patch won't compile, due to a missing brace. Could you fix that? Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/pull/1220#issuecomment-31016786 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Dec 20 17:27:41 2013 From: notifications at github.com (Joe Gooch) Date: Fri, 20 Dec 2013 08:27:41 -0800 Subject: [nagios-plugins] Fix for SSL Versioning when multiple options are used. (#1220) In-Reply-To: References: Message-ID: Fixed + amended. Sorry, hadn't worked through my other patches yet to run a compile. --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/pull/1220#issuecomment-31021682 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Dec 20 17:43:33 2013 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Fri, 20 Dec 2013 08:43:33 -0800 Subject: [nagios-plugins] Fix for SSL Versioning when multiple options are used. (#1220) In-Reply-To: References: Message-ID: Closed #1220 via 3887bb31f9a1ca343cbca47cd3e35ad7b48fc995. --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/pull/1220 -------------- next part -------------- An HTML attachment was scrubbed... URL: From pacetownsley at gmail.com Mon Dec 23 20:30:51 2013 From: pacetownsley at gmail.com (J Adams) Date: Mon, 23 Dec 2013 14:30:51 -0500 Subject: check_http alerting on time to first byte Message-ID: There are a few contexts where it would be nice to alert on time to first byte instead of elapsed request time. check_http measures ttfb but I can't send an alert on it. The attached patch adds a switch that causes -w and -c to act on time to first byte. -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: check_http.ttfb_alert.patch Type: application/octet-stream Size: 4937 bytes Desc: not available URL: From notifications at github.com Thu Dec 26 20:26:33 2013 From: notifications at github.com (jcnengel) Date: Thu, 26 Dec 2013 11:26:33 -0800 Subject: [nagios-plugins] Introduce support for SNMPv3 context in check_snmp (#1221) Message-ID: snmpget already supports using SNMPv3 contexts using the option "-n". Thus all we need to do is introduce a new argument to check_snmp and pass the argument on to snmpget using snmpget's option "-n". Since "-n" is already in use for check_snmp for a different purpose, we use "-N" instead. You can merge this Pull Request by running: git pull https://github.com/jcnengel/nagios-plugins maint Or you can view, comment on it, or merge it online at: https://github.com/nagios-plugins/nagios-plugins/pull/1221 -- Commit Summary -- * Introduce support for SNMPv3 context in check_snmp -- File Changes -- M plugins/check_snmp.c (42) -- Patch Links -- https://github.com/nagios-plugins/nagios-plugins/pull/1221.patch https://github.com/nagios-plugins/nagios-plugins/pull/1221.diff -------------- next part -------------- An HTML attachment was scrubbed... URL: