From noreply at sourceforge.net Thu Jan 3 20:50:59 2013 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 03 Jan 2013 11:50:59 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-2859548 ] check_by_ssh exit status when reaching timeout Message-ID: Bugs item #2859548, was opened at 2009-09-15 13:30 Message generated for change (Comment added) made by archiecobbs You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2859548&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Guillaume Rousse (guillomovitch) Assigned to: Nobody/Anonymous (nobody) Summary: check_by_ssh exit status when reaching timeout Initial Comment: check_by_ssh currently exist with CRITICAL status when reaching timeout. When used just as a transport mechanism for invoking a remote plugin, it should rather exit with UNKNOWN status in this case. The patch is trivial, I'd be happy to contribute it if this is agreed. ---------------------------------------------------------------------- Comment By: Archie Cobbs (archiecobbs) Date: 2013-01-03 11:50 Message: FYI, There is an easy workaround: you can achieve the same effect by adding the -oConnectTimeout=XX flag where XX is slightly less than the timeout set with the -t flag. ---------------------------------------------------------------------- Comment By: Guillaume Rousse (guillomovitch) Date: 2009-09-28 02:11 Message: I just noticed check_nrpe has -u switch for this very purpose. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=2859548&group_id=29880 From noreply at sourceforge.net Wed Jan 9 18:38:53 2013 From: noreply at sourceforge.net (SourceForge.net) Date: Wed, 09 Jan 2013 09:38:53 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-3600122 ] Old version of gnulib assumes gets is defined Message-ID: Bugs item #3600122, was opened at 2013-01-09 09:38 Message generated for change (Tracker Item Submitted) made by You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3600122&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Compilation Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: racb () Assigned to: Nobody/Anonymous (nobody) Summary: Old version of gnulib assumes gets is defined Initial Comment: The next release of Ubuntu will use eglibc 2.16, which drops the definition of gets (following ISO C11). The embedded gnulib assumes that gets is defined, and thus causes a build failure in the current development release of Ubuntu. Upstream gnulib has followed this change in http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=66712c23388e93e5c518ebc8515140fa0c807348 Workaround is to disable the warning in gl/stdio.in.h. Please update gnulib to allow nagios-plugins to compile in environments where gets is not defined. Ubuntu bug: https://launchpad.net/bugs/1097848 Thanks! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3600122&group_id=29880 From noreply at sourceforge.net Wed Jan 9 19:57:16 2013 From: noreply at sourceforge.net (SourceForge.net) Date: Wed, 09 Jan 2013 10:57:16 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-3600122 ] Old version of gnulib assumes gets is defined Message-ID: Bugs item #3600122, was opened at 2013-01-09 09:38 Message generated for change (Comment added) made by hweiss You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3600122&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Compilation Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: racb () >Assigned to: Holger Weiss (hweiss) Summary: Old version of gnulib assumes gets is defined Initial Comment: The next release of Ubuntu will use eglibc 2.16, which drops the definition of gets (following ISO C11). The embedded gnulib assumes that gets is defined, and thus causes a build failure in the current development release of Ubuntu. Upstream gnulib has followed this change in http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=66712c23388e93e5c518ebc8515140fa0c807348 Workaround is to disable the warning in gl/stdio.in.h. Please update gnulib to allow nagios-plugins to compile in environments where gets is not defined. Ubuntu bug: https://launchpad.net/bugs/1097848 Thanks! ---------------------------------------------------------------------- >Comment By: Holger Weiss (hweiss) Date: 2013-01-09 10:57 Message: Yes, we're aware of that issue and will update Gnulib before the next release. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3600122&group_id=29880 From noreply at sourceforge.net Fri Jan 11 17:35:14 2013 From: noreply at sourceforge.net (SourceForge.net) Date: Fri, 11 Jan 2013 08:35:14 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-3600414 ] check_mem.pl incorrectly reads parameters from vmstat Message-ID: Bugs item #3600414, was opened at 2013-01-11 08:35 Message generated for change (Tracker Item Submitted) made by lehtinen You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3600414&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Lassi Lehtinen (lehtinen) Assigned to: Nobody/Anonymous (nobody) Summary: check_mem.pl incorrectly reads parameters from vmstat Initial Comment: Seems like the check_mem.pl script incorrectly reads the parameters from vmstat on Linux-host: [root at machine ~]# /usr/lib64/nagios/plugins/contrib/check_mem.pl -f -w 40 -c 20 Memory CRITICAL - 16.9% (74588 kB) free [root at machine ~]# vmstat procs -----------memory---------- ---swap-- -----io---- --system-- -----cpu----- r b swpd free buff cache si so bi bo in cs us sy id wa st 1 0 0 366640 74604 9415164 0 0 5856 3863 1 5 0 2 98 0 0 Problems seems to be here: # This the unix command string that brings Perl the data $command_line = `vmstat | tail -1 | awk '{print \$4,\$5}'`; chomp $command_line; @memlist = split(/ /, $command_line); # Define the calculating scalars $used_memory = $memlist[0]; $free_memory = $memlist[1]; $total_memory = $used_memory + $free_memory; Executing $command_line first prints amount of free-memory and then amount of buffered-memory, but these are put to variables so that $used_memory has the amount of free memory, and $free_memory the amount of buffered memory. So the script actually reports inveresly free/used memory. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3600414&group_id=29880 From noreply at sourceforge.net Tue Jan 15 20:28:25 2013 From: noreply at sourceforge.net (SourceForge.net) Date: Tue, 15 Jan 2013 11:28:25 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Feature Requests-3601012 ] check_nt "Network is unreachable" handling Message-ID: Feature Requests item #3601012, was opened at 2013-01-15 11:28 Message generated for change (Tracker Item Submitted) made by rfults You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=3601012&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Priority: 5 Private: No Submitted By: Bob the IT Guy (rfults) Assigned to: Nobody/Anonymous (nobody) Summary: check_nt "Network is unreachable" handling Initial Comment: It would be nice to have the option to either ignore "network is unreachable" errors or control the status they return. I am running my checks over very low bandwidth satellite links and have frequent disconnects, when this error is returned it can generate thousands of emails which has made the notification system useless for me. I only send critical, warning, and recovery emails for my services and hosts as it is, but this feature would help to reduce false positives in these situations where we have bad connections. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397600&aid=3601012&group_id=29880 From robin.sonefors at op5.com Wed Jan 23 19:10:54 2013 From: robin.sonefors at op5.com (Robin Sonefors) Date: Wed, 23 Jan 2013 19:10:54 +0100 Subject: [Nagiosplug-devel] Segfault in check_snmp Message-ID: <1358964655-20819-1-git-send-email-robin.sonefors@op5.com> Hello list, I hope this is the right way to submit a patch here. I've fixed a problem with memory allocation in check_snmp that caused crashes when using too many oid or label parameters. Please see the patch in the next mail. From robin.sonefors at op5.com Wed Jan 23 19:10:55 2013 From: robin.sonefors at op5.com (Robin Sonefors) Date: Wed, 23 Jan 2013 19:10:55 +0100 Subject: [Nagiosplug-devel] [PATCH] check_snmp: Don't thrash memory when using multiple label/unit argument In-Reply-To: <1358964655-20819-1-git-send-email-robin.sonefors@op5.com> References: <1358964655-20819-1-git-send-email-robin.sonefors@op5.com> Message-ID: <1358964655-20819-2-git-send-email-robin.sonefors@op5.com> The memory allocation mixed up number of bytes with number of pointers, meaning as soon as we'd reach (on 64 bit systems) the second argument, we'd start writing it outside of our allocated memory. Normally, this isn't too visible, but as soon as you (again, on my 64 bit system) reach argument number 8, you get a segfault. It is easily reproducible with: check_snmp -o '' -l '' -o '' -l '' -o '' -l '' -o '' -l '' \ -o '' -l '' -o '' -l '' -o '' -l '' -o '' -l '' This patch allocates the proper amount of memory, to fix the issue. Signed-off-by: Robin Sonefors --- plugins/check_snmp.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/plugins/check_snmp.c b/plugins/check_snmp.c index 8a8ee18..7c5d0ec 100644 --- a/plugins/check_snmp.c +++ b/plugins/check_snmp.c @@ -200,8 +200,8 @@ main (int argc, char **argv) bindtextdomain (PACKAGE, LOCALEDIR); textdomain (PACKAGE); - labels = malloc (labels_size); - unitv = malloc (unitv_size); + labels = malloc (labels_size * sizeof(*labels)); + unitv = malloc (unitv_size * sizeof(*unitv)); for (i = 0; i < MAX_OIDS; i++) eval_method[i] = CHECK_UNDEF; @@ -768,9 +768,9 @@ process_arguments (int argc, char **argv) break; case 'l': /* label */ nlabels++; - if (nlabels >= labels_size) { + if (nlabels > labels_size) { labels_size += 8; - labels = realloc (labels, labels_size); + labels = realloc (labels, labels_size * sizeof(*labels)); if (labels == NULL) die (STATE_UNKNOWN, _("Could not reallocate labels[%d]"), (int)nlabels); } @@ -780,13 +780,13 @@ process_arguments (int argc, char **argv) if (ptr[0] == '\'') labels[nlabels - 1] = ptr + 1; while (ptr && (ptr = nextarg (ptr))) { - if (nlabels >= labels_size) { + nlabels++; + if (nlabels > labels_size) { labels_size += 8; - labels = realloc (labels, labels_size); + labels = realloc (labels, labels_size * sizeof(*labels)); if (labels == NULL) die (STATE_UNKNOWN, _("Could not reallocate labels\n")); } - nlabels++; ptr = thisarg (ptr); if (ptr[0] == '\'') labels[nlabels - 1] = ptr + 1; @@ -797,9 +797,9 @@ process_arguments (int argc, char **argv) case 'u': /* units */ units = optarg; nunits++; - if (nunits >= unitv_size) { + if (nunits > unitv_size) { unitv_size += 8; - unitv = realloc (unitv, unitv_size); + unitv = realloc (unitv, unitv_size * sizeof(*unitv)); if (unitv == NULL) die (STATE_UNKNOWN, _("Could not reallocate units [%d]\n"), (int)nunits); } @@ -809,9 +809,9 @@ process_arguments (int argc, char **argv) if (ptr[0] == '\'') unitv[nunits - 1] = ptr + 1; while (ptr && (ptr = nextarg (ptr))) { - if (nunits >= unitv_size) { + if (nunits > unitv_size) { unitv_size += 8; - unitv = realloc (unitv, unitv_size); + unitv = realloc (unitv, unitv_size * sizeof(*unitv)); if (units == NULL) die (STATE_UNKNOWN, _("Could not realloc() units\n")); } -- 1.7.11.7 From Sven.Nierlein at consol.de Wed Jan 23 20:01:24 2013 From: Sven.Nierlein at consol.de (Sven Nierlein) Date: Wed, 23 Jan 2013 20:01:24 +0100 Subject: [Nagiosplug-devel] [PATCH] check_snmp: Don't thrash memory when using multiple label/unit argument In-Reply-To: <1358964655-20819-2-git-send-email-robin.sonefors@op5.com> References: <1358964655-20819-1-git-send-email-robin.sonefors@op5.com> <1358964655-20819-2-git-send-email-robin.sonefors@op5.com> Message-ID: <51003384.4020804@consol.de> Hi Robin, thanks for your patch. Sending a mail is totally fine, even better would be a pull request here: https://github.com/nagios-plugins/nagios-plugins It would also be cool to keep the whitespace settings like they are, i don't like tabs too, but if the rest of the file uses tabs, i try to keep it like that. Thank you very much, Sven -- Sven Nierlein Sven.Nierlein at consol.de ConSol* GmbH http://www.consol.de Franziskanerstrasse 38 Tel.:089/45841-439 81669 Muenchen Fax.:089/45841-111 From robin.sonefors at op5.com Thu Jan 24 08:52:06 2013 From: robin.sonefors at op5.com (Robin Sonefors) Date: Thu, 24 Jan 2013 08:52:06 +0100 Subject: [Nagiosplug-devel] [PATCH] check_snmp: Don't thrash memory when using multiple label/unit argument In-Reply-To: <51003384.4020804@consol.de> References: <1358964655-20819-1-git-send-email-robin.sonefors@op5.com> <1358964655-20819-2-git-send-email-robin.sonefors@op5.com> <51003384.4020804@consol.de> Message-ID: <5100E826.5020504@op5.com> On 2013-01-23 20:01, Sven Nierlein wrote: > Hi Robin, > > thanks for your patch. Sending a mail is totally fine, even better would > be a pull request here: https://github.com/nagios-plugins/nagios-plugins > > It would also be cool to keep the whitespace settings like they are, i don't like > tabs too, but if the rest of the file uses tabs, i try to keep it like that. I... did use tabs. Oh well, I'll re-submit it on github instead. Stay Tuned! From robin.sonefors at op5.com Thu Jan 24 09:02:21 2013 From: robin.sonefors at op5.com (Robin Sonefors) Date: Thu, 24 Jan 2013 09:02:21 +0100 Subject: [Nagiosplug-devel] [PATCH] check_snmp: Don't thrash memory when using multiple label/unit argument In-Reply-To: <5100E826.5020504@op5.com> References: <1358964655-20819-1-git-send-email-robin.sonefors@op5.com> <1358964655-20819-2-git-send-email-robin.sonefors@op5.com> <51003384.4020804@consol.de> <5100E826.5020504@op5.com> Message-ID: <5100EA8D.7030902@op5.com> On 2013-01-24 08:52, Robin Sonefors wrote: > On 2013-01-23 20:01, Sven Nierlein wrote: >> Hi Robin, >> >> thanks for your patch. Sending a mail is totally fine, even better would >> be a pull request here: https://github.com/nagios-plugins/nagios-plugins >> >> It would also be cool to keep the whitespace settings like they are, i >> don't like >> tabs too, but if the rest of the file uses tabs, i try to keep it like >> that. > > I... did use tabs. > > Oh well, I'll re-submit it on github instead. Stay Tuned! No, you already applied it. Thanks! I'll be quiet now. From Sven.Nierlein at consol.de Thu Jan 24 09:22:43 2013 From: Sven.Nierlein at consol.de (Sven Nierlein) Date: Thu, 24 Jan 2013 09:22:43 +0100 Subject: [Nagiosplug-devel] [PATCH] check_snmp: Don't thrash memory when using multiple label/unit argument In-Reply-To: <5100E826.5020504@op5.com> References: <1358964655-20819-1-git-send-email-robin.sonefors@op5.com> <1358964655-20819-2-git-send-email-robin.sonefors@op5.com> <51003384.4020804@consol.de> <5100E826.5020504@op5.com> Message-ID: <5100EF53.9050305@consol.de> On 1/24/13 8:52, Robin Sonefors wrote: > I... did use tabs. Then they got lost in the mail somehow :-) And yes, i already applied it. Thanks. -- Sven Nierlein Sven.Nierlein at consol.de ConSol* GmbH http://www.consol.de Franziskanerstrasse 38 Tel.:089/45841-439 81669 Muenchen Fax.:089/45841-111 From noreply at sourceforge.net Thu Jan 24 09:29:09 2013 From: noreply at sourceforge.net (SourceForge.net) Date: Thu, 24 Jan 2013 00:29:09 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Patches-3269273 ] MySQL Requirements & Comments patch Message-ID: Patches item #3269273, was opened at 2011-04-02 04:57 Message generated for change (Comment added) made by svennierlein You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=3269273&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: None >Group: None >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: https://www.google.com/accounts () Assigned to: Nobody/Anonymous (nobody) Summary: MySQL Requirements & Comments patch Initial Comment: The attached patch will: - REQUIREMENTS: Update MySQL info (old URL doesn't work anymore) - plugins/check_mysql.c: Add more comments ---------------------------------------------------------------------- >Comment By: sni (svennierlein) Date: 2013-01-24 00:29 Message: Has been applied with https://github.com/nagios-plugins/nagios-plugins/pull/34 Thank you very much ---------------------------------------------------------------------- Comment By: sni (svennierlein) Date: 2013-01-24 00:29 Message: This problem is now fixed in Git. Thank you for your report. ---------------------------------------------------------------------- Comment By: Dani?l van Eeden (compukid128) Date: 2011-04-02 05:04 Message: Please email nagiosdev at myname.nl if there are any questions. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397599&aid=3269273&group_id=29880 From manu at netbsd.org Fri Jan 25 14:00:02 2013 From: manu at netbsd.org (Emmanuel Dreyfus) Date: Fri, 25 Jan 2013 14:00:02 +0100 Subject: [Nagiosplug-devel] [PATCH] NetBSD support for check_ide_smart Message-ID: <1kx9ash.mroe6u1aqxuevM%manu@netbsd.org> Hi Below are patches to get check_ide_smart working on NetBSD. Could it be checked in? http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/net/nagios-plugins/patches/patch-configure.in?rev=1.1 http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/net/nagios-plugins/patches/patch-plugins_check_ide_smart.c?rev=1.1 -- Emmanuel Dreyfus http://hcpnet.free.fr/pubz manu at netbsd.org From holger at CIS.FU-Berlin.DE Fri Jan 25 14:07:01 2013 From: holger at CIS.FU-Berlin.DE (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Fri, 25 Jan 2013 14:07:01 +0100 Subject: [Nagiosplug-devel] [PATCH] NetBSD support for check_ide_smart In-Reply-To: <1kx9ash.mroe6u1aqxuevM%manu@netbsd.org> References: <1kx9ash.mroe6u1aqxuevM%manu@netbsd.org> Message-ID: <20130125130701.GC56756013@CIS.FU-Berlin.DE> * Emmanuel Dreyfus [2013-01-25 14:00]: > Below are patches to get check_ide_smart working on NetBSD. > Could it be checked in? I had seen your other email regarding this patch? and added it to my TODO list. If you're worried a patch might get lost, it would be better to create a pull request on Github.? But we'll look into this one before the next release. Thanks, Holger ? Message-ID: <1kvp714.1puwc4611qdspwM%manu at netbsd.org> ? https://github.com/nagios-plugins/nagios-plugins From noreply at sourceforge.net Tue Jan 29 10:32:43 2013 From: noreply at sourceforge.net (SourceForge.net) Date: Tue, 29 Jan 2013 01:32:43 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-3602488 ] check_snmp can't do IPv6 Message-ID: Bugs item #3602488, was opened at 2013-01-29 01:32 Message generated for change (Tracker Item Submitted) made by seegras You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3602488&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: General plugin execution Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Seegras (seegras) Assigned to: Nobody/Anonymous (nobody) Summary: check_snmp can't do IPv6 Initial Comment: root at monitor1:/usr/src/nagiosplug/plugins# ./check_snmp --version check_snmp v1.4.16.72.gf4bbd (nagios-plugins 1.4.16) root at monitor1:/usr/src/nagiosplug/plugins# ./check_snmp -H 'ipv6.hostname.example' -C 'public' -o '.1.3.6.1.2.1.25.1.1.0' External command error: getaddrinfo: ipv6.hostname.example Name or service not known Neither can 1.4.14. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3602488&group_id=29880 From noreply at sourceforge.net Tue Jan 29 23:27:21 2013 From: noreply at sourceforge.net (SourceForge.net) Date: Tue, 29 Jan 2013 14:27:21 -0800 Subject: [Nagiosplug-devel] [ nagiosplug-Bugs-3602586 ] check_nagios has hard coded timeout Message-ID: Bugs item #3602586, was opened at 2013-01-29 14:27 Message generated for change (Tracker Item Submitted) made by dubuc You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3602586&group_id=29880 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Argument proccessing Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Paul M. Dubuc (dubuc) Assigned to: Nobody/Anonymous (nobody) Summary: check_nagios has hard coded timeout Initial Comment: The check_nagios plugin in release 1.4.16 has a hard coded timeout of 10 seconds. Could a -t option be added to override this default? On my our load testing system, I could use a longer timeout for this plugin. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3602586&group_id=29880