From notifications at github.com Thu Apr 3 08:05:21 2014 From: notifications at github.com (Sam Kottler) Date: Wed, 02 Apr 2014 23:05:21 -0700 Subject: Remove the suggestion to run check_apt with --verbose since it doesn't d... (#1252) Message-ID: ...o anything I'm tempted to remove --verbose as a flag for `check_apt` altogether since it doesn't do anything, but this at least removes the user-facing bits. You can merge this Pull Request by running: git pull https://github.com/skottler/monitoring-plugins check_apt_verbose Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1252 -- Commit Summary -- * Remove the suggestion to run check_apt with --verbose since it doesn't do anything -- File Changes -- M plugins/check_apt.c (2) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1252.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1252.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1252 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Apr 3 15:42:45 2014 From: notifications at github.com (Sam Kottler) Date: Thu, 03 Apr 2014 06:42:45 -0700 Subject: Add commandline -T switch to check_time and check_ntp_time (#1246) In-Reply-To: References: Message-ID: Hey @langemeijer, any update on this? -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1246#issuecomment-39452036 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Apr 3 19:42:22 2014 From: notifications at github.com (Sam Kottler) Date: Thu, 03 Apr 2014 10:42:22 -0700 Subject: Fix check_mysql.c client options from file (#1199) In-Reply-To: References: Message-ID: Committed in 70314c62fc2d5829662959e528d1b314b7. Thanks! -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1199#issuecomment-39481577 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Apr 3 19:42:21 2014 From: notifications at github.com (Sam Kottler) Date: Thu, 03 Apr 2014 10:42:21 -0700 Subject: Fix check_mysql.c client options from file (#1199) In-Reply-To: References: Message-ID: Closed #1199. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1199 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Apr 4 08:32:31 2014 From: notifications at github.com (Sam Kottler) Date: Thu, 03 Apr 2014 23:32:31 -0700 Subject: check_ntp_time: adding offset option (#1184) In-Reply-To: References: Message-ID: Only one of the commits in this PR successfully apply against master right now. This second one (https://github.com/nagios-plugins/nagios-plugins/commit/028cd0742548499927603097feef34f77568c09e) is going to need significant changes to make it mergeable. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1184#issuecomment-39535564 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Apr 4 08:47:42 2014 From: notifications at github.com (Sam Kottler) Date: Thu, 03 Apr 2014 23:47:42 -0700 Subject: check_nt: add UPTIME to perfdata [sf#3434647] (#1177) In-Reply-To: References: Message-ID: Merged as-is with a minor change in a271ad24f4e7ef5c5ef8d3ca208e7a3b66a37cda. It'd be nice to pull in the changes made nagios-plugins from here: https://github.com/nagios-plugins/nagios-plugins/commit/714e77764b42ad2ba7713e5648cc440e2fedbc98. What do you think @waja? -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1177#issuecomment-39536307 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Apr 4 08:47:59 2014 From: notifications at github.com (Sam Kottler) Date: Thu, 03 Apr 2014 23:47:59 -0700 Subject: check_nt: add UPTIME to perfdata [sf#3434647] (#1177) In-Reply-To: References: Message-ID: Closed #1177. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1177 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Apr 4 09:04:06 2014 From: notifications at github.com (Sam Kottler) Date: Fri, 04 Apr 2014 00:04:06 -0700 Subject: Added perfdata to check_nt. New -l options - seconds|minutes|hours|days. (#1253) Message-ID: You can merge this Pull Request by running: git pull https://github.com/skottler/monitoring-plugins precision_perfdata Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1253 -- Commit Summary -- * Added perfdata to check_nt. New -l options - seconds|minutes|hours|days. -- File Changes -- M plugins/check_nt.c (53) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1253.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1253.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1253 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Apr 4 10:41:22 2014 From: notifications at github.com (waja) Date: Fri, 04 Apr 2014 01:41:22 -0700 Subject: check_nt: add UPTIME to perfdata [sf#3434647] (#1177) In-Reply-To: References: Message-ID: Integrating https://github.com/nagios-plugins/nagios-plugins/commit/714e77764b42ad2ba7713e5648cc440e2fedbc98 would be cool, but I would delay that after the next stable release as it is a significant change. /cc @skottler -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1177#issuecomment-39543151 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Apr 4 10:42:40 2014 From: notifications at github.com (waja) Date: Fri, 04 Apr 2014 01:42:40 -0700 Subject: check_nt UPTIME perfdata [sf#3434647] (#1024) In-Reply-To: References: Message-ID: This could be closed due the close of #1177 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1024#issuecomment-39543244 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Apr 4 10:47:39 2014 From: notifications at github.com (waja) Date: Fri, 04 Apr 2014 01:47:39 -0700 Subject: Remove the suggestion to run check_apt with --verbose since it doesn't d... (#1252) In-Reply-To: References: Message-ID: +1 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1252#issuecomment-39543594 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Apr 4 11:05:55 2014 From: notifications at github.com (Sam Kottler) Date: Fri, 04 Apr 2014 02:05:55 -0700 Subject: Remove the suggestion to run check_apt with --verbose since it doesn't d... (#1252) In-Reply-To: References: Message-ID: @waja shall I just remove the `verbose` code altogether? -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1252#issuecomment-39544913 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Apr 4 11:14:11 2014 From: notifications at github.com (Sam Kottler) Date: Fri, 04 Apr 2014 02:14:11 -0700 Subject: check_nagios should support other platforms (#1223) In-Reply-To: References: Message-ID: I think we should rename the plugin to something like `check_mon` or something like that. It's great that's part of the project, but certainly shouldn't be made to seem like it's nagios specific. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1223#issuecomment-39545547 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Apr 4 11:16:35 2014 From: notifications at github.com (Sam Kottler) Date: Fri, 04 Apr 2014 02:16:35 -0700 Subject: Added perfdata to check_nt. New -l options - seconds|minutes|hours|days. (#1253) In-Reply-To: References: Message-ID: I've added the `nextstable` label to this pull request so it'll get reviewed when the 2.x cycle gets started. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1253#issuecomment-39545752 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Apr 4 12:49:09 2014 From: notifications at github.com (waja) Date: Fri, 04 Apr 2014 03:49:09 -0700 Subject: Remove the suggestion to run check_apt with --verbose since it doesn't d... (#1252) In-Reply-To: References: Message-ID: I still think, that this is usefull for debugging things, so I would keep it (for now). Unfortunately I've seen ppl using --verbose trying to get performance data/using it in production checks, so stop promoting it is a good idea. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1252#issuecomment-39552666 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Apr 4 12:53:37 2014 From: notifications at github.com (Sam Kottler) Date: Fri, 04 Apr 2014 03:53:37 -0700 Subject: Remove the suggestion to run check_apt with --verbose since it doesn't d... (#1252) In-Reply-To: References: Message-ID: Okay. I'm going to merge this as-is then. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1252#issuecomment-39552953 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Apr 4 12:56:43 2014 From: notifications at github.com (Sam Kottler) Date: Fri, 04 Apr 2014 03:56:43 -0700 Subject: Remove the suggestion to run check_apt with --verbose since it doesn't d... (#1252) In-Reply-To: References: Message-ID: Merged as c887890e9f9698f01eb62451a04579c9c4be325f. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1252#issuecomment-39553146 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Apr 4 12:56:40 2014 From: notifications at github.com (Sam Kottler) Date: Fri, 04 Apr 2014 03:56:40 -0700 Subject: Remove the suggestion to run check_apt with --verbose since it doesn't d... (#1252) In-Reply-To: References: Message-ID: Closed #1252. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1252 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Apr 14 15:35:52 2014 From: notifications at github.com (langemeijer) Date: Mon, 14 Apr 2014 06:35:52 -0700 Subject: Add commandline -T switch to check_time and check_ntp_time (#1246) In-Reply-To: References: Message-ID: Updating the thanks file was an attempt to get Travis CI to re-examine my commits. Sadly this doesn't seem to work. I imagine the failed build had something to do with the Travis CI infrastructure, as the build was killed after 10 minutes while running tools/setup. https://travis-ci.org/monitoring-plugins/monitoring-plugins/builds/22945684 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1246#issuecomment-40365702 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Apr 17 06:22:03 2014 From: notifications at github.com (Thomas Guyot-Sionnest) Date: Wed, 16 Apr 2014 21:22:03 -0700 Subject: Add commandline -T switch to check_time and check_ntp_time (#1246) In-Reply-To: References: Message-ID: Hi Holger, FWIW I had in mind for quite some time adding an option to set the state on timeout - and that's not just for the check_ntp_* plugins... Do you think there's something fairly generic we could add to many similar plugins? Check_http, check_ntp*, check_snmp, check_nrpe are some of the plugins for which id's have had use for this sort of behavior in the past (there's probably more...). Regards, On 21/03/14 06:02 AM, Holger Wei? wrote: > > Ah, having |-T| accept an argument was exactly what I had in mind, > after playing around with |negate| I had only forgotten that your > patch doesn't do just that (had no coffee yet today). So yes, that > would be great. > > There's |plugins/t/check_time.t| and |plugins/t/check_ntp.t| (the > latter is testing all |check_ntp*| plugins). I can add one or two test > cases myself if it's not obvious how to do that. > > Thanks! > > ? > Reply to this email directly or view it on GitHub > > . > -- Thomas --- Reply to this email directly or view it on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1246#issuecomment-40679553 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Apr 17 21:59:00 2014 From: notifications at github.com (Thomas Guyot-Sionnest) Date: Thu, 17 Apr 2014 12:59:00 -0700 Subject: Add commandline -T switch to check_time and check_ntp_time (#1246) In-Reply-To: References: Message-ID: I understand your point, however I'm looking at a larger scale: there are many plugins that can be used for multiple purposes. check_http is normally used to check the health of an http server/service, however I can write a simple http "application" that turn it into a remote monitoring tool. Now I may want to tell check_http what state I want to have timeouts to return because I already have monitoring on the server itself and I really care about what the service state is, not the http server that is running my check. Same thing goes for SNMP. If I use snmp for controling devices, I may want to monitor and alert on its responsiveness. OTOH snmp checks that timeout or fail because there is a problem with the sub-agent may have to be handled differently. It's a pretty obvious one for NRPE, check_*sql, etc. too. I think giving more control to the user on the state returned for a timeout on most plugins where it makes sense will help you achieve your goal.. my point is that it's not limited to check_*_time. Regards, -- Thomas -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1246#issuecomment-40756036 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Apr 20 08:06:03 2014 From: notifications at github.com (Thomas Guyot-Sionnest) Date: Sat, 19 Apr 2014 23:06:03 -0700 Subject: Add commandline -T switch to check_time and check_ntp_time (#1246) In-Reply-To: References: Message-ID: Thanks. I'll look at your patch... From what I understand though something that gets the state from a switch and use it for timeouts would be compatible with what you're doing. Should be very simple to implement. If you're interested I can send you a php "plugin" skeleton from what I used in the past to monitor services trough http. The check_http status is derived natively from the HTTP response code (without any modifyers, 2xx==OK, 3xx==WARNING and 4xx=CRITICAL), and the plugin output is written on the responce code line's witch is printed by check_http as well (iirc I used a switch to enable that). -- Thomas -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1246#issuecomment-40888733 -------------- next part -------------- An HTML attachment was scrubbed... URL: From yflin at tw.ibm.com Sun Apr 20 10:27:37 2014 From: yflin at tw.ibm.com (Joy YF Lin) Date: Sun, 20 Apr 2014 16:27:37 +0800 Subject: AUTO: Joy YF Lin/Taiwan/IBM is out of the office. (returning 2014/04/23) Message-ID: I am out of the office until 2014/04/23. I will be out of the office from 4/21 to 4/22. During that time I may not have access to email & mobile but will respond upon my return. If you require an immediate response, please contact my backup. Thanks. Team operation & resource management: Robert RL Lee PE & Manager backup : Edward Kao Note: This is an automated response to your message "Re: Add commandline -T switch to check_time and check_ntp_time (#1246)" sent on 20/04/2014 14:06:03. This is the only notification you will receive while this person is away. -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Apr 24 08:51:25 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Wed, 23 Apr 2014 23:51:25 -0700 Subject: check_snmp: Handle SNMPv3 noAuthNoPriv properly (#1245) In-Reply-To: References: Message-ID: Closed #1245. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1245 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Apr 24 08:51:25 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Wed, 23 Apr 2014 23:51:25 -0700 Subject: check_snmp: Handle SNMPv3 noAuthNoPriv properly (#1245) In-Reply-To: References: Message-ID: Applied, thank you! -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1245#issuecomment-41247794 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Apr 24 10:15:29 2014 From: notifications at github.com (hydrapolic) Date: Thu, 24 Apr 2014 01:15:29 -0700 Subject: monitoring-plugins-1.5 fails to build with gnutls (#1254) Message-ID: When building on Gentoo Linux: ./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/usr/lib64 --disable-dependency-tracking --without-mysql --without-ipv6 --with-ldap --without-radius --without-pgsql --without-openssl --with-gnutls=/usr --disable-nls --libexecdir=/usr/lib64/nagios/plugins --sysconfdir=/etc/nagios checking for libgnutls-config... no checking gnutls/openssl.h usability... yes checking gnutls/openssl.h presence... yes checking for gnutls/openssl.h... yes checking for main in -lgnutls-openssl... yes config.status: creating po/Makefile --with-apt-get-command: --with-ping6-command: --with-ping-command: /bin/ping -n -U -w %d -c %d %s --with-ipv6: no --with-mysql: no --with-openssl: no --with-gnutls: yes --enable-extra-opts: no --with-perl: /usr/bin/perl --enable-perl-modules: no --with-cgiurl: /nagios/cgi-bin --with-trusted-path: /bin:/sbin:/usr/bin:/usr/sbin --enable-libtap: no /bin/sh ../libtool --tag=CC --mode=link x86_64-pc-linux-gnu-gcc -DNP_VERSION='"1.5"' -mtune=native -O2 -pipe -Wl,-O1 -Wl,--as-needed -L. -o check_http check_http.o libnpcommon.a ../lib/libnagiosplug.a ../gl/libgnu.a libnpcommon.a ../lib/libnagiosplug.a ../gl/libgnu.a -lnsl -lresolv -lgnutls-openssl -lpthread -ldl libtool: link: x86_64-pc-linux-gnu-gcc -DNP_VERSION=\"1.5\" -mtune=native -O2 -pipe -Wl,-O1 -o check_http check_http.o -Wl,--as-needed -L. libnpcommon.a ../lib/libnagiosplug.a ../gl/libgnu.a -lnsl -lresolv -lgnutls-openssl -lpthread -ldl libnpcommon.a(sslutils.o): In function `np_net_ssl_init_with_hostname_version_and_cert': sslutils.c:(.text+0xa1): undefined reference to `SSL_CTX_check_private_key' collect2: error: ld returned 1 exit status Makefile:1983: recipe for target 'check_http' failed make[2]: *** [check_http] Error 1 make[2]: Leaving directory '/var/tmp/portage/net-analyzer/nagios-plugins-1.5-r1/work/nagios-plugins-1.5/plugins' Makefile:1510: recipe for target 'all-recursive' failed make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory '/var/tmp/portage/net-analyzer/nagios-plugins-1.5-r1/work/nagios-plugins-1.5' Makefile:1435: recipe for target 'all' failed make: *** [all] Error 2 Commit: https://github.com/monitoring-plugins/monitoring-plugins/commit/2f92d0dab77a3f3b1005dae3401ea1316d6789b2 Added: if (!SSL_CTX_check_private_key(c)) { printf ("%s\n", _("CRITICAL - Private key does not seem to match certificate!\n")); return STATE_CRITICAL; } However, SSL_CTX_check_private_key doesn't exist in Gnutls (checked in versions 2.12.23, 3.2.4, 3.3.0). People mentioning this: http://blog.nicolargo.com/2009/01/le-serveur-de-supervision-libre-part-2.html (comments): http://www.developpez.net/forums/d1384537/systemes/linux/administration-systeme/nagios-probleme-lancement/ When mentioning gnutls, libgnutls-config seems to be missing in recent gnutls versions and is replaced with pkg-config: http://gnutls.org/manual/gnutls.html#Building-the-source -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1254 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Apr 26 13:12:03 2014 From: notifications at github.com (Gunnar Beutner) Date: Sat, 26 Apr 2014 04:12:03 -0700 Subject: Windows fixes (#1255) Message-ID: This branch fixes a number of Windows build issues - though not all of them, check_icmp still breaks the build. It also implements proper support for check_ping, check_users and check_disk on Windows. You can merge this Pull Request by running: git pull https://github.com/gunnarbeutner/monitoring-plugins windows-fixes Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1255 -- Commit Summary -- * Add missing file extensions for some of the plugins. * Make check_ping work on Windows. * Make check_users work on Windows. * Make check_disk work on Windows. -- File Changes -- M configure.ac (68) M plugins/Makefile.am (2) M plugins/check_disk.c (21) M plugins/check_ping.c (7) M plugins/check_users.c (42) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1255.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1255.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1255 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Apr 27 20:00:27 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Sun, 27 Apr 2014 11:00:27 -0700 Subject: Windows fixes (#1255) In-Reply-To: References: Message-ID: Applied, thanks! -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1255#issuecomment-41503735 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Apr 27 20:00:27 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Sun, 27 Apr 2014 11:00:27 -0700 Subject: Windows fixes (#1255) In-Reply-To: References: Message-ID: Closed #1255. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1255 -------------- next part -------------- An HTML attachment was scrubbed... URL: