From holger at zedat.fu-berlin.de Mon Dec 1 01:10:39 2014 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Mon, 1 Dec 2014 01:10:39 +0100 Subject: [PATCH] check_tcp: fix help description regarding escape option In-Reply-To: <20141130235747.00001e39@localhost> References: <20141130235747.00001e39@localhost> Message-ID: <20141201001039.GA717688@zedat.fu-berlin.de> * Sebastian Herbszt [2014-11-30 23:57]: > The help description should print '\\' for backslash not just '\'. Applied, thanks. Holger From notifications at github.com Tue Dec 2 21:11:41 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Tue, 02 Dec 2014 12:11:41 -0800 Subject: check_mailq: add sudo support (#1171) In-Reply-To: References: Message-ID: Actually, I'll make it a compile time option, and have `./configure` auto-detect the path by default. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1171#issuecomment-65296135 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Dec 4 07:39:44 2014 From: notifications at github.com (rasoso) Date: Wed, 03 Dec 2014 22:39:44 -0800 Subject: monitoring-plugins.spec.in: Needs some love (#1273) In-Reply-To: References: Message-ID: Discussed on irc: - .spec for the project may need to be different from the fedora one because it may need to support multiple rpm distributions (like opensuse). fedora .spec: https://bugzilla.redhat.com/show_bug.cgi?id=1059281 - single .spec for multiple rpms may be better because of the dependencies (no need to install the dependency of a plugins if it is not used) -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1273#issuecomment-65544165 -------------- next part -------------- An HTML attachment was scrubbed... URL: From herbszt at gmx.de Mon Dec 8 23:21:54 2014 From: herbszt at gmx.de (Sebastian Herbszt) Date: Mon, 8 Dec 2014 23:21:54 +0100 Subject: [PATCH] check_dns: remove dead code Message-ID: <20141208232154.000027b8@localhost> Remove code dead since commit 4efa917. Signed-off-by: Sebastian Herbszt --- plugins/check_dns.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/plugins/check_dns.c b/plugins/check_dns.c index 2212122..0316e40 100644 --- a/plugins/check_dns.c +++ b/plugins/check_dns.c @@ -81,7 +81,6 @@ main (int argc, char **argv) double elapsed_time; long microsec; struct timeval tv; - int multi_address; int parse_address = FALSE; /* This flag scans for Address: but only after Name: */ output chld_out, chld_err; size_t i; @@ -249,11 +248,6 @@ main (int argc, char **argv) elapsed_time = (double)microsec / 1.0e6; if (result == STATE_OK) { - if (strchr (address, ',') == NULL) - multi_address = FALSE; - else - multi_address = TRUE; - result = get_status(elapsed_time, time_thresholds); if (result == STATE_OK) { printf ("DNS %s: ", _("OK")); -- 2.1.0 From herbszt at gmx.de Mon Dec 8 23:42:06 2014 From: herbszt at gmx.de (Sebastian Herbszt) Date: Mon, 8 Dec 2014 23:42:06 +0100 Subject: [PATCH] check_load: remove superfluous argument to printf Message-ID: <20141208234206.0000068b@localhost> The format string expects only one argument. Signed-off-by: Sebastian Herbszt --- plugins/check_load.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/check_load.c b/plugins/check_load.c index cde63e5..31b781c 100644 --- a/plugins/check_load.c +++ b/plugins/check_load.c @@ -160,7 +160,7 @@ main (int argc, char **argv) sscanf (input_buffer, "%*[^l]load averages: %lf, %lf, %lf", &la1, &la5, &la15); } else { - printf (_("could not parse load from uptime: %s\n"), result, PATH_TO_UPTIME); + printf (_("could not parse load from uptime: %s\n"), PATH_TO_UPTIME); return STATE_UNKNOWN; } -- 2.1.0 From herbszt at gmx.de Tue Dec 9 00:09:23 2014 From: herbszt at gmx.de (Sebastian Herbszt) Date: Tue, 9 Dec 2014 00:09:23 +0100 Subject: [PATCH] negate: remove unused variables Message-ID: <20141209000923.000004c0@localhost> Remove unused variables. Signed-off-by: Sebastian Herbszt --- plugins/negate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/negate.c b/plugins/negate.c index beaed1e..b320e35 100644 --- a/plugins/negate.c +++ b/plugins/negate.c @@ -59,8 +59,8 @@ static int state[4] = { int main (int argc, char **argv) { - int found = 0, result = STATE_UNKNOWN; - char *buf, *sub; + int result = STATE_UNKNOWN; + char *sub; char **command_line; output chld_out, chld_err; int i; -- 2.1.0 From notifications at github.com Sun Dec 14 11:32:02 2014 From: notifications at github.com (jklippel) Date: Sun, 14 Dec 2014 02:32:02 -0800 Subject: check_by_ssh: added option to exit with an warning, if there is output on STDERR (#1301) In-Reply-To: References: Message-ID: While it is a good idea to centralize matching functionality I am opposed to replacing this small patch by an negate-enhancement. - The size of this patch (i12:d2) alone does not justify the effort to enhance negate by such a big feature.. - There is already the --skip-stderr parameter, the proposed patch only extends the already existing behaviour by issuing a warning. - Using negate would introduce at least one additional fork which is not helpful in a big environment using check_by_ssh very often and a lot of overhead for so little functionality. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1301#issuecomment-66908797 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Dec 15 08:12:42 2014 From: notifications at github.com (waja) Date: Sun, 14 Dec 2014 23:12:42 -0800 Subject: check_http: fix Host header if explicitly set with -k (#1305) In-Reply-To: References: Message-ID: n-p seems to have pulled it with 2.1.0-beta-RC1. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1305#issuecomment-66956974 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Dec 15 08:17:51 2014 From: notifications at github.com (waja) Date: Sun, 14 Dec 2014 23:17:51 -0800 Subject: check_ldap can't connect to unix socket [sf#3191396] (#987) In-Reply-To: References: Message-ID: n-p seems to have pulled it with 2.1.0-beta-RC1. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/987#issuecomment-66957299 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Dec 15 12:08:01 2014 From: notifications at github.com (Andreas Steinel) Date: Mon, 15 Dec 2014 03:08:01 -0800 Subject: check_snmp and offset (#1306) Message-ID: Hi, I'm trying to subtract something from the given value, but it does not work. Maybe I do not understand it correctly, but have a look: 
$ ./check_snmp --version
check_snmp v2.1.1.37.g8235 (monitoring-plugins 2.1.1)

$ ./check_snmp -o IF-MIB::ifSpeed.1 --offset=-999900.0 -u MBit -m
RFC1213-MIB -l Speed switch
SNMP OK - Speed 100000000 MBit | Speed=100000000 

$ ./check_snmp -o IF-MIB::ifSpeed.1 --offset=999900.0 -u MBit -m RFC1213-MIB
-l Speed switch
SNMP OK - Speed 100000000 MBit | Speed=100000000 

$ ./check_snmp -o IF-MIB::ifSpeed.1 --offset=999900 -u MBit -m RFC1213-MIB
-l Speed switch
SNMP OK - Speed 100000000 MBit | Speed=100000000 

$ ./check_snmp -o IF-MIB::ifSpeed.1 --offset -999900 -u MBit -m RFC1213-MIB
-l Speed switch
SNMP OK - Speed 100000000 MBit | Speed=100000000
-- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1306 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Dec 15 17:46:15 2014 From: notifications at github.com (waja) Date: Mon, 15 Dec 2014 08:46:15 -0800 Subject: check_dns: remove dead code (#1307) Message-ID: Remove code dead since commit 4efa917. Signed-off-by: Sebastian Herbszt You can merge this Pull Request by running: git pull https://github.com/waja/monitoring-plugins check_dns_dead_code Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1307 -- Commit Summary -- * check_dns: remove dead code -- File Changes -- M plugins/check_dns.c (6) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1307.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1307.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1307 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Dec 15 19:40:13 2014 From: notifications at github.com (waja) Date: Mon, 15 Dec 2014 10:40:13 -0800 Subject: check_load: remove superfluous argument to printf (#1308) Message-ID: The format string expects only one argument. Signed-off-by: Sebastian Herbszt You can merge this Pull Request by running: git pull https://github.com/waja/monitoring-plugins check_load_remove_superfluous Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1308 -- Commit Summary -- * check_load: remove superfluous argument to printf -- File Changes -- M plugins/check_load.c (2) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1308.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1308.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1308 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Dec 15 19:43:12 2014 From: notifications at github.com (waja) Date: Mon, 15 Dec 2014 10:43:12 -0800 Subject: negate: remove unused variables (#1309) Message-ID: Remove unused variables. Signed-off-by: Sebastian Herbszt You can merge this Pull Request by running: git pull https://github.com/waja/monitoring-plugins negate_remove_unused_variables Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1309 -- Commit Summary -- * negate: remove unused variables -- File Changes -- M plugins/negate.c (4) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1309.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1309.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1309 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Dec 16 03:48:26 2014 From: notifications at github.com (Boden Garman) Date: Mon, 15 Dec 2014 18:48:26 -0800 Subject: check_radius help text is misleading (#1310) In-Reply-To: References: Message-ID: Additionally - the format or purpose of the configuration file is not document. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1310#issuecomment-67104759 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Dec 16 03:48:30 2014 From: notifications at github.com (Boden Garman) Date: Mon, 15 Dec 2014 18:48:30 -0800 Subject: check_radius help text is misleading (#1310) In-Reply-To: References: Message-ID: Reopened #1310. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1310#event-208052107 -------------- next part -------------- An HTML attachment was scrubbed... URL: From herbszt at gmx.de Sat Dec 20 20:51:44 2014 From: herbszt at gmx.de (Sebastian Herbszt) Date: Sat, 20 Dec 2014 20:51:44 +0100 Subject: [PATCH] check_disk: remove unused variables Message-ID: <20141220205144.00001c13@localhost> Remove unused variables. Signed-off-by: Sebastian Herbszt --- plugins/check_disk.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/plugins/check_disk.c b/plugins/check_disk.c index eb573f5..d37cc3a 100644 --- a/plugins/check_disk.c +++ b/plugins/check_disk.c @@ -61,9 +61,6 @@ const char *email = "devel at monitoring-plugins.org"; # define ERROR -1 #endif -/* If nonzero, show inode information. */ -static int inode_format = 1; - /* If nonzero, show even filesystems with zero size or uninteresting types. */ static int show_all_fs = 1; @@ -182,7 +179,7 @@ main (int argc, char **argv) int temp_result; struct mount_entry *me; - struct fs_usage fsp, tmpfsp; + struct fs_usage fsp; struct parameter_list *temp_list, *path; #ifdef __CYGWIN__ @@ -427,9 +424,7 @@ process_arguments (int argc, char **argv) int c, err; struct parameter_list *se; struct parameter_list *temp_list = NULL, *previous = NULL; - struct parameter_list *temp_path_select_list = NULL; - struct mount_entry *me, *temp_me; - int result = OK; + struct mount_entry *me; regex_t re; int cflags = REG_NOSUB | REG_EXTENDED; int default_cflags = cflags; -- 2.1.0 From herbszt at gmx.de Sat Dec 20 20:53:57 2014 From: herbszt at gmx.de (Sebastian Herbszt) Date: Sat, 20 Dec 2014 20:53:57 +0100 Subject: [PATCH] check_ntp_time: remove unused variables Message-ID: <20141220205357.0000646d@localhost> Remove unused variables. Signed-off-by: Sebastian Herbszt --- plugins/check_ntp_time.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/plugins/check_ntp_time.c b/plugins/check_ntp_time.c index e344f8b..f2762ef 100644 --- a/plugins/check_ntp_time.c +++ b/plugins/check_ntp_time.c @@ -244,7 +244,7 @@ void setup_request(ntp_message *p){ * this is done by filtering servers based on stratum, dispersion, and * finally round-trip delay. */ int best_offset_server(const ntp_server_results *slist, int nservers){ - int i=0, cserver=0, best_server=-1; + int cserver=0, best_server=-1; /* for each server */ for(cserver=0; cserver Remove unused variables. Signed-off-by: Sebastian Herbszt --- plugins/check_ntp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/plugins/check_ntp.c b/plugins/check_ntp.c index a7d278d..7450171 100644 --- a/plugins/check_ntp.c +++ b/plugins/check_ntp.c @@ -297,7 +297,7 @@ void setup_request(ntp_message *p){ * this is done by filtering servers based on stratum, dispersion, and * finally round-trip delay. */ int best_offset_server(const ntp_server_results *slist, int nservers){ - int i=0, cserver=0, best_server=-1; + int cserver=0, best_server=-1; /* for each server */ for(cserver=0; cserver Remove superfluous parenthesis. Signed-off-by: Sebastian Herbszt --- plugins/sslutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/sslutils.c b/plugins/sslutils.c index d0ae474..2fdb6a9 100644 --- a/plugins/sslutils.c +++ b/plugins/sslutils.c @@ -59,7 +59,7 @@ int np_net_ssl_init_with_hostname_version_and_cert(int sd, char *host_name, int break; case 2: /* SSLv2 protocol */ #if defined(USE_GNUTLS) || defined(OPENSSL_NO_SSL2) - printf(("%s\n", _("CRITICAL - SSL protocol version 2 is not supported by your SSL library."))); + printf("%s\n", _("CRITICAL - SSL protocol version 2 is not supported by your SSL library.")); return STATE_CRITICAL; #else method = SSLv2_client_method(); -- 2.1.0 From herbszt at gmx.de Sat Dec 20 21:00:36 2014 From: herbszt at gmx.de (Sebastian Herbszt) Date: Sat, 20 Dec 2014 21:00:36 +0100 Subject: [PATCH] utils: remove unused variable Message-ID: <20141220210036.000047dd@localhost> Remove unused variable. Signed-off-by: Sebastian Herbszt --- plugins/utils.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/plugins/utils.c b/plugins/utils.c index 58b153d..4b3c0c8 100644 --- a/plugins/utils.c +++ b/plugins/utils.c @@ -144,8 +144,6 @@ usage5 (void) void print_revision (const char *command_name, const char *revision) { - char plugin_revision[STRLEN]; - printf ("%s v%s (%s %s)\n", command_name, revision, PACKAGE, VERSION); } -- 2.1.0 From notifications at github.com Sat Dec 27 15:31:40 2014 From: notifications at github.com (waja) Date: Sat, 27 Dec 2014 06:31:40 -0800 Subject: sslutils: remove superfluous parenthesis (#1314) Message-ID: Remove superfluous parenthesis. Signed-off-by: Sebastian Herbszt You can merge this Pull Request by running: git pull https://github.com/waja/monitoring-plugins sslutils_remove_superfluous_parenthesis Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1314 -- Commit Summary -- * sslutils: remove superfluous parenthesis -- File Changes -- M plugins/sslutils.c (2) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1314.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1314.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1314 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Dec 27 15:31:45 2014 From: notifications at github.com (waja) Date: Sat, 27 Dec 2014 06:31:45 -0800 Subject: utils: remove unused variable (#1315) Message-ID: Remove unused variable. Signed-off-by: Sebastian Herbszt You can merge this Pull Request by running: git pull https://github.com/waja/monitoring-plugins utils_remove_unused_variable Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1315 -- Commit Summary -- * utils: remove unused variable -- File Changes -- M plugins/utils.c (2) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1315.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1315.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1315 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Dec 28 14:05:10 2014 From: notifications at github.com (Sven Nierlein) Date: Sun, 28 Dec 2014 05:05:10 -0800 Subject: [monitoring-plugin-perl] GetOpt::Long optional arguments using a colon instead of an equal sign (#2) In-Reply-To: References: Message-ID: Merged #2. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugin-perl/pull/2#event-212276105 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Dec 28 14:05:45 2014 From: notifications at github.com (Sven Nierlein) Date: Sun, 28 Dec 2014 05:05:45 -0800 Subject: [monitoring-plugin-perl] GetOpt::Long optional arguments using a colon instead of an equal sign (#2) In-Reply-To: References: Message-ID: thanks for you patch and sorry for the delay. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugin-perl/pull/2#issuecomment-68206594 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Dec 30 02:41:03 2014 From: notifications at github.com (Francois Conil) Date: Mon, 29 Dec 2014 17:41:03 -0800 Subject: check_disk stopped working on btrfs filesystems after installing kernel 3.18 (#1316) Message-ID: Hi, After upgrading the kernel to 3.18, we're experiencing the following error: on a 3.16 host, btrfs FS: ``` /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -p /var/lib/docker/btrfs DISK OK - free space: /var/lib/docker/btrfs 67117 MB (69% inode=-);| /var/lib/docker/btrfs=29640MB;92152;97272;0;102392 ``` on a 3.18 host, btrfs FS: ``` /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -p / DISK CRITICAL - free space: / 0 MB (0% inode=-);| /=134139MB;15451534;16309953;0;17168372 ``` 3.16 strace: ``` strace /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -p /var/lib/docker/btrfs execve("/usr/lib/nagios/plugins/check_disk", ["/usr/lib/nagios/plugins/check_di"..., "-w", "10%", "-c", "5%", "-p", "/var/lib/docker/btrfs"], [/* 21 vars */]) = 0 brk(0) = 0x7f671cbd0000 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f671c67e000 access("/etc/ld.so.preload", R_OK) = -1 ENOENT (No such file or directory) open("/etc/ld.so.cache", O_RDONLY) = 3 fstat(3, {st_mode=S_IFREG|0644, st_size=25947, ...}) = 0 mmap(NULL, 25947, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7f671c677000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libpthread.so.0", O_RDONLY) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0@\\\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0755, st_size=131107, ...}) = 0 mmap(NULL, 2208672, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f671c245000 mprotect(0x7f671c25c000, 2093056, PROT_NONE) = 0 mmap(0x7f671c45b000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x16000) = 0x7f671c45b000 mmap(0x7f671c45d000, 13216, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7f671c45d000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libdl.so.2", O_RDONLY) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\340\r\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=14768, ...}) = 0 mmap(NULL, 2109696, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f671c041000 mprotect(0x7f671c043000, 2097152, PROT_NONE) = 0 mmap(0x7f671c243000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x2000) = 0x7f671c243000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libc.so.6", O_RDONLY) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\300\357\1\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0755, st_size=1603600, ...}) = 0 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f671c676000 mmap(NULL, 3717176, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f671bcb5000 mprotect(0x7f671be37000, 2097152, PROT_NONE) = 0 mmap(0x7f671c037000, 20480, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x182000) = 0x7f671c037000 mmap(0x7f671c03c000, 18488, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7f671c03c000 close(3) = 0 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f671c675000 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f671c674000 arch_prctl(ARCH_SET_FS, 0x7f671c675700) = 0 mprotect(0x7f671c037000, 16384, PROT_READ) = 0 mprotect(0x7f671c243000, 4096, PROT_READ) = 0 mprotect(0x7f671c45b000, 4096, PROT_READ) = 0 mprotect(0x7f671c8a0000, 4096, PROT_READ) = 0 mprotect(0x7f671c680000, 4096, PROT_READ) = 0 munmap(0x7f671c677000, 25947) = 0 set_tid_address(0x7f671c6759d0) = 9513 set_robust_list(0x7f671c6759e0, 0x18) = 0 futex(0x7fff6676092c, FUTEX_WAIT_BITSET_PRIVATE|FUTEX_CLOCK_REALTIME, 1, NULL, 7f671c675700) = -1 EAGAIN (Resource temporarily unavailable) rt_sigaction(SIGRTMIN, {0x7f671c24aad0, [], SA_RESTORER|SA_SIGINFO, 0x7f671c2540a0}, NULL, 8) = 0 rt_sigaction(SIGRT_1, {0x7f671c24ab60, [], SA_RESTORER|SA_RESTART|SA_SIGINFO, 0x7f671c2540a0}, NULL, 8) = 0 rt_sigprocmask(SIG_UNBLOCK, [RTMIN RT_1], NULL, 8) = 0 getrlimit(RLIMIT_STACK, {rlim_cur=8192*1024, rlim_max=RLIM_INFINITY}) = 0 brk(0) = 0x7f671cbd0000 brk(0x7f671cbf1000) = 0x7f671cbf1000 open("/usr/lib/locale/locale-archive", O_RDONLY) = 3 fstat(3, {st_mode=S_IFREG|0644, st_size=1534592, ...}) = 0 mmap(NULL, 1534592, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7f671c4fd000 close(3) = 0 open("/etc/mtab", O_RDONLY) = 3 futex(0x7f671c03df00, FUTEX_WAKE_PRIVATE, 2147483647) = 0 fstat(3, {st_mode=S_IFREG|0444, st_size=0, ...}) = 0 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f671c67d000 read(3, "rootfs / rootfs rw,seclabel 0 0\n"..., 1024) = 1024 read(3, "/lib/nfs/rpc_pipefs rpc_pipefs r"..., 1024) = 1024 read(3, "to=tcp,port=0,timeo=600,retrans="..., 1024) = 1024 read(3, "ze=262144,wsize=262144,namlen=25"..., 1024) = 1024 read(3, "nfs4 rw,noatime,vers=4.0,rsize=2"..., 1024) = 1024 read(3, "ss3test/storage nfs4 rw,noatime,"..., 1024) = 1024 read(3, "-4/storage /var/docker-mounts/sr"..., 1024) = 1024 read(3, "_lock=none,addr=10.51.11.40 0 0\n"..., 1024) = 1024 read(3, "/var/lib/docker/btrfs btrfs rw,s"..., 1024) = 374 read(3, "", 1024) = 0 close(3) = 0 munmap(0x7f671c67d000, 4096) = 0 stat("/var/lib/docker/btrfs", {st_mode=S_IFDIR|0700, st_size=20, ...}) = 0 open("/etc/mtab", O_RDONLY) = 3 fstat(3, {st_mode=S_IFREG|0444, st_size=0, ...}) = 0 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f671c67d000 read(3, "rootfs / rootfs rw,seclabel 0 0\n"..., 1024) = 1024 read(3, "/lib/nfs/rpc_pipefs rpc_pipefs r"..., 1024) = 1024 read(3, "to=tcp,port=0,timeo=600,retrans="..., 1024) = 1024 read(3, "ze=262144,wsize=262144,namlen=25"..., 1024) = 1024 read(3, "nfs4 rw,noatime,vers=4.0,rsize=2"..., 1024) = 1024 read(3, "ss3test/storage nfs4 rw,noatime,"..., 1024) = 1024 read(3, "-4/storage /var/docker-mounts/sr"..., 1024) = 1024 read(3, "_lock=none,addr=10.51.11.40 0 0\n"..., 1024) = 1024 read(3, "/var/lib/docker/btrfs btrfs rw,s"..., 1024) = 374 read(3, "", 1024) = 0 close(3) = 0 munmap(0x7f671c67d000, 4096) = 0 stat("/var/lib/docker/btrfs", {st_mode=S_IFDIR|0700, st_size=20, ...}) = 0 statfs("/var/lib/docker/btrfs", {f_type=0x9123683e, f_bsize=4096, f_blocks=26212352, f_bfree=18624432, f_bavail=17182160, f_files=0, f_ffree=0, f_fsid={-1714817651, 1111202320}, f_namelen=255, f_frsize=4096}) = 0 fstat(1, {st_mode=S_IFCHR|0620, st_rdev=makedev(136, 0), ...}) = 0 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f671c67d000 write(1, "DISK OK - free space: /var/lib/d"..., 120DISK OK - free space: /var/lib/docker/btrfs 67117 MB (69% inode=-);| /var/lib/docker/btrfs=29640MB;92152;97272;0;102392 ) = 120 exit_group(0) = ? ``` 3.18 strace: ``` strace /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -p / execve("/usr/lib/nagios/plugins/check_disk", ["/usr/lib/nagios/plugins/check_di"..., "-w", "10%", "-c", "5%", "-p", "/"], [/* 21 vars */]) = 0 brk(0) = 0x7f52deaa9000 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f52ddf1f000 access("/etc/ld.so.preload", R_OK) = -1 ENOENT (No such file or directory) open("/etc/ld.so.cache", O_RDONLY) = 3 fstat(3, {st_mode=S_IFREG|0644, st_size=27730, ...}) = 0 mmap(NULL, 27730, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7f52ddf18000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libpthread.so.0", O_RDONLY) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0@\\\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0755, st_size=131107, ...}) = 0 mmap(NULL, 2208672, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f52ddae6000 mprotect(0x7f52ddafd000, 2093056, PROT_NONE) = 0 mmap(0x7f52ddcfc000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x16000) = 0x7f52ddcfc000 mmap(0x7f52ddcfe000, 13216, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7f52ddcfe000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libdl.so.2", O_RDONLY) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\340\r\0\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0644, st_size=14768, ...}) = 0 mmap(NULL, 2109696, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f52dd8e2000 mprotect(0x7f52dd8e4000, 2097152, PROT_NONE) = 0 mmap(0x7f52ddae4000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x2000) = 0x7f52ddae4000 close(3) = 0 access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory) open("/lib/x86_64-linux-gnu/libc.so.6", O_RDONLY) = 3 read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\300\357\1\0\0\0\0\0"..., 832) = 832 fstat(3, {st_mode=S_IFREG|0755, st_size=1603600, ...}) = 0 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f52ddf17000 mmap(NULL, 3717176, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f52dd556000 mprotect(0x7f52dd6d8000, 2097152, PROT_NONE) = 0 mmap(0x7f52dd8d8000, 20480, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x182000) = 0x7f52dd8d8000 mmap(0x7f52dd8dd000, 18488, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7f52dd8dd000 close(3) = 0 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f52ddf16000 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f52ddf15000 arch_prctl(ARCH_SET_FS, 0x7f52ddf16700) = 0 mprotect(0x7f52dd8d8000, 16384, PROT_READ) = 0 mprotect(0x7f52ddae4000, 4096, PROT_READ) = 0 mprotect(0x7f52ddcfc000, 4096, PROT_READ) = 0 mprotect(0x7f52de141000, 4096, PROT_READ) = 0 mprotect(0x7f52ddf21000, 4096, PROT_READ) = 0 munmap(0x7f52ddf18000, 27730) = 0 set_tid_address(0x7f52ddf169d0) = 26015 set_robust_list(0x7f52ddf169e0, 0x18) = 0 futex(0x7fff397aaeac, FUTEX_WAIT_BITSET_PRIVATE|FUTEX_CLOCK_REALTIME, 1, NULL, 7f52ddf16700) = -1 EAGAIN (Resource temporarily unavailable) rt_sigaction(SIGRTMIN, {0x7f52ddaebad0, [], SA_RESTORER|SA_SIGINFO, 0x7f52ddaf50a0}, NULL, 8) = 0 rt_sigaction(SIGRT_1, {0x7f52ddaebb60, [], SA_RESTORER|SA_RESTART|SA_SIGINFO, 0x7f52ddaf50a0}, NULL, 8) = 0 rt_sigprocmask(SIG_UNBLOCK, [RTMIN RT_1], NULL, 8) = 0 getrlimit(RLIMIT_STACK, {rlim_cur=8192*1024, rlim_max=RLIM_INFINITY}) = 0 brk(0) = 0x7f52deaa9000 brk(0x7f52deaca000) = 0x7f52deaca000 open("/usr/lib/locale/locale-archive", O_RDONLY) = 3 fstat(3, {st_mode=S_IFREG|0644, st_size=1534592, ...}) = 0 mmap(NULL, 1534592, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7f52ddd9e000 close(3) = 0 open("/etc/mtab", O_RDONLY) = 3 futex(0x7f52dd8def00, FUTEX_WAKE_PRIVATE, 2147483647) = 0 fstat(3, {st_mode=S_IFREG|0444, st_size=0, ...}) = 0 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f52ddf1e000 read(3, "rootfs / rootfs rw 0 0\nsysfs /sy"..., 1024) = 649 read(3, "", 1024) = 0 close(3) = 0 munmap(0x7f52ddf1e000, 4096) = 0 stat("/", {st_mode=S_IFDIR|0755, st_size=302, ...}) = 0 open("/etc/mtab", O_RDONLY) = 3 fstat(3, {st_mode=S_IFREG|0444, st_size=0, ...}) = 0 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f52ddf1e000 read(3, "rootfs / rootfs rw 0 0\nsysfs /sy"..., 1024) = 649 read(3, "", 1024) = 0 close(3) = 0 munmap(0x7f52ddf1e000, 4096) = 0 stat("/", {st_mode=S_IFDIR|0755, st_size=302, ...}) = 0 statfs("/", {f_type=0x9123683e, f_bsize=4096, f_blocks=4395103346, f_bfree=4360763531, f_bavail=4361056400, f_files=0, f_ffree=0, f_fsid={-1228765678, -1342971444}, f_namelen=255, f_frsize=4096}) = 0 fstat(1, {st_mode=S_IFCHR|0620, st_rdev=makedev(136, 0), ...}) = 0 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f52ddf1e000 write(1, "DISK CRITICAL - free space: / 0 "..., 90DISK CRITICAL - free space: / 0 MB (0% inode=-);| /=134139MB;15451534;16309953;0;17168372 ) = 90 exit_group(2) = ? ``` -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1316 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Dec 31 20:52:47 2014 From: notifications at github.com (doombirdAD) Date: Wed, 31 Dec 2014 11:52:47 -0800 Subject: check_icmp fails to compile on Solaris 10 and 11 (#1317) Message-ID: We're trying to update our monitoring in our mostly Solaris 10 and 11 environment, but I started getting errors compiling check_icmp in the most recent version. I suspect it's an issue between glibc and Oracle's libc. >From Solaris 10: ``` gcc -DLOCALEDIR=\"/usr/local/share/locale\" -DHAVE_CONFIG_H -I. -I.. -I.. -I../lib -I../gl -I../intl -I../plugins -I/include -D_REENTRANT -I/include -DNP_VERSION='"2.1.1"' -g -O2 -MT check_icmp.o -MD -MP -MF .deps/check_icmp.Tpo -c -o check_icmp.o check_icmp.c check_icmp.c: In function `send_icmp_ping': check_icmp.c:883: error: `MSG_CONFIRM' undeclared (first use in this function) check_icmp.c:883: error: (Each undeclared identifier is reported only once check_icmp.c:883: error: for each function it appears in.) check_icmp.c: In function `recvfrom_wto': check_icmp.c:943: error: structure has no member named `msg_control' check_icmp.c:944: error: structure has no member named `msg_controllen' *** Error code 1 make: Fatal error: Command failed for target `check_icmp.o' ``` Also errors when compiling from Solaris 11: ``` gcc -DLOCALEDIR=\"/usr/local/share/locale\" -DHAVE_CONFIG_H -I. -I.. -I.. -I../lib -I../gl -I../intl -I../plugins -I/usr/include -D_REENTRANT -DNP_VERSION='"2.1.1"' -g -O2 -MT check_icmp.o -MD -MP -MF .deps/check_icmp.Tpo -c -o check_icmp.o check_icmp.c check_icmp.c: In function ?send_icmp_ping?: check_icmp.c:883:28: error: ?MSG_CONFIRM? undeclared (first use in this function) check_icmp.c:883:28: note: each undeclared identifier is reported only once for each function it appears in check_icmp.c: In function ?recvfrom_wto?: check_icmp.c:943:5: error: ?struct msghdr? has no member named ?msg_control? check_icmp.c:944:5: error: ?struct msghdr? has no member named ?msg_controllen? check_icmp.c:948:11: warning: assignment makes pointer from integer without a cast check_icmp.c:948:45: warning: assignment makes pointer from integer without a cast check_icmp.c:952:4: warning: passing argument 2 of ?memcpy? makes pointer from integer without a cast /usr/include/iso/string_iso.h:54:14: note: expected ?const void *? but argument is of type ?int? *** Error code 1 make: Fatal error: Command failed for target `check_icmp.o' ``` --- Reply to this email directly or view it on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1317 -------------- next part -------------- An HTML attachment was scrubbed... URL: