From notifications at github.com Wed Jul 2 17:45:15 2014 From: notifications at github.com (waja) Date: Wed, 02 Jul 2014 08:45:15 -0700 Subject: check_icmp: with setcap enabled, but complains about suid (#1269) Message-ID: Even if check_icmp has the capabilities to work, it complains about needed root privilidges: waja at bb:~$ /usr/lib/nagios/plugins/check_icmp -H google.com Warning: This plugin must be either run as root or setuid root. To run as root, you can use a tool like sudo. To set the setuid permissions, use the command: chmod u+s yourpluginfile OK - google.com: rta 17.559ms, lost 0%|rta=17.559ms;200.000;500.000;0; pl=0%;40;80;; rtmax=17.635ms;;;; rtmin=17.387ms;;;; bb:~# getcap /usr/lib/nagios/plugins/check_icmp /usr/lib/nagios/plugins/check_icmp = cap_net_raw+ep -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1269 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jul 3 15:06:28 2014 From: notifications at github.com (waja) Date: Thu, 03 Jul 2014 06:06:28 -0700 Subject: check_ifstatus: not epn save (#1271) Message-ID: 9408c975fe199c4ef4d662dee05f4f684167b731#diff-dfcf995f823b2da424e38496f25d341a is introducing a regression: EXITED OK: No, RETURN CODE: 3, OUTPUT: **ePN failed to compile /usr/lib/nagios/plugins/check_ifstatus: "Can't locate utils.pm in @INC (@INC contains: /usr/lib/icinga /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at (eval 1) line 38,\nBEGIN failed--compilation aborted at (eval 1) line 45." -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1271 -------------- next part -------------- An HTML attachment was scrubbed... URL: From simon.deziel at gmail.com Tue Jul 1 12:09:06 2014 From: simon.deziel at gmail.com (Simon Deziel) Date: Tue, 01 Jul 2014 06:09:06 -0400 Subject: check_apt's future In-Reply-To: <20140619135452.GX17765@mal.justgohome.co.uk> References: <20140619135452.GX17765@mal.justgohome.co.uk> Message-ID: <53B288C2.3070308@gmail.com> On 14-06-19 09:54 AM, Robie Basak wrote: > I submitted > https://github.com/monitoring-plugins/monitoring-plugins/pull/1260 > a few days ago. I looked at the feature proposed in your branch and implemented it in check_apt_upgrade [1] hoping this would be useful. Regards, Simon 1: https://github.com/simondeziel/custom-nagios-plugins/blob/master/plugins/check_apt_upgrade From notifications at github.com Sun Jul 6 11:35:02 2014 From: notifications at github.com (waja) Date: Sun, 06 Jul 2014 02:35:02 -0700 Subject: check_radius: segfaulting when compiled against freeradius (#1270) In-Reply-To: References: Message-ID: libfreeradius-client2 needs a specific parameter in radiusclient.conf: # The length of time in seconds that we skip a nonresponsive RADIUS # server for transaction requests. Server(s) being in the "dead" state # are tried only after all other non-dead servers have been tried and # failed or timeouted. The deadtime interval starts when the server # does not respond to an authentication/accounting request transmissions. # When the interval expires, the "dead" server would be re-tried again, # and if it's still down then it will be considered "dead" for another # such interval and so on. This option is no-op if there is only one # server in the list. Set to 0 in order to disable the feature. radius_deadtime 0 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1270#issuecomment-48107128 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jul 6 11:35:02 2014 From: notifications at github.com (waja) Date: Sun, 06 Jul 2014 02:35:02 -0700 Subject: check_radius: segfaulting when compiled against freeradius (#1270) In-Reply-To: References: Message-ID: Closed #1270. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1270#event-138500178 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jul 6 13:32:27 2014 From: notifications at github.com (waja) Date: Sun, 06 Jul 2014 04:32:27 -0700 Subject: check_icmp: with setcap enabled, but complains about suid (#1269) In-Reply-To: References: Message-ID: fixed by ba21e26443385dd283d08e0419ff6ff25fedd0e8 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1269#issuecomment-48109422 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jul 6 13:32:27 2014 From: notifications at github.com (waja) Date: Sun, 06 Jul 2014 04:32:27 -0700 Subject: check_icmp: with setcap enabled, but complains about suid (#1269) In-Reply-To: References: Message-ID: Closed #1269. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1269#event-138506763 -------------- next part -------------- An HTML attachment was scrubbed... URL: From yflin at tw.ibm.com Sun Jul 6 16:02:58 2014 From: yflin at tw.ibm.com (Joy YF Lin) Date: Sun, 6 Jul 2014 22:02:58 +0800 Subject: AUTO: Joy YF Lin/Taiwan/IBM is out of the office. (returning 2014/07/21) Message-ID: I am out of the office until 2014/07/21. I will be out of the office from 7/5 to 7/20. During that time I may not have access to email & mobile but will respond upon my return. If you require an immediate response, please contact my backup. Thanks. Team operation & resource management: Robert RL Lee PE & Manager backup : Ruby Yu Note: This is an automated response to your message "Re: check_radius: segfaulting when compiled against freeradius (#1270)" sent on 06/07/2014 17:35:02. This is the only notification you will receive while this person is away. -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jul 6 19:55:21 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Sun, 06 Jul 2014 10:55:21 -0700 Subject: check_ifstatus: not epn save (#1271) In-Reply-To: References: Message-ID: Closed #1271 via 1f4fd12845a2041df3f34f7a84d8012e747e327c. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1271#event-138532021 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 7 11:37:57 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Mon, 07 Jul 2014 02:37:57 -0700 Subject: UNIX_PATH_MAX too large for *BSD (#1267) In-Reply-To: References: Message-ID: Closed #1267 via a2505f049d48d8ff77159a382f46b3cf854c096d. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1267#event-138660958 -------------- next part -------------- An HTML attachment was scrubbed... URL: From holger at zedat.fu-berlin.de Mon Jul 7 11:40:24 2014 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Mon, 7 Jul 2014 11:40:24 +0200 Subject: New release planned In-Reply-To: <20140622202230.GA365434@zedat.fu-berlin.de> References: <20140622202230.GA365434@zedat.fu-berlin.de> Message-ID: <20140707094024.GG299694@zedat.fu-berlin.de> * Holger Wei? [2014-06-22 22:22]: > We'd like to cut a Monitoring Plugins release really soon now. If you > could spare a bit of time to test the current snapshot? and report any > regressions from the 1.5 release, that would be great! We've applied another few changes and will create a release from the current code this week if no regressions or serious issues pop up: https://www.monitoring-plugins.org/download/snapshot/monitoring-plugins-master.tar.gz Jan also created Debian packages for his "wheezy-backports" and "unstable" repositories for you to test: http://ftp.cyconet.org/debian/ Thanks for your feedback so far! Holger From Matthias.Weiss at weiss-system.de Mon Jul 7 13:46:54 2014 From: Matthias.Weiss at weiss-system.de (Matthias =?ISO-8859-1?B?V2Vp3w==?=) Date: Mon, 07 Jul 2014 13:46:54 +0200 Subject: check_ifstatus: not epn save (#1271) In-Reply-To: References: Message-ID: Hallo, k?nnt Ihr mir bitte erkl?ren, wie ich von der Mailingliste herunter komme? Ich habe keinen Bedarf mehr an diesen Nachrichten. Von: Holger Wei? Antworten an: Monitoring Plugins Development Datum: Sonntag, 6. Juli 2014 KW27 19:55 An: Monitoring Plugins Development Betreff: Re: check_ifstatus: not epn save (#1271) Closed #1271 via 1f4fd12 . ? Reply to this email on GitHub . -------------- next part -------------- An HTML attachment was scrubbed... URL: From holger at zedat.fu-berlin.de Mon Jul 7 21:39:17 2014 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Mon, 7 Jul 2014 21:39:17 +0200 Subject: How to unsubscribe (was: check_ifstatus: not epn save (#1271)) In-Reply-To: References: Message-ID: <20140707193917.GJ299694@zedat.fu-berlin.de> * Matthias Wei? [2014-07-07 13:46]: > k?nnt Ihr mir bitte erkl?ren, wie ich von der Mailingliste herunter komme? > Ich habe keinen Bedarf mehr an diesen Nachrichten. [The question is: How to unsubscribe?] I submitted your email address at: https://www.monitoring-plugins.org/list/options/devel You should've received a confirmation email by now. Once you acknowledged that email, you should be unsubscribed. In case of trouble, please contact instead of this mailing list. Cheers, Holger From notifications at github.com Thu Jul 10 21:17:14 2014 From: notifications at github.com (Mikael Falkvidd) Date: Thu, 10 Jul 2014 12:17:14 -0700 Subject: check_procs: Add delay after forking in test (#1272) Message-ID: Forking raises a race condition, where the parent might run the test before the child has had time to fork. If that happens, an error similar to this is produced: Failed test 'Output correct' at ./t/check_procs.t line 32. 'PROCS OK: 0 processes with args 'sleep 7' | processes=0;;;0;' doesn't match '/^PROCS OK: 1 process?/' Sleeping a bit should avoid the problem. It might be enough to sleep less than a second, but perl's built-in sleep function only supports integer seconds. In our build environment, the build failed 3 of 4 times before this patch. After the patch it failed 0 of 7 times. Signed-off-by: Mikael Falkvidd <mfalkvidd at op5.com> You can merge this Pull Request by running: git pull https://github.com/mfalkvidd/monitoring-plugins master Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1272 -- Commit Summary -- * check_procs: Add delay after forking in test -- File Changes -- M plugins/t/check_procs.t (2) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1272.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1272.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1272 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jul 10 21:25:50 2014 From: notifications at github.com (Sam Kottler) Date: Thu, 10 Jul 2014 12:25:50 -0700 Subject: check_procs: Add delay after forking in test (#1272) In-Reply-To: References: Message-ID: Merged #1272. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1272#event-140342085 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jul 10 21:26:01 2014 From: notifications at github.com (Sam Kottler) Date: Thu, 10 Jul 2014 12:26:01 -0700 Subject: check_procs: Add delay after forking in test (#1272) In-Reply-To: References: Message-ID: Seems reasonable. Thanks! -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1272#issuecomment-48651937 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Jul 11 00:03:23 2014 From: notifications at github.com (Sam Kottler) Date: Thu, 10 Jul 2014 15:03:23 -0700 Subject: Update THANKS.in file with latest author (7e0661a) In-Reply-To: References: Message-ID: Thanks, sorry I forgot to do this. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/commit/7e0661a0930370248a0cd13174a6488fb1345ea0#commitcomment-6968028 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Jul 11 22:01:19 2014 From: notifications at github.com (waja) Date: Fri, 11 Jul 2014 13:01:19 -0700 Subject: Project rename initial commit. (63734f5) In-Reply-To: References: Message-ID: shouldn't those both lines reverted and maybe the old nagios-plugins* packages added? anybody with rpm knowledge? -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/commit/63734f52ab1b4b2c17545b26fc41016d6bbd80bd#commitcomment-6980575 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Jul 11 23:03:51 2014 From: notifications at github.com (waja) Date: Fri, 11 Jul 2014 14:03:51 -0700 Subject: monitoring-plugins.spec.in: Needs some love (#1273) Message-ID: After renaming into monitoring-plugin the spec file is not in a good shape. I guess the following should be reviewed: https://github.com/monitoring-plugins/monitoring-plugins/commit/63734f52ab1b4b2c17545b26fc41016d6bbd80bd#commitcomment-6980575 Anyways ... I don't know rpm very well anymore, but I guess there are other places which can be improved. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1273 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Jul 11 23:04:35 2014 From: notifications at github.com (Sam Kottler) Date: Fri, 11 Jul 2014 14:04:35 -0700 Subject: monitoring-plugins.spec.in: Needs some love (#1273) In-Reply-To: References: Message-ID: I will work on this. Assigning it to myself. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1273#issuecomment-48782809 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Jul 11 23:10:28 2014 From: notifications at github.com (waja) Date: Fri, 11 Jul 2014 14:10:28 -0700 Subject: monitoring-plugins.spec.in: Needs some love (#1273) In-Reply-To: References: Message-ID: \o/ -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1273#issuecomment-48783406 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Jul 11 23:11:15 2014 From: notifications at github.com (waja) Date: Fri, 11 Jul 2014 14:11:15 -0700 Subject: monitoring-plugins.spec.in: Needs some love (#1273) In-Reply-To: References: Message-ID: @skottler this could go into 'maint' -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1273#issuecomment-48783479 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jul 15 13:18:55 2014 From: notifications at github.com (waja) Date: Tue, 15 Jul 2014 04:18:55 -0700 Subject: check_ldap can't connect to unix socket [sf#3191396] (#987) In-Reply-To: References: Message-ID: same as https://github.com/nagios-plugins/nagios-plugins/issues/46 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/987#issuecomment-49018629 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jul 15 15:22:17 2014 From: notifications at github.com (waja) Date: Tue, 15 Jul 2014 06:22:17 -0700 Subject: check_ldap can't connect to unix socket [sf#3191396] (#987) In-Reply-To: References: Message-ID: n-p has a PR for it https://github.com/nagios-plugins/nagios-plugins/pull/47 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/987#issuecomment-49030171 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jul 20 00:23:50 2014 From: notifications at github.com (waja) Date: Sat, 19 Jul 2014 15:23:50 -0700 Subject: Several changes to remove NP-variables (#1274) Message-ID: Feel free to catch up part of this. You can merge this Pull Request by running: git pull https://github.com/waja/monitoring-plugins rename_ng Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1274 -- Commit Summary -- * Migrating over to MP-VERSION-GEN * Migrating to MP_RELEASE * Migrating to *MP-VERSION-FILE * Migrating to MP_VERSION * Migrating to MP_STATE* * Migrating to MP_EXTRA_OPTS * Migrating to MP_MATCH * Migrating to MP_UTIL * Migrating to MP_MAXARGS * Migrating to MP_RUNCMD * Migrating to MP_THRESHOLDS*, MP_RANGE_UNPARSEABLE* and MP_WARN_WITHIN* * Migrate to MPROCESSORS * Migrate to MP_HOST* * Migrate to MP_MYSQL* * Migrate remaining parts to to MP_* -- File Changes -- M .gitignore (2) R MP-VERSION-GEN (10) M Makefile.am (6) M configure.ac (20) M doc/RELEASING (2) M lib/Makefile.am (2) M lib/tests/Makefile.am (2) M lib/tests/test_tcp.c (18) M lib/tests/test_utils.c (4) M lib/tests/var/baddate (2) M lib/tests/var/missingdataline (2) M lib/tests/var/oldformat (2) M lib/tests/var/statefile (2) M lib/utils_base.c (16) M lib/utils_base.h (10) M lib/utils_tcp.c (20) M lib/utils_tcp.h (14) M plugins-root/Makefile.am (14) M plugins-root/check_dhcp.c (4) M plugins-root/check_icmp.c (2) M plugins-root/t/check_dhcp.t (8) M plugins-root/t/check_icmp.t (8) M plugins-scripts/Makefile.am (14) M plugins-scripts/check_breeze.pl (4) M plugins-scripts/check_disk_smb.pl (4) M plugins-scripts/check_file_age.pl (4) M plugins-scripts/check_flexlm.pl (4) M plugins-scripts/check_ifoperstatus.pl (4) M plugins-scripts/check_ifstatus.pl (6) M plugins-scripts/check_ircd.pl (4) M plugins-scripts/check_log.sh (2) M plugins-scripts/check_mailq.pl (4) M plugins-scripts/check_mssql.pl (2) M plugins-scripts/check_ntp.pl (4) M plugins-scripts/check_oracle.sh (2) M plugins-scripts/check_rpc.pl (4) M plugins-scripts/check_sensors.sh (2) M plugins-scripts/check_wave.pl (4) M plugins-scripts/t/check_disk_smb.t (16) M plugins-scripts/t/check_ifoperstatus.t (12) M plugins-scripts/t/check_ifstatus.t (8) M plugins/Makefile.am (14) M plugins/check_apt.c (4) M plugins/check_by_ssh.c (12) M plugins/check_cluster.c (4) M plugins/check_dbi.c (6) M plugins/check_dig.c (4) M plugins/check_disk.c (4) M plugins/check_dns.c (4) M plugins/check_dummy.c (4) M plugins/check_fping.c (4) M plugins/check_game.c (4) M plugins/check_hpjd.c (4) M plugins/check_http.c (6) M plugins/check_ide_smart.c (4) M plugins/check_ldap.c (4) M plugins/check_load.c (4) M plugins/check_mrtg.c (4) M plugins/check_mrtgtraf.c (4) M plugins/check_mysql.c (4) M plugins/check_mysql_query.c (4) M plugins/check_nagios.c (4) M plugins/check_nt.c (4) M plugins/check_ntp.c (4) M plugins/check_ntp_peer.c (4) M plugins/check_ntp_time.c (4) M plugins/check_nwstat.c (4) M plugins/check_overcr.c (4) M plugins/check_pgsql.c (4) M plugins/check_ping.c (4) M plugins/check_procs.c (4) M plugins/check_radius.c (4) M plugins/check_real.c (4) M plugins/check_smtp.c (4) M plugins/check_snmp.c (8) M plugins/check_ssh.c (4) M plugins/check_swap.c (4) M plugins/check_tcp.c (28) M plugins/check_time.c (4) M plugins/check_ups.c (4) M plugins/check_users.c (4) M plugins/common.h (8) M plugins/negate.c (4) M plugins/runcmd.c (4) M plugins/runcmd.h (2) M plugins/t/NPTest.cache.travis (80) M plugins/t/check_by_ssh.t (8) M plugins/t/check_dig.t (10) M plugins/t/check_disk.t (4) M plugins/t/check_dns.t (10) M plugins/t/check_fping.t (6) M plugins/t/check_ftp.t (6) M plugins/t/check_hpjd.t (6) M plugins/t/check_http.t (10) M plugins/t/check_imap.t (8) M plugins/t/check_jabber.t (6) M plugins/t/check_mysql.t (8) M plugins/t/check_mysql_query.t (2) M plugins/t/check_ntp.t (8) M plugins/t/check_ping.t (6) M plugins/t/check_pop.t (8) M plugins/t/check_smtp.t (10) M plugins/t/check_snmp.t (10) M plugins/t/check_ssh.t (6) M plugins/t/check_tcp.t (8) M plugins/t/check_time.t (6) M plugins/urlize.c (4) M plugins/utils.h (10) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1274.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1274.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1274 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jul 20 20:39:24 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Sun, 20 Jul 2014 11:39:24 -0700 Subject: Fix PATH_TO_QMAIL_QSTAT in configure (#1208) In-Reply-To: References: Message-ID: Maybe the same option should be usable for setting the path to `mailq` if `-M` is not `qmail`? -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1208#issuecomment-49555392 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jul 20 23:08:03 2014 From: notifications at github.com (awiddersheim) Date: Sun, 20 Jul 2014 14:08:03 -0700 Subject: Fix PATH_TO_QMAIL_QSTAT in configure (#1208) In-Reply-To: References: Message-ID: Just so I'm clear about what you are proposing... you want to add an option to `check_mailq` that allows you to specify the path when running the plugin? -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1208#issuecomment-49559619 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jul 20 23:18:38 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Sun, 20 Jul 2014 14:18:38 -0700 Subject: Fix PATH_TO_QMAIL_QSTAT in configure (#1208) In-Reply-To: References: Message-ID: Unless I'm missing something, `check_mailq` runs the command `qmail-qstat` if you're using `qmail`, and the command `mailq` if you're using another MTA. You added an option to specify the path to the `qmail-qstat` command; and I asked whether it would be possible to add a `--with-command` option instead. It would specify the path to the `qmail-qstat` command for `qmail` users and the path to `mailq` for users of other MTAs. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1208#issuecomment-49559885 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jul 20 23:19:51 2014 From: notifications at github.com (waja) Date: Sun, 20 Jul 2014 14:19:51 -0700 Subject: check_oracle: --tns bad string matching (#1191) In-Reply-To: References: Message-ID: Fixed in maint via d8b81e9ef3947a36e2647f4e54a63e3b259b103b -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1191#issuecomment-49559912 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jul 20 23:49:59 2014 From: notifications at github.com (awiddersheim) Date: Sun, 20 Jul 2014 14:49:59 -0700 Subject: Fix PATH_TO_QMAIL_QSTAT in configure (#1208) In-Reply-To: References: Message-ID: Thanks for the clarification. I personally like the idea of keeping them separate. That way if you are configuring the plugins for various systems that might be running either with `qmail-qstat` or `mailq` you can still configure the path to both separately. Hopefully, that makes sense. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1208#issuecomment-49560698 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jul 20 23:57:38 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Sun, 20 Jul 2014 14:57:38 -0700 Subject: Fix PATH_TO_QMAIL_QSTAT in configure (#1208) In-Reply-To: References: Message-ID: Heh, just ignore me. I was assuming we were talking about a runtime option. Next time I'll look at the diff before babbling nonsense, sorry. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1208#issuecomment-49560885 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 00:18:53 2014 From: notifications at github.com (waja) Date: Sun, 20 Jul 2014 15:18:53 -0700 Subject: check_hpjd: port option [sf#3123438] (#1160) In-Reply-To: References: Message-ID: Closed #1160 via 479509ad59cdb05894ab39206157e6dd3f4e7faf. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1160#event-143507723 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 00:18:53 2014 From: notifications at github.com (waja) Date: Sun, 20 Jul 2014 15:18:53 -0700 Subject: check_ntp_peer result message is unclear about reason for failure (#1236) In-Reply-To: References: Message-ID: Closed #1236 via 78d00d338a07ab0dd5ff052af96aab13a5ee93ae. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1236#event-143507722 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 00:18:53 2014 From: notifications at github.com (waja) Date: Sun, 20 Jul 2014 15:18:53 -0700 Subject: check_ifstatus: perfdata bug (#1169) In-Reply-To: References: Message-ID: Closed #1169 via 69b719aa2e3bd8dfd643d7cbe60e6e165d5279ea. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1169#event-143507724 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 00:33:56 2014 From: notifications at github.com (waja) Date: Sun, 20 Jul 2014 15:33:56 -0700 Subject: check_hpjd port option [sf#3123438] (#973) In-Reply-To: References: Message-ID: Fixed by #1160 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/973#issuecomment-49561907 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 00:33:57 2014 From: notifications at github.com (waja) Date: Sun, 20 Jul 2014 15:33:57 -0700 Subject: check_hpjd port option [sf#3123438] (#973) In-Reply-To: References: Message-ID: Closed #973. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/973#event-143509081 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 00:35:21 2014 From: notifications at github.com (waja) Date: Sun, 20 Jul 2014 15:35:21 -0700 Subject: check_ifstatus perfdata bug [sf#1767324] (#721) In-Reply-To: References: Message-ID: Fixed by #1169 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/721#issuecomment-49561935 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 00:35:21 2014 From: notifications at github.com (waja) Date: Sun, 20 Jul 2014 15:35:21 -0700 Subject: check_ifstatus perfdata bug [sf#1767324] (#721) In-Reply-To: References: Message-ID: Closed #721. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/721#event-143509189 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 01:28:45 2014 From: notifications at github.com (awiddersheim) Date: Sun, 20 Jul 2014 16:28:45 -0700 Subject: Fix PATH_TO_QMAIL_QSTAT in configure (#1208) In-Reply-To: References: Message-ID: No problem. Having a runtime option to specify paths for `check_mailq` might not be a bad idea as well. I think that was what you were suggesting. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1208#issuecomment-49563264 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 11:30:27 2014 From: notifications at github.com (waja) Date: Mon, 21 Jul 2014 02:30:27 -0700 Subject: sslutils: expire time in local timezone format (#1188) In-Reply-To: References: Message-ID: Should be fixed by #1161 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1188#issuecomment-49586515 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 11:33:04 2014 From: notifications at github.com (waja) Date: Mon, 21 Jul 2014 02:33:04 -0700 Subject: sslutils expire time in US format [sf#2424575] (#840) In-Reply-To: References: Message-ID: Should be fixed by #1161 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/840#issuecomment-49586712 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 11:42:18 2014 From: notifications at github.com (wferi) Date: Mon, 21 Jul 2014 02:42:18 -0700 Subject: Fix PATH_TO_QMAIL_QSTAT in configure (#1208) In-Reply-To: References: Message-ID: Speaking about MTA specific behavior: `exim4 -bpc` simply prints the number of messages in the queue, and is *much* more efficient than printing the message details by `mailq` (which is `exim4 -bp`) for just counting them. This can make a difference between a timeout and proper report when you have thousands of messages in the queue. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1208#issuecomment-49587389 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 12:07:49 2014 From: notifications at github.com (waja) Date: Mon, 21 Jul 2014 03:07:49 -0700 Subject: sslutils: expire time in local timezone format (#1188) In-Reply-To: References: Message-ID: > @@ -209,10 +210,8 @@ int np_net_ssl_check_cert(int days_till_exp_warn, int > days_till_exp_crit){ > > time_left = difftime(timegm(&stamp), time(NULL)); > days_left = time_left / 86400; > - snprintf > - (timestamp, 17, "%02d/%02d/%04d %02d:%02d", > - stamp.tm_mon + 1, > - stamp.tm_mday, stamp.tm_year + 1900, stamp.tm_hour, > stamp.tm_min); > + tm_t = mktime (&stamp); > + strftime(timestamp, 50, "%c", localtime(&tm_t)); seems to be in FreeBSD 1.0: "www.freebsd.org/cgi/man.cgi?query=strftime&apropos=0&sektion=3&manpath=FreeBSD+1.0-RELEASE&arch=default&format=html" -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1188/files#r15161634 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 12:34:02 2014 From: notifications at github.com (waja) Date: Mon, 21 Jul 2014 03:34:02 -0700 Subject: check_ntp_time: adding offset option (#1184) In-Reply-To: References: Message-ID: @skottler the problem was the THANKS.in ... this seems a common problem when trying to merge old PRs cause this file is conflicting. I updated the PR to match against latest master. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1184#issuecomment-49591164 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 13:40:32 2014 From: notifications at github.com (waja) Date: Mon, 21 Jul 2014 04:40:32 -0700 Subject: time in rtc 822 (#1161) In-Reply-To: References: Message-ID: Closed #1161 via 3bf812beaee7035b1c08e49b55d7962056931d7b. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1161#event-143644351 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 13:40:32 2014 From: notifications at github.com (waja) Date: Mon, 21 Jul 2014 04:40:32 -0700 Subject: print time in rfc 822 format [sf#3123940] (#975) In-Reply-To: References: Message-ID: Closed #975 via 3bf812beaee7035b1c08e49b55d7962056931d7b. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/975#event-143644354 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 13:40:32 2014 From: notifications at github.com (waja) Date: Mon, 21 Jul 2014 04:40:32 -0700 Subject: sslutils expire time in US format [sf#2424575] (#840) In-Reply-To: References: Message-ID: Closed #840 via 3bf812beaee7035b1c08e49b55d7962056931d7b. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/840#event-143644355 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 13:40:32 2014 From: notifications at github.com (waja) Date: Mon, 21 Jul 2014 04:40:32 -0700 Subject: check_http -C produces confusing date [sf#3142101] (#977) In-Reply-To: References: Message-ID: Closed #977 via 3bf812beaee7035b1c08e49b55d7962056931d7b. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/977#event-143644352 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 13:40:33 2014 From: notifications at github.com (waja) Date: Mon, 21 Jul 2014 04:40:33 -0700 Subject: check_http certificate date format i18n [sf#1096452] (#382) In-Reply-To: References: Message-ID: Closed #382 via 3bf812beaee7035b1c08e49b55d7962056931d7b. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/382#event-143644356 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 13:40:33 2014 From: notifications at github.com (waja) Date: Mon, 21 Jul 2014 04:40:33 -0700 Subject: check_http: clarify timestamp format for SSL cert expiry [sf#3140046] (#976) In-Reply-To: References: Message-ID: Closed #976 via 3bf812beaee7035b1c08e49b55d7962056931d7b. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/976#event-143644353 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 21:33:19 2014 From: notifications at github.com (waja) Date: Mon, 21 Jul 2014 12:33:19 -0700 Subject: plugins/tests/check_http.t (#1275) Message-ID: 3bf812beaee7035b1c08e49b55d7962056931d7b is breaking checks in plugins/tests/check_http.t see: https://api.travis-ci.org/jobs/30484847/log.txt?deansi=true -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1275 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 21 21:52:53 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Mon, 21 Jul 2014 12:52:53 -0700 Subject: plugins/tests/check_http.t failing (#1275) In-Reply-To: References: Message-ID: Closed #1275 via b785a770e4fbcdd6d11717eeb6eb00172eac4fb8. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1275#event-143862157 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 28 13:38:28 2014 From: notifications at github.com (Nick Peelman) Date: Mon, 28 Jul 2014 04:38:28 -0700 Subject: Add check_ifstatus option to ignore interfaces by name (#1276) Message-ID: Ignoring by index is not always an option, as the index can change on chassis switches as blade configurations change. Originally prompted in #47, requested changes made. You can merge this Pull Request by running: git pull https://github.com/peelman/nagios-plugins check_ifstatus-ignore-by-name Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1276 -- Commit Summary -- * Add check_ifstatus option to ignore interfaces by name -- File Changes -- M plugins-scripts/check_ifstatus.pl (93) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1276.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1276.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1276 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 28 22:25:12 2014 From: notifications at github.com (waja) Date: Mon, 28 Jul 2014 13:25:12 -0700 Subject: check_mysql: ignore authentication failure [sf#3408602] (#1020) In-Reply-To: References: Message-ID: Closed #1020 via 2e8d440e73ac2b1875db5ecaf6df510fdcf6eb7a. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1020#event-146430755 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 28 22:25:12 2014 From: notifications at github.com (waja) Date: Mon, 28 Jul 2014 13:25:12 -0700 Subject: check_mysql: ignore authentication failure (#1178) In-Reply-To: References: Message-ID: Closed #1178 via 2e8d440e73ac2b1875db5ecaf6df510fdcf6eb7a. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1178#event-146430756 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jul 28 23:20:00 2014 From: notifications at github.com (waja) Date: Mon, 28 Jul 2014 14:20:00 -0700 Subject: Np net connect verbose (#1277) Message-ID: This patch will add the IP and port, or socket name, to the error message and thus simplify the problem debugging: no need to check for this information in the Nagios configuration. This function is only used by 'check_tcp.c'. Without the patch: $ ./plugins/check_tcp -H 127.0.0.1 -p 21 Connection refused $ ./plugins/check_tcp -H /var/spool/nagios/cmd/nagios.cmd Permission denied With the patch: $ ./plugins/check_tcp -H 127.0.0.1 -p 21 connect to address 127.0.0.1 and port 21: Connection refused $ ./plugins/check_tcp -H /var/spool/nagios/cmd/nagios.cmd connect to socket /var/spool/nagios/cmd/nagios.cmd: Permission denied See https://github.com/nagios-plugins/nagios-plugins/pull/37 You can merge this Pull Request by running: git pull https://github.com/waja/monitoring-plugins np_net_connect_verbose Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1277 -- Commit Summary -- * This patch will add the IP and port, or socket name, to the error message and * netutils.c - A few more changes -- File Changes -- M plugins/netutils.c (15) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1277.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1277.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1277 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jul 29 10:34:46 2014 From: notifications at github.com (waja) Date: Tue, 29 Jul 2014 01:34:46 -0700 Subject: print subject name in certificate check (#1174) In-Reply-To: References: Message-ID: when testing against multiple domain certificates (where CN is not part of the cert but the hostnames are listed in the "Certificate Subject Alternative Names"-Extention): 2.0: "OK - Certificate 'Unknown CN' will expire on 12/16/2016 23:59." HEAD+#1174: "OK - Certificate '' will expire on Fri Dec 16 23:59:00 2016." -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1174#issuecomment-50449254 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jul 29 11:21:19 2014 From: notifications at github.com (waja) Date: Tue, 29 Jul 2014 02:21:19 -0700 Subject: Np net connect verbose (#1277) In-Reply-To: References: Message-ID: Closed #1277 via e85fcbd5711999af88ed887c0c17a26ab29f2b28. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1277#event-146629087 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jul 29 13:02:03 2014 From: notifications at github.com (waja) Date: Tue, 29 Jul 2014 04:02:03 -0700 Subject: print subject name in certificate check (#1174) In-Reply-To: References: Message-ID: > @@ -176,10 +177,15 @@ int np_net_ssl_check_cert(int days_till_exp_warn, > int days_till_exp_crit){ > /* Retrieve timestamp of certificate */ > tm = X509_get_notAfter(certificate); > > + /* Retrieve subject name in certificate. */ > + *subject = '\0'; > + X509_NAME_get_text_by_NID(X509_get_subject_name(certificate), > NID_commonName, subject, 256); shouldn't be the subject already stored in 'subj'? see https://github.com/monitoring-plugins/monitoring-plugins/blob/master/plugins/sslutils.c#L166 So we don't need to gather that once again. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1174/files#r15516933 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jul 29 14:41:20 2014 From: notifications at github.com (waja) Date: Tue, 29 Jul 2014 05:41:20 -0700 Subject: NTP Time Offset [sf#2864922] (#907) In-Reply-To: References: Message-ID: Closed #907 via 6f3d5825b203b75aef8d68bf0d117e7a1a4c0616. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/907#event-146692731 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jul 29 14:41:20 2014 From: notifications at github.com (waja) Date: Tue, 29 Jul 2014 05:41:20 -0700 Subject: check_ntp_time: adding offset option (#1184) In-Reply-To: References: Message-ID: Closed #1184 via 6f3d5825b203b75aef8d68bf0d117e7a1a4c0616. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1184#event-146692732 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jul 29 14:50:40 2014 From: notifications at github.com (waja) Date: Tue, 29 Jul 2014 05:50:40 -0700 Subject: Fix misleading timeout help [gh#1206] (#1209) In-Reply-To: References: Message-ID: Closed #1209. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1209#event-146696125 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jul 29 14:50:40 2014 From: notifications at github.com (waja) Date: Tue, 29 Jul 2014 05:50:40 -0700 Subject: Fix misleading timeout help [gh#1206] (#1209) In-Reply-To: References: Message-ID: fixed with 80e506a2f72b66dee5c607b4dd42b26f505762dd -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1209#issuecomment-50471456 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jul 29 14:50:53 2014 From: notifications at github.com (waja) Date: Tue, 29 Jul 2014 05:50:53 -0700 Subject: Misleading wording around timeouts [gh#1206] (#1206) In-Reply-To: References: Message-ID: fixed with 80e506a2f72b66dee5c607b4dd42b26f505762dd -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1206#issuecomment-50471482 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jul 29 14:50:54 2014 From: notifications at github.com (waja) Date: Tue, 29 Jul 2014 05:50:54 -0700 Subject: Misleading wording around timeouts [gh#1206] (#1206) In-Reply-To: References: Message-ID: Closed #1206. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1206#event-146696208 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 11:28:09 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 02:28:09 -0700 Subject: Warning fixes (#1227) In-Reply-To: References: Message-ID: the latter patch was merged by 82033b35b162c1b8a64a4b8be36c1c9c87ef9555 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1227#issuecomment-50592921 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 11:39:56 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 02:39:56 -0700 Subject: check_dns returns incorrect state when specifying server [sf#2946553] (#982) In-Reply-To: References: Message-ID: This seems to be an issue of nslookup there ... on a recent RHEL: rhel5:~/monitoring-plugins [0]markus [PR681] $ cat /etc/redhat-release Red Hat Enterprise Linux Server release 5.10 (Tikanga) rhel5:~/monitoring-plugins [0]markus [PR681] $ nslookup www.rm.com 1.1.1.1 ;; connection timed out; trying next origin ;; connection timed out; no servers could be reached -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/982#issuecomment-50593983 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 11:40:36 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 02:40:36 -0700 Subject: check_dns - server matching, fix bug id 2946553 [sf#3163584] (#981) In-Reply-To: References: Message-ID: Closed #981. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/981#event-147127093 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 11:45:41 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 02:45:41 -0700 Subject: check_dns returns incorrect state when specifying server [sf#2946553] (#982) In-Reply-To: References: Message-ID: The real problem is, that we should check if the answer which nslookup is returning is originated by the dns server we asked. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/982#issuecomment-50594497 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 14:52:44 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 05:52:44 -0700 Subject: lib/utils_base.c: if asprintf fails, string is undefined (#1278) Message-ID: if asprintf fails, string content becomes invalid. we need to check if it ran OK by checking the returned value. in case of fail, asprintf returns -1, otherwise the number of writen bytes is returned. also, on ubuntu 13.10 i've receiving a lot of warnings: "warning: ignoring return value of ?asprintf?" this patches fixes some of them Signed-off-by: Ricardo Maraschini <ricardo.maraschini at gmail.com> --- Closes #1227 You can merge this Pull Request by running: git pull https://github.com/waja/monitoring-plugins github1227 Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1278 -- Commit Summary -- * lib/utils_base.c: if asprintf fails, string is undefined -- File Changes -- M lib/utils_base.c (15) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1278.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1278.diff --- Reply to this email directly or view it on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1278 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 14:55:44 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 05:55:44 -0700 Subject: lib/utils_base.c: if asprintf fails, string is undefined (#1278) In-Reply-To: References: Message-ID: This should superseed #1278 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1278#issuecomment-50610021 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 15:01:42 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 06:01:42 -0700 Subject: Remaining use of asprintf (#1279) Message-ID: $ rgrep asprintf . | grep -v xasprintf | grep -v xvasprintf | grep -v ^./gl | grep -v ^./.git Binary file ./.git/index matches ./plugins/check_snmp.c: die(STATE_UNKNOWN,_("Cannot asprintf()")); ./plugins/check_http.c: /* NOTE: After this if/else block msg *MUST* be an asprintf-allocated string */ ./plugins/check_pgsql.c: asprintf (&conninfo, "%s ", pgparams); ./plugins/check_pgsql.c: asprintf (&conninfo, "%sdbname = '%s'", conninfo ? conninfo : "", dbName); ./plugins/check_pgsql.c: asprintf (&conninfo, "%s host = '%s'", conninfo, pghost); ./plugins/check_pgsql.c: asprintf (&conninfo, "%s port = '%s'", conninfo, pgport); ./plugins/check_pgsql.c: asprintf (&conninfo, "%s options = '%s'", conninfo, pgoptions); ./plugins/check_pgsql.c: asprintf (&conninfo, "%s user = '%s'", conninfo, pguser); ./plugins/check_pgsql.c: asprintf (&conninfo, "%s password = '%s'", conninfo, pgpasswd); ./plugins/check_pgsql.c: asprintf (&pgparams, "%s %s", pgparams, optarg); ./plugins/check_pgsql.c: asprintf (&pgparams, "%s", optarg); ./plugins/utils.c: * asprintf, but die on failure ./plugins/utils.c: int result = vasprintf (strp, fmt, ap); ./lib/tests/test_ini1.c: asprintf(&optstr, ""); ./lib/tests/test_ini1.c: asprintf(&optstr, "%s%s ", optstr, optlst->arg); ./lib/tests/test_cmd.c: asprintf (&cmd, " %s", line[i++]); ./lib/tests/test_cmd.c: asprintf (&cmd, "%s %s", cmd, line[i]); ./lib/parse_ini.c: if ((asprintf(&ini_file, "%s/%s", dir, *file)) < 0) ./po/Makevars:XGETTEXT_OPTIONS = --keyword=_ --keyword=N_ --flag=error:3:c-format --flag=error_at_line:5:c-format --flag=asprintf:2:c-format --flag=vasprintf:2:c-format ./po/fr.po:msgid "Cannot asprintf()" ./po/de.po:msgid "Cannot asprintf()" ./po/monitoring-plugins.pot:msgid "Cannot asprintf()" ./tap/tap.c: vasprintf(&local_test_name, test_name, ap); ./tap/tap.c: } else { /* vasprintf() failed, use a fixed message */ ./tap/tap.c: point. If it's NULL then asprintf() failed, and we should ./tap/tap.c: asprintf(&skip_msg, fmt, ap); ./tap/tap.c: vasprintf(&todo_msg, fmt, ap); -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1279 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 15:30:32 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 06:30:32 -0700 Subject: check_dig: Add support for drill tool (#1281) Message-ID: Superseding #1218 You can merge this Pull Request by running: git pull https://github.com/waja/monitoring-plugins github1218 Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1281 -- Commit Summary -- * check_dig: Fix to work with dig and drill tool * check_dig: takes into account the -4 and -6 switch * Adding Alexander Wittig to THANKS.in -- File Changes -- M THANKS.in (1) M plugins/check_dig.c (9) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1281.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1281.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1281 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 15:34:21 2014 From: notifications at github.com (Sven Nierlein) Date: Wed, 30 Jul 2014 06:34:21 -0700 Subject: Fix generate change log (#1280) In-Reply-To: References: Message-ID: Merged #1280. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1280#event-147204082 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 15:45:37 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 06:45:37 -0700 Subject: check_dig: Add support for drill tool (#1281) In-Reply-To: References: Message-ID: Merged #1281. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1281#event-147208971 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 15:45:38 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 06:45:38 -0700 Subject: check_dig: Add support for drill tool to (#1218) In-Reply-To: References: Message-ID: Closed #1218 via f28dc3ba200b0e7a59f9a4157a3d83f73fa1071b. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1218#event-147208972 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 15:59:35 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 06:59:35 -0700 Subject: check_disk: show troubled partition in verbose mode (#1182) In-Reply-To: References: Message-ID: Needs to be tested against a real fs. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1182#issuecomment-50617781 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 18:59:31 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 09:59:31 -0700 Subject: check_nwstat: adds percentage used space (#1183) In-Reply-To: References: Message-ID: he @skottler, you may have seen that I just pulled the patches committed over there on SF into PRs, mostly they may not changed/reworked yet. As we can't contact the authors of those directly, as the old project on SF is locked, I guess we need to polish them for our own, if we want to catch them. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1183#issuecomment-50646159 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 20:57:36 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 11:57:36 -0700 Subject: check_tcp: Implement STARTTLS logic (#1282) Message-ID: Right from https://github.com/monitoring-plugins/monitoring-plugins/pull/1195#issuecomment-33554590: I noticed is that for straight up SSL services, check_http certificate check works! Makes me think the check should actually be implemented in check_tcp for all SSL protocols. Then once we get there, what prevent us form adding just the required logic in check_tcp to implement the STARTTLS certificate checks for every other STARTTLS-cabaple protocol? -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1282 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 20:58:53 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 11:58:53 -0700 Subject: check_tcp: Implement STARTTLS logic (#1282) In-Reply-To: References: Message-ID: check_ldap: #1195 and #1067 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1282#issuecomment-50663105 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 21:12:51 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 12:12:51 -0700 Subject: check_icmp: use packet reception time to compute rtt (#1232) In-Reply-To: References: Message-ID: How portable is this code? SO_TIMESTAMP is not available on *BSD/OSX nor on Windows. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1232#issuecomment-50664959 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 21:28:33 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 12:28:33 -0700 Subject: Warning fixes (#1227) In-Reply-To: References: Message-ID: Closed #1227 via #1278. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1227#event-147384273 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 21:28:33 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 12:28:33 -0700 Subject: lib/utils_base.c: if asprintf fails, string is undefined (#1278) In-Reply-To: References: Message-ID: Merged #1278. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1278#event-147384274 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 30 23:26:18 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 14:26:18 -0700 Subject: Fix PATH_TO_QMAIL_QSTAT in configure (#1208) In-Reply-To: References: Message-ID: @wferi maybe you would like to create another PR for your suggestion? Many thanks! -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1208#issuecomment-50682335 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jul 31 00:07:23 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 15:07:23 -0700 Subject: check_dns: returns incorrect state when specifying server (#1164) In-Reply-To: References: Message-ID: Merged #1164. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1164#event-147459857 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jul 31 00:07:24 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 15:07:24 -0700 Subject: check_disk: show troubled partition in verbose mode (#1182) In-Reply-To: References: Message-ID: Merged #1182. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1182#event-147459861 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jul 31 00:07:25 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 15:07:25 -0700 Subject: Allow check_disk to identify the troubled partition [sf#3165076] (#984) In-Reply-To: References: Message-ID: Closed #984 via cbb507c89feebf2fc46a6341584de0c730ecf458. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/984#event-147459865 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jul 31 00:07:25 2014 From: notifications at github.com (waja) Date: Wed, 30 Jul 2014 15:07:25 -0700 Subject: check_dns returns incorrect state when specifying server [sf#2946553] (#982) In-Reply-To: References: Message-ID: Closed #982 via d0da78ced184197b29af9fe910aaf56a9e7fe762. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/982#event-147459866 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jul 31 00:19:24 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Wed, 30 Jul 2014 15:19:24 -0700 Subject: Fix PATH_TO_QMAIL_QSTAT in configure (#1208) In-Reply-To: References: Message-ID: Applied, thanks. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1208#issuecomment-50688345 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jul 31 00:19:24 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Wed, 30 Jul 2014 15:19:24 -0700 Subject: Fix PATH_TO_QMAIL_QSTAT in configure (#1208) In-Reply-To: References: Message-ID: Closed #1208. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1208#event-147464161 -------------- next part -------------- An HTML attachment was scrubbed... URL: From mikelhansen2000 at gmail.com Thu Jul 31 06:05:13 2014 From: mikelhansen2000 at gmail.com (Mike Hansen) Date: Wed, 30 Jul 2014 21:05:13 -0700 Subject: Fix PATH_TO_QMAIL_QSTAT in configure (#1208) In-Reply-To: References: Message-ID: unsubscribe please. On Wed, Jul 30, 2014 at 2:26 PM, waja wrote: > @wferi maybe you would like to create another > PR for your suggestion? Many thanks! > > ? > Reply to this email on GitHub > > . > -- Thanks, Mike Hansen, AE7SN 1178 Townhouse Circle, Apt. C Gardnerville, NV 89410 775-783-8916 (Home) 406-451-6615 (Cell) MikeLHansen2000 at gmail.com *No trees were killed in the sending of this message, but a large number of electrons were terribly inconvenienced.* -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jul 31 08:30:11 2014 From: notifications at github.com (Matthieu Kermagoret) Date: Wed, 30 Jul 2014 23:30:11 -0700 Subject: check_icmp: use packet reception time to compute rtt (#1232) In-Reply-To: References: Message-ID: Indeed this is Linux specific. However the code using SO_TIMESTAMP is protected with ifdef/endif and will not impact platforms that do not have it (besides the change from sendto() to sendmsg()). -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1232#issuecomment-50718311 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jul 31 22:38:03 2014 From: notifications at github.com (Rob Thomas) Date: Thu, 31 Jul 2014 13:38:03 -0700 Subject: Update spec file (#1283) Message-ID: This is a complete rewrite of the spec file. I've removed a lot of the legacy AIX code, as it'll never be used. I've also removed a lot of the install requirements, because people don't need to have - eg, - postgresql libraries installed if all they want to check is mysql. You can merge this Pull Request by running: git pull https://github.com/xrobau/monitoring-plugins update-spec-file Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1283 -- Commit Summary -- * Update spec file -- File Changes -- M monitoring-plugins.spec.in (265) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1283.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1283.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1283 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jul 31 22:42:40 2014 From: notifications at github.com (Rob Thomas) Date: Thu, 31 Jul 2014 13:42:40 -0700 Subject: Update spec file (#1283) In-Reply-To: References: Message-ID: Resolves issue #1273 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1283#issuecomment-50815668 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jul 31 22:43:20 2014 From: notifications at github.com (Sam Kottler) Date: Thu, 31 Jul 2014 13:43:20 -0700 Subject: Update spec file (#1283) In-Reply-To: References: Message-ID: Thanks for the PR! I'll take a look at it tonight. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1283#issuecomment-50815748 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jul 31 22:54:32 2014 From: notifications at github.com (waja) Date: Thu, 31 Jul 2014 13:54:32 -0700 Subject: monitoring-plugins.spec.in: Needs some love (#1273) In-Reply-To: References: Message-ID: We have a PR for this in https://github.com/monitoring-plugins/monitoring-plugins/pull/1283 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1273#issuecomment-50817178 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jul 31 23:00:11 2014 From: notifications at github.com (Sven Nierlein) Date: Thu, 31 Jul 2014 14:00:11 -0700 Subject: Update spec file (#1283) In-Reply-To: References: Message-ID: > Name: monitoring-plugins > Version: @PACKAGE_VERSION@ > Release: @RELEASE@ > -Summary: Host/service/network monitoring program plugins for Nagios and > compatible > - > +Summary: Host/service/network monitoring program plugins for > Sensu/Icinga/Nagios etc.. maybe we should mention shinken and naemon too or stay with "nagios compatible" -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1283/files#r15669537 -------------- next part -------------- An HTML attachment was scrubbed... URL: From nathan.vonnahme at bannerhealth.com Thu Jul 31 23:14:05 2014 From: nathan.vonnahme at bannerhealth.com (Vonnahme, Nathan) Date: Thu, 31 Jul 2014 13:14:05 -0800 Subject: Update spec file (#1283) In-Reply-To: References: Message-ID: <4438E9AD19D31044BDBD63937F86BF89169219CBDF@FAI01400.bhs.bannerhealth.com> That looks like a good place to list all of them for basic SEO in the often limited package search tools. From: Devel [mailto:devel-bounces+nathan.vonnahme=bannerhealth.com at monitoring-plugins.org] On Behalf Of Sven Nierlein Sent: Thursday, July 31, 2014 1:00 PM To: Monitoring Plugins Development Subject: Re: Update spec file (#1283) In monitoring-plugins.spec.in: > Name: monitoring-plugins > Version: @PACKAGE_VERSION@ > Release: @RELEASE@ > -Summary: Host/service/network monitoring program plugins for Nagios and compatible > - > +Summary: Host/service/network monitoring program plugins for Sensu/Icinga/Nagios etc.. maybe we should mention shinken and naemon too or stay with "nagios compatible" ? Reply to this email on GitHub. -------------- next part -------------- An HTML attachment was scrubbed... URL: