From notifications at github.com Wed Jun 11 11:14:22 2014 From: notifications at github.com (horihel) Date: Wed, 11 Jun 2014 02:14:22 -0700 Subject: check_oracle command line arguments not quoted (#1258) Message-ID: check_oracle uses "naked" arguments ($1 $2) which causes special characters to be interpreted by the shell. Especially this causes check_oracle to fail if you use a full TNS description as a SID because it contains parentheses. Putting Quotes around those parameters fixes the problem. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1258 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jun 12 00:07:57 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Wed, 11 Jun 2014 15:07:57 -0700 Subject: monitoring-plugins-1.5 fails to build with gnutls (#1254) In-Reply-To: References: Message-ID: Closed #1254 via 083952c426a250eaf6810b3b22e7555e4aeb3f2d. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1254#event-130477709 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jun 12 09:32:02 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Thu, 12 Jun 2014 00:32:02 -0700 Subject: Failing test cases (#1259) Message-ID: Some [tests](https://www.monitoring-plugins.org/tests.html) are currently failing. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1259 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Jun 14 22:04:02 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Sat, 14 Jun 2014 13:04:02 -0700 Subject: potential issues related to Extra-Opts, and to State Retention (#1249) In-Reply-To: References: Message-ID: JFTR: State retention should be okay, Thomas fixed this in 68fe713335183dd37ced78821711c2a3f1ea2cc7 (and *we* currently don't use it in setuid plugins anyway). -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1249#issuecomment-46098168 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 16 14:29:18 2014 From: notifications at github.com (basak) Date: Mon, 16 Jun 2014 05:29:18 -0700 Subject: check_apt: also check for HWE EOL status (#1260) In-Reply-To: References: Message-ID: We want to backport this patch to nagios-plugins in Ubuntu 12.04, so that users using a 12.04 HWE package get the notification. I understand that you will need to review this in your own time. This is time-critical for us due to our EOL schedule for our existing HWE packages. I'm also behind on our schedule (my fault). If you need some time to review, I can push this patch into 12.04 anyway and do something else for the master branch and future releases, but I'd prefer to adopt any changes you want both in this master branch and in our backport. So even if you can't complete a full review immediately, I'd appreciate any early feedback you can provide. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1260#issuecomment-46171951 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 16 14:31:24 2014 From: notifications at github.com (basak) Date: Mon, 16 Jun 2014 05:31:24 -0700 Subject: check_apt: also check for HWE EOL status (#1260) In-Reply-To: References: Message-ID: Hmm. It worked on my backport! I'll look into the CI failure; any suggestions appreciated. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1260#issuecomment-46172128 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jun 18 10:50:24 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Wed, 18 Jun 2014 01:50:24 -0700 Subject: Failing test cases (#1259) In-Reply-To: References: Message-ID: Thanks to Sven, the tests are fine again. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1259#issuecomment-46410603 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jun 18 10:50:27 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Wed, 18 Jun 2014 01:50:27 -0700 Subject: Failing test cases (#1259) In-Reply-To: References: Message-ID: Closed #1259. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1259#event-132543753 -------------- next part -------------- An HTML attachment was scrubbed... URL: From holger at zedat.fu-berlin.de Wed Jun 18 10:51:54 2014 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Wed, 18 Jun 2014 10:51:54 +0200 Subject: Extra-Opts configuration file location(s) Message-ID: <20140618085154.GV461143@zedat.fu-berlin.de> In the upcoming Monitoring Plugins release, the Extra-Opts feature will be enabled by default. See: https://www.monitoring-plugins.org/doc/extra-opts.html The configuration file used by that feature can be specified on the command line or via an environment variable. If neither is done, a list of default locations is searched. I'd like to change the environment variable used for this purpose: Currently, NAGIOS_CONFIG_PATH can be set to a colon-separated list of directories to be searched. I think that's overkill and would prefer an MP_CONFIG_FILE variable that points to a single file path instead. If nobody objects, I'll update the code and documentation accordingly. Either way, we'll continue to support NAGIOS_CONFIG_PATH for compatibility, at least for a while. Holger From michael.friedrich at gmail.com Wed Jun 18 10:56:52 2014 From: michael.friedrich at gmail.com (Michael Friedrich) Date: Wed, 18 Jun 2014 10:56:52 +0200 Subject: Extra-Opts configuration file location(s) In-Reply-To: <20140618085154.GV461143@zedat.fu-berlin.de> References: <20140618085154.GV461143@zedat.fu-berlin.de> Message-ID: <53A15454.3050808@gmail.com> On 18.06.2014 10:51, Holger Wei? wrote: > In the upcoming Monitoring Plugins release, the Extra-Opts feature will > be enabled by default. See: > > https://www.monitoring-plugins.org/doc/extra-opts.html > > The configuration file used by that feature can be specified on the > command line or via an environment variable. If neither is done, a list > of default locations is searched. > > I'd like to change the environment variable used for this purpose: > Currently, NAGIOS_CONFIG_PATH can be set to a colon-separated list of > directories to be searched. I think that's overkill and would prefer an > MP_CONFIG_FILE variable that points to a single file path instead. If > nobody objects, I'll update the code and documentation accordingly. > Either way, we'll continue to support NAGIOS_CONFIG_PATH for > compatibility, at least for a while. +1 go for it. every hardcoded string pointing to nagios will confuse users. and it certainly is time to forget about nagios. -- DI (FH) Michael Friedrich michael.friedrich at gmail.com || icinga open source monitoring https://twitter.com/dnsmichi || lead core developer dnsmichi at jabber.ccc.de || https://www.icinga.org/team irc.freenode.net/icinga || dnsmichi From holger at zedat.fu-berlin.de Wed Jun 18 12:15:30 2014 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Wed, 18 Jun 2014 12:15:30 +0200 Subject: Extra-Opts configuration file location(s) In-Reply-To: <20140618085154.GV461143@zedat.fu-berlin.de> References: <20140618085154.GV461143@zedat.fu-berlin.de> Message-ID: <20140618101530.GW461143@zedat.fu-berlin.de> * Holger Wei? [2014-06-18 10:51]: > In the upcoming Monitoring Plugins release, the Extra-Opts feature will > be enabled by default. See: > > https://www.monitoring-plugins.org/doc/extra-opts.html > > The configuration file used by that feature can be specified on the > command line or via an environment variable. If neither is done, a list > of default locations is searched. And what about these default locations? Is everyone fine with the following two path names? - /usr/local/etc/monitoring-plugins.ini - /etc/monitoring-plugins.ini Or shall we also support subdirectories? E.g.: - /usr/local/etc/monitoring-plugins/monitoring-plugins.ini - /etc/monitoring-plugins/monitoring-plugins.ini Or would be prefer a different file extension (such as ".cfg" or ".conf")? Holger From michael.friedrich at gmail.com Wed Jun 18 12:35:00 2014 From: michael.friedrich at gmail.com (Michael Friedrich) Date: Wed, 18 Jun 2014 12:35:00 +0200 Subject: Extra-Opts configuration file location(s) In-Reply-To: <20140618101530.GW461143@zedat.fu-berlin.de> References: <20140618085154.GV461143@zedat.fu-berlin.de> <20140618101530.GW461143@zedat.fu-berlin.de> Message-ID: <53A16B54.2000805@gmail.com> On 18.06.2014 12:15, Holger Wei? wrote: > * Holger Wei? [2014-06-18 10:51]: >> In the upcoming Monitoring Plugins release, the Extra-Opts feature will >> be enabled by default. See: >> >> https://www.monitoring-plugins.org/doc/extra-opts.html >> >> The configuration file used by that feature can be specified on the >> command line or via an environment variable. If neither is done, a list >> of default locations is searched. > > And what about these default locations? Is everyone fine with the > following two path names? > > - /usr/local/etc/monitoring-plugins.ini > - /etc/monitoring-plugins.ini > > Or shall we also support subdirectories? E.g.: > > - /usr/local/etc/monitoring-plugins/monitoring-plugins.ini > - /etc/monitoring-plugins/monitoring-plugins.ini Please, use sub dirs. That will be a default for packages, and you would like to support them as well out of the box (source compile shouldn't happen these days if there are well maintained packages). > > Or would be prefer a different file extension (such as ".cfg" or > ".conf")? *.cfg reminds users of native nagios/icinga 1.x object config *.conf is a common default for apache, and also icinga 2 is the format real ini-parsable? then name it like so. icinga web 2 also uses ini files, and they preserve that suffix. kind regards, michael -- DI (FH) Michael Friedrich michael.friedrich at gmail.com || icinga open source monitoring https://twitter.com/dnsmichi || lead core developer dnsmichi at jabber.ccc.de || https://www.icinga.org/team irc.freenode.net/icinga || dnsmichi From notifications at github.com Wed Jun 18 13:12:54 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Wed, 18 Jun 2014 04:12:54 -0700 Subject: fix the path names (s/nagios/monitoring/) (#1248) In-Reply-To: References: Message-ID: Closed #1248. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1248#event-132588252 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jun 18 13:12:54 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Wed, 18 Jun 2014 04:12:54 -0700 Subject: fix the path names (s/nagios/monitoring/) (#1248) In-Reply-To: References: Message-ID: Done, as documented on . -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1248#issuecomment-46422484 -------------- next part -------------- An HTML attachment was scrubbed... URL: From holger at zedat.fu-berlin.de Wed Jun 18 15:06:40 2014 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Wed, 18 Jun 2014 15:06:40 +0200 Subject: Extra-Opts configuration file location(s) In-Reply-To: <53A16B54.2000805@gmail.com> References: <20140618085154.GV461143@zedat.fu-berlin.de> <20140618101530.GW461143@zedat.fu-berlin.de> <53A16B54.2000805@gmail.com> Message-ID: <20140618130640.GY461143@zedat.fu-berlin.de> * Michael Friedrich [2014-06-18 12:35]: > On 18.06.2014 12:15, Holger Wei? wrote: > > And what about these default locations? Is everyone fine with the > > following two path names? > > > > - /usr/local/etc/monitoring-plugins.ini > > - /etc/monitoring-plugins.ini > > > > Or shall we also support subdirectories? E.g.: > > > > - /usr/local/etc/monitoring-plugins/monitoring-plugins.ini > > - /etc/monitoring-plugins/monitoring-plugins.ini > > Please, use sub dirs. That will be a default for packages, and you would > like to support them as well out of the box (source compile shouldn't > happen these days if there are well maintained packages). I've added those two path names to the list of locations to search. Thanks for your feedback! Holger From william at leibzon.org Wed Jun 18 15:56:21 2014 From: william at leibzon.org (William Leibzon) Date: Wed, 18 Jun 2014 06:56:21 -0700 Subject: Extra-Opts configuration file location(s) In-Reply-To: <20140618101530.GW461143@zedat.fu-berlin.de> References: <20140618085154.GV461143@zedat.fu-berlin.de> <20140618101530.GW461143@zedat.fu-berlin.de> Message-ID: Different distributions have different criteria for set of paths and extensions for config files. But I'd go with: /etc/monitoring-plugins/monitoring-plugins.ini /usr/local/etc/monitoring-plugins/monitoring-plugins.ini Because distributions typically don't mind packages having their own subdirectory in /etc. And some prefer that and create one even if original package would just put config file in /etc. And the most popular extension in unix world for config files is .conf after that its .cfg and .ini is least popular. You can check your own distributions to see if its something like that. But since we already went with .ini that is fine as far as I'm concerned. On Wed, Jun 18, 2014 at 3:15 AM, Holger Wei? wrote: > * Holger Wei? [2014-06-18 10:51]: >> In the upcoming Monitoring Plugins release, the Extra-Opts feature will >> be enabled by default. See: >> >> https://www.monitoring-plugins.org/doc/extra-opts.html >> >> The configuration file used by that feature can be specified on the >> command line or via an environment variable. If neither is done, a list >> of default locations is searched. > > And what about these default locations? Is everyone fine with the > following two path names? > > - /usr/local/etc/monitoring-plugins.ini > - /etc/monitoring-plugins.ini > > Or shall we also support subdirectories? E.g.: > > - /usr/local/etc/monitoring-plugins/monitoring-plugins.ini > - /etc/monitoring-plugins/monitoring-plugins.ini > > Or would be prefer a different file extension (such as ".cfg" or > ".conf")? > > Holger From holger at zedat.fu-berlin.de Wed Jun 18 19:20:55 2014 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Wed, 18 Jun 2014 19:20:55 +0200 Subject: Extra-Opts configuration file location(s) In-Reply-To: References: <20140618085154.GV461143@zedat.fu-berlin.de> <20140618101530.GW461143@zedat.fu-berlin.de> Message-ID: <20140618172055.GZ461143@zedat.fu-berlin.de> * William Leibzon [2014-06-18 06:56]: > Different distributions have different criteria for set of paths and > extensions for config files. > > But I'd go with: > /etc/monitoring-plugins/monitoring-plugins.ini > /usr/local/etc/monitoring-plugins/monitoring-plugins.ini > > Because distributions typically don't mind packages having their own > subdirectory in /etc. And some prefer that and create one even if > original package would just put config file in /etc. Yes, I've added those two paths to the list. So we now have: - /usr/local/etc/monitoring-plugins/monitoring-plugins.ini - /usr/local/etc/monitoring-plugins.ini - /etc/monitoring-plugins/monitoring-plugins.ini - /etc/monitoring-plugins.ini (Plus the old locations supported for compatibility.) > And the most popular extension in unix world for config files is .conf > after that its .cfg and .ini is least popular. You can check your own > distributions to see if its something like that. But since we already > went with .ini that is fine as far as I'm concerned. Fine with me, too. Thanks, Holger From robie.basak at ubuntu.com Thu Jun 19 15:54:52 2014 From: robie.basak at ubuntu.com (Robie Basak) Date: Thu, 19 Jun 2014 14:54:52 +0100 Subject: check_apt's future Message-ID: <20140619135452.GX17765@mal.justgohome.co.uk> Hi, (I looked to include the nagios-plugins fork in this email also, but was unable to find a suitable mailing list) For people following the Ubuntu Server list, note that this relates to our nagios-plugins source package. I submitted https://github.com/monitoring-plugins/monitoring-plugins/pull/1260 a few days ago. Since then there has been some discussion on IRC, and I am wondering where to go from here, wearing my Ubuntu hat. Before I address the pull request itself and its implications, I'd first like to talk about check_apt maintenance from a wider perspective. A bigger issue is that check_apt has gone unmaintained for a while. The main issue for Ubuntu is this bug: https://bugs.launchpad.net/ubuntu/+source/nagios-plugins/+bug/1031680 This affects two successive LTS releases of Ubuntu, with no fix on the horizon. The problem is the fundamental mechanism used to detect updates, which (inadvertently) makes assumptions about pockets. Since Ubuntu has separate -updates and -security pockets, check_apt fails to differentiate between regular and security updates correctly, since apt may choose to install a security update from an -updates pocket. I think we're all agreed that the solution is to replace check_apt entirely with a new code base. Ubuntu already ships a tool with the update-manager-common package in /usr/lib/update-notifier/apt-check. This does pretty much exactly the right thing, except that its CLI is different to the expected standard for monitoring tools. In the bug, Simon D?ziel has kindly written and published a replacement shell wrapper that just calls apt-check for the required information. He has provided it with a liberal license. As far as I can see, this does exactly the right thing. From a distribution perspective, this is perfect since it's a simple, tiny and easy to review shell wrapper, and only has a direct dependency on update-manager-common, which in Ubuntu anyway. I understand that this is not suitable for upstream monitoring-plugins since it's written in shell and uses python-apt, and you have a policy of accepting C and Perl only. I also understand that as a consequence you want check_apt rewritten in C and to use libpkg-apt directly. But nobody has stepped up to do this work in two years, and there seems to be little point in this (from a distribution perspective) since an alternative is already available. Finally, with my pull request, I understand that you had some reservations in accepting the patch, since it's distribution-specific. But check_apt itself is distribution specific. So what I'd like to propose is: 1. Remove check_apt from the upstream codebase entirely, since it's broken and unmaintained. Upstream will then not have to maintain the broken plugin any more. If in the future it gets rewritten to your standards, then it could be reintroduced easily enough. 1b. If you don't want to do this, then I'd like to consider removing check_apt in an Ubuntu-specific patch, since it's broken on Ubuntu and may mislead users into believing that their systems are up-to-date security-wise. 1c. For Debian, I guess it's up to Jan. He could do what we do (below), or patch check_apt back in, since the bug doesn't quite affect Debian in the same way. At least this way, distribution-specific stuff can stay in a distribution-specific place, which I think is what upstream want? 2. Recommend use of Simon's replacement instead. I can put this into Ubuntu's release notes. 3. Consider hosting Simon's replacement in some package in the distribution. Then you won't have to worry about maintaining distribution-specific upstream. For Ubuntu, maybe we could shove Simon's code into update-manager-common, to go side-by-side with check-apt itself. For Debian, it might make sense to move check-apt and Simon's code into a package elsewhere (and for Ubuntu to follow suit). As far as I can see the only dependency these two scripts have are on python-apt, so I think should be straightforward if we can decide where it should go. 3b. Or perhaps I should patch Simon's replacement into our nagios-plugins source package? I would definitely not want to name it check_apt to prevent confusion of course. With this being a new file, there would be no upstream to have to maintain the patch against, so there shouldn't be much of a maintenance burden for me here. 4. If we do make Simon's code available in-distro, then we can update our recommendation to point users to it. Next I'd like to address my pull request. The issue here is that there's a higher level distribution thing going on here, that is at a layer in the stack higher than apt. So "check_apt" itself is a bit of a misnomer; what would be more useful for users is "check_for_distro_updates", IYSWIM, and I hope you can consider this in any check_apt rewrite. If you decline the pull request for this reason, then I'm reluctant to introduce a distribution patch for this functionality. It'll make the maintenance situation worse than it is right now, could confuse users because of a difference in behaviour between upstream and the distribution package, and additionally get in the way of user support because you won't necessarily be able to tell easily if a user's issue is due to the distribution patch or not. And check_apt is expected to be rewritten at some point, which clearly will break any distribution patch. So I don't want to have to deal with this a second time when that happens. Instead, I'd prefer to start with Simon's code, agree where distributions should place it, rename it to "check_distro_updates" or something, and then start patching that to alert with additional non-apt update notifications. For the immediate situation with Ubuntu HWE EOL notifications then, once we remove check_apt from our development release nagios-plugins package, then we can still choose to backport my pull request to Precise and to Trusty as a one-off, without having to worry about any future maintenance burden. Future notifications can take place through the check_distro_updates replacement. How does this all sound? I'm particularly interested in: 1) Upstream's view on removing check_apt. 2) Simon's view on us recommending his code, or incorporating it in-distro. 3) Michael's view on maybe putting Simon's wrapper into update-manager-common, or moving apt-check out of update-manager. 4) Jan's view on the Debian perspective here. 5) Any other comments, from anyone? Thanks, Robie -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: From notifications at github.com Sat Jun 21 15:19:06 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Sat, 21 Jun 2014 06:19:06 -0700 Subject: potential issues related to Extra-Opts, and to State Retention (#1249) In-Reply-To: References: Message-ID: Fixed in 48025ff39c3a78b7805bf803ac96730cef53e15c (and other commits). -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1249#issuecomment-46753496 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Jun 21 15:19:06 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Sat, 21 Jun 2014 06:19:06 -0700 Subject: potential issues related to Extra-Opts, and to State Retention (#1249) In-Reply-To: References: Message-ID: Closed #1249. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1249#event-133791345 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 22 21:49:23 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Sun, 22 Jun 2014 12:49:23 -0700 Subject: check_radius: please support FreeRADIUS client library (#1231) In-Reply-To: References: Message-ID: Closed #1231 via c0311d98481b783f1d24dd6c59fe25ce994a090d. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1231#event-133897988 -------------- next part -------------- An HTML attachment was scrubbed... URL: From holger at zedat.fu-berlin.de Sun Jun 22 22:22:30 2014 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Sun, 22 Jun 2014 22:22:30 +0200 Subject: New release planned Message-ID: <20140622202230.GA365434@zedat.fu-berlin.de> We'd like to cut a Monitoring Plugins release really soon now. If you could spare a bit of time to test the current snapshot? and report any regressions from the 1.5 release, that would be great! Holger ? https://www.monitoring-plugins.org/download/snapshot/monitoring-plugins-master.tar.gz From simon.deziel at gmail.com Sun Jun 22 22:36:51 2014 From: simon.deziel at gmail.com (Simon Deziel) Date: Sun, 22 Jun 2014 16:36:51 -0400 Subject: check_apt's future In-Reply-To: <20140619135452.GX17765@mal.justgohome.co.uk> References: <20140619135452.GX17765@mal.justgohome.co.uk> Message-ID: <53A73E63.2010805@gmail.com> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 14-06-19 09:54 AM, Robie Basak wrote: > 2) Simon's view on us recommending his code, or incorporating it > in-distro. I'm OK with both alternatives. Thanks, Simon -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQJ8BAEBCgBmBQJTpz5iXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ1NjVDMzc0QUZCQUQyRkM2MjBDNkMxQkI3 MkZFMERBRTkwMEIyQzM0AAoJEHL+Da6QCyw0QrsP/jukjPZHtvzbAgsgmb3RLkr+ xkubzSJLKu1e3XM+pQBzin4aSHffVoGOYTV8++LFu60oqFgNmSHDAIVgegw2YTUj Pl0BY9MBiXVLhj7uP6lWzR4t87j/iylkvux98UWWGESBXMqe98/+ToprTc+sO+0t klltu3fF09tCR7kKzCMbeMgP48XjLMhcAPYr+XIYRpK8SuwpDIBdGiDj4jZCRkov YH6g/1ToUM9FN1sYgBIJ0S8yoK05Gc63/DnR0mt8h62MRbedvXhy+VSB8lmxuwNw KdYWXRezB1eMAer0tudQlR7Qqv6HMpksNPiNeayaat4S5T2vNSM33wn3r0Ss0n5q AGHfMPeC9VevDK5jkIVZZrqJbX12+9Xd81eQO/EB7tHB7lciQt73ytjSxDXT/zXw i8Hs9MyJKVtunIxeU4DrEiiu/RZhKzWAIR2D2RfzzoqSioaKh3e3rzAaWMinhMXL 1CQxNDrvyhiCCYgAEYs/l+tXwU825ysSY+YWYcI49jZhCwIrfIPvHWwqvSs0nCOK IvmICyGa+3IzGAEyiFYOM3gyHQp3lOE/LMmcHlWVcLExvD9kCNEgsZGiuTy6EsCe owI2KAKmiI5aqULRCXwmSFUqP4BRGmw+fEJzKcvGe/1LVRKzEo23yJNbA93XkYv8 9sz07Tiba5HjPM0ld+oI =jFFx -----END PGP SIGNATURE----- From notifications at github.com Mon Jun 23 16:19:27 2014 From: notifications at github.com (waja) Date: Mon, 23 Jun 2014 07:19:27 -0700 Subject: check_http: Fix for checking http on different virtual port [sf#3442015] (#1026) In-Reply-To: References: Message-ID: Closed #1026. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1026#event-134109559 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 23 16:19:27 2014 From: notifications at github.com (waja) Date: Mon, 23 Jun 2014 07:19:27 -0700 Subject: check_http: Fix for checking http on different virtual port [sf#3442015] (#1026) In-Reply-To: References: Message-ID: This seems to work with the lastest stable release (1.5): $ /usr/lib/nagios/plugins/check_http -I 127.0.0.1 -p 8888 -H 'domain.org:80' -v | head -4 GET / HTTP/1.1 User-Agent: check_http/v1.5 (nagios-plugins 1.5) Connection: close Host: domain.org:80 So I'm closing this issue. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1026#issuecomment-46850782 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 23 16:20:00 2014 From: notifications at github.com (waja) Date: Mon, 23 Jun 2014 07:20:00 -0700 Subject: check_http: Fix for checking http on different virtual port (#1175) In-Reply-To: References: Message-ID: As #1026 is closed, we can close this too. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1175#issuecomment-46850843 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 23 16:20:00 2014 From: notifications at github.com (waja) Date: Mon, 23 Jun 2014 07:20:00 -0700 Subject: check_http: Fix for checking http on different virtual port (#1175) In-Reply-To: References: Message-ID: Closed #1175. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1175#event-134109855 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jun 24 15:08:26 2014 From: notifications at github.com (Sven Nierlein) Date: Tue, 24 Jun 2014 06:08:26 -0700 Subject: tests: always build and test on travis (#1261) Message-ID: also make test is now working on travis-ci Signed-off-by: Sven Nierlein <sven at nierlein.de> You can merge this Pull Request by running: git pull https://github.com/sni/monitoring-plugins master Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1261 -- Commit Summary -- * tests: always build and test on travis -- File Changes -- M .travis.yml (12) A plugins/t/NPTest.cache.travis (54) M plugins/t/check_ntp.t (10) M plugins/t/check_snmp.t (2) M plugins/t/check_udp.t (2) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1261.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1261.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1261 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jun 24 15:08:43 2014 From: notifications at github.com (Sven Nierlein) Date: Tue, 24 Jun 2014 06:08:43 -0700 Subject: tests: always build and test on travis (#1261) In-Reply-To: References: Message-ID: Merged #1261. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1261#event-134538091 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jun 24 16:02:51 2014 From: notifications at github.com (Sam Kottler) Date: Tue, 24 Jun 2014 07:02:51 -0700 Subject: tests: always build and test on travis (#1261) In-Reply-To: References: Message-ID: We should probably also enable build status on pull requests. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1261#issuecomment-46974363 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jun 24 16:04:52 2014 From: notifications at github.com (Sven Nierlein) Date: Tue, 24 Jun 2014 07:04:52 -0700 Subject: tests: always build and test on travis (#1261) In-Reply-To: References: Message-ID: they are enabled already, see: https://travis-ci.org/monitoring-plugins/monitoring-plugins/pull_requests -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1261#issuecomment-46974751 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jun 24 16:07:01 2014 From: notifications at github.com (Sam Kottler) Date: Tue, 24 Jun 2014 07:07:01 -0700 Subject: tests: always build and test on travis (#1261) In-Reply-To: References: Message-ID: @sni ah perfect! I just didn't see the build status in this PR's status section. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1261#issuecomment-46975043 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jun 24 16:08:13 2014 From: notifications at github.com (Sven Nierlein) Date: Tue, 24 Jun 2014 07:08:13 -0700 Subject: tests: always build and test on travis (#1261) In-Reply-To: References: Message-ID: maybe because its closed already. The other open pull requests have a travis button. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1261#issuecomment-46975213 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jun 24 16:10:45 2014 From: notifications at github.com (Sam Kottler) Date: Tue, 24 Jun 2014 07:10:45 -0700 Subject: tests: always build and test on travis (#1261) In-Reply-To: References: Message-ID: Yep, probably because it's closed. Sorry for the noise. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1261#issuecomment-46975554 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Jun 24 16:11:30 2014 From: notifications at github.com (Sven Nierlein) Date: Tue, 24 Jun 2014 07:11:30 -0700 Subject: tests: always build and test on travis (#1261) In-Reply-To: References: Message-ID: no problem, thanks for having a look :-) -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1261#issuecomment-46975646 -------------- next part -------------- An HTML attachment was scrubbed... URL: From stu at spacehopper.org Wed Jun 25 21:54:13 2014 From: stu at spacehopper.org (Stuart Henderson) Date: Wed, 25 Jun 2014 19:54:13 +0000 (UTC) Subject: New release planned References: <20140622202230.GA365434@zedat.fu-berlin.de> Message-ID: On 2014-06-22, Holger Wei? wrote: > We'd like to cut a Monitoring Plugins release really soon now. If you > could spare a bit of time to test the current snapshot? and report any > regressions from the 1.5 release, that would be great! > > Holger > > ? https://www.monitoring-plugins.org/download/snapshot/monitoring-plugins-master.tar.gz > Not new, but while testing on OpenBSD I noticed this: netutils.c: In function 'np_net_connect': netutils.c:237: warning: array size (104) smaller than bound length (108) netutils.c:237: warning: array size (104) smaller than bound length (108) ... coming from netutils.h: #ifdef HAVE_SYS_UN_H # include # ifndef UNIX_PATH_MAX /* linux uses this, on sun it's hard-coded at 108 without a define */ # define UNIX_PATH_MAX 108 # endif /* UNIX_PATH_MAX */ #endif /* HAVE_SYS_UN_H */ Seems it's hard-coded at 104 in sys/un.h on at least (Free|Net|Open)BSD, Dragonfly and Apple. http://fxr.watson.org/fxr/search?string=sun_path From waja at cyconet.org Sat Jun 28 10:30:07 2014 From: waja at cyconet.org (Jan Wagner) Date: Sat, 28 Jun 2014 10:30:07 +0200 Subject: New release planned In-Reply-To: <20140622202230.GA365434@zedat.fu-berlin.de> References: <20140622202230.GA365434@zedat.fu-berlin.de> Message-ID: <53AE7D0F.6010404@cyconet.org> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 22.06.14 22:22, schrieb Holger Wei?: > We'd like to cut a Monitoring Plugins release really soon now. If > you could spare a bit of time to test the current snapshot? and > report any regressions from the 1.5 release, that would be great! Please be so kind and report your issue here: https://github.com/monitoring-plugins/monitoring-plugins/issues/new Thanks, Jan. - -- Never write mail to , you have been warned! - -----BEGIN GEEK CODE BLOCK----- Version: 3.12 GIT d-- s+: a C+++ UL++++ P+ L+++ E--- W+++ N+++ o++ K++ w--- O M V- PS PE Y++ PGP++ t-- 5 X R tv- b+ DI D+ G++ e++ h---- r+++ y++++ - ------END GEEK CODE BLOCK------ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (Darwin) Comment: GPGTools - http://gpgtools.org iQIcBAEBAgAGBQJTrn0PAAoJEAxwVXtaBlE+vW0P/2alPphfEU6ex6YzUnoChnAa vW8SPJZ1yGZj34raRZsciv5meU4VTIJq+1LD+NnAsNefLy9cM+XpQnyG0egO2gfz /G1yjBhZV/4lY+To0xM3hfAFN9I4SSCQuZ8NrmYSxWEXfJJkNw7+PPUH5yNGf49H TxY0nfvbwDWB3JD1tsiH+n9IXPloTXrqNR0Sy+OuwDgCkm5N27lpvqRTK3YVgyDV dR6JiQAhKFjtQUnKxSO5fBFLUhturqSnkJu8NMy004r+E8Rq9Vfo+OueIzb9Rhpv EbTGpDMh4QQbiskLN+KSVLc6In9huYSey15eEZxBSNkX0iwVIOkHhip6wH0VffHm qe/IaY3gYtfV0zLiBTf08sEyd6L98zSlLjQud1EWRfgRE9i8ic+aiFJLZzvyIhRA oX6VX6MQ0IphdOApCo7o+UN/0VQoOEnoXvwhYNIQnlVkNqTOhTvCvGHnbMKcyjSc eDWcneT3697xvgpZS/FZYnck0eHwBBEgAPw4K9FGTMhpSjmC8mEfKoAG7oahZ5GR bh7l6wwmzhq6vTYeAUpwOGuDq3RbxAhIN2fXcjpLdCkhicFvsuv2KTggEoREvhfF HFh9vPGMH3cpylpBOnooOJDTZ+RWtsosokytNAF/UT+SKK2O1iVZE/lbIQSohEno VtCU04+dt1HWh5UF6qKJ =/zbZ -----END PGP SIGNATURE----- From waja at cyconet.org Sat Jun 28 10:32:43 2014 From: waja at cyconet.org (Jan Wagner) Date: Sat, 28 Jun 2014 10:32:43 +0200 Subject: New release planned In-Reply-To: References: <20140622202230.GA365434@zedat.fu-berlin.de> Message-ID: <53AE7DAB.4070405@cyconet.org> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Stuart, thanks for bringing up this issue. Am 25.06.14 21:54, schrieb Stuart Henderson: > Not new, but while testing on OpenBSD I noticed this: > > netutils.c: In function 'np_net_connect': netutils.c:237: warning: > array size (104) smaller than bound length (108) netutils.c:237: > warning: array size (104) smaller than bound length (108) > > ... coming from netutils.h: > > #ifdef HAVE_SYS_UN_H # include # ifndef UNIX_PATH_MAX /* > linux uses this, on sun it's hard-coded at 108 without a define */ > # define UNIX_PATH_MAX 108 # endif /* UNIX_PATH_MAX */ #endif /* > HAVE_SYS_UN_H */ > > Seems it's hard-coded at 104 in sys/un.h on at least > (Free|Net|Open)BSD, Dragonfly and Apple. > > http://fxr.watson.org/fxr/search?string=sun_path Could you please put that into an issue at: https://github.com/monitoring-plugins/monitoring-plugins/issues/new This makes follow up and further communication much easier. Many thanks, Jan. - -- Never write mail to , you have been warned! - -----BEGIN GEEK CODE BLOCK----- Version: 3.12 GIT d-- s+: a C+++ UL++++ P+ L+++ E--- W+++ N+++ o++ K++ w--- O M V- PS PE Y++ PGP++ t-- 5 X R tv- b+ DI D+ G++ e++ h---- r+++ y++++ - ------END GEEK CODE BLOCK------ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (Darwin) Comment: GPGTools - http://gpgtools.org iQIcBAEBAgAGBQJTrn2rAAoJEAxwVXtaBlE+0WcP/0sTixCvHWjZckv7LPHMeLx5 qsaW0LHJKXrCa+OISMk9qf50dTVpOL/6EjRrGadwDi3F+zy/B0odW36ANRSfKg3W iNHgdRiR7gbw68EFa0xuA4Ll8eMCVSqEBEezlN+kycQjXP8AIgCOi15PZK/0HWQI 4FO/qePcZJPYY3UtJ5i+rXpbUgYMwJletqG2lp1yF0XdTo7i4GXkygtOSDQTl5Q/ OFKREuw8KpZAmQQj8EW5OmZqtGzO+XKbUXkyK4XDFxvyYqt4WB/VRbuGBFnodygW xhXip1Wah403VfPJy3ZZxH/1IQPXGxNoTyNrLLo4573Kyg7GroLoq3wlAkYyjeLT gYKEf+Wc5YMx5S7fe42bJiWOeN6ClQR5iWypFzGxU18Yj9P8b5N0XQJuY9tjYtnU 6W2L3K/bNzEOzgGfxQKab65B6VE3X36iH7dlgNeQhuJz7M6okxRcMYZdmboi7SDp qP+MHaSlm7lZPGXsYRrquhT9y5bvBTIDX/eTl/mzUGpex4X5it/ICAQCqQh4g5E9 vMAVWFgAWmcmxMTD4OQfSK+Yi1h07lic8pdpSatEJuYC9hmMEZkoLfs73myzepY8 qdvQQmrVtJmFxsI6yUDrbAZcHkkDmRdiOEaAvZ633Vhfup2g7vJkPHOvByDUSV1f nC9adaYfROq9IjcBLM8V =+XKe -----END PGP SIGNATURE----- From notifications at github.com Sat Jun 28 18:11:58 2014 From: notifications at github.com (waja) Date: Sat, 28 Jun 2014 09:11:58 -0700 Subject: Include common.h before any system headers. (#1262) Message-ID: This should fix some problems building on AIX. (as addressed ovethere in n-p: https://github.com/nagios-plugins/nagios-plugins/commit/b9c764fb4f3d977c9e36a088ca127356f3cfc820) You can merge this Pull Request by running: git pull https://github.com/waja/monitoring-plugins fix_aix Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1262 -- Commit Summary -- * Include common.h before any system headers. -- File Changes -- M plugins/check_tcp.c (3) M plugins/negate.c (4) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1262.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1262.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1262 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Jun 28 18:29:14 2014 From: notifications at github.com (waja) Date: Sat, 28 Jun 2014 09:29:14 -0700 Subject: Serveral coverity fixes from from nagios-plugins (#1263) Message-ID: You can merge this Pull Request by running: git pull https://github.com/waja/monitoring-plugins coverity_fixes Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1263 -- Commit Summary -- * plugins/check_apt.c - Print uninitialized ereg * plugins/check_real.c - recv string null terminate * plugins/check_ntp.c - Verify struct from response * plugins/check_http.c - leakage fix * plugins-root/check_dhcp.c - array out of bounds * plugins/negate.c - Reorder if statement, aiob * plugins/negate.c - Function should not return. * lib/utils_cmd.c - Free file descriptor -- File Changes -- M lib/utils_cmd.c (3) M plugins-root/check_dhcp.c (2) M plugins/check_apt.c (3) M plugins/check_http.c (10) M plugins/check_ntp.c (13) M plugins/check_real.c (1) M plugins/negate.c (7) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1263.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1263.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1263 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Jun 28 20:15:40 2014 From: notifications at github.com (waja) Date: Sat, 28 Jun 2014 11:15:40 -0700 Subject: check_nt.c - Changed 'Mb' to 'MB' in MEMUSE. (#1264) Message-ID: taken from https://github.com/nagios-plugins/nagios-plugins/commit/5d3cf6b78894583580e3eaf855e4607ee0b7b7ce You can merge this Pull Request by running: git pull https://github.com/waja/monitoring-plugins check_nt_units Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1264 -- Commit Summary -- * check_nt.c - Changed 'Mb' to 'MB' in MEMUSE. -- File Changes -- M plugins/check_nt.c (4) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1264.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1264.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1264 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Jun 28 21:06:01 2014 From: notifications at github.com (waja) Date: Sat, 28 Jun 2014 12:06:01 -0700 Subject: check_tcp: also display the server addr when host_specified is set. This... (#1265) Message-ID: ... will help the admins when multiple checks are configured Signed-off-by: Davide Madrisan <davide.madrisan at gmail.com> You can merge this Pull Request by running: git pull https://github.com/waja/monitoring-plugins check_tcp_server_addr Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1265 -- Commit Summary -- * check_tcp: also display the server addr when host_specified is set. This will help the admins when multiple checks are configured -- File Changes -- M plugins/check_tcp.c (9) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1265.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1265.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1265 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Jun 28 21:34:05 2014 From: notifications at github.com (waja) Date: Sat, 28 Jun 2014 12:34:05 -0700 Subject: Check dns perf threshold (#1266) Message-ID: Taken from https://github.com/jccomputing/nagios-plugins/compare/3ad067c7c537e27f1b7ed7660dd6a17abbacfe86...086e8e1aa3d27a37a51123061e5ba1689471476c You can merge this Pull Request by running: git pull https://github.com/waja/monitoring-plugins check_dns_perf_threshold Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1266 -- Commit Summary -- * check_dns: add warning and critical thresholds to perfdata * check_dns.c Added a bit more logic to thresholds -- File Changes -- M plugins/check_dns.c (18) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1266.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1266.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1266 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Jun 28 22:07:11 2014 From: notifications at github.com (Sven Nierlein) Date: Sat, 28 Jun 2014 13:07:11 -0700 Subject: Check dns perf threshold (#1266) In-Reply-To: References: Message-ID: Closed #1266. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1266#event-136205478 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Jun 28 22:07:11 2014 From: notifications at github.com (Sven Nierlein) Date: Sat, 28 Jun 2014 13:07:11 -0700 Subject: Check dns perf threshold (#1266) In-Reply-To: References: Message-ID: merged -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1266#issuecomment-47437131 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Jun 28 22:13:14 2014 From: notifications at github.com (waja) Date: Sat, 28 Jun 2014 13:13:14 -0700 Subject: check_tcp: also display the server addr when host_specified is set. This... (#1265) In-Reply-To: References: Message-ID: Tests regex needs to be adjusted here -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1265#issuecomment-47437299 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Jun 28 22:13:26 2014 From: notifications at github.com (waja) Date: Sat, 28 Jun 2014 13:13:26 -0700 Subject: check_tcp: also display the server addr when host_specified is set. This... (#1265) In-Reply-To: References: Message-ID: Tests regex needs to be adjusted here -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1265#issuecomment-47437308 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Jun 28 22:14:04 2014 From: notifications at github.com (Sven Nierlein) Date: Sat, 28 Jun 2014 13:14:04 -0700 Subject: Serveral coverity fixes from nagios-plugins (#1263) In-Reply-To: References: Message-ID: Merged #1263. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1263#event-136205964 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Jun 28 22:14:09 2014 From: notifications at github.com (Sven Nierlein) Date: Sat, 28 Jun 2014 13:14:09 -0700 Subject: Serveral coverity fixes from nagios-plugins (#1263) In-Reply-To: References: Message-ID: thanks, merged -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1263#issuecomment-47437322 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Jun 28 22:23:06 2014 From: notifications at github.com (Sven Nierlein) Date: Sat, 28 Jun 2014 13:23:06 -0700 Subject: check_nt.c - Changed 'Mb' to 'MB' in MEMUSE. (#1264) In-Reply-To: References: Message-ID: Merged #1264. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1264#event-136206623 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Jun 28 22:28:19 2014 From: notifications at github.com (Sven Nierlein) Date: Sat, 28 Jun 2014 13:28:19 -0700 Subject: check_ssh: check protocol (#1190) In-Reply-To: References: Message-ID: nice patch, but why should the plugin exit with warning? I would opt for critical. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1190#issuecomment-47437649 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Jun 28 22:35:27 2014 From: notifications at github.com (waja) Date: Sat, 28 Jun 2014 13:35:27 -0700 Subject: check_ntp_peer - Added specific state output for each metric. It now sho... (#1239) In-Reply-To: References: Message-ID: Thanks @abrist, I updated the PR. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1239#issuecomment-47437846 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Jun 28 22:51:19 2014 From: notifications at github.com (waja) Date: Sat, 28 Jun 2014 13:51:19 -0700 Subject: check_ssh: check protocol (#1190) In-Reply-To: References: Message-ID: Cause it depends in view? Critical is something like out of service or such? ;) -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1190#issuecomment-47438196 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 29 00:59:27 2014 From: notifications at github.com (Stuart Henderson) Date: Sat, 28 Jun 2014 15:59:27 -0700 Subject: UNIX_PATH_MAX too large for *BSD (#1267) Message-ID: On OpenBSD: ``` netutils.c: In function 'np_net_connect': netutils.c:237: warning: array size (104) smaller than bound length (108) netutils.c:237: warning: array size (104) smaller than bound length (108) ``` This uses UNIX_PATH_MAX from the macro defined in netutils.h: ``` #ifdef HAVE_SYS_UN_H # include # ifndef UNIX_PATH_MAX /* linux uses this, on sun it's hard-coded at 108 without a define */ # define UNIX_PATH_MAX 108 # endif /* UNIX_PATH_MAX */ #endif /* HAVE_SYS_UN_H */ ``` On at least (Free|Net|Open)BSD, Dragonfly and Apple this is hard-coded at 104 bytes, see http://fxr.watson.org/fxr/search?string=sun_path -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1267 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 29 10:54:15 2014 From: notifications at github.com (Sven Nierlein) Date: Sun, 29 Jun 2014 01:54:15 -0700 Subject: check_ssh: check protocol (#1190) In-Reply-To: References: Message-ID: depends, if you explicitly request a specific protocol version but get a different response, then i'd expect the check to be critical. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1190#issuecomment-47449153 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jun 29 20:55:02 2014 From: notifications at github.com (waja) Date: Sun, 29 Jun 2014 11:55:02 -0700 Subject: check_ssh: check protocol (#1190) In-Reply-To: References: Message-ID: Indeed, that's a good point. I adjusted the PR to exit with CRITICAL. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1190#issuecomment-47467688 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 30 11:43:00 2014 From: notifications at github.com (Sven Nierlein) Date: Mon, 30 Jun 2014 02:43:00 -0700 Subject: check_ssh: check protocol (#1190) In-Reply-To: References: Message-ID: almost :-) it still prints "SSH WARNING" -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1190#issuecomment-47512921 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 30 12:25:10 2014 From: notifications at github.com (waja) Date: Mon, 30 Jun 2014 03:25:10 -0700 Subject: check_ssh: check protocol (#1190) In-Reply-To: References: Message-ID: *lol* Did I? %) -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1190#issuecomment-47516331 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 30 13:42:03 2014 From: notifications at github.com (Sven Nierlein) Date: Mon, 30 Jun 2014 04:42:03 -0700 Subject: check_ssh: check protocol (#1190) In-Reply-To: References: Message-ID: Merged #1190. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1190#event-136464877 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 30 13:42:04 2014 From: notifications at github.com (Sven Nierlein) Date: Mon, 30 Jun 2014 04:42:04 -0700 Subject: check_ssh protocol check [sf#1899981] (#780) In-Reply-To: References: Message-ID: Closed #780 via #1190. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/780#event-136464876 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 30 14:57:55 2014 From: notifications at github.com (Sven Nierlein) Date: Mon, 30 Jun 2014 05:57:55 -0700 Subject: check_ssh: change warning to critical for protocal/version errors (#1268) Message-ID: It makes more sense to exit critical if a explicit version/protocol is requested. This would also be more consistent with other plugins. Other string matching plugins like check_snmp or check_http exit critical if the result does not match. Signed-off-by: Sven Nierlein <sven at nierlein.de> You can merge this Pull Request by running: git pull https://github.com/sni/monitoring-plugins check_ssh_critical Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1268 -- Commit Summary -- * check_ssh: change warning to critical for protocal/version errors -- File Changes -- M plugins/check_ssh.c (12) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1268.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1268.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1268 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Jun 30 15:15:28 2014 From: notifications at github.com (waja) Date: Mon, 30 Jun 2014 06:15:28 -0700 Subject: check_tcp: also display the server addr when host_specified is set. This... (#1265) In-Reply-To: References: Message-ID: Merged #1265. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1265#event-136493703 -------------- next part -------------- An HTML attachment was scrubbed... URL: