From notifications at github.com Mon Nov 3 03:42:56 2014 From: notifications at github.com (Bobzikwick) Date: Sun, 02 Nov 2014 18:42:56 -0800 Subject: Fix perfdata to comply with perfdata UOM definition. See https://nagios-... (#1296) Message-ID: ...plugins.org/doc/guidelines.html You can merge this Pull Request by running: git pull https://github.com/Bobzikwick/monitoring-plugins master Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1296 -- Commit Summary -- * Fix perfdata to comply with perfdata UOM definition. See https://nagios-plugins.org/doc/guidelines.html -- File Changes -- M plugins/check_mrtgtraf.c (14) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1296.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1296.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1296 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Nov 17 23:08:41 2014 From: notifications at github.com (nafets) Date: Mon, 17 Nov 2014 14:08:41 -0800 Subject: added option to exit with an warning, if there is output on STDERR (#1297) Message-ID: We need the option to bail out with an error, if there is something on stdout. E.g. someone is defining: ``` stty erase ^H ``` without any checks in the users profile (.bashrc or .profile) You can merge this Pull Request by running: git pull https://github.com/nafets/monitoring-plugins master Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1297 -- Commit Summary -- * added option to exit with an warning, if there is output on STDERR -- File Changes -- M plugins/check_by_ssh.c (14) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1297.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1297.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1297 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Nov 19 20:09:24 2014 From: notifications at github.com (nafets) Date: Wed, 19 Nov 2014 11:09:24 -0800 Subject: Segfault (#1298) Message-ID: On some systems the admin has set no ulimit, this ends up in a segfault You can merge this Pull Request by running: git pull https://github.com/nafets/monitoring-plugins segfault Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1298 -- Commit Summary -- * added option to exit with an warning, if there is output on STDERR * avoid segfault, if ulimit is not set * Revert "avoid segfault, if ulimit is not set", should be done in a branch * avoid a segfault, if ulimit is set to unlimited * Revert "added option to exit with an warning, if there is output on STDERR" -- File Changes -- M lib/utils_cmd.c (9) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1298.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1298.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1298 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Nov 19 20:15:31 2014 From: notifications at github.com (nafets) Date: Wed, 19 Nov 2014 11:15:31 -0800 Subject: added option to exit with an warning, if there is output on STDERR (#1297) In-Reply-To: References: Message-ID: cleanup with the branches -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1297#issuecomment-63695886 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Nov 19 20:16:01 2014 From: notifications at github.com (nafets) Date: Wed, 19 Nov 2014 11:16:01 -0800 Subject: Exit on stderr (#1299) Message-ID: We need the option to bail out with an error, if there is something on stdout. E.g. someone is defining: ``` stty erase ^H ``` without any checks in the users profile (.bashrc or .profile) Sorry for the GIT hussle You can merge this Pull Request by running: git pull https://github.com/nafets/monitoring-plugins exit_on_stderr Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1299 -- Commit Summary -- * added option to exit with an warning, if there is output on STDERR * avoid segfault, if ulimit is not set * Revert "avoid segfault, if ulimit is not set", should be done in a branch -- File Changes -- M plugins/check_by_ssh.c (14) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1299.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1299.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1299 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Nov 19 21:29:09 2014 From: notifications at github.com (wferi) Date: Wed, 19 Nov 2014 12:29:09 -0800 Subject: Exit on stderr (#1299) In-Reply-To: References: Message-ID: Why didn't you just drop the back-and-forth commit pair (concerning a segfault) before generating the pull request? Also, the commit message should state which component is changed, and elaborate a little on the problem and the method of the fix. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1299#issuecomment-63707817 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Nov 19 21:34:56 2014 From: notifications at github.com (wferi) Date: Wed, 19 Nov 2014 12:34:56 -0800 Subject: Segfault (#1298) In-Reply-To: References: Message-ID: Please fix your git blunders before creating pull requests, it does not make much sense to propagate them. If you need help, I recommend #git on Freenode, but we may also be able to help to some extent. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1298#issuecomment-63708689 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Nov 19 21:40:38 2014 From: notifications at github.com (John Dyer) Date: Wed, 19 Nov 2014 12:40:38 -0800 Subject: Segfault (#1298) In-Reply-To: References: Message-ID: ![Be nice](http://www.washingtonpost.com/blogs/answer-sheet/files/2013/05/just-be-nice.jpg) -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1298#issuecomment-63709515 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Nov 19 22:49:05 2014 From: notifications at github.com (nafets) Date: Wed, 19 Nov 2014 13:49:05 -0800 Subject: Exit on stderr (#1299) In-Reply-To: References: Message-ID: you are right, I'll clean up this pull request -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1299#issuecomment-63720234 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Nov 19 22:49:05 2014 From: notifications at github.com (nafets) Date: Wed, 19 Nov 2014 13:49:05 -0800 Subject: Exit on stderr (#1299) In-Reply-To: References: Message-ID: Closed #1299. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1299#event-195805285 -------------- next part -------------- An HTML attachment was scrubbed... URL: From holger at zedat.fu-berlin.de Fri Nov 21 17:03:15 2014 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Fri, 21 Nov 2014 17:03:15 +0100 Subject: Next Friday: Bug squashing sprint Message-ID: <20141121160315.GJ8814@zedat.fu-berlin.de> Hi there! I met up with Sven and Jan during the OSMC? in Nuremberg, and we decided to have a "bug squashing sprint" on Friday, Nov. 28th. The idea is to tackle a number of pull requests and bug reports in a joint effort, as that will be more fun than doing it all alone. Our main communication channel will be the #monitoring-plugins IRC room on freenode. Anyone interested is welcome to join us! Development skills aren't required: Things like categorizing issues, testing fixes, and digging up entertaining xkcd comics will help a lot. We're looking forward to meet you on Friday! Holger ? http://www.netways.de/en/osmc/osmc_2014/ From holger at zedat.fu-berlin.de Wed Nov 26 23:58:41 2014 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Wed, 26 Nov 2014 23:58:41 +0100 Subject: [PATCH] check_apt: fix memset In-Reply-To: <20141126235100.0000546e@localhost> References: <20141126235100.0000546e@localhost> Message-ID: <20141126225841.GF470467@zedat.fu-berlin.de> * Sebastian Herbszt [2014-11-26 23:51]: > Fix memset introduced by commit 9ce7369 ("plugins/check_apt.c - Print > uninitialized ereg"). Applied, thanks! Holger From basel.gozem at nakisa.com Wed Nov 19 22:43:38 2014 From: basel.gozem at nakisa.com (Basel Gozem) Date: Wed, 19 Nov 2014 21:43:38 +0000 Subject: Ping Threshold change Message-ID: <79C529F1CB33EE4D9FD66B887DB0F95901A5569F96@Exchange6.hq1.nakisa.net> Hi, I changed the ping Threshold as follows in the hosts.cfg file for one host only: check_command check_ping!150.0,20%!500.0,60% but I still get the warning alert e-mail at warning level: 100 ms although I have changed it to 150ms Here is a smaple from the alert: State: WARNING Date/Time: Wed Nov 19 16:00:03 EST 2014 Additional Info: PING WARNING - Packet loss = 0%, RTA = 100.77 ms Any idea would be greatly appreciated. Basel. -------------- next part -------------- An HTML attachment was scrubbed... URL: From Oliver.Skibbe at mdkn.de Wed Nov 26 10:15:24 2014 From: Oliver.Skibbe at mdkn.de (Skibbe, Oliver) Date: Wed, 26 Nov 2014 09:15:24 +0000 Subject: Patch for check_by_ssh - Add option to force pseudo tty allocation Message-ID: <2E1938054F08DB4492C8049E07785223050F5C82@ex1.NDS.MDKN.DE> Hey, because i've needed a pseudo tty for running sudo via ssh, i created a small patch for check_by_ssh It introduces a new option "-z" which adds -t Force pseudo-tty allocation. This can be used to execute arbitrary screen-based programs on a remote machine, which can be very useful, e.g. when implementing menu services. Multiple -t options force tty allocation, even if ssh has no local tty. While using this new option, you have to set -E because on STDERR appears: Connection to $IP closed. Maybe there is a better way to surpress this message but i'm not this deep in C. Let me know if you're interested. Mit freundlichem Gru? Oliver Skibbe Medizinischer Dienst der Krankenversicherung Niedersachsen | MDKN Gesch?ftsbereich Zentrale Dienste Informationstechnologie Oliver Skibbe Systemadministrator Hildesheimer Stra?e 202-206 30519 Hannover Tel: +49 (0) 511 8785 4321 Oliver.Skibbe at mdkn.de | http://www.mdk-niedersachsen.de ________________________________ Diese E-Mail enth?lt vertrauliche und/oder rechtlich gesch?tzte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrt?mlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet. This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden. -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: check_by_ssh_force-tty.patch Type: application/octet-stream Size: 2518 bytes Desc: check_by_ssh_force-tty.patch URL: From Oliver.Skibbe at mdkn.de Wed Nov 26 10:34:23 2014 From: Oliver.Skibbe at mdkn.de (Skibbe, Oliver) Date: Wed, 26 Nov 2014 09:34:23 +0000 Subject: AW: Patch for check_by_ssh - Add option to force pseudo tty allocation Message-ID: <2E1938054F08DB4492C8049E07785223050F5ECC@ex1.NDS.MDKN.DE> I created a pull request for this patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1303 Best regards Oliver Skibbe Medizinischer Dienst der Krankenversicherung Niedersachsen | MDKN Gesch?ftsbereich Zentrale Dienste Informationstechnologie Oliver Skibbe Systemadministrator Hildesheimer Stra?e 202-206 30519 Hannover Tel: +49 (0) 511 8785 4321 Oliver.Skibbe at mdkn.de | http://www.mdk-niedersachsen.de ________________________________ Diese E-Mail enth?lt vertrauliche und/oder rechtlich gesch?tzte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrt?mlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet. This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden. Von: Skibbe, Oliver Gesendet: Mittwoch, 26. November 2014 10:15 An: 'devel at monitoring-plugins.org' Betreff: Patch for check_by_ssh - Add option to force pseudo tty allocation Hey, because i've needed a pseudo tty for running sudo via ssh, i created a small patch for check_by_ssh It introduces a new option "-z" which adds -t Force pseudo-tty allocation. This can be used to execute arbitrary screen-based programs on a remote machine, which can be very useful, e.g. when implementing menu services. Multiple -t options force tty allocation, even if ssh has no local tty. While using this new option, you have to set -E because on STDERR appears: Connection to $IP closed. Maybe there is a better way to surpress this message but i'm not this deep in C. Let me know if you're interested. Mit freundlichem Gru? Oliver Skibbe Medizinischer Dienst der Krankenversicherung Niedersachsen | MDKN Gesch?ftsbereich Zentrale Dienste Informationstechnologie Oliver Skibbe Systemadministrator Hildesheimer Stra?e 202-206 30519 Hannover Tel: +49 (0) 511 8785 4321 Oliver.Skibbe at mdkn.de | http://www.mdk-niedersachsen.de ________________________________ Diese E-Mail enth?lt vertrauliche und/oder rechtlich gesch?tzte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrt?mlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet. This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden. -------------- next part -------------- An HTML attachment was scrubbed... URL: From herbszt at gmx.de Wed Nov 26 23:51:00 2014 From: herbszt at gmx.de (Sebastian Herbszt) Date: Wed, 26 Nov 2014 23:51:00 +0100 Subject: [PATCH] check_apt: fix memset Message-ID: <20141126235100.0000546e@localhost> Fix memset introduced by commit 9ce7369 ("plugins/check_apt.c - Print uninitialized ereg"). Signed-off-by: Sebastian Herbszt --- plugins/check_apt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/check_apt.c b/plugins/check_apt.c index 13aec5b..385f047 100644 --- a/plugins/check_apt.c +++ b/plugins/check_apt.c @@ -224,7 +224,7 @@ int run_upgrade(int *pkgcount, int *secpkgcount){ char *cmdline=NULL, rerrbuf[64]; /* initialize ereg as it is possible it is printed while uninitialized */ - memset(&ereg, "\0", sizeof(ereg.buffer)); + memset(&ereg, '\0', sizeof(ereg.buffer)); if(upgrade==NO_UPGRADE) return STATE_OK; -- 2.1.0 From herbszt at gmx.de Wed Nov 26 23:54:49 2014 From: herbszt at gmx.de (Sebastian Herbszt) Date: Wed, 26 Nov 2014 23:54:49 +0100 Subject: [PATCH] check_ntp: fix null termination Message-ID: <20141126235449.00006b6f@localhost> Fix null termination introduced by commit a04df3e ("plugins/check_ntp.c - Verify struct from response"). Signed-off-by: Sebastian Herbszt --- plugins/check_ntp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/check_ntp.c b/plugins/check_ntp.c index fb4450c..7488fa5 100644 --- a/plugins/check_ntp.c +++ b/plugins/check_ntp.c @@ -616,7 +616,7 @@ double jitter_request(const char *host, int *status){ if (bytes_read != ntp_cm_ints + req.count) die(STATE_UNKNOWN, _("Invalid NTP response: %d bytes read does not equal %d plus %d data segment"), bytes_read, ntp_cm_ints, req.count); /* else null terminate */ - strncpy(req.data[req.count], "\0", 1); + req.data[req.count] = '\0'; DBG(print_ntp_control_message(&req)); -- 2.1.0 From herbszt at gmx.de Thu Nov 27 00:03:23 2014 From: herbszt at gmx.de (Sebastian Herbszt) Date: Thu, 27 Nov 2014 00:03:23 +0100 Subject: [PATCH] check_real: fix null termination Message-ID: <20141127000323.00000f0b@localhost> Fix null termination introduced by commit b61f51a ("plugins/check_real.c - recv string null terminate"). Signed-off-by: Sebastian Herbszt --- plugins/check_real.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/check_real.c b/plugins/check_real.c index 688c398..605701d 100644 --- a/plugins/check_real.c +++ b/plugins/check_real.c @@ -178,7 +178,7 @@ main (int argc, char **argv) /* watch for the REAL connection string */ result = recv (sd, buffer, MAX_INPUT_BUFFER - 1, 0); - buffer[result] = "\0"; /* null terminate recieved buffer */ + buffer[result] = '\0'; /* null terminate recieved buffer */ /* return a CRITICAL status if we couldn't read any data */ if (result == -1) { -- 2.1.0 From herbszt at gmx.de Thu Nov 27 00:05:12 2014 From: herbszt at gmx.de (Sebastian Herbszt) Date: Thu, 27 Nov 2014 00:05:12 +0100 Subject: [PATCH] update .gitignore Message-ID: <20141127000512.000034fe@localhost> Add build-aux/test-driver to .gitignore. Signed-off-by: Sebastian Herbszt --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 78ed32a..9e57670 100644 --- a/.gitignore +++ b/.gitignore @@ -35,6 +35,7 @@ NP-VERSION-FILE /build-aux/install-sh /build-aux/missing /build-aux/mkinstalldirs +/build-aux/test-driver # /doc/ /doc/developer-guidelines.html -- 2.1.0 From holger at zedat.fu-berlin.de Thu Nov 27 00:59:06 2014 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Thu, 27 Nov 2014 00:59:06 +0100 Subject: [PATCH] check_real: fix null termination In-Reply-To: <20141127000323.00000f0b@localhost> References: <20141127000323.00000f0b@localhost> Message-ID: <20141126235906.GG470467@zedat.fu-berlin.de> * Sebastian Herbszt [2014-11-27 00:03]: > Fix null termination introduced by commit b61f51a > ("plugins/check_real.c - recv string null terminate"). Applied, thanks. Holger From Jochen.Bern at LINworks.de Thu Nov 27 17:42:20 2014 From: Jochen.Bern at LINworks.de (Jochen Bern) Date: Thu, 27 Nov 2014 17:42:20 +0100 Subject: Ping Threshold change In-Reply-To: <79C529F1CB33EE4D9FD66B887DB0F95901A5569F96@Exchange6.hq1.nakisa.net> References: <79C529F1CB33EE4D9FD66B887DB0F95901A5569F96@Exchange6.hq1.nakisa.net> Message-ID: <5477546C.9090902@LINworks.de> On 11/19/2014 10:43 PM, Basel Gozem wrote: > I changed the ping Threshold as follows in the hosts.cfg file for one host only: > check_command check_ping!150.0,20%!500.0,60% That only means that you're trying to pass two parameters to the *command* "check_ping", which is defined somewhere else in your configurations, may or may not make use of the parameters, and may or may not use the *plugin* of the same name. (And *if* it does *and* passes the parameters on to it, you might want to tell us the plugin's *version*.) Regards, J. Bern -- *NEU* - NEC IT-Infrastruktur-Produkte im : Server--Storage--Virtualisierung--Management SW--Passion for Performance Jochen Bern, Systemingenieur --- LINworks GmbH Postfach 100121, 64201 Darmstadt | Robert-Koch-Str. 9, 64331 Weiterstadt PGP (1024D/4096g) FP = D18B 41B1 16C0 11BA 7F8C DCF7 E1D5 FAF4 444E 1C27 Tel. +49 6151 9067-231, Zentr. -0, Fax -299 - Amtsg. Darmstadt HRB 85202 Unternehmenssitz Weiterstadt, Gesch?ftsf?hrer Metin Dogan, Oliver Michel From holger at zedat.fu-berlin.de Fri Nov 28 08:58:20 2014 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Fri, 28 Nov 2014 08:58:20 +0100 Subject: Next Friday: Bug squashing sprint In-Reply-To: <20141121160315.GJ8814@zedat.fu-berlin.de> References: <20141121160315.GJ8814@zedat.fu-berlin.de> Message-ID: <20141128075820.GI470467@zedat.fu-berlin.de> Just a quick reminder: * Holger Wei? [2014-11-21 17:03]: > I met up with Sven and Jan during the OSMC? in Nuremberg, and we decided > to have a "bug squashing sprint" on Friday, Nov. 28th. The idea is to > tackle a number of pull requests and bug reports in a joint effort, as > that will be more fun than doing it all alone. Our main communication > channel will be the #monitoring-plugins IRC room on freenode. This is going to take place today, we'll probably start in an hour or two. See you in #monitoring-plugins! Holger From holger at zedat.fu-berlin.de Fri Nov 28 11:23:12 2014 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Fri, 28 Nov 2014 11:23:12 +0100 Subject: [PATCH] update .gitignore In-Reply-To: <20141127000512.000034fe@localhost> References: <20141127000512.000034fe@localhost> Message-ID: <20141128102312.GA145348@zedat.fu-berlin.de> * Sebastian Herbszt [2014-11-27 00:05]: > Add build-aux/test-driver to .gitignore. I'm not sure how you ended up with a build-aux/test-driver file(?) ... Holger From notifications at github.com Fri Nov 28 11:59:24 2014 From: notifications at github.com (waja) Date: Fri, 28 Nov 2014 02:59:24 -0800 Subject: check_mailq: add sudo support (#1171) In-Reply-To: References: Message-ID: Am 28.11.14 11:54, schrieb Holger Wei?: > I think it would be nicer to have the new |-s| flag accept an optional > argument that allows the user to specify a different |sudo| command. But +1 --- Reply to this email directly or view it on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1171#issuecomment-64881979 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 12:25:19 2014 From: notifications at github.com (waja) Date: Fri, 28 Nov 2014 03:25:19 -0800 Subject: check_snmp: fix for multiple non numeric OIDs (#1163) In-Reply-To: References: Message-ID: Closed #1163. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1163#event-199881408 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 12:25:19 2014 From: notifications at github.com (waja) Date: Fri, 28 Nov 2014 03:25:19 -0800 Subject: check_snmp: fix for multiple non numeric OIDs (#1163) In-Reply-To: References: Message-ID: Closing this too as we closed #1013. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1163#issuecomment-64884144 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 13:00:58 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Fri, 28 Nov 2014 04:00:58 -0800 Subject: check_snmp: Added warning and critical thresholds to the performance data (#1235) In-Reply-To: References: Message-ID: I've squashed the two commits, applied cosmetic changes, added a NEWS entry, and merged the changes. Thanks! -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1235#issuecomment-64886894 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 13:01:02 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Fri, 28 Nov 2014 04:01:02 -0800 Subject: check_snmp: Added warning and critical thresholds to the performance data (#1235) In-Reply-To: References: Message-ID: Closed #1235. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1235#event-199894115 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 13:25:55 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Fri, 28 Nov 2014 04:25:55 -0800 Subject: check_nt: Added perfdata. New -l options - seconds|minutes|hours|days. (#1253) In-Reply-To: References: Message-ID: Closed #1253 via 7ef100a3ebd8195d9ad19e6c0cd8efd9c0284ee6. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1253#event-199902569 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 13:41:28 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Fri, 28 Nov 2014 04:41:28 -0800 Subject: check_ping output perfdata in seconds [sf#3438264] (#1025) In-Reply-To: References: Message-ID: > It is very useful for systems which scale the perfdata, i.e. Centreon. I think those systems should be fixed to cope with other UOMs. If you think otherwise, please reopen the issue. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1025#issuecomment-64890005 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 14:19:55 2014 From: notifications at github.com (Sven Nierlein) Date: Fri, 28 Nov 2014 05:19:55 -0800 Subject: check_ping: Add support for showing name (DNS) resolution in the plugin output (STDOUT). (#1284) In-Reply-To: References: Message-ID: Closed #1284. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1284#event-199921004 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 14:19:55 2014 From: notifications at github.com (Sven Nierlein) Date: Fri, 28 Nov 2014 05:19:55 -0800 Subject: check_ping: Add support for showing name (DNS) resolution in the plugin output (STDOUT). (#1284) In-Reply-To: References: Message-ID: Thanks for your patch. We decided to not include it since you almost always have the hostname in your interface or notification already and we'd like to avoid duplicate information. You might say it's optional, but then it still makes the code more complicated and less maintable and reduces the number of available options for useful future features. Also the whitespace seemed ok already, according to our guidelines (see CODE file) there should be leading tabs followed by spaces. We can discuss about how and if this is useful and state of the art, but that should be done seperatly. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1284#issuecomment-64893097 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 14:35:53 2014 From: notifications at github.com (Sven Nierlein) Date: Fri, 28 Nov 2014 05:35:53 -0800 Subject: check_by_ssh: Add option to force pseudo tty allocation (#1303) In-Reply-To: References: Message-ID: Shouldn't this be possible by using the "-o RequestTTY=force" option. I am usually not a fan of just passing through options, especially when using a different character. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1303#issuecomment-64894466 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 14:40:49 2014 From: notifications at github.com (Sven Nierlein) Date: Fri, 28 Nov 2014 05:40:49 -0800 Subject: check_ssh: change warning to critical for protocal/version errors (#1268) In-Reply-To: References: Message-ID: Closed #1268 via a7d7992777963bd192cfef21988d281bc371c794. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1268#event-199928927 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 15:18:48 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Fri, 28 Nov 2014 06:18:48 -0800 Subject: check_icmp: use packet reception time to compute rtt (#1232) In-Reply-To: References: Message-ID: As we support pre-C99 compilers, we can't apply patches that mix code and variable declarations. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1232#issuecomment-64898318 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 15:27:46 2014 From: notifications at github.com (Sven Nierlein) Date: Fri, 28 Nov 2014 06:27:46 -0800 Subject: Pr 1183 enhanced (#1304) Message-ID: You can merge this Pull Request by running: git pull https://github.com/monitoring-plugins/monitoring-plugins pr-1183-enhanced Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1304 -- Commit Summary -- * avoid a segfault, if ulimit is set to unlimited * make constants from maxfd values (#1300) -- File Changes -- M lib/utils_cmd.c (14) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1304.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1304.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1304 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 15:48:29 2014 From: notifications at github.com (Sven Nierlein) Date: Fri, 28 Nov 2014 06:48:29 -0800 Subject: Pr 1183 enhanced (#1304) In-Reply-To: References: Message-ID: Merged #1304. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1304#event-199956246 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 15:49:06 2014 From: notifications at github.com (Sven Nierlein) Date: Fri, 28 Nov 2014 06:49:06 -0800 Subject: avoid a segfault, if ulimit is set to unlimited (#1300) In-Reply-To: References: Message-ID: thanks, i merged your changes with #1304 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1300#issuecomment-64901137 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 16:03:22 2014 From: notifications at github.com (Sven Nierlein) Date: Fri, 28 Nov 2014 07:03:22 -0800 Subject: check_by_ssh: added option to exit with an warning, if there is output on STDERR (#1301) In-Reply-To: References: Message-ID: instead of adding a negate like option for each plugin, i'd prefer to enhance the negate plugin to maybe change states only for certain pattern. Ex.: negate -w WARNING -r 'Remote command execution failed' ... -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1301#issuecomment-64902438 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 16:28:40 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Fri, 28 Nov 2014 07:28:40 -0800 Subject: check_real: Fixed read timeout when passing url parameter. (#1290) In-Reply-To: References: Message-ID: Closed #1290 via 3aea6f8fa161836b18802c1a9791ec0c6e728799. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1290#event-199971374 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 16:59:02 2014 From: notifications at github.com (waja) Date: Fri, 28 Nov 2014 07:59:02 -0800 Subject: check_nwstat: adds percentage used space (#1183) In-Reply-To: References: Message-ID: Okay, I fixed those whitespace stuff. But about this operator formating ... the whole plugins is full of them. It would be better to fix that for the whole plugin (maybe after merging this or not, what ever we decide) afterwards. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1183#issuecomment-64907795 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 17:01:01 2014 From: notifications at github.com (waja) Date: Fri, 28 Nov 2014 08:01:01 -0800 Subject: check_nwstat: adds percentage used space (#1183) In-Reply-To: References: Message-ID: Just some stats for fun: $ grep "result=" plugins/check_nwstat.c | wc -l 157 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1183#issuecomment-64907997 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 17:10:21 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Fri, 28 Nov 2014 08:10:21 -0800 Subject: check_procs: added working HP-UX support (#1288) In-Reply-To: References: Message-ID: Closed #1288 via f3b789a526af04434813c3d49dfb28b106ad691c. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1288#event-199987676 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Nov 28 18:01:41 2014 From: notifications at github.com (waja) Date: Fri, 28 Nov 2014 09:01:41 -0800 Subject: check_http.c: fix Host header if explicitly set with -k (#1305) Message-ID: taken from https://github.com/llicour/nagios-plugins/commit/911c3c34755c65046fe73ce051ec9dc3b76b324a You can merge this Pull Request by running: git pull https://github.com/waja/monitoring-plugins check_http_hostheader Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1305 -- Commit Summary -- * plugins/check_http.c - fix Host header if explicitly set with -k -- File Changes -- M plugins/check_http.c (39) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1305.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1305.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1305 -------------- next part -------------- An HTML attachment was scrubbed... URL: From herbszt at gmx.de Sat Nov 29 00:54:12 2014 From: herbszt at gmx.de (Sebastian Herbszt) Date: Sat, 29 Nov 2014 00:54:12 +0100 Subject: [PATCH] update .gitignore In-Reply-To: <20141128102312.GA145348@zedat.fu-berlin.de> References: <20141127000512.000034fe@localhost> <20141128102312.GA145348@zedat.fu-berlin.de> Message-ID: <20141129005412.00000388@localhost> Holger Wei? wrote: > * Sebastian Herbszt [2014-11-27 00:05]: > > Add build-aux/test-driver to .gitignore. > > I'm not sure how you ended up with a build-aux/test-driver file(?) ... > > Holger $ git describe v2.1-23-gf3b789a $ tools/setup which: no gnumake in (/usr/lib64/mpi/gcc/openmpi/bin:/sbin:/usr/sbin:/usr/local/sbin:/root/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/X11R6/bin:/usr/games:/usr/lib/mit/bin) Found GNU Make at /usr/bin/gmake ... good. configure.ac:43: installing 'build-aux/compile' configure.ac:10: installing 'build-aux/config.guess' configure.ac:10: installing 'build-aux/config.sub' configure.ac:7: installing 'build-aux/install-sh' configure.ac:7: installing 'build-aux/missing' Makefile.am: installing './INSTALL' gl/Makefile.am: installing 'build-aux/depcomp' parallel-tests: installing 'build-aux/test-driver' automake (GNU automake) 1.13.4 Sebastian From notifications at github.com Sat Nov 29 04:17:51 2014 From: notifications at github.com (Mark A. Ziesemer) Date: Fri, 28 Nov 2014 19:17:51 -0800 Subject: check_ping: Add support for showing name (DNS) resolution in the plugin output (STDOUT). (#1284) In-Reply-To: References: Message-ID: @sni / @waja - Could we please have some opportunity for review / discussion here before immediately squashing this as closed? I would be more than happy to provide additional / alternate revisions here, if/as required for inclusion. I think we'd all hate to have an additional fork here for something so simple. > since you almost always have the hostname in your interface or > notification already and we'd like to avoid duplicate information. This is backwards of what I intended. As I noted in the original pull request above, I am monitoring everything by its DNS name, not IP. This is for the reasons above, and is what I believe to be a better monitoring configuration. As such, yes, we'd already have the hostname - but the IP is then left missing. This is why "ping" provides these details for this very reason - pinging "myHost.com"? Great - but which host did we resolve to? If the IP changed to something "invalid" which is what caused the failure, this option would allow us to see that immediately - without any additional digging required, but only if enabled with the run-time option. Again, we're not adding anything "extra" here - just no longer always preventing useful information that the "ping" output already provided us with from making it to the output. > it still makes the code more complicated and less maintable 16 additional lines of code, largely templated off of the existing code? > and reduces the number of available options for useful future features Are we talking available command-line flags here? Let's just assume 36 single-characters to begin with ([A-Za-z0-9]), not including '?' and other non-disputed allowed flags. We're currently using 12, and this would make 13. If we'd like to avoid using a single-character flag for this, that's fine - and we can just stick with the long "--show-resolution" option. > Also the whitespace seemed ok already, according to our guidelines (see > CODE file) there should be leading tabs followed by spaces. I completely agree. However, if you review the current version of the file, the indentation is not consistent. In re-reviewing my changes, the first 3 whitespace-related edits I made are probably up for debate, and I should have left them alone. However, throughout the rest of the file - indentations were being made with spaces only - not the "leading tabs followed by spaces" which are required by the CODE file, and a preference that I agree with and support. > that should be done seperatly. This is exactly why I made the whitespace changes in a separate commit - but given that I was in this file anyway, I was hoping that a separate branch and pull request would not be required here. What can we please do to compromise here? If I submit a new pull request with only the "--show-resolution" flag and supporting changes - no additional single-character flag and no whitespace changes, will you please reconsider? (Or is there anything we can please work with here without even requiring all of that?) Thanks! -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1284#issuecomment-64939909 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Nov 29 20:33:29 2014 From: notifications at github.com (Sven Nierlein) Date: Sat, 29 Nov 2014 11:33:29 -0800 Subject: check_icmp : disable rtmin/rtmax perfomance data (#1172) In-Reply-To: References: Message-ID: Closed #1172. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1172#event-200177276 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Nov 30 00:26:07 2014 From: notifications at github.com (Mark A. Ziesemer) Date: Sat, 29 Nov 2014 15:26:07 -0800 Subject: check_ping: Add support for showing name (DNS) resolution in the plugin output (STDOUT). (#1284) In-Reply-To: References: Message-ID: I never expected so much reluctance at such a simple request. I did not submit this as a bug report, looking for someone else to solve it - but as a pull request for which I've already completed the development, am already running the changes myself, and am simply hoping to contribute the improvements back to the community. I guess I still don't understand the concerns over an additional flag here - especially when mentioned in the context of "inconsistently used options across the plugins". There is no need to offer this as a single-character flag - we could just stick with "--show-resolution" (or some other proposed name), without needing to worry about any realistic conflict in what such an option might mean in other plugins. I'm not particularly attached to the implementation either (even though it was meant to be completely templated off of existing code) - and if someone would like to implement this request using an alternate implementation, that would be great as well. This is not some new math or edge case. It is deemed useful, which is why it is shown in the default output of all ping executables we've referenced here. I also don't immediately see any other option for accomplishing the same result - without patching the current plugin (or writing my own), hence my persistence for following-up on this pull request. It is not as if this is an ever-changing program for which any new changes will likely conflict at some point. Since 2012, there have only been 3 changes here that weren't related directly to the rename for the fork - 2 in January and 1 in April. (However, I guess this will make it very easy for me to maintain my own copy with these additions, if required.) > I'd say, at least 90% use check_ping with the ip adress not with the > hostname, so the use case is rather limited. Just curious, are there gathered and/or published metrics for these types of use cases anywhere? Regardless, I'd like to see any additional studies or discussion around this monitoring design decision - monitoring by IP vs. hostname. In my years of experience on a few different related monitoring implementations here, we observed a number of significant misses on a system that was still based on static IPs, while similar incidents were properly caught when based on host names. They were arguably edge cases - but cases that we'd expect such a monitoring system to be able to detect and report. Things like the disappearance of a host name record from DNS, where the DNS name is used for connections from other systems. Yes - in these incidents, things that "never should happen" happened - and we want such monitoring to be "synthetic" and to report on such failures. Part of the reason that checking by IP rather than hostname may be so prevalent could partially be due to these types of limitations in the current tools and plugins. By providing proper support for both approaches, I would hope the tide would shift to more checking by hostname - which I sincerely believe to be a better approach. However, please don't take my word for it - offer the support and choice to the users, and empower them to make the appropriate determination for their specific needs. Consider an integration with a partner, for whose IP addressing we have no control. We depend upon a service being available at the-service.extranet.some-company.com. It could be load-balanced with round-robin DNS, or it could otherwise be statically-assigned with the need to change hosting providers, etc. In the latter case, they could execute an orderly transition - with proper TTLs on the DNS records, and services available at both addresses for a matching transition period. However, when configured to monitor by IP instead of by hostname, our monitoring now potentially ends-up out-of-sync - or worse, a missed failure, as the check ends-up monitoring an incorrect host. (Again, things that should "never happen" if all other processes are properly followed, but not assumptions we'd like to make here.) Yes - this means that we are a bit more dependent on DNS or other name resolution, and could be prone to disruptions or failures in those services. However, I'd rather have a false-positive than a missed failure. Additionally, using a local name resolution cache (e.g. dnsmasq) on the monitoring server can provide for not flooding a configured DNS server with hundreds of additional requests / minute, as well as providing for some level of isolation to any intermittent upstream DNS failures (configurable to degree and preference). This leaves us with the potential cases that we observed a monitored failure, or are following-up on a failure that was missed in monitoring - and in either case, would like to know more details as to "why". A logical first step for me here would involve determining which IP address was being used - something that would otherwise have to be determined afterwards, and even then, may not be readily available with any level of confidence after-the-fact, especially for an intermittent failure. Thank you for your continued consideration. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1284#issuecomment-64969236 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Nov 30 00:55:33 2014 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Sat, 29 Nov 2014 15:55:33 -0800 Subject: check_ping: Add support for showing name (DNS) resolution in the plugin output (STDOUT). (#1284) In-Reply-To: References: Message-ID: > It is deemed useful, which is why it is shown in the default output of all > ping executables we've referenced here. So your reasoning for assuming this feature to be useful for others is that plain `ping(1)` does it, right? (Let me know if I overlooked anything else regarding _this_ question in your message.) I think the requirements for plugin output are different from those for command line tools, but I guess you still have a point there. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1284#issuecomment-64969948 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Nov 30 04:06:56 2014 From: notifications at github.com (Mark A. Ziesemer) Date: Sat, 29 Nov 2014 19:06:56 -0800 Subject: check_ping: Add support for showing name (DNS) resolution in the plugin output (STDOUT). (#1284) In-Reply-To: References: Message-ID: > So your reasoning for assuming this feature to be useful for others is > that plain ping(1) does it, right? That's a stretch. I need it. Others may need it. Still others may benefit from its use if it were available to them (as I detailed above). I do think it is silly that we're already executing the ping command which is already providing these details as part of its standard output, but are effectively preventing any possibility from already-completed work for potentially desirable details from being made available in the plugin output. However, that is my $0.02. I also respect the decision by the various authors of the `ping` executables that we've reviewed here, and also those of other utilities (e.g. `route` and `netstat`, just for a few others) - that if they don't include the numeric output by default, they can do so with the "`-n`" or "`--numeric`" flags. I still don't understand the need to have a different standard here - but I can agree to disagree, especially as this is not my project. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1284#issuecomment-64973886 -------------- next part -------------- An HTML attachment was scrubbed... URL: From holger at zedat.fu-berlin.de Sun Nov 30 22:31:31 2014 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Sun, 30 Nov 2014 22:31:31 +0100 Subject: [PATCH] update .gitignore In-Reply-To: <20141129005412.00000388@localhost> References: <20141127000512.000034fe@localhost> <20141128102312.GA145348@zedat.fu-berlin.de> <20141129005412.00000388@localhost> Message-ID: <20141130213131.GA682618@zedat.fu-berlin.de> * Sebastian Herbszt [2014-11-29 00:54]: > Holger Wei? wrote: > > * Sebastian Herbszt [2014-11-27 00:05]: > > > Add build-aux/test-driver to .gitignore. > > > > I'm not sure how you ended up with a build-aux/test-driver file(?) ... > > [...] > > automake (GNU automake) 1.13.4 Ah, my Automake was older. Applied, thank you. Holger From holger at zedat.fu-berlin.de Sun Nov 30 23:51:28 2014 From: holger at zedat.fu-berlin.de (Holger =?iso-8859-1?Q?Wei=DF?=) Date: Sun, 30 Nov 2014 23:51:28 +0100 Subject: [PATCH] check_ntp: fix null termination In-Reply-To: <20141126235449.00006b6f@localhost> References: <20141126235449.00006b6f@localhost> Message-ID: <20141130225128.GA696021@zedat.fu-berlin.de> * Sebastian Herbszt [2014-11-26 23:54]: > Fix null termination introduced by commit a04df3e > ("plugins/check_ntp.c - Verify struct from response"). Looks obviously correct if you just look at the diff, but the commit that introduced the original code is broken in many more ways (req.count is evaluated in network byte order, for example), so I reverted that. Thanks for spotting this, and for your other fixes! Holger From herbszt at gmx.de Sun Nov 30 23:57:47 2014 From: herbszt at gmx.de (Sebastian Herbszt) Date: Sun, 30 Nov 2014 23:57:47 +0100 Subject: [PATCH] check_tcp: fix help description regarding escape option Message-ID: <20141130235747.00001e39@localhost> The help description should print '\\' for backslash not just '\'. Signed-off-by: Sebastian Herbszt --- plugins/check_tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/check_tcp.c b/plugins/check_tcp.c index fc0adba..63f9fd9 100644 --- a/plugins/check_tcp.c +++ b/plugins/check_tcp.c @@ -643,7 +643,7 @@ print_help (void) printf (UT_IPv46); printf (" %s\n", "-E, --escape"); - printf (" %s\n", _("Can use \\n, \\r, \\t or \\ in send or quit string. Must come before send or quit option")); + printf (" %s\n", _("Can use \\n, \\r, \\t or \\\\ in send or quit string. Must come before send or quit option")); printf (" %s\n", _("Default: nothing added to send, \\r\\n added to end of quit")); printf (" %s\n", "-s, --send=STRING"); printf (" %s\n", _("String to send to the server")); -- 2.1.0