From notifications at github.com Wed Jul 15 21:35:40 2015 From: notifications at github.com (Casper Langemeijer) Date: Wed, 15 Jul 2015 12:35:40 -0700 Subject: Add commandline -T switch to check_time and check_ntp_time (#1246) In-Reply-To: References: Message-ID: Guys, re-reading this again a year later, I'm still stomped by the process of this pull request. I put in time, I think I worked well with @skottler and @weiss on this. Explaining the why of my patches, and implementing the suggestions offered by them. I'm not afraid to learn nor explain. Then comes in @dermoth, first disregarding any of my explanation, then claiming a larger scale, to top it off offer me advice on how to do nagios monitoring. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1246#issuecomment-121722589 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Jul 15 21:35:42 2015 From: notifications at github.com (Casper Langemeijer) Date: Wed, 15 Jul 2015 12:35:42 -0700 Subject: Add commandline -T switch to check_time and check_ntp_time (#1246) In-Reply-To: References: Message-ID: Closed #1246. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1246#event-356826726 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jul 16 03:00:02 2015 From: notifications at github.com (Thomas Guyot-Sionnest) Date: Wed, 15 Jul 2015 18:00:02 -0700 Subject: Add commandline -T switch to check_time and check_ntp_time (#1246) In-Reply-To: References: Message-ID: Hi Casper, I have to apologize for not looking at your patches like I said I would... My point was this should be implemented on a much more generic level. Like most plugins use macros to set base command switches, I think this patch should be applied to all plugin that use timeouts. The code look OK though so my main concern at this point would be checking if the choice of -T works for at least most plugins with a -t switch, and maybe somehow at making some kind of "reservation", ex by adding comments where it could be used. @skottler, @weiss, please do not wait on me if you'd like to merge it; I'm not much active in this project since I no longer deal with monitoring at work (I didn't deal a lot with it in back in spring '14, and even less since I've changed job shortly after - last summer). Regards, Thomas -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1246#issuecomment-121793184 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Jul 16 03:00:03 2015 From: notifications at github.com (Thomas Guyot-Sionnest) Date: Wed, 15 Jul 2015 18:00:03 -0700 Subject: Add commandline -T switch to check_time and check_ntp_time (#1246) In-Reply-To: References: Message-ID: Reopened #1246. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1246#event-357056905 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jul 19 09:49:13 2015 From: notifications at github.com (Sebastian Nohn) Date: Sun, 19 Jul 2015 00:49:13 -0700 Subject: add optional parameter to treat non-critical packages as OK instead of WARNING (#1342) In-Reply-To: References: Message-ID: Closed #1342. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1342#event-359393698 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jul 19 09:49:19 2015 From: notifications at github.com (Sebastian Nohn) Date: Sun, 19 Jul 2015 00:49:19 -0700 Subject: add optional parameter to treat non-critical packages as OK instead of WARNING (#1342) In-Reply-To: References: Message-ID: Reopened #1342. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1342#event-359393717 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Jul 19 09:55:29 2015 From: notifications at github.com (Sebastian Nohn) Date: Sun, 19 Jul 2015 00:55:29 -0700 Subject: add optional parameter to treat non-critical packages as OK instead of WARNING (#1342) In-Reply-To: References: Message-ID: check_http.t tests fail which should have nothing to do with this PR -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1342#issuecomment-122637516 -------------- next part -------------- An HTML attachment was scrubbed... URL: