check_load hardcodes path to 'uptime' (#1394)

[Jochen Bern]

On 11/20/2015 06:51 AM, Tomas Mozes wrote:
> The path to 'uptime' binary is hardcoded when compiling monitoring-plugins.
> This can break the plugin

For what it's worth, if a plugin relies on some system executable to be
found in $PATH and system maintenance results in an executable of the
same name appearing elsewhere, the plugin is *just as likely* to break,
*especially* with executables like "uptime" that aim to have *human
readable* output. Heck, I'ld expect that to break when you touch $LANG,
much less $PATH or $HOME/bin.

Hardcoded pathes for some executable appear all over the place, from
/etc/shells to scripts using /bin/true and /bin/ls to prevent falling
for users' aliases to checking beforehand whether the executable *is
even available* (a la "test -x"). The rationale for using them usually
boils down to "it'll break *less often* than the alternatives".

Kind regards,

Jochen Bern
Systemingenieur

-- 

LINworks GmbH

Fon:    +49 6151 9067-231
Fax:    +49 6151 9067-299
E-Mail: Jochen.Bern at LINworks.de
Web:    http://www.LINworks.de/

NEC IT Infrastrukturprodukte vom Deutschland Distributor
Server, Storage, Virtualisierung, Management Software
Shop: http://www.NEC-Store.de/

Briefanschrift: Postfach 10 01 21 · 64201 Darmstadt · DE
Hausanschrift: Robert-Koch-Straße 9 · 64331 Weiterstadt · DE
Geschäftsführer: Metin Dogan, Nils Manegold, Oliver Michel
Unternehmenssitz: Weiterstadt
Register: Amtsgericht Darmstadt, HRB 85202

MAX21-Unternehmensgruppe



-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3924 bytes
Desc: S/MIME Cryptographic Signature
URL: <https://www.monitoring-plugins.org/archive/devel/attachments/20151120/847c8a49/attachment.bin>