Use GMT timezone in SSL certs (#1396)

Peter (pir) notifications at github.com
Tue Nov 24 04:49:36 CET 2015


SSL certs are required to use times in GMT per
https://www.ietf.org/rfc/rfc5280.txt but the mktime() here assumes the
current timezone.

Fix the time_t conversion to be done assuming GMT with timegm() and
only do it once rather than twice.

Display the expiry date and time with ISO format years and give an
offset from GMT and a timezone to be very clear about exactly what time
is being displayed. Time given is correct and now in the machine’s
timezone.

Fix tests to match.
You can view, comment on, or merge this pull request online at:

  https://github.com/monitoring-plugins/monitoring-plugins/pull/1396

-- Commit Summary --

  * Use GMT timezone in SSL certs
  * Fix check_http test time output

-- File Changes --

    M plugins/sslutils.c (6)
    M plugins/tests/check_http.t (8)

-- Patch Links --

https://github.com/monitoring-plugins/monitoring-plugins/pull/1396.patch
https://github.com/monitoring-plugins/monitoring-plugins/pull/1396.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/monitoring-plugins/monitoring-plugins/pull/1396
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.monitoring-plugins.org/archive/devel/attachments/20151123/f8ce1a78/attachment.html>


More information about the Devel mailing list