From notifications at github.com Thu Oct 1 17:31:24 2015 From: notifications at github.com (waja) Date: Thu, 01 Oct 2015 08:31:24 -0700 Subject: check_http: Add check_nrpe like behaviour (#1355) In-Reply-To: References: Message-ID: Hi, I don't know if this can be merged by us, but it would super cool if you can rebase this PR against our recent master branch, as d73c57aa061a4c408701f980d1f8857b64433488 fixed some problems with our integration tests. Thanks, Jan. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1355#issuecomment-144763504 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Oct 1 17:31:54 2015 From: notifications at github.com (waja) Date: Thu, 01 Oct 2015 08:31:54 -0700 Subject: check_http: support the concept of virtual ports (#1352) In-Reply-To: References: Message-ID: Hi, I don't know if this can be merged by us, but it would super cool if you can rebase this PR against our recent master branch, as d73c57aa061a4c408701f980d1f8857b64433488 fixed some problems with our integration tests. Thanks, Jan. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1352#issuecomment-144763635 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Oct 1 17:32:16 2015 From: notifications at github.com (waja) Date: Thu, 01 Oct 2015 08:32:16 -0700 Subject: check_http: allow to alert on time-to-firstbyte (ttfb) (#1347) In-Reply-To: References: Message-ID: Hi, I don't know if this can be merged by us, but it would super cool if you can rebase this PR against our recent master branch, as d73c57aa061a4c408701f980d1f8857b64433488 fixed some problems with our integration tests. Thanks, Jan. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1347#issuecomment-144763737 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 10:40:09 2015 From: notifications at github.com (Sven Nierlein) Date: Fri, 02 Oct 2015 01:40:09 -0700 Subject: check_fping: autodetect ipv6 addresses (#1343) In-Reply-To: References: Message-ID: Merged #1343. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1343#event-425044888 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 10:50:23 2015 From: notifications at github.com (Sven Nierlein) Date: Fri, 02 Oct 2015 01:50:23 -0700 Subject: check_fping: autodetect ipv6 addresses (#1343) In-Reply-To: References: Message-ID: thanks -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1343#issuecomment-144962128 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 11:33:24 2015 From: notifications at github.com (Christopher Odenbach) Date: Fri, 02 Oct 2015 02:33:24 -0700 Subject: check_http: support the concept of virtual ports (#1352) In-Reply-To: References: Message-ID: Hi, as I see it my patch and the patch above will not collide in any way as the changes are in totally different files. My patch does not change the default behaviour of check_http, so all tests should still pass as they did before. Cheers, Christopher -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1352#issuecomment-144974829 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 11:44:17 2015 From: notifications at github.com (Christopher Odenbach) Date: Fri, 02 Oct 2015 02:44:17 -0700 Subject: check_http: Fix for checking http on different virtual port (#1348) In-Reply-To: References: Message-ID: Closed #1348. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1348#event-425094198 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 11:49:36 2015 From: notifications at github.com (waja) Date: Fri, 02 Oct 2015 02:49:36 -0700 Subject: check_http: Fix for checking http on different virtual port (#1175) In-Reply-To: References: Message-ID: Closed #1175. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1175#event-425097958 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 12:47:26 2015 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Fri, 02 Oct 2015 03:47:26 -0700 Subject: check_dhcp: Fixes segfaults when running via monitoring worker (#1345) In-Reply-To: References: Message-ID: Closed #1345. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1345#event-425135966 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 13:01:19 2015 From: notifications at github.com (Sven Nierlein) Date: Fri, 02 Oct 2015 04:01:19 -0700 Subject: check_snmp: small improvement (#1173) In-Reply-To: References: Message-ID: Reviewed and merged. Thanks -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1173#issuecomment-144990945 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 13:01:19 2015 From: notifications at github.com (Sven Nierlein) Date: Fri, 02 Oct 2015 04:01:19 -0700 Subject: check_snmp: small improvement (#1173) In-Reply-To: References: Message-ID: Closed #1173. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1173#event-425144638 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 13:01:50 2015 From: notifications at github.com (Sven Nierlein) Date: Fri, 02 Oct 2015 04:01:50 -0700 Subject: Fixes for check_snmp [sf#3463985] (#1029) In-Reply-To: References: Message-ID: merged -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1029#issuecomment-144990996 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 13:05:13 2015 From: notifications at github.com (Oliver Skibbe) Date: Fri, 02 Oct 2015 04:05:13 -0700 Subject: check_disk: reduced compiler warnings (#1326) In-Reply-To: References: Message-ID: To resolve #1331 it should be merged -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1326#issuecomment-144991488 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 13:06:19 2015 From: notifications at github.com (Oliver Skibbe) Date: Fri, 02 Oct 2015 04:06:19 -0700 Subject: check_http: timeout as perf data max value (#1350) In-Reply-To: References: Message-ID: Ill have a look on this next week, should be easy to implement -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1350#issuecomment-144991636 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 13:59:37 2015 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Fri, 02 Oct 2015 04:59:37 -0700 Subject: drop superfluous libexecdir (#1360) In-Reply-To: References: Message-ID: Applied, thanks. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1360#issuecomment-144998419 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 13:59:37 2015 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Fri, 02 Oct 2015 04:59:37 -0700 Subject: drop superfluous libexecdir (#1360) In-Reply-To: References: Message-ID: Closed #1360. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1360#event-425176718 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 14:04:14 2015 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Fri, 02 Oct 2015 05:04:14 -0700 Subject: drop superfluous libexecdir (#1360) In-Reply-To: References: Message-ID: Oh is there a reason you didn't update `check_rpc.pl` and `check_wave.pl`? -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1360#issuecomment-144998965 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 14:04:14 2015 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Fri, 02 Oct 2015 05:04:14 -0700 Subject: drop superfluous libexecdir (#1360) In-Reply-To: References: Message-ID: Reopened #1360. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1360#event-425179359 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 14:16:24 2015 From: notifications at github.com (=?UTF-8?B?RWxhbiBSdXVzYW3DpGU=?=) Date: Fri, 02 Oct 2015 05:16:24 -0700 Subject: drop superfluous libexecdir (#1360) In-Reply-To: References: Message-ID: no reason. seems missed them somehow. cherry pick 2d6b205 as well. ps: why not just do PR merge? as doing cherry pick manually will lose view from ticket that the commit reached master (and you did not include commit ref in your "applied" message as well) -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1360#issuecomment-145000987 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 14:41:26 2015 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Fri, 02 Oct 2015 05:41:26 -0700 Subject: drop superfluous libexecdir (#1360) In-Reply-To: References: Message-ID: > cherry pick 2d6b205 as well. Done, thanks! > why not just do PR merge? Well I have a little `apply 123` shell function that applies PR 123 with `git am`, and then I often amend minor cleanups. I like this workflow, and I think it's a feature that the committer is recorded without an empty merge commit. But I know it's not the workflow envisioned by GitHub, and I know that people are unhappy if GitHub is unhappy, so i do consider changing the workflow one day ... -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1360#issuecomment-145007047 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 15:13:43 2015 From: notifications at github.com (=?UTF-8?B?RWxhbiBSdXVzYW3DpGU=?=) Date: Fri, 02 Oct 2015 06:13:43 -0700 Subject: drop superfluous libexecdir (#1360) In-Reply-To: References: Message-ID: yes, without doing merge commits, i cannot figure out from the commit itself, that it https://github.com/monitoring-plugins/monitoring-plugins/commit/a9b02e7affe6d940e1fb4830156d06e4d816458b came from this pull request: https://github.com/monitoring-plugins/monitoring-plugins/pull/1360 contrary sample where it can be seen: https://github.com/monitoring-plugins/monitoring-plugins/commit/6a682b379f1b6ef920cae79fae71b38b99dff39d github puts small links to header: master (#1343) and that is very useful when trying to find pull request based on commit hash from git blame -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1360#issuecomment-145016564 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 15:16:34 2015 From: notifications at github.com (=?UTF-8?B?RWxhbiBSdXVzYW3DpGU=?=) Date: Fri, 02 Oct 2015 06:16:34 -0700 Subject: drop superfluous libexecdir (#1360) In-Reply-To: References: Message-ID: also, each PR contains links below "merge using commandline" -- you could do those commands, except push, and do extra commits with git amend to the "merge" commit. then all features work: 1. you could do your amend, which be visible as diff of the "merge commit" 2. merge commit is there for github 3. original commits from reporter are unaltered -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1360#issuecomment-145017539 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 15:20:17 2015 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Fri, 02 Oct 2015 06:20:17 -0700 Subject: drop superfluous libexecdir (#1360) In-Reply-To: References: Message-ID: > yes, without doing merge commits, i cannot figure out from the commit > itself that it a9b02e7 came from this pull request: #1360 That's what I meant above when I said that this is "not the workflow envisioned by GitHub". > you could [do stuff]. As I said I do consider changing my workflow to make GitHub users happy. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1360#issuecomment-145018569 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 15:34:46 2015 From: notifications at github.com (waja) Date: Fri, 02 Oct 2015 06:34:46 -0700 Subject: check_disk: reduced compiler warnings (#1326) In-Reply-To: References: Message-ID: Your changes are glibc specific. You could cast the problematic arguments to (long long) to avoid the warning. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1326#issuecomment-145021408 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 15:59:07 2015 From: notifications at github.com (Sven Nierlein) Date: Fri, 02 Oct 2015 06:59:07 -0700 Subject: sslutils: optimize output if certificate expires in less then 24h (#1336) In-Reply-To: References: Message-ID: Closed #1336. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1336#event-425277205 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 16:00:12 2015 From: notifications at github.com (Sven Nierlein) Date: Fri, 02 Oct 2015 07:00:12 -0700 Subject: check_http: Adding support for checking SSL-Websites through Proxies (#1349) In-Reply-To: References: Message-ID: Merged #1349. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1349#event-425278097 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 16:00:57 2015 From: notifications at github.com (Sven Nierlein) Date: Fri, 02 Oct 2015 07:00:57 -0700 Subject: check_http: Adding support for checking SSL-Websites through Proxies (#1349) In-Reply-To: References: Message-ID: Merged. We did use that patch for quite some time already. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1349#issuecomment-145029778 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 17:04:24 2015 From: notifications at github.com (waja) Date: Fri, 02 Oct 2015 08:04:24 -0700 Subject: check_snmp.c: switched DEFAULT_TIMEOUT to DEFAULT_SOCKET_TIMEOUT (provid... (#1325) In-Reply-To: References: Message-ID: Closed #1325. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1325#event-425349474 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 19:54:35 2015 From: notifications at github.com (Sven Nierlein) Date: Fri, 02 Oct 2015 10:54:35 -0700 Subject: check_tcp: Fixing to return desired exit code (#1257) In-Reply-To: References: Message-ID: Merged #1257. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1257#event-425521924 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 19:54:55 2015 From: notifications at github.com (Sven Nierlein) Date: Fri, 02 Oct 2015 10:54:55 -0700 Subject: check_tcp shows no output when changing desired exit state [sf#3538991] (#1062) In-Reply-To: References: Message-ID: Closed #1062. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1062#event-425522709 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 21:13:52 2015 From: notifications at github.com (Sven Nierlein) Date: Fri, 02 Oct 2015 12:13:52 -0700 Subject: check_http: fix Host header if explicitly set with -k (#1305) In-Reply-To: References: Message-ID: merged -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1305#issuecomment-145129267 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 2 21:13:52 2015 From: notifications at github.com (Sven Nierlein) Date: Fri, 02 Oct 2015 12:13:52 -0700 Subject: check_http: fix Host header if explicitly set with -k (#1305) In-Reply-To: References: Message-ID: Closed #1305. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1305#event-425613356 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sat Oct 3 13:49:02 2015 From: notifications at github.com (waja) Date: Sat, 03 Oct 2015 04:49:02 -0700 Subject: check_http: Add check_nrpe like behaviour (#1355) In-Reply-To: References: Message-ID: http://lmgtfy.com/?q=git+branch+rebase+master for example: https://git-scm.com/book/en/v1/Git-Branching-Rebasing or https://www.atlassian.com/git/tutorials/merging-vs-rebasing/conceptual-overview#the-rebase -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1355#issuecomment-145242346 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Oct 4 13:45:07 2015 From: notifications at github.com (waja) Date: Sun, 04 Oct 2015 04:45:07 -0700 Subject: check_snmp: default timeout incorrect in --help output (#1318) In-Reply-To: References: Message-ID: Fixed by #1325 in maint branch -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1318#issuecomment-145338144 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Oct 4 13:45:07 2015 From: notifications at github.com (waja) Date: Sun, 04 Oct 2015 04:45:07 -0700 Subject: check_snmp: default timeout incorrect in --help output (#1318) In-Reply-To: References: Message-ID: Closed #1318. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1318#event-426184418 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Oct 4 14:18:04 2015 From: notifications at github.com (waja) Date: Sun, 04 Oct 2015 05:18:04 -0700 Subject: sslutils: remove superfluous parenthesis (#1314) In-Reply-To: References: Message-ID: Closed #1314. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1314#event-426192598 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Oct 4 14:20:43 2015 From: notifications at github.com (waja) Date: Sun, 04 Oct 2015 05:20:43 -0700 Subject: sslutils: remove superfluous parenthesis (#1314) In-Reply-To: References: Message-ID: Reopened #1314. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1314#event-426193857 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Oct 4 15:26:15 2015 From: notifications at github.com (Sven Nierlein) Date: Sun, 04 Oct 2015 06:26:15 -0700 Subject: sslutils: remove superfluous parenthesis (#1362) In-Reply-To: References: Message-ID: Merged #1362. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1362#event-426205599 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Oct 4 15:26:29 2015 From: notifications at github.com (Sven Nierlein) Date: Sun, 04 Oct 2015 06:26:29 -0700 Subject: sslutils: remove superfluous parenthesis (#1362) In-Reply-To: References: Message-ID: looks good. thanks -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1362#issuecomment-145349979 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Oct 4 15:49:37 2015 From: notifications at github.com (waja) Date: Sun, 04 Oct 2015 06:49:37 -0700 Subject: check_http: Odd bug with SSL check. (#1358) In-Reply-To: References: Message-ID: $ cat /etc/debian_version 8.2 $ /usr/lib/nagios/plugins/check_http -V check_http v2.1.1 (monitoring-plugins 2.1.1) $ /usr/lib/nagios/plugins/check_http -S -H www.monitoring-plugins.org HTTP OK: HTTP/1.1 200 OK - 5528 bytes in 0.125 second response time |time=0.125402s;;;0.000000 size=5528B;;;0 $ /usr/bin/time curl https://www.monitoring-plugins.org -k -o /dev/null -s 0.01user 0.00system 0:00.14elapsed 16%CPU (0avgtext+0avgdata 4140maxresident)k 0inputs+0outputs (0major+1174minor)pagefaults 0swaps I cant see any problem here. I tested check_http against several apache (2.2,2.4) and nginx on wheezy and jessie. It looks like it's related to you apache2 installation/configuration. With my Debian monitoring-plugins maintainer hat on, Jan. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1358#issuecomment-145351544 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Oct 4 18:43:59 2015 From: notifications at github.com (Oliver Skibbe) Date: Sun, 04 Oct 2015 09:43:59 -0700 Subject: use exit code 3 for version and help (#1363) In-Reply-To: References: Message-ID: Agree on that, typical problem. Happens way too often -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1363#issuecomment-145365494 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Oct 4 19:17:56 2015 From: notifications at github.com (waja) Date: Sun, 04 Oct 2015 10:17:56 -0700 Subject: fix bogus use lib (#1361) In-Reply-To: References: Message-ID: Sorry ... I did miss your PR anyhow, but I fixed it in the same way with 20d223119eb40bd1ecdd637eb845f5e16c87bd36 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1361#issuecomment-145367447 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Oct 4 19:17:58 2015 From: notifications at github.com (waja) Date: Sun, 04 Oct 2015 10:17:58 -0700 Subject: fix bogus use lib (#1361) In-Reply-To: References: Message-ID: Closed #1361. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1361#event-426249879 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Oct 4 21:33:02 2015 From: notifications at github.com (waja) Date: Sun, 04 Oct 2015 12:33:02 -0700 Subject: check_ntp.pl: Droping this superseded plugin (#1364) Message-ID: Let's drop this plugin, as we have C-plugins for this since ages. You can view, comment on, or merge this pull request online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1364 -- Commit Summary -- * check_ntp.pl: Droping this superseded plugin -- File Changes -- M NEWS (2) D plugins-scripts/check_ntp.pl (472) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1364.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1364.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1364 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Sun Oct 4 21:36:33 2015 From: notifications at github.com (Sven Nierlein) Date: Sun, 04 Oct 2015 12:36:33 -0700 Subject: check_ntp.pl: Droping this superseded plugin (#1364) In-Reply-To: References: Message-ID: +1 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1364#issuecomment-145380348 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Oct 5 09:18:22 2015 From: notifications at github.com (=?UTF-8?B?RWxhbiBSdXVzYW3DpGU=?=) Date: Mon, 05 Oct 2015 00:18:22 -0700 Subject: lint .py and .pl scripts (#1365) Message-ID: to avoid [such mistakes](https://github.com/nagios-plugins/nagios-plugins/pull/110) like distributing scripts with syntax error, imho would be good if travis syntax lints the scripts. `perl -c script.pl`, `python -m py_compile script.py` -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1365 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Oct 5 09:42:21 2015 From: notifications at github.com (Sven Nierlein) Date: Mon, 05 Oct 2015 00:42:21 -0700 Subject: lint .py and .pl scripts (#1365) In-Reply-To: References: Message-ID: Closed #1365. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1365#event-426497888 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Oct 5 09:42:21 2015 From: notifications at github.com (Sven Nierlein) Date: Mon, 05 Oct 2015 00:42:21 -0700 Subject: lint .py and .pl scripts (#1365) In-Reply-To: References: Message-ID: We do this since yesterday already :-) https://github.com/monitoring-plugins/monitoring-plugins/commit/c0b4f418993ee2ad9fc96acafdddd98ac1bc5074 At least for perl scripts. I am not aware of any python scripts. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1365#issuecomment-145451405 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Oct 5 09:47:38 2015 From: notifications at github.com (=?UTF-8?B?RWxhbiBSdXVzYW3DpGU=?=) Date: Mon, 05 Oct 2015 00:47:38 -0700 Subject: lint .py and .pl scripts (#1365) In-Reply-To: References: Message-ID: oh. no `.py` indeed. where did i see `.py` then? :) -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1365#issuecomment-145452229 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Oct 5 09:50:50 2015 From: notifications at github.com (=?UTF-8?B?RWxhbiBSdXVzYW3DpGU=?=) Date: Mon, 05 Oct 2015 00:50:50 -0700 Subject: plugins-scripts/Makefile.am: Testing scripts with 'perl -wc' (c0b4f41) In-Reply-To: References: Message-ID: the `PLSCRIPTS` variable is confusing, should be singular not plural, as it contains one file a time. and as that variable is used only on that line (variable will not "leak" to other commands), perhaps just name it as: `script` -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/commit/c0b4f418993ee2ad9fc96acafdddd98ac1bc5074#commitcomment-13586066 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Oct 5 10:20:51 2015 From: notifications at github.com (waja) Date: Mon, 05 Oct 2015 01:20:51 -0700 Subject: lint .py and .pl scripts (#1365) In-Reply-To: References: Message-ID: The idea behind of implementing it soon was, if we delay it, it will never happen. :-) -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1365#issuecomment-145461025 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Oct 5 12:12:12 2015 From: notifications at github.com (waja) Date: Mon, 05 Oct 2015 03:12:12 -0700 Subject: check_log.sh: [ShellCheck](http://www.shellcheck.net/) fails (#1366) Message-ID: Running '$ shellcheck plugins-scripts/check_log.sh' results into the following result: In plugins-scripts/check_log.sh line 61: PATH="@TRUSTED_PATH@" ^-- SC2123: PATH is the shell search path. Use another name. In plugins-scripts/check_log.sh line 63: PROGNAME=`basename $0` ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 64: PROGPATH=`echo $0 | sed -e 's,[\\/][^\\/][^\\/]*$,,'` ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 67: . $PROGPATH/utils.sh ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 76: print_revision $PROGNAME $REVISION ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 90: exit $STATE_UNKNOWN ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 103: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 107: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 110: print_revision $PROGNAME $REVISION ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 111: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 114: print_revision $PROGNAME $REVISION ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 115: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 152: exit $STATE_UNKNOWN ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 160: if [ ! -e $logfile ]; then ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 162: exit $STATE_UNKNOWN ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 163: elif [ ! -r $logfile ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 165: exit $STATE_UNKNOWN ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 172: if [ ! -e $oldlog ]; then ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 173: cat $logfile > $oldlog ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 175: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 183: tempdiff=`/bin/mktemp /tmp/check_log.XXXXXXXXXX` ^-- SC2006: Use $(..) instead of legacy `..`. In plugins-scripts/check_log.sh line 185: tempdiff=`/bin/date '+%H%M%S'` ^-- SC2006: Use $(..) instead of legacy `..`. In plugins-scripts/check_log.sh line 187: touch $tempdiff ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 188: chmod 600 $tempdiff ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 191: diff $logfile $oldlog | grep -v "^>" > $tempdiff ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 194: count=`grep -c "$query" $tempdiff` ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 197: lastentry=`grep "$query" $tempdiff | tail -1` ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 199: rm -f $tempdiff ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 200: cat $logfile > $oldlog ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_log.sh line 210: exit $exitstatus ^-- SC2086: Double quote to prevent globbing and word splitting. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1366 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Oct 5 12:13:45 2015 From: notifications at github.com (waja) Date: Mon, 05 Oct 2015 03:13:45 -0700 Subject: check_oracle.sh: [ShellCheck](http://www.shellcheck.net/) fails (#1367) Message-ID: Running '$ shellcheck plugins-scripts/check_oracle.sh' results into the following: In plugins-scripts/check_oracle.sh line 9: PATH="@TRUSTED_PATH@" ^-- SC2123: PATH is the shell search path. Use another name. In plugins-scripts/check_oracle.sh line 11: PROGNAME=`basename $0` ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 12: PROGPATH=`echo $0 | sed -e 's,[\\/][^\\/][^\\/]*$,,'` ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 15: . $PROGPATH/utils.sh ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 32: print_revision $PROGNAME $REVISION ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 50: echo " ---> Requires select on v_$sysstat and v_$librarycache" ^-- SC2154: sysstat is referenced but not assigned. ^-- SC2154: librarycache is referenced but not assigned. In plugins-scripts/check_oracle.sh line 90: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 94: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 97: print_revision $PROGNAME $REVISION ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 98: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 101: print_revision $PROGNAME $REVISION ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 102: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 112: ORACLE_HOME=`IFS=: ^-- SC2006: Use $(..) instead of legacy `..`. In plugins-scripts/check_oracle.sh line 113: while read SID ORACLE_HOME junk; ^-- SC2034: junk appears unused. Verify it or export it. In plugins-scripts/check_oracle.sh line 116: echo $ORACLE_HOME; ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 124: [ -z "$ORACLE_HOME" -a -d $PROGPATH/oracle ] && ORACLE_HOME=$PROGPATH/oracle ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 129: exit $STATE_UNKNOWN ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 138: tnschk=` tnsping $2` ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 139: tnschk2=` echo $tnschk | grep -c OK` ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 140: if [ ${tnschk2} -eq 1 ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 143: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 146: exit $STATE_CRITICAL ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 150: namesctl status $2 | awk ' ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 156: status = '$STATE_OK' ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 160: status = '$STATE_CRITICAL' ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 168: pmonchk=`ps -ef | grep -v grep | grep -E -c "(asm|ora)_pmon_${2}$"` ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2009: Consider using pgrep instead of grepping ps output. In plugins-scripts/check_oracle.sh line 169: if [ ${pmonchk} -ge 1 ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 171: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 180: exit $STATE_CRITICAL ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 184: loginchk=`sqlplus dummy/user@$2 < /dev/null` ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 185: loginchk2=` echo $loginchk | grep -c ORA-01017` ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 186: if [ ${loginchk2} -eq 1 ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 188: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 190: loginchk3=` echo "$loginchk" | grep "ORA-" | head -1` ^-- SC2006: Use $(..) instead of legacy `..`. In plugins-scripts/check_oracle.sh line 192: exit $STATE_CRITICAL ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 196: connectchk=`sqlplus $2 < /dev/null` ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 197: connectchk2=` echo $connectchk | grep -c ORA-` ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 198: if [ ${connectchk2} -eq 0 ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 200: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 202: connectchk3=` echo "$connectchk" | grep "ORA-" | head -1` ^-- SC2006: Use $(..) instead of legacy `..`. In plugins-scripts/check_oracle.sh line 204: exit $STATE_CRITICAL ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 208: if [ ${5} -gt ${6} ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 210: exit $STATE_UNKNOWN ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 212: result=`sqlplus -s ${3}/${4}@${2} << EOF ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 222: if [ -n "`echo $result | grep ORA-`" ] ; then ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 223: error=` echo "$result" | grep "ORA-" | head -1` ^-- SC2006: Use $(..) instead of legacy `..`. In plugins-scripts/check_oracle.sh line 225: exit $STATE_CRITICAL ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 228: buf_hr=`echo "$result" | awk '/^[0-9\. \t]+$/ {print int($1)}'` ^-- SC2006: Use $(..) instead of legacy `..`. In plugins-scripts/check_oracle.sh line 229: buf_hrx=`echo "$result" | awk '/^[0-9\. \t]+$/ {print $1}'` ^-- SC2006: Use $(..) instead of legacy `..`. In plugins-scripts/check_oracle.sh line 230: result=`sqlplus -s ${3}/${4}@${2} << EOF ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 237: if [ -n "`echo $result | grep ORA-`" ] ; then ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 238: error=` echo "$result" | grep "ORA-" | head -1` ^-- SC2006: Use $(..) instead of legacy `..`. In plugins-scripts/check_oracle.sh line 240: exit $STATE_CRITICAL ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 243: lib_hr=`echo "$result" | awk '/^[0-9\. \t]+$/ {print int($1)}'` ^-- SC2006: Use $(..) instead of legacy `..`. In plugins-scripts/check_oracle.sh line 244: lib_hrx=`echo "$result" | awk '/^[0-9\. \t]+$/ {print $1}'` ^-- SC2006: Use $(..) instead of legacy `..`. In plugins-scripts/check_oracle.sh line 246: if [ $buf_hr -le ${5} -o $lib_hr -le ${5} ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 248: exit $STATE_CRITICAL ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 250: if [ $buf_hr -le ${6} -o $lib_hr -le ${6} ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 252: exit $STATE_WARNING ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 256: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 259: if [ ${6} -lt ${7} ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 261: exit $STATE_UNKNOWN ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 263: result=`sqlplus -s ${3}/${4}@${2} << EOF ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 276: if [ -n "`echo $result | grep ORA-`" ] ; then ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 277: error=` echo "$result" | grep "ORA-" | head -1` ^-- SC2006: Use $(..) instead of legacy `..`. In plugins-scripts/check_oracle.sh line 279: exit $STATE_CRITICAL ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 282: ts_free=`echo "$result" | awk '/^[ 0-9\.\t ]+$/ {print int($1)}'` ^-- SC2006: Use $(..) instead of legacy `..`. In plugins-scripts/check_oracle.sh line 283: ts_total=`echo "$result" | awk '/^[ 0-9\.\t ]+$/ {print int($2)}'` ^-- SC2006: Use $(..) instead of legacy `..`. In plugins-scripts/check_oracle.sh line 284: ts_pct=`echo "$result" | awk '/^[ 0-9\.\t ]+$/ {print int($3)}'` ^-- SC2006: Use $(..) instead of legacy `..`. In plugins-scripts/check_oracle.sh line 285: ts_pctx=`echo "$result" | awk '/^[ 0-9\.\t ]+$/ {print $3}'` ^-- SC2006: Use $(..) instead of legacy `..`. In plugins-scripts/check_oracle.sh line 288: exit $STATE_UNKNOWN ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 290: if [ "$ts_pct" -ge ${6} ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 292: exit $STATE_CRITICAL ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 294: if [ "$ts_pct" -ge ${7} ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 296: exit $STATE_WARNING ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 299: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 303: exit $STATE_UNKNOWN ^-- SC2086: Double quote to prevent globbing and word splitting. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1367 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Oct 5 12:16:45 2015 From: notifications at github.com (waja) Date: Mon, 05 Oct 2015 03:16:45 -0700 Subject: check_sensors.sh: [ShellCheck](http://www.shellcheck.net/) fails (#1368) Message-ID: Running '$ shellcheck plugins-scripts/check_sensors.sh' results into the following: In plugins-scripts/check_sensors.sh line 3: PATH="@TRUSTED_PATH@" ^-- SC2123: PATH is the shell search path. Use another name. In plugins-scripts/check_sensors.sh line 5: PROGNAME=`basename $0` ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_sensors.sh line 6: PROGPATH=`echo $0 | sed -e 's,[\\/][^\\/][^\\/]*$,,'` ^-- SC2006: Use $(..) instead of legacy `..`. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_sensors.sh line 9: . $PROGPATH/utils.sh ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_sensors.sh line 16: print_revision $PROGNAME $REVISION ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_sensors.sh line 23: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_sensors.sh line 29: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_sensors.sh line 33: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_sensors.sh line 36: print_revision $PROGNAME $REVISION ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_sensors.sh line 37: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_sensors.sh line 40: print_revision $PROGNAME $REVISION ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_sensors.sh line 41: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_sensors.sh line 44: sensordata=`sensors 2>&1` ^-- SC2006: Use $(..) instead of legacy `..`. In plugins-scripts/check_sensors.sh line 52: elif echo ${sensordata} | egrep ALARM > /dev/null; then ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_sensors.sh line 55: elif echo ${sensordata} | egrep FAULT > /dev/null \ ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_sensors.sh line 66: echo ${sensordata} ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_sensors.sh line 68: exit $exit ^-- SC2086: Double quote to prevent globbing and word splitting. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1368 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Oct 5 12:16:53 2015 From: notifications at github.com (=?UTF-8?B?RWxhbiBSdXVzYW3DpGU=?=) Date: Mon, 05 Oct 2015 03:16:53 -0700 Subject: check_log.sh: [ShellCheck](http://www.shellcheck.net/) fails (#1366) In-Reply-To: References: Message-ID: use backticks to quote output in ticket: ``` foo ``` -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1366#issuecomment-145488027 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Oct 5 12:53:43 2015 From: notifications at github.com (waja) Date: Mon, 05 Oct 2015 03:53:43 -0700 Subject: check_snmp: Timeticks are not being parsed correctly before performance data (#1369) Message-ID: When using certain OIDs with check_snmp the performance data after the '|' (pipe) is not being written because of the "Timeticks(n)" label. Currently, it will see that the output it is not an integer and it will not be displayed. $ /usr/lib/nagios/plugins/check_snmp -H localhost -C public -o .1.3.6.1.2.1.25.1.1.0 SNMP OK - Timeticks: (112941395) 13 days, 1:43:33.95 | See also https://github.com/nagios-plugins/nagios-plugins/issues/108 You can view, comment on, or merge this pull request online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1369 -- Commit Summary -- * Timeticks are not being parsed correctly before performance data -- File Changes -- M plugins/check_snmp.c (5) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1369.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1369.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1369 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Oct 5 13:05:22 2015 From: notifications at github.com (waja) Date: Mon, 05 Oct 2015 04:05:22 -0700 Subject: check_snmp can't do IPv6 [sf#3602488] (#1128) In-Reply-To: References: Message-ID: n-p has an issue about that to: https://github.com/nagios-plugins/nagios-plugins/issues/84 Patch maybe available at: https://github.com/nagios-plugins/nagios-plugins/commit/bf9aa4d647281425ba77b287ecf48501aeac9e7d#diff-a3c534e51df69a1d0c6a1b18fed94550 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1128#issuecomment-145496496 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Oct 5 14:30:06 2015 From: notifications at github.com (waja) Date: Mon, 05 Oct 2015 05:30:06 -0700 Subject: check_log.sh: [ShellCheck](http://www.shellcheck.net/) fails (#1366) In-Reply-To: References: Message-ID: @glensc thanks, fixed. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1366#issuecomment-145512504 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Oct 6 13:00:15 2015 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Tue, 06 Oct 2015 04:00:15 -0700 Subject: check_http: Allow for requesting TLSv1.1 and TLSv1.2 (#1373) In-Reply-To: References: Message-ID: Merged #1373. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1373#event-427819989 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Oct 6 13:14:00 2015 From: notifications at github.com (waja) Date: Tue, 06 Oct 2015 04:14:00 -0700 Subject: check_snmp.c: switched DEFAULT_TIMEOUT to DEFAULT_SOCKET_TIMEOUT (provid... (#1325) In-Reply-To: References: Message-ID: Closed #1325. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1325#event-427829475 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Oct 6 23:10:47 2015 From: notifications at github.com (Stuart Henderson) Date: Tue, 06 Oct 2015 14:10:47 -0700 Subject: check_http: Allow for requesting TLSv1.1 and TLSv1.2 (#1373) In-Reply-To: References: Message-ID: Thanks, this is sane syntax and a nice approach. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1373#issuecomment-146002208 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 7 09:23:21 2015 From: notifications at github.com (Oliver Skibbe) Date: Wed, 07 Oct 2015 00:23:21 -0700 Subject: check_http: added timeout to perfdata as max val (#1374) Message-ID: Added socket_timeout to time* perfdata values, see issue #1350 **Then** ``` # extended perfdata ./check_http -H 127.0.0.1 -t 30 -E HTTP OK: HTTP/1.1 200 OK - 380 bytes in 1,334 second response time |time=1,334256s;;;0,000000 size=380B;;;0 time_connect=0,000235s;;; time_headers=0,000029s;;; time_firstbyte=1,333924s;;; time_transfer=1,333947s;;; ./check_http -H 127.0.0.1 -t 30 HTTP OK: HTTP/1.1 200 OK - 380 bytes in 0,001 second response time |time=0,000551s;;;0,000000 size=380B;;;0 ``` **Now** ``` # extended perfdata ./check_http -H 127.0.0.1 -t 30 -E HTTP OK: HTTP/1.1 200 OK - 380 bytes in 0,006 second response time |time=0,005946s;;;0,000000;30,000000 size=380B;;;0 time_connect=0,000059s;;;;30,000000 time_headers=0,000035s;;;;30,000000 time_firstbyte=0,005737s;;;;30,000000 time_transfer=0,005806s;;;;30,000000 ./check_http -H 127.0.0.1 -t 30 HTTP OK: HTTP/1.1 200 OK - 380 bytes in 0,000 second response time |time=0,000499s;;;0,000000;30,000000 size=380B;;;0 ``` You can view, comment on, or merge this pull request online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1374 -- Commit Summary -- * * check_http: added timeout to perfdata as max val -- File Changes -- M plugins/check_http.c (12) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1374.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1374.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1374 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 7 09:44:17 2015 From: notifications at github.com (Oliver Skibbe) Date: Wed, 07 Oct 2015 00:44:17 -0700 Subject: check_disk: reduced compiler warnings (#1326) In-Reply-To: References: Message-ID: Ah okay, didnt know that. I changed uintmax_t to long long and %ju to %llu result @ Ubuntu 12.04 3.13.0-65-generic #105~precise1-Ubuntu SMP Tue Sep 22 13:22:42 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux ``` ./check_disk -vvv -w 10% -c 5% -p / calling stat on / Thresholds(pct) for / warn: 10,000000 crit 5,000000 calling stat on / For /, used_pct=82 free_pct=18 used_units=56842 free_units=13248 total_units=73214 used_inodes_pct=11 free_inodes_pct=89 fsp.fsu_blocksize=4096 mult=1048576 Freespace_units result=0 Freespace% result=0 Usedspace_units result=0 Usedspace_percent result=0 Usedinodes_percent result=0 Freeinodes_percent result=0 DISK OK - free space: / 13248 MB (18% inode=89%);| /=56842MB;65892;69553;0;73214 ``` -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1326#issuecomment-146103504 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 7 10:20:36 2015 From: notifications at github.com (Oliver Skibbe) Date: Wed, 07 Oct 2015 01:20:36 -0700 Subject: check_dhcp.c merged patch from #752 (#1375) Message-ID: Merged patch from #752 Sample output with exclusive/desired mode (-x): ``` # second dhcp server is detected as rogue ./check_dhcp -s 192.168.1.1 -x CRITICAL: Received 2 DHCPOFFER(s), Rogue DHCP Server detected! Server 192.168.1.2 offered 192.168.1.100 # support for multiple dhcp servers as well ./check_dhcp -s 192.168.1.1 -s 192.168.1.50 -x CRITICAL: Received 2 DHCPOFFER(s), Rogue DHCP Server detected! Server 192.168.1.2 offered 192.168.1.100 # both dhcp servers are correct ./check_dhcp -s 192.168.1.1 -s 192.168.1.2 -x OK: Received 2 DHCPOFFER(s), 2 of 2 requested servers responded, max lease time = 691200 sec. ``` You can view, comment on, or merge this pull request online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1375 -- Commit Summary -- * * check_dhcp.c added patch from #752 -- File Changes -- M plugins-root/check_dhcp.c (89) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1375.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1375.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1375 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 7 12:17:28 2015 From: notifications at github.com (Oliver Skibbe) Date: Wed, 07 Oct 2015 03:17:28 -0700 Subject: check_disk_smb uses -w and -c can't be set to be equal [sf#3316383] (#1005) In-Reply-To: References: Message-ID: So either remove default values which could break working setups or allow equal values and return with crit -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1005#issuecomment-146142849 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 7 12:25:36 2015 From: notifications at github.com (waja) Date: Wed, 07 Oct 2015 03:25:36 -0700 Subject: check_disk_smb uses -w and -c can't be set to be equal [sf#3316383] (#1005) In-Reply-To: References: Message-ID: same here: $ /usr/lib/nagios/plugins/check_disk -w 18% -c 18% -p / DISK OK - free space: / 4620 MB (48% inode=91%);| /=4947MB;8264;8264;0;10079 $ /usr/lib/nagios/plugins/check_disk -V check_disk v2.1.1 (monitoring-plugins 2.1.1) -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1005#issuecomment-146145716 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 7 12:29:44 2015 From: notifications at github.com (Oliver Skibbe) Date: Wed, 07 Oct 2015 03:29:44 -0700 Subject: check_mssql.pl: switched alarm timeout (#1376) Message-ID: alarm timeout now uses -t option, closes #991 If not set, default TIMEOUT from utils.pm will be used ``` $timeout = $TIMEOUT unless (defined($timeout)) ``` You can view, comment on, or merge this pull request online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1376 -- Commit Summary -- * * check_mssql.pl: switched alarm timeout -- File Changes -- M plugins-scripts/check_mssql.pl (2) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1376.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1376.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1376 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 7 13:04:26 2015 From: notifications at github.com (Oliver Skibbe) Date: Wed, 07 Oct 2015 04:04:26 -0700 Subject: check_disk_smb uses -w and -c can't be set to be equal [sf#3316383] (#1005) In-Reply-To: References: Message-ID: Closed #1005. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1005#event-428990786 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 7 16:20:35 2015 From: notifications at github.com (Stuart Henderson) Date: Wed, 07 Oct 2015 07:20:35 -0700 Subject: Problem with check_disk pthread checks (#1377) Message-ID: The pthread code added to check_disk in 6986aa1 isn't portable and results in timeouts at least on OpenBSD. I asked for advice about it and had a nice detailed reply explaining the situation (https://marc.info/?l=openbsd-tech&m=144421743119272&w=2). I had a look at fixing it and have something which "works" but isn't correct, but looking at druchoo's comment on the commit on github, I wonder if it works as expected at all anyway? -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1377 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Oct 8 07:45:18 2015 From: notifications at github.com (Oliver Skibbe) Date: Wed, 07 Oct 2015 22:45:18 -0700 Subject: check_smtp.c: modified SSL check for use with -e (#1378) Message-ID: Currently STARTTLS check does not work with -e if there's text like '220 hostname ESMTP*'. This is caused by SMTP answer from host. Postfix answer: **220 2.0.0 Ready to start TLS** Exchange 2010: **220 2.0.0 SMTP server ready** This fix introduces a constant for '220 2.0.0' which is used to check if TLS connection is ok Closes #1093 You can view, comment on, or merge this pull request online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1378 -- Commit Summary -- * check_smtp.c: modified SSL check for use with -e -- File Changes -- M NEWS (4) M plugins-scripts/Makefile.am (1) M plugins/check_http.c (22) M plugins/check_smtp.c (14) M plugins/netutils.h (10) M plugins/sslutils.c (81) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1378.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1378.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1378 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Oct 8 07:46:18 2015 From: notifications at github.com (Oliver Skibbe) Date: Wed, 07 Oct 2015 22:46:18 -0700 Subject: check_smtp error when combining -S and -e [sf#3556040] (#1093) In-Reply-To: References: Message-ID: It seems that this issue is active, i've done some debugging and noticed that postfix answers with: postfix 2.9.6-1~12.04.3 @ Ubuntu 12.04 ```220 2.0.0 Ready to start TLS``` Exchange 2010 @ Windows 2008R2 ```220 2.0.0 SMTP server ready``` In line 234, check_smtp matches against server_expect (-e) which will never succeed, so we could go for "220 2.0.0", defined as a constant. See patch in PR #1378 Addition: maybe the test could be improved, as it only expects for "220" which is returned, but does not test any following string -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1093#issuecomment-146426579 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Oct 8 08:38:28 2015 From: notifications at github.com (Oliver Skibbe) Date: Wed, 07 Oct 2015 23:38:28 -0700 Subject: check_smtp.c: modified SSL check for use with -e (#1378) In-Reply-To: References: Message-ID: Closed #1378. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1378#event-429954407 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Oct 8 09:07:43 2015 From: notifications at github.com (Oliver Skibbe) Date: Thu, 08 Oct 2015 00:07:43 -0700 Subject: check_smtp.c: modified SSL check for use with -e (#1379) Message-ID: currently STARTTLS check does not work with -e if there's text like '220 hostname ESMTP*'. This is caused by SMTP answer from host. Postfix answer: 220 2.0.0 Ready to start TLS Exchange 2010: 220 2.0.0 SMTP server ready This fix checks against 220 and closes #1093 You can view, comment on, or merge this pull request online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1379 -- Commit Summary -- * check_smtp.c: modified SSL check for use with -e -- File Changes -- M plugins/check_smtp.c (2) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1379.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1379.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1379 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Oct 8 09:34:55 2015 From: notifications at github.com (Oliver Skibbe) Date: Thu, 08 Oct 2015 00:34:55 -0700 Subject: check_http "-L" output doesn't print closing anchor tag [sf#3588978] (#1116) In-Reply-To: References: Message-ID: Not very easy to implement in the current implementation as the return text and state are static in netutils.c ``` /* initialize alarm signal handling, set socket timeout, start timer */ (void) signal (SIGALRM, socket_timeout_alarm_handler); (void) alarm (socket_timeout); ``` So we could extend netutils.c to support return text -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1116#issuecomment-146444614 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Oct 8 10:21:27 2015 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Thu, 08 Oct 2015 01:21:27 -0700 Subject: drop superfluous libexecdir (#1360) In-Reply-To: References: Message-ID: Another issue is that we work with two branches, `maint` and `master`. PRs are always submitted against the "default branch" as configured in GitHub, and we then apply the PR'd commits to either of the two branches as we see fit. Merging the PR'd branch into the non-default branch won't work, of course ... -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1360#issuecomment-146453608 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Oct 8 10:24:37 2015 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Thu, 08 Oct 2015 01:24:37 -0700 Subject: check_smtp.c: modified SSL check for use with -e (#1379) In-Reply-To: References: Message-ID: Merged #1379. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1379#event-430026404 -------------- next part -------------- An HTML attachment was scrubbed... URL: From ingo.kley at web.de Thu Oct 8 12:43:52 2015 From: ingo.kley at web.de (Ingo Kley) Date: Thu, 8 Oct 2015 12:43:52 +0200 Subject: stop Message-ID: <561648E8.8060902@web.de> stop From notifications at github.com Thu Oct 8 16:32:15 2015 From: notifications at github.com (waja) Date: Thu, 08 Oct 2015 07:32:15 -0700 Subject: check_dhcp.c merged patch from #752 (#1375) In-Reply-To: References: Message-ID: It would be cool, if we can find out the author of this patch and give contribution. If we have an email address, you can commit with this address as Author. If we can't find a related mail address, we should add the Author to the THANKS.in file. Looking at http://sourceforge.net/u/pcervicek/wiki/Home/ his name is "Patrick Cervicek". -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1375#issuecomment-146564315 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Oct 8 16:36:27 2015 From: notifications at github.com (Oliver Skibbe) Date: Thu, 08 Oct 2015 07:36:27 -0700 Subject: check_dhcp.c merged patch from #752 (#1375) In-Reply-To: References: Message-ID: Okay, tomorrow I'll edit my commit -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1375#issuecomment-146565347 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Oct 8 16:43:16 2015 From: notifications at github.com (waja) Date: Thu, 08 Oct 2015 07:43:16 -0700 Subject: check_mssql.pl: switched alarm timeout (#1376) In-Reply-To: References: Message-ID: Please give contribution here. The SF profile seems to be http://sourceforge.net/u/wopfel/profile/. Using google it seems (https://dev.icinga.org/attachments/download/1899/0001-Added-install-systemd-hint-in-Makefile.patch) he is now: Bernd Arnold -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1376#issuecomment-146567219 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Fri Oct 9 12:04:19 2015 From: notifications at github.com (Oliver Skibbe) Date: Fri, 09 Oct 2015 03:04:19 -0700 Subject: check_mssql.pl: switched alarm timeout (#1376) In-Reply-To: References: Message-ID: Reopened #1376. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1376#event-431250926 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Oct 12 10:11:23 2015 From: notifications at github.com (waja) Date: Mon, 12 Oct 2015 01:11:23 -0700 Subject: check_disk: missing -lrt on Solaris (#1329) In-Reply-To: References: Message-ID: @druchoo complaint at https://github.com/monitoring-plugins/monitoring-plugins/commit/6986aa1d0a352d8d02eed4896034631fffd25a27#commitcomment-9428666 about nanosleep anyways -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1329#issuecomment-147324569 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Oct 12 11:11:03 2015 From: notifications at github.com (waja) Date: Mon, 12 Oct 2015 02:11:03 -0700 Subject: check_disk: no longer hangs on hanging filesystems (#1186) In-Reply-To: References: Message-ID: @lauser, there are reported issues with this commit: https://github.com/monitoring-plugins/monitoring-plugins/commit/6986aa1d0a352d8d02eed4896034631fffd25a27#commitcomment-9428666 https://github.com/monitoring-plugins/monitoring-plugins/issues/1329 https://github.com/monitoring-plugins/monitoring-plugins/issues/1377 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1186#issuecomment-147340476 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Mon Oct 12 11:35:06 2015 From: notifications at github.com (waja) Date: Mon, 12 Oct 2015 02:35:06 -0700 Subject: check_disk: no longer hangs on hanging filesystems (#1186) In-Reply-To: References: Message-ID: reverted by 11c5796d0a3ac3cb9ccbf004f67ebf6eabcc95bc -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1186#issuecomment-147348175 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Oct 13 10:37:55 2015 From: notifications at github.com (Lars) Date: Tue, 13 Oct 2015 01:37:55 -0700 Subject: check_icmp: Add IPv6 support (#1384) Message-ID: This commit adds IPv6 capabilities to check_icmp. It is now possible to specify the address family using the arguments -4 (default) or -6. To make the change possible we had to move the argument parsing previous to creating the socket to be able to create it with the correct address family. This commit also fixes some gcc 4.9.2 compiler warnings. It has been tested with several current linux distributions (debian, ubuntu, rh, sles). This commit fixes monitoring-plugins/monitoring-plugins#1291 You can view, comment on, or merge this pull request online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1384 -- Commit Summary -- * check_icmp: Add IPv6 support -- File Changes -- M plugins-root/check_icmp.c (491) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1384.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1384.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1384 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Oct 13 11:34:59 2015 From: notifications at github.com (waja) Date: Tue, 13 Oct 2015 02:34:59 -0700 Subject: check_procs: On solaris10 args field empty but ps -ef shows args (#1203) In-Reply-To: References: Message-ID: Closed #1203 via #1371. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1203#event-433827269 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Oct 13 12:32:41 2015 From: notifications at github.com (waja) Date: Tue, 13 Oct 2015 03:32:41 -0700 Subject: check_http: support the concept of virtual ports (#1352) In-Reply-To: References: Message-ID: merging this into recent master (edcf7d64ee03f4b7fceb1ef470fb900572bce096), the tests succeeds: https://travis-ci.org/waja/monitoring-plugins/builds/85091328 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1352#issuecomment-147677296 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Oct 13 12:36:54 2015 From: notifications at github.com (waja) Date: Tue, 13 Oct 2015 03:36:54 -0700 Subject: check_http: support the concept of virtual ports (#1352) In-Reply-To: References: Message-ID: @odenbach it would be nice to have automated tests verifying this feature doesn't break in the future. This is what we are running automated on Travis CI for example. Those checks are implemented in plugins/tests/check_http.t and plugins/t/check_http.t for check_http. Many thanks for looking into this. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1352#issuecomment-147677954 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Oct 13 12:43:03 2015 From: notifications at github.com (waja) Date: Tue, 13 Oct 2015 03:43:03 -0700 Subject: check_icmp: fails to compile on Solaris 10 and 11 (#1317) In-Reply-To: References: Message-ID: @doombirdAD, @jyoung15 in which version did this problem occur the first time for you? -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1317#issuecomment-147678984 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Oct 13 12:47:31 2015 From: notifications at github.com (waja) Date: Tue, 13 Oct 2015 03:47:31 -0700 Subject: check_dig is case sensitive (#1233) In-Reply-To: References: Message-ID: @ch82 you are more then welcome to provide a fix. For example via a Pull Request. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1233#issuecomment-147679615 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Oct 13 13:33:36 2015 From: notifications at github.com (waja) Date: Tue, 13 Oct 2015 04:33:36 -0700 Subject: check_icmp: fails to compile on Solaris 10 and 11 (#1317) In-Reply-To: References: Message-ID: A ... it's in master BUT not in any official release yet. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1317#issuecomment-147689958 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Oct 13 13:44:12 2015 From: notifications at github.com (waja) Date: Tue, 13 Oct 2015 04:44:12 -0700 Subject: check_disk: format warning (#1331) In-Reply-To: References: Message-ID: this code was introduced with 77f2c84d2f599d86a60586494169dcab17853e3a -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1331#issuecomment-147692096 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 14 08:35:21 2015 From: notifications at github.com (Oliver Skibbe) Date: Tue, 13 Oct 2015 23:35:21 -0700 Subject: check_smtp: Output is not consistent (#1380) In-Reply-To: References: Message-ID: In IRC channel we discussed if we drop "SERVICE STATUS - " (e.g. CRITICAL - , WARNING -) in output because it should be printed by GUIs. What to do? I would fix this output but we must decide whats the future way. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1380#issuecomment-147951575 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 14 09:11:12 2015 From: notifications at github.com (Oliver Skibbe) Date: Wed, 14 Oct 2015 00:11:12 -0700 Subject: check_dig: expected address is an exact match (#1385) Message-ID: Expected address is not fully matched for example Assume i have a host which has the IP 173.194.116.215 and i want to check against it: ``?./check_dig -H dns1 -vvvv -l www.google.de -a 173.194.116.215``` As expected check_dig returns OK, but if its checked for .21: ``?./check_dig -H dns1 -vvvv -l www.google.de -a 173.194.116.21``` It returns also OK, because strstr/strcasestr just locate substrings but it might return a WARNING/CRITICAL because it matches not 100% To not break working setups we could add a new option -e --exact-match which toggles strict checking and then returns WARN/CRIT if the result and the expected result do not match 100% --- Reply to this email directly or view it on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1385 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 14 10:29:41 2015 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Wed, 14 Oct 2015 01:29:41 -0700 Subject: check_smtp: Output is not consistent (#1380) In-Reply-To: References: Message-ID: > What to do? I would fix this output but we must decide whats the future > way. If you'd like to fix this right now, I'd let `check_smtp` spit out `SERVICE STATUS - [...]` consistently, as that's the format currently emitted by most other plugins. We can discuss changing the output format (or making it configurable) for all plugins at a later point in time. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1380#issuecomment-147973258 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 14 10:42:52 2015 From: notifications at github.com (Sven Nierlein) Date: Wed, 14 Oct 2015 01:42:52 -0700 Subject: check_smtp: Output is not consistent (#1380) In-Reply-To: References: Message-ID: I definitly like the SERVICE STATUS - OUTPUT|PERF format most. From time to time i have to run the plugins manually from the command line and it definitly helps. Also, like Holger already said, this is the most common format. When it comes to GUIs, i could imagine GUIs removing that state if they choose a color instead, but something the GUI should do, not the plugins. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1380#issuecomment-147976315 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 14 12:01:44 2015 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Wed, 14 Oct 2015 03:01:44 -0700 Subject: check_smtp: Output is not consistent (#1380) In-Reply-To: References: Message-ID: > I definitly like the SERVICE STATUS - OUTPUT|PERF format most. It seems I'm the only one who [doesn't like it][1] :-) I should just [make this configurable][2] with a command-line flag one day, without changing the current format by default. > From time to time i have to run the plugins manually from the command line > and it definitly helps. I see your point for the `STATUS` part, but the `SERVICE` part helps as well? [1]: https://www.monitoring-plugins.org/archive/devel/2007-July/006121.html [2]: https://github.com/monitoring-plugins/monitoring-plugins/commit/006597a12d28d9cd752b3eeb56dff3bc97049f4c -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1380#issuecomment-147997825 -------------- next part -------------- An HTML attachment was scrubbed... URL: From spammagnet10 at gmail.com Wed Oct 14 12:23:59 2015 From: spammagnet10 at gmail.com (Jam Mulch) Date: Wed, 14 Oct 2015 06:23:59 -0400 Subject: check_smtp: Output is not consistent (#1380) In-Reply-To: References: Message-ID: <561E2D3F.5040602@gmail.com> Saving 20 or 30 characters won't do much to solve the detail output limitations of monitoring applications such as nagios. I have some checks that generate 100+ lines of output. What I'm doing is to store the detail output in an array and save it to a file, then include a link to the file in the normal plugin multi-line output. Lately, I've gotten a little fancier. I have two files, one for 'ok' output, and another for 'problem' output, and have two links in the plugin detail output...one for the current output, and another for the last 'problem' or 'ok' output depending on the current state of the check. That way, if the last problem has already cleared before I get around to looking at it, I can see the last non-ok details and if there is currently a problem, I can see the last 'ok' check output before the current problem occurred. I know this is not very portable, but it represents another way of thinking about managing plugin output. /usr/local/nagios/ssi/results/services/ok//.html /usr/local/nagios/ssi/results/services/problem//.html This helps users to diagnose problems, particularly for plugins that check several things at once, like all the volumes on a NetApp cluster, or all the VIPs on an F5 BigIP. On 10/14/2015 6:01 AM, Holger Wei? wrote: > > I definitly like the SERVICE STATUS - OUTPUT|PERF format most. > > It seems I'm the only one who doesn't like it > > :-) I should just make this configurable > > with a command-line flag one day, without changing the current format > by default. > > From time to time i have to run the plugins manually from the > command line and it definitly helps. > > I see your point for the |STATUS| part, but the |SERVICE| part helps > as well? > > ? > Reply to this email on GitHub > . > -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 14 12:26:52 2015 From: notifications at github.com (Oliver Skibbe) Date: Wed, 14 Oct 2015 03:26:52 -0700 Subject: check_smtp: Output is not consistent (#1380) In-Reply-To: References: Message-ID: Do you mean for example "check_smtp WARNING - Foobar|asdf=1" ? -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1380#issuecomment-148006277 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 14 12:42:09 2015 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Wed, 14 Oct 2015 03:42:09 -0700 Subject: check_smtp: Output is not consistent (#1380) In-Reply-To: References: Message-ID: > Do you mean for example "check_smtp WARNING - Foobar|asdf=1" ? `SMTP WARNING - Foobar|asdf=1` -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1380#issuecomment-148009629 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 14 13:30:24 2015 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Wed, 14 Oct 2015 04:30:24 -0700 Subject: check_smtp: Output is not consistent (#1380) In-Reply-To: References: Message-ID: > Imho is STATUS - Output|perf the best option. Yes, personally I'd let plugins use that format on the command line and I'd omit the `STATUS` when called from Icinga/whatever. An option that makes this configurable should make everybody happy (I hope). -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1380#issuecomment-148023276 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 14 16:07:45 2015 From: notifications at github.com (Martijn Grendelman) Date: Wed, 14 Oct 2015 07:07:45 -0700 Subject: check_http: Odd bug with SSL check. (#1358) In-Reply-To: References: Message-ID: I have traced the problem back to the use of mpm_itk. If I disable the mpm_itk module, the HTTPS check works as expected. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1358#issuecomment-148061295 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 14 16:26:37 2015 From: notifications at github.com (Martijn Grendelman) Date: Wed, 14 Oct 2015 07:26:37 -0700 Subject: check_http: Odd bug with SSL check. (#1358) In-Reply-To: References: Message-ID: The bug is in mpm-itk. It is reported here: http://lists.err.no/pipermail/mpm-itk/2015-September/000914.html and a fix is available later in that thread. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1358#issuecomment-148066299 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Oct 15 10:11:44 2015 From: notifications at github.com (Oliver Skibbe) Date: Thu, 15 Oct 2015 01:11:44 -0700 Subject: check_dig is case sensitive (#1233) In-Reply-To: References: Message-ID: @stirmin i would like to add your patch as PR but i need your mail address to commit for you -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1233#issuecomment-148313309 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Oct 15 10:19:14 2015 From: notifications at github.com (stirnim) Date: Thu, 15 Oct 2015 01:19:14 -0700 Subject: check_dig is case sensitive (#1233) In-Reply-To: References: Message-ID: I've not created a pull request. Can't you just create one yourself? It's one line that changed. On Oct 15, 2015 10:11 AM, "Oliver Skibbe" wrote: > @stirmin i would like to add your patch as PR but i need your mail address > to commit for you > > ? > Reply to this email directly or view it on GitHub > > > . > --- Reply to this email directly or view it on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1233#issuecomment-148314885 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Oct 15 10:20:56 2015 From: notifications at github.com (Oliver Skibbe) Date: Thu, 15 Oct 2015 01:20:56 -0700 Subject: check_dig is case sensitive (#1233) In-Reply-To: References: Message-ID: Yeah i've prepared a PR for your fix, but it wanted to set you as author for kudos =) -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1233#issuecomment-148315169 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Oct 15 10:28:11 2015 From: notifications at github.com (stirnim) Date: Thu, 15 Oct 2015 01:28:11 -0700 Subject: check_dig is case sensitive (#1233) In-Reply-To: References: Message-ID: nice ;) daniel.stirnimann @ gmail . com On Oct 15, 2015 10:20 AM, "Oliver Skibbe" wrote: > Yeah i've prepared a PR for your fix, but it wanted to set you as author > for kudos =) > > ? > Reply to this email directly or view it on GitHub > > > . > --- Reply to this email directly or view it on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1233#issuecomment-148316438 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Oct 15 11:03:37 2015 From: notifications at github.com (Oliver Skibbe) Date: Thu, 15 Oct 2015 02:03:37 -0700 Subject: check_dig: expected answer is now incasesensitive (#1386) Message-ID: check_dig was casesensitive if an expected answer is given. Switching strstr with strcasestr fixes this issue While testing i noticed a bug where expected is not an exact match New issue for that is opened #1385 This fix closes #1233 You can view, comment on, or merge this pull request online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1386 -- Commit Summary -- * check_dig: expected answer is now incasesensitive -- File Changes -- M plugins/check_dig.c (2) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1386.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1386.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1386 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Oct 15 11:18:24 2015 From: notifications at github.com (=?UTF-8?B?SG9sZ2VyIFdlacOf?=) Date: Thu, 15 Oct 2015 02:18:24 -0700 Subject: check_dig: expected answer is now incasesensitive (#1386) In-Reply-To: References: Message-ID: The `strcasestr(3)` function is non-standard, so we must add the [appropriate Gnulib module][1] (as I [mentioned][2] in #1233). I can do that for the 2.2 release, just didn't get to that yet. [1]: https://www.gnu.org/software/gnulib/manual/html_node/strcasestr.html [2]: https://github.com/monitoring-plugins/monitoring-plugins/issues/1233#issuecomment-34872523 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1386#issuecomment-148327779 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 21 17:38:55 2015 From: notifications at github.com (waja) Date: Wed, 21 Oct 2015 08:38:55 -0700 Subject: check_flexlm has several design flaws (#1387) Message-ID: that this patch partially addresses (addresses points 2 to 4): 1/ it requires the PATH_TO_LMSTAT variable to be setup in util.pm while this file is nnot a config file. Thus each time the package is upgraded, the config get lost 2/ it doesn't support finding lmstat in PATH 3/ it doesn't support getting lmstat binary path from command line switchs 4/ usage is wrongly documented (needs the -F switch to provide the licence file PATH) 5/ LM_LICENCE_FILE variable not supported 6/ licence directory instead of licence path not supported. The patch was proposed at https://github.com/nagios-plugins/nagios-plugins/issues/118 and I adjusted it to apply it to our code. You can view, comment on, or merge this pull request online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1387 -- Commit Summary -- * check_flexlm has several design flaws -- File Changes -- M plugins-scripts/check_flexlm.pl (21) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1387.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1387.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1387 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Thu Oct 22 16:41:46 2015 From: notifications at github.com (Lars) Date: Thu, 22 Oct 2015 07:41:46 -0700 Subject: check_icmp: Add IPv6 support (#1384) In-Reply-To: References: Message-ID: Found a bug in parameter handling. The provided -w -c values were not used, sorry. Has been fixed in 2nd commit. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1384#issuecomment-150245619 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 28 00:41:48 2015 From: notifications at github.com (waja) Date: Tue, 27 Oct 2015 16:41:48 -0700 Subject: Fixing the stuff that is broken on btrfs (#1388) Message-ID: This patch was shared by Klaus Ethgen (@mowgli) at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800345#29 (Closes #1357) You can view, comment on, or merge this pull request online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1388 -- Commit Summary -- * Fixing the stuff that is broken on btrfs -- File Changes -- M plugins/check_disk.c (5) -- Patch Links -- https://github.com/monitoring-plugins/monitoring-plugins/pull/1388.patch https://github.com/monitoring-plugins/monitoring-plugins/pull/1388.diff -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1388 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Wed Oct 28 19:37:59 2015 From: notifications at github.com (2bjc466) Date: Wed, 28 Oct 2015 11:37:59 -0700 Subject: check_http not following redirects containing angle brackets (#1389) Message-ID: Hello, I am having trouble getting check_http to follow redirects that contain angle brackets. A web site is issuing a 302 and a URL containing 'proxycustom=' and check_http is attempting to use 'proxycustom=' to follow the redirect. Here's partial verbose output from the command I am using: ./check_http --critical=20 --hostname=google-search-appliance --port=80 --string='Search Home' --url=/ --warning=10 --onredirect=follow -v GET / HTTP/1.1 User-Agent: check_http/v2.1.2 (monitoring-plugins 2.1.2) Connection: close Host: google-search-appliance http://google-search-appliance:80/ is 293 characters STATUS: HTTP/1.1 302 Found **** HEADER **** Date: Wed, 28 Oct 2015 18:23:07 GMT Server: Google Search Appliance Location: /search?site=default_collection&client=default_frontend&output=xml_no_dtd&proxystylesheet=default_frontend&proxycustom= Content-Type: text/html Content-Length: 0 Connection: close **** CONTENT **** Redirection to http://google-search-appliance:80/search?site=default_collection&client=default_frontend&output=xml_no_dtd&proxystylesheet=default_frontend&proxycustom= GET /search?site=default_collection&client=default_frontend&output=xml_no_dtd&proxystylesheet=default_frontend&proxycustom= HTTP/1.1 User-Agent: check_http/v2.1.2 (monitoring-plugins 2.1.2) Connection: close Host: google-search-appliance http://google-search-appliance:80/search?site=default_collection&client=default_frontend&output=xml_no_dtd&proxystylesheet=default_frontend&proxycustom= is 19793 characters STATUS: HTTP/1.1 200 OK **** HEADER **** Let me know if I can provide any additional information. Thanks! -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1389 -------------- next part -------------- An HTML attachment was scrubbed... URL: From diver at spbau.ru Tue Oct 27 15:33:21 2015 From: diver at spbau.ru (Evgeny Beysembaev) Date: Tue, 27 Oct 2015 14:33:21 -0000 Subject: check_dhcp plugin issue Message-ID: <562F8B2B.7080707@spbau.ru> Hello! Is check_dhcp nagios monitoring plugin still supported? The problem is, my DHCP server (Debian Stable, isc-dhcp) ignores requests from the plugin, and i have a suspicion that it malformes the requests. Is it possible to submit the problem or maybe send a patch? Thank you. Evgeny Beysembaev From Muhammad.Zahid at amsa.gov.au Fri Oct 30 04:14:28 2015 From: Muhammad.Zahid at amsa.gov.au (Zahid, Muhammad) Date: Fri, 30 Oct 2015 03:14:28 -0000 Subject: check_swap is not get compiled along with other plugins in nagios-plugin-1.5 [SEC=UNCLASSIFIED] Message-ID: <9BBC36A159F2D04783893E1D3BDAF7517D0713EA@EXCCRMBX.amsa.gov.au> Hi I am not sure that this address is still active. I was trying to compile the nagios-plugins-1.5, it compiles all other plugins except check_swap. Does anyone knows why it behaving like that. Regards Muhammad Zahid SYSTEM ADMINISTRATOR - UNIX IT SERVICES CORPORATE SERVICES 82 Northbourne Avenue, Braddon ACT 2612 GPO BOX 2181, Canberra ACT 2601 p 02 6279 5959 e muhammad.zahid at amsa.gov.au w www.amsa.gov.au [cid:image001.jpg at 01D1131D.445D0060][cid:image002.jpg at 01D1131D.445D0060] [cid:image003.jpg at 01D1131D.445D0060] [cid:image004.jpg at 01D1131D.445D0060] PPlease consider the environment before printing this email ********************************************************************** If you have received this transmission in error please note that that error does not constitute waiver of any confidentiality, privilege or copyright in respect of information in the e-mail or attachments and any use of this material is prohibited. Please notify the sender by return email and delete all copies of this transmission and attachments. ********************************************************************** -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image001.jpg Type: image/jpeg Size: 19615 bytes Desc: image001.jpg URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image002.jpg Type: image/jpeg Size: 20888 bytes Desc: image002.jpg URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image003.jpg Type: image/jpeg Size: 16283 bytes Desc: image003.jpg URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: image004.jpg Type: image/jpeg Size: 6537 bytes Desc: image004.jpg URL: