Running '$ shellcheck plugins-scripts/check_oracle.sh' results into the following: In plugins-scripts/check_oracle.sh line 9: PATH="@TRUSTED_PATH@" ^-- SC2123: PATH is the shell search path. Use another name. In plugins-scripts/check_oracle.sh line 11: PROGNAME=<code>basename $0</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 12: PROGPATH=<code>echo $0 | sed -e 's,[\\/][^\\/][^\\/]*$,,'</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 15: . $PROGPATH/utils.sh ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 32: print_revision $PROGNAME $REVISION ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 50: echo " ---> Requires select on v_$sysstat and v_$librarycache" ^-- SC2154: sysstat is referenced but not assigned. ^-- SC2154: librarycache is referenced but not assigned. In plugins-scripts/check_oracle.sh line 90: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 94: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 97: print_revision $PROGNAME $REVISION ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 98: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 101: print_revision $PROGNAME $REVISION ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 102: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 112: ORACLE_HOME=<code>IFS=: ^-- SC2006: Use $(..) instead of legacy</code>..`. In plugins-scripts/check_oracle.sh line 113: while read SID ORACLE_HOME junk; ^-- SC2034: junk appears unused. Verify it or export it. In plugins-scripts/check_oracle.sh line 116: echo $ORACLE_HOME; ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 124: [ -z "$ORACLE_HOME" -a -d $PROGPATH/oracle ] && ORACLE_HOME=$PROGPATH/oracle ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 129: exit $STATE_UNKNOWN ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 138: tnschk=<code>tnsping $2</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 139: tnschk2=<code>echo $tnschk | grep -c OK</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 140: if [ ${tnschk2} -eq 1 ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 143: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 146: exit $STATE_CRITICAL ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 150: namesctl status $2 | awk ' ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 156: status = '$STATE_OK' ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 160: status = '$STATE_CRITICAL' ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 168: pmonchk=<code>ps -ef | grep -v grep | grep -E -c "(asm|ora)_pmon_${2}$"</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. ^-- SC2009: Consider using pgrep instead of grepping ps output. In plugins-scripts/check_oracle.sh line 169: if [ ${pmonchk} -ge 1 ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 171: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 180: exit $STATE_CRITICAL ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 184: loginchk=<code>sqlplus dummy/user@$2 < /dev/null</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 185: loginchk2=<code>echo $loginchk | grep -c ORA-01017</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 186: if [ ${loginchk2} -eq 1 ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 188: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 190: loginchk3=<code>echo "$loginchk" | grep "ORA-" | head -1</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. In plugins-scripts/check_oracle.sh line 192: exit $STATE_CRITICAL ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 196: connectchk=<code>sqlplus $2 < /dev/null</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 197: connectchk2=<code>echo $connectchk | grep -c ORA-</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 198: if [ ${connectchk2} -eq 0 ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 200: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 202: connectchk3=<code>echo "$connectchk" | grep "ORA-" | head -1</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. In plugins-scripts/check_oracle.sh line 204: exit $STATE_CRITICAL ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 208: if [ ${5} -gt ${6} ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 210: exit $STATE_UNKNOWN ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 212: result=<code>sqlplus -s ${3}/${4}@${2} << EOF ^-- SC2006: Use $(..) instead of legacy</code>..`. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 222: if [ -n "<code>echo $result | grep ORA-</code>" ] ; then ^-- SC2006: Use $(..) instead of legacy <code>..</code>. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 223: error=<code>echo "$result" | grep "ORA-" | head -1</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. In plugins-scripts/check_oracle.sh line 225: exit $STATE_CRITICAL ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 228: buf_hr=<code>echo "$result" | awk '/^[0-9\. \t]+$/ {print int($1)}'</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. In plugins-scripts/check_oracle.sh line 229: buf_hrx=<code>echo "$result" | awk '/^[0-9\. \t]+$/ {print $1}'</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. In plugins-scripts/check_oracle.sh line 230: result=<code>sqlplus -s ${3}/${4}@${2} << EOF ^-- SC2006: Use $(..) instead of legacy</code>..`. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 237: if [ -n "<code>echo $result | grep ORA-</code>" ] ; then ^-- SC2006: Use $(..) instead of legacy <code>..</code>. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 238: error=<code>echo "$result" | grep "ORA-" | head -1</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. In plugins-scripts/check_oracle.sh line 240: exit $STATE_CRITICAL ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 243: lib_hr=<code>echo "$result" | awk '/^[0-9\. \t]+$/ {print int($1)}'</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. In plugins-scripts/check_oracle.sh line 244: lib_hrx=<code>echo "$result" | awk '/^[0-9\. \t]+$/ {print $1}'</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. In plugins-scripts/check_oracle.sh line 246: if [ $buf_hr -le ${5} -o $lib_hr -le ${5} ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 248: exit $STATE_CRITICAL ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 250: if [ $buf_hr -le ${6} -o $lib_hr -le ${6} ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 252: exit $STATE_WARNING ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 256: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 259: if [ ${6} -lt ${7} ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 261: exit $STATE_UNKNOWN ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 263: result=<code>sqlplus -s ${3}/${4}@${2} << EOF ^-- SC2006: Use $(..) instead of legacy</code>..`. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 276: if [ -n "<code>echo $result | grep ORA-</code>" ] ; then ^-- SC2006: Use $(..) instead of legacy <code>..</code>. ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 277: error=<code>echo "$result" | grep "ORA-" | head -1</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. In plugins-scripts/check_oracle.sh line 279: exit $STATE_CRITICAL ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 282: ts_free=<code>echo "$result" | awk '/^[ 0-9\.\t ]+$/ {print int($1)}'</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. In plugins-scripts/check_oracle.sh line 283: ts_total=<code>echo "$result" | awk '/^[ 0-9\.\t ]+$/ {print int($2)}'</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. In plugins-scripts/check_oracle.sh line 284: ts_pct=<code>echo "$result" | awk '/^[ 0-9\.\t ]+$/ {print int($3)}'</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. In plugins-scripts/check_oracle.sh line 285: ts_pctx=<code>echo "$result" | awk '/^[ 0-9\.\t ]+$/ {print $3}'</code> ^-- SC2006: Use $(..) instead of legacy <code>..</code>. In plugins-scripts/check_oracle.sh line 288: exit $STATE_UNKNOWN ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 290: if [ "$ts_pct" -ge ${6} ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 292: exit $STATE_CRITICAL ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 294: if [ "$ts_pct" -ge ${7} ] ; then ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 296: exit $STATE_WARNING ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 299: exit $STATE_OK ^-- SC2086: Double quote to prevent globbing and word splitting. In plugins-scripts/check_oracle.sh line 303: exit $STATE_UNKNOWN ^-- SC2086: Double quote to prevent globbing and word splitting. — <a href="https://github.com/monitoring-plugins/monitoring-plugins/issues/1367">Reply to this email on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AFQl2UeovwoJwTjWy6p6LU6bqmmPYSsaks5o4kTZgaJpZM4GI343.gif" width="1" /> <div itemscope itemtype="http://schema.org/EmailMessage"> <div itemprop="action" itemscope itemtype="http://schema.org/ViewAction"> <link itemprop="url" href="https://github.com/monitoring-plugins/monitoring-plugins/issues/1367"></link> <meta itemprop="name" content="View Issue"></meta> </div> <meta itemprop="description" content="View this Issue on GitHub"></meta> </div>