monitoring-plugin-perl, branch v0.40

release 0.40

2018-07-25T20:16:18Z

update changelog

2018-07-25T20:13:33Z

Signed-off-by: Sven Nierlein

Merge pull request #19 from tejr/config-read-error

2018-05-28T06:55:47Z

Fail with config ->errstr() when undef read

2018-05-24T01:01:21Z

The Config::Tiny parent class for Monitoring::Plugin::Config does not necessarily raise an exception in $@/$EVAL_ERROR on a failed call to its ->read() method. Indeed, it does not in most cases, at least in the most recent Config::Tiny. If a file does not exist or for whatever other reason cannot actually be read--such as permissions problems--Monitoring::Plugin ends up reporting a "Missing config section" to the caller, which is misleading. This information is available from the ->errstr() method of the base class, however, and an inspection of the code for the ->read() method in the parent class suggests the correct approach is to look for a return of `undef` from the ->read() method, and use the return value of ->errstr() as the reported error for ->_die(). This commit adds such a check. To reproduce, given the following plugin `mptest`: use strict; use warnings; use Monitoring::Plugin qw(%ERRORS); my $mp = Monitoring::Plugin->new( usage => '', ); $mp->getopts; $mp->plugin_exit($ERRORS{OK}, 'Done!'); Running it without options of course works, like so: $ perl mptest MPTEST OK - Done! However, prior to this patch, if we specify --extra-opts with a nonexistent filename, we get a misleading error: $ perl mptest --extra-opts=@/nonexistent Invalid section 'mptest' in config file '/nonexistent' With this patch included, the error is more accurate and helpful: $ perl mptest --extra-opts=@/nonexistent Failed to open file '/nonexistent' for reading: No such file or directory

Merge pull request #18 from tejr/master

2018-03-07T07:54:08Z

Remove "experimental" tag on "Message Methods"

2018-03-04T20:59:29Z

From a maintainer, Sven Nierlein: > I'd say we can remove the "experimental" tag there. It had been there > for years now and i see no reason why we would change them. Partly resolves #14.

Merge pull request #17 from tejr/arg-add-cleanup

2017-12-22T10:49:49Z

Clean up argument adding code a little bit

Remove "scalar" call entirely

2017-12-16T01:09:16Z

Context with the lhs of the == operator forces this into scalar context anyway, making this call redundant.

Pass params validation by ref not copy

2017-12-16T00:34:38Z

Since Params::Validate::validate() doesn't seem to actually mess with this specification, may as well pass a reference rather than bother copying the whole thing.

Remove unneeded params around "scalar" call

2017-12-16T00:30:52Z

Operator precedence allows leaving these out.