monitoring-plugins/plugins-root/t/check_icmp.t, branch 3.0.0-rc3Monitoring Plugins
https://www.monitoring-plugins.org/repositories/monitoring-plugins/atom?h=3.0.0-rc32025-06-20T08:53:46ZFix number of tests2025-06-20T08:53:46ZLorenz Kästle12514511+RincewindsHat@users.noreply.github.com2025-06-20T08:53:46Zurn:sha1:d2735eecd4c44ba4a2504304963e861a427e393eFix test with weird arguments2025-06-20T08:28:45ZLorenz Kästle12514511+RincewindsHat@users.noreply.github.com2025-06-20T08:28:45Zurn:sha1:6bc2e75199519d0a7677dff09137558ef6eb761ccheck_icmp: Remove signal handling and timeouts2025-06-20T08:04:34ZLorenz Kästle12514511+RincewindsHat@users.noreply.github.com2025-06-20T08:04:34Zurn:sha1:2bea8e9522af1c454d1a6a618402f9f342730406
The timeout option was redundant in that the runtime
of check_icmp was always limited by the input parameters
and therefore timeout gets removed with this commit to
avoid that confusion.
The rest of the signal handlings was removed too, since
the added complexity does not provide sufficient returns.
If check_icmp gets a signal, it now dies like most other
programs instead of trying to save some things and return a
(arguably wrong) result.
Remove check_icmp text regex tests2025-06-09T10:42:17ZLorenz Kästle12514511+RincewindsHat@users.noreply.github.com2025-06-09T10:33:15Zurn:sha1:0f8690c19b352549961c46c75c7307814e255db0check_icmp: keep performance data order in case of none-reachable hosts2024-03-01T08:03:17ZSven Nierleinsven@consol.de2024-02-28T14:37:27Zurn:sha1:0488426c7e8018d77734fb0e46328182de28f76a
For responding hosts nothing changes:
./check_icmp -H 10.0.0.1
OK - 10.0.0.1 rta 0.336ms lost 0%|rta=0.336ms;200.000;500.000;0; rtmax=0.471ms;;;; rtmin=0.000ms;;;; pl=0%;40;80;0;100
In case the host is down, the performance data now contain 'U' according to:
https://www.monitoring-plugins.org/doc/guidelines.html#AEN201
Old:
./check_icmp -H 10.0.0.99
CRITICAL - 10.0.0.99: Host unreachable @ 10.0.1.138. rta nan, lost 100%|pl=100%;40;80;0;100
Old:
./check_icmp -H 10.0.0.99
CRITICAL - 10.0.0.99: Host unreachable @ 10.0.1.138. rta nan, lost 100%|rta=U;;;; rtmax=U;;;; rtmin=U;;;; pl=100%;40;80;0;100
This confuses some performance graphing tools, ex.: pnp.
Signed-off-by: Sven Nierlein <sven@consol.de>
add some basic tests for the new modes2023-10-04T09:34:25ZDanijel Tasovm@rbfh.de2023-10-04T09:34:25Zurn:sha1:4e7eb550791afdb5d3e496a84be00286ccb6fb5b
Signed-off-by: Danijel Tasov <m@rbfh.de>
update failure regex2023-10-04T08:39:30ZDanijel Tasovm@rbfh.de2023-10-04T08:39:30Zurn:sha1:df57a23e0ace0c1d1c19038fd3834b20742ef24aadjust check_icmp tests2023-10-04T08:21:41ZDanijel Tasovm@rbfh.de2023-10-04T08:21:41Zurn:sha1:396bcf50ce23fc34d14e4ef8fb6d9843b977f95cFix a lot of typos reported by codespell2023-04-14T18:35:00ZJan Wagnerwaja@cyconet.org2023-04-14T14:37:47Zurn:sha1:0f3703e641f0f995a8abb40056cb5430b6c228c4check_icmp: buffer offerflow (#1733)2022-03-15T21:00:55ZLorenz12514511+RincewindsHat@users.noreply.github.com2022-03-15T21:00:55Zurn:sha1:605405557102c04e740fc3249675cc5154436d11
* Fix different overflows
* Less includes
* Add testcases
* Remove unused variable
* Remove unused and commented includes