Monitoring Plugins https://www.monitoring-plugins.org/repositories/monitoring-plugins/atom?h=archive%2Fstate_file 2010-04-12T13:36:33Z 2010-04-12T13:36:33Z Holger Weiss holger@zedat.fu-berlin.de 2010-04-12T13:36:33Z urn:sha1:7a661c7aed2a0bad4ce1e3786bc707cd2b07c128 If Perl's "shift" function is called outside of a subroutine and without any argument, it usually shifts @ARGV. However, if a plugin is executed via ePN, such a call will shift @_ instead, so we must explicitly specify @ARGV for this to work as expected. This fixes Debian bug #545940, see: http://bugs.debian.org/545940 Commit de7191e3424e02ba278a39b86e8b1906a25d0362 fixed the same issue for check_disk_smb. (Reported by Hendrik Jaeger, forwarded by Jan Wagner.) 2010-04-11T08:54:44Z Holger Weiss holger@zedat.fu-berlin.de 2010-04-11T08:54:44Z urn:sha1:614e9dec5e3f4059c8eb5e4ea11bf92e66c3c76f Fix some problems regarding the way check_disk_smb passes command line arguments to smbclient(1). | It runs: | | $res = qx/$smbclient "\/\/$host\/$share" $pass -W $workgroup \ | -U $user $smbclientoptions -I $address -c ls/; | | [...] | | The documentation says that if the password is not passed, it | defaults to "". That is not true above, as $pass expands to | nothing which leaves no argument at all (instead of an empty | argument) so is different from providing with an empty password | or with the -N option. | | Also, if the password starts with "-", you're in trouble, that's | why -U $user%$pass may be prefered. | | Also, the doc says that if $user is not provided, then it | defaults to "guest" but the problem is that if it is provided | but empty, it is changed to "guest" as well, which prevents us | from querying hosts that don't do user authentication. [ http://bugs.debian.org/478942 ] (Fixed by Stephane Chazelas, forwarded by Jan Wagner.) 2010-04-11T07:54:10Z Holger Weiss holger@zedat.fu-berlin.de 2010-04-11T07:54:10Z urn:sha1:de7191e3424e02ba278a39b86e8b1906a25d0362 | When perl plugin scripts are run with the embedded perl interpreter in | nagios3, the "shift" perl command doesn't shift @ARGV, but @_ (which | happens to contain the same thing as @ARGV at the time the script was | started). | | [...] | | A fix is to replace all the instances of "shift" with "shift @ARGV". [ http://bugs.debian.org/478906 ] (Fixed by Stephane Chazelas, forwarded by Jan Wagner.) 2010-04-11T07:39:24Z Holger Weiss holger@zedat.fu-berlin.de 2010-04-11T07:39:24Z urn:sha1:e4613410033dc24d9efe34013c8a35b16487af8f | The check_disk_smb plugin purports to support guest users, but it | doesn't work out, because it doesn't specify the -N command line | option to smbclient when no password is specified, making smbclient | stop and ask. [ http://bugs.debian.org/425129 ] (Fixed by Josip Rodin, forwarded by Jan Wagner.) 2010-04-10T23:57:11Z Holger Weiss holger@zedat.fu-berlin.de 2010-04-10T23:57:11Z urn:sha1:5a1babdae8759b4084445b90f676a77007c5ccca Add the "-a, --address option" which allows for specifying the IP address of the server to connect to. If this option is used, the IP address will be handed over to smbclient(1)'s "-I" option. (Contributed by Sean Finney, forwarded by Jan Wagner.) 2009-09-25T09:31:04Z nagiosplugins nagiosplugins@nagiosplugins.org 2009-09-25T08:18:04Z urn:sha1:43c187a9444ddfdac26fb5c2e2f21dd38c72ce8d 2009-09-19T06:08:51Z Thomas Guyot-Sionnest dermoth@aei.ca 2009-09-19T05:44:10Z urn:sha1:bc3c8c7cfbdbce716e8987bee211f69911ea8db2 2009-06-13T16:13:49Z Matthias Eble psychotrahe@gmx.de 2009-06-13T16:13:49Z urn:sha1:38e20a1a3369bf470b8ce9b66ca5dfb57302e009 The checks for invalid/unavailable hosts need a complete command line. They failed on hosts where no community was specified. Now, an invalid community is used so the tests can run on hosts w/o snmp host/community in NPTest.cache. Execution will fail anyway. 2009-06-13T09:10:32Z Matthias Eble psychotrahe@gmx.de 2009-06-13T09:10:32Z urn:sha1:05b801284c714e2e39a4fffc69d11d9cb78fe5ef Added snmp_interface and snmp_ifxtable test parameters to check_ifoperstatus.t. Also getTestParameter calls for both plugins were converted to use three arguments instead of undocumented >3 arg behaviour which led to redundant data in NPTest.cache. 2009-06-11T15:24:52Z Matthias Eble psychotrahe@gmx.de 2009-06-11T15:24:52Z urn:sha1:c66d2c6b3b6d948ff36126f5d3a7629279f47878 check_ifstatus already used -x so both plugins can use same short option, now. to specify privacy protocol.