diff options
| -rw-r--r-- | configure.in | 10 | ||||
| -rw-r--r-- | plugins/check_swap.c | 51 |
2 files changed, 32 insertions, 29 deletions
diff --git a/configure.in b/configure.in index 64f06bf3..030b1de3 100644 --- a/configure.in +++ b/configure.in | |||
| @@ -1257,13 +1257,13 @@ then | |||
| 1257 | egrep -i "^lswap +path +pri +swaplo +blocks +free +maxswap" \ | 1257 | egrep -i "^lswap +path +pri +swaplo +blocks +free +maxswap" \ |
| 1258 | >/dev/null] | 1258 | >/dev/null] |
| 1259 | then | 1259 | then |
| 1260 | ac_cv_swap_format=[" %*d %*s %*d,%*d %*d %*d %d %d"] | 1260 | ac_cv_swap_format=[" %*d %*s %*d,%*d %*d %*d %f %f"] |
| 1261 | ac_cv_swap_conv=2048 | 1261 | ac_cv_swap_conv=2048 |
| 1262 | AC_MSG_RESULT([using IRIX format swap]) | 1262 | AC_MSG_RESULT([using IRIX format swap]) |
| 1263 | 1263 | ||
| 1264 | elif [$PATH_TO_SWAP -l 2>/dev/null | egrep -i "^path +dev +swaplo +blocks +free" >/dev/null] | 1264 | elif [$PATH_TO_SWAP -l 2>/dev/null | egrep -i "^path +dev +swaplo +blocks +free" >/dev/null] |
| 1265 | then | 1265 | then |
| 1266 | ac_cv_swap_format=["%*s %*[0-9,-] %*d %d %d"] | 1266 | ac_cv_swap_format=["%*s %*[0-9,-] %*d %f %f"] |
| 1267 | ac_cv_swap_conv=2048 | 1267 | ac_cv_swap_conv=2048 |
| 1268 | AC_MSG_RESULT([using Unixware format swap]) | 1268 | AC_MSG_RESULT([using Unixware format swap]) |
| 1269 | else | 1269 | else |
| @@ -1287,7 +1287,7 @@ then | |||
| 1287 | 1287 | ||
| 1288 | if [$PATH_TO_SWAPINFO -k 2>/dev/null | egrep -i "^Device +1K-blocks +Used +Avail" >/dev/null] | 1288 | if [$PATH_TO_SWAPINFO -k 2>/dev/null | egrep -i "^Device +1K-blocks +Used +Avail" >/dev/null] |
| 1289 | then | 1289 | then |
| 1290 | ac_cv_swap_format=["%*s %d %*d %d"] | 1290 | ac_cv_swap_format=["%*s %f %*d %f"] |
| 1291 | ac_cv_swap_conv=1024 | 1291 | ac_cv_swap_conv=1024 |
| 1292 | AC_MSG_RESULT([using FreeBSD format swapinfo]) | 1292 | AC_MSG_RESULT([using FreeBSD format swapinfo]) |
| 1293 | fi | 1293 | fi |
| @@ -1296,7 +1296,7 @@ elif [$PATH_TO_SWAPINFO -dfM 2>/dev/null | egrep -i "^TYPE +AVAIL +USED +FREE" > | |||
| 1296 | then | 1296 | then |
| 1297 | ac_cv_have_swap=yes | 1297 | ac_cv_have_swap=yes |
| 1298 | ac_cv_swap_command="$PATH_TO_SWAPINFO -dfM", | 1298 | ac_cv_swap_command="$PATH_TO_SWAPINFO -dfM", |
| 1299 | ac_cv_swap_format=["%*s %d %*d %d"] | 1299 | ac_cv_swap_format=["%*s %f %*d %f"] |
| 1300 | ac_cv_swap_conv=1024 | 1300 | ac_cv_swap_conv=1024 |
| 1301 | AC_MSG_RESULT([using HP-UX format swapinfo]) | 1301 | AC_MSG_RESULT([using HP-UX format swapinfo]) |
| 1302 | fi | 1302 | fi |
| @@ -1311,7 +1311,7 @@ if [$PATH_TO_LSPS -a 2>/dev/null | egrep -i "^Page Space" > /dev/null] | |||
| 1311 | then | 1311 | then |
| 1312 | ac_cv_have_swap=yes | 1312 | ac_cv_have_swap=yes |
| 1313 | ac_cv_swap_command="$PATH_TO_LSPS -a" | 1313 | ac_cv_swap_command="$PATH_TO_LSPS -a" |
| 1314 | ac_cv_swap_format=["%*s %*s %*s %d%*s %d %*s"] | 1314 | ac_cv_swap_format=["%*s %*s %*s %f%*s %f %*s"] |
| 1315 | ac_cv_swap_conv=1 | 1315 | ac_cv_swap_conv=1 |
| 1316 | AC_MSG_RESULT([using AIX lsps]) | 1316 | AC_MSG_RESULT([using AIX lsps]) |
| 1317 | fi | 1317 | fi |
diff --git a/plugins/check_swap.c b/plugins/check_swap.c index bcc6b170..33965752 100644 --- a/plugins/check_swap.c +++ b/plugins/check_swap.c | |||
| @@ -34,7 +34,7 @@ const char *email = "nagiosplug-devel@lists.sourceforge.net"; | |||
| 34 | #include "popen.h" | 34 | #include "popen.h" |
| 35 | #include "utils.h" | 35 | #include "utils.h" |
| 36 | 36 | ||
| 37 | int check_swap (int usp, long unsigned int free_swap); | 37 | int check_swap (int usp, float free_swap); |
| 38 | int process_arguments (int argc, char **argv); | 38 | int process_arguments (int argc, char **argv); |
| 39 | int validate_arguments (void); | 39 | int validate_arguments (void); |
| 40 | void print_usage (void); | 40 | void print_usage (void); |
| @@ -42,8 +42,8 @@ void print_help (void); | |||
| 42 | 42 | ||
| 43 | int warn_percent = 0; | 43 | int warn_percent = 0; |
| 44 | int crit_percent = 0; | 44 | int crit_percent = 0; |
| 45 | unsigned long long warn_size = 0; | 45 | float warn_size = 0; |
| 46 | unsigned long long crit_size = 0; | 46 | float crit_size = 0; |
| 47 | int verbose; | 47 | int verbose; |
| 48 | int allswaps; | 48 | int allswaps; |
| 49 | 49 | ||
| @@ -51,8 +51,8 @@ int | |||
| 51 | main (int argc, char **argv) | 51 | main (int argc, char **argv) |
| 52 | { | 52 | { |
| 53 | int percent_used, percent; | 53 | int percent_used, percent; |
| 54 | unsigned long long total_swap = 0, used_swap = 0, free_swap = 0; | 54 | float total_swap = 0, used_swap = 0, free_swap = 0; |
| 55 | unsigned long long dsktotal = 0, dskused = 0, dskfree = 0, tmp = 0; | 55 | float dsktotal = 0, dskused = 0, dskfree = 0, tmp = 0; |
| 56 | int result = STATE_UNKNOWN; | 56 | int result = STATE_UNKNOWN; |
| 57 | char input_buffer[MAX_INPUT_BUFFER]; | 57 | char input_buffer[MAX_INPUT_BUFFER]; |
| 58 | char *perf; | 58 | char *perf; |
| @@ -95,7 +95,7 @@ main (int argc, char **argv) | |||
| 95 | #ifdef HAVE_PROC_MEMINFO | 95 | #ifdef HAVE_PROC_MEMINFO |
| 96 | fp = fopen (PROC_MEMINFO, "r"); | 96 | fp = fopen (PROC_MEMINFO, "r"); |
| 97 | while (fgets (input_buffer, MAX_INPUT_BUFFER - 1, fp)) { | 97 | while (fgets (input_buffer, MAX_INPUT_BUFFER - 1, fp)) { |
| 98 | if (sscanf (input_buffer, "%*[S]%*[w]%*[a]%*[p]%*[:] %llu %llu %llu", &dsktotal, &dskused, &dskfree) == 3) { | 98 | if (sscanf (input_buffer, "%*[S]%*[w]%*[a]%*[p]%*[:] %f %f %f", &dsktotal, &dskused, &dskfree) == 3) { |
| 99 | dsktotal = dsktotal / 1048576; | 99 | dsktotal = dsktotal / 1048576; |
| 100 | dskused = dskused / 1048576; | 100 | dskused = dskused / 1048576; |
| 101 | dskfree = dskfree / 1048576; | 101 | dskfree = dskfree / 1048576; |
| @@ -109,10 +109,10 @@ main (int argc, char **argv) | |||
| 109 | percent = 100 * (((double) dskused) / ((double) dsktotal)); | 109 | percent = 100 * (((double) dskused) / ((double) dsktotal)); |
| 110 | result = max_state (result, check_swap (percent, dskfree)); | 110 | result = max_state (result, check_swap (percent, dskfree)); |
| 111 | if (verbose) | 111 | if (verbose) |
| 112 | asprintf (&status, "%s [%llu (%d%%)]", status, dskfree, 100 - percent); | 112 | asprintf (&status, "%s [%.0f (%d%%)]", status, dskfree, 100 - percent); |
| 113 | } | 113 | } |
| 114 | } | 114 | } |
| 115 | else if (sscanf (input_buffer, "%*[S]%*[w]%*[a]%*[p]%[TotalFre]%*[:] %llu %*[k]%*[B]", str, &tmp)) { | 115 | else if (sscanf (input_buffer, "%*[S]%*[w]%*[a]%*[p]%[TotalFre]%*[:] %f %*[k]%*[B]", str, &tmp)) { |
| 116 | if (strcmp ("Total", str) == 0) { | 116 | if (strcmp ("Total", str) == 0) { |
| 117 | dsktotal = tmp / 1024; | 117 | dsktotal = tmp / 1024; |
| 118 | } | 118 | } |
| @@ -180,7 +180,7 @@ main (int argc, char **argv) | |||
| 180 | free_swap = total_swap * (100 - used_swap) /100; | 180 | free_swap = total_swap * (100 - used_swap) /100; |
| 181 | used_swap = total_swap - free_swap; | 181 | used_swap = total_swap - free_swap; |
| 182 | if (verbose >= 3) | 182 | if (verbose >= 3) |
| 183 | printf (_("total=%d, used=%d, free=%d\n"), total_swap, used_swap, free_swap); | 183 | printf (_("total=%.0f, used=%.0f, free=%.0f\n"), total_swap, used_swap, free_swap); |
| 184 | } else { | 184 | } else { |
| 185 | # endif | 185 | # endif |
| 186 | while (fgets (input_buffer, MAX_INPUT_BUFFER - 1, child_process)) { | 186 | while (fgets (input_buffer, MAX_INPUT_BUFFER - 1, child_process)) { |
| @@ -194,7 +194,7 @@ main (int argc, char **argv) | |||
| 194 | dskfree = dskfree / conv_factor; | 194 | dskfree = dskfree / conv_factor; |
| 195 | # endif | 195 | # endif |
| 196 | if (verbose >= 3) | 196 | if (verbose >= 3) |
| 197 | printf (_("total=%llu, free=%llu\n"), dsktotal, dskfree); | 197 | printf (_("total=%.0f, free=%.0f\n"), dsktotal, dskfree); |
| 198 | 198 | ||
| 199 | dskused = dsktotal - dskfree; | 199 | dskused = dsktotal - dskfree; |
| 200 | total_swap += dsktotal; | 200 | total_swap += dsktotal; |
| @@ -204,7 +204,7 @@ main (int argc, char **argv) | |||
| 204 | percent = 100 * (((double) dskused) / ((double) dsktotal)); | 204 | percent = 100 * (((double) dskused) / ((double) dsktotal)); |
| 205 | result = max_state (result, check_swap (percent, dskfree)); | 205 | result = max_state (result, check_swap (percent, dskfree)); |
| 206 | if (verbose) | 206 | if (verbose) |
| 207 | asprintf (&status, "%s [%llu (%d%%)]", status, dskfree, 100 - percent); | 207 | asprintf (&status, "%s [%.0f (%d%%)]", status, dskfree, 100 - percent); |
| 208 | } | 208 | } |
| 209 | } | 209 | } |
| 210 | # ifdef _AIX | 210 | # ifdef _AIX |
| @@ -244,15 +244,18 @@ main (int argc, char **argv) | |||
| 244 | } | 244 | } |
| 245 | 245 | ||
| 246 | for(i=0;i<nswaps;i++){ | 246 | for(i=0;i<nswaps;i++){ |
| 247 | dsktotal = tbl->swt_ent[i].ste_pages / SWAP_CONVERSION; | 247 | dsktotal = (float) tbl->swt_ent[i].ste_pages / SWAP_CONVERSION; |
| 248 | dskfree = tbl->swt_ent[i].ste_free / SWAP_CONVERSION; | 248 | dskfree = (float) tbl->swt_ent[i].ste_free / SWAP_CONVERSION; |
| 249 | dskused = ( dsktotal - dskfree ); | 249 | dskused = ( dsktotal - dskfree ); |
| 250 | 250 | ||
| 251 | if (verbose >= 3) | ||
| 252 | printf ("dsktotal=%.0f dskfree=%.0f dskused=%.0f\n", dsktotal, dskfree, dskused); | ||
| 253 | |||
| 251 | if(allswaps && dsktotal > 0){ | 254 | if(allswaps && dsktotal > 0){ |
| 252 | percent = 100 * (((double) dskused) / ((double) dsktotal)); | 255 | percent = 100 * (((double) dskused) / ((double) dsktotal)); |
| 253 | result = max_state (result, check_swap (percent, dskfree)); | 256 | result = max_state (result, check_swap (percent, dskfree)); |
| 254 | if (verbose) { | 257 | if (verbose) { |
| 255 | asprintf (&status, "%s [%d (%d%%)]", status, (int)dskfree, 100 - percent); | 258 | asprintf (&status, "%s [%.0f (%d%%)]", status, dskfree, 100 - percent); |
| 256 | } | 259 | } |
| 257 | } | 260 | } |
| 258 | 261 | ||
| @@ -283,15 +286,15 @@ main (int argc, char **argv) | |||
| 283 | } | 286 | } |
| 284 | 287 | ||
| 285 | for(i=0;i<nswaps;i++){ | 288 | for(i=0;i<nswaps;i++){ |
| 286 | dsktotal = ent->se_nblks / conv_factor; | 289 | dsktotal = (float) ent->se_nblks / conv_factor; |
| 287 | dskused = ent->se_inuse / conv_factor; | 290 | dskused = (float) ent->se_inuse / conv_factor; |
| 288 | dskfree = ( dsktotal - dskused ); | 291 | dskfree = ( dsktotal - dskused ); |
| 289 | 292 | ||
| 290 | if(allswaps && dsktotal > 0){ | 293 | if(allswaps && dsktotal > 0){ |
| 291 | percent = 100 * (((double) dskused) / ((double) dsktotal)); | 294 | percent = 100 * (((double) dskused) / ((double) dsktotal)); |
| 292 | result = max_state (result, check_swap (percent, dskfree)); | 295 | result = max_state (result, check_swap (percent, dskfree)); |
| 293 | if (verbose) { | 296 | if (verbose) { |
| 294 | asprintf (&status, "%s [%d (%d%%)]", status, (int)dskfree, 100 - percent); | 297 | asprintf (&status, "%s [%.0f (%d%%)]", status, dskfree, 100 - percent); |
| 295 | } | 298 | } |
| 296 | } | 299 | } |
| 297 | 300 | ||
| @@ -311,7 +314,7 @@ main (int argc, char **argv) | |||
| 311 | percent_used = 100 * ((double) used_swap) / ((double) total_swap); | 314 | percent_used = 100 * ((double) used_swap) / ((double) total_swap); |
| 312 | result = max_state (result, check_swap (percent_used, free_swap)); | 315 | result = max_state (result, check_swap (percent_used, free_swap)); |
| 313 | /* broken into two steps because of funkiness with builtin asprintf */ | 316 | /* broken into two steps because of funkiness with builtin asprintf */ |
| 314 | asprintf (&tmp_status, _(" %d%% free (%llu MB out of %llu MB)"), | 317 | asprintf (&tmp_status, _(" %d%% free (%.0f MB out of %.0f MB)"), |
| 315 | (100 - percent_used), free_swap, total_swap); | 318 | (100 - percent_used), free_swap, total_swap); |
| 316 | asprintf (&status, "%s%s", tmp_status, status); | 319 | asprintf (&status, "%s%s", tmp_status, status); |
| 317 | 320 | ||
| @@ -327,7 +330,7 @@ main (int argc, char **argv) | |||
| 327 | 330 | ||
| 328 | 331 | ||
| 329 | int | 332 | int |
| 330 | check_swap (int usp, long unsigned int free_swap) | 333 | check_swap (int usp, float free_swap) |
| 331 | { | 334 | { |
| 332 | int result = STATE_UNKNOWN; | 335 | int result = STATE_UNKNOWN; |
| 333 | free_swap = free_swap * 1024; /* Convert back to bytes as warn and crit specified in bytes */ | 336 | free_swap = free_swap * 1024; /* Convert back to bytes as warn and crit specified in bytes */ |
| @@ -375,12 +378,12 @@ process_arguments (int argc, char **argv) | |||
| 375 | switch (c) { | 378 | switch (c) { |
| 376 | case 'w': /* warning size threshold */ | 379 | case 'w': /* warning size threshold */ |
| 377 | if (is_intnonneg (optarg)) { | 380 | if (is_intnonneg (optarg)) { |
| 378 | warn_size = atoi (optarg); | 381 | warn_size = (float) atoi (optarg); |
| 379 | break; | 382 | break; |
| 380 | } | 383 | } |
| 381 | else if (strstr (optarg, ",") && | 384 | else if (strstr (optarg, ",") && |
| 382 | strstr (optarg, "%") && | 385 | strstr (optarg, "%") && |
| 383 | sscanf (optarg, "%llu,%d%%", &warn_size, &warn_percent) == 2) { | 386 | sscanf (optarg, "%.0f,%d%%", &warn_size, &warn_percent) == 2) { |
| 384 | break; | 387 | break; |
| 385 | } | 388 | } |
| 386 | else if (strstr (optarg, "%") && | 389 | else if (strstr (optarg, "%") && |
| @@ -392,12 +395,12 @@ process_arguments (int argc, char **argv) | |||
| 392 | } | 395 | } |
| 393 | case 'c': /* critical size threshold */ | 396 | case 'c': /* critical size threshold */ |
| 394 | if (is_intnonneg (optarg)) { | 397 | if (is_intnonneg (optarg)) { |
| 395 | crit_size = atoi (optarg); | 398 | crit_size = (float) atoi (optarg); |
| 396 | break; | 399 | break; |
| 397 | } | 400 | } |
| 398 | else if (strstr (optarg, ",") && | 401 | else if (strstr (optarg, ",") && |
| 399 | strstr (optarg, "%") && | 402 | strstr (optarg, "%") && |
| 400 | sscanf (optarg, "%llu,%d%%", &crit_size, &crit_percent) == 2) { | 403 | sscanf (optarg, "%.0f,%d%%", &crit_size, &crit_percent) == 2) { |
| 401 | break; | 404 | break; |
| 402 | } | 405 | } |
| 403 | else if (strstr (optarg, "%") && | 406 | else if (strstr (optarg, "%") && |
| @@ -438,7 +441,7 @@ process_arguments (int argc, char **argv) | |||
| 438 | if (c == argc) | 441 | if (c == argc) |
| 439 | return validate_arguments (); | 442 | return validate_arguments (); |
| 440 | if (warn_size == 0 && is_intnonneg (argv[c])) | 443 | if (warn_size == 0 && is_intnonneg (argv[c])) |
| 441 | warn_size = atoi (argv[c++]); | 444 | warn_size = (float) atoi (argv[c++]); |
| 442 | 445 | ||
| 443 | if (c == argc) | 446 | if (c == argc) |
| 444 | return validate_arguments (); | 447 | return validate_arguments (); |
