1 files changed, 94 insertions, 86 deletions

diff --git a/plugins/utils.c b/plugins/utils.c
index b4214c61..77d6a6f9 100644
--- a/plugins/utils.c
+++ b/plugins/utils.c
@@ -23,13 +23,15 @@
 *****************************************************************************/
 
 #include "common.h"
-#include "utils.h"
+#include "./utils.h"
 #include "utils_base.h"
 #include <stdarg.h>
 #include <limits.h>
 #include <string.h>
 #include <errno.h>
 
+#include <stdbool.h>
+
 #include <arpa/inet.h>
 
 extern void print_usage (void);
@@ -147,98 +149,107 @@ print_revision (const char *command_name, const char *revision)
                  command_name, revision, PACKAGE, VERSION);
 }
 
-int
-is_numeric (char *number)
-{
+bool is_numeric (char *number) {
         char tmp[1];
         float x;
 
         if (!number)
-                return FALSE;
+                return false;
         else if (sscanf (number, "%f%c", &x, tmp) == 1)
-                return TRUE;
+                return true;
         else
-                return FALSE;
+                return false;
 }
 
-int
-is_positive (char *number)
-{
+bool is_positive (char *number) {
         if (is_numeric (number) && atof (number) > 0.0)
-                return TRUE;
+                return true;
         else
-                return FALSE;
+                return false;
 }
 
-int
-is_negative (char *number)
-{
+bool is_negative (char *number) {
         if (is_numeric (number) && atof (number) < 0.0)
-                return TRUE;
+                return true;
         else
-                return FALSE;
+                return false;
 }
 
-int
-is_nonnegative (char *number)
-{
+bool is_nonnegative (char *number) {
         if (is_numeric (number) && atof (number) >= 0.0)
-                return TRUE;
+                return true;
         else
-                return FALSE;
+                return false;
 }
 
-int
-is_percentage (char *number)
-{
+bool is_percentage (char *number) {
         int x;
         if (is_numeric (number) && (x = atof (number)) >= 0 && x <= 100)
-                return TRUE;
+                return true;
         else
-                return FALSE;
+                return false;
 }
 
-int
-is_integer (char *number)
-{
+bool is_percentage_expression (const char str[]) {
+        if (!str) {
+                return false;
+        }
+
+        size_t len = strlen(str);
+
+        if (str[len-1] != '%') {
+                return false;
+        }
+
+        char *foo = calloc(sizeof(char), len + 1);
+
+        if (!foo) {
+                die (STATE_UNKNOWN, _("calloc failed \n"));
+        }
+
+        strcpy(foo, str);
+        foo[len-1] = '\0';
+
+        bool result = is_numeric(foo);
+
+        free(foo);
+
+        return result;
+}
+
+bool is_integer (char *number) {
         long int n;
 
         if (!number || (strspn (number, "-0123456789 ") != strlen (number)))
-                return FALSE;
+                return false;
 
         n = strtol (number, NULL, 10);
 
         if (errno != ERANGE && n >= INT_MIN && n <= INT_MAX)
-                return TRUE;
+                return true;
         else
-                return FALSE;
+                return false;
 }
 
-int
-is_intpos (char *number)
-{
+bool is_intpos (char *number) {
         if (is_integer (number) && atoi (number) > 0)
-                return TRUE;
+                return true;
         else
-                return FALSE;
+                return false;
 }
 
-int
-is_intneg (char *number)
-{
+bool is_intneg (char *number) {
         if (is_integer (number) && atoi (number) < 0)
-                return TRUE;
+                return true;
         else
-                return FALSE;
+                return false;
 }
 
-int
-is_intnonneg (char *number)
-{
+bool is_intnonneg (char *number) {
         if (is_integer (number) && atoi (number) >= 0)
-                return TRUE;
+                return true;
         else
-                return FALSE;
+                return false;
 }
 
 /*
@@ -246,19 +257,27 @@ is_intnonneg (char *number)
  * On success the number will be written to the _target_ address, if _target_ is not set
  * to NULL.
  */
-int is_int64(char *number, int64_t *target) {
+bool is_int64(char *number, int64_t *target) {
         errno = 0;
-        uint64_t tmp = strtoll(number, NULL, 10);
+        char *endptr = { 0 };
+
+        int64_t tmp = strtoll(number, &endptr, 10);
         if (errno != 0) {
+                return false;
+        }
+
+        if (*endptr == '\0') {
                 return 0;
         }
+
         if (tmp < INT64_MIN || tmp > INT64_MAX) {
-                return 0;
+                return false;
         }
+
         if (target != NULL) {
                 *target = tmp;
         }
-        return 1;
+        return true;
 }
 
 /*
@@ -266,40 +285,45 @@ int is_int64(char *number, int64_t *target) {
  * On success the number will be written to the _target_ address, if _target_ is not set
  * to NULL.
  */
-int is_uint64(char *number, uint64_t *target) {
+bool is_uint64(char *number, uint64_t *target) {
         errno = 0;
-        uint64_t tmp = strtoll(number, NULL, 10);
+        char *endptr = { 0 };
+        unsigned long long tmp = strtoull(number, &endptr, 10);
+
         if (errno != 0) {
-                return 0;
+                return false;
         }
-        if (tmp < 0 || tmp > UINT64_MAX) {
-                return 0;
+
+        if (*endptr != '\0') {
+                return false;
+        }
+
+        if (tmp > UINT64_MAX) {
+                return false;
         }
+
         if (target != NULL) {
-                *target = tmp;
+                *target = (uint64_t)tmp;
         }
-        return 1;
+
+        return true;
 }
 
-int
-is_intpercent (char *number)
-{
+bool is_intpercent (char *number) {
         int i;
         if (is_integer (number) && (i = atoi (number)) >= 0 && i <= 100)
-                return TRUE;
+                return true;
         else
-                return FALSE;
+                return false;
 }
 
-int
-is_option (char *str)
-{
+bool is_option (char *str) {
         if (!str)
-                return FALSE;
+                return false;
         else if (strspn (str, "-") == 1 || strspn (str, "-") == 2)
-                return TRUE;
+                return true;
         else
-                return FALSE;
+                return false;
 }
 
 #ifdef NEED_GETTIMEOFDAY
@@ -804,19 +828,3 @@ char *sperfdata_int (const char *label,
 
         return data;
 }
-
-int
-open_max (void)
-{
-        errno = 0;
-        if (maxfd > 0)
-                return(maxfd);
-
-        if ((maxfd = sysconf (_SC_OPEN_MAX)) < 0) {
-                if (errno == 0)
-                        maxfd = DEFAULT_MAXFD;   /* it's indeterminate */
-        else
-                die (STATE_UNKNOWN, _("sysconf error for _SC_OPEN_MAX\n"));
-        }
-        return(maxfd);
-}