summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2025-09-01check_snmp: improve string quoting in resultLorenz Kästle1-1/+16
2025-08-30check_snmp: Small improvements + fix dereference bugLorenz Kästle1-3/+4
2025-08-30check_snmp: Fix number processing (offset + multiplier)Lorenz Kästle3-13/+62
2025-08-30check_snmp: implement output format settingLorenz Kästle2-15/+46
2025-08-29check_snmp: Make linter happyLorenz Kästle1-22/+28
2025-08-29check_snmp: Remove options description for input delimiterLorenz Kästle1-6/+0
2025-08-28Build check_snmp unconditionallyLorenz Kästle1-2/+3
2025-08-28check_snmp: fix DES availability detection(?)Lorenz Kästle2-3/+13
2025-08-28check_snmp: formattingLorenz Kästle1-2/+2
2025-08-28check_snmp: Test for availability of DES privacy protocolLorenz Kästle1-3/+18
2025-08-28Remove testing for SNMPGETNEXT from autotools stuffLorenz Kästle1-11/+0
2025-08-27check_snmp: use snmp v2c if community is givenLorenz Kästle1-0/+8
2025-08-27Fix Specfile requiresLorenz Kästle1-1/+3
2025-08-27Add libsnmp-dev dependency to codeql gh actionLorenz Kästle1-3/+14
2025-08-27Fix one more typoLorenz Kästle1-1/+1
2025-08-27Add netsnmp lib to specfileLorenz Kästle1-0/+1
2025-08-27Add libsnmp-dev to github action dependenciesLorenz Kästle1-0/+1
2025-08-27check_snmp: fix typosLorenz Kästle1-6/+6
2025-08-27check_snmp: declare internal functions staticLorenz Kästle1-2/+2
2025-08-27check_snmp: remove leftover multiply functionLorenz Kästle1-48/+0
2025-08-27check_snmp: fix/adapt testsLorenz Kästle1-62/+41
2025-08-27check_snmp: hopefully fix helpersLorenz Kästle2-32/+41
2025-08-27check_snmp: Improve error handlingLorenz Kästle1-6/+15
2025-08-27check_snmp: rebuild threshold parsingLorenz Kästle5-65/+125
2025-08-27Fix range comparison and aesthetic improvementsLorenz Kästle1-5/+5
2025-08-25rebuild check_snmpLorenz Kästle3-926/+838
2025-08-11Merge pull request #2107 from RincewindsHat/refactor/check_usersLorenz Kästle7-123/+343
Refactor/check users
2025-08-11Merge branch 'master' into refactor/check_usersLorenz Kästle68-5842/+6408
2025-08-11check_users: Use sd_get_uids instead of sd_get_sessionLorenz Kästle1-1/+1
Previously check_users in combination with systemd used sd_get_sessions (3) to aquire the number of users, probably with the idea that every users opens a session. Turns out, that a user can have multiple sessions and we only really want to know how many users there are. This commit changes to sd_get_uids (3) to achieve that target.
2025-08-04Merge pull request #2139 from waja/ci_fix_rawhidewaja1-0/+3
2025-08-01(Re)construct PLATFORM_ID as it's droped since Fedora 43Jan Wagner1-0/+3
See https://fedoraproject.org/wiki/Changes/Drop_PLATFORM_ID?#Drop_PLATFORM_ID
2025-08-01Merge pull request #2138 from RincewindsHat/improvements/check_sshLorenz Kästle1-34/+47
Improvements/check ssh
2025-08-01clang-formatLorenz Kästle1-29/+43
2025-08-01check_ssh: Put variable in the correct scopeLorenz Kästle1-2/+1
2025-08-01check_ssh: Fix format expressionLorenz Kästle1-1/+1
2025-08-01check_ssh: fix data type to allow for error checkingLorenz Kästle1-2/+2
2025-08-01Merge pull request #2133 from rlaager/fix-check_ssh-buffer-overflowLorenz Kästle1-4/+6
Fix check ssh buffer overflow
2025-07-24Merge pull request #2137 from waja/ci_dispatch_sshwaja2-2/+26
Adding tmate optional to manual dispatch
2025-07-24Adding tmate optional to manual dispatchJan Wagner2-2/+26
2025-07-23Merge pull request #2136 from waja/ci_dispatchwaja3-0/+3
2025-07-23CI: Adding workflow_dispatchJan Wagner3-0/+3
2025-07-14Merge pull request #2134 from RincewindsHat/fix/check_ntp_peer_fmt_convLorenz Kästle1-3/+3
check_ntp_peer: fix invalid conversion in printf
2025-07-14check_ntp_peer: fix invalid conversion in printfLorenz Kästle1-3/+3
2025-07-11check_ssh: Correct type on len variableRichard Laager1-1/+1
strlen() returns a size_t. Signed-off-by: Richard Laager <rlaager@wiktel.com>
2025-07-11check_ssh: Fix buffer overflowRichard Laager1-3/+5
A buffer overflow was occurring when the server responded with: Exceeded MaxStartups\r\n glibc would then abort() with the following output: *** buffer overflow detected ***: terminated It was the memset() that was overflowing the buffer. But the memmove() needed fixing too. First off, there was an off-by-one error in both the memmove() and memset(). byte_offset was already set to the start of the data _past_ the newline (i.e. len + 1). For the memmove(), incrementing that by 1 again lost the first character of the additional output. For the memset(), this causes a buffer overflow. Second, the memset() has multiple issues. The comment claims that it was NULing (sic "null") the "rest". However, it has no idea how long the "rest" is, at this point. It was NULing BUFF_SZ - byte_offset + 1. After fixing the off-by-one / buffer overflow, it would be NULing BUFF_SZ - byte_offset. But that doesn't make any sense. The length of the first line has no relation to the length of the second line. For a quick-and-dirty test, add something like this just inside the while loop: memcpy(output, "Exceeded MaxStartups\r\nnext blah1 blah2 blah3 blah4\0", sizeof("Exceeded MaxStartups\r\nnext blah1 blah2 blah3 blah4\0")); And, after the memmove(), add: printf("output='%s'\n", output); If you fix the memset() buffer overflow, it will output: output='ext blah1 blah2 blah3 ' As you can see, the first character is lost. If you then fix the memmove(), it will output: output='next blah1 blah2 blah3' Note that this is still losing the "blah4". After moving the memset() after byte_offset is set to the new strlen() of output, then it works correctly: output='next blah1 blah2 blah3 blah4' Signed-off-by: Richard Laager <rlaager@wiktel.com>
2025-07-06Merge pull request #2109 from RincewindsHat/refactor/check_loadLorenz Kästle5-294/+444
Refactor/check load
2025-07-06check_load: fix testsLorenz Kästle1-3/+3
2025-07-06Merge branch 'master' into refactor/check_loadLorenz Kästle52-5134/+5254
2025-07-06Make multiline output look betterLorenz Kästle1-1/+32
2025-07-06check_load some number type fixesLorenz Kästle2-7/+7