summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2014-07-31tests: get current directory the perl waySven Nierlein1-1/+2
instead of hoping to have it in the environment. This at least broke tests on solaris. Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-07-31check_dns: unified check outputSven Nierlein1-1/+1
this also allows us to make tests against "critical" in the output. Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-07-31tests: check_disk_smb may exit with critical for unresponsive hosts tooSven Nierlein1-1/+1
Unknown (ex. debian 7) %> ./check_disk_smb -H 1.1.1.1 -s np_foobar -vvv /usr/bin/smbclient //1.1.1.1/np_foobar -U guest% -c du No Answer from Client Critical (ex. debian 8) %> ./check_disk_smb -H 1.1.1.1 -s np_foobar -vvv /usr/bin/smbclient //1.1.1.1/np_foobar -U guest% -c du Connection to 1.1.1.1 failed CRITICAL Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-07-31check_ntp_peer: do not use uninitialized results for max stateSven Nierlein1-3/+6
s/t/jresult are not initialized if there is no corresponding threshold supplied. So we shouldn't use them for calculating our result. Signed-off-by: Sven Nierlein <sven@nierlein.de>
2014-07-30NEWS: Mention --with-qmail-qstat-command optionHolger Weiss1-0/+2
2014-07-30Fix PATH_TO_QMAIL_QSTAT in configureawiddersheim1-2/+5
When configuring PATH_TO_QMAIL_QSTAT the PATH_TO_MAILQ would get applied instead after tests had passed. Also made --with-qmail-qstat-command a configuration option.
2014-07-30Merge pull request #1164 from waja/github981Jan Wagner2-0/+23
2014-07-30adding to THANKSrefs/pull/1164/headJan Wagner1-0/+1
2014-07-30check_dns: Use strchr instead of indexJan Wagner1-1/+1
2014-07-30Merge pull request #1182 from waja/github984Jan Wagner2-5/+12
2014-07-30Merge pull request #1278 from waja/github1227Jan Wagner1-5/+10
2014-07-30Merge pull request #1281 from waja/github1218Jan Wagner2-3/+7
2014-07-30Merge pull request #1280 from sni/fix-generate-change-logSven Nierlein1-0/+2
Fix generate change log
2014-07-30Adding Alexander Wittig to THANKS.inrefs/pull/1281/headJan Wagner1-0/+1
--- Closes #1218 Closes #1281
2014-07-30check_dig: takes into account the -4 and -6 switchAlexander Wittig1-1/+4
Fix automatic DNS server name detection to honor -4 and -6 switches (default to 127.0.0.1 or ::1 respectively, i.e. if -6 is given ::1 is used instead of 127.0.0.1)
2014-07-30check_dig: Fix to work with dig and drill toolAlexander Wittig1-2/+2
FreeBSD starting with version 10 is shipped with ldns instead of bind as resolver. Consequently the dig tool in base is replaced by drill. While dig can still be installed as a third party application, it would be nice to make do with the tools available in the system already. This patch rearranges the command line used to invoke dig slightly so that it can be used with both dig and drill (tested with dig 9.8.3-P1 and 9.9.4 as well as drill 1.6.16). It would be really neat if the configure script could be changed to automatically pick up drill when dig is not available (or the other way around), but my autotools-foo is not good enough for that. This part of the patch is an extended version of the locally maintained patch currently deployed in the FreeBSD ports tree by Dmitry Sivachenko.
2014-07-30tools/generate-change-log: workaround for broken Text::Wraprefs/pull/1280/headSven Nierlein1-0/+1
workaround for broken Text::Wrap: "This shouldn't happen at /usr/share/perl/5.18/Text/Wrap.pm line 84." changing huge to overflow make generating changelogs work again at the price of not having changelog strictly cut of at 80 columns anymore. Words longer than 80 characters will now printed in one line. This mainly affects old sf.net urls. Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-07-30no need for the signed off messages in our changelogSven Nierlein1-0/+1
Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-07-30Make use of xasprintf instead of asprintfrefs/pull/1278/headJan Wagner1-3/+3
--- Closes #1278
2014-07-30lib/utils_base.c: if asprintf fails, string is undefinedRicardo Maraschini1-5/+10
if asprintf fails, string content becomes invalid. we need to check if it ran OK by checking the returned value. in case of fail, asprintf returns -1, otherwise the number of writen bytes is returned. also, on ubuntu 13.10 i've receiving a lot of warnings: "warning: ignoring return value of ‘asprintf’" this patches fixes some of them Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com> --- Closes #1227
2014-07-30check_dns: returns incorrect state when specifying serverJan Wagner1-0/+22
This patch verifies if the response is returned by the dns server we are trying to check --- Closes #981 Closes #982 Closes #1164
2014-07-30travis-ci: create MySQL database 'test'Jan Wagner1-0/+2
2014-07-30check_dns: added test for nonresponsive dns server (#982)Sven Nierlein1-1/+11
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2014-07-29Adding Jason Benguerelrefs/pull/1182/headJan Wagner1-0/+1
2014-07-29check_disk: show troubled partition in verbose modeJan Wagner1-5/+11
I'm submitting a small patch to check_disk that will show which partitions are actually causing the error state. This helps the human operator to quickly identify the exact issue. I made it so a single -v flag is required so it doesn't harm legacy code that may be parsing the original style of output. Thanks to Jason Benguerel. --- Closes #984 Closes #1182
2014-07-29check_ntp_time.c - Cleaned up usage and added a noteabrist1-1/+3
Closes #907 Closes #1184
2014-07-29Adding Patrick McAndrew to THANKS.inJan Wagner1-1/+1
2014-07-29check_ntp_time: adding offset optionJan Wagner1-3/+10
Not sure if this is of use or not - we have a strange requirement to run certain servers 5 minutes fast. I've added a switch to the check_ntp_time to allow for this offset. Thanks to Patrick McAndrew.
2014-07-29netutils.c - A few more changesabrist1-4/+3
Changed bool to short. Removed first instance of is_socket to avoid redeclaration error. Changed 'socket' to 'file socket' for verbosity.
2014-07-29This patch will add the IP and port, or socket name, to the error message andDavide Madrisan1-3/+13
thus simplify the problem debugging: no need to check for this information in the Nagios configuration. This function is only used by 'check_tcp.c'. Without the patch: $ ./plugins/check_tcp -H 127.0.0.1 -p 21 Connection refused $ ./plugins/check_tcp -H /var/spool/nagios/cmd/nagios.cmd Permission denied With the patch: $ ./plugins/check_tcp -H 127.0.0.1 -p 21 connect to address 127.0.0.1 and port 21: Connection refused $ ./plugins/check_tcp -H /var/spool/nagios/cmd/nagios.cmd connect to socket /var/spool/nagios/cmd/nagios.cmd: Permission denied Thanks to Davide Madrisan. --- Closes #1277
2014-07-28check_mysql: ignore authentication failureJan Wagner2-2/+21
This patch allows checking if MySQL server is running without providing valid username and password. Similar to check_ssh plugin it returns MySQL server version string and protocol number. Example: check_mysql -n -H aaa.bbb.ccc.ddd MySQL OK - Version: 5.0.51a-24+lenny5 (protocol 10) This is useful for monitoring servers where one does not have administrator privileges or does not want to grant any privileges for the monitoring station. To enable this functionality new option --ignore-auth (-n) is added to check_mysql plugin. Thanks to Julius Kriukas Closes #1020 Closes #1178
2014-07-21travis-ci: Installing libhttp-daemon-ssl-perl to make ↵Jan Wagner1-1/+1
plugins/tests/check_http.t possible to run
2014-07-21Use "C" locale when running test suiteHolger Weiss1-0/+2
Some of our tests check locale-dependent plugin output, so let's make sure "make test" is always using the "C" locale.
2014-07-21plugins/tests/check_http.t: Adjust date stringsHolger Weiss1-4/+4
Adjust the expected date strings to the now-localized output produced by plugins/sslutils.c. Closes #1275.
2014-07-21travis-ci: Using libfreeradius-client-dev as build-depJan Wagner1-1/+2
2014-07-21plugins/t/check_dns.t: Fix Perl warningHolger Weiss1-1/+1
Perl said: "Unrecognized escape \d passed through at ./t/check_dns.t line 57."
2014-07-21sslutils: expire time in local timezone formatJan Wagner2-5/+5
sshutils prints the expiry time of certificates in US format this patch uses the strftime %c, I don't know how portable that is Thanks to Neil Prockter. Closes #1188 Closes #1161 Closes #977 Closes #976 Closes #975 Closes #840 Closes #382
2014-07-20check_ifstatus: perfdata bugJan Wagner2-1/+2
The perfdata output violates the current Nagios Plugin Development Guidelines (http://nagiosplug.sourceforge.net/developer-guidelines.html#AEN202 : "space separated list of label/value pairs"). Thus the Addon PNP did not read the perdata correctly. The patch replaces the commas with spaces in the perfdata output. Many thanks to Patric Wust. --- Closes #1169 and #721.
2014-07-20travis-ci: Adding ports for check_hpjdJan Wagner1-0/+2
2014-07-20added tests for check_hpjd port optionsabrist1-7/+28
--- Closes #1160 and #973
2014-07-20Added check_hpjd port option to news and clarified the port usage error.abrist2-1/+5
2014-07-20check_hpjd - Added a switch for port specification. Defaults to 161.abrist1-6/+24
2014-07-20check_ntp.t - fixed tests for new status outputabrist1-2/+2
closes #1236 and #1239
2014-07-20check_ntp_peer - Added specific state output for each metric. It now should ↵abrist1-12/+37
be easy to see which check caused the alert.
2014-07-11NEWS: Fix typov2.0Holger Weiss1-1/+1
2014-07-11Prepare for the 2.0 releaseHolger Weiss3-3/+3
2014-07-11NEWS: Wrap overly long lineHolger Weiss1-1/+2
2014-07-10Update THANKS.in file with latest authorHolger Weiss1-0/+1
2014-07-10Merge pull request #1272 from mfalkvidd/masterSam Kottler1-1/+1
check_procs: Add delay after forking in test
2014-07-10check_procs: Add delay after forking in testrefs/pull/1272/headMikael Falkvidd1-1/+1
Forking raises a race condition, where the parent might run the test before the child has had time to fork. If that happens, an error similar to this is produced: Failed test 'Output correct' at ./t/check_procs.t line 32. 'PROCS OK: 0 processes with args 'sleep 7' | processes=0;;;0;' doesn't match '/^PROCS OK: 1 process?/' Sleeping a bit should avoid the problem. It might be enough to sleep less than a second, but perl's built-in sleep function only supports integer seconds. In our build environment, the build failed 3 of 4 times before this patch. After the patch it failed 0 of 7 times. Signed-off-by: Mikael Falkvidd <mfalkvidd@op5.com>