| Age | Commit message (Collapse) | Author | Files | Lines | |
|---|---|---|---|---|---|
| 11 days | OpenBSD: pledge(2) some network-facing checks (#2225) | Alvar | 1 | -0/+17 | |
| OpenBSD's pledge(2) system call allows the current process to self-restrict itself, being reduced to promised pledges. For example, unless a process says it wants to write to files, it is not allowed to do so any longer. This change starts by calling pledge(2) in some network-facing checks, removing the more dangerous privileges, such as executing other files. My initial motivation came from check_icmp, being installed as a setuid binary and (temporarily) running with root privileges. There, the pledge(2) calls result in check_icmp to only being allowed to interact with the network and to setuid(2) to the calling user later on. Afterwards, I went through my most commonly used monitoring plugins directly interacting with the network. Thus, I continued with pledge(2)-ing check_curl - having a huge codebase and all -, check_ntp_time, check_smtp, check_ssh, and check_tcp. For most of those, the changes were quite similar: start with network-friendly promises, parse the configuration, give up file access, and proceed with the actual check. | |||||
| 2026-01-19 | check_icmp: Populate progname before np_extra_opts call (#2226) | Alvar | 1 | -9/+8 | |
| Within np_extra_opts, the ini parser expects a valid progname as the default section to select a configuration section in the ini file. However, within the check_icmp codebase, the progname is being populated directly after the np_extra_opts call, being a null pointer before. $ ./check_icmp --extra-opts=@foo.ini Segmentation fault (core dumped) > #0 strlen () at /usr/src/lib/libc/arch/amd64/string/strlen.S:125 > #1 0x000003989615d032 in _libc_strdup (str=Variable "str" is not available.) at /usr/src/lib/libc/string/strdup.c:44 > #2 0x000003966f751b74 in np_get_defaults (locator=0x73ede1e538ea "@foo.ini", default_section=0x0) at parse_ini.c:91 > #3 0x000003966f7518ce in np_extra_opts (argc=0x73ede1e5369c, argv=0x73ede1e53728, plugin_name=0x0) at extra_opts.c:98 > #4 0x000003966f74165a in main (argc=1, argv=0x0) at check_icmp.c:832 The progname variable is set within the process_arguments function, requiring the already enriched arguments from np_extra_opts. Thus, I moved the progname detection out of this function, directly before the np_extra_opts call. This pattern does already exists in check_tcp. I briefly looked for similar issues in other plugins, but found none. | |||||
| 2026-01-16 | check_icmp: prevent segfault on OpenBSD (#2224) | Lorenz Kästle | 1 | -2/+5 | |
| * check_icmp: prevent segfault on OpenBSD This commit adds a sanity check for sockets in check_icmp. Previously FD_ISSET segfaulted when a socket value was -1 (on OpenBSD). The changes here add an explicit check whether the socket is -1 (and therefore not set). --------- Co-authored-by: Lorenz Kästle <lorenz.kaestle@netways.de> | |||||
| 2026-01-09 | check_icmp: fix some compiler warnings (and maybe bugs) | Lorenz Kästle | 1 | -21/+32 | |
| 2025-12-11 | plugins-root/check_icmp: Fix build for SIOCGIFADDR | Alvar Penning | 1 | -4/+4 | |
| The refactoring in eafee9c3f91879afa82749fa1d8cd2b0b53a5d5c missed the part within "#if defined(SIOCGIFADDR)" in get_ip_address. | |||||
| 2025-12-11 | plugins-root/check_icmp: Import sys/ioctl.h | Alvar Penning | 1 | -0/+3 | |
| The ioctl(2) call within "#if defined(SIOCGIFADDR)" requires the include. | |||||
| 2025-09-15 | More refactoring | Lorenz Kästle | 1 | -2/+2 | |
| 2025-09-15 | Run clang-format again | Lorenz Kästle | 3 | -323/+378 | |
| 2025-06-23 | Reapply "check_dhcp: reduce number of tests for weird reasons" | Lorenz Kästle | 1 | -1/+1 | |
| This reverts commit 612d261cbf467c82f0dcc0ed63e7584d91f194c4. | |||||
| 2025-06-23 | Revert "check_dhcp: reduce number of tests for weird reasons" | Lorenz Kästle | 1 | -1/+1 | |
| This reverts commit 52338c3423d4b10d2bbeec7a120c7dd2a98fa092. | |||||
| 2025-06-23 | Add check_dhcp related files to Makefile | Lorenz Kästle | 1 | -1/+2 | |
| 2025-06-23 | check_dhcp: reduce number of tests for weird reasons | Lorenz Kästle | 1 | -1/+1 | |
| 2025-06-23 | Adapt tests | Lorenz Kästle | 1 | -10/+14 | |
| 2025-06-23 | check_dhcp: little fix to output | Lorenz Kästle | 1 | -1/+1 | |
| 2025-06-23 | Refactor check_dhcp | Lorenz Kästle | 2 | -343/+448 | |
| 2025-06-23 | check_dhcp: clang-format | Lorenz Kästle | 1 | -65/+119 | |
| 2025-06-23 | check_icmp: Add missing line ending in help | Lorenz Kästle | 1 | -1/+1 | |
| 2025-06-23 | check_icmp: trigger help before anything important | Lorenz Kästle | 1 | -4/+6 | |
| 2025-06-23 | check_icmp: Add comment to config | Lorenz Kästle | 1 | -1/+3 | |
| 2025-06-23 | check_icmp: add long options to help | Lorenz Kästle | 1 | -27/+31 | |
| 2025-06-23 | check_icmp: remove dead comment | Lorenz Kästle | 1 | -8/+0 | |
| 2025-06-23 | check_icmp: remove unnecessary variable | Lorenz Kästle | 3 | -4/+1 | |
| 2025-06-23 | check_icmp: correct output strings | Lorenz Kästle | 1 | -12/+12 | |
| 2025-06-23 | check_icmp: remove paket_interval, was never used anyway | Lorenz Kästle | 3 | -53/+37 | |
| 2025-06-23 | Fix typo | Lorenz Kästle | 1 | -1/+1 | |
| 2025-06-23 | check_icmp: cleanup some leftover comments | Lorenz Kästle | 1 | -22/+1 | |
| 2025-06-23 | check_icmp: add long options, add output format option | Lorenz Kästle | 3 | -3/+57 | |
| This commit switches check_icmp from getopt to getopt_long to provide long options too and (most importantly) homogenize option parsing between the different plugins. | |||||
| 2025-06-23 | Improve check_icmp help output | Lorenz Kästle | 1 | -29/+19 | |
| 2025-06-20 | Fix number of tests | Lorenz Kästle | 1 | -1/+1 | |
| 2025-06-20 | Fix test with weird arguments | Lorenz Kästle | 1 | -1/+1 | |
| 2025-06-20 | check_icmp: Remove signal handling and timeouts | Lorenz Kästle | 4 | -53/+16 | |
| The timeout option was redundant in that the runtime of check_icmp was always limited by the input parameters and therefore timeout gets removed with this commit to avoid that confusion. The rest of the signal handlings was removed too, since the added complexity does not provide sufficient returns. If check_icmp gets a signal, it now dies like most other programs instead of trying to save some things and return a (arguably wrong) result. | |||||
| 2025-06-19 | Override state with min_hosts_alive | Lorenz Kästle | 1 | -25/+14 | |
| 2025-06-19 | Reintroduce min_hosts_alive | Lorenz Kästle | 1 | -2/+22 | |
| 2025-06-17 | Fix possible multiplication overflow? | Lorenz Kästle | 1 | -1/+1 | |
| 2025-06-17 | Improve error detection for threshold parsers | Lorenz Kästle | 2 | -35/+65 | |
| 2025-06-09 | Remove check_icmp text regex tests | Lorenz Kästle | 1 | -26/+0 | |
| 2025-05-18 | Format specifier fixes | Lorenz Kästle | 1 | -6/+6 | |
| 2025-05-18 | some more fixes | Lorenz Kästle | 1 | -7/+8 | |
| 2025-05-18 | Fix typos | Lorenz Kästle | 1 | -3/+2 | |
| 2025-05-18 | Some more fixes | Lorenz Kästle | 4 | -32/+31 | |
| 2025-05-18 | WIP - check_icmp refactor 8 | Lorenz Kästle | 4 | -255/+332 | |
| 2025-05-18 | WIP - check_icmp refactor 7 | Lorenz Kästle | 1 | -85/+108 | |
| 2025-05-18 | Clang-format | Lorenz Kästle | 2 | -14/+13 | |
| 2025-05-17 | WIP - check_icmp refactor 6 | Lorenz Kästle | 4 | -383/+360 | |
| 2025-05-17 | Lib: Add perfdata for char and unsigned char | Lorenz Kästle | 1 | -1/+1 | |
| 2025-05-16 | WIP - check_icmp refactor 5 | Lorenz Kästle | 3 | -15/+20 | |
| 2025-05-06 | WIP - check_icmp refactor 4 | Lorenz Kästle | 1 | -73/+147 | |
| 2025-05-05 | WIP - check_icmp refactor 3 | Lorenz Kästle | 3 | -115/+118 | |
| 2025-05-04 | WIP - check_icmp refactor 2 | Lorenz Kästle | 4 | -341/+540 | |
| 2025-04-28 | WIP: check_icmp refactor | Lorenz Kästle | 4 | -629/+877 | |
 |
index : monitoring-plugins | |
| Monitoring Plugins | Monitoring Plugins |
| summaryrefslogtreecommitdiffstats |
path: root/plugins-root