summaryrefslogtreecommitdiffstats
path: root/plugins/check_by_ssh.c
AgeCommit message (Collapse)AuthorFilesLines
2025-09-15check_by_ssh: Ignore output on stderr by defaultAlvar Penning1-8/+15
check_by_ssh no longer returns UNKNOWN if ssh(1) returns data on stderr. But it can be enforced again by the new "--unknown-on-stderr" option. --- The default logic of check_by_ssh results in an UNKNOWN state if the ssh(1) process produces output on stderr. Using the "--skip-stderr=[n]" option allows ignoring a certain amount of lines or disabling this check altogether. Furthermore, passing the "--warn-on-stderr" option reduces the exit code to WARNING. The "--help" output does not document this behavior, only states that "--warn-on-stderr" will result in the WARNING, but does not mention the UNKNOWN by default. The man page of ssh(1) mentions that debug information is logged to stderr. This conflicts with the described logic, resulting in check_by_ssh to go UNKNOWN, unless additional options are set. Starting with OpenSSH version 10.1, ssh(1) will report warnings to stderr if the opposite server does not support post-quantum cryptography, <https://www.openssh.com/pq.html>. This change, slowly being rolled out throughout the next months/years, might result in mass-breakages of check_by_ssh. By introducing a new "--unknown-on-stderr" option, enforcing the prior default logic of an UNKNOWN state for data on stderr, and ignoring output on stderr by default, check_by_ssh will continue to work. One might even argue that this change converges actual implementation and the documented behavior, as argued above. --- $ ssh example '/usr/lib/nagios/plugins/check_dummy 0 demo' ** WARNING: connection is not using a post-quantum key exchange algorithm. ** This session may be vulnerable to "store now, decrypt later" attacks. ** The server may need to be upgraded. See https://openssh.com/pq.html OK: demo $ echo $? 0 $ ./check_by_ssh -H example -C '/usr/lib/nagios/plugins/check_dummy 0 demo' OK: demo $ echo $? 0 $ ./check_by_ssh -H example -C '/usr/lib/nagios/plugins/check_dummy 0 demo' --warn-on-stderr Remote command execution failed: ** WARNING: connection is not using a post-quantum key exchange algorithm. $ echo $? 1 $ ./check_by_ssh -H example -C '/usr/lib/nagios/plugins/check_dummy 0 demo' --unknown-on-stderr Remote command execution failed: ** WARNING: connection is not using a post-quantum key exchange algorithm. $ echo $? 3 --- Fixes #2147.
2025-09-15Run clang-format againLorenz Kästle1-44/+64
2025-03-10Refactor check_by_sshLorenz Kästle1-126/+139
2025-02-24check_by_ssh: clang-formatLorenz Kästle1-35/+63
2025-02-24check_by_ssh: Remove warning/critical from helpLorenz Kästle1-1/+0
2024-10-31check_by_ssh: linter fixesRincewindsHat1-10/+11
2024-10-31check_by_ssh: do not export local symbolsRincewindsHat1-19/+19
2024-10-31check_by_ssh: Copyright updateRincewindsHat1-2/+2
2024-10-31check_by_ssh: clang-formatRincewindsHat1-254/+227
2023-10-19Fixes for -Wsign-compareRincewindsHat1-8/+7
2023-10-18check_by_ssh: Use C99 booleansRincewindsHat1-6/+6
2022-07-14check_by_ssh: Add "-U" flag (#1123). (#1774)Archie L. Cobbs1-2/+16
This causes a 255 exit value from ssh(1), which indicates a connection failure, to return UNKNOWN instead of CRITICAL; similar to check_nrpe's "-u" flag.
2022-01-14Merge pull request #1301 from nafets/exit_on_stderrLorenz1-2/+12
check_by_ssh: added option to exit with an warning, if there is output on STDERR
2021-06-25Let ssh decide if a host is valid, enables usage of ssh .config fileLorenz Kästle1-2/+0
2016-09-17check_by_ssh: print command output in verbose modeSven Nierlein1-0/+7
right now it is not possible to print the command output of ssh. check_by_ssh only prints the command itself. This patchs adds printing the output too. This makes it possible to use ssh with verbose logging which helps debuging any connection, key or other ssh problems. Note: you must use -E,--skip-stderr=<high number>, otherwise check_by_ssh would always exit with unknown state. Example: ./check_by_ssh -H localhost -o LogLevel=DEBUG3 -C "sleep 1" -E 999 -v Signed-off-by: Sven Nierlein <sven@nierlein.de>
2015-10-04use unknown exit code for help/version in pluginsSven Nierlein1-2/+2
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2014-11-17added option to exit with an warning, if there is output on STDERRnafets1-2/+12
2014-08-06check_by_ssh: added --hostname supportSven Nierlein1-1/+2
just like the guidelines and the help already suggests. Signed-off-by: Sven Nierlein <sven@nierlein.de>
2014-01-21Merge branch 'rename'Thomas Guyot-Sionnest1-8/+8
2014-01-21plugins/*.c: Alterations for timeout messages.Spenser Reinhardt1-1/+1
.c file changes for misleading timeout messages in help functions. Solution to pull request #1209 tracker by awiddersheim. Files: plugins/check_apt.c, plugins/check_by_ssh.c, plugins/check_dbi.c, plugins/check_dig.c, plugins/check_disk.c, plugins/check_dns.c, plugins/check_game.c, plugins/check_http.c, plugins/check_ldap.c, plugins/check_ntp.c, plugins/check_ntp_peer.c, plugins/check_ntp_time.c, plugins/check_nwstat.c, plugins/check_overcr.c, plugins/check_pgsql.c, plugins/check_ping.c, plugins/check_procs.c, plugins/check_radius.c, plugins/check_real.c, plugins/check_smtp.c, plugins/check_snmp.c, plugins/check_ssh.c, plugins/check_tcp.c, plugins/check_time.c, plugins/check_ups.c, plugins/negate.c
2014-01-20Capitalize "Monitoring" when it's the first wordHolger Weiss1-1/+1
2014-01-19Project rename initial commit.Monitoring Plugins Development Team1-8/+8
This is an initial take at renaming the project to Monitoring Plugins. It's not expected to be fully complete, and it is expected to break things (The perl module for instance). More testing will be required before this goes mainline.
2012-06-29Die when asprintf failsAnders Kaseorg1-5/+5
Fixes many instances of warning: ignoring return value of 'asprintf', declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-04-09check_by_ssh: added -F config file to specify alternative ssh configSven Nierlein1-2/+9
2010-04-22Add newline after "Usage:" in --helpThomas Guyot-Sionnest1-1/+1
2010-04-21Standardize the extra-opts notesThomas Guyot-Sionnest1-6/+0
2010-04-14Fix translations when extra-opts aren't enabledThomas Guyot-Sionnest1-9/+9
Bug #2832884 reported problem with translations outputting pot file headers. This is caused by "" matching the header of the translation files. This patch moves gettext macros inside utils macros and update some french translations.
2009-05-26Fix check_by_ssh interpretation of quotes in -C parameter (#1985246, #2268675)Thomas Guyot-Sionnest1-16/+56
2008-11-23Removing CVS/SVN tags and replacing with git-based versioningThomas Guyot-Sionnest1-6/+2
For contrib/, full tags have been imported from subversion git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2091 f882894a-f735-0410-b71e-b25c423dba1c
2008-05-27Addition to help to state that -f will always return OK if ssh commandTon Voon1-1/+1
is executed (Alain Dewit - 1852198) git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2002 f882894a-f735-0410-b71e-b25c423dba1c
2008-05-21Fixed passive option in check_by_sshThomas Guyot-Sionnest1-11/+10
Also: - On non-skipped stderr, check_by_ssh now returns UNKNOWN or worse (result from command) instead of always UNKNOWN. - Fixed passive tests and make is always run the specified number of tests (using fail if there's nothing to test). git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1997 f882894a-f735-0410-b71e-b25c423dba1c
2008-05-07Added support for --extra-opts in all C plugins (disabled by default, see ↵Thomas Guyot-Sionnest1-0/+11
configure --help) git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1991 f882894a-f735-0410-b71e-b25c423dba1c
2008-04-27--help output cleanup (plus removal of spaces on blank lines)Thomas Guyot-Sionnest1-6/+9
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1984 f882894a-f735-0410-b71e-b25c423dba1c
2008-01-30Bump plugins/ to GPLv3 (check_apt to check_nwstat)Thomas Guyot-Sionnest1-19/+17
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1916 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-23Added multiline output capability to check_by_ssh. Thanks to Matthias Flacke ↵Matthias Eble1-1/+2
(#1769653) git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1792 f882894a-f735-0410-b71e-b25c423dba1c
2007-06-12Add "-v" to help/usage output.Holger Weiss1-1/+2
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1738 f882894a-f735-0410-b71e-b25c423dba1c
2007-04-18Revert my previous change to "-S/--skip" in favour of the two optionsHolger Weiss1-20/+45
"-E/--skip-stderr" and "-S/--skip-stdout". Both of them support omitting the number of lines to skip, in which case all output on the respective file descriptor is skipped. "--skip" is kept as an alias for "--skip-stdout" for backwards compatibility with recent releases. Also, print a message if no (non-skipped) stdout/stderr output is available. This fixes a segfault if the remote command prints no output. git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1692 f882894a-f735-0410-b71e-b25c423dba1c
2007-04-14Up to revision 1.35, the "-S" option skipped the specified number ofHolger Weiss1-9/+12
lines written to stderr. With revision 1.36 and newer, "-S" skipped the specified number of lines written to stdout. Now, "-S" skips the specified number of lines written to stderr; and if the number specified via "-S" minus the number of lines written to stderr is larger than 0, the difference is used as the number of lines written to stdout to skip. Also, the "--help" output was fixed. (Hector - 1675286) git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1685 f882894a-f735-0410-b71e-b25c423dba1c
2007-01-28Don't try to print `optarg' (which will be a NULL pointer) if an unknownHolger Weiss1-1/+1
command line option was used, as this leads to a segfault on some systems. The unknown option will be printed by getopt(3) anyway. So, simply call print_usage() and exit UNKNOWN via the new usage5() instead. git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1590 f882894a-f735-0410-b71e-b25c423dba1c
2007-01-22Added "-o,--ssh-option=OPTION" which hands "-o OPTION" over to ssh(1) andHolger Weiss1-3/+15
"-q,--quiet" which tells ssh(1) to suppress warnings (Gerhard Lausser - 1472491) git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1574 f882894a-f735-0410-b71e-b25c423dba1c
2006-10-19first pass at cleaning localization for new releaseBenoit Mortier1-18/+31
first pass at making all the headre be the same licence, plugin, etc... git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1499 f882894a-f735-0410-b71e-b25c423dba1c
2006-06-14starting the BIG locale update ;-)Benoit Mortier1-53/+43
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1425 f882894a-f735-0410-b71e-b25c423dba1c
2006-03-22Typo (Thomas Guettler - 1433447)Ton Voon1-1/+1
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1341 f882894a-f735-0410-b71e-b25c423dba1c
2005-10-24initial merging of ae's np_runcmd code into selected plugins.M. Sean Finney1-95/+55
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1260 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-25internationalization of check_dhcpBenoit Mortier1-3/+1
internationalization fixes of check_ssh git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1058 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-08patch 1028033Benoit Mortier1-2/+2
minor internationalization fixes git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1013 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-04various internationalization fixesBenoit Mortier1-2/+2
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1002 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-04internationalization fixesBenoit Mortier1-1/+1
bugfixes git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1001 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-03reverting my changes from !=TRUE to == ERROR, that's not good ;-( sorryBenoit Mortier1-1/+1
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@998 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-03remove UT_HLP_VRS from print_usageBenoit Mortier1-5/+2
this was not a good idea ;-) git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@994 f882894a-f735-0410-b71e-b25c423dba1c