| Age | Commit message (Collapse) | Author | Files | Lines | |
|---|---|---|---|---|---|
| 2025-09-15 | check_by_ssh: Ignore output on stderr by default | Alvar Penning | 2 | -8/+17 | |
| check_by_ssh no longer returns UNKNOWN if ssh(1) returns data on stderr. But it can be enforced again by the new "--unknown-on-stderr" option. --- The default logic of check_by_ssh results in an UNKNOWN state if the ssh(1) process produces output on stderr. Using the "--skip-stderr=[n]" option allows ignoring a certain amount of lines or disabling this check altogether. Furthermore, passing the "--warn-on-stderr" option reduces the exit code to WARNING. The "--help" output does not document this behavior, only states that "--warn-on-stderr" will result in the WARNING, but does not mention the UNKNOWN by default. The man page of ssh(1) mentions that debug information is logged to stderr. This conflicts with the described logic, resulting in check_by_ssh to go UNKNOWN, unless additional options are set. Starting with OpenSSH version 10.1, ssh(1) will report warnings to stderr if the opposite server does not support post-quantum cryptography, <https://www.openssh.com/pq.html>. This change, slowly being rolled out throughout the next months/years, might result in mass-breakages of check_by_ssh. By introducing a new "--unknown-on-stderr" option, enforcing the prior default logic of an UNKNOWN state for data on stderr, and ignoring output on stderr by default, check_by_ssh will continue to work. One might even argue that this change converges actual implementation and the documented behavior, as argued above. --- $ ssh example '/usr/lib/nagios/plugins/check_dummy 0 demo' ** WARNING: connection is not using a post-quantum key exchange algorithm. ** This session may be vulnerable to "store now, decrypt later" attacks. ** The server may need to be upgraded. See https://openssh.com/pq.html OK: demo $ echo $? 0 $ ./check_by_ssh -H example -C '/usr/lib/nagios/plugins/check_dummy 0 demo' OK: demo $ echo $? 0 $ ./check_by_ssh -H example -C '/usr/lib/nagios/plugins/check_dummy 0 demo' --warn-on-stderr Remote command execution failed: ** WARNING: connection is not using a post-quantum key exchange algorithm. $ echo $? 1 $ ./check_by_ssh -H example -C '/usr/lib/nagios/plugins/check_dummy 0 demo' --unknown-on-stderr Remote command execution failed: ** WARNING: connection is not using a post-quantum key exchange algorithm. $ echo $? 3 --- Fixes #2147. | |||||
| 2025-09-15 | Merge branch 'master' into refactor/check_apt | Lorenz Kästle | 55 | -1681/+2484 | |
| 2025-09-15 | Fix types in check_apt | Lorenz Kästle | 1 | -4/+4 | |
| 2025-09-15 | More refactoring | Lorenz Kästle | 3 | -123/+137 | |
| 2025-09-15 | Run clang-format again | Lorenz Kästle | 53 | -1560/+2349 | |
| 2025-09-15 | check_apt: implement new output | Lorenz Kästle | 2 | -72/+172 | |
| 2025-09-15 | check_apt: improve some variable types to make the linter happy | Lorenz Kästle | 2 | -12/+12 | |
| 2025-09-15 | Add output formatting option | Lorenz Kästle | 3 | -1/+26 | |
| 2025-09-15 | fix number of tests | Lorenz Kästle | 1 | -1/+1 | |
| 2025-09-15 | Adapt test to new error message | Lorenz Kästle | 1 | -1/+1 | |
| 2025-09-15 | Fix typo in error message | Lorenz Kästle | 1 | -1/+1 | |
| 2025-09-15 | Fix typos | Lorenz Kästle | 1 | -4/+4 | |
| 2025-09-15 | Fix/adapt tests | Lorenz Kästle | 2 | -18/+29 | |
| 2025-09-15 | check_curl: use new cert check function | Lorenz Kästle | 1 | -3/+5 | |
| 2025-09-15 | Add new cert check function | Lorenz Kästle | 3 | -2/+139 | |
| 2025-09-15 | check_curl: fix perfdata label | Lorenz Kästle | 1 | -1/+1 | |
| 2025-09-15 | check_curl: finish after cert without continue param | Lorenz Kästle | 1 | -1/+1 | |
| 2025-09-15 | Fix regex matching | Lorenz Kästle | 1 | -5/+11 | |
| 2025-09-15 | Improve error message | Lorenz Kästle | 1 | -3/+2 | |
| 2025-09-13 | check_curl: test adaption and output adaption | Lorenz Kästle | 3 | -63/+69 | |
| 2025-09-13 | check_curl: remove display-html option | Lorenz Kästle | 3 | -26/+11 | |
| 2025-09-12 | check_curl: implement new output mechanism | Lorenz Kästle | 4 | -398/+443 | |
| 2025-09-12 | check_curl: fix default redirect setting | Lorenz Kästle | 1 | -1/+1 | |
| 2025-09-12 | Fix struct access | Lorenz Kästle | 2 | -2/+2 | |
| 2025-09-12 | check_curl: create outsourced helpers in extra files | Lorenz Kästle | 5 | -1335/+1397 | |
| 2025-09-11 | check_curl: http3 is only available with libcurl 7.66 or later | Lorenz Kästle | 1 | -1/+4 | |
| 2025-09-11 | check_curl: refactoring to modularize code | Lorenz Kästle | 2 | -539/+594 | |
| 2025-09-11 | check_curl: improve option handling a bit | Lorenz Kästle | 2 | -9/+14 | |
| 2025-09-11 | check_curl: fix function signature | Lorenz Kästle | 1 | -1/+2 | |
| 2025-09-11 | check_curl: less global state | Lorenz Kästle | 1 | -31/+41 | |
| 2025-09-10 | sslutils: some refactoring to improve readability | Lorenz Kästle | 1 | -36/+28 | |
| 2025-09-10 | plugins-netutils: return proper state from test functions | Lorenz Kästle | 2 | -2/+3 | |
| 2025-09-10 | netutils.h: clang-format | Lorenz Kästle | 1 | -66/+65 | |
| 2025-09-10 | sslutils.c: clang-format | Lorenz Kästle | 1 | -24/+41 | |
| 2025-09-10 | check_curl: remove the other gotos | Lorenz Kästle | 1 | -5/+16 | |
| 2025-09-10 | check_curl: remove goto logic | Lorenz Kästle | 1 | -122/+138 | |
| 2025-09-10 | check_curl: set http port to 80 by default | Lorenz Kästle | 1 | -1/+1 | |
| 2025-09-10 | check_curl: pre compile regex for string matching | Lorenz Kästle | 2 | -3/+12 | |
| 2025-09-10 | check_curl: remove another global variable | Lorenz Kästle | 1 | -4/+2 | |
| 2025-09-10 | Merge branch 'master' into refactor/check_curl | Lorenz Kästle | 1 | -1767/+1822 | |
| 2025-09-09 | check_http: formatting + no-brainer linter fixes | Lorenz Kästle | 1 | -1767/+1822 | |
| 2025-09-09 | check_curl: more refactoring | Lorenz Kästle | 2 | -366/+469 | |
| 2025-09-09 | Fix some include paths | Lorenz Kästle | 1 | -3/+3 | |
| 2025-09-09 | Merge branch 'master' into refactor/check_curl | Lorenz Kästle | 18 | -1299/+2659 | |
| 2025-09-09 | Adjust number of tests | Lorenz Kästle | 1 | -1/+1 | |
| 2025-09-09 | Add break statement to switch path | Lorenz Kästle | 1 | -0/+1 | |
| 2025-09-08 | Little adaptions for old compilers | Lorenz Kästle | 1 | -4/+3 | |
| 2025-09-08 | Fix spelling ... | Lorenz Kästle | 1 | -1/+1 | |
| 2025-09-08 | check_snmp: refactoring + fixes | Lorenz Kästle | 9 | -537/+1623 | |
| This commit moves the state retention logic to check_snmp as it is only used there and I do not want it to be used at all, so it doesn't get a place in the lib. Otherwise this adapts tests and fixes the rate computing in the refactored version of check_snmp. Also fixes some bugs detected with the tests | |||||
| 2025-09-08 | snmp: fix complaint of snmpd about paths | Lorenz Kästle | 1 | -1/+1 | |
