From f855c5b5bbbc6d5436741fd8108be64825a3c76b Mon Sep 17 00:00:00 2001
From: Lorenz Kästle <12514511+RincewindsHat@users.noreply.github.com>
Date: Mon, 15 Sep 2025 14:06:55 +0200
Subject: general refactorin in lib, more local variables, real booleans

---
 lib/tests/test_opts1.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

(limited to 'lib/tests/test_opts1.c')

diff --git a/lib/tests/test_opts1.c b/lib/tests/test_opts1.c
index 99da5596..fa95c4d4 100644
--- a/lib/tests/test_opts1.c
+++ b/lib/tests/test_opts1.c
@@ -40,15 +40,16 @@ void my_free(int *argc, char **newargv, char **argv) {
 #else
 void my_free(int *argc, char **newargv, char **argv) {
 	/* Free stuff (and print while we're at it) */
-	int i, freeflag = 1;
+	bool freeflag = true;
 	printf("    Arg(%i): ", *argc + 1);
 	printf("'%s' ", newargv[0]);
-	for (i = 1; i < *argc; i++) {
+
+	for (int i = 1; i < *argc; i++) {
 		printf("'%s' ", newargv[i]);
 		/* Stop freeing when we get to the start of the original array */
 		if (freeflag) {
 			if (newargv[i] == argv[1]) {
-				freeflag = 0;
+				freeflag = false;
 			} else {
 				free(newargv[i]);
 			}
@@ -64,13 +65,12 @@ void my_free(int *argc, char **newargv, char **argv) {
 #endif
 
 int array_diff(int i1, char **a1, int i2, char **a2) {
-	int i;
-
 	if (i1 != i2) {
 		printf("    Argument count doesn't match!\n");
 		return 0;
 	}
-	for (i = 0; i <= i1; i++) {
+
+	for (int i = 0; i <= i1; i++) {
 		if (a1[i] == NULL && a2[i] == NULL) {
 			continue;
 		}
@@ -87,11 +87,10 @@ int array_diff(int i1, char **a1, int i2, char **a2) {
 }
 
 int main(int argc, char **argv) {
-	char **argv_new = NULL;
-	int i, argc_test;
-
 	plan_tests(5);
 
+	char **argv_new = NULL;
+	int argc_test;
 	{
 		char *argv_test[] = {"prog_name", (char *)NULL};
 		argc_test = 1;
-- 
cgit v1.2.3-74-g34f1