From c537d71a3af67d0df4e1e015f6b9dcbb505f08d2 Mon Sep 17 00:00:00 2001 From: Andreas Ericsson Date: Fri, 2 Nov 2012 14:52:34 +0100 Subject: plugins/check_snmp: Show snmp error when we fail to parse its output Dying without a hint of what went wrong is just plain annoying. With this patch we at least get a hint. While at it, we fix the string offset so the output we're interested in doesn't keep the equal sign that snmpget prints. Signed-off-by: Andreas Ericsson diff --git a/plugins/check_snmp.c b/plugins/check_snmp.c index 0ddfb94..8a8ee18 100644 --- a/plugins/check_snmp.c +++ b/plugins/check_snmp.c @@ -419,7 +419,7 @@ main (int argc, char **argv) show = strstr (response, "Timeticks: "); } else - show = response; + show = response + 3; iresult = STATE_DEPENDENT; @@ -428,7 +428,7 @@ main (int argc, char **argv) if (thlds[i]->warning || thlds[i]->critical || calculate_rate) { ptr = strpbrk (show, "0123456789"); if (ptr == NULL) - die (STATE_UNKNOWN,_("No valid data returned")); + die (STATE_UNKNOWN,_("No valid data returned (%s)\n"), show); response_value[i] = strtod (ptr, NULL); if(calculate_rate) { -- cgit v0.10-9-g596f