From 4a0e309f9f5a85af6087e3eb7034a98dd410c6f7 Mon Sep 17 00:00:00 2001
From: Lorenz Kästle <12514511+RincewindsHat@users.noreply.github.com>
Date: Wed, 12 Mar 2025 23:37:36 +0100
Subject: Fail correctly with missing thresholds

---
 plugins/check_users.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

(limited to 'plugins/check_users.c')

diff --git a/plugins/check_users.c b/plugins/check_users.c
index b7b7bd24..cd3bd181 100644
--- a/plugins/check_users.c
+++ b/plugins/check_users.c
@@ -215,8 +215,11 @@ check_users_config_wrapper process_arguments(int argc, char **argv) {
 	if (warning_range) {
 		tmp = mp_parse_range_string(warning_range);
 	} else {
-		tmp = mp_parse_range_string(argv[option_char++]);
-	}
+		printf("Warning threshold missing\n");
+		print_usage();
+		exit(STATE_UNKNOWN);
+		}
+
 	if (tmp.error == MP_PARSING_SUCCES) {
 		result.config.thresholds.warning = tmp.range;
 		result.config.thresholds.warning_is_set = true;
@@ -228,8 +231,11 @@ check_users_config_wrapper process_arguments(int argc, char **argv) {
 	if (critical_range) {
 		tmp = mp_parse_range_string(critical_range);
 	} else {
-		tmp = mp_parse_range_string(argv[option_char++]);
+		printf("Critical threshold missing\n");
+		print_usage();
+		exit(STATE_UNKNOWN);
 	}
+
 	if (tmp.error == MP_PARSING_SUCCES) {
 		result.config.thresholds.critical = tmp.range;
 		result.config.thresholds.critical_is_set = true;
-- 
cgit v1.2.3-74-g34f1