[Nagiosplug-devel] [ nagiosplug-Bugs-1523748 ] check_disk should error if warn range is subset of critical

[SourceForge.net]

Bugs item #1523748, was opened at 2006-07-17 10:37
Message generated for change (Comment added) made by tonvoon
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1523748&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Pending
Resolution: None
Priority: 5
Private: No
Submitted By: Dick van den Burg (vandenburgd)
Assigned to: Ton Voon (tonvoon)
Summary: check_disk should error if warn range is subset of critical

Initial Comment:
the new se->w_idfp and se->c_idfp in version 1.4.3 are
not initialized resulting in the following error (on
HP-UX 11.23)

check_disk -c 5% -w 10%  -p /dev/vg00/lvol1
INPUT ERROR: C_IDFP (0.000000) should be less than
W_IDFP
(64768802081573470261722606760322190900000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000.0)
and both should be between zero and 100 percent,
inclusive for /dev/vg00/lvol1
check_disk: Could not parse arguments
Usage: check_disk -w limit -c limit [-p path | -x
device] [-t timeout][-m] [-e] [-W limit] [-K limit]
[-v] [-q]
The following patch corrects this

*** check_disk.c        Mon Jul 17 11:32:26 2006
--- check_disk.c.good   Mon Jul 17 11:32:03 2006
***************
*** 462,467 ****
--- 462,469 ----
        se->c_df = c_df;
        se->w_dfp = w_dfp;
        se->c_dfp = c_dfp;
+       se->w_idfp = w_idfp;
+       se->c_idfp = c_idfp;
        se->found = 0;
        se->found_len = 0;
        *pathtail = se;



----------------------------------------------------------------------

>Comment By: Ton Voon (tonvoon)
Date: 2007-06-11 10:13

Message:
Logged In: YES 
user_id=664364
Originator: NO

Matthias,

Sorry, I should have put some more details in here. Dick's original query
was because check_disk used to give an error if the range values did not
"make sense" - ie, "./check_disk 0 200" (200% free?) and "./check_disk -w
10% -c 15%" (warn if less than 10%, but critical if less than 15% means
warn will neven happen). The changes I made a few months ago for range
values does not do any validation for the input values.

There are some TODO tests in check_disk.t for invalid values and invalid
percent figures - I think these are what Dick would like fixed.

I'm unsure how general these cases are. Should you always flag an UNKNOWN
state if the warning range is completely within the critical range? Should
you check values for data types such as percentages (of course, it is
possible to get something as 200% of a previous value...).

Matthias, this is probably a good conversation for the mailing list if you
want to drive.

Ton

----------------------------------------------------------------------

Comment By: Matthias Eble (psychotrahe)
Date: 2007-06-11 09:21

Message:
Logged In: YES 
user_id=1694341
Originator: NO

Announced pending state by sending emails to vandenburgd.
Unfortunately the mail couldn't be delivered. Yet setting to pending.

----------------------------------------------------------------------

Comment By: Matthias Eble (psychotrahe)
Date: 2007-05-10 17:52

Message:
Logged In: YES 
user_id=1694341
Originator: NO

what do you mean with "consistency check"?

matthias

----------------------------------------------------------------------

Comment By: Dick van den Burg (vandenburgd)
Date: 2006-07-17 16:46

Message:
Logged In: YES 
user_id=780242

As the changes in CURRENT deleted every reference to w_idfp
and c_idfp the error also disappears. Unfortunately the
consistency check also dispappeared.

Dick

----------------------------------------------------------------------

Comment By: Ton Voon (tonvoon)
Date: 2006-07-17 11:27

Message:
Logged In: YES 
user_id=664364

Dick,

Can you try the snapshot at http://nagiosplug.sourceforge.net/snapshot.
There 
have been fixes to check_disk recently. Please update if there is still a
problem.

I've marked the call in pending so it will autoclose in 7 days.

Ton

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=1523748&group_id=29880