[Nagiosplug-devel] [ nagiosplug-Bugs-1181554 ] 1.4-3: Bug incheck_tcp

[Matthias Eble]

> I believe all we want to change is:
> 
>                 printf("|%s",
>                                 fperfdata ("time", elapsed_time, "s",
>                                 TRUE, warning_time,
>                                 TRUE, critical_time,
>                                 TRUE, 0,
>                                 TRUE, socket_timeout)
> 
> To something like this:
> 
>                 printf("|%s",
>                                 fperfdata ("time", elapsed_time, "s",
>                                 (warning_time > 0 ? TRUE : FALSE),
>                                 warning_time,
>                                 (critical_time > 0 ? TRUE : FALSE),
>                                 critical_time,
>                                 TRUE, 0,
>                                 TRUE, socket_timeout)
> 
> Basically don't tell fperfdata that there is a warn/crit parameter if
> there's none.
That was my intention, too, except that i used the flags 
FLAG_TIME_WARN/CRIT istead of >0. I think that's what the flags are good 
for (I checked it in a few minutes ago).

> At the same time I could review all of them to make sure there's no other
> plugins with optional thresholds that hard-code the parameter.
> 
I don't know if this is worth the time, because there were discussions 
about major changes in the perfdata part - That's the reason why I'm 
usually ignoring performance data items in the bug tracker at the moment.

But I don't wanna stop you, if you like to do it :)

Matthias