[Nagiosplug-devel] [ nagiosplug-Bugs-1181554 ] 1.4-3: Bug incheck_tcp

[Matthias Eble]

> I looked at your commit and I still have one comment. Where the
> thresholds are hard-coded (0), I'd either use the real thresholds
> (actually remove teh if/else) or always set the parameter as FALSE. It's
> the same thing as the other place; either print a real threshold or
> print nothing, but we shouldn't always print 0.
yes, i stumbled over this, too and set it to my "wanna ask on the 
mailing list" list. I let it that way because I thought the comment 
above the code block must somehow have a reason. So I kept the old 
behavior for backward compatibility and changed only the part I 
definitely knew about.

> I believe the original idea was to be able to "know" the state of the
> service by using the perfdata. This isn't consistent anymore now you
> test for the flag, and IMHO reverting to the old behavior for match==-2
> is a hack; the perfdata isn't proper way to deduct services status*.
If it is like that, fine. Then we can kick out the entire if/else block.

> Many thanks Matthias; your work on the tracker items is greatly appreciated!

Thank you. I hope we can get it clean some time. To me actively 
maintaining the tracker is the best way to say thanks to all the people 
reporting problems. If they don't get responses on their items they 
might not post their reports in the future.

Matthias